[INFO] cloning repository https://github.com/Ewwii-sh/eiipm [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Ewwii-sh/eiipm" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEwwii-sh%2Feiipm", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEwwii-sh%2Feiipm'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 01db16d6dbef9b3f777543e61e00f34ed9cdfc8c [INFO] linting Ewwii-sh/eiipm against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEwwii-sh%2Feiipm" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Ewwii-sh/eiipm [INFO] finished tweaking git repo https://github.com/Ewwii-sh/eiipm [INFO] tweaked toml for git repo https://github.com/Ewwii-sh/eiipm written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Ewwii-sh/eiipm on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Ewwii-sh/eiipm already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 344b7110adb4b158b0f7c5c1d9092a1cd9ca585497e0bb1c34ab545062a0684d [INFO] running `Command { std: "docker" "start" "-a" "344b7110adb4b158b0f7c5c1d9092a1cd9ca585497e0bb1c34ab545062a0684d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "344b7110adb4b158b0f7c5c1d9092a1cd9ca585497e0bb1c34ab545062a0684d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "344b7110adb4b158b0f7c5c1d9092a1cd9ca585497e0bb1c34ab545062a0684d", kill_on_drop: false }` [INFO] [stdout] 344b7110adb4b158b0f7c5c1d9092a1cd9ca585497e0bb1c34ab545062a0684d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 846b1cdb2fa07b3f48a2582c14743e21a0f2022d040314c37698be2c6dc1a3a0 [INFO] running `Command { std: "docker" "start" "-a" "846b1cdb2fa07b3f48a2582c14743e21a0f2022d040314c37698be2c6dc1a3a0", kill_on_drop: false }` [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling jobserver v0.1.33 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling cc v1.2.32 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling serde_json v1.0.142 [INFO] [stderr] Checking indexmap v2.10.0 [INFO] [stderr] Compiling clap_derive v4.5.41 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking clap_builder v4.5.43 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking serde_spanned v1.0.0 [INFO] [stderr] Compiling openssl-sys v0.9.109 [INFO] [stderr] Compiling libz-sys v1.1.22 [INFO] [stderr] Compiling libssh2-sys v0.3.1 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Compiling libgit2-sys v0.18.2+1.9.1 [INFO] [stderr] Compiling openssl v0.10.73 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking toml_datetime v0.7.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Checking clap v4.5.43 [INFO] [stderr] Checking toml v0.9.5 [INFO] [stderr] Checking dirs v6.0.0 [INFO] [stderr] Checking colored v3.0.0 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking hyper-util v0.1.16 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.22 [INFO] [stderr] Checking git2 v0.20.2 [INFO] [stderr] Checking eiipm v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/functions/install.rs:130:17 [INFO] [stdout] | [INFO] [stdout] 130 | installed_files: installed_files, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `installed_files` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/functions/mod.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | use dirs; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/functions/install.rs:130:17 [INFO] [stdout] | [INFO] [stdout] 130 | installed_files: installed_files, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `installed_files` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/functions/mod.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | use dirs; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/checkupdate.rs:13:52 [INFO] [stdout] | [INFO] [stdout] 13 | let need_update = is_update_needed_for(&name)?; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/checkupdate.rs:25:52 [INFO] [stdout] | [INFO] [stdout] 25 | let need_update = is_update_needed_for(&name)?; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/functions/install.rs:124:8 [INFO] [stdout] | [INFO] [stdout] 124 | if !(meta.pkg_type == "theme") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(meta.pkg_type != "theme")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/functions/install.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | / let _repo = update_to_latest(&repo_fs_path, &meta.commit_hash, 1) [INFO] [stdout] 51 | | .map_err(|e| format!("Failed to fetch commit and clean state: {}", e))?; [INFO] [stdout] | |____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 50 - let _repo = update_to_latest(&repo_fs_path, &meta.commit_hash, 1) [INFO] [stdout] 50 + update_to_latest(&repo_fs_path, &meta.commit_hash, 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `info!` args [INFO] [stdout] --> src/functions/search.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | / info!( [INFO] [stdout] 27 | | "{}", [INFO] [stdout] 28 | | format!( [INFO] [stdout] 29 | | "\n--- Metadata for '{}' ---\n{}", [INFO] [stdout] ... | [INFO] [stdout] 33 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `info!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `info!` args [INFO] [stdout] --> src/functions/search.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | / info!( [INFO] [stdout] 37 | | "{}", [INFO] [stdout] 38 | | format!("Package '{}' not found.", package_name.red().bold()) [INFO] [stdout] 39 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `info!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/update.rs:29:56 [INFO] [stdout] | [INFO] [stdout] 29 | let need_update = is_update_needed_for(&name)?; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/update.rs:32:38 [INFO] [stdout] | [INFO] [stdout] 32 | update_file(pkg, &name, need_update.1)?; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/update.rs:55:52 [INFO] [stdout] | [INFO] [stdout] 55 | let need_update = is_update_needed_for(&name)?; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/update.rs:58:34 [INFO] [stdout] | [INFO] [stdout] 58 | update_file(pkg, &name, need_update.1)?; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/functions/update.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | / let _repo = update_to_latest(&repo_fs_path, &commit_hash, 1) [INFO] [stdout] 92 | | .map_err(|e| format!("Failed to fetch commit and clean state: {}", e))?; [INFO] [stdout] | |____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 91 - let _repo = update_to_latest(&repo_fs_path, &commit_hash, 1) [INFO] [stdout] 91 + update_to_latest(&repo_fs_path, &commit_hash, 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | let user_confirmed: bool; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `user_confirmed` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 60 ~ [INFO] [stdout] 61 | [INFO] [stdout] 62 ~ let user_confirmed: bool = if !flags.force { [INFO] [stdout] 63 ~ confirm(&question) [INFO] [stdout] 64 | } else { [INFO] [stdout] 65 ~ true [INFO] [stdout] 66 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/checkupdate.rs:13:52 [INFO] [stdout] | [INFO] [stdout] 13 | let need_update = is_update_needed_for(&name)?; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/checkupdate.rs:25:52 [INFO] [stdout] | [INFO] [stdout] 25 | let need_update = is_update_needed_for(&name)?; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/functions/install.rs:124:8 [INFO] [stdout] | [INFO] [stdout] 124 | if !(meta.pkg_type == "theme") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(meta.pkg_type != "theme")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/functions/install.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | / let _repo = update_to_latest(&repo_fs_path, &meta.commit_hash, 1) [INFO] [stdout] 51 | | .map_err(|e| format!("Failed to fetch commit and clean state: {}", e))?; [INFO] [stdout] | |____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 50 - let _repo = update_to_latest(&repo_fs_path, &meta.commit_hash, 1) [INFO] [stdout] 50 + update_to_latest(&repo_fs_path, &meta.commit_hash, 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `info!` args [INFO] [stdout] --> src/functions/search.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | / info!( [INFO] [stdout] 27 | | "{}", [INFO] [stdout] 28 | | format!( [INFO] [stdout] 29 | | "\n--- Metadata for '{}' ---\n{}", [INFO] [stdout] ... | [INFO] [stdout] 33 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `info!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `info!` args [INFO] [stdout] --> src/functions/search.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | / info!( [INFO] [stdout] 37 | | "{}", [INFO] [stdout] 38 | | format!("Package '{}' not found.", package_name.red().bold()) [INFO] [stdout] 39 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `info!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/update.rs:29:56 [INFO] [stdout] | [INFO] [stdout] 29 | let need_update = is_update_needed_for(&name)?; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/update.rs:32:38 [INFO] [stdout] | [INFO] [stdout] 32 | update_file(pkg, &name, need_update.1)?; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/update.rs:55:52 [INFO] [stdout] | [INFO] [stdout] 55 | let need_update = is_update_needed_for(&name)?; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions/update.rs:58:34 [INFO] [stdout] | [INFO] [stdout] 58 | update_file(pkg, &name, need_update.1)?; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/functions/update.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | / let _repo = update_to_latest(&repo_fs_path, &commit_hash, 1) [INFO] [stdout] 92 | | .map_err(|e| format!("Failed to fetch commit and clean state: {}", e))?; [INFO] [stdout] | |____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 91 - let _repo = update_to_latest(&repo_fs_path, &commit_hash, 1) [INFO] [stdout] 91 + update_to_latest(&repo_fs_path, &commit_hash, 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | let user_confirmed: bool; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `user_confirmed` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 60 ~ [INFO] [stdout] 61 | [INFO] [stdout] 62 ~ let user_confirmed: bool = if !flags.force { [INFO] [stdout] 63 ~ confirm(&question) [INFO] [stdout] 64 | } else { [INFO] [stdout] 65 ~ true [INFO] [stdout] 66 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 20s [INFO] running `Command { std: "docker" "inspect" "846b1cdb2fa07b3f48a2582c14743e21a0f2022d040314c37698be2c6dc1a3a0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "846b1cdb2fa07b3f48a2582c14743e21a0f2022d040314c37698be2c6dc1a3a0", kill_on_drop: false }` [INFO] [stdout] 846b1cdb2fa07b3f48a2582c14743e21a0f2022d040314c37698be2c6dc1a3a0