[INFO] cloning repository https://github.com/EvanMerlock/aoc-2023 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/EvanMerlock/aoc-2023" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEvanMerlock%2Faoc-2023", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEvanMerlock%2Faoc-2023'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0b9923e9cc4fcb8fb3816fbc6896d3a4f2758ed0 [INFO] linting EvanMerlock/aoc-2023 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEvanMerlock%2Faoc-2023" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/EvanMerlock/aoc-2023 [INFO] finished tweaking git repo https://github.com/EvanMerlock/aoc-2023 [INFO] tweaked toml for git repo https://github.com/EvanMerlock/aoc-2023 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/EvanMerlock/aoc-2023 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/EvanMerlock/aoc-2023 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded clap v4.4.10 [INFO] [stderr] Downloaded rust-lapper v1.1.0 [INFO] [stderr] Downloaded clap_builder v4.4.9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d6b15dcce572c6d58d2201c3e910c606ab8d95452c9ec853566c10925581b491 [INFO] running `Command { std: "docker" "start" "-a" "d6b15dcce572c6d58d2201c3e910c606ab8d95452c9ec853566c10925581b491", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d6b15dcce572c6d58d2201c3e910c606ab8d95452c9ec853566c10925581b491", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d6b15dcce572c6d58d2201c3e910c606ab8d95452c9ec853566c10925581b491", kill_on_drop: false }` [INFO] [stdout] d6b15dcce572c6d58d2201c3e910c606ab8d95452c9ec853566c10925581b491 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c24a9bb9b203c148efd1d6af083ecd28e5a8ef16566c583db5a8d95f2ae90bc3 [INFO] running `Command { std: "docker" "start" "-a" "c24a9bb9b203c148efd1d6af083ecd28e5a8ef16566c583db5a8d95f2ae90bc3", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Checking clap_builder v4.4.9 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking rust-lapper v1.1.0 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking clap v4.4.10 [INFO] [stderr] Checking aoc-23 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `Interval` and `Lapper` [INFO] [stdout] --> src/day_five.rs:4:19 [INFO] [stdout] | [INFO] [stdout] 4 | use rust_lapper::{Lapper, Interval}; [INFO] [stdout] | ^^^^^^ ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BufRead`, `BufReader`, `cmp::Ordering`, and `fs::File` [INFO] [stdout] --> src/day_seven/mod.rs:7:16 [INFO] [stdout] | [INFO] [stdout] 7 | use std::{io::{BufReader, BufRead}, fs::File, cmp::Ordering, fmt::Debug}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^ ^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Interval` and `Lapper` [INFO] [stdout] --> src/day_five.rs:4:19 [INFO] [stdout] | [INFO] [stdout] 4 | use rust_lapper::{Lapper, Interval}; [INFO] [stdout] | ^^^^^^ ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BufRead`, `BufReader`, `cmp::Ordering`, and `fs::File` [INFO] [stdout] --> src/day_seven/mod.rs:7:16 [INFO] [stdout] | [INFO] [stdout] 7 | use std::{io::{BufReader, BufRead}, fs::File, cmp::Ordering, fmt::Debug}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^ ^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `locations` is never read [INFO] [stdout] --> src/day_three.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 29 | struct Gear { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 30 | gear_ratio: i64, [INFO] [stdout] 31 | locations: Coordinate [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_unverified_gears` is never used [INFO] [stdout] --> src/day_three.rs:202:8 [INFO] [stdout] | [INFO] [stdout] 156 | impl EngineSchematic { [INFO] [stdout] | -------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 202 | fn get_unverified_gears(&self) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `locations` is never read [INFO] [stdout] --> src/day_three.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 29 | struct Gear { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 30 | gear_ratio: i64, [INFO] [stdout] 31 | locations: Coordinate [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_unverified_gears` is never used [INFO] [stdout] --> src/day_three.rs:202:8 [INFO] [stdout] | [INFO] [stdout] 156 | impl EngineSchematic { [INFO] [stdout] | -------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 202 | fn get_unverified_gears(&self) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/day_seven/question_one.rs:78:1 [INFO] [stdout] | [INFO] [stdout] 78 | / impl PartialOrd for Hand { [INFO] [stdout] 79 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 80 | | match self.ty.partial_cmp(&other.ty) { [INFO] [stdout] 81 | | Some(Ordering::Equal) => { [INFO] [stdout] ... | [INFO] [stdout] 96 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 79 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 80 - match self.ty.partial_cmp(&other.ty) { [INFO] [stdout] 81 - Some(Ordering::Equal) => { [INFO] [stdout] 82 - for (position, my_card) in self.cards.iter().enumerate() { [INFO] [stdout] 83 - let other_card = &other.cards[position]; [INFO] [stdout] 84 - match my_card.partial_cmp(other_card) { [INFO] [stdout] 85 - Some(Ordering::Equal) => { [INFO] [stdout] 86 - continue; [INFO] [stdout] 87 - }, [INFO] [stdout] 88 - ord => return ord, [INFO] [stdout] 89 - } [INFO] [stdout] 90 - } [INFO] [stdout] 91 - None [INFO] [stdout] 92 - } [INFO] [stdout] 93 - ord => ord, [INFO] [stdout] 94 - } [INFO] [stdout] 95 - } [INFO] [stdout] 79 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day_seven/question_one.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | / (card_check[0] == card_check[1] && card_check[1] == card_check[2] && card_check[2] == card_check[3]) [INFO] [stdout] 127 | | || (card_check[1] == card_check[2] && card_check[2] == card_check[3] && card_check[3] == card_check[4]) [INFO] [stdout] | |_______________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 126 - (card_check[0] == card_check[1] && card_check[1] == card_check[2] && card_check[2] == card_check[3]) [INFO] [stdout] 127 - || (card_check[1] == card_check[2] && card_check[2] == card_check[3] && card_check[3] == card_check[4]) [INFO] [stdout] 126 + !(card_check[1] != card_check[2] || card_check[2] != card_check[3] || card_check[0] != card_check[1] && card_check[3] != card_check[4]) [INFO] [stdout] | [INFO] [stdout] 126 - (card_check[0] == card_check[1] && card_check[1] == card_check[2] && card_check[2] == card_check[3]) [INFO] [stdout] 127 - || (card_check[1] == card_check[2] && card_check[2] == card_check[3] && card_check[3] == card_check[4]) [INFO] [stdout] 126 + (card_check[3] == card_check[4] || card_check[0] == card_check[1]) && card_check[2] == card_check[3] && card_check[1] == card_check[2] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day_seven/question_one.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 136 | / ((card_check[0] == card_check[1] && card_check[1] == card_check[2]) && (card_check[3] == card_check[4])) [INFO] [stdout] 137 | | || ((card_check[2] == card_check[3] && card_check[3] == card_check[4]) && (card_check[0] == card_check[1])) [INFO] [stdout] | |___________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 136 - ((card_check[0] == card_check[1] && card_check[1] == card_check[2]) && (card_check[3] == card_check[4])) [INFO] [stdout] 137 - || ((card_check[2] == card_check[3] && card_check[3] == card_check[4]) && (card_check[0] == card_check[1])) [INFO] [stdout] 136 + !(card_check[0] != card_check[1] || card_check[3] != card_check[4] || card_check[1] != card_check[2] && card_check[2] != card_check[3]) [INFO] [stdout] | [INFO] [stdout] 136 - ((card_check[0] == card_check[1] && card_check[1] == card_check[2]) && (card_check[3] == card_check[4])) [INFO] [stdout] 137 - || ((card_check[2] == card_check[3] && card_check[3] == card_check[4]) && (card_check[0] == card_check[1])) [INFO] [stdout] 136 + (card_check[2] == card_check[3] || card_check[1] == card_check[2]) && (card_check[3] == card_check[4]) && card_check[0] == card_check[1] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day_seven/question_one.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | / (card_check[0] == card_check[1] && card_check[1] == card_check[2]) [INFO] [stdout] 147 | | || (card_check[1] == card_check[2] && card_check[2] == card_check[3]) [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 146 - (card_check[0] == card_check[1] && card_check[1] == card_check[2]) [INFO] [stdout] 147 - || (card_check[1] == card_check[2] && card_check[2] == card_check[3]) [INFO] [stdout] 146 + !(card_check[1] != card_check[2] || card_check[0] != card_check[1] && card_check[2] != card_check[3]) [INFO] [stdout] | [INFO] [stdout] 146 - (card_check[0] == card_check[1] && card_check[1] == card_check[2]) [INFO] [stdout] 147 - || (card_check[1] == card_check[2] && card_check[2] == card_check[3]) [INFO] [stdout] 146 + (card_check[2] == card_check[3] || card_check[0] == card_check[1]) && card_check[1] == card_check[2] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/day_seven/question_two.rs:83:1 [INFO] [stdout] | [INFO] [stdout] 83 | / impl PartialOrd for Hand { [INFO] [stdout] 84 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 85 | | match self.ty.partial_cmp(&other.ty) { [INFO] [stdout] 86 | | Some(Ordering::Equal) => { [INFO] [stdout] ... | [INFO] [stdout] 102 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 84 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 85 - match self.ty.partial_cmp(&other.ty) { [INFO] [stdout] 86 - Some(Ordering::Equal) => { [INFO] [stdout] 87 - for (position, my_card) in self.cards.iter().enumerate() { [INFO] [stdout] 88 - let other_card = &other.cards[position]; [INFO] [stdout] 89 - [INFO] [stdout] 90 - match my_card.partial_cmp(other_card) { [INFO] [stdout] 91 - Some(Ordering::Equal) => { [INFO] [stdout] 92 - continue; [INFO] [stdout] 93 - }, [INFO] [stdout] 94 - ord => return ord, [INFO] [stdout] 95 - } [INFO] [stdout] 96 - } [INFO] [stdout] 97 - None [INFO] [stdout] 98 - } [INFO] [stdout] 99 - ord => ord, [INFO] [stdout] 100 - } [INFO] [stdout] 101 - } [INFO] [stdout] 84 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day_seven/question_two.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | / (card_check[0] == card_check[1] && card_check[1] == card_check[2] && card_check[2] == card_check[3]) [INFO] [stdout] 133 | | || (card_check[1] == card_check[2] && card_check[2] == card_check[3] && card_check[3] == card_check[4]) [INFO] [stdout] | |_______________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 132 - (card_check[0] == card_check[1] && card_check[1] == card_check[2] && card_check[2] == card_check[3]) [INFO] [stdout] 133 - || (card_check[1] == card_check[2] && card_check[2] == card_check[3] && card_check[3] == card_check[4]) [INFO] [stdout] 132 + !(card_check[1] != card_check[2] || card_check[2] != card_check[3] || card_check[0] != card_check[1] && card_check[3] != card_check[4]) [INFO] [stdout] | [INFO] [stdout] 132 - (card_check[0] == card_check[1] && card_check[1] == card_check[2] && card_check[2] == card_check[3]) [INFO] [stdout] 133 - || (card_check[1] == card_check[2] && card_check[2] == card_check[3] && card_check[3] == card_check[4]) [INFO] [stdout] 132 + (card_check[3] == card_check[4] || card_check[0] == card_check[1]) && card_check[2] == card_check[3] && card_check[1] == card_check[2] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day_seven/question_two.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | / ((card_check[0] == card_check[1] && card_check[1] == card_check[2]) && (card_check[3] == card_check[4])) [INFO] [stdout] 144 | | || ((card_check[2] == card_check[3] && card_check[3] == card_check[4]) && (card_check[0] == card_check[1])) [INFO] [stdout] | |___________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 143 - ((card_check[0] == card_check[1] && card_check[1] == card_check[2]) && (card_check[3] == card_check[4])) [INFO] [stdout] 144 - || ((card_check[2] == card_check[3] && card_check[3] == card_check[4]) && (card_check[0] == card_check[1])) [INFO] [stdout] 143 + !(card_check[0] != card_check[1] || card_check[3] != card_check[4] || card_check[1] != card_check[2] && card_check[2] != card_check[3]) [INFO] [stdout] | [INFO] [stdout] 143 - ((card_check[0] == card_check[1] && card_check[1] == card_check[2]) && (card_check[3] == card_check[4])) [INFO] [stdout] 144 - || ((card_check[2] == card_check[3] && card_check[3] == card_check[4]) && (card_check[0] == card_check[1])) [INFO] [stdout] 143 + (card_check[2] == card_check[3] || card_check[1] == card_check[2]) && (card_check[3] == card_check[4]) && card_check[0] == card_check[1] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day_seven/question_two.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 154 | / (card_check[0] == card_check[1] && card_check[1] == card_check[2]) [INFO] [stdout] 155 | | || (card_check[1] == card_check[2] && card_check[2] == card_check[3]) [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 154 - (card_check[0] == card_check[1] && card_check[1] == card_check[2]) [INFO] [stdout] 155 - || (card_check[1] == card_check[2] && card_check[2] == card_check[3]) [INFO] [stdout] 154 + !(card_check[1] != card_check[2] || card_check[0] != card_check[1] && card_check[2] != card_check[3]) [INFO] [stdout] | [INFO] [stdout] 154 - (card_check[0] == card_check[1] && card_check[1] == card_check[2]) [INFO] [stdout] 155 - || (card_check[1] == card_check[2] && card_check[2] == card_check[3]) [INFO] [stdout] 154 + (card_check[2] == card_check[3] || card_check[0] == card_check[1]) && card_check[1] == card_check[2] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/day_seven/question_one.rs:78:1 [INFO] [stdout] | [INFO] [stdout] 78 | / impl PartialOrd for Hand { [INFO] [stdout] 79 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 80 | | match self.ty.partial_cmp(&other.ty) { [INFO] [stdout] 81 | | Some(Ordering::Equal) => { [INFO] [stdout] ... | [INFO] [stdout] 96 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 79 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 80 - match self.ty.partial_cmp(&other.ty) { [INFO] [stdout] 81 - Some(Ordering::Equal) => { [INFO] [stdout] 82 - for (position, my_card) in self.cards.iter().enumerate() { [INFO] [stdout] 83 - let other_card = &other.cards[position]; [INFO] [stdout] 84 - match my_card.partial_cmp(other_card) { [INFO] [stdout] 85 - Some(Ordering::Equal) => { [INFO] [stdout] 86 - continue; [INFO] [stdout] 87 - }, [INFO] [stdout] 88 - ord => return ord, [INFO] [stdout] 89 - } [INFO] [stdout] 90 - } [INFO] [stdout] 91 - None [INFO] [stdout] 92 - } [INFO] [stdout] 93 - ord => ord, [INFO] [stdout] 94 - } [INFO] [stdout] 95 - } [INFO] [stdout] 79 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day_seven/question_one.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | / (card_check[0] == card_check[1] && card_check[1] == card_check[2] && card_check[2] == card_check[3]) [INFO] [stdout] 127 | | || (card_check[1] == card_check[2] && card_check[2] == card_check[3] && card_check[3] == card_check[4]) [INFO] [stdout] | |_______________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 126 - (card_check[0] == card_check[1] && card_check[1] == card_check[2] && card_check[2] == card_check[3]) [INFO] [stdout] 127 - || (card_check[1] == card_check[2] && card_check[2] == card_check[3] && card_check[3] == card_check[4]) [INFO] [stdout] 126 + !(card_check[1] != card_check[2] || card_check[2] != card_check[3] || card_check[0] != card_check[1] && card_check[3] != card_check[4]) [INFO] [stdout] | [INFO] [stdout] 126 - (card_check[0] == card_check[1] && card_check[1] == card_check[2] && card_check[2] == card_check[3]) [INFO] [stdout] 127 - || (card_check[1] == card_check[2] && card_check[2] == card_check[3] && card_check[3] == card_check[4]) [INFO] [stdout] 126 + (card_check[3] == card_check[4] || card_check[0] == card_check[1]) && card_check[2] == card_check[3] && card_check[1] == card_check[2] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day_seven/question_one.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 136 | / ((card_check[0] == card_check[1] && card_check[1] == card_check[2]) && (card_check[3] == card_check[4])) [INFO] [stdout] 137 | | || ((card_check[2] == card_check[3] && card_check[3] == card_check[4]) && (card_check[0] == card_check[1])) [INFO] [stdout] | |___________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 136 - ((card_check[0] == card_check[1] && card_check[1] == card_check[2]) && (card_check[3] == card_check[4])) [INFO] [stdout] 137 - || ((card_check[2] == card_check[3] && card_check[3] == card_check[4]) && (card_check[0] == card_check[1])) [INFO] [stdout] 136 + !(card_check[0] != card_check[1] || card_check[3] != card_check[4] || card_check[1] != card_check[2] && card_check[2] != card_check[3]) [INFO] [stdout] | [INFO] [stdout] 136 - ((card_check[0] == card_check[1] && card_check[1] == card_check[2]) && (card_check[3] == card_check[4])) [INFO] [stdout] 137 - || ((card_check[2] == card_check[3] && card_check[3] == card_check[4]) && (card_check[0] == card_check[1])) [INFO] [stdout] 136 + (card_check[2] == card_check[3] || card_check[1] == card_check[2]) && (card_check[3] == card_check[4]) && card_check[0] == card_check[1] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day_seven/question_one.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | / (card_check[0] == card_check[1] && card_check[1] == card_check[2]) [INFO] [stdout] 147 | | || (card_check[1] == card_check[2] && card_check[2] == card_check[3]) [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 146 - (card_check[0] == card_check[1] && card_check[1] == card_check[2]) [INFO] [stdout] 147 - || (card_check[1] == card_check[2] && card_check[2] == card_check[3]) [INFO] [stdout] 146 + !(card_check[1] != card_check[2] || card_check[0] != card_check[1] && card_check[2] != card_check[3]) [INFO] [stdout] | [INFO] [stdout] 146 - (card_check[0] == card_check[1] && card_check[1] == card_check[2]) [INFO] [stdout] 147 - || (card_check[1] == card_check[2] && card_check[2] == card_check[3]) [INFO] [stdout] 146 + (card_check[2] == card_check[3] || card_check[0] == card_check[1]) && card_check[1] == card_check[2] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/day_seven/question_two.rs:83:1 [INFO] [stdout] | [INFO] [stdout] 83 | / impl PartialOrd for Hand { [INFO] [stdout] 84 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 85 | | match self.ty.partial_cmp(&other.ty) { [INFO] [stdout] 86 | | Some(Ordering::Equal) => { [INFO] [stdout] ... | [INFO] [stdout] 102 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 84 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 85 - match self.ty.partial_cmp(&other.ty) { [INFO] [stdout] 86 - Some(Ordering::Equal) => { [INFO] [stdout] 87 - for (position, my_card) in self.cards.iter().enumerate() { [INFO] [stdout] 88 - let other_card = &other.cards[position]; [INFO] [stdout] 89 - [INFO] [stdout] 90 - match my_card.partial_cmp(other_card) { [INFO] [stdout] 91 - Some(Ordering::Equal) => { [INFO] [stdout] 92 - continue; [INFO] [stdout] 93 - }, [INFO] [stdout] 94 - ord => return ord, [INFO] [stdout] 95 - } [INFO] [stdout] 96 - } [INFO] [stdout] 97 - None [INFO] [stdout] 98 - } [INFO] [stdout] 99 - ord => ord, [INFO] [stdout] 100 - } [INFO] [stdout] 101 - } [INFO] [stdout] 84 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day_seven/question_two.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | / (card_check[0] == card_check[1] && card_check[1] == card_check[2] && card_check[2] == card_check[3]) [INFO] [stdout] 133 | | || (card_check[1] == card_check[2] && card_check[2] == card_check[3] && card_check[3] == card_check[4]) [INFO] [stdout] | |_______________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 132 - (card_check[0] == card_check[1] && card_check[1] == card_check[2] && card_check[2] == card_check[3]) [INFO] [stdout] 133 - || (card_check[1] == card_check[2] && card_check[2] == card_check[3] && card_check[3] == card_check[4]) [INFO] [stdout] 132 + !(card_check[1] != card_check[2] || card_check[2] != card_check[3] || card_check[0] != card_check[1] && card_check[3] != card_check[4]) [INFO] [stdout] | [INFO] [stdout] 132 - (card_check[0] == card_check[1] && card_check[1] == card_check[2] && card_check[2] == card_check[3]) [INFO] [stdout] 133 - || (card_check[1] == card_check[2] && card_check[2] == card_check[3] && card_check[3] == card_check[4]) [INFO] [stdout] 132 + (card_check[3] == card_check[4] || card_check[0] == card_check[1]) && card_check[2] == card_check[3] && card_check[1] == card_check[2] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day_seven/question_two.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | / ((card_check[0] == card_check[1] && card_check[1] == card_check[2]) && (card_check[3] == card_check[4])) [INFO] [stdout] 144 | | || ((card_check[2] == card_check[3] && card_check[3] == card_check[4]) && (card_check[0] == card_check[1])) [INFO] [stdout] | |___________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 143 - ((card_check[0] == card_check[1] && card_check[1] == card_check[2]) && (card_check[3] == card_check[4])) [INFO] [stdout] 144 - || ((card_check[2] == card_check[3] && card_check[3] == card_check[4]) && (card_check[0] == card_check[1])) [INFO] [stdout] 143 + !(card_check[0] != card_check[1] || card_check[3] != card_check[4] || card_check[1] != card_check[2] && card_check[2] != card_check[3]) [INFO] [stdout] | [INFO] [stdout] 143 - ((card_check[0] == card_check[1] && card_check[1] == card_check[2]) && (card_check[3] == card_check[4])) [INFO] [stdout] 144 - || ((card_check[2] == card_check[3] && card_check[3] == card_check[4]) && (card_check[0] == card_check[1])) [INFO] [stdout] 143 + (card_check[2] == card_check[3] || card_check[1] == card_check[2]) && (card_check[3] == card_check[4]) && card_check[0] == card_check[1] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day_seven/question_two.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 154 | / (card_check[0] == card_check[1] && card_check[1] == card_check[2]) [INFO] [stdout] 155 | | || (card_check[1] == card_check[2] && card_check[2] == card_check[3]) [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 154 - (card_check[0] == card_check[1] && card_check[1] == card_check[2]) [INFO] [stdout] 155 - || (card_check[1] == card_check[2] && card_check[2] == card_check[3]) [INFO] [stdout] 154 + !(card_check[1] != card_check[2] || card_check[0] != card_check[1] && card_check[2] != card_check[3]) [INFO] [stdout] | [INFO] [stdout] 154 - (card_check[0] == card_check[1] && card_check[1] == card_check[2]) [INFO] [stdout] 155 - || (card_check[1] == card_check[2] && card_check[2] == card_check[3]) [INFO] [stdout] 154 + (card_check[2] == card_check[3] || card_check[0] == card_check[1]) && card_check[1] == card_check[2] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.28s [INFO] running `Command { std: "docker" "inspect" "c24a9bb9b203c148efd1d6af083ecd28e5a8ef16566c583db5a8d95f2ae90bc3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c24a9bb9b203c148efd1d6af083ecd28e5a8ef16566c583db5a8d95f2ae90bc3", kill_on_drop: false }` [INFO] [stdout] c24a9bb9b203c148efd1d6af083ecd28e5a8ef16566c583db5a8d95f2ae90bc3