[INFO] cloning repository https://github.com/EvanMPutnam/Rust-Advent-of-Code-2024 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/EvanMPutnam/Rust-Advent-of-Code-2024" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEvanMPutnam%2FRust-Advent-of-Code-2024", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEvanMPutnam%2FRust-Advent-of-Code-2024'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ea73fba8262fdab22fe51b18ff24140000a4a95c [INFO] linting EvanMPutnam/Rust-Advent-of-Code-2024 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEvanMPutnam%2FRust-Advent-of-Code-2024" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/EvanMPutnam/Rust-Advent-of-Code-2024 [INFO] finished tweaking git repo https://github.com/EvanMPutnam/Rust-Advent-of-Code-2024 [INFO] tweaked toml for git repo https://github.com/EvanMPutnam/Rust-Advent-of-Code-2024 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/EvanMPutnam/Rust-Advent-of-Code-2024 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/EvanMPutnam/Rust-Advent-of-Code-2024 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1c94eededfc5fb5d2e11a6d4dc58b6217204f398839030868bbdf111b1104937 [INFO] running `Command { std: "docker" "start" "-a" "1c94eededfc5fb5d2e11a6d4dc58b6217204f398839030868bbdf111b1104937", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1c94eededfc5fb5d2e11a6d4dc58b6217204f398839030868bbdf111b1104937", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c94eededfc5fb5d2e11a6d4dc58b6217204f398839030868bbdf111b1104937", kill_on_drop: false }` [INFO] [stdout] 1c94eededfc5fb5d2e11a6d4dc58b6217204f398839030868bbdf111b1104937 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cf41d21f0813c601ee457d9d17e777a2f172913bf60aeba8ba1b1db5c11a4472 [INFO] running `Command { std: "docker" "start" "-a" "cf41d21f0813c601ee457d9d17e777a2f172913bf60aeba8ba1b1db5c11a4472", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking AdventOfCode2024 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: function `solution1` is never used [INFO] [stdout] --> src/problems/dec1/solution.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn solution1(file: &str) -> i128 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solution2` is never used [INFO] [stdout] --> src/problems/dec1/solution.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn solution2(file: &str) -> i128 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Status` is never used [INFO] [stdout] --> src/problems/dec2/solution.rs:5:6 [INFO] [stdout] | [INFO] [stdout] 5 | enum Status { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_line_valid` is never used [INFO] [stdout] --> src/problems/dec2/solution.rs:12:4 [INFO] [stdout] | [INFO] [stdout] 12 | fn is_line_valid(values: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solution1` is never used [INFO] [stdout] --> src/problems/dec2/solution.rs:46:8 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn solution1(file: &str) -> i128 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `process_vectors_with_missing_elements` is never used [INFO] [stdout] --> src/problems/dec2/solution.rs:63:8 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn process_vectors_with_missing_elements(vec: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solution2` is never used [INFO] [stdout] --> src/problems/dec2/solution.rs:81:8 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn solution2(file: &str) -> i128 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `process_mult_instruction` is never used [INFO] [stdout] --> src/problems/dec3/solution.rs:4:4 [INFO] [stdout] | [INFO] [stdout] 4 | fn process_mult_instruction(value: &str) -> i128 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solution1` is never used [INFO] [stdout] --> src/problems/dec3/solution.rs:23:8 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn solution1(file: &str) -> i128 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solution2` is never used [INFO] [stdout] --> src/problems/dec3/solution.rs:36:8 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn solution2(file: &str) -> i128 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ChristmasData` is never constructed [INFO] [stdout] --> src/problems/dec4/solution.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | struct ChristmasData { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `create_christmas_data` is never used [INFO] [stdout] --> src/problems/dec4/solution.rs:9:4 [INFO] [stdout] | [INFO] [stdout] 9 | fn create_christmas_data(file: &str) -> ChristmasData { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `xy_index` is never used [INFO] [stdout] --> src/problems/dec4/solution.rs:29:4 [INFO] [stdout] | [INFO] [stdout] 29 | fn xy_index(x: usize, y: usize, width: usize) -> usize { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `valid_sequence` is never used [INFO] [stdout] --> src/problems/dec4/solution.rs:33:4 [INFO] [stdout] | [INFO] [stdout] 33 | fn valid_sequence(first: char, second: char, third: char, fourth: char) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `check_mas` is never used [INFO] [stdout] --> src/problems/dec4/solution.rs:37:4 [INFO] [stdout] | [INFO] [stdout] 37 | fn check_mas( [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solution` is never used [INFO] [stdout] --> src/problems/dec4/solution.rs:69:8 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn solution(file: &str) -> i32 { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `check_backwards` is never used [INFO] [stdout] --> src/problems/dec4/solution.rs:93:4 [INFO] [stdout] | [INFO] [stdout] 93 | fn check_backwards(christmas_data: &ChristmasData, start_x: i64, start_y: i64) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `check_above` is never used [INFO] [stdout] --> src/problems/dec4/solution.rs:120:4 [INFO] [stdout] | [INFO] [stdout] 120 | fn check_above(christmas_data: &ChristmasData, start_x: i64, start_y: i64) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `check_forwards` is never used [INFO] [stdout] --> src/problems/dec4/solution.rs:148:4 [INFO] [stdout] | [INFO] [stdout] 148 | fn check_forwards(christmas_data: &ChristmasData, start_x: i64, start_y: i64) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `check_mas2` is never used [INFO] [stdout] --> src/problems/dec4/solution.rs:194:4 [INFO] [stdout] | [INFO] [stdout] 194 | fn check_mas2(christmas_data: &ChristmasData, start_x: i64, start_y: i64) -> i32 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solution2` is never used [INFO] [stdout] --> src/problems/dec4/solution.rs:214:8 [INFO] [stdout] | [INFO] [stdout] 214 | pub fn solution2(file: &str) -> i32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/problems/dec2/solution.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | difference < 0 && difference >= -3 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(-3..0).contains(&difference)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/problems/dec2/solution.rs:63:51 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn process_vectors_with_missing_elements(vec: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 63 - pub fn process_vectors_with_missing_elements(vec: &Vec) -> bool { [INFO] [stdout] 63 + pub fn process_vectors_with_missing_elements(vec: &[i128]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i2` is used to index `vec` [INFO] [stdout] --> src/problems/dec2/solution.rs:66:19 [INFO] [stdout] | [INFO] [stdout] 66 | for i2 in 0..vec.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 66 - for i2 in 0..vec.len() { [INFO] [stdout] 66 + for (i2, ) in vec.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `pieces.get(0)` [INFO] [stdout] --> src/problems/dec3/solution.rs:6:23 [INFO] [stdout] | [INFO] [stdout] 6 | let left_value = *pieces [INFO] [stdout] | _______________________^ [INFO] [stdout] 7 | | .get(0) [INFO] [stdout] | |_______________^ help: try: `pieces.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `pieces [INFO] [stdout] .get(1) [INFO] [stdout] .unwrap() [INFO] [stdout] .split(')') [INFO] [stdout] .collect::>().get(0)` [INFO] [stdout] --> src/problems/dec3/solution.rs:13:24 [INFO] [stdout] | [INFO] [stdout] 13 | let right_value = *pieces [INFO] [stdout] | ________________________^ [INFO] [stdout] 14 | | .get(1) [INFO] [stdout] 15 | | .unwrap() [INFO] [stdout] 16 | | .split(')') [INFO] [stdout] 17 | | .collect::>() [INFO] [stdout] 18 | | .get(0) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 13 ~ let right_value = *pieces [INFO] [stdout] 14 + .get(1) [INFO] [stdout] 15 + .unwrap() [INFO] [stdout] 16 + .split(')') [INFO] [stdout] 17 + .collect::>().first() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/problems/dec4/solution.rs:200:8 [INFO] [stdout] | [INFO] [stdout] 200 | if !(start_x + 2 < christmas_data.x_dim as i64) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(start_x + 2 >= christmas_data.x_dim as i64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/problems/dec4/solution.rs:197:34 [INFO] [stdout] | [INFO] [stdout] 197 | count += check_backwards(&christmas_data, start_x, start_y); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `christmas_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/problems/dec4/solution.rs:205:33 [INFO] [stdout] | [INFO] [stdout] 205 | count += check_forwards(&christmas_data, start_x, start_y); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `christmas_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/problems/dec4/solution.rs:209:30 [INFO] [stdout] | [INFO] [stdout] 209 | count += check_above(&christmas_data, start_x, start_y) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `christmas_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/problems/dec2/solution.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | difference < 0 && difference >= -3 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(-3..0).contains(&difference)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/problems/dec2/solution.rs:63:51 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn process_vectors_with_missing_elements(vec: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 63 - pub fn process_vectors_with_missing_elements(vec: &Vec) -> bool { [INFO] [stdout] 63 + pub fn process_vectors_with_missing_elements(vec: &[i128]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i2` is used to index `vec` [INFO] [stdout] --> src/problems/dec2/solution.rs:66:19 [INFO] [stdout] | [INFO] [stdout] 66 | for i2 in 0..vec.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 66 - for i2 in 0..vec.len() { [INFO] [stdout] 66 + for (i2, ) in vec.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `pieces.get(0)` [INFO] [stdout] --> src/problems/dec3/solution.rs:6:23 [INFO] [stdout] | [INFO] [stdout] 6 | let left_value = *pieces [INFO] [stdout] | _______________________^ [INFO] [stdout] 7 | | .get(0) [INFO] [stdout] | |_______________^ help: try: `pieces.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `pieces [INFO] [stdout] .get(1) [INFO] [stdout] .unwrap() [INFO] [stdout] .split(')') [INFO] [stdout] .collect::>().get(0)` [INFO] [stdout] --> src/problems/dec3/solution.rs:13:24 [INFO] [stdout] | [INFO] [stdout] 13 | let right_value = *pieces [INFO] [stdout] | ________________________^ [INFO] [stdout] 14 | | .get(1) [INFO] [stdout] 15 | | .unwrap() [INFO] [stdout] 16 | | .split(')') [INFO] [stdout] 17 | | .collect::>() [INFO] [stdout] 18 | | .get(0) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 13 ~ let right_value = *pieces [INFO] [stdout] 14 + .get(1) [INFO] [stdout] 15 + .unwrap() [INFO] [stdout] 16 + .split(')') [INFO] [stdout] 17 + .collect::>().first() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/problems/dec4/solution.rs:200:8 [INFO] [stdout] | [INFO] [stdout] 200 | if !(start_x + 2 < christmas_data.x_dim as i64) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(start_x + 2 >= christmas_data.x_dim as i64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/problems/dec4/solution.rs:197:34 [INFO] [stdout] | [INFO] [stdout] 197 | count += check_backwards(&christmas_data, start_x, start_y); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `christmas_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/problems/dec4/solution.rs:205:33 [INFO] [stdout] | [INFO] [stdout] 205 | count += check_forwards(&christmas_data, start_x, start_y); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `christmas_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/problems/dec4/solution.rs:209:30 [INFO] [stdout] | [INFO] [stdout] 209 | count += check_above(&christmas_data, start_x, start_y) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `christmas_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.77s [INFO] running `Command { std: "docker" "inspect" "cf41d21f0813c601ee457d9d17e777a2f172913bf60aeba8ba1b1db5c11a4472", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cf41d21f0813c601ee457d9d17e777a2f172913bf60aeba8ba1b1db5c11a4472", kill_on_drop: false }` [INFO] [stdout] cf41d21f0813c601ee457d9d17e777a2f172913bf60aeba8ba1b1db5c11a4472