[INFO] cloning repository https://github.com/ErikPeter2000/rust_web_crawler [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ErikPeter2000/rust_web_crawler" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FErikPeter2000%2Frust_web_crawler", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FErikPeter2000%2Frust_web_crawler'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a7bf039750b75aacff21a87c5a6bd65f1ce6c29f [INFO] linting ErikPeter2000/rust_web_crawler against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FErikPeter2000%2Frust_web_crawler" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ErikPeter2000/rust_web_crawler [INFO] finished tweaking git repo https://github.com/ErikPeter2000/rust_web_crawler [INFO] tweaked toml for git repo https://github.com/ErikPeter2000/rust_web_crawler written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ErikPeter2000/rust_web_crawler on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ErikPeter2000/rust_web_crawler already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded clap v4.5.38 [INFO] [stderr] Downloaded jiff-static v0.2.13 [INFO] [stderr] Downloaded clap_builder v4.5.38 [INFO] [stderr] Downloaded rusqlite v0.33.0 [INFO] [stderr] Downloaded jiff v0.2.13 [INFO] [stderr] Downloaded libsqlite3-sys v0.31.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 11153ce61b120efb5307051668ff37e6ed622613b14e198f54c06ec203b3f130 [INFO] running `Command { std: "docker" "start" "-a" "11153ce61b120efb5307051668ff37e6ed622613b14e198f54c06ec203b3f130", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "11153ce61b120efb5307051668ff37e6ed622613b14e198f54c06ec203b3f130", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "11153ce61b120efb5307051668ff37e6ed622613b14e198f54c06ec203b3f130", kill_on_drop: false }` [INFO] [stdout] 11153ce61b120efb5307051668ff37e6ed622613b14e198f54c06ec203b3f130 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cbf51bb913fbae147e8e86ea15db60ec8f85e9c7cbbd688e46a02adc745dcfac [INFO] running `Command { std: "docker" "start" "-a" "cbf51bb913fbae147e8e86ea15db60ec8f85e9c7cbbd688e46a02adc745dcfac", kill_on_drop: false }` [INFO] [stderr] Checking smallvec v1.15.0 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling siphasher v1.0.1 [INFO] [stderr] Compiling syn v2.0.101 [INFO] [stderr] Compiling openssl-sys v0.9.108 [INFO] [stderr] Checking hashbrown v0.15.3 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling icu_properties_data v2.0.0 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling phf_shared v0.11.3 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling openssl v0.10.72 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking mac v0.1.1 [INFO] [stderr] Checking precomputed-hash v0.1.1 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking futf v0.1.5 [INFO] [stderr] Checking dtoa v1.0.10 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking indexmap v2.9.0 [INFO] [stderr] Checking tendril v0.4.3 [INFO] [stderr] Checking dtoa-short v0.3.5 [INFO] [stderr] Compiling phf_generator v0.11.3 [INFO] [stderr] Compiling libsqlite3-sys v0.31.0 [INFO] [stderr] Compiling phf_codegen v0.11.3 [INFO] [stderr] Compiling string_cache_codegen v0.5.4 [INFO] [stderr] Compiling selectors v0.26.0 [INFO] [stderr] Compiling blake3 v1.8.2 [INFO] [stderr] Compiling markup5ever v0.14.1 [INFO] [stderr] Checking servo_arc v0.4.0 [INFO] [stderr] Checking clap_builder v4.5.38 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking rustls-pemfile v2.2.0 [INFO] [stderr] Checking hashlink v0.10.0 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking ego-tree v0.10.0 [INFO] [stderr] Checking jiff v0.2.13 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Checking clap v4.5.38 [INFO] [stderr] Checking string_cache v0.8.9 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling phf_macros v0.11.3 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking phf v0.11.3 [INFO] [stderr] Checking tokio v1.45.0 [INFO] [stderr] Compiling cssparser-macros v0.6.1 [INFO] [stderr] Compiling match_token v0.1.0 [INFO] [stderr] Checking cssparser v0.34.0 [INFO] [stderr] Compiling derive_more v0.99.20 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking zerovec v0.11.2 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking html5ever v0.29.1 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Checking scraper v0.22.0 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.0 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking tokio-util v0.7.15 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking h2 v0.4.10 [INFO] [stderr] Checking rusqlite v0.33.0 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking hyper-util v0.1.11 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.15 [INFO] [stderr] Checking rust_web_crawler v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/crawler.rs:233:13 [INFO] [stdout] | [INFO] [stdout] 233 | &[url.as_str(), &hash], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[url.as_str(), &hash]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/crawler.rs:301:25 [INFO] [stdout] | [INFO] [stdout] 301 | / &[ [INFO] [stdout] 302 | | &domain_id.to_string().as_str(), [INFO] [stdout] 303 | | &disallowed_pattern.as_str(), [INFO] [stdout] 304 | | ], [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 301 ~ [ [INFO] [stdout] 302 + &domain_id.to_string().as_str(), [INFO] [stdout] 303 + &disallowed_pattern.as_str(), [INFO] [stdout] 304 ~ ], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:58:39 [INFO] [stdout] | [INFO] [stdout] 58 | if arguments.get_flag("clean") || !fs::metadata(DB_NAME).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(DB_NAME).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:66:8 [INFO] [stdout] | [INFO] [stdout] 66 | if !Url::parse(&start_url).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Url::parse(&start_url).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:66:20 [INFO] [stdout] | [INFO] [stdout] 66 | if !Url::parse(&start_url).is_ok() { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `start_url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/crawler.rs:233:13 [INFO] [stdout] | [INFO] [stdout] 233 | &[url.as_str(), &hash], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[url.as_str(), &hash]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/crawler.rs:301:25 [INFO] [stdout] | [INFO] [stdout] 301 | / &[ [INFO] [stdout] 302 | | &domain_id.to_string().as_str(), [INFO] [stdout] 303 | | &disallowed_pattern.as_str(), [INFO] [stdout] 304 | | ], [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 301 ~ [ [INFO] [stdout] 302 + &domain_id.to_string().as_str(), [INFO] [stdout] 303 + &disallowed_pattern.as_str(), [INFO] [stdout] 304 ~ ], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:58:39 [INFO] [stdout] | [INFO] [stdout] 58 | if arguments.get_flag("clean") || !fs::metadata(DB_NAME).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(DB_NAME).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:66:8 [INFO] [stdout] | [INFO] [stdout] 66 | if !Url::parse(&start_url).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Url::parse(&start_url).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:66:20 [INFO] [stdout] | [INFO] [stdout] 66 | if !Url::parse(&start_url).is_ok() { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `start_url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 03s [INFO] running `Command { std: "docker" "inspect" "cbf51bb913fbae147e8e86ea15db60ec8f85e9c7cbbd688e46a02adc745dcfac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cbf51bb913fbae147e8e86ea15db60ec8f85e9c7cbbd688e46a02adc745dcfac", kill_on_drop: false }` [INFO] [stdout] cbf51bb913fbae147e8e86ea15db60ec8f85e9c7cbbd688e46a02adc745dcfac