[INFO] cloning repository https://github.com/EricFrancis12/ds [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/EricFrancis12/ds" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEricFrancis12%2Fds", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEricFrancis12%2Fds'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 550061a9cdebb17990d40c4b10bec89ea586a690 [INFO] linting EricFrancis12/ds against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEricFrancis12%2Fds" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/EricFrancis12/ds [INFO] finished tweaking git repo https://github.com/EricFrancis12/ds [INFO] tweaked toml for git repo https://github.com/EricFrancis12/ds written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/EricFrancis12/ds on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/EricFrancis12/ds already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded unit-prefix v0.5.1 [INFO] [stderr] Downloaded console v0.16.0 [INFO] [stderr] Downloaded indicatif v0.18.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e282c1b2ad19b7c4a0ecd313c7b3ad2b9ec614c3ad31e5e1d5dfa4df28701120 [INFO] running `Command { std: "docker" "start" "-a" "e282c1b2ad19b7c4a0ecd313c7b3ad2b9ec614c3ad31e5e1d5dfa4df28701120", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e282c1b2ad19b7c4a0ecd313c7b3ad2b9ec614c3ad31e5e1d5dfa4df28701120", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e282c1b2ad19b7c4a0ecd313c7b3ad2b9ec614c3ad31e5e1d5dfa4df28701120", kill_on_drop: false }` [INFO] [stdout] e282c1b2ad19b7c4a0ecd313c7b3ad2b9ec614c3ad31e5e1d5dfa4df28701120 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 64873b2d0e9ad25a0b245f12da0b1cfa625b833cd04d5fc652df3a1d2d293908 [INFO] running `Command { std: "docker" "start" "-a" "64873b2d0e9ad25a0b245f12da0b1cfa625b833cd04d5fc652df3a1d2d293908", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling portable-atomic v1.11.1 [INFO] [stderr] Compiling rustix v1.0.8 [INFO] [stderr] Checking bstr v1.12.0 [INFO] [stderr] Checking unit-prefix v0.5.1 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Checking signal-hook-registry v1.4.5 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking console v0.16.0 [INFO] [stderr] Checking signal-hook v0.3.18 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking indicatif v0.18.0 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Compiling derive_more-impl v2.0.1 [INFO] [stderr] Compiling clap_derive v4.5.41 [INFO] [stderr] Checking globset v0.4.16 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking derive_more v2.0.1 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Checking clap v4.5.41 [INFO] [stderr] Checking ds v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/filter.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/filter.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 182 | if !(actual_min < actual_max) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(actual_min >= actual_max)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cli.rs:255:31 [INFO] [stdout] | [INFO] [stdout] 255 | builder.add(Glob::new(&s)?); [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/file_system/read.rs:19:6 [INFO] [stdout] | [INFO] [stdout] 19 | ) -> (Receiver<(FsEntry, Vec)>, Vec>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/file_system/read.rs:23:15 [INFO] [stdout] | [INFO] [stdout] 23 | let sem = match max_threads { [INFO] [stdout] | _______________^ [INFO] [stdout] 24 | | Some(n) => Some(Arc::new(Semaphore::new(n))), [INFO] [stdout] 25 | | None => None, [INFO] [stdout] 26 | | }; [INFO] [stdout] | |_____^ help: try: `max_threads.map(|n| Arc::new(Semaphore::new(n)))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/file_system/read.rs:41:34 [INFO] [stdout] | [INFO] [stdout] 41 | tx.send((fse, errs)).expect(&format!( [INFO] [stdout] | __________________________________^ [INFO] [stdout] 42 | | "Reader thread '{}' failed to send", [INFO] [stdout] 43 | | entry.path().to_string_lossy() [INFO] [stdout] 44 | | )); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 41 ~ tx.send((fse, errs)).unwrap_or_else(|_| panic!("Reader thread '{}' failed to send", [INFO] [stdout] 42 ~ entry.path().to_string_lossy())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/output/chart.rs:60:37 [INFO] [stdout] | [INFO] [stdout] 60 | let name = console::pad_str(&colored_name, max_name_len, console::Alignment::Left, None); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `colored_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/output/summary.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | / pub fn print_summary( [INFO] [stdout] 6 | | dir: impl Into, [INFO] [stdout] 7 | | resolved_dir: impl Into, [INFO] [stdout] 8 | | unit_system: &UnitSystem, [INFO] [stdout] ... | [INFO] [stdout] 16 | | took: Duration, [INFO] [stdout] 17 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/output/summary.rs:36:1 [INFO] [stdout] | [INFO] [stdout] 36 | / pub fn make_summary( [INFO] [stdout] 37 | | dir: impl Into, [INFO] [stdout] 38 | | resolved_dir: impl Into, [INFO] [stdout] 39 | | unit_system: &UnitSystem, [INFO] [stdout] ... | [INFO] [stdout] 47 | | took: Duration, [INFO] [stdout] 48 | | ) -> String { [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:175:22 [INFO] [stdout] | [INFO] [stdout] 175 | Ok(path) => &format!("{}", path.to_str().unwrap_or(&config.dir)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `path.to_str().unwrap_or(&config.dir).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 182 | if !(actual_min < actual_max) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(actual_min >= actual_max)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cli.rs:255:31 [INFO] [stdout] | [INFO] [stdout] 255 | builder.add(Glob::new(&s)?); [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/file_system/read.rs:19:6 [INFO] [stdout] | [INFO] [stdout] 19 | ) -> (Receiver<(FsEntry, Vec)>, Vec>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/file_system/read.rs:23:15 [INFO] [stdout] | [INFO] [stdout] 23 | let sem = match max_threads { [INFO] [stdout] | _______________^ [INFO] [stdout] 24 | | Some(n) => Some(Arc::new(Semaphore::new(n))), [INFO] [stdout] 25 | | None => None, [INFO] [stdout] 26 | | }; [INFO] [stdout] | |_____^ help: try: `max_threads.map(|n| Arc::new(Semaphore::new(n)))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/file_system/read.rs:41:34 [INFO] [stdout] | [INFO] [stdout] 41 | tx.send((fse, errs)).expect(&format!( [INFO] [stdout] | __________________________________^ [INFO] [stdout] 42 | | "Reader thread '{}' failed to send", [INFO] [stdout] 43 | | entry.path().to_string_lossy() [INFO] [stdout] 44 | | )); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 41 ~ tx.send((fse, errs)).unwrap_or_else(|_| panic!("Reader thread '{}' failed to send", [INFO] [stdout] 42 ~ entry.path().to_string_lossy())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/output/chart.rs:60:37 [INFO] [stdout] | [INFO] [stdout] 60 | let name = console::pad_str(&colored_name, max_name_len, console::Alignment::Left, None); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `colored_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/output/summary.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | / pub fn print_summary( [INFO] [stdout] 6 | | dir: impl Into, [INFO] [stdout] 7 | | resolved_dir: impl Into, [INFO] [stdout] 8 | | unit_system: &UnitSystem, [INFO] [stdout] ... | [INFO] [stdout] 16 | | took: Duration, [INFO] [stdout] 17 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/output/summary.rs:36:1 [INFO] [stdout] | [INFO] [stdout] 36 | / pub fn make_summary( [INFO] [stdout] 37 | | dir: impl Into, [INFO] [stdout] 38 | | resolved_dir: impl Into, [INFO] [stdout] 39 | | unit_system: &UnitSystem, [INFO] [stdout] ... | [INFO] [stdout] 47 | | took: Duration, [INFO] [stdout] 48 | | ) -> String { [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:175:22 [INFO] [stdout] | [INFO] [stdout] 175 | Ok(path) => &format!("{}", path.to_str().unwrap_or(&config.dir)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `path.to_str().unwrap_or(&config.dir).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.84s [INFO] running `Command { std: "docker" "inspect" "64873b2d0e9ad25a0b245f12da0b1cfa625b833cd04d5fc652df3a1d2d293908", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "64873b2d0e9ad25a0b245f12da0b1cfa625b833cd04d5fc652df3a1d2d293908", kill_on_drop: false }` [INFO] [stdout] 64873b2d0e9ad25a0b245f12da0b1cfa625b833cd04d5fc652df3a1d2d293908