[INFO] cloning repository https://github.com/EmeraldMastaMC/bjccs
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/EmeraldMastaMC/bjccs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEmeraldMastaMC%2Fbjccs", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEmeraldMastaMC%2Fbjccs'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] e63c7b1a961fc32e24612a043f406cea3df3ceac
[INFO] linting EmeraldMastaMC/bjccs against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEmeraldMastaMC%2Fbjccs" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/EmeraldMastaMC/bjccs
[INFO] finished tweaking git repo https://github.com/EmeraldMastaMC/bjccs
[INFO] tweaked toml for git repo https://github.com/EmeraldMastaMC/bjccs written to /workspace/builds/worker-6-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/EmeraldMastaMC/bjccs on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/EmeraldMastaMC/bjccs already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] warning: unused manifest key: build
[INFO] [stderr] help: build is a valid .cargo/config.toml key
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded proc-macro2 v1.0.92
[INFO] [stderr]   Downloaded syn v2.0.89
[INFO] [stderr]   Downloaded libc v0.2.165
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 2fbbdd41a48c1a21e0311ebd67c09d71573285f01cbb7622fcd50043975b4b88
[INFO] running `Command { std: "docker" "start" "-a" "2fbbdd41a48c1a21e0311ebd67c09d71573285f01cbb7622fcd50043975b4b88", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "2fbbdd41a48c1a21e0311ebd67c09d71573285f01cbb7622fcd50043975b4b88", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "2fbbdd41a48c1a21e0311ebd67c09d71573285f01cbb7622fcd50043975b4b88", kill_on_drop: false }`
[INFO] [stdout] 2fbbdd41a48c1a21e0311ebd67c09d71573285f01cbb7622fcd50043975b4b88
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 5940fe15074bd0b194ac58f35bd734dccf50c7cae3eaa8676a6561ed72697b98
[INFO] running `Command { std: "docker" "start" "-a" "5940fe15074bd0b194ac58f35bd734dccf50c7cae3eaa8676a6561ed72697b98", kill_on_drop: false }`
[INFO] [stderr] warning: unused manifest key: build
[INFO] [stderr] help: build is a valid .cargo/config.toml key
[INFO] [stderr]    Compiling proc-macro2 v1.0.92
[INFO] [stderr]    Compiling libc v0.2.165
[INFO] [stderr]    Compiling quote v1.0.37
[INFO] [stderr]    Compiling syn v2.0.89
[INFO] [stderr]     Checking getrandom v0.2.15
[INFO] [stderr]     Checking rand_core v0.6.4
[INFO] [stderr]    Compiling zerocopy-derive v0.7.35
[INFO] [stderr]     Checking zerocopy v0.7.35
[INFO] [stderr]     Checking ppv-lite86 v0.2.20
[INFO] [stderr]     Checking rand_chacha v0.3.1
[INFO] [stderr]     Checking rand v0.8.5
[INFO] [stderr]     Checking bjccs2 v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: struct `HandCards` has a public `len` method, but no `is_empty` method
[INFO] [stdout]    --> src/cardutils.rs:194:5
[INFO] [stdout]     |
[INFO] [stdout] 194 |     pub fn len(&self) -> usize {
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stdout]     = note: `#[warn(clippy::len_without_is_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (8/7)
[INFO] [stdout]   --> src/gamelogic.rs:18:5
[INFO] [stdout]    |
[INFO] [stdout] 18 | /     pub fn new(
[INFO] [stdout] 19 | |         decks_in_shoe: u8,
[INFO] [stdout] 20 | |         deck_penetration: usize,
[INFO] [stdout] 21 | |         hit_soft_17: bool,
[INFO] [stdout] ...  |
[INFO] [stdout] 26 | |         double_split_aces: bool,
[INFO] [stdout] 27 | |     ) -> Self {
[INFO] [stdout]    | |_____________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout]    = note: `#[warn(clippy::too_many_arguments)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Count`
[INFO] [stdout]   --> src/gamelogic.rs:51:5
[INFO] [stdout]    |
[INFO] [stdout] 51 | /     pub fn new() -> Self {
[INFO] [stdout] 52 | |         Count {
[INFO] [stdout] 53 | |             running_count: 0,
[INFO] [stdout] 54 | |             cards_seen: 0,
[INFO] [stdout] ...  |
[INFO] [stdout] 57 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 49 + impl Default for Count {
[INFO] [stdout] 50 +     fn default() -> Self {
[INFO] [stdout] 51 +         Self::new()
[INFO] [stdout] 52 +     }
[INFO] [stdout] 53 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: struct `HandCards` has a public `len` method, but no `is_empty` method
[INFO] [stdout]    --> src/cardutils.rs:194:5
[INFO] [stdout]     |
[INFO] [stdout] 194 |     pub fn len(&self) -> usize {
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stdout]     = note: `#[warn(clippy::len_without_is_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (8/7)
[INFO] [stdout]   --> src/gamelogic.rs:18:5
[INFO] [stdout]    |
[INFO] [stdout] 18 | /     pub fn new(
[INFO] [stdout] 19 | |         decks_in_shoe: u8,
[INFO] [stdout] 20 | |         deck_penetration: usize,
[INFO] [stdout] 21 | |         hit_soft_17: bool,
[INFO] [stdout] ...  |
[INFO] [stdout] 26 | |         double_split_aces: bool,
[INFO] [stdout] 27 | |     ) -> Self {
[INFO] [stdout]    | |_____________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout]    = note: `#[warn(clippy::too_many_arguments)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/gamelogic.rs:254:43
[INFO] [stdout]     |
[INFO] [stdout] 254 |         (dealer_value == player_value) && !(dealer_value > 21)
[INFO] [stdout]     |                                           ^^^^^^^^^^^^^^^^^^^^ help: try: `(dealer_value <= 21)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Count`
[INFO] [stdout]   --> src/gamelogic.rs:51:5
[INFO] [stdout]    |
[INFO] [stdout] 51 | /     pub fn new() -> Self {
[INFO] [stdout] 52 | |         Count {
[INFO] [stdout] 53 | |             running_count: 0,
[INFO] [stdout] 54 | |             cards_seen: 0,
[INFO] [stdout] ...  |
[INFO] [stdout] 57 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 49 + impl Default for Count {
[INFO] [stdout] 50 +     fn default() -> Self {
[INFO] [stdout] 51 +         Self::new()
[INFO] [stdout] 52 +     }
[INFO] [stdout] 53 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/gamelogic.rs:351:9
[INFO] [stdout]     |
[INFO] [stdout] 351 |         !(splits != 0 && !hit_split_aces)
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `splits == 0 || hit_split_aces`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/gamelogic.rs:254:43
[INFO] [stdout]     |
[INFO] [stdout] 254 |         (dealer_value == player_value) && !(dealer_value > 21)
[INFO] [stdout]     |                                           ^^^^^^^^^^^^^^^^^^^^ help: try: `(dealer_value <= 21)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/gamelogic.rs:351:9
[INFO] [stdout]     |
[INFO] [stdout] 351 |         !(splits != 0 && !hit_split_aces)
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `splits == 0 || hit_split_aces`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.48s
[INFO] running `Command { std: "docker" "inspect" "5940fe15074bd0b194ac58f35bd734dccf50c7cae3eaa8676a6561ed72697b98", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "5940fe15074bd0b194ac58f35bd734dccf50c7cae3eaa8676a6561ed72697b98", kill_on_drop: false }`
[INFO] [stdout] 5940fe15074bd0b194ac58f35bd734dccf50c7cae3eaa8676a6561ed72697b98