[INFO] cloning repository https://github.com/ElusAegis/halo2-fibonacci-sample [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ElusAegis/halo2-fibonacci-sample" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FElusAegis%2Fhalo2-fibonacci-sample", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FElusAegis%2Fhalo2-fibonacci-sample'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4e5f955c936e4c9199a8183152dbad780b10c6d6 [INFO] linting ElusAegis/halo2-fibonacci-sample against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FElusAegis%2Fhalo2-fibonacci-sample" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ElusAegis/halo2-fibonacci-sample [INFO] finished tweaking git repo https://github.com/ElusAegis/halo2-fibonacci-sample [INFO] tweaked toml for git repo https://github.com/ElusAegis/halo2-fibonacci-sample written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ElusAegis/halo2-fibonacci-sample on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ElusAegis/halo2-fibonacci-sample already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating git repository `https://github.com/privacy-scaling-explorations/halo2` [INFO] [stderr] Updating git repository `https://github.com/privacy-scaling-explorations/halo2curves` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded plotters-svg v0.3.6 [INFO] [stderr] Downloaded plotters-bitmap v0.3.6 [INFO] [stderr] Downloaded yeslogic-fontconfig-sys v5.0.0 [INFO] [stderr] Downloaded plotters-backend v0.3.6 [INFO] [stderr] Downloaded cstr v0.2.12 [INFO] [stderr] Downloaded libloading v0.8.4 [INFO] [stderr] Downloaded float-ord v0.3.2 [INFO] [stderr] Downloaded tabbycat v0.1.2 [INFO] [stderr] Downloaded derive_builder_core v0.9.0 [INFO] [stderr] Downloaded font-kit v0.13.2 [INFO] [stderr] Downloaded derive_builder v0.9.0 [INFO] [stderr] Downloaded cc v1.1.0 [INFO] [stderr] Downloaded plotters v0.3.6 [INFO] [stderr] Downloaded syn v2.0.70 [INFO] [stderr] Downloaded freetype-sys v0.20.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b6e0157759963bffa559819ad1f67dbe02c43140b60cd67a68912a8f18eeadf1 [INFO] running `Command { std: "docker" "start" "-a" "b6e0157759963bffa559819ad1f67dbe02c43140b60cd67a68912a8f18eeadf1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b6e0157759963bffa559819ad1f67dbe02c43140b60cd67a68912a8f18eeadf1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b6e0157759963bffa559819ad1f67dbe02c43140b60cd67a68912a8f18eeadf1", kill_on_drop: false }` [INFO] [stdout] b6e0157759963bffa559819ad1f67dbe02c43140b60cd67a68912a8f18eeadf1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a68f6a9c46792425ab505d42286b85218602073b34582f71239d6bcc536ccde2 [INFO] running `Command { std: "docker" "start" "-a" "a68f6a9c46792425ab505d42286b85218602073b34582f71239d6bcc536ccde2", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking constant_time_eq v0.3.0 [INFO] [stderr] Checking arrayref v0.3.7 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling syn v2.0.70 [INFO] [stderr] Compiling halo2curves v0.3.2 (https://github.com/privacy-scaling-explorations/halo2curves?tag=0.3.2#9f5c5081) [INFO] [stderr] Checking block-padding v0.2.1 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Compiling thiserror v1.0.62 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking sha3 v0.9.1 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking blake2b_simd v1.0.2 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking pasta_curves v0.5.1 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.62 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking halo2_proofs v0.2.0 (https://github.com/privacy-scaling-explorations/halo2?tag=v2023_04_20#be955686) [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking halo2-fibonacci v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: using `clone` on type `Fr` which implements the `Copy` trait [INFO] [stdout] --> src/circuit.rs:219:19 [INFO] [stdout] | [INFO] [stdout] 219 | let out: Fr = inputs [INFO] [stdout] | ___________________^ [INFO] [stdout] 220 | | .get("out") [INFO] [stdout] 221 | | .ok_or(FibonacciError( [INFO] [stdout] 222 | | "Failed to get `out` value".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 227 | | ))? [INFO] [stdout] 228 | | .clone(); [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] help: try dereferencing it [INFO] [stdout] | [INFO] [stdout] 219 ~ let out: Fr = *inputs [INFO] [stdout] 220 + .get("out") [INFO] [stdout] 221 + .ok_or(FibonacciError( [INFO] [stdout] 222 + "Failed to get `out` value".to_string(), [INFO] [stdout] 223 + ))? [INFO] [stdout] 224 + .get(0) [INFO] [stdout] 225 + .ok_or(FibonacciError( [INFO] [stdout] 226 + "Failed to get `out` value".to_string(), [INFO] [stdout] 227 ~ ))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `inputs [INFO] [stdout] .get("out") [INFO] [stdout] .ok_or(FibonacciError( [INFO] [stdout] "Failed to get `out` value".to_string(), [INFO] [stdout] ))?.get(0)` [INFO] [stdout] --> src/circuit.rs:219:19 [INFO] [stdout] | [INFO] [stdout] 219 | let out: Fr = inputs [INFO] [stdout] | ___________________^ [INFO] [stdout] 220 | | .get("out") [INFO] [stdout] 221 | | .ok_or(FibonacciError( [INFO] [stdout] 222 | | "Failed to get `out` value".to_string(), [INFO] [stdout] 223 | | ))? [INFO] [stdout] 224 | | .get(0) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 219 ~ let out: Fr = inputs [INFO] [stdout] 220 + .get("out") [INFO] [stdout] 221 + .ok_or(FibonacciError( [INFO] [stdout] 222 + "Failed to get `out` value".to_string(), [INFO] [stdout] 223 + ))?.first() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/io.rs:38:23 [INFO] [stdout] | [INFO] [stdout] 38 | with_reader(path, |reader| ParamsKZG::read(reader)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `ParamsKZG::read` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/serialisation.rs:28:29 [INFO] [stdout] | [INFO] [stdout] 28 | int.map(|i| Fr::from_u128(i)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Fr::from_u128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/serialisation.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Fr` which implements the `Copy` trait [INFO] [stdout] --> src/circuit.rs:219:19 [INFO] [stdout] | [INFO] [stdout] 219 | let out: Fr = inputs [INFO] [stdout] | ___________________^ [INFO] [stdout] 220 | | .get("out") [INFO] [stdout] 221 | | .ok_or(FibonacciError( [INFO] [stdout] 222 | | "Failed to get `out` value".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 227 | | ))? [INFO] [stdout] 228 | | .clone(); [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] help: try dereferencing it [INFO] [stdout] | [INFO] [stdout] 219 ~ let out: Fr = *inputs [INFO] [stdout] 220 + .get("out") [INFO] [stdout] 221 + .ok_or(FibonacciError( [INFO] [stdout] 222 + "Failed to get `out` value".to_string(), [INFO] [stdout] 223 + ))? [INFO] [stdout] 224 + .get(0) [INFO] [stdout] 225 + .ok_or(FibonacciError( [INFO] [stdout] 226 + "Failed to get `out` value".to_string(), [INFO] [stdout] 227 ~ ))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `inputs [INFO] [stdout] .get("out") [INFO] [stdout] .ok_or(FibonacciError( [INFO] [stdout] "Failed to get `out` value".to_string(), [INFO] [stdout] ))?.get(0)` [INFO] [stdout] --> src/circuit.rs:219:19 [INFO] [stdout] | [INFO] [stdout] 219 | let out: Fr = inputs [INFO] [stdout] | ___________________^ [INFO] [stdout] 220 | | .get("out") [INFO] [stdout] 221 | | .ok_or(FibonacciError( [INFO] [stdout] 222 | | "Failed to get `out` value".to_string(), [INFO] [stdout] 223 | | ))? [INFO] [stdout] 224 | | .get(0) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 219 ~ let out: Fr = inputs [INFO] [stdout] 220 + .get("out") [INFO] [stdout] 221 + .ok_or(FibonacciError( [INFO] [stdout] 222 + "Failed to get `out` value".to_string(), [INFO] [stdout] 223 + ))?.first() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/circuit.rs:311:17 [INFO] [stdout] | [INFO] [stdout] 311 | assert!(!result.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/io.rs:38:23 [INFO] [stdout] | [INFO] [stdout] 38 | with_reader(path, |reader| ParamsKZG::read(reader)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `ParamsKZG::read` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/serialisation.rs:28:29 [INFO] [stdout] | [INFO] [stdout] 28 | int.map(|i| Fr::from_u128(i)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Fr::from_u128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 14.93s [INFO] running `Command { std: "docker" "inspect" "a68f6a9c46792425ab505d42286b85218602073b34582f71239d6bcc536ccde2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a68f6a9c46792425ab505d42286b85218602073b34582f71239d6bcc536ccde2", kill_on_drop: false }` [INFO] [stdout] a68f6a9c46792425ab505d42286b85218602073b34582f71239d6bcc536ccde2