[INFO] cloning repository https://github.com/Ellendren/football-rpg
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Ellendren/football-rpg" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEllendren%2Ffootball-rpg", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEllendren%2Ffootball-rpg'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 6140bd3d7ce62aa7f1466bb0bb1e7005d1c28fe4
[INFO] linting Ellendren/football-rpg against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEllendren%2Ffootball-rpg" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/Ellendren/football-rpg
[INFO] finished tweaking git repo https://github.com/Ellendren/football-rpg
[INFO] tweaked toml for git repo https://github.com/Ellendren/football-rpg written to /workspace/builds/worker-2-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/Ellendren/football-rpg on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/Ellendren/football-rpg already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 8ff33e0eb81d200bd884f7dd701565c92f28c40de215b299a212e92084815970
[INFO] running `Command { std: "docker" "start" "-a" "8ff33e0eb81d200bd884f7dd701565c92f28c40de215b299a212e92084815970", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "8ff33e0eb81d200bd884f7dd701565c92f28c40de215b299a212e92084815970", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "8ff33e0eb81d200bd884f7dd701565c92f28c40de215b299a212e92084815970", kill_on_drop: false }`
[INFO] [stdout] 8ff33e0eb81d200bd884f7dd701565c92f28c40de215b299a212e92084815970
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] a04a24083412991b009fe933eeacdaeed671d875157ba5e05c32b636668aeb05
[INFO] running `Command { std: "docker" "start" "-a" "a04a24083412991b009fe933eeacdaeed671d875157ba5e05c32b636668aeb05", kill_on_drop: false }`
[INFO] [stderr]    Compiling proc-macro2 v1.0.89
[INFO] [stderr]    Compiling unicode-ident v1.0.13
[INFO] [stderr]    Compiling rustversion v1.0.18
[INFO] [stderr]     Checking strum v0.26.3
[INFO] [stderr]     Checking colored v2.1.0
[INFO] [stderr]    Compiling quote v1.0.37
[INFO] [stderr]    Compiling syn v2.0.85
[INFO] [stderr]    Compiling strum_macros v0.26.4
[INFO] [stderr]     Checking football-rpg v0.0.1 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unused import: `std::env::VarError`
[INFO] [stdout]  --> src/stats.rs:1:5
[INFO] [stdout]   |
[INFO] [stdout] 1 | use std::env::VarError;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::default`
[INFO] [stdout]  --> src/stats/team.rs:1:5
[INFO] [stdout]   |
[INFO] [stdout] 1 | use std::default;
[INFO] [stdout]   |     ^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::env::VarError`
[INFO] [stdout]  --> src/stats.rs:1:5
[INFO] [stdout]   |
[INFO] [stdout] 1 | use std::env::VarError;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `self`
[INFO] [stdout]  --> src/stats/team.rs:3:21
[INFO] [stdout]   |
[INFO] [stdout] 3 | use super::player::{self, Player};
[INFO] [stdout]   |                     ^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::default`
[INFO] [stdout]  --> src/stats/team.rs:1:5
[INFO] [stdout]   |
[INFO] [stdout] 1 | use std::default;
[INFO] [stdout]   |     ^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant `List_saves` should have an upper camel case name
[INFO] [stdout]  --> src/stats/team.rs:8:5
[INFO] [stdout]   |
[INFO] [stdout] 8 |     List_saves,
[INFO] [stdout]   |     ^^^^^^^^^^ help: convert the identifier to upper camel case: `ListSaves`
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `self`
[INFO] [stdout]  --> src/stats/team.rs:3:21
[INFO] [stdout]   |
[INFO] [stdout] 3 | use super::player::{self, Player};
[INFO] [stdout]   |                     ^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant `List_saves` should have an upper camel case name
[INFO] [stdout]  --> src/stats/team.rs:8:5
[INFO] [stdout]   |
[INFO] [stdout] 8 |     List_saves,
[INFO] [stdout]   |     ^^^^^^^^^^ help: convert the identifier to upper camel case: `ListSaves`
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: type `util` should have an upper camel case name
[INFO] [stdout]   --> src/stats.rs:19:8
[INFO] [stdout]    |
[INFO] [stdout] 19 | struct util;
[INFO] [stdout]    |        ^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Util`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused imports: `fmt::format` and `option`
[INFO] [stdout]  --> src/cli.rs:1:11
[INFO] [stdout]   |
[INFO] [stdout] 1 | use std::{fmt::format, io::Write, option};
[INFO] [stdout]   |           ^^^^^^^^^^^             ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: type `util` should have an upper camel case name
[INFO] [stdout]   --> src/stats.rs:19:8
[INFO] [stdout]    |
[INFO] [stdout] 19 | struct util;
[INFO] [stdout]    |        ^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Util`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused imports: `fmt::format` and `option`
[INFO] [stdout]  --> src/cli.rs:1:11
[INFO] [stdout]   |
[INFO] [stdout] 1 | use std::{fmt::format, io::Write, option};
[INFO] [stdout]   |           ^^^^^^^^^^^             ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `path`
[INFO] [stdout]    --> src/stats/player.rs:212:25
[INFO] [stdout]     |
[INFO] [stdout] 212 |     pub fn list_players(path: Option<String>) -> Result<Vec<std::fs::DirEntry>, Error>{
[INFO] [stdout]     |                         ^^^^ help: if this is intentional, prefix it with an underscore: `_path`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: value assigned to `player` is never read
[INFO] [stdout]    --> src/stats/player.rs:237:26
[INFO] [stdout]     |
[INFO] [stdout] 237 |         let mut player = Player::default();
[INFO] [stdout]     |                          ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: maybe it is overwritten before being read?
[INFO] [stdout]     = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `path`
[INFO] [stdout]    --> src/stats/player.rs:212:25
[INFO] [stdout]     |
[INFO] [stdout] 212 |     pub fn list_players(path: Option<String>) -> Result<Vec<std::fs::DirEntry>, Error>{
[INFO] [stdout]     |                         ^^^^ help: if this is intentional, prefix it with an underscore: `_path`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: value assigned to `player` is never read
[INFO] [stdout]    --> src/stats/player.rs:237:26
[INFO] [stdout]     |
[INFO] [stdout] 237 |         let mut player = Player::default();
[INFO] [stdout]     |                          ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: maybe it is overwritten before being read?
[INFO] [stdout]     = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `err_msg` is never read
[INFO] [stdout]  --> src/stats/player.rs:6:10
[INFO] [stdout]   |
[INFO] [stdout] 6 |     Save{err_msg: String},
[INFO] [stdout]   |     ---- ^^^^^^^
[INFO] [stdout]   |     |
[INFO] [stdout]   |     field in this variant
[INFO] [stdout]   |
[INFO] [stdout]   = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout]   = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `err_msg` is never read
[INFO] [stdout]  --> src/stats/player.rs:7:10
[INFO] [stdout]   |
[INFO] [stdout] 7 |     Load{err_msg: String}
[INFO] [stdout]   |     ---- ^^^^^^^
[INFO] [stdout]   |     |
[INFO] [stdout]   |     field in this variant
[INFO] [stdout]   |
[INFO] [stdout]   = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: associated function `list_players` is never used
[INFO] [stdout]    --> src/stats/player.rs:212:12
[INFO] [stdout]     |
[INFO] [stdout] 130 | impl Player {
[INFO] [stdout]     | ----------- associated function in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 212 |     pub fn list_players(path: Option<String>) -> Result<Vec<std::fs::DirEntry>, Error>{
[INFO] [stdout]     |            ^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant `Load` is never constructed
[INFO] [stdout]  --> src/stats/team.rs:9:5
[INFO] [stdout]   |
[INFO] [stdout] 6 | pub enum ErrorKind {
[INFO] [stdout]   |          --------- variant in this enum
[INFO] [stdout] ...
[INFO] [stdout] 9 |     Load
[INFO] [stdout]   |     ^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `ErrorKind` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `kind` is never read
[INFO] [stdout]   --> src/stats/team.rs:14:5
[INFO] [stdout]    |
[INFO] [stdout] 13 | pub struct Error {
[INFO] [stdout]    |            ----- field in this struct
[INFO] [stdout] 14 |     kind: ErrorKind,
[INFO] [stdout]    |     ^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enum `Commands` is never used
[INFO] [stdout]   --> src/cli.rs:23:6
[INFO] [stdout]    |
[INFO] [stdout] 23 | enum Commands {
[INFO] [stdout]    |      ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `menu` is never used
[INFO] [stdout]   --> src/cli.rs:28:8
[INFO] [stdout]    |
[INFO] [stdout] 27 | impl Commands {
[INFO] [stdout]    | ------------- method in this implementation
[INFO] [stdout] 28 |     fn menu(&self) -> String {
[INFO] [stdout]    |        ^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `load` is never used
[INFO] [stdout]   --> src/cli/player.rs:22:8
[INFO] [stdout]    |
[INFO] [stdout] 22 | pub fn load(){
[INFO] [stdout]    |        ^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `err_msg` is never read
[INFO] [stdout]  --> src/stats/player.rs:6:10
[INFO] [stdout]   |
[INFO] [stdout] 6 |     Save{err_msg: String},
[INFO] [stdout]   |     ---- ^^^^^^^
[INFO] [stdout]   |     |
[INFO] [stdout]   |     field in this variant
[INFO] [stdout]   |
[INFO] [stdout]   = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout]   = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `err_msg` is never read
[INFO] [stdout]  --> src/stats/player.rs:7:10
[INFO] [stdout]   |
[INFO] [stdout] 7 |     Load{err_msg: String}
[INFO] [stdout]   |     ---- ^^^^^^^
[INFO] [stdout]   |     |
[INFO] [stdout]   |     field in this variant
[INFO] [stdout]   |
[INFO] [stdout]   = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: associated function `list_players` is never used
[INFO] [stdout]    --> src/stats/player.rs:212:12
[INFO] [stdout]     |
[INFO] [stdout] 130 | impl Player {
[INFO] [stdout]     | ----------- associated function in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 212 |     pub fn list_players(path: Option<String>) -> Result<Vec<std::fs::DirEntry>, Error>{
[INFO] [stdout]     |            ^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant `Load` is never constructed
[INFO] [stdout]  --> src/stats/team.rs:9:5
[INFO] [stdout]   |
[INFO] [stdout] 6 | pub enum ErrorKind {
[INFO] [stdout]   |          --------- variant in this enum
[INFO] [stdout] ...
[INFO] [stdout] 9 |     Load
[INFO] [stdout]   |     ^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `ErrorKind` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `kind` is never read
[INFO] [stdout]   --> src/stats/team.rs:14:5
[INFO] [stdout]    |
[INFO] [stdout] 13 | pub struct Error {
[INFO] [stdout]    |            ----- field in this struct
[INFO] [stdout] 14 |     kind: ErrorKind,
[INFO] [stdout]    |     ^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value
[INFO] [stdout]   --> src/stats/player.rs:65:14
[INFO] [stdout]    |
[INFO] [stdout] 65 |     fn to_hp(&self) -> HP {
[INFO] [stdout]    |              ^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: consider choosing a less ambiguous name
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stdout]    = note: `#[warn(clippy::wrong_self_convention)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `NPC` contains a capitalized acronym
[INFO] [stdout]   --> src/stats/player.rs:80:5
[INFO] [stdout]    |
[INFO] [stdout] 80 |     NPC(u64)
[INFO] [stdout]    |     ^^^ help: consider making the acronym lowercase, except the initial letter: `Npc`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout]    = note: `#[warn(clippy::upper_case_acronyms)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/stats/player.rs:105:17
[INFO] [stdout]     |
[INFO] [stdout] 105 |                 return IDType::NPC(num);
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 105 -                 return IDType::NPC(num);
[INFO] [stdout] 105 +                 IDType::NPC(num)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enum `Commands` is never used
[INFO] [stdout]   --> src/cli.rs:23:6
[INFO] [stdout]    |
[INFO] [stdout] 23 | enum Commands {
[INFO] [stdout]    |      ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/stats/player.rs:109:17
[INFO] [stdout]     |
[INFO] [stdout] 109 |                 return IDType::PC(num);
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 109 -                 return IDType::PC(num);
[INFO] [stdout] 109 +                 IDType::PC(num)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `menu` is never used
[INFO] [stdout]   --> src/cli.rs:28:8
[INFO] [stdout]    |
[INFO] [stdout] 27 | impl Commands {
[INFO] [stdout]    | ------------- method in this implementation
[INFO] [stdout] 28 |     fn menu(&self) -> String {
[INFO] [stdout]    |        ^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `load` is never used
[INFO] [stdout]   --> src/cli/player.rs:22:8
[INFO] [stdout]    |
[INFO] [stdout] 22 | pub fn load(){
[INFO] [stdout]    |        ^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/stats/player.rs:111:18
[INFO] [stdout]     |
[INFO] [stdout] 111 |             _ => return IDType::NPC(0)
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 111 -             _ => return IDType::NPC(0)
[INFO] [stdout] 111 +             _ => IDType::NPC(0)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value
[INFO] [stdout]   --> src/stats/player.rs:65:14
[INFO] [stdout]    |
[INFO] [stdout] 65 |     fn to_hp(&self) -> HP {
[INFO] [stdout]    |              ^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: consider choosing a less ambiguous name
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stdout]    = note: `#[warn(clippy::wrong_self_convention)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/stats/player.rs:134:9
[INFO] [stdout]     |
[INFO] [stdout] 134 |         return Player::new(None, None, None, None, None, None, None, None)
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 134 -         return Player::new(None, None, None, None, None, None, None, None)
[INFO] [stdout] 134 +         Player::new(None, None, None, None, None, None, None, None)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (8/7)
[INFO] [stdout]    --> src/stats/player.rs:137:5
[INFO] [stdout]     |
[INFO] [stdout] 137 | /     pub fn new(
[INFO] [stdout] 138 | |         speed: Option<u16>,
[INFO] [stdout] 139 | |         strength: Option<u16>,
[INFO] [stdout] 140 | |         agility: Option<u16>,
[INFO] [stdout] ...   |
[INFO] [stdout] 145 | |         lname: Option<String>
[INFO] [stdout] 146 | |     ) -> Self{
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout]     = note: `#[warn(clippy::too_many_arguments)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `NPC` contains a capitalized acronym
[INFO] [stdout]   --> src/stats/player.rs:80:5
[INFO] [stdout]    |
[INFO] [stdout] 80 |     NPC(u64)
[INFO] [stdout]    |     ^^^ help: consider making the acronym lowercase, except the initial letter: `Npc`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout]    = note: `#[warn(clippy::upper_case_acronyms)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (8/7)
[INFO] [stdout]    --> src/stats/player.rs:162:5
[INFO] [stdout]     |
[INFO] [stdout] 162 | /     pub fn new_pc(
[INFO] [stdout] 163 | |         speed: Option<u16>,
[INFO] [stdout] 164 | |         strength: Option<u16>,
[INFO] [stdout] 165 | |         agility: Option<u16>,
[INFO] [stdout] ...   |
[INFO] [stdout] 170 | |         lname: Option<String>
[INFO] [stdout] 171 | |     ) -> Self{
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/stats/player.rs:105:17
[INFO] [stdout]     |
[INFO] [stdout] 105 |                 return IDType::NPC(num);
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 105 -                 return IDType::NPC(num);
[INFO] [stdout] 105 +                 IDType::NPC(num)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `match` expression can be replaced with `?`
[INFO] [stdout]    --> src/stats/player.rs:181:20
[INFO] [stdout]     |
[INFO] [stdout] 181 |           let path = match self.save_file_name(None) {
[INFO] [stdout]     |  ____________________^
[INFO] [stdout] 182 | |             Ok(path) => path,
[INFO] [stdout] 183 | |             Err(e) => return Err(e)
[INFO] [stdout] 184 | |         };
[INFO] [stdout]     | |_________^ help: try instead: `self.save_file_name(None)?`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stdout]     = note: `#[warn(clippy::question_mark)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/stats/player.rs:109:17
[INFO] [stdout]     |
[INFO] [stdout] 109 |                 return IDType::PC(num);
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 109 -                 return IDType::PC(num);
[INFO] [stdout] 109 +                 IDType::PC(num)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/stats/player.rs:111:18
[INFO] [stdout]     |
[INFO] [stdout] 111 |             _ => return IDType::NPC(0)
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 111 -             _ => return IDType::NPC(0)
[INFO] [stdout] 111 +             _ => IDType::NPC(0)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/stats/player.rs:194:45
[INFO] [stdout]     |
[INFO] [stdout] 194 |         let stream = PlayerByteStream::from(&self);
[INFO] [stdout]     |                                             ^^^^^ help: change this to: `self`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/stats/player.rs:134:9
[INFO] [stdout]     |
[INFO] [stdout] 134 |         return Player::new(None, None, None, None, None, None, None, None)
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 134 -         return Player::new(None, None, None, None, None, None, None, None)
[INFO] [stdout] 134 +         Player::new(None, None, None, None, None, None, None, None)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/stats/player.rs:215:57
[INFO] [stdout]     |
[INFO] [stdout] 215 |             Err(_) => return Err(Error::Load { err_msg: format!("Failed to get load file path") })
[INFO] [stdout]     |                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Failed to get load file path".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout]     = note: `#[warn(clippy::useless_format)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (8/7)
[INFO] [stdout]    --> src/stats/player.rs:137:5
[INFO] [stdout]     |
[INFO] [stdout] 137 | /     pub fn new(
[INFO] [stdout] 138 | |         speed: Option<u16>,
[INFO] [stdout] 139 | |         strength: Option<u16>,
[INFO] [stdout] 140 | |         agility: Option<u16>,
[INFO] [stdout] ...   |
[INFO] [stdout] 145 | |         lname: Option<String>
[INFO] [stdout] 146 | |     ) -> Self{
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout]     = note: `#[warn(clippy::too_many_arguments)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args
[INFO] [stdout]    --> src/stats/player.rs:220:87
[INFO] [stdout]     |
[INFO] [stdout] 220 |             Err(e) => return Err(Error::Load { err_msg: format!("Cant read dir: {}", e.to_string()) })
[INFO] [stdout]     |                                                                                       ^^^^^^^^^^^^ help: remove this
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
[INFO] [stdout]     = note: `#[warn(clippy::to_string_in_format_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `filter` for `Ok` followed by `unwrap`
[INFO] [stdout]    --> src/stats/player.rs:224:14
[INFO] [stdout]     |
[INFO] [stdout] 224 |               .filter(|e| e.is_ok())
[INFO] [stdout]     |  ______________^
[INFO] [stdout] 225 | |             .map(|e| e.unwrap())
[INFO] [stdout]     | |________________________________^ help: consider using `flatten` instead: `flatten()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_filter_map
[INFO] [stdout]     = note: `#[warn(clippy::result_filter_map)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (8/7)
[INFO] [stdout]    --> src/stats/player.rs:162:5
[INFO] [stdout]     |
[INFO] [stdout] 162 | /     pub fn new_pc(
[INFO] [stdout] 163 | |         speed: Option<u16>,
[INFO] [stdout] 164 | |         strength: Option<u16>,
[INFO] [stdout] 165 | |         agility: Option<u16>,
[INFO] [stdout] ...   |
[INFO] [stdout] 170 | |         lname: Option<String>
[INFO] [stdout] 171 | |     ) -> Self{
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/stats/player.rs:240:55
[INFO] [stdout]     |
[INFO] [stdout] 240 |             None => return Err(Error::Load { err_msg: format!("Failed to get load file path") })
[INFO] [stdout]     |                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Failed to get load file path".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `match` expression can be replaced with `?`
[INFO] [stdout]    --> src/stats/player.rs:181:20
[INFO] [stdout]     |
[INFO] [stdout] 181 |           let path = match self.save_file_name(None) {
[INFO] [stdout]     |  ____________________^
[INFO] [stdout] 182 | |             Ok(path) => path,
[INFO] [stdout] 183 | |             Err(e) => return Err(e)
[INFO] [stdout] 184 | |         };
[INFO] [stdout]     | |_________^ help: try instead: `self.save_file_name(None)?`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stdout]     = note: `#[warn(clippy::question_mark)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator
[INFO] [stdout]    --> src/stats/player.rs:243:25
[INFO] [stdout]     |
[INFO] [stdout] 243 |         let file_name = path.split('/').last();
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last
[INFO] [stdout]     = note: `#[warn(clippy::double_ended_iterator_last)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 243 -         let file_name = path.split('/').last();
[INFO] [stdout] 243 +         let file_name = path.split('/').next_back();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/stats/player.rs:194:45
[INFO] [stdout]     |
[INFO] [stdout] 194 |         let stream = PlayerByteStream::from(&self);
[INFO] [stdout]     |                                             ^^^^^ help: change this to: `self`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args
[INFO] [stdout]    --> src/stats/player.rs:252:74
[INFO] [stdout]     |
[INFO] [stdout] 252 |                 let err_msg = format!("Error reding file {}: {}", path, e.to_string());
[INFO] [stdout]     |                                                                          ^^^^^^^^^^^^ help: remove this
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/stats/player.rs:215:57
[INFO] [stdout]     |
[INFO] [stdout] 215 |             Err(_) => return Err(Error::Load { err_msg: format!("Failed to get load file path") })
[INFO] [stdout]     |                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Failed to get load file path".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout]     = note: `#[warn(clippy::useless_format)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args
[INFO] [stdout]    --> src/stats/player.rs:220:87
[INFO] [stdout]     |
[INFO] [stdout] 220 |             Err(e) => return Err(Error::Load { err_msg: format!("Cant read dir: {}", e.to_string()) })
[INFO] [stdout]     |                                                                                       ^^^^^^^^^^^^ help: remove this
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
[INFO] [stdout]     = note: `#[warn(clippy::to_string_in_format_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `filter` for `Ok` followed by `unwrap`
[INFO] [stdout]    --> src/stats/player.rs:224:14
[INFO] [stdout]     |
[INFO] [stdout] 224 |               .filter(|e| e.is_ok())
[INFO] [stdout]     |  ______________^
[INFO] [stdout] 225 | |             .map(|e| e.unwrap())
[INFO] [stdout]     | |________________________________^ help: consider using `flatten` instead: `flatten()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_filter_map
[INFO] [stdout]     = note: `#[warn(clippy::result_filter_map)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/stats/player.rs:258:9
[INFO] [stdout]     |
[INFO] [stdout] 258 | /         match file_name {
[INFO] [stdout] 259 | |             Some(f) => {
[INFO] [stdout] 260 | |                 //get rid of file extension
[INFO] [stdout] 261 | |                 let name = f.split('.').nth(0).unwrap_or("");
[INFO] [stdout] ...   |
[INFO] [stdout] 272 | |             None => {}
[INFO] [stdout] 273 | |         };
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]     = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 258 ~         if let Some(f) = file_name {
[INFO] [stdout] 259 +             //get rid of file extension
[INFO] [stdout] 260 +             let name = f.split('.').nth(0).unwrap_or("");
[INFO] [stdout] 261 + 
[INFO] [stdout] 262 +             //split lname, fname, id
[INFO] [stdout] 263 +             let vals: Vec<&str> = name.split('_').collect();
[INFO] [stdout] 264 +             if vals.len() != 3 {
[INFO] [stdout] 265 +                 return Err(Error::Load { err_msg: "Invalid player file name, most be in form '<lname>_<fname>_<ID>.player'".to_string() });
[INFO] [stdout] 266 +             }
[INFO] [stdout] 267 +             player.lname = vals[0].to_string();
[INFO] [stdout] 268 +             player.fname = vals[1].to_string();
[INFO] [stdout] 269 +             player.id = IDType::from_string(vals[2].to_string());
[INFO] [stdout] 270 ~         };
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/stats/player.rs:291:31
[INFO] [stdout]     |
[INFO] [stdout] 291 |                     Err(e) => return Err(e)
[INFO] [stdout]     |                               ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 291 -                     Err(e) => return Err(e)
[INFO] [stdout] 291 +                     Err(e) => Err(e)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/stats/player.rs:240:55
[INFO] [stdout]     |
[INFO] [stdout] 240 |             None => return Err(Error::Load { err_msg: format!("Failed to get load file path") })
[INFO] [stdout]     |                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Failed to get load file path".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator
[INFO] [stdout]    --> src/stats/player.rs:243:25
[INFO] [stdout]     |
[INFO] [stdout] 243 |         let file_name = path.split('/').last();
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last
[INFO] [stdout]     = note: `#[warn(clippy::double_ended_iterator_last)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 243 -         let file_name = path.split('/').last();
[INFO] [stdout] 243 +         let file_name = path.split('/').next_back();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args
[INFO] [stdout]    --> src/stats/player.rs:252:74
[INFO] [stdout]     |
[INFO] [stdout] 252 |                 let err_msg = format!("Error reding file {}: {}", path, e.to_string());
[INFO] [stdout]     |                                                                          ^^^^^^^^^^^^ help: remove this
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/stats/player.rs:258:9
[INFO] [stdout]     |
[INFO] [stdout] 258 | /         match file_name {
[INFO] [stdout] 259 | |             Some(f) => {
[INFO] [stdout] 260 | |                 //get rid of file extension
[INFO] [stdout] 261 | |                 let name = f.split('.').nth(0).unwrap_or("");
[INFO] [stdout] ...   |
[INFO] [stdout] 272 | |             None => {}
[INFO] [stdout] 273 | |         };
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]     = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 258 ~         if let Some(f) = file_name {
[INFO] [stdout] 259 +             //get rid of file extension
[INFO] [stdout] 260 +             let name = f.split('.').nth(0).unwrap_or("");
[INFO] [stdout] 261 + 
[INFO] [stdout] 262 +             //split lname, fname, id
[INFO] [stdout] 263 +             let vals: Vec<&str> = name.split('_').collect();
[INFO] [stdout] 264 +             if vals.len() != 3 {
[INFO] [stdout] 265 +                 return Err(Error::Load { err_msg: "Invalid player file name, most be in form '<lname>_<fname>_<ID>.player'".to_string() });
[INFO] [stdout] 266 +             }
[INFO] [stdout] 267 +             player.lname = vals[0].to_string();
[INFO] [stdout] 268 +             player.fname = vals[1].to_string();
[INFO] [stdout] 269 +             player.id = IDType::from_string(vals[2].to_string());
[INFO] [stdout] 270 ~         };
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/stats/player.rs:291:31
[INFO] [stdout]     |
[INFO] [stdout] 291 |                     Err(e) => return Err(e)
[INFO] [stdout]     |                               ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 291 -                     Err(e) => return Err(e)
[INFO] [stdout] 291 +                     Err(e) => Err(e)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value
[INFO] [stdout]    --> src/stats/player.rs:397:18
[INFO] [stdout]     |
[INFO] [stdout] 397 |     fn to_player(&self) -> Player{
[INFO] [stdout]     |                  ^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: consider choosing a less ambiguous name
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `Vec<T>` is already on the heap, the boxing is unnecessary
[INFO] [stdout]   --> src/stats/team.rs:21:14
[INFO] [stdout]    |
[INFO] [stdout] 21 |     players: Vec<Box<super::player::Player>>
[INFO] [stdout]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Vec<super::player::Player>`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box
[INFO] [stdout]    = note: `#[warn(clippy::vec_box)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `match` expression can be replaced with `?`
[INFO] [stdout]   --> src/stats/team.rs:58:21
[INFO] [stdout]    |
[INFO] [stdout] 58 |               None => match Team::default_path(){
[INFO] [stdout]    |  _____________________^
[INFO] [stdout] 59 | |                 Ok(dp) => dp,
[INFO] [stdout] 60 | |                 Err(e) => return Err(e)
[INFO] [stdout] 61 | |             }
[INFO] [stdout]    | |_____________^ help: try instead: `Team::default_path()?`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value
[INFO] [stdout]    --> src/stats/player.rs:397:18
[INFO] [stdout]     |
[INFO] [stdout] 397 |     fn to_player(&self) -> Player{
[INFO] [stdout]     |                  ^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: consider choosing a less ambiguous name
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `Vec<T>` is already on the heap, the boxing is unnecessary
[INFO] [stdout]   --> src/stats/team.rs:21:14
[INFO] [stdout]    |
[INFO] [stdout] 21 |     players: Vec<Box<super::player::Player>>
[INFO] [stdout]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Vec<super::player::Player>`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box
[INFO] [stdout]    = note: `#[warn(clippy::vec_box)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `filter` for `Ok` followed by `unwrap`
[INFO] [stdout]    --> src/stats/team.rs:126:14
[INFO] [stdout]     |
[INFO] [stdout] 126 |               .filter(|e| e.is_ok())
[INFO] [stdout]     |  ______________^
[INFO] [stdout] 127 | |             .map(|e| e.unwrap())
[INFO] [stdout]     | |________________________________^ help: consider using `flatten` instead: `flatten()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_filter_map
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `file` after checking its variant with `is_ok`
[INFO] [stdout]    --> src/stats/team.rs:152:33
[INFO] [stdout]     |
[INFO] [stdout] 151 |             if file.is_ok() {
[INFO] [stdout]     |             --------------- help: try: `if let Ok(<item>) = file`
[INFO] [stdout] 152 |                 let file_name = file.unwrap().as_mut_os_string().to_str().unwrap().to_string();
[INFO] [stdout]     |                                 ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `match` expression can be replaced with `?`
[INFO] [stdout]   --> src/stats/team.rs:58:21
[INFO] [stdout]    |
[INFO] [stdout] 58 |               None => match Team::default_path(){
[INFO] [stdout]    |  _____________________^
[INFO] [stdout] 59 | |                 Ok(dp) => dp,
[INFO] [stdout] 60 | |                 Err(e) => return Err(e)
[INFO] [stdout] 61 | |             }
[INFO] [stdout]    | |_____________^ help: try instead: `Team::default_path()?`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `match` expression can be replaced with `?`
[INFO] [stdout]    --> src/stats/team.rs:144:19
[INFO] [stdout]     |
[INFO] [stdout] 144 |           let dir = match Team::list_teams(Some(path.path().to_str().unwrap_or("badname").to_string())) {
[INFO] [stdout]     |  ___________________^
[INFO] [stdout] 145 | |             Ok(d) => d,
[INFO] [stdout] 146 | |             Err(e) =>return Err(e)
[INFO] [stdout] 147 | |         };
[INFO] [stdout]     | |_________^ help: try instead: `Team::list_teams(Some(path.path().to_str().unwrap_or("badname").to_string()))?`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `filter` for `Ok` followed by `unwrap`
[INFO] [stdout]    --> src/stats/team.rs:126:14
[INFO] [stdout]     |
[INFO] [stdout] 126 |               .filter(|e| e.is_ok())
[INFO] [stdout]     |  ______________^
[INFO] [stdout] 127 | |             .map(|e| e.unwrap())
[INFO] [stdout]     | |________________________________^ help: consider using `flatten` instead: `flatten()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_filter_map
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `file` after checking its variant with `is_ok`
[INFO] [stdout]    --> src/stats/team.rs:152:33
[INFO] [stdout]     |
[INFO] [stdout] 151 |             if file.is_ok() {
[INFO] [stdout]     |             --------------- help: try: `if let Ok(<item>) = file`
[INFO] [stdout] 152 |                 let file_name = file.unwrap().as_mut_os_string().to_str().unwrap().to_string();
[INFO] [stdout]     |                                 ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `match` expression can be replaced with `?`
[INFO] [stdout]    --> src/stats/team.rs:144:19
[INFO] [stdout]     |
[INFO] [stdout] 144 |           let dir = match Team::list_teams(Some(path.path().to_str().unwrap_or("badname").to_string())) {
[INFO] [stdout]     |  ___________________^
[INFO] [stdout] 145 | |             Ok(d) => d,
[INFO] [stdout] 146 | |             Err(e) =>return Err(e)
[INFO] [stdout] 147 | |         };
[INFO] [stdout]     | |_________^ help: try instead: `Team::list_teams(Some(path.path().to_str().unwrap_or("badname").to_string()))?`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]   --> src/cli/player.rs:19:5
[INFO] [stdout]    |
[INFO] [stdout] 18 |     let player = player::Player::new_pc(speed, strength, agility, reaction, charisma, awareness, Some(fname), Some(lname));
[INFO] [stdout]    |     ----------------------------------------------------------------------------------------------------------------------- unnecessary `let` binding
[INFO] [stdout] 19 |     player
[INFO] [stdout]    |     ^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]    = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]    |
[INFO] [stdout] 18 ~     
[INFO] [stdout] 19 ~     player::Player::new_pc(speed, strength, agility, reaction, charisma, awareness, Some(fname), Some(lname))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]  --> src/cli/player.rs:9:38
[INFO] [stdout]   |
[INFO] [stdout] 9 |     let fname = super::input_prompt(&format!("\tFirst name"), &mut buf);
[INFO] [stdout]   |                                      ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tFirst name".to_string()`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/cli/player.rs:10:38
[INFO] [stdout]    |
[INFO] [stdout] 10 |     let lname = super::input_prompt(&format!("\tLast name"), &mut buf);
[INFO] [stdout]    |                                      ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tLast name".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/cli/player.rs:11:35
[INFO] [stdout]    |
[INFO] [stdout] 11 |     let speed = attribute_prompt(&format!("speed"), &mut buf);
[INFO] [stdout]    |                                   ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"speed".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/cli/player.rs:12:38
[INFO] [stdout]    |
[INFO] [stdout] 12 |     let strength = attribute_prompt(&format!("strength"), &mut buf);
[INFO] [stdout]    |                                      ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"strength".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/cli/player.rs:13:37
[INFO] [stdout]    |
[INFO] [stdout] 13 |     let agility = attribute_prompt(&format!("agility"), &mut buf);
[INFO] [stdout]    |                                     ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"agility".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]   --> src/cli/player.rs:19:5
[INFO] [stdout]    |
[INFO] [stdout] 18 |     let player = player::Player::new_pc(speed, strength, agility, reaction, charisma, awareness, Some(fname), Some(lname));
[INFO] [stdout]    |     ----------------------------------------------------------------------------------------------------------------------- unnecessary `let` binding
[INFO] [stdout] 19 |     player
[INFO] [stdout]    |     ^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]    = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]    |
[INFO] [stdout] 18 ~     
[INFO] [stdout] 19 ~     player::Player::new_pc(speed, strength, agility, reaction, charisma, awareness, Some(fname), Some(lname))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/cli/player.rs:14:38
[INFO] [stdout]    |
[INFO] [stdout] 14 |     let reaction = attribute_prompt(&format!("reaction"), &mut buf);
[INFO] [stdout]    |                                      ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"reaction".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/cli/player.rs:15:38
[INFO] [stdout]    |
[INFO] [stdout] 15 |     let charisma = attribute_prompt(&format!("charisma"), &mut buf);
[INFO] [stdout]    |                                      ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"charisma".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/cli/player.rs:16:39
[INFO] [stdout]    |
[INFO] [stdout] 16 |     let awareness = attribute_prompt(&format!("awareness"), &mut buf);
[INFO] [stdout]    |                                       ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"awareness".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/cli/player.rs:41:11
[INFO] [stdout]    |
[INFO] [stdout] 41 |     while !pick.is_ok() {
[INFO] [stdout]    |           ^^^^^^^^^^^^^ help: try: `pick.is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]  --> src/cli/player.rs:9:38
[INFO] [stdout]   |
[INFO] [stdout] 9 |     let fname = super::input_prompt(&format!("\tFirst name"), &mut buf);
[INFO] [stdout]   |                                      ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tFirst name".to_string()`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/cli/player.rs:10:38
[INFO] [stdout]    |
[INFO] [stdout] 10 |     let lname = super::input_prompt(&format!("\tLast name"), &mut buf);
[INFO] [stdout]    |                                      ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tLast name".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/cli/player.rs:11:35
[INFO] [stdout]    |
[INFO] [stdout] 11 |     let speed = attribute_prompt(&format!("speed"), &mut buf);
[INFO] [stdout]    |                                   ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"speed".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/cli/player.rs:12:38
[INFO] [stdout]    |
[INFO] [stdout] 12 |     let strength = attribute_prompt(&format!("strength"), &mut buf);
[INFO] [stdout]    |                                      ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"strength".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/cli/player.rs:13:37
[INFO] [stdout]    |
[INFO] [stdout] 13 |     let agility = attribute_prompt(&format!("agility"), &mut buf);
[INFO] [stdout]    |                                     ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"agility".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/cli/player.rs:14:38
[INFO] [stdout]    |
[INFO] [stdout] 14 |     let reaction = attribute_prompt(&format!("reaction"), &mut buf);
[INFO] [stdout]    |                                      ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"reaction".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/cli/player.rs:15:38
[INFO] [stdout]    |
[INFO] [stdout] 15 |     let charisma = attribute_prompt(&format!("charisma"), &mut buf);
[INFO] [stdout]    |                                      ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"charisma".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: needlessly taken reference of left operand
[INFO] [stdout]   --> src/cli/player.rs:69:16
[INFO] [stdout]    |
[INFO] [stdout] 69 |             if &res.to_lowercase() == default{
[INFO] [stdout]    |                -------------------^^^^^^^^^^^
[INFO] [stdout]    |                |
[INFO] [stdout]    |                help: use the left value directly: `res.to_lowercase()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stdout]    = note: `#[warn(clippy::op_ref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/cli/player.rs:16:39
[INFO] [stdout]    |
[INFO] [stdout] 16 |     let awareness = attribute_prompt(&format!("awareness"), &mut buf);
[INFO] [stdout]    |                                       ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"awareness".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/cli/player.rs:41:11
[INFO] [stdout]    |
[INFO] [stdout] 41 |     while !pick.is_ok() {
[INFO] [stdout]    |           ^^^^^^^^^^^^^ help: try: `pick.is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/cli/team.rs:35:11
[INFO] [stdout]    |
[INFO] [stdout] 35 |     while !pick.is_ok() {
[INFO] [stdout]    |           ^^^^^^^^^^^^^ help: try: `pick.is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: needlessly taken reference of left operand
[INFO] [stdout]   --> src/cli/player.rs:69:16
[INFO] [stdout]    |
[INFO] [stdout] 69 |             if &res.to_lowercase() == default{
[INFO] [stdout]    |                -------------------^^^^^^^^^^^
[INFO] [stdout]    |                |
[INFO] [stdout]    |                help: use the left value directly: `res.to_lowercase()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stdout]    = note: `#[warn(clippy::op_ref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/cli/team.rs:35:11
[INFO] [stdout]    |
[INFO] [stdout] 35 |     while !pick.is_ok() {
[INFO] [stdout]    |           ^^^^^^^^^^^^^ help: try: `pick.is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/cli.rs:56:36
[INFO] [stdout]    |
[INFO] [stdout] 56 |     while option.to_lowercase() != format!("exit"){
[INFO] [stdout]    |                                    ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"exit".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/cli.rs:58:23
[INFO] [stdout]    |
[INFO] [stdout] 58 |         input_prompt(&format!("pick option(or 'exit' to quit)"), &mut option);
[INFO] [stdout]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"pick option(or 'exit' to quit)".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/cli.rs:83:20
[INFO] [stdout]    |
[INFO] [stdout] 83 |     let mut menu = format!("Command menu:");
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Command menu:".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/cli.rs:56:36
[INFO] [stdout]    |
[INFO] [stdout] 56 |     while option.to_lowercase() != format!("exit"){
[INFO] [stdout]    |                                    ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"exit".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/cli.rs:58:23
[INFO] [stdout]    |
[INFO] [stdout] 58 |         input_prompt(&format!("pick option(or 'exit' to quit)"), &mut option);
[INFO] [stdout]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"pick option(or 'exit' to quit)".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/cli.rs:83:20
[INFO] [stdout]    |
[INFO] [stdout] 83 |     let mut menu = format!("Command menu:");
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Command menu:".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.76s
[INFO] running `Command { std: "docker" "inspect" "a04a24083412991b009fe933eeacdaeed671d875157ba5e05c32b636668aeb05", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "a04a24083412991b009fe933eeacdaeed671d875157ba5e05c32b636668aeb05", kill_on_drop: false }`
[INFO] [stdout] a04a24083412991b009fe933eeacdaeed671d875157ba5e05c32b636668aeb05