[INFO] cloning repository https://github.com/Egevtech/sbs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Egevtech/sbs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEgevtech%2Fsbs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEgevtech%2Fsbs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 59cc3725a9803abb40f92a654b436effcf1aa521 [INFO] linting Egevtech/sbs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEgevtech%2Fsbs" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Egevtech/sbs [INFO] finished tweaking git repo https://github.com/Egevtech/sbs [INFO] tweaked toml for git repo https://github.com/Egevtech/sbs written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Egevtech/sbs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Egevtech/sbs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded knuffel-derive v3.2.0 [INFO] [stderr] Downloaded knuffel v3.2.0 [INFO] [stderr] Downloaded zerocopy-derive v0.8.40 [INFO] [stderr] Downloaded zerocopy v0.8.40 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 35919f853e6b3eb4a2cc78680396e3c4c307c79c398e15a6b42953fb862bf421 [INFO] running `Command { std: "docker" "start" "-a" "35919f853e6b3eb4a2cc78680396e3c4c307c79c398e15a6b42953fb862bf421", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "35919f853e6b3eb4a2cc78680396e3c4c307c79c398e15a6b42953fb862bf421", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "35919f853e6b3eb4a2cc78680396e3c4c307c79c398e15a6b42953fb862bf421", kill_on_drop: false }` [INFO] [stdout] 35919f853e6b3eb4a2cc78680396e3c4c307c79c398e15a6b42953fb862bf421 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1202c60123b5ed6caf1bbedc4886f76e0287e0f34835f66d8181f59d181263bb [INFO] running `Command { std: "docker" "start" "-a" "1202c60123b5ed6caf1bbedc4886f76e0287e0f34835f66d8181f59d181263bb", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling unicode-ident v1.0.24 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling zerocopy v0.8.40 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking clap_lex v1.0.0 [INFO] [stderr] Checking clap_builder v4.5.60 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling miette-derive v5.10.0 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Compiling knuffel-derive v3.2.0 [INFO] [stderr] Checking chumsky v0.9.3 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking miette v5.10.0 [INFO] [stderr] Checking clap v4.5.60 [INFO] [stderr] Checking knuffel v3.2.0 [INFO] [stderr] Checking sbs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use knuffel; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use knuffel; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:143:48 [INFO] [stdout] | [INFO] [stdout] 143 | if args.command == Command::Install && !target.install_directory.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `target.install_directory.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/main.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | / match args.command { [INFO] [stdout] 75 | | Command::Clean => { [INFO] [stdout] 76 | | fs::remove_dir_all("./build").expect("Failed to remove build directory"); [INFO] [stdout] 77 | | exit(0); [INFO] [stdout] ... | [INFO] [stdout] 80 | | _ => {} [INFO] [stdout] 81 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 74 ~ if args.command == Command::Clean { [INFO] [stdout] 75 + fs::remove_dir_all("./build").expect("Failed to remove build directory"); [INFO] [stdout] 76 + exit(0); [INFO] [stdout] 77 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:86:14 [INFO] [stdout] | [INFO] [stdout] 86 | .expect(format!("Failed to read project file {}", args.config).as_str()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to read project file {}", args.config))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:143:48 [INFO] [stdout] | [INFO] [stdout] 143 | if args.command == Command::Install && !target.install_directory.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `target.install_directory.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/main.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | / match args.command { [INFO] [stdout] 75 | | Command::Clean => { [INFO] [stdout] 76 | | fs::remove_dir_all("./build").expect("Failed to remove build directory"); [INFO] [stdout] 77 | | exit(0); [INFO] [stdout] ... | [INFO] [stdout] 80 | | _ => {} [INFO] [stdout] 81 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 74 ~ if args.command == Command::Clean { [INFO] [stdout] 75 + fs::remove_dir_all("./build").expect("Failed to remove build directory"); [INFO] [stdout] 76 + exit(0); [INFO] [stdout] 77 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `v.r#type` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:117:17 [INFO] [stdout] | [INFO] [stdout] 110 | if v.r#type.is_none() { [INFO] [stdout] | --------------------- help: try: `if let Some() = &v.r#type` [INFO] [stdout] ... [INFO] [stdout] 117 | v.r#type.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:86:14 [INFO] [stdout] | [INFO] [stdout] 86 | .expect(format!("Failed to read project file {}", args.config).as_str()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to read project file {}", args.config))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `v.r#type` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:117:17 [INFO] [stdout] | [INFO] [stdout] 110 | if v.r#type.is_none() { [INFO] [stdout] | --------------------- help: try: `if let Some() = &v.r#type` [INFO] [stdout] ... [INFO] [stdout] 117 | v.r#type.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/main.rs:179:54 [INFO] [stdout] | [INFO] [stdout] 179 | fn build_target(target: &Target, output_file: String) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/main.rs:179:54 [INFO] [stdout] | [INFO] [stdout] 179 | fn build_target(target: &Target, output_file: String) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:184:13 [INFO] [stdout] | [INFO] [stdout] 184 | / String::from( [INFO] [stdout] 185 | | Path::new(f) [INFO] [stdout] 186 | | .file_name() [INFO] [stdout] 187 | | .unwrap_or_else(|| panic!("OCHKO")) [INFO] [stdout] ... | [INFO] [stdout] 190 | | .to_string(), [INFO] [stdout] 191 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing `String::from()` [INFO] [stdout] | [INFO] [stdout] 184 ~ Path::new(f) [INFO] [stdout] 185 + .file_name() [INFO] [stdout] 186 + .unwrap_or_else(|| panic!("OCHKO")) [INFO] [stdout] 187 + .to_str() [INFO] [stdout] 188 + .unwrap() [INFO] [stdout] 189 + .to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `target.compile_args` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:219:17 [INFO] [stdout] | [INFO] [stdout] 216 | .args(if target.compile_args.is_none() { [INFO] [stdout] | -------------------------------- help: try: `if let Some() = &target.compile_args` [INFO] [stdout] ... [INFO] [stdout] 219 | target.compile_args.as_ref().unwrap().to_vec() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:184:13 [INFO] [stdout] | [INFO] [stdout] 184 | / String::from( [INFO] [stdout] 185 | | Path::new(f) [INFO] [stdout] 186 | | .file_name() [INFO] [stdout] 187 | | .unwrap_or_else(|| panic!("OCHKO")) [INFO] [stdout] ... | [INFO] [stdout] 190 | | .to_string(), [INFO] [stdout] 191 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing `String::from()` [INFO] [stdout] | [INFO] [stdout] 184 ~ Path::new(f) [INFO] [stdout] 185 + .file_name() [INFO] [stdout] 186 + .unwrap_or_else(|| panic!("OCHKO")) [INFO] [stdout] 187 + .to_str() [INFO] [stdout] 188 + .unwrap() [INFO] [stdout] 189 + .to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `target.compile_args` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:219:17 [INFO] [stdout] | [INFO] [stdout] 216 | .args(if target.compile_args.is_none() { [INFO] [stdout] | -------------------------------- help: try: `if let Some() = &target.compile_args` [INFO] [stdout] ... [INFO] [stdout] 219 | target.compile_args.as_ref().unwrap().to_vec() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:250:5 [INFO] [stdout] | [INFO] [stdout] 250 | let output: Output; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `output` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 250 ~ [INFO] [stdout] 251 ~ let output: Output = if target.r#type == Some(String::from("static")) { [INFO] [stdout] 252 ~ process::Command::new("ar") [INFO] [stdout] 253 | .args(["rcs", format!("build/{output_file}").as_str()]) [INFO] [stdout] ... [INFO] [stdout] 256 | .output() [INFO] [stdout] 257 ~ .expect("Failed to execute linker") [INFO] [stdout] 258 | // } else if target.r#type == Some(String::from("binary")) { [INFO] [stdout] 259 | } else { [INFO] [stdout] 260 ~ process::Command::new("clang") [INFO] [stdout] 261 | .args(object_files) [INFO] [stdout] ... [INFO] [stdout] 265 | .expect("Failed to execute linker") [INFO] [stdout] 266 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:250:5 [INFO] [stdout] | [INFO] [stdout] 250 | let output: Output; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `output` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 250 ~ [INFO] [stdout] 251 ~ let output: Output = if target.r#type == Some(String::from("static")) { [INFO] [stdout] 252 ~ process::Command::new("ar") [INFO] [stdout] 253 | .args(["rcs", format!("build/{output_file}").as_str()]) [INFO] [stdout] ... [INFO] [stdout] 256 | .output() [INFO] [stdout] 257 ~ .expect("Failed to execute linker") [INFO] [stdout] 258 | // } else if target.r#type == Some(String::from("binary")) { [INFO] [stdout] 259 | } else { [INFO] [stdout] 260 ~ process::Command::new("clang") [INFO] [stdout] 261 | .args(object_files) [INFO] [stdout] ... [INFO] [stdout] 265 | .expect("Failed to execute linker") [INFO] [stdout] 266 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 15.30s [INFO] running `Command { std: "docker" "inspect" "1202c60123b5ed6caf1bbedc4886f76e0287e0f34835f66d8181f59d181263bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1202c60123b5ed6caf1bbedc4886f76e0287e0f34835f66d8181f59d181263bb", kill_on_drop: false }` [INFO] [stdout] 1202c60123b5ed6caf1bbedc4886f76e0287e0f34835f66d8181f59d181263bb