[INFO] cloning repository https://github.com/EdwardJoke/lox-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/EdwardJoke/lox-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEdwardJoke%2Flox-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEdwardJoke%2Flox-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7bf6cd1b22c9aaea0e538c6af189b1af7e8daa8b [INFO] linting EdwardJoke/lox-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEdwardJoke%2Flox-rs" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/EdwardJoke/lox-rs [INFO] finished tweaking git repo https://github.com/EdwardJoke/lox-rs [INFO] tweaked toml for git repo https://github.com/EdwardJoke/lox-rs written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/EdwardJoke/lox-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/EdwardJoke/lox-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded signal-hook-registry v1.4.7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f59cfae2970efcb315c7a61c26d06d229097fb845f95bcc65639a29a4fc9615d [INFO] running `Command { std: "docker" "start" "-a" "f59cfae2970efcb315c7a61c26d06d229097fb845f95bcc65639a29a4fc9615d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f59cfae2970efcb315c7a61c26d06d229097fb845f95bcc65639a29a4fc9615d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f59cfae2970efcb315c7a61c26d06d229097fb845f95bcc65639a29a4fc9615d", kill_on_drop: false }` [INFO] [stdout] f59cfae2970efcb315c7a61c26d06d229097fb845f95bcc65639a29a4fc9615d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e90fa876404e87c637dfa52d62b2e2618f6d97419d3d1186753bc54ac7f82dcf [INFO] running `Command { std: "docker" "start" "-a" "e90fa876404e87c637dfa52d62b2e2618f6d97419d3d1186753bc54ac7f82dcf", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Compiling unicode-ident v1.0.22 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking is_terminal_polyfill v1.70.2 [INFO] [stderr] Checking anstyle-query v1.1.5 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking anstyle v1.0.13 [INFO] [stderr] Checking clap_lex v0.7.6 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking bytes v1.11.0 [INFO] [stderr] Checking pin-project-lite v0.2.16 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking clap_builder v4.5.53 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking signal-hook-registry v1.4.7 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking clap v4.5.53 [INFO] [stderr] Checking lox v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/dash.rs:51:31 [INFO] [stdout] | [INFO] [stdout] 51 | if !is_fpm && !metadata(target_debug).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `metadata(target_debug).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/commands/dash.rs:119:14 [INFO] [stdout] | [INFO] [stdout] 119 | .expect(format!("Failed to execute {}", target_debug).as_str()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to execute {}", target_debug))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/doctor.rs:13:24 [INFO] [stdout] | [INFO] [stdout] 13 | let is_first_run = !metadata("lox.toml").await.is_ok(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `metadata("lox.toml").await.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/commands/doctor.rs:28:14 [INFO] [stdout] | [INFO] [stdout] 28 | .trim() [INFO] [stdout] | ______________^ [INFO] [stdout] 29 | | .split_whitespace() [INFO] [stdout] | |_____________^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] = note: `#[warn(clippy::trim_split_whitespace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/commands/doctor.rs:42:14 [INFO] [stdout] | [INFO] [stdout] 42 | .trim() [INFO] [stdout] | ______________^ [INFO] [stdout] 43 | | .split_whitespace() [INFO] [stdout] | |_____________^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/commands/doctor.rs:68:22 [INFO] [stdout] | [INFO] [stdout] 68 | .trim() [INFO] [stdout] | ______________________^ [INFO] [stdout] 69 | | .split_whitespace() [INFO] [stdout] | |_____________________^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/run.rs:47:31 [INFO] [stdout] | [INFO] [stdout] 47 | if !is_fpm && !metadata(target_release).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `metadata(target_release).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/commands/run.rs:118:14 [INFO] [stdout] | [INFO] [stdout] 118 | .expect(format!("Failed to execute {}", target_release).as_str()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to execute {}", target_release))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/projects/cargo.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | if !metadata("Cargo.toml").await.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `metadata("Cargo.toml").await.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/projects/cargo.rs:18:17 [INFO] [stdout] | [INFO] [stdout] 18 | / if let Some((_, rest)) = line.split_once('"') { [INFO] [stdout] 19 | | if let Some((name, _)) = rest.split_once('"') { [INFO] [stdout] 20 | | project_name = name.to_string(); [INFO] [stdout] 21 | | } [INFO] [stdout] 22 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 18 ~ if let Some((_, rest)) = line.split_once('"') [INFO] [stdout] 19 ~ && let Some((name, _)) = rest.split_once('"') { [INFO] [stdout] 20 | project_name = name.to_string(); [INFO] [stdout] 21 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/projects/cargo.rs:24:17 [INFO] [stdout] | [INFO] [stdout] 24 | / if let Some((_, rest)) = line.split_once('"') { [INFO] [stdout] 25 | | if let Some((version, _)) = rest.split_once('"') { [INFO] [stdout] 26 | | project_version = version.to_string(); [INFO] [stdout] 27 | | } [INFO] [stdout] 28 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 24 ~ if let Some((_, rest)) = line.split_once('"') [INFO] [stdout] 25 ~ && let Some((version, _)) = rest.split_once('"') { [INFO] [stdout] 26 | project_version = version.to_string(); [INFO] [stdout] 27 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/projects/flang.rs:11:13 [INFO] [stdout] | [INFO] [stdout] 11 | while let Some(entry_result) = entries.next_entry().await.ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] = note: `#[warn(clippy::match_result_ok)]` on by default [INFO] [stdout] help: consider matching on `Ok(entry_result)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 11 - while let Some(entry_result) = entries.next_entry().await.ok() { [INFO] [stdout] 11 + while let Ok(entry_result) = entries.next_entry().await { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/projects/flang.rs:14:21 [INFO] [stdout] | [INFO] [stdout] 14 | / if path.is_file() { [INFO] [stdout] 15 | | if let Some(extension) = path.extension() { [INFO] [stdout] 16 | | let ext = extension.to_str().unwrap_or(""); [INFO] [stdout] 17 | | if ext == "f90" || ext == "f" || ext == "F90" || ext == "F" { [INFO] [stdout] ... | [INFO] [stdout] 22 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 14 ~ if path.is_file() [INFO] [stdout] 15 ~ && let Some(extension) = path.extension() { [INFO] [stdout] 16 | let ext = extension.to_str().unwrap_or(""); [INFO] [stdout] ... [INFO] [stdout] 20 | } [INFO] [stdout] 21 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/projects/flang.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | while let Some(entry_result) = entries.next_entry().await.ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] help: consider matching on `Ok(entry_result)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 66 - while let Some(entry_result) = entries.next_entry().await.ok() { [INFO] [stdout] 66 + while let Ok(entry_result) = entries.next_entry().await { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/projects/flang.rs:69:17 [INFO] [stdout] | [INFO] [stdout] 69 | / if path.is_file() { [INFO] [stdout] 70 | | if let Some(extension) = path.extension() { [INFO] [stdout] 71 | | let ext = extension.to_str().unwrap_or(""); [INFO] [stdout] 72 | | if ext == "f90" || ext == "f" || ext == "F90" || ext == "F" { [INFO] [stdout] ... | [INFO] [stdout] 86 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 69 ~ if path.is_file() [INFO] [stdout] 70 ~ && let Some(extension) = path.extension() { [INFO] [stdout] 71 | let ext = extension.to_str().unwrap_or(""); [INFO] [stdout] ... [INFO] [stdout] 84 | } [INFO] [stdout] 85 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/projects/flang.rs:72:25 [INFO] [stdout] | [INFO] [stdout] 72 | / if ext == "f90" || ext == "f" || ext == "F90" || ext == "F" { [INFO] [stdout] 73 | | if let Ok(content) = read_to_string(&path).await { [INFO] [stdout] 74 | | // Check each line for program declaration at the beginning [INFO] [stdout] 75 | | for line in content.lines() { [INFO] [stdout] ... | [INFO] [stdout] 84 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 72 ~ if (ext == "f90" || ext == "f" || ext == "F90" || ext == "F") { [INFO] [stdout] 73 ~ && let Ok(content) = read_to_string(&path).await { [INFO] [stdout] 74 | // Check each line for program declaration at the beginning [INFO] [stdout] ... [INFO] [stdout] 82 | } [INFO] [stdout] 83 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/projects/flang.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | while let Some(entry_result) = entries.next_entry().await.ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] help: consider matching on `Ok(entry_result)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 99 - while let Some(entry_result) = entries.next_entry().await.ok() { [INFO] [stdout] 99 + while let Ok(entry_result) = entries.next_entry().await { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/projects/flang.rs:102:17 [INFO] [stdout] | [INFO] [stdout] 102 | / if path.is_file() { [INFO] [stdout] 103 | | if let Some(extension) = path.extension() { [INFO] [stdout] 104 | | let ext = extension.to_str().unwrap_or(""); [INFO] [stdout] 105 | | if ext == "f90" || ext == "f" || ext == "F90" || ext == "F" { [INFO] [stdout] ... | [INFO] [stdout] 111 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 102 ~ if path.is_file() [INFO] [stdout] 103 ~ && let Some(extension) = path.extension() { [INFO] [stdout] 104 | let ext = extension.to_str().unwrap_or(""); [INFO] [stdout] ... [INFO] [stdout] 109 | } [INFO] [stdout] 110 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/projects/flang.rs:146:81 [INFO] [stdout] | [INFO] [stdout] 146 | if include_path.starts_with('"') && include_path.ends_with('"') { [INFO] [stdout] | _________________________________________________________________________________^ [INFO] [stdout] 147 | | include_path = &include_path[1..include_path.len() - 1]; [INFO] [stdout] 148 | | } else if include_path.starts_with('\'') && include_path.ends_with('\'') { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/projects/flang.rs:148:90 [INFO] [stdout] | [INFO] [stdout] 148 | } else if include_path.starts_with('\'') && include_path.ends_with('\'') { [INFO] [stdout] | __________________________________________________________________________________________^ [INFO] [stdout] 149 | | include_path = &include_path[1..include_path.len() - 1]; [INFO] [stdout] 150 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/projects/flang.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 162 | while let Some(entry_result) = entries.next_entry().await.ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] help: consider matching on `Ok(entry_result)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 162 - while let Some(entry_result) = entries.next_entry().await.ok() { [INFO] [stdout] 162 + while let Ok(entry_result) = entries.next_entry().await { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/projects/flang.rs:165:17 [INFO] [stdout] | [INFO] [stdout] 165 | / if path.is_file() { [INFO] [stdout] 166 | | if let Some(extension) = path.extension() { [INFO] [stdout] 167 | | let ext = extension.to_str().unwrap_or(""); [INFO] [stdout] 168 | | if ext == "f90" || ext == "f" || ext == "F90" || ext == "F" { [INFO] [stdout] ... | [INFO] [stdout] 181 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 165 ~ if path.is_file() [INFO] [stdout] 166 ~ && let Some(extension) = path.extension() { [INFO] [stdout] 167 | let ext = extension.to_str().unwrap_or(""); [INFO] [stdout] ... [INFO] [stdout] 179 | } [INFO] [stdout] 180 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/projects/flang.rs:168:25 [INFO] [stdout] | [INFO] [stdout] 168 | / if ext == "f90" || ext == "f" || ext == "F90" || ext == "F" { [INFO] [stdout] 169 | | if let Ok(content) = read_to_string(&path).await { [INFO] [stdout] 170 | | if content [INFO] [stdout] 171 | | .to_lowercase() [INFO] [stdout] ... | [INFO] [stdout] 179 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 168 ~ if (ext == "f90" || ext == "f" || ext == "F90" || ext == "F") { [INFO] [stdout] 169 ~ && let Ok(content) = read_to_string(&path).await { [INFO] [stdout] 170 | if content [INFO] [stdout] ... [INFO] [stdout] 177 | } [INFO] [stdout] 178 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/projects/flang.rs:169:29 [INFO] [stdout] | [INFO] [stdout] 169 | / ... if let Ok(content) = read_to_string(&path).await { [INFO] [stdout] 170 | | ... if content [INFO] [stdout] 171 | | ... .to_lowercase() [INFO] [stdout] 172 | | ... .contains(&format!("module {}", module_name)) [INFO] [stdout] ... | [INFO] [stdout] 178 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 169 ~ if let Ok(content) = read_to_string(&path).await [INFO] [stdout] 170 ~ && content [INFO] [stdout] 171 | .to_lowercase() [INFO] [stdout] ... [INFO] [stdout] 176 | ); [INFO] [stdout] 177 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/projects/fpm.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | if !metadata("fpm.toml").await.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `metadata("fpm.toml").await.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/projects/uv.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | if !metadata("pyproject.toml").await.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `metadata("pyproject.toml").await.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/projects/uv.rs:18:17 [INFO] [stdout] | [INFO] [stdout] 18 | / if let Some((_, rest)) = line.split_once('"') { [INFO] [stdout] 19 | | if let Some((name, _)) = rest.split_once('"') { [INFO] [stdout] 20 | | project_name = name.to_string(); [INFO] [stdout] 21 | | } [INFO] [stdout] 22 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 18 ~ if let Some((_, rest)) = line.split_once('"') [INFO] [stdout] 19 ~ && let Some((name, _)) = rest.split_once('"') { [INFO] [stdout] 20 | project_name = name.to_string(); [INFO] [stdout] 21 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/projects/uv.rs:23:20 [INFO] [stdout] | [INFO] [stdout] 23 | } else if line.starts_with("version = ") { [INFO] [stdout] | ____________________^ [INFO] [stdout] 24 | | if let Some((_, rest)) = line.split_once('"') { [INFO] [stdout] 25 | | if let Some((version, _)) = rest.split_once('"') { [INFO] [stdout] 26 | | project_version = version.to_string(); [INFO] [stdout] ... | [INFO] [stdout] 29 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 23 ~ } else if line.starts_with("version = ") [INFO] [stdout] 24 ~ && let Some((_, rest)) = line.split_once('"') { [INFO] [stdout] 25 | if let Some((version, _)) = rest.split_once('"') { [INFO] [stdout] 26 | project_version = version.to_string(); [INFO] [stdout] 27 | } [INFO] [stdout] 28 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/projects/uv.rs:24:17 [INFO] [stdout] | [INFO] [stdout] 24 | / if let Some((_, rest)) = line.split_once('"') { [INFO] [stdout] 25 | | if let Some((version, _)) = rest.split_once('"') { [INFO] [stdout] 26 | | project_version = version.to_string(); [INFO] [stdout] 27 | | } [INFO] [stdout] 28 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 24 ~ if let Some((_, rest)) = line.split_once('"') [INFO] [stdout] 25 ~ && let Some((version, _)) = rest.split_once('"') { [INFO] [stdout] 26 | project_version = version.to_string(); [INFO] [stdout] 27 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/tasks/task.rs:290:12 [INFO] [stdout] | [INFO] [stdout] 290 | tasks: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] = note: `#[warn(clippy::vec_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/tasks/task.rs:314:50 [INFO] [stdout] | [INFO] [stdout] 314 | fn get_task_by_id(&self, id: &str) -> Option<&Box> { [INFO] [stdout] | ^^^^^^^^^^ help: try: `&Task` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] = note: `#[warn(clippy::borrowed_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/tasks/task.rs:372:17 [INFO] [stdout] | [INFO] [stdout] 372 | while let Some(entry_result) = entries.next_entry().await.ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] help: consider matching on `Ok(entry_result)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 372 - while let Some(entry_result) = entries.next_entry().await.ok() { [INFO] [stdout] 372 + while let Ok(entry_result) = entries.next_entry().await { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tasks/task.rs:375:25 [INFO] [stdout] | [INFO] [stdout] 375 | / if path.is_file() && path.extension().unwrap_or_default() == "o" { [INFO] [stdout] 376 | | if let Some(path_str) = path.to_str() { [INFO] [stdout] 377 | | files.push(path_str.to_string()); [INFO] [stdout] 378 | | } [INFO] [stdout] 379 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 375 ~ if path.is_file() && path.extension().unwrap_or_default() == "o" [INFO] [stdout] 376 ~ && let Some(path_str) = path.to_str() { [INFO] [stdout] 377 | files.push(path_str.to_string()); [INFO] [stdout] 378 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/tasks/task.rs:444:17 [INFO] [stdout] | [INFO] [stdout] 444 | while let Some(entry_result) = entries.next_entry().await.ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] help: consider matching on `Ok(entry_result)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 444 - while let Some(entry_result) = entries.next_entry().await.ok() { [INFO] [stdout] 444 + while let Ok(entry_result) = entries.next_entry().await { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tasks/task.rs:447:25 [INFO] [stdout] | [INFO] [stdout] 447 | / if path.is_file() && path.extension().unwrap_or_default() == "o" { [INFO] [stdout] 448 | | if let Some(path_str) = path.to_str() { [INFO] [stdout] 449 | | files.push(path_str.to_string()); [INFO] [stdout] 450 | | } [INFO] [stdout] 451 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 447 ~ if path.is_file() && path.extension().unwrap_or_default() == "o" [INFO] [stdout] 448 ~ && let Some(path_str) = path.to_str() { [INFO] [stdout] 449 | files.push(path_str.to_string()); [INFO] [stdout] 450 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/dash.rs:51:31 [INFO] [stdout] | [INFO] [stdout] 51 | if !is_fpm && !metadata(target_debug).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `metadata(target_debug).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/commands/dash.rs:119:14 [INFO] [stdout] | [INFO] [stdout] 119 | .expect(format!("Failed to execute {}", target_debug).as_str()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to execute {}", target_debug))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/doctor.rs:13:24 [INFO] [stdout] | [INFO] [stdout] 13 | let is_first_run = !metadata("lox.toml").await.is_ok(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `metadata("lox.toml").await.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/commands/doctor.rs:28:14 [INFO] [stdout] | [INFO] [stdout] 28 | .trim() [INFO] [stdout] | ______________^ [INFO] [stdout] 29 | | .split_whitespace() [INFO] [stdout] | |_____________^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] = note: `#[warn(clippy::trim_split_whitespace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/commands/doctor.rs:42:14 [INFO] [stdout] | [INFO] [stdout] 42 | .trim() [INFO] [stdout] | ______________^ [INFO] [stdout] 43 | | .split_whitespace() [INFO] [stdout] | |_____________^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/commands/doctor.rs:68:22 [INFO] [stdout] | [INFO] [stdout] 68 | .trim() [INFO] [stdout] | ______________________^ [INFO] [stdout] 69 | | .split_whitespace() [INFO] [stdout] | |_____________________^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/run.rs:47:31 [INFO] [stdout] | [INFO] [stdout] 47 | if !is_fpm && !metadata(target_release).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `metadata(target_release).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/commands/run.rs:118:14 [INFO] [stdout] | [INFO] [stdout] 118 | .expect(format!("Failed to execute {}", target_release).as_str()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to execute {}", target_release))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/projects/cargo.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | if !metadata("Cargo.toml").await.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `metadata("Cargo.toml").await.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/projects/cargo.rs:18:17 [INFO] [stdout] | [INFO] [stdout] 18 | / if let Some((_, rest)) = line.split_once('"') { [INFO] [stdout] 19 | | if let Some((name, _)) = rest.split_once('"') { [INFO] [stdout] 20 | | project_name = name.to_string(); [INFO] [stdout] 21 | | } [INFO] [stdout] 22 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 18 ~ if let Some((_, rest)) = line.split_once('"') [INFO] [stdout] 19 ~ && let Some((name, _)) = rest.split_once('"') { [INFO] [stdout] 20 | project_name = name.to_string(); [INFO] [stdout] 21 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/projects/cargo.rs:24:17 [INFO] [stdout] | [INFO] [stdout] 24 | / if let Some((_, rest)) = line.split_once('"') { [INFO] [stdout] 25 | | if let Some((version, _)) = rest.split_once('"') { [INFO] [stdout] 26 | | project_version = version.to_string(); [INFO] [stdout] 27 | | } [INFO] [stdout] 28 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 24 ~ if let Some((_, rest)) = line.split_once('"') [INFO] [stdout] 25 ~ && let Some((version, _)) = rest.split_once('"') { [INFO] [stdout] 26 | project_version = version.to_string(); [INFO] [stdout] 27 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/projects/flang.rs:11:13 [INFO] [stdout] | [INFO] [stdout] 11 | while let Some(entry_result) = entries.next_entry().await.ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] = note: `#[warn(clippy::match_result_ok)]` on by default [INFO] [stdout] help: consider matching on `Ok(entry_result)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 11 - while let Some(entry_result) = entries.next_entry().await.ok() { [INFO] [stdout] 11 + while let Ok(entry_result) = entries.next_entry().await { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/projects/flang.rs:14:21 [INFO] [stdout] | [INFO] [stdout] 14 | / if path.is_file() { [INFO] [stdout] 15 | | if let Some(extension) = path.extension() { [INFO] [stdout] 16 | | let ext = extension.to_str().unwrap_or(""); [INFO] [stdout] 17 | | if ext == "f90" || ext == "f" || ext == "F90" || ext == "F" { [INFO] [stdout] ... | [INFO] [stdout] 22 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 14 ~ if path.is_file() [INFO] [stdout] 15 ~ && let Some(extension) = path.extension() { [INFO] [stdout] 16 | let ext = extension.to_str().unwrap_or(""); [INFO] [stdout] ... [INFO] [stdout] 20 | } [INFO] [stdout] 21 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/projects/flang.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | while let Some(entry_result) = entries.next_entry().await.ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] help: consider matching on `Ok(entry_result)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 66 - while let Some(entry_result) = entries.next_entry().await.ok() { [INFO] [stdout] 66 + while let Ok(entry_result) = entries.next_entry().await { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/projects/flang.rs:69:17 [INFO] [stdout] | [INFO] [stdout] 69 | / if path.is_file() { [INFO] [stdout] 70 | | if let Some(extension) = path.extension() { [INFO] [stdout] 71 | | let ext = extension.to_str().unwrap_or(""); [INFO] [stdout] 72 | | if ext == "f90" || ext == "f" || ext == "F90" || ext == "F" { [INFO] [stdout] ... | [INFO] [stdout] 86 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 69 ~ if path.is_file() [INFO] [stdout] 70 ~ && let Some(extension) = path.extension() { [INFO] [stdout] 71 | let ext = extension.to_str().unwrap_or(""); [INFO] [stdout] ... [INFO] [stdout] 84 | } [INFO] [stdout] 85 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/projects/flang.rs:72:25 [INFO] [stdout] | [INFO] [stdout] 72 | / if ext == "f90" || ext == "f" || ext == "F90" || ext == "F" { [INFO] [stdout] 73 | | if let Ok(content) = read_to_string(&path).await { [INFO] [stdout] 74 | | // Check each line for program declaration at the beginning [INFO] [stdout] 75 | | for line in content.lines() { [INFO] [stdout] ... | [INFO] [stdout] 84 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 72 ~ if (ext == "f90" || ext == "f" || ext == "F90" || ext == "F") { [INFO] [stdout] 73 ~ && let Ok(content) = read_to_string(&path).await { [INFO] [stdout] 74 | // Check each line for program declaration at the beginning [INFO] [stdout] ... [INFO] [stdout] 82 | } [INFO] [stdout] 83 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/projects/flang.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | while let Some(entry_result) = entries.next_entry().await.ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] help: consider matching on `Ok(entry_result)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 99 - while let Some(entry_result) = entries.next_entry().await.ok() { [INFO] [stdout] 99 + while let Ok(entry_result) = entries.next_entry().await { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/projects/flang.rs:102:17 [INFO] [stdout] | [INFO] [stdout] 102 | / if path.is_file() { [INFO] [stdout] 103 | | if let Some(extension) = path.extension() { [INFO] [stdout] 104 | | let ext = extension.to_str().unwrap_or(""); [INFO] [stdout] 105 | | if ext == "f90" || ext == "f" || ext == "F90" || ext == "F" { [INFO] [stdout] ... | [INFO] [stdout] 111 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 102 ~ if path.is_file() [INFO] [stdout] 103 ~ && let Some(extension) = path.extension() { [INFO] [stdout] 104 | let ext = extension.to_str().unwrap_or(""); [INFO] [stdout] ... [INFO] [stdout] 109 | } [INFO] [stdout] 110 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/projects/flang.rs:146:81 [INFO] [stdout] | [INFO] [stdout] 146 | if include_path.starts_with('"') && include_path.ends_with('"') { [INFO] [stdout] | _________________________________________________________________________________^ [INFO] [stdout] 147 | | include_path = &include_path[1..include_path.len() - 1]; [INFO] [stdout] 148 | | } else if include_path.starts_with('\'') && include_path.ends_with('\'') { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/projects/flang.rs:148:90 [INFO] [stdout] | [INFO] [stdout] 148 | } else if include_path.starts_with('\'') && include_path.ends_with('\'') { [INFO] [stdout] | __________________________________________________________________________________________^ [INFO] [stdout] 149 | | include_path = &include_path[1..include_path.len() - 1]; [INFO] [stdout] 150 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/projects/flang.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 162 | while let Some(entry_result) = entries.next_entry().await.ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] help: consider matching on `Ok(entry_result)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 162 - while let Some(entry_result) = entries.next_entry().await.ok() { [INFO] [stdout] 162 + while let Ok(entry_result) = entries.next_entry().await { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/projects/flang.rs:165:17 [INFO] [stdout] | [INFO] [stdout] 165 | / if path.is_file() { [INFO] [stdout] 166 | | if let Some(extension) = path.extension() { [INFO] [stdout] 167 | | let ext = extension.to_str().unwrap_or(""); [INFO] [stdout] 168 | | if ext == "f90" || ext == "f" || ext == "F90" || ext == "F" { [INFO] [stdout] ... | [INFO] [stdout] 181 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 165 ~ if path.is_file() [INFO] [stdout] 166 ~ && let Some(extension) = path.extension() { [INFO] [stdout] 167 | let ext = extension.to_str().unwrap_or(""); [INFO] [stdout] ... [INFO] [stdout] 179 | } [INFO] [stdout] 180 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/projects/flang.rs:168:25 [INFO] [stdout] | [INFO] [stdout] 168 | / if ext == "f90" || ext == "f" || ext == "F90" || ext == "F" { [INFO] [stdout] 169 | | if let Ok(content) = read_to_string(&path).await { [INFO] [stdout] 170 | | if content [INFO] [stdout] 171 | | .to_lowercase() [INFO] [stdout] ... | [INFO] [stdout] 179 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 168 ~ if (ext == "f90" || ext == "f" || ext == "F90" || ext == "F") { [INFO] [stdout] 169 ~ && let Ok(content) = read_to_string(&path).await { [INFO] [stdout] 170 | if content [INFO] [stdout] ... [INFO] [stdout] 177 | } [INFO] [stdout] 178 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/projects/flang.rs:169:29 [INFO] [stdout] | [INFO] [stdout] 169 | / ... if let Ok(content) = read_to_string(&path).await { [INFO] [stdout] 170 | | ... if content [INFO] [stdout] 171 | | ... .to_lowercase() [INFO] [stdout] 172 | | ... .contains(&format!("module {}", module_name)) [INFO] [stdout] ... | [INFO] [stdout] 178 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 169 ~ if let Ok(content) = read_to_string(&path).await [INFO] [stdout] 170 ~ && content [INFO] [stdout] 171 | .to_lowercase() [INFO] [stdout] ... [INFO] [stdout] 176 | ); [INFO] [stdout] 177 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/projects/fpm.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | if !metadata("fpm.toml").await.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `metadata("fpm.toml").await.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/projects/uv.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | if !metadata("pyproject.toml").await.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `metadata("pyproject.toml").await.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/projects/uv.rs:18:17 [INFO] [stdout] | [INFO] [stdout] 18 | / if let Some((_, rest)) = line.split_once('"') { [INFO] [stdout] 19 | | if let Some((name, _)) = rest.split_once('"') { [INFO] [stdout] 20 | | project_name = name.to_string(); [INFO] [stdout] 21 | | } [INFO] [stdout] 22 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 18 ~ if let Some((_, rest)) = line.split_once('"') [INFO] [stdout] 19 ~ && let Some((name, _)) = rest.split_once('"') { [INFO] [stdout] 20 | project_name = name.to_string(); [INFO] [stdout] 21 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/projects/uv.rs:23:20 [INFO] [stdout] | [INFO] [stdout] 23 | } else if line.starts_with("version = ") { [INFO] [stdout] | ____________________^ [INFO] [stdout] 24 | | if let Some((_, rest)) = line.split_once('"') { [INFO] [stdout] 25 | | if let Some((version, _)) = rest.split_once('"') { [INFO] [stdout] 26 | | project_version = version.to_string(); [INFO] [stdout] ... | [INFO] [stdout] 29 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 23 ~ } else if line.starts_with("version = ") [INFO] [stdout] 24 ~ && let Some((_, rest)) = line.split_once('"') { [INFO] [stdout] 25 | if let Some((version, _)) = rest.split_once('"') { [INFO] [stdout] 26 | project_version = version.to_string(); [INFO] [stdout] 27 | } [INFO] [stdout] 28 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/projects/uv.rs:24:17 [INFO] [stdout] | [INFO] [stdout] 24 | / if let Some((_, rest)) = line.split_once('"') { [INFO] [stdout] 25 | | if let Some((version, _)) = rest.split_once('"') { [INFO] [stdout] 26 | | project_version = version.to_string(); [INFO] [stdout] 27 | | } [INFO] [stdout] 28 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 24 ~ if let Some((_, rest)) = line.split_once('"') [INFO] [stdout] 25 ~ && let Some((version, _)) = rest.split_once('"') { [INFO] [stdout] 26 | project_version = version.to_string(); [INFO] [stdout] 27 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/tasks/task.rs:290:12 [INFO] [stdout] | [INFO] [stdout] 290 | tasks: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] = note: `#[warn(clippy::vec_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/tasks/task.rs:314:50 [INFO] [stdout] | [INFO] [stdout] 314 | fn get_task_by_id(&self, id: &str) -> Option<&Box> { [INFO] [stdout] | ^^^^^^^^^^ help: try: `&Task` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] = note: `#[warn(clippy::borrowed_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/tasks/task.rs:372:17 [INFO] [stdout] | [INFO] [stdout] 372 | while let Some(entry_result) = entries.next_entry().await.ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] help: consider matching on `Ok(entry_result)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 372 - while let Some(entry_result) = entries.next_entry().await.ok() { [INFO] [stdout] 372 + while let Ok(entry_result) = entries.next_entry().await { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tasks/task.rs:375:25 [INFO] [stdout] | [INFO] [stdout] 375 | / if path.is_file() && path.extension().unwrap_or_default() == "o" { [INFO] [stdout] 376 | | if let Some(path_str) = path.to_str() { [INFO] [stdout] 377 | | files.push(path_str.to_string()); [INFO] [stdout] 378 | | } [INFO] [stdout] 379 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 375 ~ if path.is_file() && path.extension().unwrap_or_default() == "o" [INFO] [stdout] 376 ~ && let Some(path_str) = path.to_str() { [INFO] [stdout] 377 | files.push(path_str.to_string()); [INFO] [stdout] 378 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/tasks/task.rs:444:17 [INFO] [stdout] | [INFO] [stdout] 444 | while let Some(entry_result) = entries.next_entry().await.ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] help: consider matching on `Ok(entry_result)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 444 - while let Some(entry_result) = entries.next_entry().await.ok() { [INFO] [stdout] 444 + while let Ok(entry_result) = entries.next_entry().await { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tasks/task.rs:447:25 [INFO] [stdout] | [INFO] [stdout] 447 | / if path.is_file() && path.extension().unwrap_or_default() == "o" { [INFO] [stdout] 448 | | if let Some(path_str) = path.to_str() { [INFO] [stdout] 449 | | files.push(path_str.to_string()); [INFO] [stdout] 450 | | } [INFO] [stdout] 451 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 447 ~ if path.is_file() && path.extension().unwrap_or_default() == "o" [INFO] [stdout] 448 ~ && let Some(path_str) = path.to_str() { [INFO] [stdout] 449 | files.push(path_str.to_string()); [INFO] [stdout] 450 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.60s [INFO] running `Command { std: "docker" "inspect" "e90fa876404e87c637dfa52d62b2e2618f6d97419d3d1186753bc54ac7f82dcf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e90fa876404e87c637dfa52d62b2e2618f6d97419d3d1186753bc54ac7f82dcf", kill_on_drop: false }` [INFO] [stdout] e90fa876404e87c637dfa52d62b2e2618f6d97419d3d1186753bc54ac7f82dcf