[INFO] cloning repository https://github.com/East-China-Gold-Medal/co-digits-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/East-China-Gold-Medal/co-digits-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEast-China-Gold-Medal%2Fco-digits-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEast-China-Gold-Medal%2Fco-digits-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5879df2fb4f20c38ecfa1de5d0dddb836a58400d [INFO] linting East-China-Gold-Medal/co-digits-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEast-China-Gold-Medal%2Fco-digits-rs" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/East-China-Gold-Medal/co-digits-rs [INFO] finished tweaking git repo https://github.com/East-China-Gold-Medal/co-digits-rs [INFO] tweaked toml for git repo https://github.com/East-China-Gold-Medal/co-digits-rs written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/East-China-Gold-Medal/co-digits-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/East-China-Gold-Medal/co-digits-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9fc59eab82dafc5e93d2b54a3eecb912c75856f6310ce6e00f5798f6e74cc0f2 [INFO] running `Command { std: "docker" "start" "-a" "9fc59eab82dafc5e93d2b54a3eecb912c75856f6310ce6e00f5798f6e74cc0f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9fc59eab82dafc5e93d2b54a3eecb912c75856f6310ce6e00f5798f6e74cc0f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9fc59eab82dafc5e93d2b54a3eecb912c75856f6310ce6e00f5798f6e74cc0f2", kill_on_drop: false }` [INFO] [stdout] 9fc59eab82dafc5e93d2b54a3eecb912c75856f6310ce6e00f5798f6e74cc0f2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5c5620d21538ab946c51d43adbd5ba64fbe875ecd39731ca6c30ea9222519bfa [INFO] running `Command { std: "docker" "start" "-a" "5c5620d21538ab946c51d43adbd5ba64fbe875ecd39731ca6c30ea9222519bfa", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking co-digits-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `Div` and `Mul` [INFO] [stdout] --> src/operation.rs:2:26 [INFO] [stdout] | [INFO] [stdout] 2 | use std::ops::{Add, Sub, Mul, Div, Neg}; [INFO] [stdout] | ^^^ ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Div` and `Mul` [INFO] [stdout] --> src/operation.rs:2:26 [INFO] [stdout] | [INFO] [stdout] 2 | use std::ops::{Add, Sub, Mul, Div, Neg}; [INFO] [stdout] | ^^^ ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `UInt32` [INFO] [stdout] --> src/integer.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn new() -> Self { [INFO] [stdout] 15 | | return Self { [INFO] [stdout] 16 | | bits: [false; 32] [INFO] [stdout] 17 | | } [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 13 + impl Default for UInt32 { [INFO] [stdout] 14 + fn default() -> Self { [INFO] [stdout] 15 + Self::new() [INFO] [stdout] 16 + } [INFO] [stdout] 17 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/integer.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | / return Self { [INFO] [stdout] 16 | | bits: [false; 32] [INFO] [stdout] 17 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 ~ Self { [INFO] [stdout] 16 + bits: [false; 32] [INFO] [stdout] 17 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Int32` [INFO] [stdout] --> src/integer.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | / pub fn new() -> Self { [INFO] [stdout] 23 | | return Self { [INFO] [stdout] 24 | | bits: [false; 32] [INFO] [stdout] 25 | | } [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 21 + impl Default for Int32 { [INFO] [stdout] 22 + fn default() -> Self { [INFO] [stdout] 23 + Self::new() [INFO] [stdout] 24 + } [INFO] [stdout] 25 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/integer.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | / return Self { [INFO] [stdout] 24 | | bits: [false; 32] [INFO] [stdout] 25 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 ~ Self { [INFO] [stdout] 24 + bits: [false; 32] [INFO] [stdout] 25 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/integer.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return false; [INFO] [stdout] 36 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/integer.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return &self.bits; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return &self.bits; [INFO] [stdout] 40 + &self.bits [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/integer.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | return self.bits[0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return self.bits[0]; [INFO] [stdout] 51 + self.bits[0] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/integer.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | return &self.bits; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return &self.bits; [INFO] [stdout] 55 + &self.bits [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/integer.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | return int32; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return int32; [INFO] [stdout] 72 + int32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/integer.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | return uint32; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - return uint32; [INFO] [stdout] 88 + uint32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/float.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | / return Self { [INFO] [stdout] 18 | | bits: [false; 32] [INFO] [stdout] 19 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 ~ Self { [INFO] [stdout] 18 + bits: [false; 32] [INFO] [stdout] 19 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/float.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | / return Self { [INFO] [stdout] 26 | | bits: [false; 64] [INFO] [stdout] 27 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 ~ Self { [INFO] [stdout] 26 + bits: [false; 64] [INFO] [stdout] 27 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/float.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | return float32; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return float32; [INFO] [stdout] 47 + float32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/float.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | return float64; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return float64; [INFO] [stdout] 67 + float64 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/float.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | return &self.bits; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return &self.bits; [INFO] [stdout] 79 + &self.bits [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/float.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | / return self.exponent_bits().iter() [INFO] [stdout] 91 | | .zip(pows) [INFO] [stdout] 92 | | .map(|(bit, pow)| { [INFO] [stdout] 93 | | if *bit { [INFO] [stdout] ... | [INFO] [stdout] 98 | | }).fold(Self::BIAS, |r, x| r + x); [INFO] [stdout] | |_____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 ~ self.exponent_bits().iter() [INFO] [stdout] 91 + .zip(pows) [INFO] [stdout] 92 + .map(|(bit, pow)| { [INFO] [stdout] 93 + if *bit { [INFO] [stdout] 94 + pow [INFO] [stdout] 95 + } else { [INFO] [stdout] 96 + 0 [INFO] [stdout] 97 + } [INFO] [stdout] 98 ~ }).fold(Self::BIAS, |r, x| r + x) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `UInt32` [INFO] [stdout] --> src/integer.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn new() -> Self { [INFO] [stdout] 15 | | return Self { [INFO] [stdout] 16 | | bits: [false; 32] [INFO] [stdout] 17 | | } [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 13 + impl Default for UInt32 { [INFO] [stdout] 14 + fn default() -> Self { [INFO] [stdout] 15 + Self::new() [INFO] [stdout] 16 + } [INFO] [stdout] 17 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/integer.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | / return Self { [INFO] [stdout] 16 | | bits: [false; 32] [INFO] [stdout] 17 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 ~ Self { [INFO] [stdout] 16 + bits: [false; 32] [INFO] [stdout] 17 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Int32` [INFO] [stdout] --> src/integer.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | / pub fn new() -> Self { [INFO] [stdout] 23 | | return Self { [INFO] [stdout] 24 | | bits: [false; 32] [INFO] [stdout] 25 | | } [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 21 + impl Default for Int32 { [INFO] [stdout] 22 + fn default() -> Self { [INFO] [stdout] 23 + Self::new() [INFO] [stdout] 24 + } [INFO] [stdout] 25 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/integer.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | / return Self { [INFO] [stdout] 24 | | bits: [false; 32] [INFO] [stdout] 25 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 ~ Self { [INFO] [stdout] 24 + bits: [false; 32] [INFO] [stdout] 25 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/float.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | / return self.fraction_bits().iter() [INFO] [stdout] 107 | | .zip(pows) [INFO] [stdout] 108 | | .map(|(bit, pow)| { [INFO] [stdout] 109 | | if *bit { [INFO] [stdout] ... | [INFO] [stdout] 114 | | }).fold(1.0, |r, x| r + x); [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 ~ self.fraction_bits().iter() [INFO] [stdout] 107 + .zip(pows) [INFO] [stdout] 108 + .map(|(bit, pow)| { [INFO] [stdout] 109 + if *bit { [INFO] [stdout] 110 + pow [INFO] [stdout] 111 + } else { [INFO] [stdout] 112 + 0.0 [INFO] [stdout] 113 + } [INFO] [stdout] 114 ~ }).fold(1.0, |r, x| r + x) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/integer.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return false; [INFO] [stdout] 36 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/float.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | / return if is_negative { [INFO] [stdout] 124 | | -result [INFO] [stdout] 125 | | } else { [INFO] [stdout] 126 | | result [INFO] [stdout] 127 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 ~ if is_negative { [INFO] [stdout] 124 + -result [INFO] [stdout] 125 + } else { [INFO] [stdout] 126 + result [INFO] [stdout] 127 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/integer.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return &self.bits; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return &self.bits; [INFO] [stdout] 40 + &self.bits [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/integer.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | return self.bits[0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return self.bits[0]; [INFO] [stdout] 51 + self.bits[0] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/float.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | return &self.bits; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 - return &self.bits; [INFO] [stdout] 139 + &self.bits [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/integer.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | return &self.bits; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return &self.bits; [INFO] [stdout] 55 + &self.bits [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/integer.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | return int32; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return int32; [INFO] [stdout] 72 + int32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/float.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | / return self.exponent_bits().iter() [INFO] [stdout] 151 | | .zip(pows) [INFO] [stdout] 152 | | .map(|(bit, pow)| { [INFO] [stdout] 153 | | if *bit { [INFO] [stdout] ... | [INFO] [stdout] 158 | | }).fold(Self::BIAS, |r, x| r + x); [INFO] [stdout] | |_____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 150 ~ self.exponent_bits().iter() [INFO] [stdout] 151 + .zip(pows) [INFO] [stdout] 152 + .map(|(bit, pow)| { [INFO] [stdout] 153 + if *bit { [INFO] [stdout] 154 + pow [INFO] [stdout] 155 + } else { [INFO] [stdout] 156 + 0 [INFO] [stdout] 157 + } [INFO] [stdout] 158 ~ }).fold(Self::BIAS, |r, x| r + x) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/integer.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | return uint32; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - return uint32; [INFO] [stdout] 88 + uint32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/float.rs:166:9 [INFO] [stdout] | [INFO] [stdout] 166 | / return self.fraction_bits().iter() [INFO] [stdout] 167 | | .zip(pows) [INFO] [stdout] 168 | | .map(|(bit, pow)| { [INFO] [stdout] 169 | | if *bit { [INFO] [stdout] ... | [INFO] [stdout] 174 | | }).fold(1.0, |r, x| r + x); [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 166 ~ self.fraction_bits().iter() [INFO] [stdout] 167 + .zip(pows) [INFO] [stdout] 168 + .map(|(bit, pow)| { [INFO] [stdout] 169 + if *bit { [INFO] [stdout] 170 + pow [INFO] [stdout] 171 + } else { [INFO] [stdout] 172 + 0.0 [INFO] [stdout] 173 + } [INFO] [stdout] 174 ~ }).fold(1.0, |r, x| r + x) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/float.rs:183:9 [INFO] [stdout] | [INFO] [stdout] 183 | / return if is_negative { [INFO] [stdout] 184 | | -result [INFO] [stdout] 185 | | } else { [INFO] [stdout] 186 | | result [INFO] [stdout] 187 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 183 ~ if is_negative { [INFO] [stdout] 184 + -result [INFO] [stdout] 185 + } else { [INFO] [stdout] 186 + result [INFO] [stdout] 187 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/float.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | / return Self { [INFO] [stdout] 18 | | bits: [false; 32] [INFO] [stdout] 19 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 ~ Self { [INFO] [stdout] 18 + bits: [false; 32] [INFO] [stdout] 19 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/float.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | / return Self { [INFO] [stdout] 26 | | bits: [false; 64] [INFO] [stdout] 27 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 ~ Self { [INFO] [stdout] 26 + bits: [false; 64] [INFO] [stdout] 27 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/operation.rs:18:21 [INFO] [stdout] | [INFO] [stdout] 18 | carry = (left && right) || (right && carry); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 18 - carry = (left && right) || (right && carry); [INFO] [stdout] 18 + carry = !(!right || !left && !carry); [INFO] [stdout] | [INFO] [stdout] 18 - carry = (left && right) || (right && carry); [INFO] [stdout] 18 + carry = (carry || left) && right; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/float.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | return float32; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return float32; [INFO] [stdout] 47 + float32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / return if carry { [INFO] [stdout] 22 | | Err(OverflowException) [INFO] [stdout] 23 | | } else { [INFO] [stdout] 24 | | Ok(result) [INFO] [stdout] 25 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 ~ if carry { [INFO] [stdout] 22 + Err(OverflowException) [INFO] [stdout] 23 + } else { [INFO] [stdout] 24 + Ok(result) [INFO] [stdout] 25 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/float.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | return float64; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return float64; [INFO] [stdout] 67 + float64 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return result; [INFO] [stdout] 44 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/float.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | return &self.bits; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return &self.bits; [INFO] [stdout] 79 + &self.bits [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/float.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | / return self.exponent_bits().iter() [INFO] [stdout] 91 | | .zip(pows) [INFO] [stdout] 92 | | .map(|(bit, pow)| { [INFO] [stdout] 93 | | if *bit { [INFO] [stdout] ... | [INFO] [stdout] 98 | | }).fold(Self::BIAS, |r, x| r + x); [INFO] [stdout] | |_____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 ~ self.exponent_bits().iter() [INFO] [stdout] 91 + .zip(pows) [INFO] [stdout] 92 + .map(|(bit, pow)| { [INFO] [stdout] 93 + if *bit { [INFO] [stdout] 94 + pow [INFO] [stdout] 95 + } else { [INFO] [stdout] 96 + 0 [INFO] [stdout] 97 + } [INFO] [stdout] 98 ~ }).fold(Self::BIAS, |r, x| r + x) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/operation.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | result[index] = result[index] ^ carry; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result[index] ^= carry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/operation.rs:60:21 [INFO] [stdout] | [INFO] [stdout] 60 | carry = (left && right) || (right && carry); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 60 - carry = (left && right) || (right && carry); [INFO] [stdout] 60 + carry = !(!right || !left && !carry); [INFO] [stdout] | [INFO] [stdout] 60 - carry = (left && right) || (right && carry); [INFO] [stdout] 60 + carry = (carry || left) && right; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | / return if result > self { [INFO] [stdout] 64 | | Err(OverflowException) [INFO] [stdout] 65 | | } else { [INFO] [stdout] 66 | | Ok(result) [INFO] [stdout] 67 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 ~ if result > self { [INFO] [stdout] 64 + Err(OverflowException) [INFO] [stdout] 65 + } else { [INFO] [stdout] 66 + Ok(result) [INFO] [stdout] 67 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/float.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | / return self.fraction_bits().iter() [INFO] [stdout] 107 | | .zip(pows) [INFO] [stdout] 108 | | .map(|(bit, pow)| { [INFO] [stdout] 109 | | if *bit { [INFO] [stdout] ... | [INFO] [stdout] 114 | | }).fold(1.0, |r, x| r + x); [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 ~ self.fraction_bits().iter() [INFO] [stdout] 107 + .zip(pows) [INFO] [stdout] 108 + .map(|(bit, pow)| { [INFO] [stdout] 109 + if *bit { [INFO] [stdout] 110 + pow [INFO] [stdout] 111 + } else { [INFO] [stdout] 112 + 0.0 [INFO] [stdout] 113 + } [INFO] [stdout] 114 ~ }).fold(1.0, |r, x| r + x) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | return self.decode_original_code() <= other.decode_original_code(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return self.decode_original_code() <= other.decode_original_code(); [INFO] [stdout] 73 + self.decode_original_code() <= other.decode_original_code() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | return self.decode_original_code() >= other.decode_original_code(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return self.decode_original_code() >= other.decode_original_code(); [INFO] [stdout] 77 + self.decode_original_code() >= other.decode_original_code() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/float.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | / return if is_negative { [INFO] [stdout] 124 | | -result [INFO] [stdout] 125 | | } else { [INFO] [stdout] 126 | | result [INFO] [stdout] 127 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 ~ if is_negative { [INFO] [stdout] 124 + -result [INFO] [stdout] 125 + } else { [INFO] [stdout] 126 + result [INFO] [stdout] 127 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | return self.decode_original_code() > other.decode_original_code(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - return self.decode_original_code() > other.decode_original_code(); [INFO] [stdout] 81 + self.decode_original_code() > other.decode_original_code() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | return self.decode_original_code() < other.decode_original_code(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return self.decode_original_code() < other.decode_original_code(); [INFO] [stdout] 85 + self.decode_original_code() < other.decode_original_code() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/float.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | return &self.bits; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 - return &self.bits; [INFO] [stdout] 139 + &self.bits [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | return self.decode_original_code().cmp(&other.decode_original_code()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return self.decode_original_code().cmp(&other.decode_original_code()); [INFO] [stdout] 95 + self.decode_original_code().cmp(&other.decode_original_code()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/float.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | / return self.exponent_bits().iter() [INFO] [stdout] 151 | | .zip(pows) [INFO] [stdout] 152 | | .map(|(bit, pow)| { [INFO] [stdout] 153 | | if *bit { [INFO] [stdout] ... | [INFO] [stdout] 158 | | }).fold(Self::BIAS, |r, x| r + x); [INFO] [stdout] | |_____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 150 ~ self.exponent_bits().iter() [INFO] [stdout] 151 + .zip(pows) [INFO] [stdout] 152 + .map(|(bit, pow)| { [INFO] [stdout] 153 + if *bit { [INFO] [stdout] 154 + pow [INFO] [stdout] 155 + } else { [INFO] [stdout] 156 + 0 [INFO] [stdout] 157 + } [INFO] [stdout] 158 ~ }).fold(Self::BIAS, |r, x| r + x) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/operation.rs:112:21 [INFO] [stdout] | [INFO] [stdout] 112 | carry = (left && right) || (right && carry); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 112 - carry = (left && right) || (right && carry); [INFO] [stdout] 112 + carry = !(!right || !left && !carry); [INFO] [stdout] | [INFO] [stdout] 112 - carry = (left && right) || (right && carry); [INFO] [stdout] 112 + carry = (carry || left) && right; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | / return if carry { [INFO] [stdout] 116 | | Err(OverflowException) [INFO] [stdout] 117 | | } else { [INFO] [stdout] 118 | | Ok(result) [INFO] [stdout] 119 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 115 ~ if carry { [INFO] [stdout] 116 + Err(OverflowException) [INFO] [stdout] 117 + } else { [INFO] [stdout] 118 + Ok(result) [INFO] [stdout] 119 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/float.rs:166:9 [INFO] [stdout] | [INFO] [stdout] 166 | / return self.fraction_bits().iter() [INFO] [stdout] 167 | | .zip(pows) [INFO] [stdout] 168 | | .map(|(bit, pow)| { [INFO] [stdout] 169 | | if *bit { [INFO] [stdout] ... | [INFO] [stdout] 174 | | }).fold(1.0, |r, x| r + x); [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 166 ~ self.fraction_bits().iter() [INFO] [stdout] 167 + .zip(pows) [INFO] [stdout] 168 + .map(|(bit, pow)| { [INFO] [stdout] 169 + if *bit { [INFO] [stdout] 170 + pow [INFO] [stdout] 171 + } else { [INFO] [stdout] 172 + 0.0 [INFO] [stdout] 173 + } [INFO] [stdout] 174 ~ }).fold(1.0, |r, x| r + x) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 138 - return result; [INFO] [stdout] 138 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/float.rs:183:9 [INFO] [stdout] | [INFO] [stdout] 183 | / return if is_negative { [INFO] [stdout] 184 | | -result [INFO] [stdout] 185 | | } else { [INFO] [stdout] 186 | | result [INFO] [stdout] 187 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 183 ~ if is_negative { [INFO] [stdout] 184 + -result [INFO] [stdout] 185 + } else { [INFO] [stdout] 186 + result [INFO] [stdout] 187 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/operation.rs:18:21 [INFO] [stdout] | [INFO] [stdout] 18 | carry = (left && right) || (right && carry); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 18 - carry = (left && right) || (right && carry); [INFO] [stdout] 18 + carry = !(!right || !left && !carry); [INFO] [stdout] | [INFO] [stdout] 18 - carry = (left && right) || (right && carry); [INFO] [stdout] 18 + carry = (carry || left) && right; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / return if carry { [INFO] [stdout] 22 | | Err(OverflowException) [INFO] [stdout] 23 | | } else { [INFO] [stdout] 24 | | Ok(result) [INFO] [stdout] 25 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 ~ if carry { [INFO] [stdout] 22 + Err(OverflowException) [INFO] [stdout] 23 + } else { [INFO] [stdout] 24 + Ok(result) [INFO] [stdout] 25 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/operation.rs:134:13 [INFO] [stdout] | [INFO] [stdout] 134 | result[index] = result[index] ^ carry; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result[index] ^= carry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/operation.rs:154:21 [INFO] [stdout] | [INFO] [stdout] 154 | carry = (left && right) || (right && carry); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 154 - carry = (left && right) || (right && carry); [INFO] [stdout] 154 + carry = !(!right || !left && !carry); [INFO] [stdout] | [INFO] [stdout] 154 - carry = (left && right) || (right && carry); [INFO] [stdout] 154 + carry = (carry || left) && right; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 157 | / return if carry { [INFO] [stdout] 158 | | Err(OverflowException) [INFO] [stdout] 159 | | } else { [INFO] [stdout] 160 | | Ok(result) [INFO] [stdout] 161 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 ~ if carry { [INFO] [stdout] 158 + Err(OverflowException) [INFO] [stdout] 159 + } else { [INFO] [stdout] 160 + Ok(result) [INFO] [stdout] 161 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 167 | return self.decode_original_code() <= other.decode_original_code(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 167 - return self.decode_original_code() <= other.decode_original_code(); [INFO] [stdout] 167 + self.decode_original_code() <= other.decode_original_code() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:171:9 [INFO] [stdout] | [INFO] [stdout] 171 | return self.decode_original_code() >= other.decode_original_code(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 171 - return self.decode_original_code() >= other.decode_original_code(); [INFO] [stdout] 171 + self.decode_original_code() >= other.decode_original_code() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return result; [INFO] [stdout] 44 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/operation.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | result[index] = result[index] ^ carry; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result[index] ^= carry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 175 | return self.decode_original_code() > other.decode_original_code(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 175 - return self.decode_original_code() > other.decode_original_code(); [INFO] [stdout] 175 + self.decode_original_code() > other.decode_original_code() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:179:9 [INFO] [stdout] | [INFO] [stdout] 179 | return self.decode_original_code() < other.decode_original_code(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 179 - return self.decode_original_code() < other.decode_original_code(); [INFO] [stdout] 179 + self.decode_original_code() < other.decode_original_code() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/operation.rs:60:21 [INFO] [stdout] | [INFO] [stdout] 60 | carry = (left && right) || (right && carry); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 60 - carry = (left && right) || (right && carry); [INFO] [stdout] 60 + carry = !(!right || !left && !carry); [INFO] [stdout] | [INFO] [stdout] 60 - carry = (left && right) || (right && carry); [INFO] [stdout] 60 + carry = (carry || left) && right; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | / return if result > self { [INFO] [stdout] 64 | | Err(OverflowException) [INFO] [stdout] 65 | | } else { [INFO] [stdout] 66 | | Ok(result) [INFO] [stdout] 67 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 ~ if result > self { [INFO] [stdout] 64 + Err(OverflowException) [INFO] [stdout] 65 + } else { [INFO] [stdout] 66 + Ok(result) [INFO] [stdout] 67 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 189 | return self.decode_original_code().cmp(&other.decode_original_code()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 189 - return self.decode_original_code().cmp(&other.decode_original_code()); [INFO] [stdout] 189 + self.decode_original_code().cmp(&other.decode_original_code()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | return self.decode_original_code() <= other.decode_original_code(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return self.decode_original_code() <= other.decode_original_code(); [INFO] [stdout] 73 + self.decode_original_code() <= other.decode_original_code() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | return self.decode_original_code() >= other.decode_original_code(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return self.decode_original_code() >= other.decode_original_code(); [INFO] [stdout] 77 + self.decode_original_code() >= other.decode_original_code() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | return self.decode_original_code() > other.decode_original_code(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - return self.decode_original_code() > other.decode_original_code(); [INFO] [stdout] 81 + self.decode_original_code() > other.decode_original_code() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | return self.decode_original_code() < other.decode_original_code(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return self.decode_original_code() < other.decode_original_code(); [INFO] [stdout] 85 + self.decode_original_code() < other.decode_original_code() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | return self.decode_original_code().cmp(&other.decode_original_code()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return self.decode_original_code().cmp(&other.decode_original_code()); [INFO] [stdout] 95 + self.decode_original_code().cmp(&other.decode_original_code()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/operation.rs:112:21 [INFO] [stdout] | [INFO] [stdout] 112 | carry = (left && right) || (right && carry); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 112 - carry = (left && right) || (right && carry); [INFO] [stdout] 112 + carry = !(!right || !left && !carry); [INFO] [stdout] | [INFO] [stdout] 112 - carry = (left && right) || (right && carry); [INFO] [stdout] 112 + carry = (carry || left) && right; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | / return if carry { [INFO] [stdout] 116 | | Err(OverflowException) [INFO] [stdout] 117 | | } else { [INFO] [stdout] 118 | | Ok(result) [INFO] [stdout] 119 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 115 ~ if carry { [INFO] [stdout] 116 + Err(OverflowException) [INFO] [stdout] 117 + } else { [INFO] [stdout] 118 + Ok(result) [INFO] [stdout] 119 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:111:9 [INFO] [stdout] | [INFO] [stdout] 111 | return grouped; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 111 - return grouped; [INFO] [stdout] 111 + grouped [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 141 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 141 - return result; [INFO] [stdout] 141 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 138 - return result; [INFO] [stdout] 138 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/operation.rs:134:13 [INFO] [stdout] | [INFO] [stdout] 134 | result[index] = result[index] ^ carry; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result[index] ^= carry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/operation.rs:154:21 [INFO] [stdout] | [INFO] [stdout] 154 | carry = (left && right) || (right && carry); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 154 - carry = (left && right) || (right && carry); [INFO] [stdout] 154 + carry = !(!right || !left && !carry); [INFO] [stdout] | [INFO] [stdout] 154 - carry = (left && right) || (right && carry); [INFO] [stdout] 154 + carry = (carry || left) && right; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 157 | / return if carry { [INFO] [stdout] 158 | | Err(OverflowException) [INFO] [stdout] 159 | | } else { [INFO] [stdout] 160 | | Ok(result) [INFO] [stdout] 161 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 ~ if carry { [INFO] [stdout] 158 + Err(OverflowException) [INFO] [stdout] 159 + } else { [INFO] [stdout] 160 + Ok(result) [INFO] [stdout] 161 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 167 | return self.decode_original_code() <= other.decode_original_code(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 167 - return self.decode_original_code() <= other.decode_original_code(); [INFO] [stdout] 167 + self.decode_original_code() <= other.decode_original_code() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:171:9 [INFO] [stdout] | [INFO] [stdout] 171 | return self.decode_original_code() >= other.decode_original_code(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 171 - return self.decode_original_code() >= other.decode_original_code(); [INFO] [stdout] 171 + self.decode_original_code() >= other.decode_original_code() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 175 | return self.decode_original_code() > other.decode_original_code(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 175 - return self.decode_original_code() > other.decode_original_code(); [INFO] [stdout] 175 + self.decode_original_code() > other.decode_original_code() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:179:9 [INFO] [stdout] | [INFO] [stdout] 179 | return self.decode_original_code() < other.decode_original_code(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 179 - return self.decode_original_code() < other.decode_original_code(); [INFO] [stdout] 179 + self.decode_original_code() < other.decode_original_code() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operation.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 189 | return self.decode_original_code().cmp(&other.decode_original_code()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 189 - return self.decode_original_code().cmp(&other.decode_original_code()); [INFO] [stdout] 189 + self.decode_original_code().cmp(&other.decode_original_code()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:111:9 [INFO] [stdout] | [INFO] [stdout] 111 | return grouped; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 111 - return grouped; [INFO] [stdout] 111 + grouped [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/lib.rs:119:23 [INFO] [stdout] | [INFO] [stdout] 119 | let two = Self::BinarySumOutput::try_from(2); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `u32` to `::BinarySumOutput` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 119 - let two = Self::BinarySumOutput::try_from(2); [INFO] [stdout] 119 + let two = From::from(2); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 141 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 141 - return result; [INFO] [stdout] 141 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 154 | return self.bits()[0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 154 - return self.bits()[0]; [INFO] [stdout] 154 + self.bits()[0] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 159 | return &self.bits()[1..=Self::EXPONENT_SIZE]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 159 - return &self.bits()[1..=Self::EXPONENT_SIZE]; [INFO] [stdout] 159 + &self.bits()[1..=Self::EXPONENT_SIZE] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:164:9 [INFO] [stdout] | [INFO] [stdout] 164 | return min_exponent + Self::BIAS; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 164 - return min_exponent + Self::BIAS; [INFO] [stdout] 164 + min_exponent + Self::BIAS [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | return &self.bits()[Self::EXPONENT_SIZE + 1..=Self::BIT_SIZE - 1]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 169 - return &self.bits()[Self::EXPONENT_SIZE + 1..=Self::BIT_SIZE - 1]; [INFO] [stdout] 169 + &self.bits()[Self::EXPONENT_SIZE + 1..=Self::BIT_SIZE - 1] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:199:9 [INFO] [stdout] | [INFO] [stdout] 199 | return grouped; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 199 - return grouped; [INFO] [stdout] 199 + grouped [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:203:9 [INFO] [stdout] | [INFO] [stdout] 203 | return self.decode_exponent() < Self::min_exponent_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 203 - return self.decode_exponent() < Self::min_exponent_value(); [INFO] [stdout] 203 + self.decode_exponent() < Self::min_exponent_value() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 207 | return self.exponent_bits().iter().all(|bit| *bit) && self.fraction_bits().iter().any(|bit| *bit); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 207 - return self.exponent_bits().iter().all(|bit| *bit) && self.fraction_bits().iter().any(|bit| *bit); [INFO] [stdout] 207 + self.exponent_bits().iter().all(|bit| *bit) && self.fraction_bits().iter().any(|bit| *bit) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 211 | return self.exponent_bits().iter().all(|bit| *bit) && self.fraction_bits().iter().any(|bit| !*bit); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 211 - return self.exponent_bits().iter().all(|bit| *bit) && self.fraction_bits().iter().any(|bit| !*bit); [INFO] [stdout] 211 + self.exponent_bits().iter().all(|bit| *bit) && self.fraction_bits().iter().any(|bit| !*bit) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/float.rs:34:13 [INFO] [stdout] | [INFO] [stdout] 34 | std::mem::transmute(value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unnecessary_transmutes)]` on by default [INFO] [stdout] help: replace this with [INFO] [stdout] | [INFO] [stdout] 34 - std::mem::transmute(value) [INFO] [stdout] 34 + f32::to_bits(value) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/lib.rs:119:23 [INFO] [stdout] | [INFO] [stdout] 119 | let two = Self::BinarySumOutput::try_from(2); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `u32` to `::BinarySumOutput` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 119 - let two = Self::BinarySumOutput::try_from(2); [INFO] [stdout] 119 + let two = From::from(2); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/float.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | std::mem::transmute(value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace this with [INFO] [stdout] | [INFO] [stdout] 54 - std::mem::transmute(value) [INFO] [stdout] 54 + f64::to_bits(value) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 154 | return self.bits()[0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 154 - return self.bits()[0]; [INFO] [stdout] 154 + self.bits()[0] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 159 | return &self.bits()[1..=Self::EXPONENT_SIZE]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 159 - return &self.bits()[1..=Self::EXPONENT_SIZE]; [INFO] [stdout] 159 + &self.bits()[1..=Self::EXPONENT_SIZE] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:164:9 [INFO] [stdout] | [INFO] [stdout] 164 | return min_exponent + Self::BIAS; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 164 - return min_exponent + Self::BIAS; [INFO] [stdout] 164 + min_exponent + Self::BIAS [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | return &self.bits()[Self::EXPONENT_SIZE + 1..=Self::BIT_SIZE - 1]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 169 - return &self.bits()[Self::EXPONENT_SIZE + 1..=Self::BIT_SIZE - 1]; [INFO] [stdout] 169 + &self.bits()[Self::EXPONENT_SIZE + 1..=Self::BIT_SIZE - 1] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:199:9 [INFO] [stdout] | [INFO] [stdout] 199 | return grouped; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 199 - return grouped; [INFO] [stdout] 199 + grouped [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:203:9 [INFO] [stdout] | [INFO] [stdout] 203 | return self.decode_exponent() < Self::min_exponent_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 203 - return self.decode_exponent() < Self::min_exponent_value(); [INFO] [stdout] 203 + self.decode_exponent() < Self::min_exponent_value() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 207 | return self.exponent_bits().iter().all(|bit| *bit) && self.fraction_bits().iter().any(|bit| *bit); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 207 - return self.exponent_bits().iter().all(|bit| *bit) && self.fraction_bits().iter().any(|bit| *bit); [INFO] [stdout] 207 + self.exponent_bits().iter().all(|bit| *bit) && self.fraction_bits().iter().any(|bit| *bit) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 211 | return self.exponent_bits().iter().all(|bit| *bit) && self.fraction_bits().iter().any(|bit| !*bit); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 211 - return self.exponent_bits().iter().all(|bit| *bit) && self.fraction_bits().iter().any(|bit| !*bit); [INFO] [stdout] 211 + self.exponent_bits().iter().all(|bit| *bit) && self.fraction_bits().iter().any(|bit| !*bit) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/float.rs:34:13 [INFO] [stdout] | [INFO] [stdout] 34 | std::mem::transmute(value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unnecessary_transmutes)]` on by default [INFO] [stdout] help: replace this with [INFO] [stdout] | [INFO] [stdout] 34 - std::mem::transmute(value) [INFO] [stdout] 34 + f32::to_bits(value) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/float.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | std::mem::transmute(value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace this with [INFO] [stdout] | [INFO] [stdout] 54 - std::mem::transmute(value) [INFO] [stdout] 54 + f64::to_bits(value) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `OverflowException` [INFO] [stdout] --> tests/test_uint_op.rs:1:20 [INFO] [stdout] | [INFO] [stdout] 1 | use co_digits_rs::{OverflowException, UInt32}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `index` is only used to index `bits` [INFO] [stdout] --> tests/test_float.rs:12:18 [INFO] [stdout] | [INFO] [stdout] 12 | for index in 0..31 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 12 - for index in 0..31 { [INFO] [stdout] 12 + for in bits.iter_mut().take(31) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/test_float.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | / return if *bit { [INFO] [stdout] 25 | | 1 [INFO] [stdout] 26 | | } else { [INFO] [stdout] 27 | | 0 [INFO] [stdout] 28 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 ~ if *bit { [INFO] [stdout] 25 + 1 [INFO] [stdout] 26 + } else { [INFO] [stdout] 27 + 0 [INFO] [stdout] 28 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> tests/test_float.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 6 | std::mem::transmute(number) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unnecessary_transmutes)]` on by default [INFO] [stdout] help: replace this with [INFO] [stdout] | [INFO] [stdout] 6 - std::mem::transmute(number) [INFO] [stdout] 6 + f32::to_bits(number) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> tests/test_uint_op.rs:5:29 [INFO] [stdout] | [INFO] [stdout] 5 | let left = UInt32::from(1 as u32); [INFO] [stdout] | ^^^^^^^^ help: try: `1_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u128` [INFO] [stdout] --> tests/test_pow.rs:5:22 [INFO] [stdout] | [INFO] [stdout] 5 | println!("{:?}", u128::try_from(pow_127)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `u128::try_from()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> tests/test_uint_op.rs:6:30 [INFO] [stdout] | [INFO] [stdout] 6 | let right = UInt32::from(2 as u32); [INFO] [stdout] | ^^^^^^^^ help: try: `2_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/test_pow.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return result; [INFO] [stdout] 14 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.70s [INFO] running `Command { std: "docker" "inspect" "5c5620d21538ab946c51d43adbd5ba64fbe875ecd39731ca6c30ea9222519bfa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c5620d21538ab946c51d43adbd5ba64fbe875ecd39731ca6c30ea9222519bfa", kill_on_drop: false }` [INFO] [stdout] 5c5620d21538ab946c51d43adbd5ba64fbe875ecd39731ca6c30ea9222519bfa