[INFO] cloning repository https://github.com/EVODelavega/dune-graph [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/EVODelavega/dune-graph" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEVODelavega%2Fdune-graph", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEVODelavega%2Fdune-graph'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 55ecbb319dc7ba2d111f3eb00b2a3e61befb6075 [INFO] linting EVODelavega/dune-graph against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEVODelavega%2Fdune-graph" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/EVODelavega/dune-graph [INFO] finished tweaking git repo https://github.com/EVODelavega/dune-graph [INFO] tweaked toml for git repo https://github.com/EVODelavega/dune-graph written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/EVODelavega/dune-graph on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/EVODelavega/dune-graph already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded zmij v1.0.12 [INFO] [stderr] Downloaded sexp v1.1.4 [INFO] [stderr] Downloaded clap v4.5.54 [INFO] [stderr] Downloaded clap_builder v4.5.54 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 626d4728969baf04c18e12c387274c7bc1f66a657b5ce9d3f1b8da51baa2d0a6 [INFO] running `Command { std: "docker" "start" "-a" "626d4728969baf04c18e12c387274c7bc1f66a657b5ce9d3f1b8da51baa2d0a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "626d4728969baf04c18e12c387274c7bc1f66a657b5ce9d3f1b8da51baa2d0a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "626d4728969baf04c18e12c387274c7bc1f66a657b5ce9d3f1b8da51baa2d0a6", kill_on_drop: false }` [INFO] [stdout] 626d4728969baf04c18e12c387274c7bc1f66a657b5ce9d3f1b8da51baa2d0a6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f6aa13e1effdd10c0bbf4a98445f9ee7a955aa95214ef7c8c9cc69268689834e [INFO] running `Command { std: "docker" "start" "-a" "f6aa13e1effdd10c0bbf4a98445f9ee7a955aa95214ef7c8c9cc69268689834e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.105 [INFO] [stderr] Compiling quote v1.0.43 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling zmij v1.0.12 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking is_terminal_polyfill v1.70.2 [INFO] [stderr] Checking anstyle v1.0.13 [INFO] [stderr] Checking anstyle-query v1.1.5 [INFO] [stderr] Checking clap_lex v0.7.6 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Checking sexp v1.1.4 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking clap_builder v4.5.54 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking clap v4.5.54 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking dune-graph v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:99:35 [INFO] [stdout] | [INFO] [stdout] 99 | fn load_opam_export(root_dir: &PathBuf) -> Result> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 99 - fn load_opam_export(root_dir: &PathBuf) -> Result> { [INFO] [stdout] 99 + fn load_opam_export(root_dir: &Path) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:276:41 [INFO] [stdout] | [INFO] [stdout] 276 | / ... if inner.len() >= 2 { [INFO] [stdout] 277 | | ... if let Some(Sexp::Atom(Atom::S(n))) = inner.get(1) { [INFO] [stdout] 278 | | ... name = Some(n.clone()); [INFO] [stdout] 279 | | ... } [INFO] [stdout] 280 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 275 ~ "name" [INFO] [stdout] 276 ~ if inner.len() >= 2 => { [INFO] [stdout] 277 | if let Some(Sexp::Atom(Atom::S(n))) = inner.get(1) { [INFO] [stdout] 278 | name = Some(n.clone()); [INFO] [stdout] 279 | } [INFO] [stdout] 280 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:283:41 [INFO] [stdout] | [INFO] [stdout] 283 | / ... if inner.len() >= 2 { [INFO] [stdout] 284 | | ... if let Some(Sexp::Atom(Atom::S(n))) = inner.get(1) { [INFO] [stdout] 285 | | ... public_name = Some(n.clone()); [INFO] [stdout] 286 | | ... } [INFO] [stdout] 287 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 282 ~ "public_name" [INFO] [stdout] 283 ~ if inner.len() >= 2 => { [INFO] [stdout] 284 | if let Some(Sexp::Atom(Atom::S(n))) = inner.get(1) { [INFO] [stdout] 285 | public_name = Some(n.clone()); [INFO] [stdout] 286 | } [INFO] [stdout] 287 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:290:41 [INFO] [stdout] | [INFO] [stdout] 290 | / ... if inner.len() >= 2 { [INFO] [stdout] 291 | | ... if let Some(Sexp::Atom(Atom::S(n))) = inner.get(1) { [INFO] [stdout] 292 | | ... package = Some(n.clone()); [INFO] [stdout] 293 | | ... } [INFO] [stdout] 294 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 289 ~ "package" [INFO] [stdout] 290 ~ if inner.len() >= 2 => { [INFO] [stdout] 291 | if let Some(Sexp::Atom(Atom::S(n))) = inner.get(1) { [INFO] [stdout] 292 | package = Some(n.clone()); [INFO] [stdout] 293 | } [INFO] [stdout] 294 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:298:41 [INFO] [stdout] | [INFO] [stdout] 298 | / ... if inner.len() >= 2 { [INFO] [stdout] 299 | | ... if let Some(Sexp::Atom(Atom::S(val))) = inner.get(1) { [INFO] [stdout] 300 | | ... if val == "false" { [INFO] [stdout] 301 | | ... enabled = false; [INFO] [stdout] ... | [INFO] [stdout] 304 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 296 ~ "enabled_if" [INFO] [stdout] 297 | // Check if it's (enabled_if false) [INFO] [stdout] 298 ~ if inner.len() >= 2 => { [INFO] [stdout] 299 | if let Some(Sexp::Atom(Atom::S(val))) = inner.get(1) { [INFO] [stdout] ... [INFO] [stdout] 303 | } [INFO] [stdout] 304 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:308:41 [INFO] [stdout] | [INFO] [stdout] 308 | / ... if inner.len() >= 2 { [INFO] [stdout] 309 | | ... if let Some(Sexp::List(names_list)) = inner.get(1) { [INFO] [stdout] 310 | | ... for name_item in names_list { [INFO] [stdout] 311 | | ... if let Sexp::Atom(Atom::S(n)) = name_item { [INFO] [stdout] ... | [INFO] [stdout] 330 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 306 ~ "names" [INFO] [stdout] 307 | // Handle (executables ((names (exe1 exe2 ...)))) [INFO] [stdout] 308 ~ if inner.len() >= 2 => { [INFO] [stdout] 309 | if let Some(Sexp::List(names_list)) = inner.get(1) { [INFO] [stdout] ... [INFO] [stdout] 329 | } [INFO] [stdout] 330 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:99:35 [INFO] [stdout] | [INFO] [stdout] 99 | fn load_opam_export(root_dir: &PathBuf) -> Result> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 99 - fn load_opam_export(root_dir: &PathBuf) -> Result> { [INFO] [stdout] 99 + fn load_opam_export(root_dir: &Path) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:437:41 [INFO] [stdout] | [INFO] [stdout] 437 | / ... if inner.len() >= 2 { [INFO] [stdout] 438 | | ... if let Some(Sexp::Atom(Atom::S(n))) = inner.get(1) { [INFO] [stdout] 439 | | ... name = Some(n.clone()); [INFO] [stdout] 440 | | ... } [INFO] [stdout] 441 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 436 ~ "name" [INFO] [stdout] 437 ~ if inner.len() >= 2 => { [INFO] [stdout] 438 | if let Some(Sexp::Atom(Atom::S(n))) = inner.get(1) { [INFO] [stdout] 439 | name = Some(n.clone()); [INFO] [stdout] 440 | } [INFO] [stdout] 441 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:444:41 [INFO] [stdout] | [INFO] [stdout] 444 | / ... if inner.len() >= 2 { [INFO] [stdout] 445 | | ... if let Some(Sexp::Atom(Atom::S(pn))) = inner.get(1) { [INFO] [stdout] 446 | | ... public_name = Some(pn.clone()); [INFO] [stdout] 447 | | ... } [INFO] [stdout] 448 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 443 ~ "public_name" [INFO] [stdout] 444 ~ if inner.len() >= 2 => { [INFO] [stdout] 445 | if let Some(Sexp::Atom(Atom::S(pn))) = inner.get(1) { [INFO] [stdout] 446 | public_name = Some(pn.clone()); [INFO] [stdout] 447 | } [INFO] [stdout] 448 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:276:41 [INFO] [stdout] | [INFO] [stdout] 276 | / ... if inner.len() >= 2 { [INFO] [stdout] 277 | | ... if let Some(Sexp::Atom(Atom::S(n))) = inner.get(1) { [INFO] [stdout] 278 | | ... name = Some(n.clone()); [INFO] [stdout] 279 | | ... } [INFO] [stdout] 280 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 275 ~ "name" [INFO] [stdout] 276 ~ if inner.len() >= 2 => { [INFO] [stdout] 277 | if let Some(Sexp::Atom(Atom::S(n))) = inner.get(1) { [INFO] [stdout] 278 | name = Some(n.clone()); [INFO] [stdout] 279 | } [INFO] [stdout] 280 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:283:41 [INFO] [stdout] | [INFO] [stdout] 283 | / ... if inner.len() >= 2 { [INFO] [stdout] 284 | | ... if let Some(Sexp::Atom(Atom::S(n))) = inner.get(1) { [INFO] [stdout] 285 | | ... public_name = Some(n.clone()); [INFO] [stdout] 286 | | ... } [INFO] [stdout] 287 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 282 ~ "public_name" [INFO] [stdout] 283 ~ if inner.len() >= 2 => { [INFO] [stdout] 284 | if let Some(Sexp::Atom(Atom::S(n))) = inner.get(1) { [INFO] [stdout] 285 | public_name = Some(n.clone()); [INFO] [stdout] 286 | } [INFO] [stdout] 287 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:290:41 [INFO] [stdout] | [INFO] [stdout] 290 | / ... if inner.len() >= 2 { [INFO] [stdout] 291 | | ... if let Some(Sexp::Atom(Atom::S(n))) = inner.get(1) { [INFO] [stdout] 292 | | ... package = Some(n.clone()); [INFO] [stdout] 293 | | ... } [INFO] [stdout] 294 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 289 ~ "package" [INFO] [stdout] 290 ~ if inner.len() >= 2 => { [INFO] [stdout] 291 | if let Some(Sexp::Atom(Atom::S(n))) = inner.get(1) { [INFO] [stdout] 292 | package = Some(n.clone()); [INFO] [stdout] 293 | } [INFO] [stdout] 294 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:298:41 [INFO] [stdout] | [INFO] [stdout] 298 | / ... if inner.len() >= 2 { [INFO] [stdout] 299 | | ... if let Some(Sexp::Atom(Atom::S(val))) = inner.get(1) { [INFO] [stdout] 300 | | ... if val == "false" { [INFO] [stdout] 301 | | ... enabled = false; [INFO] [stdout] ... | [INFO] [stdout] 304 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 296 ~ "enabled_if" [INFO] [stdout] 297 | // Check if it's (enabled_if false) [INFO] [stdout] 298 ~ if inner.len() >= 2 => { [INFO] [stdout] 299 | if let Some(Sexp::Atom(Atom::S(val))) = inner.get(1) { [INFO] [stdout] ... [INFO] [stdout] 303 | } [INFO] [stdout] 304 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:308:41 [INFO] [stdout] | [INFO] [stdout] 308 | / ... if inner.len() >= 2 { [INFO] [stdout] 309 | | ... if let Some(Sexp::List(names_list)) = inner.get(1) { [INFO] [stdout] 310 | | ... for name_item in names_list { [INFO] [stdout] 311 | | ... if let Sexp::Atom(Atom::S(n)) = name_item { [INFO] [stdout] ... | [INFO] [stdout] 330 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 306 ~ "names" [INFO] [stdout] 307 | // Handle (executables ((names (exe1 exe2 ...)))) [INFO] [stdout] 308 ~ if inner.len() >= 2 => { [INFO] [stdout] 309 | if let Some(Sexp::List(names_list)) = inner.get(1) { [INFO] [stdout] ... [INFO] [stdout] 329 | } [INFO] [stdout] 330 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:759:27 [INFO] [stdout] | [INFO] [stdout] 759 | } else if !self.find_library_dune(&lib).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.find_library_dune(&lib).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:778:20 [INFO] [stdout] | [INFO] [stdout] 778 | if !self.find_library_dune(&lib).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.find_library_dune(&lib).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:437:41 [INFO] [stdout] | [INFO] [stdout] 437 | / ... if inner.len() >= 2 { [INFO] [stdout] 438 | | ... if let Some(Sexp::Atom(Atom::S(n))) = inner.get(1) { [INFO] [stdout] 439 | | ... name = Some(n.clone()); [INFO] [stdout] 440 | | ... } [INFO] [stdout] 441 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 436 ~ "name" [INFO] [stdout] 437 ~ if inner.len() >= 2 => { [INFO] [stdout] 438 | if let Some(Sexp::Atom(Atom::S(n))) = inner.get(1) { [INFO] [stdout] 439 | name = Some(n.clone()); [INFO] [stdout] 440 | } [INFO] [stdout] 441 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:444:41 [INFO] [stdout] | [INFO] [stdout] 444 | / ... if inner.len() >= 2 { [INFO] [stdout] 445 | | ... if let Some(Sexp::Atom(Atom::S(pn))) = inner.get(1) { [INFO] [stdout] 446 | | ... public_name = Some(pn.clone()); [INFO] [stdout] 447 | | ... } [INFO] [stdout] 448 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 443 ~ "public_name" [INFO] [stdout] 444 ~ if inner.len() >= 2 => { [INFO] [stdout] 445 | if let Some(Sexp::Atom(Atom::S(pn))) = inner.get(1) { [INFO] [stdout] 446 | public_name = Some(pn.clone()); [INFO] [stdout] 447 | } [INFO] [stdout] 448 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:759:27 [INFO] [stdout] | [INFO] [stdout] 759 | } else if !self.find_library_dune(&lib).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.find_library_dune(&lib).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:778:20 [INFO] [stdout] | [INFO] [stdout] 778 | if !self.find_library_dune(&lib).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.find_library_dune(&lib).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.20s [INFO] running `Command { std: "docker" "inspect" "f6aa13e1effdd10c0bbf4a98445f9ee7a955aa95214ef7c8c9cc69268689834e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f6aa13e1effdd10c0bbf4a98445f9ee7a955aa95214ef7c8c9cc69268689834e", kill_on_drop: false }` [INFO] [stdout] f6aa13e1effdd10c0bbf4a98445f9ee7a955aa95214ef7c8c9cc69268689834e