[INFO] cloning repository https://github.com/ELI7VH/chat-daddy [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ELI7VH/chat-daddy" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FELI7VH%2Fchat-daddy", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FELI7VH%2Fchat-daddy'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 328b759c8a07172b034ba33ff2ea2b8ae4089721 [INFO] linting ELI7VH/chat-daddy against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FELI7VH%2Fchat-daddy" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ELI7VH/chat-daddy [INFO] finished tweaking git repo https://github.com/ELI7VH/chat-daddy [INFO] tweaked toml for git repo https://github.com/ELI7VH/chat-daddy written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ELI7VH/chat-daddy on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ELI7VH/chat-daddy already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded winresource v0.1.30 [INFO] [stderr] Downloaded toml v0.9.12+spec-1.1.0 [INFO] [stderr] Downloaded minifb v0.28.0 [INFO] [stderr] Downloaded fontdue v0.9.3 [INFO] [stderr] Downloaded sdl2 v0.38.0 [INFO] [stderr] Downloaded orbclient v0.3.51 [INFO] [stderr] Downloaded sdl2-sys v0.38.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f6069014ed01492025c13e38db15076e4e51373828f9639bcce3cf987f7d064e [INFO] running `Command { std: "docker" "start" "-a" "f6069014ed01492025c13e38db15076e4e51373828f9639bcce3cf987f7d064e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f6069014ed01492025c13e38db15076e4e51373828f9639bcce3cf987f7d064e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f6069014ed01492025c13e38db15076e4e51373828f9639bcce3cf987f7d064e", kill_on_drop: false }` [INFO] [stdout] f6069014ed01492025c13e38db15076e4e51373828f9639bcce3cf987f7d064e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8f3774f995d8c859b72e8b7f655573fce3c5834d63e3b182e022f6d8daa164fc [INFO] running `Command { std: "docker" "start" "-a" "8f3774f995d8c859b72e8b7f655573fce3c5834d63e3b182e022f6d8daa164fc", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Checking once_cell v1.21.4 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling anyhow v1.0.102 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling wayland-sys v0.29.5 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling wayland-scanner v0.29.5 [INFO] [stderr] Compiling zerocopy v0.8.42 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking as-slice v0.2.1 [INFO] [stderr] Compiling av-scenechange v0.14.1 [INFO] [stderr] Compiling built v0.8.0 [INFO] [stderr] Checking linux-raw-sys v0.12.1 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking aligned v0.4.3 [INFO] [stderr] Compiling winnow v0.7.15 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking y4m v0.8.0 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Checking imgref v1.12.0 [INFO] [stderr] Compiling noop_proc_macro v0.3.0 [INFO] [stderr] Checking weezl v0.1.12 [INFO] [stderr] Checking zune-core v0.5.1 [INFO] [stderr] Checking loop9 v0.1.5 [INFO] [stderr] Checking avif-serialize v0.8.8 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Compiling rustls v0.23.37 [INFO] [stderr] Checking pxfm v0.1.28 [INFO] [stderr] Checking bit_field v0.10.3 [INFO] [stderr] Checking lebe v0.5.3 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking zune-jpeg v0.5.13 [INFO] [stderr] Checking rgb v0.8.53 [INFO] [stderr] Compiling rav1e v0.8.1 [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Checking nom v8.0.0 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Checking bitstream-io v4.9.0 [INFO] [stderr] Checking image-webp v0.2.4 [INFO] [stderr] Checking gif v0.14.1 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Compiling minifb v0.28.0 [INFO] [stderr] Compiling wayland-client v0.29.5 [INFO] [stderr] Compiling wayland-protocols v0.29.5 [INFO] [stderr] Checking x11rb-protocol v0.13.2 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking raw-window-handle v0.6.2 [INFO] [stderr] Checking ttf-parser v0.21.1 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking wayland-commons v0.29.5 [INFO] [stderr] Compiling toml_parser v1.0.9+spec-1.1.0 [INFO] [stderr] Checking wayland-cursor v0.29.5 [INFO] [stderr] Compiling serde_spanned v1.0.4 [INFO] [stderr] Compiling toml_datetime v0.7.5+spec-1.1.0 [INFO] [stderr] Checking fontdue v0.9.3 [INFO] [stderr] Compiling toml v0.9.12+spec-1.1.0 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Checking moxcms v0.8.1 [INFO] [stderr] Compiling winresource v0.1.30 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling chat-daddy v0.4.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking gethostname v1.1.0 [INFO] [stderr] Checking tempfile v3.27.0 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling equator-macro v0.4.2 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling zerocopy-derive v0.8.42 [INFO] [stderr] Compiling profiling-procmacros v1.0.17 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Compiling fax_derive v0.2.0 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Checking profiling v1.0.17 [INFO] [stderr] Checking fax v0.2.6 [INFO] [stderr] Checking equator v0.4.2 [INFO] [stderr] Checking aligned-vec v0.6.4 [INFO] [stderr] Checking v_frame v0.3.9 [INFO] [stderr] Checking av1-grain v0.2.5 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking ureq v2.12.1 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking ravif v0.13.0 [INFO] [stderr] Checking exr v1.74.0 [INFO] [stderr] Checking tiff v0.11.3 [INFO] [stderr] Checking image v0.25.10 [INFO] [stderr] Checking arboard v3.6.1 [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/main.rs:593:5 [INFO] [stdout] | [INFO] [stdout] 593 | themes.sort_by(|a, b| a.1.to_lowercase().cmp(&b.1.to_lowercase())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 593 - themes.sort_by(|a, b| a.1.to_lowercase().cmp(&b.1.to_lowercase())); [INFO] [stdout] 593 + themes.sort_by_key(|a| a.1.to_lowercase()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:873:19 [INFO] [stdout] | [INFO] [stdout] 873 | } else if path.extension().map_or(false, |e| e == "jsonl") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 873 - } else if path.extension().map_or(false, |e| e == "jsonl") { [INFO] [stdout] 873 + } else if path.extension().is_some_and(|e| e == "jsonl") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/main.rs:1004:5 [INFO] [stdout] | [INFO] [stdout] 1004 | all.sort_by(|a, b| b.mtime_secs.cmp(&a.mtime_secs)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1004 - all.sort_by(|a, b| b.mtime_secs.cmp(&a.mtime_secs)); [INFO] [stdout] 1004 + all.sort_by_key(|b| std::cmp::Reverse(b.mtime_secs)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/main.rs:593:5 [INFO] [stdout] | [INFO] [stdout] 593 | themes.sort_by(|a, b| a.1.to_lowercase().cmp(&b.1.to_lowercase())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 593 - themes.sort_by(|a, b| a.1.to_lowercase().cmp(&b.1.to_lowercase())); [INFO] [stdout] 593 + themes.sort_by_key(|a| a.1.to_lowercase()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:873:19 [INFO] [stdout] | [INFO] [stdout] 873 | } else if path.extension().map_or(false, |e| e == "jsonl") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 873 - } else if path.extension().map_or(false, |e| e == "jsonl") { [INFO] [stdout] 873 + } else if path.extension().is_some_and(|e| e == "jsonl") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/main.rs:1535:44 [INFO] [stdout] | [INFO] [stdout] 1535 | let msg_label = if mi == 0 { label } else { label }; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/main.rs:1535:59 [INFO] [stdout] | [INFO] [stdout] 1535 | let msg_label = if mi == 0 { label } else { label }; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/main.rs:1004:5 [INFO] [stdout] | [INFO] [stdout] 1004 | all.sort_by(|a, b| b.mtime_secs.cmp(&a.mtime_secs)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1004 - all.sort_by(|a, b| b.mtime_secs.cmp(&a.mtime_secs)); [INFO] [stdout] 1004 + all.sort_by_key(|b| std::cmp::Reverse(b.mtime_secs)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `chars` [INFO] [stdout] --> src/main.rs:1617:22 [INFO] [stdout] | [INFO] [stdout] 1617 | for j in start..chars.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 1617 - for j in start..chars.len() { [INFO] [stdout] 1617 + for (j, ) in chars.iter().enumerate().skip(start) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/main.rs:1673:1 [INFO] [stdout] | [INFO] [stdout] 1673 | / fn draw_text_ttf( [INFO] [stdout] 1674 | | buf: &mut [u32], [INFO] [stdout] 1675 | | x: i32, [INFO] [stdout] 1676 | | y: i32, [INFO] [stdout] ... | [INFO] [stdout] 1681 | | buf_h: usize, [INFO] [stdout] 1682 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/main.rs:1739:1 [INFO] [stdout] | [INFO] [stdout] 1739 | / fn fill_rect( [INFO] [stdout] 1740 | | buf: &mut [u32], [INFO] [stdout] 1741 | | x: i32, [INFO] [stdout] 1742 | | y: i32, [INFO] [stdout] ... | [INFO] [stdout] 1747 | | buf_h: usize, [INFO] [stdout] 1748 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/main.rs:1798:1 [INFO] [stdout] | [INFO] [stdout] 1798 | / fn blit_icon( [INFO] [stdout] 1799 | | buf: &mut [u32], [INFO] [stdout] 1800 | | dx: i32, [INFO] [stdout] 1801 | | dy: i32, [INFO] [stdout] ... | [INFO] [stdout] 1806 | | buf_h: usize, [INFO] [stdout] 1807 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:1859:30 [INFO] [stdout] | [INFO] [stdout] 1859 | if favs_only && !chats.get(&t.uuid).map_or(false, |m| m.starred) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 1859 - if favs_only && !chats.get(&t.uuid).map_or(false, |m| m.starred) { [INFO] [stdout] 1859 + if favs_only && !chats.get(&t.uuid).is_some_and(|m| m.starred) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:1888:30 [INFO] [stdout] | [INFO] [stdout] 1888 | if favs_only && !chats.get(&t.uuid).map_or(false, |m| m.starred) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 1888 - if favs_only && !chats.get(&t.uuid).map_or(false, |m| m.starred) { [INFO] [stdout] 1888 + if favs_only && !chats.get(&t.uuid).is_some_and(|m| m.starred) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/main.rs:1535:44 [INFO] [stdout] | [INFO] [stdout] 1535 | let msg_label = if mi == 0 { label } else { label }; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/main.rs:1535:59 [INFO] [stdout] | [INFO] [stdout] 1535 | let msg_label = if mi == 0 { label } else { label }; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `chars` [INFO] [stdout] --> src/main.rs:1617:22 [INFO] [stdout] | [INFO] [stdout] 1617 | for j in start..chars.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 1617 - for j in start..chars.len() { [INFO] [stdout] 1617 + for (j, ) in chars.iter().enumerate().skip(start) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/main.rs:1673:1 [INFO] [stdout] | [INFO] [stdout] 1673 | / fn draw_text_ttf( [INFO] [stdout] 1674 | | buf: &mut [u32], [INFO] [stdout] 1675 | | x: i32, [INFO] [stdout] 1676 | | y: i32, [INFO] [stdout] ... | [INFO] [stdout] 1681 | | buf_h: usize, [INFO] [stdout] 1682 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/main.rs:1739:1 [INFO] [stdout] | [INFO] [stdout] 1739 | / fn fill_rect( [INFO] [stdout] 1740 | | buf: &mut [u32], [INFO] [stdout] 1741 | | x: i32, [INFO] [stdout] 1742 | | y: i32, [INFO] [stdout] ... | [INFO] [stdout] 1747 | | buf_h: usize, [INFO] [stdout] 1748 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/main.rs:1798:1 [INFO] [stdout] | [INFO] [stdout] 1798 | / fn blit_icon( [INFO] [stdout] 1799 | | buf: &mut [u32], [INFO] [stdout] 1800 | | dx: i32, [INFO] [stdout] 1801 | | dy: i32, [INFO] [stdout] ... | [INFO] [stdout] 1806 | | buf_h: usize, [INFO] [stdout] 1807 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:1859:30 [INFO] [stdout] | [INFO] [stdout] 1859 | if favs_only && !chats.get(&t.uuid).map_or(false, |m| m.starred) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 1859 - if favs_only && !chats.get(&t.uuid).map_or(false, |m| m.starred) { [INFO] [stdout] 1859 + if favs_only && !chats.get(&t.uuid).is_some_and(|m| m.starred) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:1888:30 [INFO] [stdout] | [INFO] [stdout] 1888 | if favs_only && !chats.get(&t.uuid).map_or(false, |m| m.starred) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 1888 - if favs_only && !chats.get(&t.uuid).map_or(false, |m| m.starred) { [INFO] [stdout] 1888 + if favs_only && !chats.get(&t.uuid).is_some_and(|m| m.starred) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/main.rs:2352:22 [INFO] [stdout] | [INFO] [stdout] 2352 | let load_result: Arc, HashMap)>>> = Arc::new(Mutex::new(None)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/main.rs:2558:25 [INFO] [stdout] | [INFO] [stdout] 2558 | fresh.sort_by(|a, b| b.mtime_secs.cmp(&a.mtime_secs)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 2558 - fresh.sort_by(|a, b| b.mtime_secs.cmp(&a.mtime_secs)); [INFO] [stdout] 2558 + fresh.sort_by_key(|b| std::cmp::Reverse(b.mtime_secs)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:2661:21 [INFO] [stdout] | [INFO] [stdout] 2661 | !chats.get(&t.uuid).and_then(|m| m.name.as_ref()).is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `chats.get(&t.uuid).and_then(|m| m.name.as_ref()).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/main.rs:2352:22 [INFO] [stdout] | [INFO] [stdout] 2352 | let load_result: Arc, HashMap)>>> = Arc::new(Mutex::new(None)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:3053:42 [INFO] [stdout] | [INFO] [stdout] 3053 | ... !chats.get(uuid).map_or(false, |m| m.starred) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 3053 - !chats.get(uuid).map_or(false, |m| m.starred) [INFO] [stdout] 3053 + !chats.get(uuid).is_some_and(|m| m.starred) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/main.rs:3155:33 [INFO] [stdout] | [INFO] [stdout] 3155 | ... all.sort_by(|a, b| b.mtime_secs.cmp(&a.mtime_secs)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 3155 - all.sort_by(|a, b| b.mtime_secs.cmp(&a.mtime_secs)); [INFO] [stdout] 3155 + all.sort_by_key(|b| std::cmp::Reverse(b.mtime_secs)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/main.rs:2558:25 [INFO] [stdout] | [INFO] [stdout] 2558 | fresh.sort_by(|a, b| b.mtime_secs.cmp(&a.mtime_secs)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 2558 - fresh.sort_by(|a, b| b.mtime_secs.cmp(&a.mtime_secs)); [INFO] [stdout] 2558 + fresh.sort_by_key(|b| std::cmp::Reverse(b.mtime_secs)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `list` [INFO] [stdout] --> src/main.rs:3293:26 [INFO] [stdout] | [INFO] [stdout] 3293 | for i in 0..list.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 3293 - for i in 0..list.len() { [INFO] [stdout] 3293 + for (i, ) in list.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:3320:31 [INFO] [stdout] | [INFO] [stdout] 3320 | } else if chats.get(&t.uuid).map_or(false, |m| m.starred) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 3320 - } else if chats.get(&t.uuid).map_or(false, |m| m.starred) { [INFO] [stdout] 3320 + } else if chats.get(&t.uuid).is_some_and(|m| m.starred) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:2661:21 [INFO] [stdout] | [INFO] [stdout] 2661 | !chats.get(&t.uuid).and_then(|m| m.name.as_ref()).is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `chats.get(&t.uuid).and_then(|m| m.name.as_ref()).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:3053:42 [INFO] [stdout] | [INFO] [stdout] 3053 | ... !chats.get(uuid).map_or(false, |m| m.starred) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 3053 - !chats.get(uuid).map_or(false, |m| m.starred) [INFO] [stdout] 3053 + !chats.get(uuid).is_some_and(|m| m.starred) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/main.rs:3155:33 [INFO] [stdout] | [INFO] [stdout] 3155 | ... all.sort_by(|a, b| b.mtime_secs.cmp(&a.mtime_secs)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 3155 - all.sort_by(|a, b| b.mtime_secs.cmp(&a.mtime_secs)); [INFO] [stdout] 3155 + all.sort_by_key(|b| std::cmp::Reverse(b.mtime_secs)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `list` [INFO] [stdout] --> src/main.rs:3293:26 [INFO] [stdout] | [INFO] [stdout] 3293 | for i in 0..list.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 3293 - for i in 0..list.len() { [INFO] [stdout] 3293 + for (i, ) in list.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:3320:31 [INFO] [stdout] | [INFO] [stdout] 3320 | } else if chats.get(&t.uuid).map_or(false, |m| m.starred) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 3320 - } else if chats.get(&t.uuid).map_or(false, |m| m.starred) { [INFO] [stdout] 3320 + } else if chats.get(&t.uuid).is_some_and(|m| m.starred) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 46.46s [INFO] running `Command { std: "docker" "inspect" "8f3774f995d8c859b72e8b7f655573fce3c5834d63e3b182e022f6d8daa164fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f3774f995d8c859b72e8b7f655573fce3c5834d63e3b182e022f6d8daa164fc", kill_on_drop: false }` [INFO] [stdout] 8f3774f995d8c859b72e8b7f655573fce3c5834d63e3b182e022f6d8daa164fc