[INFO] cloning repository https://github.com/DrunkJon/pseudo_assembly [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DrunkJon/pseudo_assembly" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDrunkJon%2Fpseudo_assembly", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDrunkJon%2Fpseudo_assembly'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 70561dbb2719862013e46b2afa86269a0deb1b57 [INFO] linting DrunkJon/pseudo_assembly against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDrunkJon%2Fpseudo_assembly" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/DrunkJon/pseudo_assembly [INFO] finished tweaking git repo https://github.com/DrunkJon/pseudo_assembly [INFO] tweaked toml for git repo https://github.com/DrunkJon/pseudo_assembly written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/DrunkJon/pseudo_assembly on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/DrunkJon/pseudo_assembly already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 93bc6369513d5598a3c90792f39f9cf26e0ebe750432dc53ad5f572cb95aac3f [INFO] running `Command { std: "docker" "start" "-a" "93bc6369513d5598a3c90792f39f9cf26e0ebe750432dc53ad5f572cb95aac3f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "93bc6369513d5598a3c90792f39f9cf26e0ebe750432dc53ad5f572cb95aac3f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "93bc6369513d5598a3c90792f39f9cf26e0ebe750432dc53ad5f572cb95aac3f", kill_on_drop: false }` [INFO] [stdout] 93bc6369513d5598a3c90792f39f9cf26e0ebe750432dc53ad5f572cb95aac3f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fc853361c870f56c8a2f45cb2a41810dc58e800ef5d7af880ecbad7fb84a55dc [INFO] running `Command { std: "docker" "start" "-a" "fc853361c870f56c8a2f45cb2a41810dc58e800ef5d7af880ecbad7fb84a55dc", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Compiling nom v7.1.0 [INFO] [stderr] Checking pseudo_assembly v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crate::operator::Operator` [INFO] [stdout] --> src/ast.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::operator::Operator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ErrorKind`, `FromExternalError`, and `Parser` [INFO] [stdout] --> src/operator_parsers.rs:9:20 [INFO] [stdout] | [INFO] [stdout] 9 | error::{Error, ErrorKind, FromExternalError}, [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 12 | IResult, Parser, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `char`, `many0`, `many_m_n`, and `terminated` [INFO] [stdout] --> src/term_parsers.rs:5:27 [INFO] [stdout] | [INFO] [stdout] 5 | character::complete::{char, one_of}, [INFO] [stdout] | ^^^^ [INFO] [stdout] 6 | combinator::{map_res, recognize}, [INFO] [stdout] 7 | multi::{many0, many1, many_m_n}, [INFO] [stdout] | ^^^^^ ^^^^^^^^ [INFO] [stdout] 8 | sequence::{preceded, terminated}, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `branch::alt` [INFO] [stdout] --> src/statement_parsers.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | branch::alt, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/operator.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | _ => { [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/operator.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 23 | Self::Add(ref_, term_) => { [INFO] [stdout] | ---------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 27 | Self::Sub(ref_, term_) => { [INFO] [stdout] | ---------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 31 | Self::Mul(ref_, term_) => { [INFO] [stdout] | ---------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 35 | Self::Div(ref_, term_) => { [INFO] [stdout] | ---------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 43 | _ => { [INFO] [stdout] | ^ ...and 1 other patterns collectively make this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/operator_parsers.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | _x => panic!("tag is not implementet for {:?}", _x), [INFO] [stdout] | ^^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/operator_parsers.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 27 | Self::Add => "ADD", [INFO] [stdout] | --------- matches some of the same values [INFO] [stdout] 28 | Self::Sub => "SUB", [INFO] [stdout] | --------- matches some of the same values [INFO] [stdout] 29 | Self::Mul => "MUL", [INFO] [stdout] | --------- matches some of the same values [INFO] [stdout] 30 | Self::Div => "DIV", [INFO] [stdout] | --------- matches some of the same values [INFO] [stdout] 31 | Self::Mov => "MOV", [INFO] [stdout] 32 | _x => panic!("tag is not implementet for {:?}", _x), [INFO] [stdout] | ^^ ...and 1 other patterns collectively make this unreachable [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/operator_parsers.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | _x => panic!("build is not implementet for {:?}", _x), [INFO] [stdout] | ^^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/operator_parsers.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 38 | Self::Add => Operator::Add(ref_, term_), [INFO] [stdout] | --------- matches some of the same values [INFO] [stdout] 39 | Self::Sub => Operator::Sub(ref_, term_), [INFO] [stdout] | --------- matches some of the same values [INFO] [stdout] 40 | Self::Mul => Operator::Mul(ref_, term_), [INFO] [stdout] | --------- matches some of the same values [INFO] [stdout] 41 | Self::Div => Operator::Div(ref_, term_), [INFO] [stdout] | --------- matches some of the same values [INFO] [stdout] 42 | Self::Mov => Operator::Mov(ref_, term_), [INFO] [stdout] 43 | _x => panic!("build is not implementet for {:?}", _x), [INFO] [stdout] | ^^ ...and 1 other patterns collectively make this unreachable [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::operator::Operator` [INFO] [stdout] --> src/ast.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::operator::Operator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ErrorKind`, `FromExternalError`, and `Parser` [INFO] [stdout] --> src/operator_parsers.rs:9:20 [INFO] [stdout] | [INFO] [stdout] 9 | error::{Error, ErrorKind, FromExternalError}, [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 12 | IResult, Parser, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `statement` is never used [INFO] [stdout] --> src/operator_parsers.rs:80:4 [INFO] [stdout] | [INFO] [stdout] 80 | fn statement(input: &str) -> IResult<&str, Vec> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `eval` is never used [INFO] [stdout] --> src/statement.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 11 | impl Statement { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] 12 | fn eval(&self, mem: &mut Mem) { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `char`, `many0`, `many_m_n`, and `terminated` [INFO] [stdout] --> src/term_parsers.rs:5:27 [INFO] [stdout] | [INFO] [stdout] 5 | character::complete::{char, one_of}, [INFO] [stdout] | ^^^^ [INFO] [stdout] 6 | combinator::{map_res, recognize}, [INFO] [stdout] 7 | multi::{many0, many1, many_m_n}, [INFO] [stdout] | ^^^^^ ^^^^^^^^ [INFO] [stdout] 8 | sequence::{preceded, terminated}, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `branch::alt` [INFO] [stdout] --> src/statement_parsers.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | branch::alt, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/operator_parsers.rs:69:17 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn operator<'a>(input: &'a str) -> IResult<&'a str, Operator> { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 69 - pub fn operator<'a>(input: &'a str) -> IResult<&'a str, Operator> { [INFO] [stdout] 69 + pub fn operator(input: &str) -> IResult<&str, Operator> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/term.rs:16:48 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn write(&self, mem: &mut Mem, val: u8) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/term.rs:19:21 [INFO] [stdout] | [INFO] [stdout] 19 | mem[adr.clone() as usize] = val; [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*adr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/term.rs:22:25 [INFO] [stdout] | [INFO] [stdout] 22 | mem[mem[adr.clone() as usize] as usize] = val; [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*adr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/term.rs:29:41 [INFO] [stdout] | [INFO] [stdout] 29 | Self::DirectRef(adr) => mem[adr.clone() as usize], [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*adr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/term.rs:30:47 [INFO] [stdout] | [INFO] [stdout] 30 | Self::IndirectRef(adr) => mem[mem[adr.clone() as usize] as usize], [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*adr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/term.rs:51:37 [INFO] [stdout] | [INFO] [stdout] 51 | Self::Immediate(val) => val.clone(), [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/term_parsers.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | u8::from_str_radix(out, 10) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `out.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] = note: `#[warn(clippy::from_str_radix_10)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/operator_parsers.rs:50:37 [INFO] [stdout] | [INFO] [stdout] 49 | op: &'a OperatorEnum, [INFO] [stdout] | -- the lifetime is named here [INFO] [stdout] 50 | ) -> impl FnMut(&'a str) -> IResult<&str, Operator> { [INFO] [stdout] | -- ^^^^ the same lifetime is elided here [INFO] [stdout] | | [INFO] [stdout] | the same lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 50 | ) -> impl FnMut(&'a str) -> IResult<&'a str, Operator> { [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/operator.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | _ => { [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/operator.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 23 | Self::Add(ref_, term_) => { [INFO] [stdout] | ---------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 27 | Self::Sub(ref_, term_) => { [INFO] [stdout] | ---------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 31 | Self::Mul(ref_, term_) => { [INFO] [stdout] | ---------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 35 | Self::Div(ref_, term_) => { [INFO] [stdout] | ---------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 43 | _ => { [INFO] [stdout] | ^ ...and 1 other patterns collectively make this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/operator_parsers.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | _x => panic!("tag is not implementet for {:?}", _x), [INFO] [stdout] | ^^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/operator_parsers.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 27 | Self::Add => "ADD", [INFO] [stdout] | --------- matches some of the same values [INFO] [stdout] 28 | Self::Sub => "SUB", [INFO] [stdout] | --------- matches some of the same values [INFO] [stdout] 29 | Self::Mul => "MUL", [INFO] [stdout] | --------- matches some of the same values [INFO] [stdout] 30 | Self::Div => "DIV", [INFO] [stdout] | --------- matches some of the same values [INFO] [stdout] 31 | Self::Mov => "MOV", [INFO] [stdout] 32 | _x => panic!("tag is not implementet for {:?}", _x), [INFO] [stdout] | ^^ ...and 1 other patterns collectively make this unreachable [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/operator_parsers.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | _x => panic!("build is not implementet for {:?}", _x), [INFO] [stdout] | ^^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/operator_parsers.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 38 | Self::Add => Operator::Add(ref_, term_), [INFO] [stdout] | --------- matches some of the same values [INFO] [stdout] 39 | Self::Sub => Operator::Sub(ref_, term_), [INFO] [stdout] | --------- matches some of the same values [INFO] [stdout] 40 | Self::Mul => Operator::Mul(ref_, term_), [INFO] [stdout] | --------- matches some of the same values [INFO] [stdout] 41 | Self::Div => Operator::Div(ref_, term_), [INFO] [stdout] | --------- matches some of the same values [INFO] [stdout] 42 | Self::Mov => Operator::Mov(ref_, term_), [INFO] [stdout] 43 | _x => panic!("build is not implementet for {:?}", _x), [INFO] [stdout] | ^^ ...and 1 other patterns collectively make this unreachable [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `statement` is never used [INFO] [stdout] --> src/operator_parsers.rs:80:4 [INFO] [stdout] | [INFO] [stdout] 80 | fn statement(input: &str) -> IResult<&str, Vec> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/operator_parsers.rs:69:17 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn operator<'a>(input: &'a str) -> IResult<&'a str, Operator> { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 69 - pub fn operator<'a>(input: &'a str) -> IResult<&'a str, Operator> { [INFO] [stdout] 69 + pub fn operator(input: &str) -> IResult<&str, Operator> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/operator_parsers.rs:119:17 [INFO] [stdout] | [INFO] [stdout] 119 | assert!(!operator("ADD #FF 69").is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `operator("ADD #FF 69").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/operator_parsers.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | assert!(!operator("SUB #FF 69").is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `operator("SUB #FF 69").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/operator_parsers.rs:121:17 [INFO] [stdout] | [INFO] [stdout] 121 | assert!(!operator("MUL #FF 69").is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `operator("MUL #FF 69").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/operator_parsers.rs:122:17 [INFO] [stdout] | [INFO] [stdout] 122 | assert!(!operator("DIV #FF 69").is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `operator("DIV #FF 69").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/operator_parsers.rs:123:17 [INFO] [stdout] | [INFO] [stdout] 123 | assert!(!operator("MOV #FF 69").is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `operator("MOV #FF 69").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/term.rs:16:48 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn write(&self, mem: &mut Mem, val: u8) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/term.rs:19:21 [INFO] [stdout] | [INFO] [stdout] 19 | mem[adr.clone() as usize] = val; [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*adr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/term.rs:22:25 [INFO] [stdout] | [INFO] [stdout] 22 | mem[mem[adr.clone() as usize] as usize] = val; [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*adr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/term.rs:29:41 [INFO] [stdout] | [INFO] [stdout] 29 | Self::DirectRef(adr) => mem[adr.clone() as usize], [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*adr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/term.rs:30:47 [INFO] [stdout] | [INFO] [stdout] 30 | Self::IndirectRef(adr) => mem[mem[adr.clone() as usize] as usize], [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*adr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/term.rs:51:37 [INFO] [stdout] | [INFO] [stdout] 51 | Self::Immediate(val) => val.clone(), [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/term_parsers.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | u8::from_str_radix(out, 10) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `out.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] = note: `#[warn(clippy::from_str_radix_10)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `mem` [INFO] [stdout] --> src/statement.rs:46:18 [INFO] [stdout] | [INFO] [stdout] 46 | for i in 0..255 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 46 - for i in 0..255 { [INFO] [stdout] 46 + for (i, ) in mem.iter().enumerate().take(255) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/operator_parsers.rs:50:37 [INFO] [stdout] | [INFO] [stdout] 49 | op: &'a OperatorEnum, [INFO] [stdout] | -- the lifetime is named here [INFO] [stdout] 50 | ) -> impl FnMut(&'a str) -> IResult<&str, Operator> { [INFO] [stdout] | -- ^^^^ the same lifetime is elided here [INFO] [stdout] | | [INFO] [stdout] | the same lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 50 | ) -> impl FnMut(&'a str) -> IResult<&'a str, Operator> { [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `Terminal_eval` should have a snake case name [INFO] [stdout] --> src/term.rs:61:8 [INFO] [stdout] | [INFO] [stdout] 61 | fn Terminal_eval() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `terminal_eval` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.97s [INFO] running `Command { std: "docker" "inspect" "fc853361c870f56c8a2f45cb2a41810dc58e800ef5d7af880ecbad7fb84a55dc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fc853361c870f56c8a2f45cb2a41810dc58e800ef5d7af880ecbad7fb84a55dc", kill_on_drop: false }` [INFO] [stdout] fc853361c870f56c8a2f45cb2a41810dc58e800ef5d7af880ecbad7fb84a55dc