[INFO] cloning repository https://github.com/DreadedHippy/ratatui-project [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DreadedHippy/ratatui-project" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDreadedHippy%2Fratatui-project", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDreadedHippy%2Fratatui-project'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3df2f3ac2c95b1c5ff6f1efc2f1df4eeb55e718c [INFO] linting DreadedHippy/ratatui-project against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDreadedHippy%2Fratatui-project" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/DreadedHippy/ratatui-project [INFO] finished tweaking git repo https://github.com/DreadedHippy/ratatui-project [INFO] tweaked toml for git repo https://github.com/DreadedHippy/ratatui-project written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/DreadedHippy/ratatui-project on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/DreadedHippy/ratatui-project already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded quote v1.0.32 [INFO] [stderr] Downloaded pin-project-lite v0.2.12 [INFO] [stderr] Downloaded windows-targets v0.48.1 [INFO] [stderr] Downloaded anyhow v1.0.72 [INFO] [stderr] Downloaded log v0.4.19 [INFO] [stderr] Downloaded addr2line v0.20.0 [INFO] [stderr] Downloaded cc v1.0.82 [INFO] [stderr] Downloaded time v0.3.25 [INFO] [stderr] Downloaded backtrace v0.3.68 [INFO] [stderr] Downloaded serde_json v1.0.105 [INFO] [stderr] Downloaded serde v1.0.183 [INFO] [stderr] Downloaded ratatui v0.22.0 [INFO] [stderr] Downloaded syn v2.0.28 [INFO] [stderr] Downloaded gimli v0.27.3 [INFO] [stderr] Downloaded indoc v2.0.3 [INFO] [stderr] Downloaded deranged v0.3.7 [INFO] [stderr] Downloaded time-core v0.1.1 [INFO] [stderr] Downloaded tokio v1.31.0 [INFO] [stderr] Downloaded object v0.31.1 [INFO] [stderr] Downloaded serde_derive v1.0.183 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d6d5b156afdf7588e88c747c5860d3b4177f92657d3ad524f6e286919807501c [INFO] running `Command { std: "docker" "start" "-a" "d6d5b156afdf7588e88c747c5860d3b4177f92657d3ad524f6e286919807501c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d6d5b156afdf7588e88c747c5860d3b4177f92657d3ad524f6e286919807501c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d6d5b156afdf7588e88c747c5860d3b4177f92657d3ad524f6e286919807501c", kill_on_drop: false }` [INFO] [stdout] d6d5b156afdf7588e88c747c5860d3b4177f92657d3ad524f6e286919807501c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] eff09ca83026fa190cef2c556c93450d9f6d1da628820c11c5e85e2676e08332 [INFO] running `Command { std: "docker" "start" "-a" "eff09ca83026fa190cef2c556c93450d9f6d1da628820c11c5e85e2676e08332", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Checking smallvec v1.11.0 [INFO] [stderr] Compiling serde v1.0.183 [INFO] [stderr] Compiling serde_derive v1.0.183 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling serde_json v1.0.105 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Checking num_threads v0.1.6 [INFO] [stderr] Compiling anyhow v1.0.72 [INFO] [stderr] Checking time-core v0.1.1 [INFO] [stderr] Checking deranged v0.3.7 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Compiling indoc v2.0.3 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking pin-project-lite v0.2.12 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking time v0.3.25 [INFO] [stderr] Compiling quote v1.0.32 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Compiling syn v2.0.28 [INFO] [stderr] Checking crossterm v0.26.1 [INFO] [stderr] Checking ratatui v0.22.0 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Checking tokio v1.31.0 [INFO] [stderr] Checking ratatui-project v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `is_submitted`, `activity`, `should_quit`, and `terminal` are never read [INFO] [stdout] --> src/interfaces/app.rs:20:6 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct AppInterface<'a> { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] ... [INFO] [stdout] 20 | pub is_submitted: Option, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 21 | pub activity: Option, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 22 | pub should_quit: bool, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 23 | pub terminal: Option<&'a mut AppTerminal>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/events/mod.rs:22:10 [INFO] [stdout] | [INFO] [stdout] 22 | if c >= '0' && c <= '9' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `('0'..='9').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/interfaces/app.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 41 | if !self.create_new_customer(terminal).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.create_new_customer(terminal).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/interfaces/app.rs:45:6 [INFO] [stdout] | [INFO] [stdout] 45 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - self.set_hint_mode(1); [INFO] [stdout] 45 - return [INFO] [stdout] 44 + self.set_hint_mode(1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/interfaces/app.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - self.set_hint_mode(1); [INFO] [stdout] 58 - return [INFO] [stdout] 57 + self.set_hint_mode(1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/interfaces/app.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - self.set_hint_mode(1); [INFO] [stdout] 70 - return [INFO] [stdout] 69 + self.set_hint_mode(1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/interfaces/app.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - self.set_hint_mode(1); [INFO] [stdout] 82 - return [INFO] [stdout] 81 + self.set_hint_mode(1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/interfaces/app.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 93 - self.set_hint_mode(1); [INFO] [stdout] 94 - return [INFO] [stdout] 93 + self.set_hint_mode(1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/interfaces/app.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 106 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 105 - self.set_hint_mode(1); [INFO] [stdout] 106 - return [INFO] [stdout] 105 + self.set_hint_mode(1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/interfaces/app.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 118 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - self.set_hint_mode(1); [INFO] [stdout] 118 - return [INFO] [stdout] 117 + self.set_hint_mode(1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/interfaces/app.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 130 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 129 - self.set_hint_mode(1); [INFO] [stdout] 130 - return [INFO] [stdout] 129 + self.set_hint_mode(1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/interfaces/app.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | / match self.create_bank_account(terminal) { [INFO] [stdout] 51 | | Err(i) => { [INFO] [stdout] 52 | | self.set_display_text(i.to_string()).draw(terminal); [INFO] [stdout] 53 | | }, [INFO] [stdout] 54 | | _ => {} [INFO] [stdout] 55 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 50 ~ if let Err(i) = self.create_bank_account(terminal) { [INFO] [stdout] 51 ~ self.set_display_text(i.to_string()).draw(terminal); [INFO] [stdout] 52 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/interfaces/app.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 62 | / match self.deposit_money(terminal) { [INFO] [stdout] 63 | | Err(i) => { [INFO] [stdout] 64 | | self.set_display_text(i.to_string()).draw(terminal); [INFO] [stdout] 65 | | }, [INFO] [stdout] 66 | | _ => {}, [INFO] [stdout] 67 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 62 ~ if let Err(i) = self.deposit_money(terminal) { [INFO] [stdout] 63 ~ self.set_display_text(i.to_string()).draw(terminal); [INFO] [stdout] 64 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/interfaces/app.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | / match self.withdraw_money(terminal) { [INFO] [stdout] 75 | | Err(i) => { [INFO] [stdout] 76 | | self.set_display_text(i.to_string()).draw(terminal); [INFO] [stdout] 77 | | }, [INFO] [stdout] 78 | | _ => {}, [INFO] [stdout] 79 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 74 ~ if let Err(i) = self.withdraw_money(terminal) { [INFO] [stdout] 75 ~ self.set_display_text(i.to_string()).draw(terminal); [INFO] [stdout] 76 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/interfaces/app.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | / match self.check_balances(terminal) { [INFO] [stdout] 87 | | Err(i) => { [INFO] [stdout] 88 | | self.set_display_text(i.to_string()).draw(terminal); [INFO] [stdout] 89 | | }, [INFO] [stdout] 90 | | _ => {}, [INFO] [stdout] 91 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 86 ~ if let Err(i) = self.check_balances(terminal) { [INFO] [stdout] 87 ~ self.set_display_text(i.to_string()).draw(terminal); [INFO] [stdout] 88 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/interfaces/app.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | / match self.get_all_users(terminal) { [INFO] [stdout] 99 | | Err(i) => { [INFO] [stdout] 100 | | self.set_display_text(i.to_string()).draw(terminal); [INFO] [stdout] 101 | | }, [INFO] [stdout] 102 | | _ => {}, [INFO] [stdout] 103 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 98 ~ if let Err(i) = self.get_all_users(terminal) { [INFO] [stdout] 99 ~ self.set_display_text(i.to_string()).draw(terminal); [INFO] [stdout] 100 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/interfaces/app.rs:110:5 [INFO] [stdout] | [INFO] [stdout] 110 | / match self.close_bank_account(terminal) { [INFO] [stdout] 111 | | Err(i) => { [INFO] [stdout] 112 | | self.set_display_text(i.to_string()).draw(terminal); [INFO] [stdout] 113 | | }, [INFO] [stdout] 114 | | _ => {}, [INFO] [stdout] 115 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 110 ~ if let Err(i) = self.close_bank_account(terminal) { [INFO] [stdout] 111 ~ self.set_display_text(i.to_string()).draw(terminal); [INFO] [stdout] 112 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/interfaces/app.rs:122:5 [INFO] [stdout] | [INFO] [stdout] 122 | / match self.update_bank_account(terminal) { [INFO] [stdout] 123 | | Err(i) => { [INFO] [stdout] 124 | | self.set_display_text(i.to_string()).draw(terminal); [INFO] [stdout] 125 | | }, [INFO] [stdout] 126 | | _ => {}, [INFO] [stdout] 127 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 122 ~ if let Err(i) = self.update_bank_account(terminal) { [INFO] [stdout] 123 ~ self.set_display_text(i.to_string()).draw(terminal); [INFO] [stdout] 124 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/interfaces/app.rs:336:25 [INFO] [stdout] | [INFO] [stdout] 336 | self.set_display_text(format!("{p}")).draw(terminal); // Prompt the user for new account number [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `p.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/interfaces/app.rs:363:15 [INFO] [stdout] | [INFO] [stdout] 363 | ... 't' => if self.input.len() == 0{ [INFO] [stdout] | _________________________________^ [INFO] [stdout] 364 | | ... self.input.push_str(&c.to_string()) [INFO] [stdout] 365 | | ... }, [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 363 ~ 't'f self.input.len() == 0=> { [INFO] [stdout] 364 ~ self.input.push_str(&c.to_string()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character converted to string [INFO] [stdout] --> src/interfaces/app.rs:362:15 [INFO] [stdout] | [INFO] [stdout] 362 | ... 'c' => self.input.push_str(&c.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` without `to_string()`: `self.input.push(c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/interfaces/app.rs:363:18 [INFO] [stdout] | [INFO] [stdout] 363 | ... 't' => if self.input.len() == 0{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.input.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character converted to string [INFO] [stdout] --> src/interfaces/app.rs:364:9 [INFO] [stdout] | [INFO] [stdout] 364 | ... self.input.push_str(&c.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` without `to_string()`: `self.input.push(c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character converted to string [INFO] [stdout] --> src/interfaces/app.rs:366:15 [INFO] [stdout] | [INFO] [stdout] 366 | ... 'g' => self.input.push_str(&c.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` without `to_string()`: `self.input.push(c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/interfaces/app.rs:373:9 [INFO] [stdout] | [INFO] [stdout] 373 | / ... if self.input.len() < 4 { [INFO] [stdout] 374 | | ... self.input.push_str(&n.to_string()) [INFO] [stdout] 375 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 372 ~ 'n' [INFO] [stdout] 373 ~ if self.input.len() < 4 => { [INFO] [stdout] 374 | self.input.push_str(&n.to_string()) [INFO] [stdout] 375 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/interfaces/app.rs:378:9 [INFO] [stdout] | [INFO] [stdout] 378 | / ... if self.input.len() < 5 { [INFO] [stdout] 379 | | ... self.input.push_str(&n.to_string()) [INFO] [stdout] 380 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 377 ~ 'a' [INFO] [stdout] 378 ~ if self.input.len() < 5 => { [INFO] [stdout] 379 | self.input.push_str(&n.to_string()) [INFO] [stdout] 380 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/banking_system/models.rs:16:10 [INFO] [stdout] | [INFO] [stdout] 16 | if let Ok(_) = account.deposit(amount) { [INFO] [stdout] | -------^^^^^-------------------------- help: try: `if account.deposit(amount).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/banking_system/models.rs:27:10 [INFO] [stdout] | [INFO] [stdout] 27 | if let Ok(_) = account.withdraw(amount) { [INFO] [stdout] | -------^^^^^--------------------------- help: try: `if account.withdraw(amount).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/banking_system/models.rs:45:10 [INFO] [stdout] | [INFO] [stdout] 45 | if let Ok(_) = account.update(new_account_number){ [INFO] [stdout] | -------^^^^^------------------------------------- help: try: `if account.update(new_account_number).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/banking_system/utils.rs:23:34 [INFO] [stdout] | [INFO] [stdout] 23 | let customers: Vec = match serde_json::from_str(file.as_str()) { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 24 | | Ok(i) => i, [INFO] [stdout] 25 | | _ => {Vec::new()} [INFO] [stdout] 26 | | }; [INFO] [stdout] | |_____^ help: ascribe the type std::vec::Vec and replace your expression with: `serde_json::from_str(file.as_str()).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/banking_system/handlers.rs:17:4 [INFO] [stdout] | [INFO] [stdout] 17 | return Ok(("Customer saved".to_string(), customer)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return Ok(("Customer saved".to_string(), customer)); [INFO] [stdout] 17 + Ok(("Customer saved".to_string(), customer)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/banking_system/handlers.rs:19:4 [INFO] [stdout] | [INFO] [stdout] 19 | return Err("Failed to save user".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return Err("Failed to save user".to_string()); [INFO] [stdout] 19 + Err("Failed to save user".to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/banking_system/handlers.rs:29:22 [INFO] [stdout] | [INFO] [stdout] 29 | Some((c_i, c)) => return Some((c_i, c.to_owned())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - Some((c_i, c)) => return Some((c_i, c.to_owned())), [INFO] [stdout] 29 + Some((c_i, c)) => Some((c_i, c.to_owned())), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/banking_system/mod.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - println!("Thank you for banking with us"); [INFO] [stdout] 33 - return; [INFO] [stdout] 32 + println!("Thank you for banking with us"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/utils/mod.rs:18:33 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn generate_prompt(string: &String) -> Text { [INFO] [stdout] | ^^^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 18 | pub fn generate_prompt(string: &String) -> Text<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/utils/mod.rs:22:31 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn generate_hint(string: &String) -> Text { [INFO] [stdout] | ^^^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 22 | pub fn generate_hint(string: &String) -> Text<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/utils/mod.rs:26:32 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn generate_input(string: &String) -> Text{ [INFO] [stdout] | ^^^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 26 | pub fn generate_input(string: &String) -> Text<'_>{ [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/utils/mod.rs:18:33 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn generate_prompt(string: &String) -> Text { [INFO] [stdout] | ^^^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 18 | pub fn generate_prompt(string: &String) -> Text<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/utils/mod.rs:22:31 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn generate_hint(string: &String) -> Text { [INFO] [stdout] | ^^^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 22 | pub fn generate_hint(string: &String) -> Text<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/utils/mod.rs:26:32 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn generate_input(string: &String) -> Text{ [INFO] [stdout] | ^^^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 26 | pub fn generate_input(string: &String) -> Text<'_>{ [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/utils/mod.rs:18:33 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn generate_prompt(string: &String) -> Text { [INFO] [stdout] | ^^^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 18 | pub fn generate_prompt(string: &String) -> Text<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/utils/mod.rs:22:31 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn generate_hint(string: &String) -> Text { [INFO] [stdout] | ^^^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 22 | pub fn generate_hint(string: &String) -> Text<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/utils/mod.rs:26:32 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn generate_input(string: &String) -> Text{ [INFO] [stdout] | ^^^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 26 | pub fn generate_input(string: &String) -> Text<'_>{ [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `is_submitted`, `activity`, `should_quit`, and `terminal` are never read [INFO] [stdout] --> src/interfaces/app.rs:20:6 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct AppInterface<'a> { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] ... [INFO] [stdout] 20 | pub is_submitted: Option, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 21 | pub activity: Option, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 22 | pub should_quit: bool, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 23 | pub terminal: Option<&'a mut AppTerminal>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/events/mod.rs:22:10 [INFO] [stdout] | [INFO] [stdout] 22 | if c >= '0' && c <= '9' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `('0'..='9').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/interfaces/app.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 41 | if !self.create_new_customer(terminal).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.create_new_customer(terminal).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/interfaces/app.rs:45:6 [INFO] [stdout] | [INFO] [stdout] 45 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - self.set_hint_mode(1); [INFO] [stdout] 45 - return [INFO] [stdout] 44 + self.set_hint_mode(1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/interfaces/app.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - self.set_hint_mode(1); [INFO] [stdout] 58 - return [INFO] [stdout] 57 + self.set_hint_mode(1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/interfaces/app.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - self.set_hint_mode(1); [INFO] [stdout] 70 - return [INFO] [stdout] 69 + self.set_hint_mode(1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/interfaces/app.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - self.set_hint_mode(1); [INFO] [stdout] 82 - return [INFO] [stdout] 81 + self.set_hint_mode(1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/interfaces/app.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 93 - self.set_hint_mode(1); [INFO] [stdout] 94 - return [INFO] [stdout] 93 + self.set_hint_mode(1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/interfaces/app.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 106 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 105 - self.set_hint_mode(1); [INFO] [stdout] 106 - return [INFO] [stdout] 105 + self.set_hint_mode(1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/interfaces/app.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 118 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - self.set_hint_mode(1); [INFO] [stdout] 118 - return [INFO] [stdout] 117 + self.set_hint_mode(1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/interfaces/app.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 130 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 129 - self.set_hint_mode(1); [INFO] [stdout] 130 - return [INFO] [stdout] 129 + self.set_hint_mode(1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/interfaces/app.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | / match self.create_bank_account(terminal) { [INFO] [stdout] 51 | | Err(i) => { [INFO] [stdout] 52 | | self.set_display_text(i.to_string()).draw(terminal); [INFO] [stdout] 53 | | }, [INFO] [stdout] 54 | | _ => {} [INFO] [stdout] 55 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 50 ~ if let Err(i) = self.create_bank_account(terminal) { [INFO] [stdout] 51 ~ self.set_display_text(i.to_string()).draw(terminal); [INFO] [stdout] 52 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/interfaces/app.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 62 | / match self.deposit_money(terminal) { [INFO] [stdout] 63 | | Err(i) => { [INFO] [stdout] 64 | | self.set_display_text(i.to_string()).draw(terminal); [INFO] [stdout] 65 | | }, [INFO] [stdout] 66 | | _ => {}, [INFO] [stdout] 67 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 62 ~ if let Err(i) = self.deposit_money(terminal) { [INFO] [stdout] 63 ~ self.set_display_text(i.to_string()).draw(terminal); [INFO] [stdout] 64 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/interfaces/app.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | / match self.withdraw_money(terminal) { [INFO] [stdout] 75 | | Err(i) => { [INFO] [stdout] 76 | | self.set_display_text(i.to_string()).draw(terminal); [INFO] [stdout] 77 | | }, [INFO] [stdout] 78 | | _ => {}, [INFO] [stdout] 79 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 74 ~ if let Err(i) = self.withdraw_money(terminal) { [INFO] [stdout] 75 ~ self.set_display_text(i.to_string()).draw(terminal); [INFO] [stdout] 76 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/interfaces/app.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | / match self.check_balances(terminal) { [INFO] [stdout] 87 | | Err(i) => { [INFO] [stdout] 88 | | self.set_display_text(i.to_string()).draw(terminal); [INFO] [stdout] 89 | | }, [INFO] [stdout] 90 | | _ => {}, [INFO] [stdout] 91 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 86 ~ if let Err(i) = self.check_balances(terminal) { [INFO] [stdout] 87 ~ self.set_display_text(i.to_string()).draw(terminal); [INFO] [stdout] 88 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/interfaces/app.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | / match self.get_all_users(terminal) { [INFO] [stdout] 99 | | Err(i) => { [INFO] [stdout] 100 | | self.set_display_text(i.to_string()).draw(terminal); [INFO] [stdout] 101 | | }, [INFO] [stdout] 102 | | _ => {}, [INFO] [stdout] 103 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 98 ~ if let Err(i) = self.get_all_users(terminal) { [INFO] [stdout] 99 ~ self.set_display_text(i.to_string()).draw(terminal); [INFO] [stdout] 100 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/interfaces/app.rs:110:5 [INFO] [stdout] | [INFO] [stdout] 110 | / match self.close_bank_account(terminal) { [INFO] [stdout] 111 | | Err(i) => { [INFO] [stdout] 112 | | self.set_display_text(i.to_string()).draw(terminal); [INFO] [stdout] 113 | | }, [INFO] [stdout] 114 | | _ => {}, [INFO] [stdout] 115 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 110 ~ if let Err(i) = self.close_bank_account(terminal) { [INFO] [stdout] 111 ~ self.set_display_text(i.to_string()).draw(terminal); [INFO] [stdout] 112 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/interfaces/app.rs:122:5 [INFO] [stdout] | [INFO] [stdout] 122 | / match self.update_bank_account(terminal) { [INFO] [stdout] 123 | | Err(i) => { [INFO] [stdout] 124 | | self.set_display_text(i.to_string()).draw(terminal); [INFO] [stdout] 125 | | }, [INFO] [stdout] 126 | | _ => {}, [INFO] [stdout] 127 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 122 ~ if let Err(i) = self.update_bank_account(terminal) { [INFO] [stdout] 123 ~ self.set_display_text(i.to_string()).draw(terminal); [INFO] [stdout] 124 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/interfaces/app.rs:336:25 [INFO] [stdout] | [INFO] [stdout] 336 | self.set_display_text(format!("{p}")).draw(terminal); // Prompt the user for new account number [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `p.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/interfaces/app.rs:363:15 [INFO] [stdout] | [INFO] [stdout] 363 | ... 't' => if self.input.len() == 0{ [INFO] [stdout] | _________________________________^ [INFO] [stdout] 364 | | ... self.input.push_str(&c.to_string()) [INFO] [stdout] 365 | | ... }, [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 363 ~ 't'f self.input.len() == 0=> { [INFO] [stdout] 364 ~ self.input.push_str(&c.to_string()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character converted to string [INFO] [stdout] --> src/interfaces/app.rs:362:15 [INFO] [stdout] | [INFO] [stdout] 362 | ... 'c' => self.input.push_str(&c.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` without `to_string()`: `self.input.push(c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/interfaces/app.rs:363:18 [INFO] [stdout] | [INFO] [stdout] 363 | ... 't' => if self.input.len() == 0{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.input.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character converted to string [INFO] [stdout] --> src/interfaces/app.rs:364:9 [INFO] [stdout] | [INFO] [stdout] 364 | ... self.input.push_str(&c.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` without `to_string()`: `self.input.push(c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character converted to string [INFO] [stdout] --> src/interfaces/app.rs:366:15 [INFO] [stdout] | [INFO] [stdout] 366 | ... 'g' => self.input.push_str(&c.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` without `to_string()`: `self.input.push(c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/interfaces/app.rs:373:9 [INFO] [stdout] | [INFO] [stdout] 373 | / ... if self.input.len() < 4 { [INFO] [stdout] 374 | | ... self.input.push_str(&n.to_string()) [INFO] [stdout] 375 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 372 ~ 'n' [INFO] [stdout] 373 ~ if self.input.len() < 4 => { [INFO] [stdout] 374 | self.input.push_str(&n.to_string()) [INFO] [stdout] 375 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/interfaces/app.rs:378:9 [INFO] [stdout] | [INFO] [stdout] 378 | / ... if self.input.len() < 5 { [INFO] [stdout] 379 | | ... self.input.push_str(&n.to_string()) [INFO] [stdout] 380 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 377 ~ 'a' [INFO] [stdout] 378 ~ if self.input.len() < 5 => { [INFO] [stdout] 379 | self.input.push_str(&n.to_string()) [INFO] [stdout] 380 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/banking_system/models.rs:16:10 [INFO] [stdout] | [INFO] [stdout] 16 | if let Ok(_) = account.deposit(amount) { [INFO] [stdout] | -------^^^^^-------------------------- help: try: `if account.deposit(amount).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/banking_system/models.rs:27:10 [INFO] [stdout] | [INFO] [stdout] 27 | if let Ok(_) = account.withdraw(amount) { [INFO] [stdout] | -------^^^^^--------------------------- help: try: `if account.withdraw(amount).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/banking_system/models.rs:45:10 [INFO] [stdout] | [INFO] [stdout] 45 | if let Ok(_) = account.update(new_account_number){ [INFO] [stdout] | -------^^^^^------------------------------------- help: try: `if account.update(new_account_number).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/banking_system/utils.rs:23:34 [INFO] [stdout] | [INFO] [stdout] 23 | let customers: Vec = match serde_json::from_str(file.as_str()) { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 24 | | Ok(i) => i, [INFO] [stdout] 25 | | _ => {Vec::new()} [INFO] [stdout] 26 | | }; [INFO] [stdout] | |_____^ help: ascribe the type std::vec::Vec and replace your expression with: `serde_json::from_str(file.as_str()).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/banking_system/handlers.rs:17:4 [INFO] [stdout] | [INFO] [stdout] 17 | return Ok(("Customer saved".to_string(), customer)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return Ok(("Customer saved".to_string(), customer)); [INFO] [stdout] 17 + Ok(("Customer saved".to_string(), customer)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/banking_system/handlers.rs:19:4 [INFO] [stdout] | [INFO] [stdout] 19 | return Err("Failed to save user".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return Err("Failed to save user".to_string()); [INFO] [stdout] 19 + Err("Failed to save user".to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/banking_system/handlers.rs:29:22 [INFO] [stdout] | [INFO] [stdout] 29 | Some((c_i, c)) => return Some((c_i, c.to_owned())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - Some((c_i, c)) => return Some((c_i, c.to_owned())), [INFO] [stdout] 29 + Some((c_i, c)) => Some((c_i, c.to_owned())), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/banking_system/mod.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - println!("Thank you for banking with us"); [INFO] [stdout] 33 - return; [INFO] [stdout] 32 + println!("Thank you for banking with us"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/utils/mod.rs:18:33 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn generate_prompt(string: &String) -> Text { [INFO] [stdout] | ^^^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 18 | pub fn generate_prompt(string: &String) -> Text<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/utils/mod.rs:22:31 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn generate_hint(string: &String) -> Text { [INFO] [stdout] | ^^^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 22 | pub fn generate_hint(string: &String) -> Text<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/utils/mod.rs:26:32 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn generate_input(string: &String) -> Text{ [INFO] [stdout] | ^^^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 26 | pub fn generate_input(string: &String) -> Text<'_>{ [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.93s [INFO] running `Command { std: "docker" "inspect" "eff09ca83026fa190cef2c556c93450d9f6d1da628820c11c5e85e2676e08332", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eff09ca83026fa190cef2c556c93450d9f6d1da628820c11c5e85e2676e08332", kill_on_drop: false }` [INFO] [stdout] eff09ca83026fa190cef2c556c93450d9f6d1da628820c11c5e85e2676e08332