[INFO] cloning repository https://github.com/DoradoAcero/rust_practice [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DoradoAcero/rust_practice" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDoradoAcero%2Frust_practice", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDoradoAcero%2Frust_practice'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3c2b57c2e50899dda377022c1665c3458ca7a55b [INFO] linting DoradoAcero/rust_practice against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDoradoAcero%2Frust_practice" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/DoradoAcero/rust_practice [INFO] finished tweaking git repo https://github.com/DoradoAcero/rust_practice [INFO] tweaked toml for git repo https://github.com/DoradoAcero/rust_practice written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/DoradoAcero/rust_practice on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/DoradoAcero/rust_practice already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded proc-macro2 v1.0.88 [INFO] [stderr] Downloaded syn v2.0.80 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f4461cd35f30a4275410c546fee40ab3effdb7e587e43f0be8eb505c4fd79f33 [INFO] running `Command { std: "docker" "start" "-a" "f4461cd35f30a4275410c546fee40ab3effdb7e587e43f0be8eb505c4fd79f33", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f4461cd35f30a4275410c546fee40ab3effdb7e587e43f0be8eb505c4fd79f33", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f4461cd35f30a4275410c546fee40ab3effdb7e587e43f0be8eb505c4fd79f33", kill_on_drop: false }` [INFO] [stdout] f4461cd35f30a4275410c546fee40ab3effdb7e587e43f0be8eb505c4fd79f33 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 614edd5efa462137c743de75cceb48587eac9a0ce69d3a441f44e0d23a08155b [INFO] running `Command { std: "docker" "start" "-a" "614edd5efa462137c743de75cceb48587eac9a0ce69d3a441f44e0d23a08155b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.88 [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Compiling libc v0.2.161 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.80 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rust_practice v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/strats.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | target_word: target_word, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target_word` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/wordle_utils.rs:170:54 [INFO] [stdout] | [INFO] [stdout] 170 | None => {letter_freq.insert(chr, 1); ()} [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/wordle_utils.rs:213:21 [INFO] [stdout] | [INFO] [stdout] 213 | () [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/strats.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | target_word: target_word, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target_word` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/wordle_utils.rs:170:54 [INFO] [stdout] | [INFO] [stdout] 170 | None => {letter_freq.insert(chr, 1); ()} [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/wordle_utils.rs:213:21 [INFO] [stdout] | [INFO] [stdout] 213 | () [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/strats.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | / match index { [INFO] [stdout] 109 | | Some(i) => {possible_words.remove(i);}, [INFO] [stdout] 110 | | None => () [INFO] [stdout] 111 | | }; [INFO] [stdout] | |_________^ help: try: `if let Some(i) = index {possible_words.remove(i);}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/strats.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 156 | / match index { [INFO] [stdout] 157 | | Some(i) => {possible_words.remove(i);}, [INFO] [stdout] 158 | | None => () [INFO] [stdout] 159 | | }; [INFO] [stdout] | |_________^ help: try: `if let Some(i) = index {possible_words.remove(i);}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/wordle_utils.rs:45:59 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn wordle_compare(game_state: & mut GameState, guess: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 45 - pub fn wordle_compare(game_state: & mut GameState, guess: &String) { [INFO] [stdout] 45 + pub fn wordle_compare(game_state: & mut GameState, guess: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/wordle_utils.rs:94:27 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn get_possible_words<'a>(game_state: &GameState, possible_words: &Vec) -> Vec { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/wordle_utils.rs:140:24 [INFO] [stdout] | [INFO] [stdout] 140 | if !(word.chars().nth(letter.known_position.unwrap() as usize).unwrap() == chr) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word.chars().nth(letter.known_position.unwrap() as usize).unwrap() != chr)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/wordle_utils.rs:94:71 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn get_possible_words<'a>(game_state: &GameState, possible_words: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 94 - pub fn get_possible_words<'a>(game_state: &GameState, possible_words: &Vec) -> Vec { [INFO] [stdout] 94 + pub fn get_possible_words<'a>(game_state: &GameState, possible_words: &[String]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/wordle_utils.rs:140:21 [INFO] [stdout] | [INFO] [stdout] 140 | / ... if !(word.chars().nth(letter.known_position.unwrap() as usize).unwrap() == chr) { [INFO] [stdout] 141 | | ... to_remove.insert(0, word.clone()); // unideal, but no longer reading the file over and over, small improvements [INFO] [stdout] 142 | | ... } [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 139 ~ LetterStatus::LetterMatch [INFO] [stdout] 140 ~ if !(word.chars().nth(letter.known_position.unwrap() as usize).unwrap() == chr) => { [INFO] [stdout] 141 | to_remove.insert(0, word.clone()); // unideal, but no longer reading the file over and over, small improvements [INFO] [stdout] 142 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/wordle_utils.rs:145:21 [INFO] [stdout] | [INFO] [stdout] 145 | / if !word.contains(chr) { [INFO] [stdout] 146 | | to_remove.insert(0, word.clone()); [INFO] [stdout] 147 | | continue; [INFO] [stdout] 148 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 144 ~ LetterStatus::WordMatch [INFO] [stdout] 145 ~ if !word.contains(chr) => { [INFO] [stdout] 146 | to_remove.insert(0, word.clone()); [INFO] [stdout] 147 | continue; [INFO] [stdout] 148 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/wordle_utils.rs:196:5 [INFO] [stdout] | [INFO] [stdout] 196 | *word_scores.iter().max_by(|a, b| a.1.cmp(b.1)).unwrap().0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `word_scores.iter().max_by(|a, b| a.1.cmp(b.1)).unwrap().0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/wordle_utils.rs:206:21 [INFO] [stdout] | [INFO] [stdout] 206 | (*freq).0 += 1; [INFO] [stdout] | ^^^^^^^ help: try: `freq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/wordle_utils.rs:207:21 [INFO] [stdout] | [INFO] [stdout] 207 | (*freq).1[i] += 1; [INFO] [stdout] | ^^^^^^^ help: try: `freq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/wordle_utils.rs:224:18 [INFO] [stdout] | [INFO] [stdout] 224 | _ => (*freq).0 = 0 [INFO] [stdout] | ^^^^^^^ help: try: `freq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/wordle_utils.rs:241:5 [INFO] [stdout] | [INFO] [stdout] 241 | *word_scores.iter().max_by(|a, b| a.1.cmp(b.1)).unwrap().0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `word_scores.iter().max_by(|a, b| a.1.cmp(b.1)).unwrap().0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/strats.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | / match index { [INFO] [stdout] 109 | | Some(i) => {possible_words.remove(i);}, [INFO] [stdout] 110 | | None => () [INFO] [stdout] 111 | | }; [INFO] [stdout] | |_________^ help: try: `if let Some(i) = index {possible_words.remove(i);}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/strats.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 156 | / match index { [INFO] [stdout] 157 | | Some(i) => {possible_words.remove(i);}, [INFO] [stdout] 158 | | None => () [INFO] [stdout] 159 | | }; [INFO] [stdout] | |_________^ help: try: `if let Some(i) = index {possible_words.remove(i);}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/wordle_utils.rs:45:59 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn wordle_compare(game_state: & mut GameState, guess: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 45 - pub fn wordle_compare(game_state: & mut GameState, guess: &String) { [INFO] [stdout] 45 + pub fn wordle_compare(game_state: & mut GameState, guess: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/wordle_utils.rs:94:27 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn get_possible_words<'a>(game_state: &GameState, possible_words: &Vec) -> Vec { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/wordle_utils.rs:140:24 [INFO] [stdout] | [INFO] [stdout] 140 | if !(word.chars().nth(letter.known_position.unwrap() as usize).unwrap() == chr) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word.chars().nth(letter.known_position.unwrap() as usize).unwrap() != chr)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/wordle_utils.rs:94:71 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn get_possible_words<'a>(game_state: &GameState, possible_words: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 94 - pub fn get_possible_words<'a>(game_state: &GameState, possible_words: &Vec) -> Vec { [INFO] [stdout] 94 + pub fn get_possible_words<'a>(game_state: &GameState, possible_words: &[String]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/wordle_utils.rs:140:21 [INFO] [stdout] | [INFO] [stdout] 140 | / ... if !(word.chars().nth(letter.known_position.unwrap() as usize).unwrap() == chr) { [INFO] [stdout] 141 | | ... to_remove.insert(0, word.clone()); // unideal, but no longer reading the file over and over, small improvements [INFO] [stdout] 142 | | ... } [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 139 ~ LetterStatus::LetterMatch [INFO] [stdout] 140 ~ if !(word.chars().nth(letter.known_position.unwrap() as usize).unwrap() == chr) => { [INFO] [stdout] 141 | to_remove.insert(0, word.clone()); // unideal, but no longer reading the file over and over, small improvements [INFO] [stdout] 142 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/wordle_utils.rs:145:21 [INFO] [stdout] | [INFO] [stdout] 145 | / if !word.contains(chr) { [INFO] [stdout] 146 | | to_remove.insert(0, word.clone()); [INFO] [stdout] 147 | | continue; [INFO] [stdout] 148 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 144 ~ LetterStatus::WordMatch [INFO] [stdout] 145 ~ if !word.contains(chr) => { [INFO] [stdout] 146 | to_remove.insert(0, word.clone()); [INFO] [stdout] 147 | continue; [INFO] [stdout] 148 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/wordle_utils.rs:196:5 [INFO] [stdout] | [INFO] [stdout] 196 | *word_scores.iter().max_by(|a, b| a.1.cmp(b.1)).unwrap().0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `word_scores.iter().max_by(|a, b| a.1.cmp(b.1)).unwrap().0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/wordle_utils.rs:206:21 [INFO] [stdout] | [INFO] [stdout] 206 | (*freq).0 += 1; [INFO] [stdout] | ^^^^^^^ help: try: `freq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/wordle_utils.rs:207:21 [INFO] [stdout] | [INFO] [stdout] 207 | (*freq).1[i] += 1; [INFO] [stdout] | ^^^^^^^ help: try: `freq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/wordle_utils.rs:224:18 [INFO] [stdout] | [INFO] [stdout] 224 | _ => (*freq).0 = 0 [INFO] [stdout] | ^^^^^^^ help: try: `freq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/wordle_utils.rs:241:5 [INFO] [stdout] | [INFO] [stdout] 241 | *word_scores.iter().max_by(|a, b| a.1.cmp(b.1)).unwrap().0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `word_scores.iter().max_by(|a, b| a.1.cmp(b.1)).unwrap().0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.62s [INFO] running `Command { std: "docker" "inspect" "614edd5efa462137c743de75cceb48587eac9a0ce69d3a441f44e0d23a08155b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "614edd5efa462137c743de75cceb48587eac9a0ce69d3a441f44e0d23a08155b", kill_on_drop: false }` [INFO] [stdout] 614edd5efa462137c743de75cceb48587eac9a0ce69d3a441f44e0d23a08155b