[INFO] cloning repository https://github.com/DieracDelta/srcbot [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DieracDelta/srcbot" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDieracDelta%2Fsrcbot", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDieracDelta%2Fsrcbot'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] aab2b7da5b5cb199caf44081294ae0c78ed24a91 [INFO] linting DieracDelta/srcbot against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDieracDelta%2Fsrcbot" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/DieracDelta/srcbot [INFO] finished tweaking git repo https://github.com/DieracDelta/srcbot [INFO] tweaked toml for git repo https://github.com/DieracDelta/srcbot written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/DieracDelta/srcbot on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/DieracDelta/srcbot already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rustls-pki-types v1.13.2 [INFO] [stderr] Downloaded dirs v5.0.1 [INFO] [stderr] Downloaded redox_users v0.4.6 [INFO] [stderr] Downloaded dirs-sys v0.4.1 [INFO] [stderr] Downloaded itoa v1.0.16 [INFO] [stderr] Downloaded option-ext v0.2.0 [INFO] [stderr] Downloaded ryu v1.0.21 [INFO] [stderr] Downloaded cc v1.2.50 [INFO] [stderr] Downloaded serde_json v1.0.146 [INFO] [stderr] Downloaded reqwest v0.12.27 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ce311326525ff98b90564b44ca58a079bc53ed203c472d96267b047295159c88 [INFO] running `Command { std: "docker" "start" "-a" "ce311326525ff98b90564b44ca58a079bc53ed203c472d96267b047295159c88", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ce311326525ff98b90564b44ca58a079bc53ed203c472d96267b047295159c88", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ce311326525ff98b90564b44ca58a079bc53ed203c472d96267b047295159c88", kill_on_drop: false }` [INFO] [stdout] ce311326525ff98b90564b44ca58a079bc53ed203c472d96267b047295159c88 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6dc51f0bb1cd442407a99604ca5e4d3dda2e0ab155c3a31e542ddf86f002d365 [INFO] running `Command { std: "docker" "start" "-a" "6dc51f0bb1cd442407a99604ca5e4d3dda2e0ab155c3a31e542ddf86f002d365", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Compiling unicode-ident v1.0.22 [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Checking cfg-if v1.0.4 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking stable_deref_trait v1.2.1 [INFO] [stderr] Checking bytes v1.11.0 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Compiling parking_lot_core v0.9.12 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Checking itoa v1.0.16 [INFO] [stderr] Compiling find-msvc-tools v0.1.5 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking slab v0.4.11 [INFO] [stderr] Checking lock_api v0.4.14 [INFO] [stderr] Compiling pkg-config v0.3.32 [INFO] [stderr] Checking litemap v0.8.1 [INFO] [stderr] Compiling cc v1.2.50 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Checking writeable v0.6.2 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling icu_normalizer_data v2.1.1 [INFO] [stderr] Compiling icu_properties_data v2.1.2 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Compiling httparse v1.10.1 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking openssl-probe v0.1.6 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Checking anstyle v1.0.13 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking ryu v1.0.21 [INFO] [stderr] Checking anstyle-query v1.1.5 [INFO] [stderr] Compiling serde_json v1.0.146 [INFO] [stderr] Checking ipnet v2.11.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking is_terminal_polyfill v1.70.2 [INFO] [stderr] Checking indexmap v2.12.1 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking signal-hook-registry v1.4.7 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling anyhow v1.0.100 [INFO] [stderr] Checking clap_lex v0.7.6 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking iri-string v0.7.9 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking rustls-pki-types v1.13.2 [INFO] [stderr] Checking clap_builder v4.5.53 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking thread_local v1.1.9 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking nu-ansi-term v0.50.3 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking tempfile v3.23.0 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking clap v4.5.53 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking tokio-util v0.7.17 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking hyper-util v0.1.19 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.27 [INFO] [stderr] Checking srcbot v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/cache.rs:191:5 [INFO] [stdout] | [INFO] [stdout] 191 | /// When provided, prefixes the log filename for multi-arch support [INFO] [stdout] | ^^^^^^^^^^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] = note: `#[warn(clippy::doc_overindented_list_items)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/cache.rs:208:26 [INFO] [stdout] | [INFO] [stdout] 208 | let attr_safe = attr.replace('.', "_").replace('/', "_"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace(['.', '/'], "_")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] = note: `#[warn(clippy::collapsible_str_replace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/cache.rs:242:26 [INFO] [stdout] | [INFO] [stdout] 242 | let attr_safe = attr.replace('.', "_").replace('/', "_"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace(['.', '/'], "_")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/cache.rs:268:37 [INFO] [stdout] | [INFO] [stdout] 268 | let attr_safe = result.attr.replace('.', "_").replace('/', "_"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace(['.', '/'], "_")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/fix_hash.rs:63:19 [INFO] [stdout] | [INFO] [stdout] 63 | nixpkgs_path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 63 - nixpkgs_path: &PathBuf, [INFO] [stdout] 63 + nixpkgs_path: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/fix_hash.rs:95:66 [INFO] [stdout] | [INFO] [stdout] 95 | NixCommandResult::Completed { code, logs: _ } if code == Some(0) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] = note: `#[warn(clippy::redundant_guards)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 95 - NixCommandResult::Completed { code, logs: _ } if code == Some(0) => { [INFO] [stdout] 95 + NixCommandResult::Completed { code: Some(0), logs: _ } => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/fix_hash.rs:118:19 [INFO] [stdout] | [INFO] [stdout] 118 | nixpkgs_path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 118 - nixpkgs_path: &PathBuf, [INFO] [stdout] 118 + nixpkgs_path: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/cache.rs:191:5 [INFO] [stdout] | [INFO] [stdout] 191 | /// When provided, prefixes the log filename for multi-arch support [INFO] [stdout] | ^^^^^^^^^^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] = note: `#[warn(clippy::doc_overindented_list_items)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/cache.rs:208:26 [INFO] [stdout] | [INFO] [stdout] 208 | let attr_safe = attr.replace('.', "_").replace('/', "_"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace(['.', '/'], "_")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] = note: `#[warn(clippy::collapsible_str_replace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/fix_hash.rs:361:47 [INFO] [stdout] | [INFO] [stdout] 361 | async fn find_nix_file_for_attr(nixpkgs_path: &PathBuf, attr: &str, system: &str) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 361 - async fn find_nix_file_for_attr(nixpkgs_path: &PathBuf, attr: &str, system: &str) -> Result { [INFO] [stdout] 361 + async fn find_nix_file_for_attr(nixpkgs_path: &Path, attr: &str, system: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/cache.rs:242:26 [INFO] [stdout] | [INFO] [stdout] 242 | let attr_safe = attr.replace('.', "_").replace('/', "_"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace(['.', '/'], "_")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/cache.rs:268:37 [INFO] [stdout] | [INFO] [stdout] 268 | let attr_safe = result.attr.replace('.', "_").replace('/', "_"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace(['.', '/'], "_")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/fix_hash.rs:465:19 [INFO] [stdout] | [INFO] [stdout] 465 | nixpkgs_path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 465 - nixpkgs_path: &PathBuf, [INFO] [stdout] 465 + nixpkgs_path: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/fix_hash.rs:498:55 [INFO] [stdout] | [INFO] [stdout] 498 | NixCommandResult::Completed { code, logs } if code == Some(0) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 498 - NixCommandResult::Completed { code, logs } if code == Some(0) => { [INFO] [stdout] 498 + NixCommandResult::Completed { code: Some(0), logs } => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/fix_hash.rs:544:58 [INFO] [stdout] | [INFO] [stdout] 544 | NixCommandResult::Completed { code, logs: _ } if code == Some(0) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 544 - NixCommandResult::Completed { code, logs: _ } if code == Some(0) => { [INFO] [stdout] 544 + NixCommandResult::Completed { code: Some(0), logs: _ } => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/fix_hash.rs:567:38 [INFO] [stdout] | [INFO] [stdout] 567 | let attr_safe = result.attribute.replace('.', "_").replace('/', "_"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace(['.', '/'], "_")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/fix_hash.rs:716:1 [INFO] [stdout] | [INFO] [stdout] 716 | / async fn git_commit_and_push( [INFO] [stdout] 717 | | nixpkgs_path: &PathBuf, [INFO] [stdout] 718 | | attribute: &str, [INFO] [stdout] 719 | | intermediate: &str, [INFO] [stdout] ... | [INFO] [stdout] 724 | | branch: &str, [INFO] [stdout] 725 | | ) -> Result { [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/fix_hash.rs:722:15 [INFO] [stdout] | [INFO] [stdout] 722 | nix_file: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 722 - nix_file: &PathBuf, [INFO] [stdout] 722 + nix_file: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/fix_hash.rs:787:1 [INFO] [stdout] | [INFO] [stdout] 787 | / async fn process_fix_hash_worktree( [INFO] [stdout] 788 | | nixpkgs_path: &PathBuf, [INFO] [stdout] 789 | | attribute: &str, [INFO] [stdout] 790 | | intermediate: &str, [INFO] [stdout] ... | [INFO] [stdout] 799 | | builders: Option<&str>, [INFO] [stdout] 800 | | ) -> Result { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/fix_hash.rs:998:28 [INFO] [stdout] | [INFO] [stdout] 998 | let final_branch = branch [INFO] [stdout] | ____________________________^ [INFO] [stdout] 999 | | .map(|s| s.clone()) [INFO] [stdout] | |_______________________________^ help: consider calling the dedicated `cloned` method: `branch.cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (13/7) [INFO] [stdout] --> src/fix_hash.rs:1069:1 [INFO] [stdout] | [INFO] [stdout] 1069 | / pub async fn process_fix_hash( [INFO] [stdout] 1070 | | nixpkgs_path: &PathBuf, [INFO] [stdout] 1071 | | attribute: &str, [INFO] [stdout] 1072 | | intermediate: &str, [INFO] [stdout] ... | [INFO] [stdout] 1082 | | remote_config: Option<&RemoteBuilderConfig>, [INFO] [stdout] 1083 | | ) -> Result { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/fix_hash.rs:1070:19 [INFO] [stdout] | [INFO] [stdout] 1070 | nixpkgs_path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1070 - nixpkgs_path: &PathBuf, [INFO] [stdout] 1070 + nixpkgs_path: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (19/7) [INFO] [stdout] --> src/full_eval.rs:723:1 [INFO] [stdout] | [INFO] [stdout] 723 | / pub async fn process_pr_full_eval( [INFO] [stdout] 724 | | pr_num: u64, [INFO] [stdout] 725 | | token: Option<&String>, [INFO] [stdout] 726 | | nixpkgs: &PathBuf, [INFO] [stdout] ... | [INFO] [stdout] 742 | | cli_command: &str, [INFO] [stdout] 743 | | ) -> Result { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/full_eval.rs:861:8 [INFO] [stdout] | [INFO] [stdout] 861 | ): ( [INFO] [stdout] | ________^ [INFO] [stdout] 862 | | HashMap>, [INFO] [stdout] 863 | | Vec, [INFO] [stdout] 864 | | HashMap>, [INFO] [stdout] 865 | | bool, [INFO] [stdout] 866 | | ) = if let Some(state) = valid_saved_state { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/fix_hash.rs:63:19 [INFO] [stdout] | [INFO] [stdout] 63 | nixpkgs_path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 63 - nixpkgs_path: &PathBuf, [INFO] [stdout] 63 + nixpkgs_path: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/fix_hash.rs:95:66 [INFO] [stdout] | [INFO] [stdout] 95 | NixCommandResult::Completed { code, logs: _ } if code == Some(0) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] = note: `#[warn(clippy::redundant_guards)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 95 - NixCommandResult::Completed { code, logs: _ } if code == Some(0) => { [INFO] [stdout] 95 + NixCommandResult::Completed { code: Some(0), logs: _ } => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/git.rs:8:19 [INFO] [stdout] | [INFO] [stdout] 8 | nixpkgs_path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 8 - nixpkgs_path: &PathBuf, [INFO] [stdout] 8 + nixpkgs_path: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/fix_hash.rs:118:19 [INFO] [stdout] | [INFO] [stdout] 118 | nixpkgs_path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 118 - nixpkgs_path: &PathBuf, [INFO] [stdout] 118 + nixpkgs_path: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/fix_hash.rs:361:47 [INFO] [stdout] | [INFO] [stdout] 361 | async fn find_nix_file_for_attr(nixpkgs_path: &PathBuf, attr: &str, system: &str) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 361 - async fn find_nix_file_for_attr(nixpkgs_path: &PathBuf, attr: &str, system: &str) -> Result { [INFO] [stdout] 361 + async fn find_nix_file_for_attr(nixpkgs_path: &Path, attr: &str, system: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/nix.rs:52:19 [INFO] [stdout] | [INFO] [stdout] 52 | nixpkgs_path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 52 - nixpkgs_path: &PathBuf, [INFO] [stdout] 52 + nixpkgs_path: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/fix_hash.rs:465:19 [INFO] [stdout] | [INFO] [stdout] 465 | nixpkgs_path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 465 - nixpkgs_path: &PathBuf, [INFO] [stdout] 465 + nixpkgs_path: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/fix_hash.rs:498:55 [INFO] [stdout] | [INFO] [stdout] 498 | NixCommandResult::Completed { code, logs } if code == Some(0) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 498 - NixCommandResult::Completed { code, logs } if code == Some(0) => { [INFO] [stdout] 498 + NixCommandResult::Completed { code: Some(0), logs } => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/nix.rs:117:19 [INFO] [stdout] | [INFO] [stdout] 117 | nixpkgs_path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 117 - nixpkgs_path: &PathBuf, [INFO] [stdout] 117 + nixpkgs_path: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/fix_hash.rs:544:58 [INFO] [stdout] | [INFO] [stdout] 544 | NixCommandResult::Completed { code, logs: _ } if code == Some(0) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 544 - NixCommandResult::Completed { code, logs: _ } if code == Some(0) => { [INFO] [stdout] 544 + NixCommandResult::Completed { code: Some(0), logs: _ } => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/nix.rs:211:1 [INFO] [stdout] | [INFO] [stdout] 211 | / pub async fn build_intermediate_async( [INFO] [stdout] 212 | | nixpkgs_path: PathBuf, [INFO] [stdout] 213 | | attr: String, [INFO] [stdout] 214 | | intermediate: String, [INFO] [stdout] ... | [INFO] [stdout] 219 | | builders: Option<&str>, [INFO] [stdout] 220 | | ) -> (String, String, bool, String, bool) { [INFO] [stdout] | |_________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/nix.rs:250:34 [INFO] [stdout] | [INFO] [stdout] 250 | let attr_safe = attr.replace('.', "_").replace('/', "_"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace(['.', '/'], "_")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/fix_hash.rs:567:38 [INFO] [stdout] | [INFO] [stdout] 567 | let attr_safe = result.attribute.replace('.', "_").replace('/', "_"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace(['.', '/'], "_")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/fix_hash.rs:716:1 [INFO] [stdout] | [INFO] [stdout] 716 | / async fn git_commit_and_push( [INFO] [stdout] 717 | | nixpkgs_path: &PathBuf, [INFO] [stdout] 718 | | attribute: &str, [INFO] [stdout] 719 | | intermediate: &str, [INFO] [stdout] ... | [INFO] [stdout] 724 | | branch: &str, [INFO] [stdout] 725 | | ) -> Result { [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/fix_hash.rs:722:15 [INFO] [stdout] | [INFO] [stdout] 722 | nix_file: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 722 - nix_file: &PathBuf, [INFO] [stdout] 722 + nix_file: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/fix_hash.rs:787:1 [INFO] [stdout] | [INFO] [stdout] 787 | / async fn process_fix_hash_worktree( [INFO] [stdout] 788 | | nixpkgs_path: &PathBuf, [INFO] [stdout] 789 | | attribute: &str, [INFO] [stdout] 790 | | intermediate: &str, [INFO] [stdout] ... | [INFO] [stdout] 799 | | builders: Option<&str>, [INFO] [stdout] 800 | | ) -> Result { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|p| p.as_path())` on an `Option` value [INFO] [stdout] --> src/nix.rs:410:21 [INFO] [stdout] | [INFO] [stdout] 410 | log_path.as_ref().map(|p| p.as_path()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `log_path.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] = note: `#[warn(clippy::option_as_ref_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/nix.rs:488:34 [INFO] [stdout] | [INFO] [stdout] 488 | let attr_safe = attr.replace('.', "_").replace('/', "_"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace(['.', '/'], "_")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/nix.rs:826:37 [INFO] [stdout] | [INFO] [stdout] 826 | pub async fn has_attr(nixpkgs_path: &PathBuf, pkg_attr: &str, sub_attr: &str, system: &str) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 826 - pub async fn has_attr(nixpkgs_path: &PathBuf, pkg_attr: &str, sub_attr: &str, system: &str) -> bool { [INFO] [stdout] 826 + pub async fn has_attr(nixpkgs_path: &Path, pkg_attr: &str, sub_attr: &str, system: &str) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/nix.rs:842:44 [INFO] [stdout] | [INFO] [stdout] 842 | pub async fn pkg_attr_exists(nixpkgs_path: &PathBuf, attr: &str, system: &str) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 842 - pub async fn pkg_attr_exists(nixpkgs_path: &PathBuf, attr: &str, system: &str) -> bool { [INFO] [stdout] 842 + pub async fn pkg_attr_exists(nixpkgs_path: &Path, attr: &str, system: &str) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/nix.rs:860:19 [INFO] [stdout] | [INFO] [stdout] 860 | nixpkgs_path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 860 - nixpkgs_path: &PathBuf, [INFO] [stdout] 860 + nixpkgs_path: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/nix.rs:920:19 [INFO] [stdout] | [INFO] [stdout] 920 | nixpkgs_path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 920 - nixpkgs_path: &PathBuf, [INFO] [stdout] 920 + nixpkgs_path: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/fix_hash.rs:998:28 [INFO] [stdout] | [INFO] [stdout] 998 | let final_branch = branch [INFO] [stdout] | ____________________________^ [INFO] [stdout] 999 | | .map(|s| s.clone()) [INFO] [stdout] | |_______________________________^ help: consider calling the dedicated `cloned` method: `branch.cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (13/7) [INFO] [stdout] --> src/fix_hash.rs:1069:1 [INFO] [stdout] | [INFO] [stdout] 1069 | / pub async fn process_fix_hash( [INFO] [stdout] 1070 | | nixpkgs_path: &PathBuf, [INFO] [stdout] 1071 | | attribute: &str, [INFO] [stdout] 1072 | | intermediate: &str, [INFO] [stdout] ... | [INFO] [stdout] 1082 | | remote_config: Option<&RemoteBuilderConfig>, [INFO] [stdout] 1083 | | ) -> Result { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/fix_hash.rs:1070:19 [INFO] [stdout] | [INFO] [stdout] 1070 | nixpkgs_path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1070 - nixpkgs_path: &PathBuf, [INFO] [stdout] 1070 + nixpkgs_path: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/nix.rs:1055:15 [INFO] [stdout] | [INFO] [stdout] 1055 | .args(&["nix-store", "--delete", "--ignore-liveness", store_path]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["nix-store", "--delete", "--ignore-liveness", store_path]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/nix.rs:1153:19 [INFO] [stdout] | [INFO] [stdout] 1153 | nixpkgs_path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1153 - nixpkgs_path: &PathBuf, [INFO] [stdout] 1153 + nixpkgs_path: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/nix.rs:1205:22 [INFO] [stdout] | [INFO] [stdout] 1205 | nixpkgs_display: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1205 - nixpkgs_display: &PathBuf, [INFO] [stdout] 1205 + nixpkgs_display: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/nix.rs:1273:22 [INFO] [stdout] | [INFO] [stdout] 1273 | nixpkgs_display: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1273 - nixpkgs_display: &PathBuf, [INFO] [stdout] 1273 + nixpkgs_display: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/simple.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | / pub async fn process_pr( [INFO] [stdout] 20 | | pr_num: u64, [INFO] [stdout] 21 | | override_attr: Option<&String>, [INFO] [stdout] 22 | | token: Option<&String>, [INFO] [stdout] ... | [INFO] [stdout] 27 | | remote_config: Option<&RemoteBuilderConfig>, [INFO] [stdout] 28 | | ) -> Result { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (19/7) [INFO] [stdout] --> src/full_eval.rs:723:1 [INFO] [stdout] | [INFO] [stdout] 723 | / pub async fn process_pr_full_eval( [INFO] [stdout] 724 | | pr_num: u64, [INFO] [stdout] 725 | | token: Option<&String>, [INFO] [stdout] 726 | | nixpkgs: &PathBuf, [INFO] [stdout] ... | [INFO] [stdout] 742 | | cli_command: &str, [INFO] [stdout] 743 | | ) -> Result { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/summary.rs:26:26 [INFO] [stdout] | [INFO] [stdout] 26 | let attr_safe = attr.replace('.', "_").replace('/', "_"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace(['.', '/'], "_")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/summary.rs:38:26 [INFO] [stdout] | [INFO] [stdout] 38 | let attr_safe = attr.replace('.', "_").replace('/', "_"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace(['.', '/'], "_")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/summary.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | /// For passed (include_before_after=false): `[src](...), [package](...)` [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 50 | /// For passed (include_before_after=false): `[src](...), [package](...)` [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/summary.rs:143:1 [INFO] [stdout] | [INFO] [stdout] 143 | / pub fn build_summary_comment( [INFO] [stdout] 144 | | pr_num: u64, [INFO] [stdout] 145 | | results: &[FullEvalBuildResult], [INFO] [stdout] 146 | | log_url_base: Option<&str>, [INFO] [stdout] ... | [INFO] [stdout] 151 | | _remote_config: Option<&RemoteBuilderConfig>, [INFO] [stdout] 152 | | ) -> String { [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/summary.rs:163:14 [INFO] [stdout] | [INFO] [stdout] 163 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/summary.rs:253:5 [INFO] [stdout] | [INFO] [stdout] 253 | summary.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `summary.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/summary.rs:264:9 [INFO] [stdout] | [INFO] [stdout] 264 | summary.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `summary.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/full_eval.rs:861:8 [INFO] [stdout] | [INFO] [stdout] 861 | ): ( [INFO] [stdout] | ________^ [INFO] [stdout] 862 | | HashMap>, [INFO] [stdout] 863 | | Vec, [INFO] [stdout] 864 | | HashMap>, [INFO] [stdout] 865 | | bool, [INFO] [stdout] 866 | | ) = if let Some(state) = valid_saved_state { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/full_eval.rs:1344:18 [INFO] [stdout] | [INFO] [stdout] 1344 | Some(1 * 1024 * 1024 * 1024 * 1024) [INFO] [stdout] | ^^^^^^^^ help: consider reducing it to: `1024` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/git.rs:8:19 [INFO] [stdout] | [INFO] [stdout] 8 | nixpkgs_path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 8 - nixpkgs_path: &PathBuf, [INFO] [stdout] 8 + nixpkgs_path: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/nix.rs:52:19 [INFO] [stdout] | [INFO] [stdout] 52 | nixpkgs_path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 52 - nixpkgs_path: &PathBuf, [INFO] [stdout] 52 + nixpkgs_path: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/nix.rs:117:19 [INFO] [stdout] | [INFO] [stdout] 117 | nixpkgs_path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 117 - nixpkgs_path: &PathBuf, [INFO] [stdout] 117 + nixpkgs_path: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/nix.rs:211:1 [INFO] [stdout] | [INFO] [stdout] 211 | / pub async fn build_intermediate_async( [INFO] [stdout] 212 | | nixpkgs_path: PathBuf, [INFO] [stdout] 213 | | attr: String, [INFO] [stdout] 214 | | intermediate: String, [INFO] [stdout] ... | [INFO] [stdout] 219 | | builders: Option<&str>, [INFO] [stdout] 220 | | ) -> (String, String, bool, String, bool) { [INFO] [stdout] | |_________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/nix.rs:250:34 [INFO] [stdout] | [INFO] [stdout] 250 | let attr_safe = attr.replace('.', "_").replace('/', "_"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace(['.', '/'], "_")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|p| p.as_path())` on an `Option` value [INFO] [stdout] --> src/nix.rs:410:21 [INFO] [stdout] | [INFO] [stdout] 410 | log_path.as_ref().map(|p| p.as_path()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `log_path.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] = note: `#[warn(clippy::option_as_ref_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/nix.rs:488:34 [INFO] [stdout] | [INFO] [stdout] 488 | let attr_safe = attr.replace('.', "_").replace('/', "_"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace(['.', '/'], "_")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/nix.rs:826:37 [INFO] [stdout] | [INFO] [stdout] 826 | pub async fn has_attr(nixpkgs_path: &PathBuf, pkg_attr: &str, sub_attr: &str, system: &str) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 826 - pub async fn has_attr(nixpkgs_path: &PathBuf, pkg_attr: &str, sub_attr: &str, system: &str) -> bool { [INFO] [stdout] 826 + pub async fn has_attr(nixpkgs_path: &Path, pkg_attr: &str, sub_attr: &str, system: &str) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/nix.rs:842:44 [INFO] [stdout] | [INFO] [stdout] 842 | pub async fn pkg_attr_exists(nixpkgs_path: &PathBuf, attr: &str, system: &str) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 842 - pub async fn pkg_attr_exists(nixpkgs_path: &PathBuf, attr: &str, system: &str) -> bool { [INFO] [stdout] 842 + pub async fn pkg_attr_exists(nixpkgs_path: &Path, attr: &str, system: &str) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/nix.rs:860:19 [INFO] [stdout] | [INFO] [stdout] 860 | nixpkgs_path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 860 - nixpkgs_path: &PathBuf, [INFO] [stdout] 860 + nixpkgs_path: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/nix.rs:920:19 [INFO] [stdout] | [INFO] [stdout] 920 | nixpkgs_path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 920 - nixpkgs_path: &PathBuf, [INFO] [stdout] 920 + nixpkgs_path: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/nix.rs:1055:15 [INFO] [stdout] | [INFO] [stdout] 1055 | .args(&["nix-store", "--delete", "--ignore-liveness", store_path]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["nix-store", "--delete", "--ignore-liveness", store_path]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/nix.rs:1153:19 [INFO] [stdout] | [INFO] [stdout] 1153 | nixpkgs_path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1153 - nixpkgs_path: &PathBuf, [INFO] [stdout] 1153 + nixpkgs_path: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/nix.rs:1205:22 [INFO] [stdout] | [INFO] [stdout] 1205 | nixpkgs_display: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1205 - nixpkgs_display: &PathBuf, [INFO] [stdout] 1205 + nixpkgs_display: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/nix.rs:1273:22 [INFO] [stdout] | [INFO] [stdout] 1273 | nixpkgs_display: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1273 - nixpkgs_display: &PathBuf, [INFO] [stdout] 1273 + nixpkgs_display: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/nix.rs:1577:26 [INFO] [stdout] | [INFO] [stdout] 1577 | assert!(false || !false, "case 1: didn't exist, from cache -> check"); [INFO] [stdout] | ^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/nix.rs:1578:28 [INFO] [stdout] | [INFO] [stdout] 1578 | assert!(!(false || !true), "case 2: didn't exist, built fresh -> no check"); [INFO] [stdout] | ^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/nix.rs:1579:25 [INFO] [stdout] | [INFO] [stdout] 1579 | assert!(true || !false, "case 3: existed, from cache -> check"); [INFO] [stdout] | ^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/nix.rs:1580:25 [INFO] [stdout] | [INFO] [stdout] 1580 | assert!(true || !true, "case 4: existed, built locally -> check"); [INFO] [stdout] | ^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/nix.rs:1577:9 [INFO] [stdout] | [INFO] [stdout] 1577 | assert!(false || !false, "case 1: didn't exist, from cache -> check"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/nix.rs:1578:9 [INFO] [stdout] | [INFO] [stdout] 1578 | assert!(!(false || !true), "case 2: didn't exist, built fresh -> no check"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/nix.rs:1579:9 [INFO] [stdout] | [INFO] [stdout] 1579 | assert!(true || !false, "case 3: existed, from cache -> check"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/nix.rs:1580:9 [INFO] [stdout] | [INFO] [stdout] 1580 | assert!(true || !true, "case 4: existed, built locally -> check"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/simple.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | / pub async fn process_pr( [INFO] [stdout] 20 | | pr_num: u64, [INFO] [stdout] 21 | | override_attr: Option<&String>, [INFO] [stdout] 22 | | token: Option<&String>, [INFO] [stdout] ... | [INFO] [stdout] 27 | | remote_config: Option<&RemoteBuilderConfig>, [INFO] [stdout] 28 | | ) -> Result { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/summary.rs:26:26 [INFO] [stdout] | [INFO] [stdout] 26 | let attr_safe = attr.replace('.', "_").replace('/', "_"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace(['.', '/'], "_")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/summary.rs:38:26 [INFO] [stdout] | [INFO] [stdout] 38 | let attr_safe = attr.replace('.', "_").replace('/', "_"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace(['.', '/'], "_")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/summary.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | /// For passed (include_before_after=false): `[src](...), [package](...)` [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 50 | /// For passed (include_before_after=false): `[src](...), [package](...)` [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/summary.rs:143:1 [INFO] [stdout] | [INFO] [stdout] 143 | / pub fn build_summary_comment( [INFO] [stdout] 144 | | pr_num: u64, [INFO] [stdout] 145 | | results: &[FullEvalBuildResult], [INFO] [stdout] 146 | | log_url_base: Option<&str>, [INFO] [stdout] ... | [INFO] [stdout] 151 | | _remote_config: Option<&RemoteBuilderConfig>, [INFO] [stdout] 152 | | ) -> String { [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/summary.rs:163:14 [INFO] [stdout] | [INFO] [stdout] 163 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/summary.rs:253:5 [INFO] [stdout] | [INFO] [stdout] 253 | summary.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `summary.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/summary.rs:264:9 [INFO] [stdout] | [INFO] [stdout] 264 | summary.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `summary.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 48.39s [INFO] running `Command { std: "docker" "inspect" "6dc51f0bb1cd442407a99604ca5e4d3dda2e0ab155c3a31e542ddf86f002d365", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6dc51f0bb1cd442407a99604ca5e4d3dda2e0ab155c3a31e542ddf86f002d365", kill_on_drop: false }` [INFO] [stdout] 6dc51f0bb1cd442407a99604ca5e4d3dda2e0ab155c3a31e542ddf86f002d365