[INFO] cloning repository https://github.com/DerJesko/Rusty_Satellite
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DerJesko/Rusty_Satellite" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDerJesko%2FRusty_Satellite", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDerJesko%2FRusty_Satellite'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 6ce3a4521f5c32f7841f267a168c2485e3bb7240
[INFO] linting DerJesko/Rusty_Satellite against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDerJesko%2FRusty_Satellite" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/DerJesko/Rusty_Satellite
[INFO] finished tweaking git repo https://github.com/DerJesko/Rusty_Satellite
[INFO] tweaked toml for git repo https://github.com/DerJesko/Rusty_Satellite written to /workspace/builds/worker-3-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/DerJesko/Rusty_Satellite on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/DerJesko/Rusty_Satellite already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded libc v0.2.26
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 3bed7070e0f387fb525a5c928aba1c66ef851fc0322538eac739d0f5d93b685a
[INFO] running `Command { std: "docker" "start" "-a" "3bed7070e0f387fb525a5c928aba1c66ef851fc0322538eac739d0f5d93b685a", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "3bed7070e0f387fb525a5c928aba1c66ef851fc0322538eac739d0f5d93b685a", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "3bed7070e0f387fb525a5c928aba1c66ef851fc0322538eac739d0f5d93b685a", kill_on_drop: false }`
[INFO] [stdout] 3bed7070e0f387fb525a5c928aba1c66ef851fc0322538eac739d0f5d93b685a
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] e03411ab72e34669003e8146b32cfe10c93291d23f67dfd0e1725a25b2a690d2
[INFO] running `Command { std: "docker" "start" "-a" "e03411ab72e34669003e8146b32cfe10c93291d23f67dfd0e1725a25b2a690d2", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr]     Checking libc v0.2.26
[INFO] [stderr]     Checking rand v0.3.15
[INFO] [stderr]     Checking satsolve v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/formula.rs:43:13
[INFO] [stdout]    |
[INFO] [stdout] 43 |             clauses: clauses,
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `clauses`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/cdcl.rs:273:69
[INFO] [stdout]     |
[INFO] [stdout] 273 |         return CdClInstance{formula: initialFormula, stack: vec!(), receiver: receiver, senders: senders};
[INFO] [stdout]     |                                                                     ^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/cdcl.rs:273:89
[INFO] [stdout]     |
[INFO] [stdout] 273 |         return CdClInstance{formula: initialFormula, stack: vec!(), receiver: receiver, senders: senders};
[INFO] [stdout]     |                                                                                         ^^^^^^^^^^^^^^^^ help: replace it with: `senders`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/formula.rs:43:13
[INFO] [stdout]    |
[INFO] [stdout] 43 |             clauses: clauses,
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `clauses`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/cdcl.rs:273:69
[INFO] [stdout]     |
[INFO] [stdout] 273 |         return CdClInstance{formula: initialFormula, stack: vec!(), receiver: receiver, senders: senders};
[INFO] [stdout]     |                                                                     ^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `remove_clause` is never used
[INFO] [stdout]   --> src/formula.rs:17:8
[INFO] [stdout]    |
[INFO] [stdout]  5 | pub trait Formula {
[INFO] [stdout]    |           ------- method in this trait
[INFO] [stdout] ...
[INFO] [stdout] 17 |     fn remove_clause(&mut self, clause_to_remove:&TwoPointerClause);
[INFO] [stdout]    |        ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/cdcl.rs:273:89
[INFO] [stdout]     |
[INFO] [stdout] 273 |         return CdClInstance{formula: initialFormula, stack: vec!(), receiver: receiver, senders: senders};
[INFO] [stdout]     |                                                                                         ^^^^^^^^^^^^^^^^ help: replace it with: `senders`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/formula.rs:62:9
[INFO] [stdout]    |
[INFO] [stdout] 62 |         return false;
[INFO] [stdout]    |         ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 62 -         return false;
[INFO] [stdout] 62 +         false
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/formula.rs:106:9
[INFO] [stdout]     |
[INFO] [stdout] 106 | ...   return if return_clause_is_conflict {FormulaState::Conflict(return_clause)} else if return_clause_is_unit {FormulaState::Unit(return_clause)} else {FormulaState::Else};
[INFO] [stdout]     |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 106 -         return if return_clause_is_conflict {FormulaState::Conflict(return_clause)} else if return_clause_is_unit {FormulaState::Unit(return_clause)} else {FormulaState::Else};
[INFO] [stdout] 106 +         if return_clause_is_conflict {FormulaState::Conflict(return_clause)} else if return_clause_is_unit {FormulaState::Unit(return_clause)} else {FormulaState::Else}
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]  --> src/clause.rs:7:52
[INFO] [stdout]   |
[INFO] [stdout] 7 |     fn update_clause_state(&mut self, assignments: &Vec<Option<bool>>);
[INFO] [stdout]   |                                                    ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Option<bool>]`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]   = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/clause.rs:140:13
[INFO] [stdout]     |
[INFO] [stdout] 140 |             return;
[INFO] [stdout]     |             ^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 139 -             self.state = ClauseState::Open;
[INFO] [stdout] 140 -             return;
[INFO] [stdout] 139 +             self.state = ClauseState::Open;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/clause.rs:144:17
[INFO] [stdout]     |
[INFO] [stdout] 144 |                 return;
[INFO] [stdout]     |                 ^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 143 -                 self.state = ClauseState::Unit(pointer_1);
[INFO] [stdout] 144 -                 return;
[INFO] [stdout] 143 +                 self.state = ClauseState::Unit(pointer_1);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/clause.rs:147:17
[INFO] [stdout]     |
[INFO] [stdout] 147 |                 return;
[INFO] [stdout]     |                 ^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 146 -                 self.state = ClauseState::Unit(pointer_2);
[INFO] [stdout] 147 -                 return;
[INFO] [stdout] 146 +                 self.state = ClauseState::Unit(pointer_2);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/clause.rs:151:13
[INFO] [stdout]     |
[INFO] [stdout] 151 |             return;
[INFO] [stdout]     |             ^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 150 -             self.state = ClauseState::Unsatisfiable;
[INFO] [stdout] 151 -             return;
[INFO] [stdout] 150 +             self.state = ClauseState::Unsatisfiable;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stdout]   --> src/clause.rs:60:16
[INFO] [stdout]    |
[INFO] [stdout] 60 |         if let Some(_) = assignments[self.literals[pointer_1].value()] {
[INFO] [stdout]    |         -------^^^^^^^------------------------------------------------ help: try: `if assignments[self.literals[pointer_1].value()].is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout]    = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stdout]   --> src/clause.rs:99:16
[INFO] [stdout]    |
[INFO] [stdout] 99 |         if let Some(_) = assignments[self.literals[pointer_2].value()] {
[INFO] [stdout]    |         -------^^^^^^^------------------------------------------------ help: try: `if assignments[self.literals[pointer_2].value()].is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]    --> src/clause.rs:142:16
[INFO] [stdout]     |
[INFO] [stdout] 142 |             if assignments[self.literals[pointer_1].value()] == None {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `assignments[self.literals[pointer_1].value()].is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout]     = note: `#[warn(clippy::partialeq_to_none)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/clause.rs:160:21
[INFO] [stdout]     |
[INFO] [stdout] 160 |                     return SimpleLiteral::Positive(variable_index);
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 160 -                     return SimpleLiteral::Positive(variable_index);
[INFO] [stdout] 160 +                     SimpleLiteral::Positive(variable_index)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/clause.rs:164:21
[INFO] [stdout]     |
[INFO] [stdout] 164 |                     return SimpleLiteral::Negative(variable_index);
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 164 -                     return SimpleLiteral::Negative(variable_index);
[INFO] [stdout] 164 +                     SimpleLiteral::Negative(variable_index)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/clause.rs:188:42
[INFO] [stdout]     |
[INFO] [stdout] 188 |             if !clause.literals.contains(&l) {
[INFO] [stdout]     |                                          ^^ help: change this to: `l`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this pattern creates a reference to a reference
[INFO] [stdout]    --> src/clause.rs:193:33
[INFO] [stdout]     |
[INFO] [stdout] 193 |         clause.literals.retain(|ref x| x.value() != index);
[INFO] [stdout]     |                                 ^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 193 -         clause.literals.retain(|ref x| x.value() != index);
[INFO] [stdout] 193 +         clause.literals.retain(|x| x.value() != index);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]  --> src/literal.rs:6:39
[INFO] [stdout]   |
[INFO] [stdout] 6 |     fn is_satisfied(&self, variables: &Vec<Option<bool>>) -> bool;
[INFO] [stdout]   |                                       ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Option<bool>]`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()`
[INFO] [stdout]   --> src/literal.rs:20:55
[INFO] [stdout]    |
[INFO] [stdout] 20 |               SimpleLiteral::Positive(literal_index) => if let Some(assigned_value) = variables[literal_index] {
[INFO] [stdout]    |  _______________________________________________________^
[INFO] [stdout] 21 | |                 assigned_value
[INFO] [stdout] 22 | |             } else { false },
[INFO] [stdout]    | |____________________________^ help: replace it with: `variables[literal_index].unwrap_or_default()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default
[INFO] [stdout]    = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/cdcl.rs:61:9
[INFO] [stdout]    |
[INFO] [stdout] 61 |         return 0;
[INFO] [stdout]    |         ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 61 -         return 0;
[INFO] [stdout] 61 +         0
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is used to index `order`
[INFO] [stdout]   --> src/cdcl.rs:51:18
[INFO] [stdout]    |
[INFO] [stdout] 51 |         for i in 0..self.formula.assignments.len(){
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]    = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator and enumerate()
[INFO] [stdout]    |
[INFO] [stdout] 51 -         for i in 0..self.formula.assignments.len(){
[INFO] [stdout] 51 +         for (i, <item>) in order.iter_mut().enumerate().take(self.formula.assignments.len()){
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]   --> src/cdcl.rs:56:16
[INFO] [stdout]    |
[INFO] [stdout] 56 |             if self.formula.assignments[i]==None {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `self.formula.assignments[i].is_none()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/cdcl.rs:116:13
[INFO] [stdout]     |
[INFO] [stdout] 116 |             return Some((clause, -1));
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 116 -             return Some((clause, -1));
[INFO] [stdout] 116 +             Some((clause, -1))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/cdcl.rs:119:13
[INFO] [stdout]     |
[INFO] [stdout] 119 |             return Some((clause, secondHighest+1));
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 119 -             return Some((clause, secondHighest+1));
[INFO] [stdout] 119 +             Some((clause, secondHighest+1))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`isize` -> `isize`)
[INFO] [stdout]    --> src/cdcl.rs:106:25
[INFO] [stdout]     |
[INFO] [stdout] 106 |             let level = self.getLevel(lit.value()) as isize;
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.getLevel(lit.value())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/cdcl.rs:158:9
[INFO] [stdout]     |
[INFO] [stdout] 158 |         return -1;
[INFO] [stdout]     |         ^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 158 -         return -1;
[INFO] [stdout] 158 +         -1
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/cdcl.rs:185:9
[INFO] [stdout]     |
[INFO] [stdout] 185 |         return None;
[INFO] [stdout]     |         ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 185 -         return None;
[INFO] [stdout] 185 +         None
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/cdcl.rs:200:9
[INFO] [stdout]     |
[INFO] [stdout] 200 |         return false;
[INFO] [stdout]     |         ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 200 -         return false;
[INFO] [stdout] 200 +         false
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stdout]    --> src/cdcl.rs:213:17
[INFO] [stdout]     |
[INFO] [stdout] 213 |             let ref mut receiver = self.receiver.as_ref().unwrap();
[INFO] [stdout]     |             ----^^^^^^^^^^^^^^^^----------------------------------- help: try: `let receiver = &mut self.receiver.as_ref().unwrap();`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stdout]     = note: `#[warn(clippy::toplevel_ref_arg)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/cdcl.rs:264:9
[INFO] [stdout]     |
[INFO] [stdout] 264 |         return;  //may happen!
[INFO] [stdout]     |         ^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 263 -         }
[INFO] [stdout] 264 -         return;  //may happen!
[INFO] [stdout] 263 +         }//may happen!
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/cdcl.rs:273:9
[INFO] [stdout]     |
[INFO] [stdout] 273 |         return CdClInstance{formula: initialFormula, stack: vec!(), receiver: receiver, senders: senders};
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 273 -         return CdClInstance{formula: initialFormula, stack: vec!(), receiver: receiver, senders: senders};
[INFO] [stdout] 273 +         CdClInstance{formula: initialFormula, stack: vec!(), receiver: receiver, senders: senders}
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/cdcl.rs:284:12
[INFO] [stdout]     |
[INFO] [stdout] 284 |         if !self.unitPropagation(level).is_none(){
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.unitPropagation(level).is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/cdcl.rs:309:19
[INFO] [stdout]     |
[INFO] [stdout] 309 |             while !conflict.is_none() {  //backtracking (some failure)
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^^^^ help: try: `conflict.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/cdcl.rs:335:23
[INFO] [stdout]     |
[INFO] [stdout] 335 |                 while !conflict.is_none() {
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^^^^^ help: try: `conflict.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/cdcl.rs:363:9
[INFO] [stdout]     |
[INFO] [stdout] 363 |         return Some(true);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 363 -         return Some(true);
[INFO] [stdout] 363 +         Some(true)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]    --> src/cdcl.rs:346:21
[INFO] [stdout]     |
[INFO] [stdout] 346 |                     level = level - 1;
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^^^ help: replace it with: `level -= 1`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout]     = note: `#[warn(clippy::assign_op_pattern)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:91:5
[INFO] [stdout]    |
[INFO] [stdout] 91 |     return false;
[INFO] [stdout]    |     ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 91 -     return false;
[INFO] [stdout] 91 +     false
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `j` is used to index `senders`
[INFO] [stdout]   --> src/main.rs:56:18
[INFO] [stdout]    |
[INFO] [stdout] 56 |         for j in 0..threadAmount {
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout] help: consider using an iterator and enumerate()
[INFO] [stdout]    |
[INFO] [stdout] 56 -         for j in 0..threadAmount {
[INFO] [stdout] 56 +         for (j, <item>) in senders.iter().enumerate().take(threadAmount) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:71:13
[INFO] [stdout]    |
[INFO] [stdout] 71 |             return (res, solver.formula.assignments);
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 71 -             return (res, solver.formula.assignments);
[INFO] [stdout] 71 +             (res, solver.formula.assignments)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `remove_clause` is never used
[INFO] [stdout]   --> src/formula.rs:17:8
[INFO] [stdout]    |
[INFO] [stdout]  5 | pub trait Formula {
[INFO] [stdout]    |           ------- method in this trait
[INFO] [stdout] ...
[INFO] [stdout] 17 |     fn remove_clause(&mut self, clause_to_remove:&TwoPointerClause);
[INFO] [stdout]    |        ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/formula.rs:62:9
[INFO] [stdout]    |
[INFO] [stdout] 62 |         return false;
[INFO] [stdout]    |         ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 62 -         return false;
[INFO] [stdout] 62 +         false
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/formula.rs:106:9
[INFO] [stdout]     |
[INFO] [stdout] 106 | ...   return if return_clause_is_conflict {FormulaState::Conflict(return_clause)} else if return_clause_is_unit {FormulaState::Unit(return_clause)} else {FormulaState::Else};
[INFO] [stdout]     |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 106 -         return if return_clause_is_conflict {FormulaState::Conflict(return_clause)} else if return_clause_is_unit {FormulaState::Unit(return_clause)} else {FormulaState::Else};
[INFO] [stdout] 106 +         if return_clause_is_conflict {FormulaState::Conflict(return_clause)} else if return_clause_is_unit {FormulaState::Unit(return_clause)} else {FormulaState::Else}
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]  --> src/clause.rs:7:52
[INFO] [stdout]   |
[INFO] [stdout] 7 |     fn update_clause_state(&mut self, assignments: &Vec<Option<bool>>);
[INFO] [stdout]   |                                                    ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Option<bool>]`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]   = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/clause.rs:140:13
[INFO] [stdout]     |
[INFO] [stdout] 140 |             return;
[INFO] [stdout]     |             ^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 139 -             self.state = ClauseState::Open;
[INFO] [stdout] 140 -             return;
[INFO] [stdout] 139 +             self.state = ClauseState::Open;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/clause.rs:144:17
[INFO] [stdout]     |
[INFO] [stdout] 144 |                 return;
[INFO] [stdout]     |                 ^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 143 -                 self.state = ClauseState::Unit(pointer_1);
[INFO] [stdout] 144 -                 return;
[INFO] [stdout] 143 +                 self.state = ClauseState::Unit(pointer_1);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/clause.rs:147:17
[INFO] [stdout]     |
[INFO] [stdout] 147 |                 return;
[INFO] [stdout]     |                 ^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 146 -                 self.state = ClauseState::Unit(pointer_2);
[INFO] [stdout] 147 -                 return;
[INFO] [stdout] 146 +                 self.state = ClauseState::Unit(pointer_2);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/clause.rs:151:13
[INFO] [stdout]     |
[INFO] [stdout] 151 |             return;
[INFO] [stdout]     |             ^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 150 -             self.state = ClauseState::Unsatisfiable;
[INFO] [stdout] 151 -             return;
[INFO] [stdout] 150 +             self.state = ClauseState::Unsatisfiable;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stdout]   --> src/clause.rs:60:16
[INFO] [stdout]    |
[INFO] [stdout] 60 |         if let Some(_) = assignments[self.literals[pointer_1].value()] {
[INFO] [stdout]    |         -------^^^^^^^------------------------------------------------ help: try: `if assignments[self.literals[pointer_1].value()].is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout]    = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stdout]   --> src/clause.rs:99:16
[INFO] [stdout]    |
[INFO] [stdout] 99 |         if let Some(_) = assignments[self.literals[pointer_2].value()] {
[INFO] [stdout]    |         -------^^^^^^^------------------------------------------------ help: try: `if assignments[self.literals[pointer_2].value()].is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]    --> src/clause.rs:142:16
[INFO] [stdout]     |
[INFO] [stdout] 142 |             if assignments[self.literals[pointer_1].value()] == None {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `assignments[self.literals[pointer_1].value()].is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout]     = note: `#[warn(clippy::partialeq_to_none)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/clause.rs:160:21
[INFO] [stdout]     |
[INFO] [stdout] 160 |                     return SimpleLiteral::Positive(variable_index);
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 160 -                     return SimpleLiteral::Positive(variable_index);
[INFO] [stdout] 160 +                     SimpleLiteral::Positive(variable_index)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/clause.rs:164:21
[INFO] [stdout]     |
[INFO] [stdout] 164 |                     return SimpleLiteral::Negative(variable_index);
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 164 -                     return SimpleLiteral::Negative(variable_index);
[INFO] [stdout] 164 +                     SimpleLiteral::Negative(variable_index)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/clause.rs:188:42
[INFO] [stdout]     |
[INFO] [stdout] 188 |             if !clause.literals.contains(&l) {
[INFO] [stdout]     |                                          ^^ help: change this to: `l`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this pattern creates a reference to a reference
[INFO] [stdout]    --> src/clause.rs:193:33
[INFO] [stdout]     |
[INFO] [stdout] 193 |         clause.literals.retain(|ref x| x.value() != index);
[INFO] [stdout]     |                                 ^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 193 -         clause.literals.retain(|ref x| x.value() != index);
[INFO] [stdout] 193 +         clause.literals.retain(|x| x.value() != index);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]  --> src/literal.rs:6:39
[INFO] [stdout]   |
[INFO] [stdout] 6 |     fn is_satisfied(&self, variables: &Vec<Option<bool>>) -> bool;
[INFO] [stdout]   |                                       ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Option<bool>]`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()`
[INFO] [stdout]   --> src/literal.rs:20:55
[INFO] [stdout]    |
[INFO] [stdout] 20 |               SimpleLiteral::Positive(literal_index) => if let Some(assigned_value) = variables[literal_index] {
[INFO] [stdout]    |  _______________________________________________________^
[INFO] [stdout] 21 | |                 assigned_value
[INFO] [stdout] 22 | |             } else { false },
[INFO] [stdout]    | |____________________________^ help: replace it with: `variables[literal_index].unwrap_or_default()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default
[INFO] [stdout]    = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/cdcl.rs:61:9
[INFO] [stdout]    |
[INFO] [stdout] 61 |         return 0;
[INFO] [stdout]    |         ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 61 -         return 0;
[INFO] [stdout] 61 +         0
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is used to index `order`
[INFO] [stdout]   --> src/cdcl.rs:51:18
[INFO] [stdout]    |
[INFO] [stdout] 51 |         for i in 0..self.formula.assignments.len(){
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]    = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator and enumerate()
[INFO] [stdout]    |
[INFO] [stdout] 51 -         for i in 0..self.formula.assignments.len(){
[INFO] [stdout] 51 +         for (i, <item>) in order.iter_mut().enumerate().take(self.formula.assignments.len()){
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]   --> src/cdcl.rs:56:16
[INFO] [stdout]    |
[INFO] [stdout] 56 |             if self.formula.assignments[i]==None {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `self.formula.assignments[i].is_none()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/cdcl.rs:116:13
[INFO] [stdout]     |
[INFO] [stdout] 116 |             return Some((clause, -1));
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 116 -             return Some((clause, -1));
[INFO] [stdout] 116 +             Some((clause, -1))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/cdcl.rs:119:13
[INFO] [stdout]     |
[INFO] [stdout] 119 |             return Some((clause, secondHighest+1));
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 119 -             return Some((clause, secondHighest+1));
[INFO] [stdout] 119 +             Some((clause, secondHighest+1))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`isize` -> `isize`)
[INFO] [stdout]    --> src/cdcl.rs:106:25
[INFO] [stdout]     |
[INFO] [stdout] 106 |             let level = self.getLevel(lit.value()) as isize;
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.getLevel(lit.value())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/cdcl.rs:158:9
[INFO] [stdout]     |
[INFO] [stdout] 158 |         return -1;
[INFO] [stdout]     |         ^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 158 -         return -1;
[INFO] [stdout] 158 +         -1
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/cdcl.rs:185:9
[INFO] [stdout]     |
[INFO] [stdout] 185 |         return None;
[INFO] [stdout]     |         ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 185 -         return None;
[INFO] [stdout] 185 +         None
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/cdcl.rs:200:9
[INFO] [stdout]     |
[INFO] [stdout] 200 |         return false;
[INFO] [stdout]     |         ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 200 -         return false;
[INFO] [stdout] 200 +         false
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stdout]    --> src/cdcl.rs:213:17
[INFO] [stdout]     |
[INFO] [stdout] 213 |             let ref mut receiver = self.receiver.as_ref().unwrap();
[INFO] [stdout]     |             ----^^^^^^^^^^^^^^^^----------------------------------- help: try: `let receiver = &mut self.receiver.as_ref().unwrap();`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stdout]     = note: `#[warn(clippy::toplevel_ref_arg)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/cdcl.rs:264:9
[INFO] [stdout]     |
[INFO] [stdout] 264 |         return;  //may happen!
[INFO] [stdout]     |         ^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 263 -         }
[INFO] [stdout] 264 -         return;  //may happen!
[INFO] [stdout] 263 +         }//may happen!
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/cdcl.rs:273:9
[INFO] [stdout]     |
[INFO] [stdout] 273 |         return CdClInstance{formula: initialFormula, stack: vec!(), receiver: receiver, senders: senders};
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 273 -         return CdClInstance{formula: initialFormula, stack: vec!(), receiver: receiver, senders: senders};
[INFO] [stdout] 273 +         CdClInstance{formula: initialFormula, stack: vec!(), receiver: receiver, senders: senders}
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/cdcl.rs:284:12
[INFO] [stdout]     |
[INFO] [stdout] 284 |         if !self.unitPropagation(level).is_none(){
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.unitPropagation(level).is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/cdcl.rs:309:19
[INFO] [stdout]     |
[INFO] [stdout] 309 |             while !conflict.is_none() {  //backtracking (some failure)
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^^^^ help: try: `conflict.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/cdcl.rs:335:23
[INFO] [stdout]     |
[INFO] [stdout] 335 |                 while !conflict.is_none() {
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^^^^^ help: try: `conflict.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/cdcl.rs:363:9
[INFO] [stdout]     |
[INFO] [stdout] 363 |         return Some(true);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 363 -         return Some(true);
[INFO] [stdout] 363 +         Some(true)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]    --> src/cdcl.rs:346:21
[INFO] [stdout]     |
[INFO] [stdout] 346 |                     level = level - 1;
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^^^ help: replace it with: `level -= 1`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout]     = note: `#[warn(clippy::assign_op_pattern)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:91:5
[INFO] [stdout]    |
[INFO] [stdout] 91 |     return false;
[INFO] [stdout]    |     ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 91 -     return false;
[INFO] [stdout] 91 +     false
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `j` is used to index `senders`
[INFO] [stdout]   --> src/main.rs:56:18
[INFO] [stdout]    |
[INFO] [stdout] 56 |         for j in 0..threadAmount {
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout] help: consider using an iterator and enumerate()
[INFO] [stdout]    |
[INFO] [stdout] 56 -         for j in 0..threadAmount {
[INFO] [stdout] 56 +         for (j, <item>) in senders.iter().enumerate().take(threadAmount) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:71:13
[INFO] [stdout]    |
[INFO] [stdout] 71 |             return (res, solver.formula.assignments);
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 71 -             return (res, solver.formula.assignments);
[INFO] [stdout] 71 +             (res, solver.formula.assignments)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.29s
[INFO] running `Command { std: "docker" "inspect" "e03411ab72e34669003e8146b32cfe10c93291d23f67dfd0e1725a25b2a690d2", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "e03411ab72e34669003e8146b32cfe10c93291d23f67dfd0e1725a25b2a690d2", kill_on_drop: false }`
[INFO] [stdout] e03411ab72e34669003e8146b32cfe10c93291d23f67dfd0e1725a25b2a690d2