[INFO] cloning repository https://github.com/DawnRuby/GitlabWorker-Caching [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DawnRuby/GitlabWorker-Caching" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDawnRuby%2FGitlabWorker-Caching", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDawnRuby%2FGitlabWorker-Caching'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5d520efebe0f5be8bb9d2cc8b4c4581d17d2a15d [INFO] linting DawnRuby/GitlabWorker-Caching against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDawnRuby%2FGitlabWorker-Caching" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/DawnRuby/GitlabWorker-Caching [INFO] finished tweaking git repo https://github.com/DawnRuby/GitlabWorker-Caching [INFO] tweaked toml for git repo https://github.com/DawnRuby/GitlabWorker-Caching written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/DawnRuby/GitlabWorker-Caching on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/DawnRuby/GitlabWorker-Caching already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded sha256 v1.4.0 [INFO] [stderr] Downloaded serde_derive v1.0.189 [INFO] [stderr] Downloaded lazy-regex v3.0.2 [INFO] [stderr] Downloaded cpufeatures v0.2.10 [INFO] [stderr] Downloaded rustydav v0.1.3 [INFO] [stderr] Downloaded lazy-regex-proc_macros v3.0.1 [INFO] [stderr] Downloaded errno v0.3.5 [INFO] [stderr] Downloaded suppaftp v5.2.1 [INFO] [stderr] Downloaded normpath v1.1.1 [INFO] [stderr] Downloaded serde v1.0.189 [INFO] [stderr] Downloaded base64 v0.21.5 [INFO] [stderr] Downloaded openssl-sys v0.9.93 [INFO] [stderr] Downloaded reqwest v0.11.22 [INFO] [stderr] Downloaded rustix v0.38.20 [INFO] [stderr] Downloaded zstd-sys v2.0.9+zstd.1.5.5 [INFO] [stderr] Downloaded tokio v1.33.0 [INFO] [stderr] Downloaded linux-raw-sys v0.4.10 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ca78a870c9a7f5d4af778a70c36a1b5313345e2b11a106278fe4c45c581bd71b [INFO] running `Command { std: "docker" "start" "-a" "ca78a870c9a7f5d4af778a70c36a1b5313345e2b11a106278fe4c45c581bd71b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ca78a870c9a7f5d4af778a70c36a1b5313345e2b11a106278fe4c45c581bd71b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ca78a870c9a7f5d4af778a70c36a1b5313345e2b11a106278fe4c45c581bd71b", kill_on_drop: false }` [INFO] [stdout] ca78a870c9a7f5d4af778a70c36a1b5313345e2b11a106278fe4c45c581bd71b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e051f1202a15086a476d8073c82c147e8d0afdbadcdce54d3d00001b7ac54df9 [INFO] running `Command { std: "docker" "start" "-a" "e051f1202a15086a476d8073c82c147e8d0afdbadcdce54d3d00001b7ac54df9", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Compiling openssl v0.10.57 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Compiling serde v1.0.189 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking cpufeatures v0.2.10 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking httparse v1.8.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling zstd-safe v5.0.2+zstd.1.5.2 [INFO] [stderr] Compiling jobserver v0.1.27 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Compiling async-trait v0.1.74 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Checking deranged v0.3.9 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking password-hash v0.4.2 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.9 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking iana-time-zone v0.1.58 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking base64 v0.21.5 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking time v0.3.30 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking normpath v1.1.1 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking aes v0.8.3 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking tokio v1.33.0 [INFO] [stderr] Checking pbkdf2 v0.11.0 [INFO] [stderr] Checking url v2.4.1 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Compiling openssl-sys v0.9.93 [INFO] [stderr] Compiling zstd-sys v2.0.9+zstd.1.5.5 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.189 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Compiling lazy-regex-proc_macros v3.0.1 [INFO] [stderr] Checking lazy-regex v3.0.2 [INFO] [stderr] Checking suppaftp v5.2.1 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking sha256 v1.4.0 [INFO] [stderr] Checking h2 v0.3.21 [INFO] [stderr] Checking zstd v0.11.2+zstd.1.5.2 [INFO] [stderr] Checking zip v0.6.6 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.22 [INFO] [stderr] Checking rustydav v0.1.3 [INFO] [stderr] Checking worker-cache v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this looks like an `else if` but the `else` is missing [INFO] [stdout] --> src/envfuncs.rs:28:10 [INFO] [stdout] | [INFO] [stdout] 28 | } if env_var.starts_with(name) { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: to remove this lint, add the missing `else` or add a new line before the second `if` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#possible_missing_else [INFO] [stdout] = note: `#[warn(clippy::possible_missing_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like an `else if` but the `else` is missing [INFO] [stdout] --> src/envfuncs.rs:28:10 [INFO] [stdout] | [INFO] [stdout] 28 | } if env_var.starts_with(name) { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: to remove this lint, add the missing `else` or add a new line before the second `if` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#possible_missing_else [INFO] [stdout] = note: `#[warn(clippy::possible_missing_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/datas/enums.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / impl ToString for OsType { [INFO] [stdout] 17 | | /// converts an [`OsType`] enum variant into a string representation. [INFO] [stdout] 18 | | /// [INFO] [stdout] 19 | | /// Returns: [INFO] [stdout] ... | [INFO] [stdout] 28 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/datas/enums.rs:23:33 [INFO] [stdout] | [INFO] [stdout] 23 | OsType::Windows => {return format!("Windows")} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - OsType::Windows => {return format!("Windows")} [INFO] [stdout] 23 + OsType::Windows => {format!("Windows")} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/datas/enums.rs:24:30 [INFO] [stdout] | [INFO] [stdout] 24 | OsType::Unix => {return format!("Unix")} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - OsType::Unix => {return format!("Unix")} [INFO] [stdout] 24 + OsType::Unix => {format!("Unix")} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/datas/enums.rs:23:40 [INFO] [stdout] | [INFO] [stdout] 23 | OsType::Windows => {return format!("Windows")} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Windows".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/datas/enums.rs:24:37 [INFO] [stdout] | [INFO] [stdout] 24 | OsType::Unix => {return format!("Unix")} [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Unix".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/datas/enums.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 38 | return OsType::Windows; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return OsType::Windows; [INFO] [stdout] 38 + OsType::Windows [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/datas/enums.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | return OsType::Unix; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return OsType::Unix; [INFO] [stdout] 40 + OsType::Unix [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/datas/enums.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | return OsType::Unknown; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return OsType::Unknown; [INFO] [stdout] 43 + OsType::Unknown [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `restore_data` after checking its variant with `is_err` [INFO] [stdout] --> src/create_cache.rs:43:96 [INFO] [stdout] | [INFO] [stdout] 42 | if restore_data.is_err(){ [INFO] [stdout] | ------------------------ help: try: `if let Err() = restore_data` [INFO] [stdout] 43 | eprintln!("Encountered an error while generating the Restore Data. The error was: {}", restore_data.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `create_result` after checking its variant with `is_err` [INFO] [stdout] --> src/create_cache.rs:54:128 [INFO] [stdout] | [INFO] [stdout] 53 | if create_result.is_err(){ [INFO] [stdout] | ------------------------- help: try: `if let Err() = create_result` [INFO] [stdout] 54 | eprintln!("Encountered error while attempting to create base and project directory on webdav server. Error was: \n{}", create_result.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `cpy_files_result` after checking its variant with `is_err` [INFO] [stdout] --> src/create_cache.rs:61:115 [INFO] [stdout] | [INFO] [stdout] 60 | if cpy_files_result.is_err(){ [INFO] [stdout] | ---------------------------- help: try: `if let Err() = cpy_files_result` [INFO] [stdout] 61 | eprintln!("Encountered an error while attempting to copy files to the .cache directory. Error was: \n{}", cpy_files_result.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `zip_cache_result` after checking its variant with `is_err` [INFO] [stdout] --> src/create_cache.rs:69:94 [INFO] [stdout] | [INFO] [stdout] 68 | if zip_cache_result.is_err(){ [INFO] [stdout] | ---------------------------- help: try: `if let Err() = zip_cache_result` [INFO] [stdout] 69 | eprintln!("Encountered error while attempting to Zip cache folder. Error was: \n{}", zip_cache_result.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `copyres` after checking its variant with `is_err` [INFO] [stdout] --> src/create_cache.rs:76:121 [INFO] [stdout] | [INFO] [stdout] 75 | if copyres.is_err(){ [INFO] [stdout] | ------------------- help: try: `if let Err() = copyres` [INFO] [stdout] 76 | eprintln!("Encountered an error while attempting to upload the ZIP file to the webdav server. Error was: \n{}", copyres.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/create_cache.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 81 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - return Ok(()); [INFO] [stdout] 81 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/create_cache.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | if (folders.len() == 0) && (files.len() == 0){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `folders.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/create_cache.rs:29:34 [INFO] [stdout] | [INFO] [stdout] 29 | if (folders.len() == 0) && (files.len() == 0){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `files.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/create_cache.rs:129:5 [INFO] [stdout] | [INFO] [stdout] 129 | return Ok(restore_data) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 129 - return Ok(restore_data) [INFO] [stdout] 129 + Ok(restore_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/create_cache.rs:137:5 [INFO] [stdout] | [INFO] [stdout] 137 | /// JSON Data that should be written to restore the cache later on should represent `restore_data` [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 137 | /// JSON Data that should be written to restore the cache later on should represent `restore_data` [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/create_cache.rs:139:5 [INFO] [stdout] | [INFO] [stdout] 139 | /// Contains the data we want to restore later on. `json_data` should represent it's contents. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 139 | /// Contains the data we want to restore later on. `json_data` should represent it's contents. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/create_cache.rs:182:5 [INFO] [stdout] | [INFO] [stdout] 182 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 182 - return Ok(()); [INFO] [stdout] 182 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/create_cache.rs:170:9 [INFO] [stdout] | [INFO] [stdout] 170 | let copy_error: bool; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `copy_error` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 170 ~ [INFO] [stdout] 171 | [INFO] [stdout] 172 ~ let copy_error: bool = match restore_obj.cachetype{ [INFO] [stdout] 173 ~ enums::CacheType::Directory => {helpers::copy_recursively(restore_objpath.clone(), copy_to_path.clone()).is_err()} [INFO] [stdout] 174 ~ enums::CacheType::File => {fs::copy(restore_objpath.clone(), copy_to_path.clone()).is_err()} [INFO] [stdout] 175 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/datas/enums.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / impl ToString for OsType { [INFO] [stdout] 17 | | /// converts an [`OsType`] enum variant into a string representation. [INFO] [stdout] 18 | | /// [INFO] [stdout] 19 | | /// Returns: [INFO] [stdout] ... | [INFO] [stdout] 28 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/datas/enums.rs:23:33 [INFO] [stdout] | [INFO] [stdout] 23 | OsType::Windows => {return format!("Windows")} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - OsType::Windows => {return format!("Windows")} [INFO] [stdout] 23 + OsType::Windows => {format!("Windows")} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/datas/enums.rs:24:30 [INFO] [stdout] | [INFO] [stdout] 24 | OsType::Unix => {return format!("Unix")} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - OsType::Unix => {return format!("Unix")} [INFO] [stdout] 24 + OsType::Unix => {format!("Unix")} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/datas/enums.rs:23:40 [INFO] [stdout] | [INFO] [stdout] 23 | OsType::Windows => {return format!("Windows")} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Windows".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/datas/enums.rs:24:37 [INFO] [stdout] | [INFO] [stdout] 24 | OsType::Unix => {return format!("Unix")} [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Unix".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/create_cache.rs:207:5 [INFO] [stdout] | [INFO] [stdout] 207 | return generate_storage_data_file_from_pathbuf(file_path.unwrap().into_path_buf()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 207 - return generate_storage_data_file_from_pathbuf(file_path.unwrap().into_path_buf()); [INFO] [stdout] 207 + generate_storage_data_file_from_pathbuf(file_path.unwrap().into_path_buf()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/datas/enums.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 38 | return OsType::Windows; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return OsType::Windows; [INFO] [stdout] 38 + OsType::Windows [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/datas/enums.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | return OsType::Unix; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return OsType::Unix; [INFO] [stdout] 40 + OsType::Unix [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/datas/enums.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | return OsType::Unknown; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return OsType::Unknown; [INFO] [stdout] 43 + OsType::Unknown [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/create_cache.rs:221:8 [INFO] [stdout] | [INFO] [stdout] 221 | if !fs::metadata(file.clone()).is_ok(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(file.clone()).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `restore_data` after checking its variant with `is_err` [INFO] [stdout] --> src/create_cache.rs:43:96 [INFO] [stdout] | [INFO] [stdout] 42 | if restore_data.is_err(){ [INFO] [stdout] | ------------------------ help: try: `if let Err() = restore_data` [INFO] [stdout] 43 | eprintln!("Encountered an error while generating the Restore Data. The error was: {}", restore_data.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `create_result` after checking its variant with `is_err` [INFO] [stdout] --> src/create_cache.rs:54:128 [INFO] [stdout] | [INFO] [stdout] 53 | if create_result.is_err(){ [INFO] [stdout] | ------------------------- help: try: `if let Err() = create_result` [INFO] [stdout] 54 | eprintln!("Encountered error while attempting to create base and project directory on webdav server. Error was: \n{}", create_result.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `cpy_files_result` after checking its variant with `is_err` [INFO] [stdout] --> src/create_cache.rs:61:115 [INFO] [stdout] | [INFO] [stdout] 60 | if cpy_files_result.is_err(){ [INFO] [stdout] | ---------------------------- help: try: `if let Err() = cpy_files_result` [INFO] [stdout] 61 | eprintln!("Encountered an error while attempting to copy files to the .cache directory. Error was: \n{}", cpy_files_result.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/create_cache.rs:245:5 [INFO] [stdout] | [INFO] [stdout] 245 | return Result::Ok(res_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 245 - return Result::Ok(res_data); [INFO] [stdout] 245 + Result::Ok(res_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `zip_cache_result` after checking its variant with `is_err` [INFO] [stdout] --> src/create_cache.rs:69:94 [INFO] [stdout] | [INFO] [stdout] 68 | if zip_cache_result.is_err(){ [INFO] [stdout] | ---------------------------- help: try: `if let Err() = zip_cache_result` [INFO] [stdout] 69 | eprintln!("Encountered error while attempting to Zip cache folder. Error was: \n{}", zip_cache_result.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `copyres` after checking its variant with `is_err` [INFO] [stdout] --> src/create_cache.rs:76:121 [INFO] [stdout] | [INFO] [stdout] 75 | if copyres.is_err(){ [INFO] [stdout] | ------------------- help: try: `if let Err() = copyres` [INFO] [stdout] 76 | eprintln!("Encountered an error while attempting to upload the ZIP file to the webdav server. Error was: \n{}", copyres.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/create_cache.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 81 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - return Ok(()); [INFO] [stdout] 81 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/create_cache.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | if (folders.len() == 0) && (files.len() == 0){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `folders.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/create_cache.rs:29:34 [INFO] [stdout] | [INFO] [stdout] 29 | if (folders.len() == 0) && (files.len() == 0){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `files.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/create_cache.rs:272:5 [INFO] [stdout] | [INFO] [stdout] 272 | return generate_storage_data_directory_from_pathbuf(dir_canonicalize_result.unwrap().into_path_buf()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 272 - return generate_storage_data_directory_from_pathbuf(dir_canonicalize_result.unwrap().into_path_buf()); [INFO] [stdout] 272 + generate_storage_data_directory_from_pathbuf(dir_canonicalize_result.unwrap().into_path_buf()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/create_cache.rs:286:8 [INFO] [stdout] | [INFO] [stdout] 286 | if !fs::metadata(dir.clone()).is_ok(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(dir.clone()).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/create_cache.rs:310:5 [INFO] [stdout] | [INFO] [stdout] 310 | return Result::Ok(res_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 310 - return Result::Ok(res_data); [INFO] [stdout] 310 + Result::Ok(res_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/create_cache.rs:350:5 [INFO] [stdout] | [INFO] [stdout] 350 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 350 - return Ok(()); [INFO] [stdout] 350 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/create_cache.rs:129:5 [INFO] [stdout] | [INFO] [stdout] 129 | return Ok(restore_data) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 129 - return Ok(restore_data) [INFO] [stdout] 129 + Ok(restore_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/create_cache.rs:412:5 [INFO] [stdout] | [INFO] [stdout] 412 | return Ok(()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 412 - return Ok(()) [INFO] [stdout] 412 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/create_cache.rs:137:5 [INFO] [stdout] | [INFO] [stdout] 137 | /// JSON Data that should be written to restore the cache later on should represent `restore_data` [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 137 | /// JSON Data that should be written to restore the cache later on should represent `restore_data` [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/create_cache.rs:139:5 [INFO] [stdout] | [INFO] [stdout] 139 | /// Contains the data we want to restore later on. `json_data` should represent it's contents. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 139 | /// Contains the data we want to restore later on. `json_data` should represent it's contents. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/create_cache.rs:182:5 [INFO] [stdout] | [INFO] [stdout] 182 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 182 - return Ok(()); [INFO] [stdout] 182 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/create_cache.rs:170:9 [INFO] [stdout] | [INFO] [stdout] 170 | let copy_error: bool; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `copy_error` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 170 ~ [INFO] [stdout] 171 | [INFO] [stdout] 172 ~ let copy_error: bool = match restore_obj.cachetype{ [INFO] [stdout] 173 ~ enums::CacheType::Directory => {helpers::copy_recursively(restore_objpath.clone(), copy_to_path.clone()).is_err()} [INFO] [stdout] 174 ~ enums::CacheType::File => {fs::copy(restore_objpath.clone(), copy_to_path.clone()).is_err()} [INFO] [stdout] 175 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/create_cache.rs:390:9 [INFO] [stdout] | [INFO] [stdout] 390 | / if result.is_err(){ [INFO] [stdout] 391 | | return result; [INFO] [stdout] 392 | | } [INFO] [stdout] | |_________^ help: replace it with: `result?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/create_cache.rs:207:5 [INFO] [stdout] | [INFO] [stdout] 207 | return generate_storage_data_file_from_pathbuf(file_path.unwrap().into_path_buf()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 207 - return generate_storage_data_file_from_pathbuf(file_path.unwrap().into_path_buf()); [INFO] [stdout] 207 + generate_storage_data_file_from_pathbuf(file_path.unwrap().into_path_buf()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/create_cache.rs:221:8 [INFO] [stdout] | [INFO] [stdout] 221 | if !fs::metadata(file.clone()).is_ok(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(file.clone()).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/create_cache.rs:245:5 [INFO] [stdout] | [INFO] [stdout] 245 | return Result::Ok(res_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 245 - return Result::Ok(res_data); [INFO] [stdout] 245 + Result::Ok(res_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/create_cache.rs:454:5 [INFO] [stdout] | [INFO] [stdout] 454 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 454 - return Ok(()); [INFO] [stdout] 454 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/create_cache.rs:272:5 [INFO] [stdout] | [INFO] [stdout] 272 | return generate_storage_data_directory_from_pathbuf(dir_canonicalize_result.unwrap().into_path_buf()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 272 - return generate_storage_data_directory_from_pathbuf(dir_canonicalize_result.unwrap().into_path_buf()); [INFO] [stdout] 272 + generate_storage_data_directory_from_pathbuf(dir_canonicalize_result.unwrap().into_path_buf()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/create_cache.rs:286:8 [INFO] [stdout] | [INFO] [stdout] 286 | if !fs::metadata(dir.clone()).is_ok(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(dir.clone()).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/create_cache.rs:310:5 [INFO] [stdout] | [INFO] [stdout] 310 | return Result::Ok(res_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 310 - return Result::Ok(res_data); [INFO] [stdout] 310 + Result::Ok(res_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/create_cache.rs:477:5 [INFO] [stdout] | [INFO] [stdout] 477 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 477 - return Ok(()); [INFO] [stdout] 477 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `unzip_result` after checking its variant with `is_err` [INFO] [stdout] --> src/download_cache.rs:38:96 [INFO] [stdout] | [INFO] [stdout] 37 | if unzip_result.is_err(){ [INFO] [stdout] | ------------------------ help: try: `if let Err() = unzip_result` [INFO] [stdout] 38 | eprintln!("Encountered an error / warning while trying to unzip file. \nError was:{}", unzip_result.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/download_cache.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return Ok(()); [INFO] [stdout] 42 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/create_cache.rs:350:5 [INFO] [stdout] | [INFO] [stdout] 350 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 350 - return Ok(()); [INFO] [stdout] 350 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/create_cache.rs:412:5 [INFO] [stdout] | [INFO] [stdout] 412 | return Ok(()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 412 - return Ok(()) [INFO] [stdout] 412 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/download_cache.rs:126:5 [INFO] [stdout] | [INFO] [stdout] 126 | return Ok(file_name); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 126 - return Ok(file_name); [INFO] [stdout] 126 + Ok(file_name) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/create_cache.rs:390:9 [INFO] [stdout] | [INFO] [stdout] 390 | / if result.is_err(){ [INFO] [stdout] 391 | | return result; [INFO] [stdout] 392 | | } [INFO] [stdout] | |_________^ help: replace it with: `result?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/create_cache.rs:454:5 [INFO] [stdout] | [INFO] [stdout] 454 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 454 - return Ok(()); [INFO] [stdout] 454 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/create_cache.rs:477:5 [INFO] [stdout] | [INFO] [stdout] 477 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 477 - return Ok(()); [INFO] [stdout] 477 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/download_cache.rs:103:6 [INFO] [stdout] | [INFO] [stdout] 103 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `unzip_result` after checking its variant with `is_err` [INFO] [stdout] --> src/download_cache.rs:38:96 [INFO] [stdout] | [INFO] [stdout] 37 | if unzip_result.is_err(){ [INFO] [stdout] | ------------------------ help: try: `if let Err() = unzip_result` [INFO] [stdout] 38 | eprintln!("Encountered an error / warning while trying to unzip file. \nError was:{}", unzip_result.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/download_cache.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return Ok(()); [INFO] [stdout] 42 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/download_cache.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 156 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 156 - return Ok(()); [INFO] [stdout] 156 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/download_cache.rs:126:5 [INFO] [stdout] | [INFO] [stdout] 126 | return Ok(file_name); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 126 - return Ok(file_name); [INFO] [stdout] 126 + Ok(file_name) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `restore_res` after checking its variant with `is_err` [INFO] [stdout] --> src/restore_cache.rs:65:27 [INFO] [stdout] | [INFO] [stdout] 63 | if restore_res.is_err(){ [INFO] [stdout] | ----------------------- help: try: `if let Err() = restore_res` [INFO] [stdout] 64 | eprintln!("Encountered an unrecoverable error during restore process. [INFO] [stdout] 65 | \nError was: {}", restore_res.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `del_restore_dir_res` after checking its variant with `is_err` [INFO] [stdout] --> src/restore_cache.rs:74:27 [INFO] [stdout] | [INFO] [stdout] 71 | if del_restore_dir_res.is_err(){ [INFO] [stdout] | ------------------------------- help: try: `if let Err() = del_restore_dir_res` [INFO] [stdout] ... [INFO] [stdout] 74 | \nError was: {}", del_restore_dir_res.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/restore_cache.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return Ok(()); [INFO] [stdout] 78 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/restore_cache.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | if (folders.len() == 0) && (files.len() == 0){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `folders.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/restore_cache.rs:25:34 [INFO] [stdout] | [INFO] [stdout] 25 | if (folders.len() == 0) && (files.len() == 0){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `files.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/download_cache.rs:103:6 [INFO] [stdout] | [INFO] [stdout] 103 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/download_cache.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 156 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 156 - return Ok(()); [INFO] [stdout] 156 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `restore_res` after checking its variant with `is_err` [INFO] [stdout] --> src/restore_cache.rs:65:27 [INFO] [stdout] | [INFO] [stdout] 63 | if restore_res.is_err(){ [INFO] [stdout] | ----------------------- help: try: `if let Err() = restore_res` [INFO] [stdout] 64 | eprintln!("Encountered an unrecoverable error during restore process. [INFO] [stdout] 65 | \nError was: {}", restore_res.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `del_restore_dir_res` after checking its variant with `is_err` [INFO] [stdout] --> src/restore_cache.rs:74:27 [INFO] [stdout] | [INFO] [stdout] 71 | if del_restore_dir_res.is_err(){ [INFO] [stdout] | ------------------------------- help: try: `if let Err() = del_restore_dir_res` [INFO] [stdout] ... [INFO] [stdout] 74 | \nError was: {}", del_restore_dir_res.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/restore_cache.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return Ok(()); [INFO] [stdout] 78 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/restore_cache.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | /// about the data to be restored, such as the cache type (directory or file), the restore destination, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 89 | /// about the data to be restored, such as the cache type (directory or file), the restore destination, [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/restore_cache.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | /// and the name of the object to be restored. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 90 | /// and the name of the object to be restored. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/restore_cache.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 92 | /// should be restored. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 92 | /// should be restored. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/restore_cache.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | if (folders.len() == 0) && (files.len() == 0){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `folders.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/restore_cache.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | /// restored. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 94 | /// restored. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `restore_file_res` after checking its variant with `is_err` [INFO] [stdout] --> src/restore_cache.rs:118:36 [INFO] [stdout] | [INFO] [stdout] 115 | if restore_file_res.is_err() { [INFO] [stdout] | ---------------------------- help: try: `if let Err() = restore_file_res` [INFO] [stdout] ... [INFO] [stdout] 118 | \n{}", restore_file_res.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `restore_file_res` after checking its variant with `is_err` [INFO] [stdout] --> src/restore_cache.rs:134:37 [INFO] [stdout] | [INFO] [stdout] 131 | if restore_file_res.is_err() { [INFO] [stdout] | ---------------------------- help: try: `if let Err() = restore_file_res` [INFO] [stdout] ... [INFO] [stdout] 134 | \n{}", restore_file_res.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/restore_cache.rs:143:5 [INFO] [stdout] | [INFO] [stdout] 143 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 - return Ok(()); [INFO] [stdout] 143 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/restore_cache.rs:25:34 [INFO] [stdout] | [INFO] [stdout] 25 | if (folders.len() == 0) && (files.len() == 0){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `files.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/restore_cache.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | /// about the data to be restored, such as the cache type (directory or file), the restore destination, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 89 | /// about the data to be restored, such as the cache type (directory or file), the restore destination, [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/restore_cache.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | /// and the name of the object to be restored. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 90 | /// and the name of the object to be restored. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/restore_cache.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 92 | /// should be restored. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 92 | /// should be restored. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/restore_cache.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | /// restored. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 94 | /// restored. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `restore_file_res` after checking its variant with `is_err` [INFO] [stdout] --> src/restore_cache.rs:118:36 [INFO] [stdout] | [INFO] [stdout] 115 | if restore_file_res.is_err() { [INFO] [stdout] | ---------------------------- help: try: `if let Err() = restore_file_res` [INFO] [stdout] ... [INFO] [stdout] 118 | \n{}", restore_file_res.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `restore_file_res` after checking its variant with `is_err` [INFO] [stdout] --> src/restore_cache.rs:134:37 [INFO] [stdout] | [INFO] [stdout] 131 | if restore_file_res.is_err() { [INFO] [stdout] | ---------------------------- help: try: `if let Err() = restore_file_res` [INFO] [stdout] ... [INFO] [stdout] 134 | \n{}", restore_file_res.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/restore_cache.rs:143:5 [INFO] [stdout] | [INFO] [stdout] 143 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 - return Ok(()); [INFO] [stdout] 143 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/restore_cache.rs:119:20 [INFO] [stdout] | [INFO] [stdout] 119 | error_count = error_count +1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_count += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/restore_cache.rs:119:20 [INFO] [stdout] | [INFO] [stdout] 119 | error_count = error_count +1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_count += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/restore_cache.rs:135:21 [INFO] [stdout] | [INFO] [stdout] 135 | error_count = error_count +1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_count += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/restore_cache.rs:135:21 [INFO] [stdout] | [INFO] [stdout] 135 | error_count = error_count +1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_count += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/restore_cache.rs:178:5 [INFO] [stdout] | [INFO] [stdout] 178 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 178 - return Ok(()); [INFO] [stdout] 178 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/restore_cache.rs:178:5 [INFO] [stdout] | [INFO] [stdout] 178 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 178 - return Ok(()); [INFO] [stdout] 178 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/restore_cache.rs:212:5 [INFO] [stdout] | [INFO] [stdout] 212 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 212 - return Ok(()); [INFO] [stdout] 212 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/restore_cache.rs:212:5 [INFO] [stdout] | [INFO] [stdout] 212 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 212 - return Ok(()); [INFO] [stdout] 212 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/envfuncs.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | return found_variables; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return found_variables; [INFO] [stdout] 34 + found_variables [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/envfuncs.rs:29:36 [INFO] [stdout] | [INFO] [stdout] 29 | ...v.to_str().expect(format!("Could not convert value of the enviorement variable {env_var} to string.").as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("Could not convert value of the enviorement variable {env_var} to string."))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/envfuncs.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | /// environment variable retrieval fails. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 44 | /// environment variable retrieval fails. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/envfuncs.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | /// variable is not found or cannot be retrieved. If `exitonfail` is `true`, the program will exit with [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 46 | /// variable is not found or cannot be retrieved. If `exitonfail` is `true`, the program will exit with [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/envfuncs.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | return found_variables; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return found_variables; [INFO] [stdout] 34 + found_variables [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/envfuncs.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | /// a status code of 2. If `exitonfail` is `false`, the program will continue execution and return an empty string [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 47 | /// a status code of 2. If `exitonfail` is `false`, the program will continue execution and return an empty string [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/envfuncs.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | return get_envvar_result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return get_envvar_result.unwrap(); [INFO] [stdout] 65 + get_envvar_result.unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/envfuncs.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | / return safe_get_envvar("WEBDAVUSER", [INFO] [stdout] 77 | | "WEBDAVUSER env var not set. [INFO] [stdout] 78 | | Please make sure to set one. We currently do not support unsecured webdav servers.", [INFO] [stdout] 79 | | true); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 ~ safe_get_envvar("WEBDAVUSER", [INFO] [stdout] 77 + "WEBDAVUSER env var not set. [INFO] [stdout] 78 + Please make sure to set one. We currently do not support unsecured webdav servers.", [INFO] [stdout] 79 ~ true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/envfuncs.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | / return safe_get_envvar("WEBDAVPASS", [INFO] [stdout] 90 | | "WEBDAVPASS env var not set. [INFO] [stdout] 91 | | Please make sure to set one. [INFO] [stdout] 92 | | We currently do not support unsecured webdav servers.", true); [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 ~ safe_get_envvar("WEBDAVPASS", [INFO] [stdout] 90 + "WEBDAVPASS env var not set. [INFO] [stdout] 91 + Please make sure to set one. [INFO] [stdout] 92 ~ We currently do not support unsecured webdav servers.", true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/envfuncs.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | / return safe_get_envvar("WEBDAVADDR", [INFO] [stdout] 103 | | "WEBDAVPASS env var not set. [INFO] [stdout] 104 | | Please make sure to set one otherwise we don't know where to connect.", [INFO] [stdout] 105 | | true); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 ~ safe_get_envvar("WEBDAVADDR", [INFO] [stdout] 103 + "WEBDAVPASS env var not set. [INFO] [stdout] 104 + Please make sure to set one otherwise we don't know where to connect.", [INFO] [stdout] 105 ~ true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/envfuncs.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 115 | / return safe_get_envvar("CI_PROJECT_ID", [INFO] [stdout] 116 | | "Could not find CI_PROJECT_ID enviorement variable. [INFO] [stdout] 117 | | Please make sure that you are using a gilab server or set the value manually to a unique value.", [INFO] [stdout] 118 | | true); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 115 ~ safe_get_envvar("CI_PROJECT_ID", [INFO] [stdout] 116 + "Could not find CI_PROJECT_ID enviorement variable. [INFO] [stdout] 117 + Please make sure that you are using a gilab server or set the value manually to a unique value.", [INFO] [stdout] 118 ~ true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/envfuncs.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 128 | / return safe_get_envvar("CI_COMMIT_BRANCH", [INFO] [stdout] 129 | | "Could not find CI_COMMIT_BRANCH or CI_MERGE_REQUEST_TARGET_BRANCH_NAME enviorement variable. [INFO] [stdout] 130 | | Please make sure that you are using a gilab server or set the value manually to a unique value.", [INFO] [stdout] 131 | | true); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 128 ~ safe_get_envvar("CI_COMMIT_BRANCH", [INFO] [stdout] 129 + "Could not find CI_COMMIT_BRANCH or CI_MERGE_REQUEST_TARGET_BRANCH_NAME enviorement variable. [INFO] [stdout] 130 + Please make sure that you are using a gilab server or set the value manually to a unique value.", [INFO] [stdout] 131 ~ true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/envfuncs.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 152 | return format!("{}-{}.zip", ostype.to_string(), get_branch_name()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 - return format!("{}-{}.zip", ostype.to_string(), get_branch_name()); [INFO] [stdout] 152 + format!("{}-{}.zip", ostype.to_string(), get_branch_name()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/envfuncs.rs:29:36 [INFO] [stdout] | [INFO] [stdout] 29 | ...v.to_str().expect(format!("Could not convert value of the enviorement variable {env_var} to string.").as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("Could not convert value of the enviorement variable {env_var} to string."))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/envfuncs.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | /// environment variable retrieval fails. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 44 | /// environment variable retrieval fails. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/envfuncs.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | /// variable is not found or cannot be retrieved. If `exitonfail` is `true`, the program will exit with [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 46 | /// variable is not found or cannot be retrieved. If `exitonfail` is `true`, the program will exit with [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/envfuncs.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | /// a status code of 2. If `exitonfail` is `false`, the program will continue execution and return an empty string [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 47 | /// a status code of 2. If `exitonfail` is `false`, the program will continue execution and return an empty string [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/envfuncs.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | return get_envvar_result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return get_envvar_result.unwrap(); [INFO] [stdout] 65 + get_envvar_result.unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/zip.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | /// stripped from the file paths before adding them to the zip archive. This is useful when you want to [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 18 | /// stripped from the file paths before adding them to the zip archive. This is useful when you want to [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/zip.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | /// create a zip archive that contains files from a specific directory, but you don't want the directory [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 19 | /// create a zip archive that contains files from a specific directory, but you don't want the directory [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/envfuncs.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | / return safe_get_envvar("WEBDAVUSER", [INFO] [stdout] 77 | | "WEBDAVUSER env var not set. [INFO] [stdout] 78 | | Please make sure to set one. We currently do not support unsecured webdav servers.", [INFO] [stdout] 79 | | true); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 ~ safe_get_envvar("WEBDAVUSER", [INFO] [stdout] 77 + "WEBDAVUSER env var not set. [INFO] [stdout] 78 + Please make sure to set one. We currently do not support unsecured webdav servers.", [INFO] [stdout] 79 ~ true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/zip.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | /// structure to be included in [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 20 | /// structure to be included in [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/zip.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | /// It represents the output stream where the zip file will be written to. It could be any type [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 22 | /// It represents the output stream where the zip file will be written to. It could be any type [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/zip.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | /// that implements these traits, such as a [`File`] or a [`TcpStream`]. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 23 | /// that implements these traits, such as a [`File`] or a [`TcpStream`]. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/zip.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | /// compression method to be used when creating the zip file. The [`zip::CompressionMethod`] enum provides [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 25 | /// compression method to be used when creating the zip file. The [`zip::CompressionMethod`] enum provides [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/zip.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | /// different compression methods such as `Stored`, `Deflated`, `Bzip2`, etc. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 26 | /// different compression methods such as `Stored`, `Deflated`, `Bzip2`, etc. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/envfuncs.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | / return safe_get_envvar("WEBDAVPASS", [INFO] [stdout] 90 | | "WEBDAVPASS env var not set. [INFO] [stdout] 91 | | Please make sure to set one. [INFO] [stdout] 92 | | We currently do not support unsecured webdav servers.", true); [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 ~ safe_get_envvar("WEBDAVPASS", [INFO] [stdout] 90 + "WEBDAVPASS env var not set. [INFO] [stdout] 91 + Please make sure to set one. [INFO] [stdout] 92 ~ We currently do not support unsecured webdav servers.", true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/envfuncs.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | / return safe_get_envvar("WEBDAVADDR", [INFO] [stdout] 103 | | "WEBDAVPASS env var not set. [INFO] [stdout] 104 | | Please make sure to set one otherwise we don't know where to connect.", [INFO] [stdout] 105 | | true); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 ~ safe_get_envvar("WEBDAVADDR", [INFO] [stdout] 103 + "WEBDAVPASS env var not set. [INFO] [stdout] 104 + Please make sure to set one otherwise we don't know where to connect.", [INFO] [stdout] 105 ~ true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/envfuncs.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 115 | / return safe_get_envvar("CI_PROJECT_ID", [INFO] [stdout] 116 | | "Could not find CI_PROJECT_ID enviorement variable. [INFO] [stdout] 117 | | Please make sure that you are using a gilab server or set the value manually to a unique value.", [INFO] [stdout] 118 | | true); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 115 ~ safe_get_envvar("CI_PROJECT_ID", [INFO] [stdout] 116 + "Could not find CI_PROJECT_ID enviorement variable. [INFO] [stdout] 117 + Please make sure that you are using a gilab server or set the value manually to a unique value.", [INFO] [stdout] 118 ~ true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/envfuncs.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 128 | / return safe_get_envvar("CI_COMMIT_BRANCH", [INFO] [stdout] 129 | | "Could not find CI_COMMIT_BRANCH or CI_MERGE_REQUEST_TARGET_BRANCH_NAME enviorement variable. [INFO] [stdout] 130 | | Please make sure that you are using a gilab server or set the value manually to a unique value.", [INFO] [stdout] 131 | | true); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 128 ~ safe_get_envvar("CI_COMMIT_BRANCH", [INFO] [stdout] 129 + "Could not find CI_COMMIT_BRANCH or CI_MERGE_REQUEST_TARGET_BRANCH_NAME enviorement variable. [INFO] [stdout] 130 + Please make sure that you are using a gilab server or set the value manually to a unique value.", [INFO] [stdout] 131 ~ true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/envfuncs.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 152 | return format!("{}-{}.zip", ostype.to_string(), get_branch_name()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 - return format!("{}-{}.zip", ostype.to_string(), get_branch_name()); [INFO] [stdout] 152 + format!("{}-{}.zip", ostype.to_string(), get_branch_name()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/zip.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | /// want to recursively zip all files and subdirectories. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 76 | /// want to recursively zip all files and subdirectories. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/zip.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | /// directory will be created. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 78 | /// directory will be created. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/zip.rs:80:5 [INFO] [stdout] | [INFO] [stdout] 80 | /// zip file. The [`zip::CompressionMethod`] enum provides different compression methods such as `Stored`, `Deflated, `Bzip2`, etc. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 80 | /// zip file. The [`zip::CompressionMethod`] enum provides different compression methods such as `Stored`, `Deflated, `Bzip2`, etc. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/zip.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | /// stripped from the file paths before adding them to the zip archive. This is useful when you want to [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 18 | /// stripped from the file paths before adding them to the zip archive. This is useful when you want to [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/zip.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | /// create a zip archive that contains files from a specific directory, but you don't want the directory [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 19 | /// create a zip archive that contains files from a specific directory, but you don't want the directory [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/zip.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 108 | /// that you want to unzip. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 108 | /// that you want to unzip. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/zip.rs:123:8 [INFO] [stdout] | [INFO] [stdout] 123 | if !fs::metadata(file_pathbuf.clone()).is_ok(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(file_pathbuf.clone()).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/zip.rs:168:5 [INFO] [stdout] | [INFO] [stdout] 168 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 168 - return Ok(()); [INFO] [stdout] 168 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/zip.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | /// structure to be included in [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 20 | /// structure to be included in [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/zip.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | /// It represents the output stream where the zip file will be written to. It could be any type [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 22 | /// It represents the output stream where the zip file will be written to. It could be any type [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/zip.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | /// that implements these traits, such as a [`File`] or a [`TcpStream`]. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 23 | /// that implements these traits, such as a [`File`] or a [`TcpStream`]. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/zip.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | /// compression method to be used when creating the zip file. The [`zip::CompressionMethod`] enum provides [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 25 | /// compression method to be used when creating the zip file. The [`zip::CompressionMethod`] enum provides [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/zip.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | /// different compression methods such as `Stored`, `Deflated`, `Bzip2`, etc. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 26 | /// different compression methods such as `Stored`, `Deflated`, `Bzip2`, etc. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/zip.rs:141:44 [INFO] [stdout] | [INFO] [stdout] 141 | Some(path) => parent_path.join(path.to_owned()), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/helpers.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | /// can be any type that can be converted to a [`Path`], such as a [`String`] or [`&str`]. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 13 | /// can be any type that can be converted to a [`Path`], such as a [`String`] or [`&str`]. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/zip.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | /// want to recursively zip all files and subdirectories. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 76 | /// want to recursively zip all files and subdirectories. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/zip.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | /// directory will be created. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 78 | /// directory will be created. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/zip.rs:80:5 [INFO] [stdout] | [INFO] [stdout] 80 | /// zip file. The [`zip::CompressionMethod`] enum provides different compression methods such as `Stored`, `Deflated, `Bzip2`, etc. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 80 | /// zip file. The [`zip::CompressionMethod`] enum provides different compression methods such as `Stored`, `Deflated, `Bzip2`, etc. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/zip.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 108 | /// that you want to unzip. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 108 | /// that you want to unzip. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/helpers.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | /// copied to. It should implement the [`AsRef`] trait, which means it can be any type that can be [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 15 | /// copied to. It should implement the [`AsRef`] trait, which means it can be any type that can be [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/helpers.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | /// converted to a [`Path`] reference. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 16 | /// converted to a [`Path`] reference. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/zip.rs:123:8 [INFO] [stdout] | [INFO] [stdout] 123 | if !fs::metadata(file_pathbuf.clone()).is_ok(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(file_pathbuf.clone()).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/zip.rs:168:5 [INFO] [stdout] | [INFO] [stdout] 168 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 168 - return Ok(()); [INFO] [stdout] 168 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/zip.rs:141:44 [INFO] [stdout] | [INFO] [stdout] 141 | Some(path) => parent_path.join(path.to_owned()), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helpers.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return Ok(()); [INFO] [stdout] 53 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helpers.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return Ok(()); [INFO] [stdout] 83 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/helpers.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | /// can be any type that can be converted to a [`Path`], such as a [`String`] or [`&str`]. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 13 | /// can be any type that can be converted to a [`Path`], such as a [`String`] or [`&str`]. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/helpers.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | /// copied to. It should implement the [`AsRef`] trait, which means it can be any type that can be [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 15 | /// copied to. It should implement the [`AsRef`] trait, which means it can be any type that can be [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/helpers.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | /// converted to a [`Path`] reference. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 16 | /// converted to a [`Path`] reference. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `upload_res` after checking its variant with `is_err` [INFO] [stdout] --> src/main.rs:72:27 [INFO] [stdout] | [INFO] [stdout] 69 | if upload_res.is_err(){ [INFO] [stdout] | ---------------------- help: try: `if let Err() = upload_res` [INFO] [stdout] ... [INFO] [stdout] 72 | process::exit(upload_res.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `upload_res` after checking its variant with `is_err` [INFO] [stdout] --> src/main.rs:105:27 [INFO] [stdout] | [INFO] [stdout] 101 | if upload_res.is_err(){ [INFO] [stdout] | ---------------------- help: try: `if let Err() = upload_res` [INFO] [stdout] ... [INFO] [stdout] 105 | process::exit(upload_res.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `upload_res` after checking its variant with `is_err` [INFO] [stdout] --> src/main.rs:118:27 [INFO] [stdout] | [INFO] [stdout] 114 | if upload_res.is_err(){ [INFO] [stdout] | ---------------------- help: try: `if let Err() = upload_res` [INFO] [stdout] ... [INFO] [stdout] 118 | process::exit(upload_res.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:26:30 [INFO] [stdout] | [INFO] [stdout] 26 | if launch_args.contains(&format!("/help")) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"/help".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helpers.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return Ok(()); [INFO] [stdout] 53 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helpers.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return Ok(()); [INFO] [stdout] 83 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `upload_res` after checking its variant with `is_err` [INFO] [stdout] --> src/main.rs:72:27 [INFO] [stdout] | [INFO] [stdout] 69 | if upload_res.is_err(){ [INFO] [stdout] | ---------------------- help: try: `if let Err() = upload_res` [INFO] [stdout] ... [INFO] [stdout] 72 | process::exit(upload_res.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `upload_res` after checking its variant with `is_err` [INFO] [stdout] --> src/main.rs:105:27 [INFO] [stdout] | [INFO] [stdout] 101 | if upload_res.is_err(){ [INFO] [stdout] | ---------------------- help: try: `if let Err() = upload_res` [INFO] [stdout] ... [INFO] [stdout] 105 | process::exit(upload_res.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `upload_res` after checking its variant with `is_err` [INFO] [stdout] --> src/main.rs:118:27 [INFO] [stdout] | [INFO] [stdout] 114 | if upload_res.is_err(){ [INFO] [stdout] | ---------------------- help: try: `if let Err() = upload_res` [INFO] [stdout] ... [INFO] [stdout] 118 | process::exit(upload_res.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:60:30 [INFO] [stdout] | [INFO] [stdout] 60 | if launch_args.contains(&format!("/backup")) && (launch_args.contains(&format!("download")) ||launch_args.contains(&format!("res... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"/backup".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:60:76 [INFO] [stdout] | [INFO] [stdout] 60 | ... (launch_args.contains(&format!("download")) ||launch_args.contains(&format!("restore"))){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"download".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:60:121 [INFO] [stdout] | [INFO] [stdout] 60 | ... ||launch_args.contains(&format!("restore"))){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"restore".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:66:30 [INFO] [stdout] | [INFO] [stdout] 66 | if launch_args.contains(&format!("/download")){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"/download".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:76:30 [INFO] [stdout] | [INFO] [stdout] 76 | if launch_args.contains(&format!("/rmlocalcache")){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"/rmlocalcache".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:87:30 [INFO] [stdout] | [INFO] [stdout] 87 | if launch_args.contains(&format!("/rmremcache")){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"/rmremcache".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:98:30 [INFO] [stdout] | [INFO] [stdout] 98 | if launch_args.contains(&format!("/backup")){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"/backup".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:111:30 [INFO] [stdout] | [INFO] [stdout] 111 | if launch_args.contains(&format!("/restore")){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"/restore".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:26:30 [INFO] [stdout] | [INFO] [stdout] 26 | if launch_args.contains(&format!("/help")) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"/help".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:60:30 [INFO] [stdout] | [INFO] [stdout] 60 | if launch_args.contains(&format!("/backup")) && (launch_args.contains(&format!("download")) ||launch_args.contains(&format!("res... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"/backup".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:60:76 [INFO] [stdout] | [INFO] [stdout] 60 | ... (launch_args.contains(&format!("download")) ||launch_args.contains(&format!("restore"))){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"download".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:60:121 [INFO] [stdout] | [INFO] [stdout] 60 | ... ||launch_args.contains(&format!("restore"))){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"restore".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:66:30 [INFO] [stdout] | [INFO] [stdout] 66 | if launch_args.contains(&format!("/download")){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"/download".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:76:30 [INFO] [stdout] | [INFO] [stdout] 76 | if launch_args.contains(&format!("/rmlocalcache")){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"/rmlocalcache".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:87:30 [INFO] [stdout] | [INFO] [stdout] 87 | if launch_args.contains(&format!("/rmremcache")){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"/rmremcache".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:98:30 [INFO] [stdout] | [INFO] [stdout] 98 | if launch_args.contains(&format!("/backup")){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"/backup".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:111:30 [INFO] [stdout] | [INFO] [stdout] 111 | if launch_args.contains(&format!("/restore")){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"/restore".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 39.79s [INFO] running `Command { std: "docker" "inspect" "e051f1202a15086a476d8073c82c147e8d0afdbadcdce54d3d00001b7ac54df9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e051f1202a15086a476d8073c82c147e8d0afdbadcdce54d3d00001b7ac54df9", kill_on_drop: false }` [INFO] [stdout] e051f1202a15086a476d8073c82c147e8d0afdbadcdce54d3d00001b7ac54df9