[INFO] cloning repository https://github.com/DavideR95/Temporal-Adaptive-K-Cores [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DavideR95/Temporal-Adaptive-K-Cores" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDavideR95%2FTemporal-Adaptive-K-Cores", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDavideR95%2FTemporal-Adaptive-K-Cores'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ab99a3f97e0c72395d01b778026cf0a77d7fc60e [INFO] linting DavideR95/Temporal-Adaptive-K-Cores against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDavideR95%2FTemporal-Adaptive-K-Cores" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/DavideR95/Temporal-Adaptive-K-Cores [INFO] finished tweaking git repo https://github.com/DavideR95/Temporal-Adaptive-K-Cores [INFO] tweaked toml for git repo https://github.com/DavideR95/Temporal-Adaptive-K-Cores written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/DavideR95/Temporal-Adaptive-K-Cores on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/DavideR95/Temporal-Adaptive-K-Cores already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded meval v0.2.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 73902a24c361141343ceb1a7553175f884456bbf02fe974482bec2478f11d863 [INFO] running `Command { std: "docker" "start" "-a" "73902a24c361141343ceb1a7553175f884456bbf02fe974482bec2478f11d863", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "73902a24c361141343ceb1a7553175f884456bbf02fe974482bec2478f11d863", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "73902a24c361141343ceb1a7553175f884456bbf02fe974482bec2478f11d863", kill_on_drop: false }` [INFO] [stdout] 73902a24c361141343ceb1a7553175f884456bbf02fe974482bec2478f11d863 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d40df5de4495881a798d84aa09b6c7339fcd297e9a6ae78256ff6211cf923aa3 [INFO] running `Command { std: "docker" "start" "-a" "d40df5de4495881a798d84aa09b6c7339fcd297e9a6ae78256ff6211cf923aa3", kill_on_drop: false }` [INFO] [stderr] Compiling nix v0.31.1 [INFO] [stderr] Checking nom v1.2.4 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking meval v0.2.0 [INFO] [stderr] Checking temporal-adaptive-k-cores v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/temporal_node.rs:15:29 [INFO] [stdout] | [INFO] [stdout] 15 | pub static NODES_TO_CHECK: &'static [usize] = &[]; //&[3333, 6765]; // &[816, 3602, 6327]; [INFO] [stdout] | -^^^^^^^-------- help: consider removing `'static`: `&[usize]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/temporal_node.rs:15:29 [INFO] [stdout] | [INFO] [stdout] 15 | pub static NODES_TO_CHECK: &'static [usize] = &[]; //&[3333, 6765]; // &[816, 3602, 6327]; [INFO] [stdout] | -^^^^^^^-------- help: consider removing `'static`: `&[usize]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/temporal_graph.rs:32:6 [INFO] [stdout] | [INFO] [stdout] 32 | impl<'a, T> TemporalGraph [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/temporal_graph.rs:208:17 [INFO] [stdout] | [INFO] [stdout] 208 | / if node.has_changed_backup() { [INFO] [stdout] 209 | | if let Some(cness) = node.send_coreness_backup() { [INFO] [stdout] 210 | | self.msg_mgr.take_broadcast_message(Some(Message::new( [INFO] [stdout] 211 | | node.id_index().unwrap(), [INFO] [stdout] ... | [INFO] [stdout] 217 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 208 ~ if node.has_changed_backup() [INFO] [stdout] 209 ~ && let Some(cness) = node.send_coreness_backup() { [INFO] [stdout] 210 | self.msg_mgr.take_broadcast_message(Some(Message::new( [INFO] [stdout] ... [INFO] [stdout] 215 | } [INFO] [stdout] 216 ~ // println!("Il nodo cambiato è: {:?}", node.id().unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/temporal_node.rs:112:49 [INFO] [stdout] | [INFO] [stdout] 112 | self.estimate.values_mut().for_each(|e| (*e).0 = usize::MAX); [INFO] [stdout] | ^^^^ help: try: `e` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/temporal_node.rs:356:20 [INFO] [stdout] | [INFO] [stdout] 356 | if cness <= est.0 || (cness > est.0 && est.1 < self.time) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 356 - if cness <= est.0 || (cness > est.0 && est.1 < self.time) { [INFO] [stdout] 356 + if !(cness > est.0 && est.1 >= self.time) { [INFO] [stdout] | [INFO] [stdout] 356 - if cness <= est.0 || (cness > est.0 && est.1 < self.time) { [INFO] [stdout] 356 + if cness <= est.0 || est.1 < self.time { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 115 | let memory_size: usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `memory_size` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 115 ~ [INFO] [stdout] 116 | [INFO] [stdout] 117 ~ let memory_size: usize = if args.len() >= 5 { [INFO] [stdout] 118 ~ eval_str(&args[4])? as usize [INFO] [stdout] 119 | } else { [INFO] [stdout] 120 ~ 5 [INFO] [stdout] 121 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `fn(&BitVec) -> bool` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:128:44 [INFO] [stdout] | [INFO] [stdout] 128 | temporal_graph::TemporalGraph::new(aggr_f.clone(), memory_size); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `aggr_f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/temporal_graph.rs:32:6 [INFO] [stdout] | [INFO] [stdout] 32 | impl<'a, T> TemporalGraph [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/temporal_graph.rs:208:17 [INFO] [stdout] | [INFO] [stdout] 208 | / if node.has_changed_backup() { [INFO] [stdout] 209 | | if let Some(cness) = node.send_coreness_backup() { [INFO] [stdout] 210 | | self.msg_mgr.take_broadcast_message(Some(Message::new( [INFO] [stdout] 211 | | node.id_index().unwrap(), [INFO] [stdout] ... | [INFO] [stdout] 217 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 208 ~ if node.has_changed_backup() [INFO] [stdout] 209 ~ && let Some(cness) = node.send_coreness_backup() { [INFO] [stdout] 210 | self.msg_mgr.take_broadcast_message(Some(Message::new( [INFO] [stdout] ... [INFO] [stdout] 215 | } [INFO] [stdout] 216 ~ // println!("Il nodo cambiato è: {:?}", node.id().unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/temporal_node.rs:112:49 [INFO] [stdout] | [INFO] [stdout] 112 | self.estimate.values_mut().for_each(|e| (*e).0 = usize::MAX); [INFO] [stdout] | ^^^^ help: try: `e` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/temporal_node.rs:356:20 [INFO] [stdout] | [INFO] [stdout] 356 | if cness <= est.0 || (cness > est.0 && est.1 < self.time) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 356 - if cness <= est.0 || (cness > est.0 && est.1 < self.time) { [INFO] [stdout] 356 + if !(cness > est.0 && est.1 >= self.time) { [INFO] [stdout] | [INFO] [stdout] 356 - if cness <= est.0 || (cness > est.0 && est.1 < self.time) { [INFO] [stdout] 356 + if cness <= est.0 || est.1 < self.time { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 115 | let memory_size: usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `memory_size` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 115 ~ [INFO] [stdout] 116 | [INFO] [stdout] 117 ~ let memory_size: usize = if args.len() >= 5 { [INFO] [stdout] 118 ~ eval_str(&args[4])? as usize [INFO] [stdout] 119 | } else { [INFO] [stdout] 120 ~ 5 [INFO] [stdout] 121 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `fn(&BitVec) -> bool` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:128:44 [INFO] [stdout] | [INFO] [stdout] 128 | temporal_graph::TemporalGraph::new(aggr_f.clone(), memory_size); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `aggr_f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.26s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: nom v1.2.4 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 4` [INFO] running `Command { std: "docker" "inspect" "d40df5de4495881a798d84aa09b6c7339fcd297e9a6ae78256ff6211cf923aa3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d40df5de4495881a798d84aa09b6c7339fcd297e9a6ae78256ff6211cf923aa3", kill_on_drop: false }` [INFO] [stdout] d40df5de4495881a798d84aa09b6c7339fcd297e9a6ae78256ff6211cf923aa3