[INFO] cloning repository https://github.com/DavidAGullo/rust-basics [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DavidAGullo/rust-basics" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDavidAGullo%2Frust-basics", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDavidAGullo%2Frust-basics'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b7c6722f3e5d0b2751563e546d3720656deecb4b [INFO] linting DavidAGullo/rust-basics against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDavidAGullo%2Frust-basics" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/DavidAGullo/rust-basics [INFO] finished tweaking git repo https://github.com/DavidAGullo/rust-basics [INFO] tweaked toml for git repo https://github.com/DavidAGullo/rust-basics written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/DavidAGullo/rust-basics on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/DavidAGullo/rust-basics already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6145b774ca861e8da1e6fd13aee9f1260f70b950623bf0401e2fa5a8b51d026a [INFO] running `Command { std: "docker" "start" "-a" "6145b774ca861e8da1e6fd13aee9f1260f70b950623bf0401e2fa5a8b51d026a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6145b774ca861e8da1e6fd13aee9f1260f70b950623bf0401e2fa5a8b51d026a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6145b774ca861e8da1e6fd13aee9f1260f70b950623bf0401e2fa5a8b51d026a", kill_on_drop: false }` [INFO] [stdout] 6145b774ca861e8da1e6fd13aee9f1260f70b950623bf0401e2fa5a8b51d026a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 407c23ca4e29f8414f36f288e58ac630f77757f825fe15683df91fdf465c159c [INFO] running `Command { std: "docker" "start" "-a" "407c23ca4e29f8414f36f288e58ac630f77757f825fe15683df91fdf465c159c", kill_on_drop: false }` [INFO] [stderr] Checking rust-basics v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `name` [INFO] [stdout] --> src/main.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | let name :&str = "John"; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_name` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `age` [INFO] [stdout] --> src/main.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | let age :i32 = 43; [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_age` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `weight` [INFO] [stdout] --> src/main.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | let weight = 180.5; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_weight` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `is_male` [INFO] [stdout] --> src/main.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | let is_male = true; [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_is_male` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `is_tall` [INFO] [stdout] --> src/main.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | let is_tall = false; [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_is_tall` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | let mut owner = format!("{} is owned by {}", cow, "John"); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cow` [INFO] [stdout] --> src/main.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | let cow: String = String::new(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_cow` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/main.rs:152:10 [INFO] [stdout] | [INFO] [stdout] 152 | let (x, y, z) = tup; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `z` [INFO] [stdout] --> src/main.rs:152:16 [INFO] [stdout] | [INFO] [stdout] 152 | let (x, y, z) = tup; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_z` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:130:13 [INFO] [stdout] | [INFO] [stdout] 130 | let m = true && false; // Logical AND operator true && false = false [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:131:13 [INFO] [stdout] | [INFO] [stdout] 131 | let n = true || false; // Logical OR operator true || false = true [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:132:13 [INFO] [stdout] | [INFO] [stdout] 132 | let o = !true; // Logical NOT operator !true = false [INFO] [stdout] | ^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name` [INFO] [stdout] --> src/main.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | let name :&str = "John"; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_name` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `age` [INFO] [stdout] --> src/main.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | let age :i32 = 43; [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_age` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `weight` [INFO] [stdout] --> src/main.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | let weight = 180.5; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_weight` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `is_male` [INFO] [stdout] --> src/main.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | let is_male = true; [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_is_male` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `is_tall` [INFO] [stdout] --> src/main.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | let is_tall = false; [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_is_tall` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | let mut owner = format!("{} is owned by {}", cow, "John"); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cow` [INFO] [stdout] --> src/main.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | let cow: String = String::new(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_cow` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/main.rs:152:10 [INFO] [stdout] | [INFO] [stdout] 152 | let (x, y, z) = tup; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `z` [INFO] [stdout] --> src/main.rs:152:16 [INFO] [stdout] | [INFO] [stdout] 152 | let (x, y, z) = tup; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_z` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:130:13 [INFO] [stdout] | [INFO] [stdout] 130 | let m = true && false; // Logical AND operator true && false = false [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:131:13 [INFO] [stdout] | [INFO] [stdout] 131 | let n = true || false; // Logical OR operator true || false = true [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:132:13 [INFO] [stdout] | [INFO] [stdout] 132 | let o = !true; // Logical NOT operator !true = false [INFO] [stdout] | ^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.13s [INFO] running `Command { std: "docker" "inspect" "407c23ca4e29f8414f36f288e58ac630f77757f825fe15683df91fdf465c159c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "407c23ca4e29f8414f36f288e58ac630f77757f825fe15683df91fdf465c159c", kill_on_drop: false }` [INFO] [stdout] 407c23ca4e29f8414f36f288e58ac630f77757f825fe15683df91fdf465c159c