[INFO] cloning repository https://github.com/David1704-1/dumb-asm-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/David1704-1/dumb-asm-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDavid1704-1%2Fdumb-asm-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDavid1704-1%2Fdumb-asm-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 41b9b61cbe0ae7a2cb10e3661af7bf41ee430a5c [INFO] linting David1704-1/dumb-asm-rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDavid1704-1%2Fdumb-asm-rust" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/David1704-1/dumb-asm-rust [INFO] finished tweaking git repo https://github.com/David1704-1/dumb-asm-rust [INFO] tweaked toml for git repo https://github.com/David1704-1/dumb-asm-rust written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/David1704-1/dumb-asm-rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/David1704-1/dumb-asm-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 31f70ff3744b148e0f56d811264053f2fea66b6820b2a85e37862f7da39e17e5 [INFO] running `Command { std: "docker" "start" "-a" "31f70ff3744b148e0f56d811264053f2fea66b6820b2a85e37862f7da39e17e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "31f70ff3744b148e0f56d811264053f2fea66b6820b2a85e37862f7da39e17e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "31f70ff3744b148e0f56d811264053f2fea66b6820b2a85e37862f7da39e17e5", kill_on_drop: false }` [INFO] [stdout] 31f70ff3744b148e0f56d811264053f2fea66b6820b2a85e37862f7da39e17e5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 51f5e006698ee3efa0b0a5ec8e9a37d34b526a5db47490845daae937ffdccff6 [INFO] running `Command { std: "docker" "start" "-a" "51f5e006698ee3efa0b0a5ec8e9a37d34b526a5db47490845daae937ffdccff6", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling serde v1.0.202 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling axum-core v0.4.3 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling axum v0.7.5 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.64 [INFO] [stderr] Compiling serde_derive v1.0.202 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking hyper v1.3.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_path_to_error v0.1.16 [INFO] [stderr] Checking asm-simulator v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: name `CPU` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:9:12 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct CPU { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/cpu.rs:47:40 [INFO] [stdout] | [INFO] [stdout] 47 | memory.values.push(instruction_value.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `instruction_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/cpu.rs:61:35 [INFO] [stdout] | [INFO] [stdout] 61 | let tmp = self.accumulator.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.accumulator` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:97:21 [INFO] [stdout] | [INFO] [stdout] 97 | self.accumulator = self.accumulator & instruction_value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.accumulator &= instruction_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:100:21 [INFO] [stdout] | [INFO] [stdout] 100 | self.accumulator = self.accumulator | instruction_value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.accumulator |= instruction_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:103:21 [INFO] [stdout] | [INFO] [stdout] 103 | self.accumulator = self.accumulator ^ instruction_value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.accumulator ^= instruction_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:106:21 [INFO] [stdout] | [INFO] [stdout] 106 | self.accumulator = self.accumulator << instruction_value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.accumulator <<= instruction_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:109:21 [INFO] [stdout] | [INFO] [stdout] 109 | self.accumulator = self.accumulator >> instruction_value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.accumulator >>= instruction_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LOAD` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | LOAD, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Load` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ADD` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | ADD, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Add` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STORE` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | STORE, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Store` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PUT` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | PUT, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Put` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `END` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | END, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `End` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SUB` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | SUB, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MUL` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | MUL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Mul` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DIV` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | DIV, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Div` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JMP` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | JMP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jmp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JMPF` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | JMPF, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Jmpf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JMPB` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | JMPB, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Jmpb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NEQ` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | NEQ, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Neq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JEQ` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | JEQ, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jeq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JNEQ` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | JNEQ, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Jneq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INV` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | INV, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AND` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | AND, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `And` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `XOR` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | XOR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Xor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LSHIFT` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | LSHIFT, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Lshift` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RSHIFT` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | RSHIFT, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Rshift` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | / return Operation { [INFO] [stdout] 11 | | operation: (Instruction::from(split[0]), value), [INFO] [stdout] 12 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 ~ Operation { [INFO] [stdout] 11 + operation: (Instruction::from(split[0]), value), [INFO] [stdout] 12 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/route_handlers.rs:32:60 [INFO] [stdout] | [INFO] [stdout] 32 | while cpu.program_counter < memory.operations.len() || !cpu.instruction_register.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cpu.instruction_register.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPU` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:9:12 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct CPU { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/cpu.rs:47:40 [INFO] [stdout] | [INFO] [stdout] 47 | memory.values.push(instruction_value.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `instruction_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/cpu.rs:61:35 [INFO] [stdout] | [INFO] [stdout] 61 | let tmp = self.accumulator.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.accumulator` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:97:21 [INFO] [stdout] | [INFO] [stdout] 97 | self.accumulator = self.accumulator & instruction_value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.accumulator &= instruction_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:100:21 [INFO] [stdout] | [INFO] [stdout] 100 | self.accumulator = self.accumulator | instruction_value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.accumulator |= instruction_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:103:21 [INFO] [stdout] | [INFO] [stdout] 103 | self.accumulator = self.accumulator ^ instruction_value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.accumulator ^= instruction_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:106:21 [INFO] [stdout] | [INFO] [stdout] 106 | self.accumulator = self.accumulator << instruction_value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.accumulator <<= instruction_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:109:21 [INFO] [stdout] | [INFO] [stdout] 109 | self.accumulator = self.accumulator >> instruction_value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.accumulator >>= instruction_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LOAD` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | LOAD, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Load` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ADD` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | ADD, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Add` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STORE` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | STORE, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Store` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PUT` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | PUT, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Put` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `END` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | END, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `End` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SUB` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | SUB, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MUL` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | MUL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Mul` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DIV` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | DIV, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Div` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JMP` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | JMP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jmp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JMPF` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | JMPF, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Jmpf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JMPB` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | JMPB, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Jmpb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NEQ` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | NEQ, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Neq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JEQ` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | JEQ, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jeq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JNEQ` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | JNEQ, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Jneq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INV` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | INV, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AND` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | AND, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `And` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `XOR` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | XOR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Xor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LSHIFT` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | LSHIFT, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Lshift` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RSHIFT` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | RSHIFT, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Rshift` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | / return Operation { [INFO] [stdout] 11 | | operation: (Instruction::from(split[0]), value), [INFO] [stdout] 12 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 ~ Operation { [INFO] [stdout] 11 + operation: (Instruction::from(split[0]), value), [INFO] [stdout] 12 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/route_handlers.rs:32:60 [INFO] [stdout] | [INFO] [stdout] 32 | while cpu.program_counter < memory.operations.len() || !cpu.instruction_register.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cpu.instruction_register.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 27.28s [INFO] running `Command { std: "docker" "inspect" "51f5e006698ee3efa0b0a5ec8e9a37d34b526a5db47490845daae937ffdccff6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "51f5e006698ee3efa0b0a5ec8e9a37d34b526a5db47490845daae937ffdccff6", kill_on_drop: false }` [INFO] [stdout] 51f5e006698ee3efa0b0a5ec8e9a37d34b526a5db47490845daae937ffdccff6