[INFO] cloning repository https://github.com/DaanHoogland/tr [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DaanHoogland/tr" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDaanHoogland%2Ftr", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDaanHoogland%2Ftr'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ef036497a42a42e18e3d22b79b053e9643dd419d [INFO] linting DaanHoogland/tr against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDaanHoogland%2Ftr" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/DaanHoogland/tr [INFO] finished tweaking git repo https://github.com/DaanHoogland/tr [INFO] tweaked toml for git repo https://github.com/DaanHoogland/tr written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/DaanHoogland/tr on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/DaanHoogland/tr already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded strsim v0.4.0 [INFO] [stderr] Downloaded ansi_term v0.6.3 [INFO] [stderr] Downloaded clap v1.2.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6a501b75c58f6a0998fef05ca87e6cff9fc326fd548921f8eb912c1d8944b7e0 [INFO] running `Command { std: "docker" "start" "-a" "6a501b75c58f6a0998fef05ca87e6cff9fc326fd548921f8eb912c1d8944b7e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6a501b75c58f6a0998fef05ca87e6cff9fc326fd548921f8eb912c1d8944b7e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6a501b75c58f6a0998fef05ca87e6cff9fc326fd548921f8eb912c1d8944b7e0", kill_on_drop: false }` [INFO] [stdout] 6a501b75c58f6a0998fef05ca87e6cff9fc326fd548921f8eb912c1d8944b7e0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2e0ab04b01423f9d0bff6f8539f81c80462c272279345fea3ec33fc73df33099 [INFO] running `Command { std: "docker" "start" "-a" "2e0ab04b01423f9d0bff6f8539f81c80462c272279345fea3ec33fc73df33099", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking ansi_term v0.6.3 [INFO] [stderr] Checking strsim v0.4.0 [INFO] [stderr] Checking clap v1.2.1 [INFO] [stderr] Checking tr v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:6:18 [INFO] [stdout] | [INFO] [stdout] 6 | const MAN_PAGE: &'static str = /* @MANSTART{tr} */ r#"NAME [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:6:18 [INFO] [stdout] | [INFO] [stdout] 6 | const MAN_PAGE: &'static str = /* @MANSTART{tr} */ r#"NAME [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `MAN_PAGE` is never used [INFO] [stdout] --> src/main.rs:6:7 [INFO] [stdout] | [INFO] [stdout] 6 | const MAN_PAGE: &'static str = /* @MANSTART{tr} */ r#"NAME [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `complement`, `delete`, and `squeeze` are never read [INFO] [stdout] --> src/main.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 51 | struct Translation { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 52 | complement: bool, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 53 | delete: bool, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 54 | squeeze: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `print_opts`, `get_opts`, and `check_opts` are never used [INFO] [stdout] --> src/main.rs:60:8 [INFO] [stdout] | [INFO] [stdout] 59 | impl Translation { [INFO] [stdout] | ---------------- methods in this implementation [INFO] [stdout] 60 | fn print_opts(&self) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 87 | fn get_opts(&mut self) -> &mut Translation { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 118 | fn check_opts(&mut self) -> &mut Translation { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:75:19 [INFO] [stdout] | [INFO] [stdout] 75 | while ! search.next().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `search.next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:76:20 [INFO] [stdout] | [INFO] [stdout] 76 | if ! nextkar.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `nextkar.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:119:45 [INFO] [stdout] | [INFO] [stdout] 119 | if !self.delete && !self.squeeze && self.replace.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.replace.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:75:19 [INFO] [stdout] | [INFO] [stdout] 75 | while ! search.next().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `search.next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:76:20 [INFO] [stdout] | [INFO] [stdout] 76 | if ! nextkar.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `nextkar.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:119:45 [INFO] [stdout] | [INFO] [stdout] 119 | if !self.delete && !self.squeeze && self.replace.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.replace.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.21s [INFO] running `Command { std: "docker" "inspect" "2e0ab04b01423f9d0bff6f8539f81c80462c272279345fea3ec33fc73df33099", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2e0ab04b01423f9d0bff6f8539f81c80462c272279345fea3ec33fc73df33099", kill_on_drop: false }` [INFO] [stdout] 2e0ab04b01423f9d0bff6f8539f81c80462c272279345fea3ec33fc73df33099