[INFO] cloning repository https://github.com/DaQueenJodi/Rust-Mon [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DaQueenJodi/Rust-Mon" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDaQueenJodi%2FRust-Mon", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDaQueenJodi%2FRust-Mon'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 64acdf9acacfc369469b5f0fc952d6633f8821a6 [INFO] linting DaQueenJodi/Rust-Mon against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDaQueenJodi%2FRust-Mon" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/DaQueenJodi/Rust-Mon [INFO] finished tweaking git repo https://github.com/DaQueenJodi/Rust-Mon [INFO] tweaked toml for git repo https://github.com/DaQueenJodi/Rust-Mon written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/DaQueenJodi/Rust-Mon on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/DaQueenJodi/Rust-Mon already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded int-enum-impl v0.4.0 [INFO] [stderr] Downloaded int-enum v0.4.0 [INFO] [stderr] Downloaded serde_json v1.0.78 [INFO] [stderr] Downloaded libc v0.2.117 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bf671c6e1a18e32f0303ee5232b1db2de38d949e447a9ec0b39e3e67e8406ded [INFO] running `Command { std: "docker" "start" "-a" "bf671c6e1a18e32f0303ee5232b1db2de38d949e447a9ec0b39e3e67e8406ded", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bf671c6e1a18e32f0303ee5232b1db2de38d949e447a9ec0b39e3e67e8406ded", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf671c6e1a18e32f0303ee5232b1db2de38d949e447a9ec0b39e3e67e8406ded", kill_on_drop: false }` [INFO] [stdout] bf671c6e1a18e32f0303ee5232b1db2de38d949e447a9ec0b39e3e67e8406ded [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 607d4f0ea7d8cbbcdd9697e1255cce5a1ad0fb88624b62bb0a8c727b7e93c39f [INFO] running `Command { std: "docker" "start" "-a" "607d4f0ea7d8cbbcdd9697e1255cce5a1ad0fb88624b62bb0a8c727b7e93c39f", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling libc v0.2.117 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling serde_json v1.0.78 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking getrandom v0.2.4 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Compiling toml v0.5.8 [INFO] [stderr] Compiling proc-macro-crate v0.1.5 [INFO] [stderr] Compiling int-enum-impl v0.4.0 [INFO] [stderr] Checking int-enum v0.4.0 [INFO] [stderr] Checking rust-mon v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/global.rs:6:69 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, PartialEq, Eq, Clone, Copy, Serialize, Deserialize, IntEnum)] [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `IntEnum` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `IntEnum` may come from an old version of the `int_enum_impl` crate, try updating your dependency with `cargo update -p int_enum_impl` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `IntEnum` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/global.rs:14:45 [INFO] [stdout] | [INFO] [stdout] 14 | #[derive(Copy, Debug, PartialEq, Eq, Clone, IntEnum, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `IntEnum` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `IntEnum` may come from an old version of the `int_enum_impl` crate, try updating your dependency with `cargo update -p int_enum_impl` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `IntEnum` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/global.rs:6:69 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, PartialEq, Eq, Clone, Copy, Serialize, Deserialize, IntEnum)] [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `IntEnum` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `IntEnum` may come from an old version of the `int_enum_impl` crate, try updating your dependency with `cargo update -p int_enum_impl` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `IntEnum` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/global.rs:14:45 [INFO] [stdout] | [INFO] [stdout] 14 | #[derive(Copy, Debug, PartialEq, Eq, Clone, IntEnum, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `IntEnum` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `IntEnum` may come from an old version of the `int_enum_impl` crate, try updating your dependency with `cargo update -p int_enum_impl` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `IntEnum` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `IntEnumError` [INFO] [stdout] --> src/item.rs:3:25 [INFO] [stdout] | [INFO] [stdout] 3 | use int_enum::{IntEnum, IntEnumError}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `IntEnumError` [INFO] [stdout] --> src/item.rs:3:25 [INFO] [stdout] | [INFO] [stdout] 3 | use int_enum::{IntEnum, IntEnumError}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `error::Error` [INFO] [stdout] --> src/main.rs:14:11 [INFO] [stdout] | [INFO] [stdout] 14 | use std::{error::Error, fmt}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `error::Error` [INFO] [stdout] --> src/main.rs:14:11 [INFO] [stdout] | [INFO] [stdout] 14 | use std::{error::Error, fmt}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | return Err(format!("Mon named {} was not found in json file", name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return Err(format!("Mon named {} was not found in json file", name)); [INFO] [stdout] 27 + Err(format!("Mon named {} was not found in json file", name)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | return Err(format!("Move named {} was not found in json file", name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return Err(format!("Move named {} was not found in json file", name)); [INFO] [stdout] 37 + Err(format!("Move named {} was not found in json file", name)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Game` [INFO] [stdout] --> src/game.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | / pub fn new() -> Game { [INFO] [stdout] 99 | | Game { [INFO] [stdout] 100 | | player_mon: Mon::new(), [INFO] [stdout] 101 | | enemy_mon: Mon::new(), [INFO] [stdout] ... | [INFO] [stdout] 109 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 48 + impl Default for Game { [INFO] [stdout] 49 + fn default() -> Self { [INFO] [stdout] 50 + Self::new() [INFO] [stdout] 51 + } [INFO] [stdout] 52 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game.rs:114:17 [INFO] [stdout] | [INFO] [stdout] 114 | assert!(!(num > self.bag.available_mons.len())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(num <= self.bag.available_mons.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | return Err(format!("Mon named {} was not found in json file", name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return Err(format!("Mon named {} was not found in json file", name)); [INFO] [stdout] 27 + Err(format!("Mon named {} was not found in json file", name)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | return Err(format!("Move named {} was not found in json file", name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return Err(format!("Move named {} was not found in json file", name)); [INFO] [stdout] 37 + Err(format!("Move named {} was not found in json file", name)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Game` [INFO] [stdout] --> src/game.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | / pub fn new() -> Game { [INFO] [stdout] 99 | | Game { [INFO] [stdout] 100 | | player_mon: Mon::new(), [INFO] [stdout] 101 | | enemy_mon: Mon::new(), [INFO] [stdout] ... | [INFO] [stdout] 109 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 48 + impl Default for Game { [INFO] [stdout] 49 + fn default() -> Self { [INFO] [stdout] 50 + Self::new() [INFO] [stdout] 51 + } [INFO] [stdout] 52 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Bag` [INFO] [stdout] --> src/item.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | / pub fn new() -> Bag { [INFO] [stdout] 74 | | Bag { [INFO] [stdout] 75 | | items: vec![], [INFO] [stdout] 76 | | available_mons: vec![Game::read_specific_mon("Balls".to_owned()).unwrap()], [INFO] [stdout] ... | [INFO] [stdout] 79 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 72 + impl Default for Bag { [INFO] [stdout] 73 + fn default() -> Self { [INFO] [stdout] 74 + Self::new() [INFO] [stdout] 75 + } [INFO] [stdout] 76 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game.rs:114:17 [INFO] [stdout] | [INFO] [stdout] 114 | assert!(!(num > self.bag.available_mons.len())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(num <= self.bag.available_mons.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Bag` [INFO] [stdout] --> src/item.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | / pub fn new() -> Bag { [INFO] [stdout] 74 | | Bag { [INFO] [stdout] 75 | | items: vec![], [INFO] [stdout] 76 | | available_mons: vec![Game::read_specific_mon("Balls".to_owned()).unwrap()], [INFO] [stdout] ... | [INFO] [stdout] 79 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 72 + impl Default for Bag { [INFO] [stdout] 73 + fn default() -> Self { [INFO] [stdout] 74 + Self::new() [INFO] [stdout] 75 + } [INFO] [stdout] 76 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Mon` [INFO] [stdout] --> src/mon.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 117 | / pub fn new() -> Mon { [INFO] [stdout] 118 | | Mon { [INFO] [stdout] 119 | | buffs: vec![], [INFO] [stdout] 120 | | debuffs: vec![], [INFO] [stdout] ... | [INFO] [stdout] 132 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 116 + impl Default for Mon { [INFO] [stdout] 117 + fn default() -> Self { [INFO] [stdout] 118 + Self::new() [INFO] [stdout] 119 + } [INFO] [stdout] 120 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mon.rs:153:12 [INFO] [stdout] | [INFO] [stdout] 153 | if !(move_name == "None".to_owned()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(move_name != "None".to_owned())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/mon.rs:153:27 [INFO] [stdout] | [INFO] [stdout] 153 | if !(move_name == "None".to_owned()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"None"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/global.rs:6:69 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, PartialEq, Eq, Clone, Copy, Serialize, Deserialize, IntEnum)] [INFO] [stdout] | ^------ [INFO] [stdout] | | [INFO] [stdout] | `IntEnum` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_IntEnum_FOR_Debuff` [INFO] [stdout] 7 | pub enum Debuff { [INFO] [stdout] | ------ `Debuff` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `IntEnum` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `IntEnum` may come from an old version of the `int_enum_impl` crate, try updating your dependency with `cargo update -p int_enum_impl` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `IntEnum` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/global.rs:14:45 [INFO] [stdout] | [INFO] [stdout] 14 | #[derive(Copy, Debug, PartialEq, Eq, Clone, IntEnum, Serialize, Deserialize)] [INFO] [stdout] | ^------ [INFO] [stdout] | | [INFO] [stdout] | `IntEnum` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_IntEnum_FOR_Buff` [INFO] [stdout] 15 | pub enum Buff { [INFO] [stdout] | ---- `Buff` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `IntEnum` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `IntEnum` may come from an old version of the `int_enum_impl` crate, try updating your dependency with `cargo update -p int_enum_impl` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `IntEnum` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Mon` [INFO] [stdout] --> src/mon.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 117 | / pub fn new() -> Mon { [INFO] [stdout] 118 | | Mon { [INFO] [stdout] 119 | | buffs: vec![], [INFO] [stdout] 120 | | debuffs: vec![], [INFO] [stdout] ... | [INFO] [stdout] 132 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 116 + impl Default for Mon { [INFO] [stdout] 117 + fn default() -> Self { [INFO] [stdout] 118 + Self::new() [INFO] [stdout] 119 + } [INFO] [stdout] 120 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mon.rs:153:12 [INFO] [stdout] | [INFO] [stdout] 153 | if !(move_name == "None".to_owned()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(move_name != "None".to_owned())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/mon.rs:153:27 [INFO] [stdout] | [INFO] [stdout] 153 | if !(move_name == "None".to_owned()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"None"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/global.rs:6:69 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, PartialEq, Eq, Clone, Copy, Serialize, Deserialize, IntEnum)] [INFO] [stdout] | ^------ [INFO] [stdout] | | [INFO] [stdout] | `IntEnum` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_IntEnum_FOR_Debuff` [INFO] [stdout] 7 | pub enum Debuff { [INFO] [stdout] | ------ `Debuff` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `IntEnum` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `IntEnum` may come from an old version of the `int_enum_impl` crate, try updating your dependency with `cargo update -p int_enum_impl` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `IntEnum` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/global.rs:14:45 [INFO] [stdout] | [INFO] [stdout] 14 | #[derive(Copy, Debug, PartialEq, Eq, Clone, IntEnum, Serialize, Deserialize)] [INFO] [stdout] | ^------ [INFO] [stdout] | | [INFO] [stdout] | `IntEnum` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_IntEnum_FOR_Buff` [INFO] [stdout] 15 | pub enum Buff { [INFO] [stdout] | ---- `Buff` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `IntEnum` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `IntEnum` may come from an old version of the `int_enum_impl` crate, try updating your dependency with `cargo update -p int_enum_impl` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `IntEnum` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.78s [INFO] running `Command { std: "docker" "inspect" "607d4f0ea7d8cbbcdd9697e1255cce5a1ad0fb88624b62bb0a8c727b7e93c39f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "607d4f0ea7d8cbbcdd9697e1255cce5a1ad0fb88624b62bb0a8c727b7e93c39f", kill_on_drop: false }` [INFO] [stdout] 607d4f0ea7d8cbbcdd9697e1255cce5a1ad0fb88624b62bb0a8c727b7e93c39f