[INFO] cloning repository https://github.com/Da-Real-Kryall/aoc2022 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Da-Real-Kryall/aoc2022" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDa-Real-Kryall%2Faoc2022", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDa-Real-Kryall%2Faoc2022'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 224e7f9ae7e68607cc152d0c745d2c91f729f3b4 [INFO] linting Da-Real-Kryall/aoc2022 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDa-Real-Kryall%2Faoc2022" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Da-Real-Kryall/aoc2022 [INFO] finished tweaking git repo https://github.com/Da-Real-Kryall/aoc2022 [INFO] tweaked toml for git repo https://github.com/Da-Real-Kryall/aoc2022 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Da-Real-Kryall/aoc2022 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Da-Real-Kryall/aoc2022 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c8bc79490e7d7566c0278791a1495dcfa5c9c3f1af651f0340faaf606d62a23d [INFO] running `Command { std: "docker" "start" "-a" "c8bc79490e7d7566c0278791a1495dcfa5c9c3f1af651f0340faaf606d62a23d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c8bc79490e7d7566c0278791a1495dcfa5c9c3f1af651f0340faaf606d62a23d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c8bc79490e7d7566c0278791a1495dcfa5c9c3f1af651f0340faaf606d62a23d", kill_on_drop: false }` [INFO] [stdout] c8bc79490e7d7566c0278791a1495dcfa5c9c3f1af651f0340faaf606d62a23d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1beffb0cdf7a0461c0d59565878fd76fee4438bb9c1d7605d3e54ae7f3456f25 [INFO] running `Command { std: "docker" "start" "-a" "1beffb0cdf7a0461c0d59565878fd76fee4438bb9c1d7605d3e54ae7f3456f25", kill_on_drop: false }` [INFO] [stderr] Checking either v1.8.0 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking aoc2022 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day12.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day12.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let input = include_str!("../inputs/day12.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day12.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day12.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let input = include_str!("../inputs/day12.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day13.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day13.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let input = include_str!("../inputs/day13.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day13.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day13.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let input = include_str!("../inputs/day13.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day14.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day14.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let input = include_str!("../inputs/day14.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day14.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day14.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let input = include_str!("../inputs/day14.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day15.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day15.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let input = include_str!("../inputs/day15.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day15.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day15.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let input = include_str!("../inputs/day15.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day16.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day16.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let input = include_str!("../inputs/day16.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day16.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day16.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let input = include_str!("../inputs/day16.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day17.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day17.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let input = include_str!("../inputs/day17.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day17.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day17.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let input = include_str!("../inputs/day17.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day18.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day18.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let input = include_str!("../inputs/day18.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day18.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day18.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let input = include_str!("../inputs/day18.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day19.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day19.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let input = include_str!("../inputs/day19.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day19.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day19.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let input = include_str!("../inputs/day19.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day20.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day20.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let input = include_str!("../inputs/day20.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day20.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day20.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let input = include_str!("../inputs/day20.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day21.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day21.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let input = include_str!("../inputs/day21.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day21.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day21.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let input = include_str!("../inputs/day21.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day22.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day22.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let input = include_str!("../inputs/day22.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day22.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day22.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let input = include_str!("../inputs/day22.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day23.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day23.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let input = include_str!("../inputs/day23.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day23.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day23.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let input = include_str!("../inputs/day23.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day24.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day24.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let input = include_str!("../inputs/day24.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day24.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day24.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let input = include_str!("../inputs/day24.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day25.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day25.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let input = include_str!("../inputs/day25.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day25.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day25.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let input = include_str!("../inputs/day25.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/solutions/day02.rs:10:30 [INFO] [stdout] | [INFO] [stdout] 10 | let opponent: char = line.chars().nth(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `line.chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/solutions/day02.rs:17:24 [INFO] [stdout] | [INFO] [stdout] 17 | 'Z' => 3 + 0, //scissors [INFO] [stdout] | ^^^^^ help: consider reducing it to: `3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/solutions/day02.rs:22:24 [INFO] [stdout] | [INFO] [stdout] 22 | 'X' => 1 + 0, [INFO] [stdout] | ^^^^^ help: consider reducing it to: `1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/solutions/day02.rs:30:24 [INFO] [stdout] | [INFO] [stdout] 30 | 'Y' => 2 + 0, [INFO] [stdout] | ^^^^^ help: consider reducing it to: `2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/solutions/day02.rs:51:24 [INFO] [stdout] | [INFO] [stdout] 51 | let opponent = line.chars().nth(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `line.chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/solutions/day02.rs:56:24 [INFO] [stdout] | [INFO] [stdout] 56 | 'X' => 0 + 3, //lose [INFO] [stdout] | ^^^^^ help: consider reducing it to: `3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/solutions/day02.rs:63:24 [INFO] [stdout] | [INFO] [stdout] 63 | 'X' => 0 + 1, [INFO] [stdout] | ^^^^^ help: consider reducing it to: `1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/solutions/day02.rs:70:24 [INFO] [stdout] | [INFO] [stdout] 70 | 'X' => 0 + 2, [INFO] [stdout] | ^^^^^ help: consider reducing it to: `2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/solutions/day03.rs:68:16 [INFO] [stdout] | [INFO] [stdout] 68 | if found_char == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `!found_char` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/solutions/day03.rs:73:46 [INFO] [stdout] | [INFO] [stdout] 73 | if char == letter && found_char == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `!found_char` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/solutions/day04.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 56 | if (range_a.0 >= range_b.0 && range_a.0 <= range_b.1) [INFO] [stdout] | ____________^ [INFO] [stdout] 57 | | || (range_a.1 >= range_b.0 && range_a.0 <= range_b.1) [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 56 - if (range_a.0 >= range_b.0 && range_a.0 <= range_b.1) [INFO] [stdout] 57 - || (range_a.1 >= range_b.0 && range_a.0 <= range_b.1) [INFO] [stdout] 56 + if !(range_a.0 > range_b.1 || range_a.0 < range_b.0 && range_a.1 < range_b.0) [INFO] [stdout] | [INFO] [stdout] 56 - if (range_a.0 >= range_b.0 && range_a.0 <= range_b.1) [INFO] [stdout] 57 - || (range_a.1 >= range_b.0 && range_a.0 <= range_b.1) [INFO] [stdout] 56 + if (range_a.1 >= range_b.0 || range_a.0 >= range_b.0) && range_a.0 <= range_b.1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/solutions/day05.rs:16:41 [INFO] [stdout] | [INFO] [stdout] 16 | fn move_box(args: Vec<&str>, boxes: &mut Vec>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 16 - fn move_box(args: Vec<&str>, boxes: &mut Vec>) { [INFO] [stdout] 16 + fn move_box(args: Vec<&str>, boxes: &mut [Vec]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `char` which implements the `Copy` trait [INFO] [stdout] --> src/solutions/day05.rs:24:30 [INFO] [stdout] | [INFO] [stdout] 24 | boxes[dest].push(box_char.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `box_char` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/solutions/day05.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 35 | if line == "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/solutions/day05.rs:63:41 [INFO] [stdout] | [INFO] [stdout] 63 | fn move_box(args: Vec<&str>, boxes: &mut Vec>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 63 - fn move_box(args: Vec<&str>, boxes: &mut Vec>) { [INFO] [stdout] 63 + fn move_box(args: Vec<&str>, boxes: &mut [Vec]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `char` which implements the `Copy` trait [INFO] [stdout] --> src/solutions/day05.rs:71:34 [INFO] [stdout] | [INFO] [stdout] 71 | picked_up_boxes.push(box_char.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `box_char` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/solutions/day05.rs:83:12 [INFO] [stdout] | [INFO] [stdout] 83 | if line == "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/solutions/day06.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return "not found :(".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return "not found :(".to_string(); [INFO] [stdout] 25 + "not found :(".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Chars<'_>` [INFO] [stdout] --> src/solutions/day06.rs:9:28 [INFO] [stdout] | [INFO] [stdout] 9 | for (index, letter) in input.chars().into_iter().enumerate().skip(3) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `input.chars()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/solutions/day06.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | return "not found :(".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 - return "not found :(".to_string(); [INFO] [stdout] 50 + "not found :(".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Chars<'_>` [INFO] [stdout] --> src/solutions/day06.rs:34:28 [INFO] [stdout] | [INFO] [stdout] 34 | for (index, letter) in input.chars().into_iter().enumerate().skip(3) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `input.chars()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/solutions/day07.rs:19:20 [INFO] [stdout] | [INFO] [stdout] 19 | "$" => match tokens.next().unwrap() { [INFO] [stdout] | ____________________^ [INFO] [stdout] 20 | | "cd" => { [INFO] [stdout] 21 | | let token = tokens.next().unwrap(); [INFO] [stdout] 22 | | if token == ".." { [INFO] [stdout] ... | [INFO] [stdout] 29 | | _ => {} [INFO] [stdout] 30 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ "$" => if tokens.next().unwrap() == "cd" { [INFO] [stdout] 20 + let token = tokens.next().unwrap(); [INFO] [stdout] 21 + if token == ".." { [INFO] [stdout] 22 + current_directory = cd_back(¤t_directory); [INFO] [stdout] 23 + } else { [INFO] [stdout] 24 + current_directory += "/"; [INFO] [stdout] 25 + current_directory += token; [INFO] [stdout] 26 + } [INFO] [stdout] 27 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/solutions/day07.rs:73:20 [INFO] [stdout] | [INFO] [stdout] 73 | "$" => match tokens.next().unwrap() { [INFO] [stdout] | ____________________^ [INFO] [stdout] 74 | | "cd" => { [INFO] [stdout] 75 | | let token = tokens.next().unwrap(); [INFO] [stdout] 76 | | if token == ".." { [INFO] [stdout] ... | [INFO] [stdout] 83 | | _ => {} [INFO] [stdout] 84 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 73 ~ "$" => if tokens.next().unwrap() == "cd" { [INFO] [stdout] 74 + let token = tokens.next().unwrap(); [INFO] [stdout] 75 + if token == ".." { [INFO] [stdout] 76 + current_directory = cd_back(¤t_directory); [INFO] [stdout] 77 + } else { [INFO] [stdout] 78 + current_directory += "/"; [INFO] [stdout] 79 + current_directory += token; [INFO] [stdout] 80 + } [INFO] [stdout] 81 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/solutions/day07.rs:113:23 [INFO] [stdout] | [INFO] [stdout] 113 | used_space += file.1.clone() as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `file.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `y` is used to index `tree_map` [INFO] [stdout] --> src/solutions/day08.rs:28:14 [INFO] [stdout] | [INFO] [stdout] 28 | for y in 0..SIZE { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 28 - for y in 0..SIZE { [INFO] [stdout] 28 + for (y, ) in tree_map.iter_mut().enumerate().take(SIZE) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is used to index `tree_map` [INFO] [stdout] --> src/solutions/day08.rs:29:18 [INFO] [stdout] | [INFO] [stdout] 29 | for x in 0..SIZE { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 29 - for x in 0..SIZE { [INFO] [stdout] 29 + for (x, ) in tree_map.iter_mut().enumerate().take(SIZE) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/solutions/day08.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day12.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day12.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let input = include_str!("../inputs/day12.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day12.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day12.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let input = include_str!("../inputs/day12.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day13.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day13.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let input = include_str!("../inputs/day13.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day13.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day13.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let input = include_str!("../inputs/day13.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day14.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day14.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let input = include_str!("../inputs/day14.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day14.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day14.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let input = include_str!("../inputs/day14.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day15.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day15.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let input = include_str!("../inputs/day15.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day15.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day15.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let input = include_str!("../inputs/day15.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day16.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day16.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let input = include_str!("../inputs/day16.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day16.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day16.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let input = include_str!("../inputs/day16.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day17.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day17.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let input = include_str!("../inputs/day17.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day17.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day17.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let input = include_str!("../inputs/day17.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/solutions/day10.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return false; [INFO] [stdout] 17 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/solutions/day10.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | return signal_strength_sum.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return signal_strength_sum.to_string(); [INFO] [stdout] 41 + signal_strength_sum.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/solutions/day10.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | / if advance_clock_1(&x, &mut cycle_num, &mut signal_strength_sum, 1) { [INFO] [stdout] 29 | | return signal_strength_sum.to_string(); [INFO] [stdout] 30 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 27 ~ "noop" [INFO] [stdout] 28 ~ if advance_clock_1(&x, &mut cycle_num, &mut signal_strength_sum, 1) => { [INFO] [stdout] 29 | return signal_strength_sum.to_string(); [INFO] [stdout] 30 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/solutions/day10.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 77 | return screen; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return screen; [INFO] [stdout] 77 + screen [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day18.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day18.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let input = include_str!("../inputs/day18.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day18.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day18.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let input = include_str!("../inputs/day18.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day19.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day19.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let input = include_str!("../inputs/day19.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day19.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day19.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let input = include_str!("../inputs/day19.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day20.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day20.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let input = include_str!("../inputs/day20.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day20.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day20.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let input = include_str!("../inputs/day20.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day21.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day21.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let input = include_str!("../inputs/day21.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day21.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/solutions/day11.rs:6:22 [INFO] [stdout] | [INFO] [stdout] 6 | let mut monkeys: Vec<(Vec, Vec, usize, usize, usize, usize)> = vec![]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day21.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let input = include_str!("../inputs/day21.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day22.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day22.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let input = include_str!("../inputs/day22.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Split<'_, &str>` [INFO] [stdout] --> src/solutions/day11.rs:8:25 [INFO] [stdout] | [INFO] [stdout] 8 | let mut lines = string.split("\n").into_iter().skip(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `string.split("\n")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day22.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day22.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let input = include_str!("../inputs/day22.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day23.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day23.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let input = include_str!("../inputs/day23.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day23.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day23.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let input = include_str!("../inputs/day23.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day24.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day24.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let input = include_str!("../inputs/day24.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day24.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day24.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let input = include_str!("../inputs/day24.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day25.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day25.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | let input = include_str!("../inputs/day25.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/solutions/day25.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut current_total = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/solutions/day11.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 54 | let recipient; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `recipient` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 54 ~ [INFO] [stdout] 55 ~ let recipient = if end % monkeys[index].2 == 0 { [INFO] [stdout] 56 ~ monkeys[index].3 [INFO] [stdout] 57 | } else { [INFO] [stdout] 58 ~ monkeys[index].4 [INFO] [stdout] 59 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/solutions/day25.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let input = include_str!("../inputs/day25.txt"); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/solutions/day11.rs:77:22 [INFO] [stdout] | [INFO] [stdout] 77 | let mut monkeys: Vec<(Vec, Vec, usize, usize, usize, usize)> = vec![]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Split<'_, &str>` [INFO] [stdout] --> src/solutions/day11.rs:79:25 [INFO] [stdout] | [INFO] [stdout] 79 | let mut lines = string.split("\n").into_iter().skip(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `string.split("\n")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/solutions/day11.rs:133:17 [INFO] [stdout] | [INFO] [stdout] 133 | let recipient; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `recipient` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 133 ~ [INFO] [stdout] 134 ~ let recipient = if end % monkeys[index].2 == 0 { [INFO] [stdout] 135 ~ monkeys[index].3 [INFO] [stdout] 136 | } else { [INFO] [stdout] 137 ~ monkeys[index].4 [INFO] [stdout] 138 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/solutions/day02.rs:10:30 [INFO] [stdout] | [INFO] [stdout] 10 | let opponent: char = line.chars().nth(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `line.chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/solutions/day02.rs:17:24 [INFO] [stdout] | [INFO] [stdout] 17 | 'Z' => 3 + 0, //scissors [INFO] [stdout] | ^^^^^ help: consider reducing it to: `3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/solutions/day02.rs:22:24 [INFO] [stdout] | [INFO] [stdout] 22 | 'X' => 1 + 0, [INFO] [stdout] | ^^^^^ help: consider reducing it to: `1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/solutions/day02.rs:30:24 [INFO] [stdout] | [INFO] [stdout] 30 | 'Y' => 2 + 0, [INFO] [stdout] | ^^^^^ help: consider reducing it to: `2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/solutions/day02.rs:51:24 [INFO] [stdout] | [INFO] [stdout] 51 | let opponent = line.chars().nth(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `line.chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/solutions/day02.rs:56:24 [INFO] [stdout] | [INFO] [stdout] 56 | 'X' => 0 + 3, //lose [INFO] [stdout] | ^^^^^ help: consider reducing it to: `3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/solutions/day02.rs:63:24 [INFO] [stdout] | [INFO] [stdout] 63 | 'X' => 0 + 1, [INFO] [stdout] | ^^^^^ help: consider reducing it to: `1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/solutions/day02.rs:70:24 [INFO] [stdout] | [INFO] [stdout] 70 | 'X' => 0 + 2, [INFO] [stdout] | ^^^^^ help: consider reducing it to: `2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/solutions/day03.rs:68:16 [INFO] [stdout] | [INFO] [stdout] 68 | if found_char == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `!found_char` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/solutions/day03.rs:73:46 [INFO] [stdout] | [INFO] [stdout] 73 | if char == letter && found_char == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `!found_char` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/solutions/day04.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 56 | if (range_a.0 >= range_b.0 && range_a.0 <= range_b.1) [INFO] [stdout] | ____________^ [INFO] [stdout] 57 | | || (range_a.1 >= range_b.0 && range_a.0 <= range_b.1) [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 56 - if (range_a.0 >= range_b.0 && range_a.0 <= range_b.1) [INFO] [stdout] 57 - || (range_a.1 >= range_b.0 && range_a.0 <= range_b.1) [INFO] [stdout] 56 + if !(range_a.0 > range_b.1 || range_a.0 < range_b.0 && range_a.1 < range_b.0) [INFO] [stdout] | [INFO] [stdout] 56 - if (range_a.0 >= range_b.0 && range_a.0 <= range_b.1) [INFO] [stdout] 57 - || (range_a.1 >= range_b.0 && range_a.0 <= range_b.1) [INFO] [stdout] 56 + if (range_a.1 >= range_b.0 || range_a.0 >= range_b.0) && range_a.0 <= range_b.1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/solutions/day05.rs:16:41 [INFO] [stdout] | [INFO] [stdout] 16 | fn move_box(args: Vec<&str>, boxes: &mut Vec>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 16 - fn move_box(args: Vec<&str>, boxes: &mut Vec>) { [INFO] [stdout] 16 + fn move_box(args: Vec<&str>, boxes: &mut [Vec]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `char` which implements the `Copy` trait [INFO] [stdout] --> src/solutions/day05.rs:24:30 [INFO] [stdout] | [INFO] [stdout] 24 | boxes[dest].push(box_char.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `box_char` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/solutions/day05.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 35 | if line == "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/solutions/day05.rs:63:41 [INFO] [stdout] | [INFO] [stdout] 63 | fn move_box(args: Vec<&str>, boxes: &mut Vec>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 63 - fn move_box(args: Vec<&str>, boxes: &mut Vec>) { [INFO] [stdout] 63 + fn move_box(args: Vec<&str>, boxes: &mut [Vec]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `char` which implements the `Copy` trait [INFO] [stdout] --> src/solutions/day05.rs:71:34 [INFO] [stdout] | [INFO] [stdout] 71 | picked_up_boxes.push(box_char.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `box_char` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/solutions/day05.rs:83:12 [INFO] [stdout] | [INFO] [stdout] 83 | if line == "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/solutions/day06.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return "not found :(".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return "not found :(".to_string(); [INFO] [stdout] 25 + "not found :(".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Chars<'_>` [INFO] [stdout] --> src/solutions/day06.rs:9:28 [INFO] [stdout] | [INFO] [stdout] 9 | for (index, letter) in input.chars().into_iter().enumerate().skip(3) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `input.chars()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/solutions/day06.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | return "not found :(".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 - return "not found :(".to_string(); [INFO] [stdout] 50 + "not found :(".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Chars<'_>` [INFO] [stdout] --> src/solutions/day06.rs:34:28 [INFO] [stdout] | [INFO] [stdout] 34 | for (index, letter) in input.chars().into_iter().enumerate().skip(3) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `input.chars()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/solutions/day07.rs:19:20 [INFO] [stdout] | [INFO] [stdout] 19 | "$" => match tokens.next().unwrap() { [INFO] [stdout] | ____________________^ [INFO] [stdout] 20 | | "cd" => { [INFO] [stdout] 21 | | let token = tokens.next().unwrap(); [INFO] [stdout] 22 | | if token == ".." { [INFO] [stdout] ... | [INFO] [stdout] 29 | | _ => {} [INFO] [stdout] 30 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ "$" => if tokens.next().unwrap() == "cd" { [INFO] [stdout] 20 + let token = tokens.next().unwrap(); [INFO] [stdout] 21 + if token == ".." { [INFO] [stdout] 22 + current_directory = cd_back(¤t_directory); [INFO] [stdout] 23 + } else { [INFO] [stdout] 24 + current_directory += "/"; [INFO] [stdout] 25 + current_directory += token; [INFO] [stdout] 26 + } [INFO] [stdout] 27 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/solutions/day07.rs:73:20 [INFO] [stdout] | [INFO] [stdout] 73 | "$" => match tokens.next().unwrap() { [INFO] [stdout] | ____________________^ [INFO] [stdout] 74 | | "cd" => { [INFO] [stdout] 75 | | let token = tokens.next().unwrap(); [INFO] [stdout] 76 | | if token == ".." { [INFO] [stdout] ... | [INFO] [stdout] 83 | | _ => {} [INFO] [stdout] 84 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 73 ~ "$" => if tokens.next().unwrap() == "cd" { [INFO] [stdout] 74 + let token = tokens.next().unwrap(); [INFO] [stdout] 75 + if token == ".." { [INFO] [stdout] 76 + current_directory = cd_back(¤t_directory); [INFO] [stdout] 77 + } else { [INFO] [stdout] 78 + current_directory += "/"; [INFO] [stdout] 79 + current_directory += token; [INFO] [stdout] 80 + } [INFO] [stdout] 81 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/solutions/day07.rs:113:23 [INFO] [stdout] | [INFO] [stdout] 113 | used_space += file.1.clone() as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `file.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `y` is used to index `tree_map` [INFO] [stdout] --> src/solutions/day08.rs:28:14 [INFO] [stdout] | [INFO] [stdout] 28 | for y in 0..SIZE { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 28 - for y in 0..SIZE { [INFO] [stdout] 28 + for (y, ) in tree_map.iter_mut().enumerate().take(SIZE) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is used to index `tree_map` [INFO] [stdout] --> src/solutions/day08.rs:29:18 [INFO] [stdout] | [INFO] [stdout] 29 | for x in 0..SIZE { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 29 - for x in 0..SIZE { [INFO] [stdout] 29 + for (x, ) in tree_map.iter_mut().enumerate().take(SIZE) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/solutions/day08.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/solutions/day10.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return false; [INFO] [stdout] 17 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/solutions/day10.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | return signal_strength_sum.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return signal_strength_sum.to_string(); [INFO] [stdout] 41 + signal_strength_sum.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/solutions/day10.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | / if advance_clock_1(&x, &mut cycle_num, &mut signal_strength_sum, 1) { [INFO] [stdout] 29 | | return signal_strength_sum.to_string(); [INFO] [stdout] 30 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 27 ~ "noop" [INFO] [stdout] 28 ~ if advance_clock_1(&x, &mut cycle_num, &mut signal_strength_sum, 1) => { [INFO] [stdout] 29 | return signal_strength_sum.to_string(); [INFO] [stdout] 30 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/solutions/day10.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 77 | return screen; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return screen; [INFO] [stdout] 77 + screen [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/solutions/day11.rs:6:22 [INFO] [stdout] | [INFO] [stdout] 6 | let mut monkeys: Vec<(Vec, Vec, usize, usize, usize, usize)> = vec![]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Split<'_, &str>` [INFO] [stdout] --> src/solutions/day11.rs:8:25 [INFO] [stdout] | [INFO] [stdout] 8 | let mut lines = string.split("\n").into_iter().skip(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `string.split("\n")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/solutions/day11.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 54 | let recipient; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `recipient` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 54 ~ [INFO] [stdout] 55 ~ let recipient = if end % monkeys[index].2 == 0 { [INFO] [stdout] 56 ~ monkeys[index].3 [INFO] [stdout] 57 | } else { [INFO] [stdout] 58 ~ monkeys[index].4 [INFO] [stdout] 59 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/solutions/day11.rs:77:22 [INFO] [stdout] | [INFO] [stdout] 77 | let mut monkeys: Vec<(Vec, Vec, usize, usize, usize, usize)> = vec![]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Split<'_, &str>` [INFO] [stdout] --> src/solutions/day11.rs:79:25 [INFO] [stdout] | [INFO] [stdout] 79 | let mut lines = string.split("\n").into_iter().skip(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `string.split("\n")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/solutions/day11.rs:133:17 [INFO] [stdout] | [INFO] [stdout] 133 | let recipient; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `recipient` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 133 ~ [INFO] [stdout] 134 ~ let recipient = if end % monkeys[index].2 == 0 { [INFO] [stdout] 135 ~ monkeys[index].3 [INFO] [stdout] 136 | } else { [INFO] [stdout] 137 ~ monkeys[index].4 [INFO] [stdout] 138 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.93s [INFO] running `Command { std: "docker" "inspect" "1beffb0cdf7a0461c0d59565878fd76fee4438bb9c1d7605d3e54ae7f3456f25", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1beffb0cdf7a0461c0d59565878fd76fee4438bb9c1d7605d3e54ae7f3456f25", kill_on_drop: false }` [INFO] [stdout] 1beffb0cdf7a0461c0d59565878fd76fee4438bb9c1d7605d3e54ae7f3456f25