[INFO] cloning repository https://github.com/DR4KN31L/OrcWars [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DR4KN31L/OrcWars" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDR4KN31L%2FOrcWars", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDR4KN31L%2FOrcWars'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7598acf749a17b532e1966c0aa50180aedf3fbac [INFO] linting DR4KN31L/OrcWars against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDR4KN31L%2FOrcWars" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/DR4KN31L/OrcWars [INFO] finished tweaking git repo https://github.com/DR4KN31L/OrcWars [INFO] tweaked toml for git repo https://github.com/DR4KN31L/OrcWars written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/DR4KN31L/OrcWars on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/DR4KN31L/OrcWars already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded wayland-scanner v0.31.4 [INFO] [stderr] Downloaded wayland-protocols-plasma v0.3.3 [INFO] [stderr] Downloaded wayland-cursor v0.31.5 [INFO] [stderr] Downloaded ecolor v0.28.1 [INFO] [stderr] Downloaded unicode-xid v0.2.5 [INFO] [stderr] Downloaded bevy-inspector-egui-derive v0.25.1 [INFO] [stderr] Downloaded webbrowser v1.0.1 [INFO] [stderr] Downloaded arboard v3.4.0 [INFO] [stderr] Downloaded gilrs-core v0.5.13 [INFO] [stderr] Downloaded bytemuck v1.17.0 [INFO] [stderr] Downloaded bevy-inspector-egui v0.25.2 [INFO] [stderr] Downloaded bevy_egui v0.28.0 [INFO] [stderr] Downloaded gilrs v0.10.9 [INFO] [stderr] Downloaded serde_json v1.0.125 [INFO] [stderr] Downloaded blake3 v1.5.4 [INFO] [stderr] Downloaded quick-xml v0.34.0 [INFO] [stderr] Downloaded ttf-parser v0.24.1 [INFO] [stderr] Downloaded owned_ttf_parser v0.24.0 [INFO] [stderr] Downloaded wayland-protocols v0.32.3 [INFO] [stderr] Downloaded syn v2.0.75 [INFO] [stderr] Downloaded wayland-client v0.31.5 [INFO] [stderr] Downloaded wayland-backend v0.3.6 [INFO] [stderr] Downloaded serde v1.0.208 [INFO] [stderr] Downloaded egui v0.28.1 [INFO] [stderr] Downloaded xml-rs v0.8.21 [INFO] [stderr] Downloaded polling v3.7.3 [INFO] [stderr] Downloaded serde_derive v1.0.208 [INFO] [stderr] Downloaded emath v0.28.1 [INFO] [stderr] Downloaded bevy_pancam v0.13.0 [INFO] [stderr] Downloaded noise v0.9.0 [INFO] [stderr] Downloaded async-executor v1.13.0 [INFO] [stderr] Downloaded ab_glyph v0.2.28 [INFO] [stderr] Downloaded memmap2 v0.9.4 [INFO] [stderr] Downloaded wayland-protocols-wlr v0.3.3 [INFO] [stderr] Downloaded wayland-sys v0.31.4 [INFO] [stderr] Downloaded epaint v0.28.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 79656dc7c32cf8a5d6cc0654af3a6c53c00355e1965775ed9df24c4953e1e535 [INFO] running `Command { std: "docker" "start" "-a" "79656dc7c32cf8a5d6cc0654af3a6c53c00355e1965775ed9df24c4953e1e535", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "79656dc7c32cf8a5d6cc0654af3a6c53c00355e1965775ed9df24c4953e1e535", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "79656dc7c32cf8a5d6cc0654af3a6c53c00355e1965775ed9df24c4953e1e535", kill_on_drop: false }` [INFO] [stdout] 79656dc7c32cf8a5d6cc0654af3a6c53c00355e1965775ed9df24c4953e1e535 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9fc89f30fa5ce70e68c5a9c4224e0d04fb1377a3b14d6d57f2bde43887cdf402 [INFO] running `Command { std: "docker" "start" "-a" "9fc89f30fa5ce70e68c5a9c4224e0d04fb1377a3b14d6d57f2bde43887cdf402", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling serde v1.0.208 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling winnow v0.6.18 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling indexmap v2.4.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Compiling typeid v1.0.2 [INFO] [stderr] Compiling syn v2.0.75 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking web-time v1.1.0 [INFO] [stderr] Checking bevy_ptr v0.14.1 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking fixedbitset v0.5.7 [INFO] [stderr] Checking libloading v0.8.5 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Checking unicode-xid v0.2.5 [INFO] [stderr] Compiling cc v1.1.13 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling wgpu-hal v0.21.1 [INFO] [stderr] Checking accesskit v0.14.0 [INFO] [stderr] Checking ash v0.37.3+1.3.251 [INFO] [stderr] Checking flate2 v1.0.31 [INFO] [stderr] Compiling wgpu-core v0.21.1 [INFO] [stderr] Checking arrayref v0.3.8 [INFO] [stderr] Compiling litrs v0.4.1 [INFO] [stderr] Compiling wgpu v0.20.1 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking async-executor v1.13.0 [INFO] [stderr] Checking ruzstd v0.7.0 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking ttf-parser v0.24.1 [INFO] [stderr] Checking radsort v0.1.1 [INFO] [stderr] Checking euclid v0.22.10 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Compiling uuid v1.10.0 [INFO] [stderr] Checking bevy_tasks v0.14.1 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Compiling serde_json v1.0.125 [INFO] [stderr] Checking guillotiere v0.6.2 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Compiling winit v0.30.5 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Checking dpi v0.1.1 [INFO] [stderr] Compiling gilrs v0.10.9 [INFO] [stderr] Checking grid v0.14.0 [INFO] [stderr] Checking async-fs v2.1.2 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking lewton v0.10.2 [INFO] [stderr] Compiling toml_edit v0.22.20 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking khronos-egl v6.0.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking sysinfo v0.30.13 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking alsa-sys v0.3.1 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking libudev-sys v0.1.4 [INFO] [stderr] Compiling bevy_egui v0.28.0 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking inotify v0.10.2 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Compiling document-features v0.2.10 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking pretty-type-name v1.0.1 [INFO] [stderr] Checking taffy v0.5.2 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling encase_derive_impl v0.8.0 [INFO] [stderr] Checking webbrowser v1.0.1 [INFO] [stderr] Checking owned_ttf_parser v0.24.0 [INFO] [stderr] Compiling bevy_macro_utils v0.14.1 [INFO] [stderr] Compiling blake3 v1.5.4 [INFO] [stderr] Checking ab_glyph v0.2.28 [INFO] [stderr] Checking glyph_brush_layout v0.2.4 [INFO] [stderr] Compiling serde_derive v1.0.208 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling bytemuck_derive v1.7.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling bevy_utils_proc_macros v0.14.1 [INFO] [stderr] Compiling bevy_reflect_derive v0.14.1 [INFO] [stderr] Compiling bevy_ecs_macros v0.14.1 [INFO] [stderr] Compiling bevy_derive v0.14.1 [INFO] [stderr] Compiling bevy_asset_macros v0.14.1 [INFO] [stderr] Compiling encase_derive v0.8.0 [INFO] [stderr] Compiling bevy_encase_derive v0.14.1 [INFO] [stderr] Compiling bevy_render_macros v0.14.1 [INFO] [stderr] Compiling gltf-derive v1.4.1 [INFO] [stderr] Compiling bevy_gizmos_macros v0.14.1 [INFO] [stderr] Compiling bevy_state_macros v0.14.1 [INFO] [stderr] Compiling bevy-inspector-egui-derive v0.25.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking noise v0.9.0 [INFO] [stderr] Checking bytemuck v1.17.0 [INFO] [stderr] Checking image v0.25.2 [INFO] [stderr] Checking emath v0.28.1 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking ecolor v0.28.1 [INFO] [stderr] Checking epaint v0.28.1 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking egui v0.28.1 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking glam v0.27.0 [INFO] [stderr] Checking erased-serde v0.4.5 [INFO] [stderr] Checking spirv v0.3.0+sdk-1.3.268.0 [INFO] [stderr] Checking gpu-alloc-types v0.3.0 [INFO] [stderr] Checking wgpu-types v0.20.0 [INFO] [stderr] Checking gpu-descriptor-types v0.2.0 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking rustix v0.38.34 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking nix v0.29.0 [INFO] [stderr] Checking alsa v0.9.0 [INFO] [stderr] Checking gpu-alloc v0.6.0 [INFO] [stderr] Checking bevy_utils v0.14.1 [INFO] [stderr] Checking gpu-descriptor v0.3.0 [INFO] [stderr] Checking gilrs-core v0.5.13 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking gltf-json v1.4.1 [INFO] [stderr] Checking naga v0.20.0 [INFO] [stderr] Checking cpal v0.15.3 [INFO] [stderr] Checking rodio v0.18.1 [INFO] [stderr] Checking gltf v1.4.1 [INFO] [stderr] Checking bevy_reflect v0.14.1 [INFO] [stderr] Checking encase v0.8.0 [INFO] [stderr] Checking hexasphere v12.0.0 [INFO] [stderr] Checking bevy_mikktspace v0.14.1 [INFO] [stderr] Checking polling v3.7.3 [INFO] [stderr] Checking x11rb v0.13.1 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking arboard v3.4.0 [INFO] [stderr] Checking bevy_ecs v0.14.1 [INFO] [stderr] Checking bevy_math v0.14.1 [INFO] [stderr] Checking naga_oil v0.14.0 [INFO] [stderr] Checking accesskit_winit v0.20.4 [INFO] [stderr] Checking bevy_color v0.14.2 [INFO] [stderr] Checking bevy_app v0.14.1 [INFO] [stderr] Checking bevy_core v0.14.1 [INFO] [stderr] Checking bevy_a11y v0.14.1 [INFO] [stderr] Checking bevy_time v0.14.1 [INFO] [stderr] Checking bevy_asset v0.14.1 [INFO] [stderr] Checking bevy_log v0.14.1 [INFO] [stderr] Checking bevy_input v0.14.1 [INFO] [stderr] Checking bevy_window v0.14.1 [INFO] [stderr] Checking bevy_hierarchy v0.14.1 [INFO] [stderr] Checking bevy_diagnostic v0.14.1 [INFO] [stderr] Checking bevy_transform v0.14.1 [INFO] [stderr] Checking bevy_state v0.14.1 [INFO] [stderr] Checking bevy_winit v0.14.1 [INFO] [stderr] Checking bevy_gilrs v0.14.1 [INFO] [stderr] Checking bevy_render v0.14.1 [INFO] [stderr] Checking bevy_audio v0.14.1 [INFO] [stderr] Checking bevy_core_pipeline v0.14.1 [INFO] [stderr] Checking bevy_scene v0.14.1 [INFO] [stderr] Checking bevy_animation v0.14.1 [INFO] [stderr] Checking bevy_sprite v0.14.1 [INFO] [stderr] Checking bevy_pbr v0.14.1 [INFO] [stderr] Checking bevy_text v0.14.1 [INFO] [stderr] Checking bevy_ui v0.14.1 [INFO] [stderr] Checking bevy_gizmos v0.14.1 [INFO] [stderr] Checking bevy_gltf v0.14.1 [INFO] [stderr] Checking bevy_internal v0.14.1 [INFO] [stderr] Checking bevy v0.14.1 [INFO] [stderr] Checking bevy_pancam v0.13.0 [INFO] [stderr] Checking bevy-inspector-egui v0.25.2 [INFO] [stderr] Checking OrcWars v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `rand::Rng` [INFO] [stdout] --> src/player.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use rand::Rng; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/terrain.rs:85:42 [INFO] [stdout] | [INFO] [stdout] 85 | vege.push(Bioma::new((pos),rnd,0,None,None)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 85 - vege.push(Bioma::new((pos),rnd,0,None,None)); [INFO] [stdout] 85 + vege.push(Bioma::new(pos ,rnd,0,None,None)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/terrain.rs:94:42 [INFO] [stdout] | [INFO] [stdout] 94 | vege.push(Bioma::new((pos),rnd,0,None,None)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 94 - vege.push(Bioma::new((pos),rnd,0,None,None)); [INFO] [stdout] 94 + vege.push(Bioma::new(pos ,rnd,0,None,None)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/terrain.rs:103:42 [INFO] [stdout] | [INFO] [stdout] 103 | vege.push(Bioma::new((pos),rnd,0,None,None)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 103 - vege.push(Bioma::new((pos),rnd,0,None,None)); [INFO] [stdout] 103 + vege.push(Bioma::new(pos ,rnd,0,None,None)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rand::Rng` [INFO] [stdout] --> src/player.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use rand::Rng; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/terrain.rs:85:42 [INFO] [stdout] | [INFO] [stdout] 85 | vege.push(Bioma::new((pos),rnd,0,None,None)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 85 - vege.push(Bioma::new((pos),rnd,0,None,None)); [INFO] [stdout] 85 + vege.push(Bioma::new(pos ,rnd,0,None,None)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/terrain.rs:94:42 [INFO] [stdout] | [INFO] [stdout] 94 | vege.push(Bioma::new((pos),rnd,0,None,None)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 94 - vege.push(Bioma::new((pos),rnd,0,None,None)); [INFO] [stdout] 94 + vege.push(Bioma::new(pos ,rnd,0,None,None)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/terrain.rs:103:42 [INFO] [stdout] | [INFO] [stdout] 103 | vege.push(Bioma::new((pos),rnd,0,None,None)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 103 - vege.push(Bioma::new((pos),rnd,0,None,None)); [INFO] [stdout] 103 + vege.push(Bioma::new(pos ,rnd,0,None,None)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/terrain.rs:209:32 [INFO] [stdout] | [INFO] [stdout] 209 | for (mut timer, mut atlas, mut watertype) in &mut query { [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `GameStatus` is never used [INFO] [stdout] --> src/main.rs:19:6 [INFO] [stdout] | [INFO] [stdout] 19 | enum GameStatus{ [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PlayerCollider` is never constructed [INFO] [stdout] --> src/player.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | struct PlayerCollider; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/player.rs:22:26 [INFO] [stdout] | [INFO] [stdout] 22 | struct PlayerSpriteIndex(usize); [INFO] [stdout] | ----------------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Walk`, `Run`, `DeadFront`, `DeadBack`, `DeadLeft`, and `DeadRight` are never constructed [INFO] [stdout] --> src/player.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 27 | enum PlayerState { [INFO] [stdout] | ----------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 34 | Walk, [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 39 | Run, [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 44 | DeadFront, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 45 | DeadBack, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 46 | DeadLeft, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 47 | DeadRight, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PlayerState` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `last` is never read [INFO] [stdout] --> src/player.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 67 | struct AnimationIndices { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 68 | first: usize, [INFO] [stdout] 69 | last: usize [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `is_alive`, `is_walking`, and `is_running` are never used [INFO] [stdout] --> src/player.rs:288:8 [INFO] [stdout] | [INFO] [stdout] 287 | impl CurrentPlayerState { [INFO] [stdout] | ----------------------- methods in this implementation [INFO] [stdout] 288 | fn is_alive(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 291 | fn is_walking(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 310 | fn is_running(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/enemy.rs:30:26 [INFO] [stdout] | [INFO] [stdout] 30 | struct EnemyCurrentState(EnemyState); [INFO] [stdout] | ----------------- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Dead` is never constructed [INFO] [stdout] --> src/enemy.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 33 | enum EnemyState { [INFO] [stdout] | ---------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 44 | Dead, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EnemyState` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set_state` is never used [INFO] [stdout] --> src/enemy.rs:195:8 [INFO] [stdout] | [INFO] [stdout] 194 | impl EnemyCurrentState{ [INFO] [stdout] | ---------------------- method in this implementation [INFO] [stdout] 195 | fn set_state(&mut self,new_state : EnemyState){ [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/player.rs:244:9 [INFO] [stdout] | [INFO] [stdout] 244 | / if player_state.0 == PlayerState::IdleBack || player_state.0 == PlayerState::Alive{ [INFO] [stdout] 245 | | if timer.just_finished(){ [INFO] [stdout] 246 | | atlas.index = (atlas.index+1)%8 [INFO] [stdout] 247 | | } [INFO] [stdout] 248 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 244 ~ if (player_state.0 == PlayerState::IdleBack || player_state.0 == PlayerState::Alive){ [INFO] [stdout] 245 ~ && timer.just_finished(){ [INFO] [stdout] 246 | atlas.index = (atlas.index+1)%8 [INFO] [stdout] 247 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/player.rs:249:9 [INFO] [stdout] | [INFO] [stdout] 249 | / if player_state.0 == PlayerState::IdleFront{ [INFO] [stdout] 250 | | if timer.just_finished() { [INFO] [stdout] 251 | | atlas.index = (atlas.index+1)%8 + 8 [INFO] [stdout] 252 | | } [INFO] [stdout] 253 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 249 ~ if player_state.0 == PlayerState::IdleFront [INFO] [stdout] 250 ~ && timer.just_finished() { [INFO] [stdout] 251 | atlas.index = (atlas.index+1)%8 + 8 [INFO] [stdout] 252 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/player.rs:254:9 [INFO] [stdout] | [INFO] [stdout] 254 | / if player_state.0 == PlayerState::IdleLeft { [INFO] [stdout] 255 | | if timer.just_finished(){ [INFO] [stdout] 256 | | atlas.index = (atlas.index+1)%8 + 16 [INFO] [stdout] 257 | | } [INFO] [stdout] 258 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 254 ~ if player_state.0 == PlayerState::IdleLeft [INFO] [stdout] 255 ~ && timer.just_finished(){ [INFO] [stdout] 256 | atlas.index = (atlas.index+1)%8 + 16 [INFO] [stdout] 257 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/player.rs:259:9 [INFO] [stdout] | [INFO] [stdout] 259 | / if player_state.0 == PlayerState::IdleRight { [INFO] [stdout] 260 | | if timer.just_finished(){ [INFO] [stdout] 261 | | atlas.index = (atlas.index+1)%8 + 24 [INFO] [stdout] 262 | | } [INFO] [stdout] 263 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 259 ~ if player_state.0 == PlayerState::IdleRight [INFO] [stdout] 260 ~ && timer.just_finished(){ [INFO] [stdout] 261 | atlas.index = (atlas.index+1)%8 + 24 [INFO] [stdout] 262 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/player.rs:264:9 [INFO] [stdout] | [INFO] [stdout] 264 | / if player_state.0 == PlayerState::WalkBack || player_state.0 == PlayerState::RunBack{ [INFO] [stdout] 265 | | if timer.just_finished(){ [INFO] [stdout] 266 | | atlas.index = (atlas.index+1)%8 + 32 [INFO] [stdout] 267 | | } [INFO] [stdout] 268 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 264 ~ if (player_state.0 == PlayerState::WalkBack || player_state.0 == PlayerState::RunBack){ [INFO] [stdout] 265 ~ && timer.just_finished(){ [INFO] [stdout] 266 | atlas.index = (atlas.index+1)%8 + 32 [INFO] [stdout] 267 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/player.rs:269:9 [INFO] [stdout] | [INFO] [stdout] 269 | / if player_state.0 == PlayerState::WalkFront || player_state.0 == PlayerState::RunFront{ [INFO] [stdout] 270 | | if timer.just_finished(){ [INFO] [stdout] 271 | | atlas.index = (atlas.index+1)%8 + 40 [INFO] [stdout] 272 | | } [INFO] [stdout] 273 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 269 ~ if (player_state.0 == PlayerState::WalkFront || player_state.0 == PlayerState::RunFront){ [INFO] [stdout] 270 ~ && timer.just_finished(){ [INFO] [stdout] 271 | atlas.index = (atlas.index+1)%8 + 40 [INFO] [stdout] 272 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/player.rs:274:9 [INFO] [stdout] | [INFO] [stdout] 274 | / if player_state.0 == PlayerState::WalkLeft || player_state.0 == PlayerState::RunLeft{ [INFO] [stdout] 275 | | if timer.just_finished(){ [INFO] [stdout] 276 | | atlas.index = (atlas.index+1)%8 + 48 [INFO] [stdout] 277 | | } [INFO] [stdout] 278 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 274 ~ if (player_state.0 == PlayerState::WalkLeft || player_state.0 == PlayerState::RunLeft){ [INFO] [stdout] 275 ~ && timer.just_finished(){ [INFO] [stdout] 276 | atlas.index = (atlas.index+1)%8 + 48 [INFO] [stdout] 277 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/player.rs:279:9 [INFO] [stdout] | [INFO] [stdout] 279 | / if player_state.0 == PlayerState::WalkRight || player_state.0 == PlayerState::RunRight{ [INFO] [stdout] 280 | | if timer.just_finished(){ [INFO] [stdout] 281 | | atlas.index = (atlas.index+1)%8 + 56 [INFO] [stdout] 282 | | } [INFO] [stdout] 283 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 279 ~ if (player_state.0 == PlayerState::WalkRight || player_state.0 == PlayerState::RunRight){ [INFO] [stdout] 280 ~ && timer.just_finished(){ [INFO] [stdout] 281 | atlas.index = (atlas.index+1)%8 + 56 [INFO] [stdout] 282 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/player.rs:292:9 [INFO] [stdout] | [INFO] [stdout] 292 | / match self.0 { [INFO] [stdout] 293 | | PlayerState::Walk => true, [INFO] [stdout] 294 | | PlayerState::WalkBack => true, [INFO] [stdout] 295 | | PlayerState::WalkFront => true, [INFO] [stdout] ... | [INFO] [stdout] 298 | | _ => false [INFO] [stdout] 299 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 292 - match self.0 { [INFO] [stdout] 293 - PlayerState::Walk => true, [INFO] [stdout] 294 - PlayerState::WalkBack => true, [INFO] [stdout] 295 - PlayerState::WalkFront => true, [INFO] [stdout] 296 - PlayerState::WalkLeft => true, [INFO] [stdout] 297 - PlayerState::WalkRight => true, [INFO] [stdout] 298 - _ => false [INFO] [stdout] 299 - } [INFO] [stdout] 292 + matches!(self.0, PlayerState::Walk | PlayerState::WalkBack | PlayerState::WalkFront | PlayerState::WalkLeft | PlayerState::WalkRight) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/player.rs:302:9 [INFO] [stdout] | [INFO] [stdout] 302 | / match self.0{ [INFO] [stdout] 303 | | PlayerState::DeadFront => true, [INFO] [stdout] 304 | | PlayerState::DeadBack => true, [INFO] [stdout] 305 | | PlayerState::DeadLeft => true, [INFO] [stdout] 306 | | PlayerState::DeadRight => true, [INFO] [stdout] 307 | | _ => false [INFO] [stdout] 308 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 302 - match self.0{ [INFO] [stdout] 303 - PlayerState::DeadFront => true, [INFO] [stdout] 304 - PlayerState::DeadBack => true, [INFO] [stdout] 305 - PlayerState::DeadLeft => true, [INFO] [stdout] 306 - PlayerState::DeadRight => true, [INFO] [stdout] 307 - _ => false [INFO] [stdout] 308 - } [INFO] [stdout] 302 + matches!(self.0, PlayerState::DeadFront | PlayerState::DeadBack | PlayerState::DeadLeft | PlayerState::DeadRight) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/player.rs:311:9 [INFO] [stdout] | [INFO] [stdout] 311 | / match self.0 { [INFO] [stdout] 312 | | PlayerState::Run => true, [INFO] [stdout] 313 | | PlayerState::RunBack => true, [INFO] [stdout] 314 | | PlayerState::RunFront => true, [INFO] [stdout] ... | [INFO] [stdout] 317 | | _ => false [INFO] [stdout] 318 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 311 - match self.0 { [INFO] [stdout] 312 - PlayerState::Run => true, [INFO] [stdout] 313 - PlayerState::RunBack => true, [INFO] [stdout] 314 - PlayerState::RunFront => true, [INFO] [stdout] 315 - PlayerState::RunLeft => true, [INFO] [stdout] 316 - PlayerState::RunRight => true, [INFO] [stdout] 317 - _ => false [INFO] [stdout] 318 - } [INFO] [stdout] 311 + matches!(self.0, PlayerState::Run | PlayerState::RunBack | PlayerState::RunFront | PlayerState::RunLeft | PlayerState::RunRight) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/terrain.rs:209:32 [INFO] [stdout] | [INFO] [stdout] 209 | for (mut timer, mut atlas, mut watertype) in &mut query { [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/terrain.rs:81:16 [INFO] [stdout] | [INFO] [stdout] 81 | if noise >= 0.31 && noise < 0.36{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0.31..0.36).contains(&noise)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/terrain.rs:90:16 [INFO] [stdout] | [INFO] [stdout] 90 | if noise >= 0.23 && noise < 0.31 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0.23..0.31).contains(&noise)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/terrain.rs:99:16 [INFO] [stdout] | [INFO] [stdout] 99 | if noise >= 0.36 && noise < 0.5 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0.36..0.5).contains(&noise)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/terrain.rs:108:16 [INFO] [stdout] | [INFO] [stdout] 108 | if noise >= 0.5 && noise < 0.64 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0.5..0.64).contains(&noise)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/terrain.rs:142:12 [INFO] [stdout] | [INFO] [stdout] 142 | if bioma.is_water == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `bioma.is_water` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/terrain.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 211 | / if *watertype == WaterType::Normal{ [INFO] [stdout] 212 | | if timer.just_finished(){ [INFO] [stdout] 213 | | atlas.index = (atlas.index+1)%4; [INFO] [stdout] 214 | | } [INFO] [stdout] 215 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 211 ~ if *watertype == WaterType::Normal [INFO] [stdout] 212 ~ && timer.just_finished(){ [INFO] [stdout] 213 | atlas.index = (atlas.index+1)%4; [INFO] [stdout] 214 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/terrain.rs:216:9 [INFO] [stdout] | [INFO] [stdout] 216 | / if *watertype == WaterType::Deep{ [INFO] [stdout] 217 | | if timer.just_finished(){ [INFO] [stdout] 218 | | atlas.index = (atlas.index+1)%4 +4; [INFO] [stdout] 219 | | } [INFO] [stdout] 220 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 216 ~ if *watertype == WaterType::Deep [INFO] [stdout] 217 ~ && timer.just_finished(){ [INFO] [stdout] 218 | atlas.index = (atlas.index+1)%4 +4; [INFO] [stdout] 219 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/enemy.rs:107:17 [INFO] [stdout] | [INFO] [stdout] 107 | mut query : Query<(&mut crate::AnimationTimer, &mut TextureAtlas, &EnemyType, &EnemyState),(With,Without)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | / if (enemy_state == &EnemyState::IdleFront || enemy_state == &EnemyState::Alive) && enemy_type.is_slave(){ [INFO] [stdout] 113 | | if timer.just_finished(){ [INFO] [stdout] 114 | | atlas.index = (atlas.index+1)%8 [INFO] [stdout] 115 | | } [INFO] [stdout] 116 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 112 ~ if (enemy_state == &EnemyState::IdleFront || enemy_state == &EnemyState::Alive) && enemy_type.is_slave() [INFO] [stdout] 113 ~ && timer.just_finished(){ [INFO] [stdout] 114 | atlas.index = (atlas.index+1)%8 [INFO] [stdout] 115 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | / if enemy_state == &EnemyState::IdleBack && enemy_type.is_slave(){ [INFO] [stdout] 118 | | if timer.just_finished() { [INFO] [stdout] 119 | | atlas.index = (atlas.index+1)%8 + 8 [INFO] [stdout] 120 | | } [INFO] [stdout] 121 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 117 ~ if enemy_state == &EnemyState::IdleBack && enemy_type.is_slave() [INFO] [stdout] 118 ~ && timer.just_finished() { [INFO] [stdout] 119 | atlas.index = (atlas.index+1)%8 + 8 [INFO] [stdout] 120 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 122 | / if enemy_state == &EnemyState::IdleLeft && enemy_type.is_slave(){ [INFO] [stdout] 123 | | if timer.just_finished(){ [INFO] [stdout] 124 | | atlas.index = (atlas.index+1)%8 + 16 [INFO] [stdout] 125 | | } [INFO] [stdout] 126 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 122 ~ if enemy_state == &EnemyState::IdleLeft && enemy_type.is_slave() [INFO] [stdout] 123 ~ && timer.just_finished(){ [INFO] [stdout] 124 | atlas.index = (atlas.index+1)%8 + 16 [INFO] [stdout] 125 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 127 | / if enemy_state == &EnemyState::IdleRight && enemy_type.is_slave(){ [INFO] [stdout] 128 | | if timer.just_finished(){ [INFO] [stdout] 129 | | atlas.index = (atlas.index+1)%8 + 24 [INFO] [stdout] 130 | | } [INFO] [stdout] 131 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 127 ~ if enemy_state == &EnemyState::IdleRight && enemy_type.is_slave() [INFO] [stdout] 128 ~ && timer.just_finished(){ [INFO] [stdout] 129 | atlas.index = (atlas.index+1)%8 + 24 [INFO] [stdout] 130 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | / if enemy_state == &EnemyState::RunFront && enemy_type.is_slave(){ [INFO] [stdout] 133 | | if timer.just_finished(){ [INFO] [stdout] 134 | | atlas.index = (atlas.index+1)%8 + 32 [INFO] [stdout] 135 | | } [INFO] [stdout] 136 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 132 ~ if enemy_state == &EnemyState::RunFront && enemy_type.is_slave() [INFO] [stdout] 133 ~ && timer.just_finished(){ [INFO] [stdout] 134 | atlas.index = (atlas.index+1)%8 + 32 [INFO] [stdout] 135 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 137 | / if enemy_state == &EnemyState::RunBack && enemy_type.is_slave(){ [INFO] [stdout] 138 | | if timer.just_finished(){ [INFO] [stdout] 139 | | atlas.index = (atlas.index+1)%8 + 40 [INFO] [stdout] 140 | | } [INFO] [stdout] 141 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 137 ~ if enemy_state == &EnemyState::RunBack && enemy_type.is_slave() [INFO] [stdout] 138 ~ && timer.just_finished(){ [INFO] [stdout] 139 | atlas.index = (atlas.index+1)%8 + 40 [INFO] [stdout] 140 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 142 | / if enemy_state == &EnemyState::RunLeft && enemy_type.is_slave(){ [INFO] [stdout] 143 | | if timer.just_finished(){ [INFO] [stdout] 144 | | atlas.index = (atlas.index+1)%8 + 48 [INFO] [stdout] 145 | | } [INFO] [stdout] 146 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 142 ~ if enemy_state == &EnemyState::RunLeft && enemy_type.is_slave() [INFO] [stdout] 143 ~ && timer.just_finished(){ [INFO] [stdout] 144 | atlas.index = (atlas.index+1)%8 + 48 [INFO] [stdout] 145 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:147:9 [INFO] [stdout] | [INFO] [stdout] 147 | / if enemy_state == &EnemyState::RunRight && enemy_type.is_slave(){ [INFO] [stdout] 148 | | if timer.just_finished(){ [INFO] [stdout] 149 | | atlas.index = (atlas.index+1)%8 + 56 [INFO] [stdout] 150 | | } [INFO] [stdout] 151 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 147 ~ if enemy_state == &EnemyState::RunRight && enemy_type.is_slave() [INFO] [stdout] 148 ~ && timer.just_finished(){ [INFO] [stdout] 149 | atlas.index = (atlas.index+1)%8 + 56 [INFO] [stdout] 150 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | / if (enemy_state == &EnemyState::IdleFront || enemy_state == &EnemyState::Alive) && !enemy_type.is_slave(){ [INFO] [stdout] 153 | | if timer.just_finished(){ [INFO] [stdout] 154 | | atlas.index = (atlas.index+1)%8 + 128 [INFO] [stdout] 155 | | } [INFO] [stdout] 156 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 152 ~ if (enemy_state == &EnemyState::IdleFront || enemy_state == &EnemyState::Alive) && !enemy_type.is_slave() [INFO] [stdout] 153 ~ && timer.just_finished(){ [INFO] [stdout] 154 | atlas.index = (atlas.index+1)%8 + 128 [INFO] [stdout] 155 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 157 | / if enemy_state == &EnemyState::IdleBack && !enemy_type.is_slave(){ [INFO] [stdout] 158 | | if timer.just_finished() { [INFO] [stdout] 159 | | atlas.index = (atlas.index+1)%8 + 136 [INFO] [stdout] 160 | | } [INFO] [stdout] 161 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 157 ~ if enemy_state == &EnemyState::IdleBack && !enemy_type.is_slave() [INFO] [stdout] 158 ~ && timer.just_finished() { [INFO] [stdout] 159 | atlas.index = (atlas.index+1)%8 + 136 [INFO] [stdout] 160 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 162 | / if enemy_state == &EnemyState::IdleLeft && !enemy_type.is_slave(){ [INFO] [stdout] 163 | | if timer.just_finished(){ [INFO] [stdout] 164 | | atlas.index = (atlas.index+1)%8 + 144 [INFO] [stdout] 165 | | } [INFO] [stdout] 166 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 162 ~ if enemy_state == &EnemyState::IdleLeft && !enemy_type.is_slave() [INFO] [stdout] 163 ~ && timer.just_finished(){ [INFO] [stdout] 164 | atlas.index = (atlas.index+1)%8 + 144 [INFO] [stdout] 165 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 167 | / if enemy_state == &EnemyState::IdleRight && !enemy_type.is_slave(){ [INFO] [stdout] 168 | | if timer.just_finished(){ [INFO] [stdout] 169 | | atlas.index = (atlas.index+1)%8 + 152 [INFO] [stdout] 170 | | } [INFO] [stdout] 171 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 167 ~ if enemy_state == &EnemyState::IdleRight && !enemy_type.is_slave() [INFO] [stdout] 168 ~ && timer.just_finished(){ [INFO] [stdout] 169 | atlas.index = (atlas.index+1)%8 + 152 [INFO] [stdout] 170 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | / if enemy_state == &EnemyState::RunFront && !enemy_type.is_slave(){ [INFO] [stdout] 173 | | if timer.just_finished(){ [INFO] [stdout] 174 | | atlas.index = (atlas.index+1)%8 + 160 [INFO] [stdout] 175 | | } [INFO] [stdout] 176 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 172 ~ if enemy_state == &EnemyState::RunFront && !enemy_type.is_slave() [INFO] [stdout] 173 ~ && timer.just_finished(){ [INFO] [stdout] 174 | atlas.index = (atlas.index+1)%8 + 160 [INFO] [stdout] 175 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 177 | / if enemy_state == &EnemyState::RunBack && !enemy_type.is_slave(){ [INFO] [stdout] 178 | | if timer.just_finished(){ [INFO] [stdout] 179 | | atlas.index = (atlas.index+1)%8 + 168 [INFO] [stdout] 180 | | } [INFO] [stdout] 181 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 177 ~ if enemy_state == &EnemyState::RunBack && !enemy_type.is_slave() [INFO] [stdout] 178 ~ && timer.just_finished(){ [INFO] [stdout] 179 | atlas.index = (atlas.index+1)%8 + 168 [INFO] [stdout] 180 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:182:9 [INFO] [stdout] | [INFO] [stdout] 182 | / if enemy_state == &EnemyState::RunLeft && !enemy_type.is_slave(){ [INFO] [stdout] 183 | | if timer.just_finished(){ [INFO] [stdout] 184 | | atlas.index = (atlas.index+1)%8 + 176 [INFO] [stdout] 185 | | } [INFO] [stdout] 186 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 182 ~ if enemy_state == &EnemyState::RunLeft && !enemy_type.is_slave() [INFO] [stdout] 183 ~ && timer.just_finished(){ [INFO] [stdout] 184 | atlas.index = (atlas.index+1)%8 + 176 [INFO] [stdout] 185 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | / if enemy_state == &EnemyState::RunRight && !enemy_type.is_slave(){ [INFO] [stdout] 188 | | if timer.just_finished(){ [INFO] [stdout] 189 | | atlas.index = (atlas.index+1)%8 + 184 [INFO] [stdout] 190 | | } [INFO] [stdout] 191 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 187 ~ if enemy_state == &EnemyState::RunRight && !enemy_type.is_slave() [INFO] [stdout] 188 ~ && timer.just_finished(){ [INFO] [stdout] 189 | atlas.index = (atlas.index+1)%8 + 184 [INFO] [stdout] 190 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/enemy.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | / return match random_enemy { [INFO] [stdout] 205 | | 0 => EnemyType::MiniBoss, [INFO] [stdout] 206 | | _ => EnemyType::Slave [INFO] [stdout] 207 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 204 ~ match random_enemy { [INFO] [stdout] 205 + 0 => EnemyType::MiniBoss, [INFO] [stdout] 206 + _ => EnemyType::Slave [INFO] [stdout] 207 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/enemy.rs:216:9 [INFO] [stdout] | [INFO] [stdout] 216 | / match self { [INFO] [stdout] 217 | | EnemyType::Slave => true, [INFO] [stdout] 218 | | _ => false [INFO] [stdout] 219 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 216 - match self { [INFO] [stdout] 217 - EnemyType::Slave => true, [INFO] [stdout] 218 - _ => false [INFO] [stdout] 219 - } [INFO] [stdout] 216 + matches!(self, EnemyType::Slave) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/enemy.rs:223:1 [INFO] [stdout] | [INFO] [stdout] 223 | / impl Default for GlobalTextureAtlas { [INFO] [stdout] 224 | | fn default() -> Self { [INFO] [stdout] 225 | | Self { [INFO] [stdout] 226 | | layout: None, [INFO] [stdout] ... | [INFO] [stdout] 229 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 17 + #[derive(Default)] [INFO] [stdout] 18 | pub struct GlobalTextureAtlas { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/enemy.rs:256:22 [INFO] [stdout] | [INFO] [stdout] 256 | mut enemy_query: Query<(&mut Transform, &mut EnemyState), (With,Without)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/enemy.rs:278:16 [INFO] [stdout] | [INFO] [stdout] 278 | if 0.0 <= angle && 25f32 >= angle || 335f32 <= angle && 360f32 >= angle { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0.0..=25f32).contains(&angle)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/enemy.rs:278:50 [INFO] [stdout] | [INFO] [stdout] 278 | if 0.0 <= angle && 25f32 >= angle || 335f32 <= angle && 360f32 >= angle { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(335f32..=360f32).contains(&angle)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/enemy.rs:281:16 [INFO] [stdout] | [INFO] [stdout] 281 | if 26f32 <= angle && 155f32 >= angle{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(26f32..=155f32).contains(&angle)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/enemy.rs:284:16 [INFO] [stdout] | [INFO] [stdout] 284 | if 156f32 <= angle && 205f32 >= angle { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(156f32..=205f32).contains(&angle)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/enemy.rs:287:16 [INFO] [stdout] | [INFO] [stdout] 287 | if 206f32 <= angle && 334f32 >= angle{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(206f32..=334f32).contains(&angle)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/assets_loader.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | / impl Default for TextureGameAssets{ [INFO] [stdout] 23 | | fn default() -> Self { [INFO] [stdout] 24 | | Self{ [INFO] [stdout] 25 | | player_handler: None, [INFO] [stdout] ... | [INFO] [stdout] 32 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 5 + #[derive(Default)] [INFO] [stdout] 6 | pub struct TextureGameAssets{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/main.rs:39:22 [INFO] [stdout] | [INFO] [stdout] 39 | .add_plugins(PanCamPlugin::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 39 - .add_plugins(PanCamPlugin::default()) [INFO] [stdout] 39 + .add_plugins(PanCamPlugin) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `GameStatus` is never used [INFO] [stdout] --> src/main.rs:19:6 [INFO] [stdout] | [INFO] [stdout] 19 | enum GameStatus{ [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PlayerCollider` is never constructed [INFO] [stdout] --> src/player.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | struct PlayerCollider; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/player.rs:22:26 [INFO] [stdout] | [INFO] [stdout] 22 | struct PlayerSpriteIndex(usize); [INFO] [stdout] | ----------------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Walk`, `Run`, `DeadFront`, `DeadBack`, `DeadLeft`, and `DeadRight` are never constructed [INFO] [stdout] --> src/player.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 27 | enum PlayerState { [INFO] [stdout] | ----------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 34 | Walk, [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 39 | Run, [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 44 | DeadFront, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 45 | DeadBack, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 46 | DeadLeft, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 47 | DeadRight, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PlayerState` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `last` is never read [INFO] [stdout] --> src/player.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 67 | struct AnimationIndices { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 68 | first: usize, [INFO] [stdout] 69 | last: usize [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `is_alive`, `is_walking`, and `is_running` are never used [INFO] [stdout] --> src/player.rs:288:8 [INFO] [stdout] | [INFO] [stdout] 287 | impl CurrentPlayerState { [INFO] [stdout] | ----------------------- methods in this implementation [INFO] [stdout] 288 | fn is_alive(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 291 | fn is_walking(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 310 | fn is_running(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/enemy.rs:30:26 [INFO] [stdout] | [INFO] [stdout] 30 | struct EnemyCurrentState(EnemyState); [INFO] [stdout] | ----------------- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Dead` is never constructed [INFO] [stdout] --> src/enemy.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 33 | enum EnemyState { [INFO] [stdout] | ---------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 44 | Dead, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EnemyState` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set_state` is never used [INFO] [stdout] --> src/enemy.rs:195:8 [INFO] [stdout] | [INFO] [stdout] 194 | impl EnemyCurrentState{ [INFO] [stdout] | ---------------------- method in this implementation [INFO] [stdout] 195 | fn set_state(&mut self,new_state : EnemyState){ [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/player.rs:244:9 [INFO] [stdout] | [INFO] [stdout] 244 | / if player_state.0 == PlayerState::IdleBack || player_state.0 == PlayerState::Alive{ [INFO] [stdout] 245 | | if timer.just_finished(){ [INFO] [stdout] 246 | | atlas.index = (atlas.index+1)%8 [INFO] [stdout] 247 | | } [INFO] [stdout] 248 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 244 ~ if (player_state.0 == PlayerState::IdleBack || player_state.0 == PlayerState::Alive){ [INFO] [stdout] 245 ~ && timer.just_finished(){ [INFO] [stdout] 246 | atlas.index = (atlas.index+1)%8 [INFO] [stdout] 247 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/player.rs:249:9 [INFO] [stdout] | [INFO] [stdout] 249 | / if player_state.0 == PlayerState::IdleFront{ [INFO] [stdout] 250 | | if timer.just_finished() { [INFO] [stdout] 251 | | atlas.index = (atlas.index+1)%8 + 8 [INFO] [stdout] 252 | | } [INFO] [stdout] 253 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 249 ~ if player_state.0 == PlayerState::IdleFront [INFO] [stdout] 250 ~ && timer.just_finished() { [INFO] [stdout] 251 | atlas.index = (atlas.index+1)%8 + 8 [INFO] [stdout] 252 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/player.rs:254:9 [INFO] [stdout] | [INFO] [stdout] 254 | / if player_state.0 == PlayerState::IdleLeft { [INFO] [stdout] 255 | | if timer.just_finished(){ [INFO] [stdout] 256 | | atlas.index = (atlas.index+1)%8 + 16 [INFO] [stdout] 257 | | } [INFO] [stdout] 258 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 254 ~ if player_state.0 == PlayerState::IdleLeft [INFO] [stdout] 255 ~ && timer.just_finished(){ [INFO] [stdout] 256 | atlas.index = (atlas.index+1)%8 + 16 [INFO] [stdout] 257 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/player.rs:259:9 [INFO] [stdout] | [INFO] [stdout] 259 | / if player_state.0 == PlayerState::IdleRight { [INFO] [stdout] 260 | | if timer.just_finished(){ [INFO] [stdout] 261 | | atlas.index = (atlas.index+1)%8 + 24 [INFO] [stdout] 262 | | } [INFO] [stdout] 263 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 259 ~ if player_state.0 == PlayerState::IdleRight [INFO] [stdout] 260 ~ && timer.just_finished(){ [INFO] [stdout] 261 | atlas.index = (atlas.index+1)%8 + 24 [INFO] [stdout] 262 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/player.rs:264:9 [INFO] [stdout] | [INFO] [stdout] 264 | / if player_state.0 == PlayerState::WalkBack || player_state.0 == PlayerState::RunBack{ [INFO] [stdout] 265 | | if timer.just_finished(){ [INFO] [stdout] 266 | | atlas.index = (atlas.index+1)%8 + 32 [INFO] [stdout] 267 | | } [INFO] [stdout] 268 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 264 ~ if (player_state.0 == PlayerState::WalkBack || player_state.0 == PlayerState::RunBack){ [INFO] [stdout] 265 ~ && timer.just_finished(){ [INFO] [stdout] 266 | atlas.index = (atlas.index+1)%8 + 32 [INFO] [stdout] 267 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/player.rs:269:9 [INFO] [stdout] | [INFO] [stdout] 269 | / if player_state.0 == PlayerState::WalkFront || player_state.0 == PlayerState::RunFront{ [INFO] [stdout] 270 | | if timer.just_finished(){ [INFO] [stdout] 271 | | atlas.index = (atlas.index+1)%8 + 40 [INFO] [stdout] 272 | | } [INFO] [stdout] 273 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 269 ~ if (player_state.0 == PlayerState::WalkFront || player_state.0 == PlayerState::RunFront){ [INFO] [stdout] 270 ~ && timer.just_finished(){ [INFO] [stdout] 271 | atlas.index = (atlas.index+1)%8 + 40 [INFO] [stdout] 272 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/player.rs:274:9 [INFO] [stdout] | [INFO] [stdout] 274 | / if player_state.0 == PlayerState::WalkLeft || player_state.0 == PlayerState::RunLeft{ [INFO] [stdout] 275 | | if timer.just_finished(){ [INFO] [stdout] 276 | | atlas.index = (atlas.index+1)%8 + 48 [INFO] [stdout] 277 | | } [INFO] [stdout] 278 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 274 ~ if (player_state.0 == PlayerState::WalkLeft || player_state.0 == PlayerState::RunLeft){ [INFO] [stdout] 275 ~ && timer.just_finished(){ [INFO] [stdout] 276 | atlas.index = (atlas.index+1)%8 + 48 [INFO] [stdout] 277 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/player.rs:279:9 [INFO] [stdout] | [INFO] [stdout] 279 | / if player_state.0 == PlayerState::WalkRight || player_state.0 == PlayerState::RunRight{ [INFO] [stdout] 280 | | if timer.just_finished(){ [INFO] [stdout] 281 | | atlas.index = (atlas.index+1)%8 + 56 [INFO] [stdout] 282 | | } [INFO] [stdout] 283 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 279 ~ if (player_state.0 == PlayerState::WalkRight || player_state.0 == PlayerState::RunRight){ [INFO] [stdout] 280 ~ && timer.just_finished(){ [INFO] [stdout] 281 | atlas.index = (atlas.index+1)%8 + 56 [INFO] [stdout] 282 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/player.rs:292:9 [INFO] [stdout] | [INFO] [stdout] 292 | / match self.0 { [INFO] [stdout] 293 | | PlayerState::Walk => true, [INFO] [stdout] 294 | | PlayerState::WalkBack => true, [INFO] [stdout] 295 | | PlayerState::WalkFront => true, [INFO] [stdout] ... | [INFO] [stdout] 298 | | _ => false [INFO] [stdout] 299 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 292 - match self.0 { [INFO] [stdout] 293 - PlayerState::Walk => true, [INFO] [stdout] 294 - PlayerState::WalkBack => true, [INFO] [stdout] 295 - PlayerState::WalkFront => true, [INFO] [stdout] 296 - PlayerState::WalkLeft => true, [INFO] [stdout] 297 - PlayerState::WalkRight => true, [INFO] [stdout] 298 - _ => false [INFO] [stdout] 299 - } [INFO] [stdout] 292 + matches!(self.0, PlayerState::Walk | PlayerState::WalkBack | PlayerState::WalkFront | PlayerState::WalkLeft | PlayerState::WalkRight) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/player.rs:302:9 [INFO] [stdout] | [INFO] [stdout] 302 | / match self.0{ [INFO] [stdout] 303 | | PlayerState::DeadFront => true, [INFO] [stdout] 304 | | PlayerState::DeadBack => true, [INFO] [stdout] 305 | | PlayerState::DeadLeft => true, [INFO] [stdout] 306 | | PlayerState::DeadRight => true, [INFO] [stdout] 307 | | _ => false [INFO] [stdout] 308 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 302 - match self.0{ [INFO] [stdout] 303 - PlayerState::DeadFront => true, [INFO] [stdout] 304 - PlayerState::DeadBack => true, [INFO] [stdout] 305 - PlayerState::DeadLeft => true, [INFO] [stdout] 306 - PlayerState::DeadRight => true, [INFO] [stdout] 307 - _ => false [INFO] [stdout] 308 - } [INFO] [stdout] 302 + matches!(self.0, PlayerState::DeadFront | PlayerState::DeadBack | PlayerState::DeadLeft | PlayerState::DeadRight) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/player.rs:311:9 [INFO] [stdout] | [INFO] [stdout] 311 | / match self.0 { [INFO] [stdout] 312 | | PlayerState::Run => true, [INFO] [stdout] 313 | | PlayerState::RunBack => true, [INFO] [stdout] 314 | | PlayerState::RunFront => true, [INFO] [stdout] ... | [INFO] [stdout] 317 | | _ => false [INFO] [stdout] 318 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 311 - match self.0 { [INFO] [stdout] 312 - PlayerState::Run => true, [INFO] [stdout] 313 - PlayerState::RunBack => true, [INFO] [stdout] 314 - PlayerState::RunFront => true, [INFO] [stdout] 315 - PlayerState::RunLeft => true, [INFO] [stdout] 316 - PlayerState::RunRight => true, [INFO] [stdout] 317 - _ => false [INFO] [stdout] 318 - } [INFO] [stdout] 311 + matches!(self.0, PlayerState::Run | PlayerState::RunBack | PlayerState::RunFront | PlayerState::RunLeft | PlayerState::RunRight) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/terrain.rs:81:16 [INFO] [stdout] | [INFO] [stdout] 81 | if noise >= 0.31 && noise < 0.36{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0.31..0.36).contains(&noise)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/terrain.rs:90:16 [INFO] [stdout] | [INFO] [stdout] 90 | if noise >= 0.23 && noise < 0.31 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0.23..0.31).contains(&noise)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/terrain.rs:99:16 [INFO] [stdout] | [INFO] [stdout] 99 | if noise >= 0.36 && noise < 0.5 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0.36..0.5).contains(&noise)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/terrain.rs:108:16 [INFO] [stdout] | [INFO] [stdout] 108 | if noise >= 0.5 && noise < 0.64 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0.5..0.64).contains(&noise)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/terrain.rs:142:12 [INFO] [stdout] | [INFO] [stdout] 142 | if bioma.is_water == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `bioma.is_water` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/terrain.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 211 | / if *watertype == WaterType::Normal{ [INFO] [stdout] 212 | | if timer.just_finished(){ [INFO] [stdout] 213 | | atlas.index = (atlas.index+1)%4; [INFO] [stdout] 214 | | } [INFO] [stdout] 215 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 211 ~ if *watertype == WaterType::Normal [INFO] [stdout] 212 ~ && timer.just_finished(){ [INFO] [stdout] 213 | atlas.index = (atlas.index+1)%4; [INFO] [stdout] 214 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/terrain.rs:216:9 [INFO] [stdout] | [INFO] [stdout] 216 | / if *watertype == WaterType::Deep{ [INFO] [stdout] 217 | | if timer.just_finished(){ [INFO] [stdout] 218 | | atlas.index = (atlas.index+1)%4 +4; [INFO] [stdout] 219 | | } [INFO] [stdout] 220 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 216 ~ if *watertype == WaterType::Deep [INFO] [stdout] 217 ~ && timer.just_finished(){ [INFO] [stdout] 218 | atlas.index = (atlas.index+1)%4 +4; [INFO] [stdout] 219 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/enemy.rs:107:17 [INFO] [stdout] | [INFO] [stdout] 107 | mut query : Query<(&mut crate::AnimationTimer, &mut TextureAtlas, &EnemyType, &EnemyState),(With,Without)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | / if (enemy_state == &EnemyState::IdleFront || enemy_state == &EnemyState::Alive) && enemy_type.is_slave(){ [INFO] [stdout] 113 | | if timer.just_finished(){ [INFO] [stdout] 114 | | atlas.index = (atlas.index+1)%8 [INFO] [stdout] 115 | | } [INFO] [stdout] 116 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 112 ~ if (enemy_state == &EnemyState::IdleFront || enemy_state == &EnemyState::Alive) && enemy_type.is_slave() [INFO] [stdout] 113 ~ && timer.just_finished(){ [INFO] [stdout] 114 | atlas.index = (atlas.index+1)%8 [INFO] [stdout] 115 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | / if enemy_state == &EnemyState::IdleBack && enemy_type.is_slave(){ [INFO] [stdout] 118 | | if timer.just_finished() { [INFO] [stdout] 119 | | atlas.index = (atlas.index+1)%8 + 8 [INFO] [stdout] 120 | | } [INFO] [stdout] 121 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 117 ~ if enemy_state == &EnemyState::IdleBack && enemy_type.is_slave() [INFO] [stdout] 118 ~ && timer.just_finished() { [INFO] [stdout] 119 | atlas.index = (atlas.index+1)%8 + 8 [INFO] [stdout] 120 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 122 | / if enemy_state == &EnemyState::IdleLeft && enemy_type.is_slave(){ [INFO] [stdout] 123 | | if timer.just_finished(){ [INFO] [stdout] 124 | | atlas.index = (atlas.index+1)%8 + 16 [INFO] [stdout] 125 | | } [INFO] [stdout] 126 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 122 ~ if enemy_state == &EnemyState::IdleLeft && enemy_type.is_slave() [INFO] [stdout] 123 ~ && timer.just_finished(){ [INFO] [stdout] 124 | atlas.index = (atlas.index+1)%8 + 16 [INFO] [stdout] 125 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 127 | / if enemy_state == &EnemyState::IdleRight && enemy_type.is_slave(){ [INFO] [stdout] 128 | | if timer.just_finished(){ [INFO] [stdout] 129 | | atlas.index = (atlas.index+1)%8 + 24 [INFO] [stdout] 130 | | } [INFO] [stdout] 131 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 127 ~ if enemy_state == &EnemyState::IdleRight && enemy_type.is_slave() [INFO] [stdout] 128 ~ && timer.just_finished(){ [INFO] [stdout] 129 | atlas.index = (atlas.index+1)%8 + 24 [INFO] [stdout] 130 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | / if enemy_state == &EnemyState::RunFront && enemy_type.is_slave(){ [INFO] [stdout] 133 | | if timer.just_finished(){ [INFO] [stdout] 134 | | atlas.index = (atlas.index+1)%8 + 32 [INFO] [stdout] 135 | | } [INFO] [stdout] 136 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 132 ~ if enemy_state == &EnemyState::RunFront && enemy_type.is_slave() [INFO] [stdout] 133 ~ && timer.just_finished(){ [INFO] [stdout] 134 | atlas.index = (atlas.index+1)%8 + 32 [INFO] [stdout] 135 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 137 | / if enemy_state == &EnemyState::RunBack && enemy_type.is_slave(){ [INFO] [stdout] 138 | | if timer.just_finished(){ [INFO] [stdout] 139 | | atlas.index = (atlas.index+1)%8 + 40 [INFO] [stdout] 140 | | } [INFO] [stdout] 141 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 137 ~ if enemy_state == &EnemyState::RunBack && enemy_type.is_slave() [INFO] [stdout] 138 ~ && timer.just_finished(){ [INFO] [stdout] 139 | atlas.index = (atlas.index+1)%8 + 40 [INFO] [stdout] 140 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 142 | / if enemy_state == &EnemyState::RunLeft && enemy_type.is_slave(){ [INFO] [stdout] 143 | | if timer.just_finished(){ [INFO] [stdout] 144 | | atlas.index = (atlas.index+1)%8 + 48 [INFO] [stdout] 145 | | } [INFO] [stdout] 146 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 142 ~ if enemy_state == &EnemyState::RunLeft && enemy_type.is_slave() [INFO] [stdout] 143 ~ && timer.just_finished(){ [INFO] [stdout] 144 | atlas.index = (atlas.index+1)%8 + 48 [INFO] [stdout] 145 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:147:9 [INFO] [stdout] | [INFO] [stdout] 147 | / if enemy_state == &EnemyState::RunRight && enemy_type.is_slave(){ [INFO] [stdout] 148 | | if timer.just_finished(){ [INFO] [stdout] 149 | | atlas.index = (atlas.index+1)%8 + 56 [INFO] [stdout] 150 | | } [INFO] [stdout] 151 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 147 ~ if enemy_state == &EnemyState::RunRight && enemy_type.is_slave() [INFO] [stdout] 148 ~ && timer.just_finished(){ [INFO] [stdout] 149 | atlas.index = (atlas.index+1)%8 + 56 [INFO] [stdout] 150 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | / if (enemy_state == &EnemyState::IdleFront || enemy_state == &EnemyState::Alive) && !enemy_type.is_slave(){ [INFO] [stdout] 153 | | if timer.just_finished(){ [INFO] [stdout] 154 | | atlas.index = (atlas.index+1)%8 + 128 [INFO] [stdout] 155 | | } [INFO] [stdout] 156 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 152 ~ if (enemy_state == &EnemyState::IdleFront || enemy_state == &EnemyState::Alive) && !enemy_type.is_slave() [INFO] [stdout] 153 ~ && timer.just_finished(){ [INFO] [stdout] 154 | atlas.index = (atlas.index+1)%8 + 128 [INFO] [stdout] 155 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 157 | / if enemy_state == &EnemyState::IdleBack && !enemy_type.is_slave(){ [INFO] [stdout] 158 | | if timer.just_finished() { [INFO] [stdout] 159 | | atlas.index = (atlas.index+1)%8 + 136 [INFO] [stdout] 160 | | } [INFO] [stdout] 161 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 157 ~ if enemy_state == &EnemyState::IdleBack && !enemy_type.is_slave() [INFO] [stdout] 158 ~ && timer.just_finished() { [INFO] [stdout] 159 | atlas.index = (atlas.index+1)%8 + 136 [INFO] [stdout] 160 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 162 | / if enemy_state == &EnemyState::IdleLeft && !enemy_type.is_slave(){ [INFO] [stdout] 163 | | if timer.just_finished(){ [INFO] [stdout] 164 | | atlas.index = (atlas.index+1)%8 + 144 [INFO] [stdout] 165 | | } [INFO] [stdout] 166 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 162 ~ if enemy_state == &EnemyState::IdleLeft && !enemy_type.is_slave() [INFO] [stdout] 163 ~ && timer.just_finished(){ [INFO] [stdout] 164 | atlas.index = (atlas.index+1)%8 + 144 [INFO] [stdout] 165 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 167 | / if enemy_state == &EnemyState::IdleRight && !enemy_type.is_slave(){ [INFO] [stdout] 168 | | if timer.just_finished(){ [INFO] [stdout] 169 | | atlas.index = (atlas.index+1)%8 + 152 [INFO] [stdout] 170 | | } [INFO] [stdout] 171 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 167 ~ if enemy_state == &EnemyState::IdleRight && !enemy_type.is_slave() [INFO] [stdout] 168 ~ && timer.just_finished(){ [INFO] [stdout] 169 | atlas.index = (atlas.index+1)%8 + 152 [INFO] [stdout] 170 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | / if enemy_state == &EnemyState::RunFront && !enemy_type.is_slave(){ [INFO] [stdout] 173 | | if timer.just_finished(){ [INFO] [stdout] 174 | | atlas.index = (atlas.index+1)%8 + 160 [INFO] [stdout] 175 | | } [INFO] [stdout] 176 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 172 ~ if enemy_state == &EnemyState::RunFront && !enemy_type.is_slave() [INFO] [stdout] 173 ~ && timer.just_finished(){ [INFO] [stdout] 174 | atlas.index = (atlas.index+1)%8 + 160 [INFO] [stdout] 175 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 177 | / if enemy_state == &EnemyState::RunBack && !enemy_type.is_slave(){ [INFO] [stdout] 178 | | if timer.just_finished(){ [INFO] [stdout] 179 | | atlas.index = (atlas.index+1)%8 + 168 [INFO] [stdout] 180 | | } [INFO] [stdout] 181 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 177 ~ if enemy_state == &EnemyState::RunBack && !enemy_type.is_slave() [INFO] [stdout] 178 ~ && timer.just_finished(){ [INFO] [stdout] 179 | atlas.index = (atlas.index+1)%8 + 168 [INFO] [stdout] 180 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:182:9 [INFO] [stdout] | [INFO] [stdout] 182 | / if enemy_state == &EnemyState::RunLeft && !enemy_type.is_slave(){ [INFO] [stdout] 183 | | if timer.just_finished(){ [INFO] [stdout] 184 | | atlas.index = (atlas.index+1)%8 + 176 [INFO] [stdout] 185 | | } [INFO] [stdout] 186 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 182 ~ if enemy_state == &EnemyState::RunLeft && !enemy_type.is_slave() [INFO] [stdout] 183 ~ && timer.just_finished(){ [INFO] [stdout] 184 | atlas.index = (atlas.index+1)%8 + 176 [INFO] [stdout] 185 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | / if enemy_state == &EnemyState::RunRight && !enemy_type.is_slave(){ [INFO] [stdout] 188 | | if timer.just_finished(){ [INFO] [stdout] 189 | | atlas.index = (atlas.index+1)%8 + 184 [INFO] [stdout] 190 | | } [INFO] [stdout] 191 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 187 ~ if enemy_state == &EnemyState::RunRight && !enemy_type.is_slave() [INFO] [stdout] 188 ~ && timer.just_finished(){ [INFO] [stdout] 189 | atlas.index = (atlas.index+1)%8 + 184 [INFO] [stdout] 190 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/enemy.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | / return match random_enemy { [INFO] [stdout] 205 | | 0 => EnemyType::MiniBoss, [INFO] [stdout] 206 | | _ => EnemyType::Slave [INFO] [stdout] 207 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 204 ~ match random_enemy { [INFO] [stdout] 205 + 0 => EnemyType::MiniBoss, [INFO] [stdout] 206 + _ => EnemyType::Slave [INFO] [stdout] 207 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/enemy.rs:216:9 [INFO] [stdout] | [INFO] [stdout] 216 | / match self { [INFO] [stdout] 217 | | EnemyType::Slave => true, [INFO] [stdout] 218 | | _ => false [INFO] [stdout] 219 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 216 - match self { [INFO] [stdout] 217 - EnemyType::Slave => true, [INFO] [stdout] 218 - _ => false [INFO] [stdout] 219 - } [INFO] [stdout] 216 + matches!(self, EnemyType::Slave) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/enemy.rs:223:1 [INFO] [stdout] | [INFO] [stdout] 223 | / impl Default for GlobalTextureAtlas { [INFO] [stdout] 224 | | fn default() -> Self { [INFO] [stdout] 225 | | Self { [INFO] [stdout] 226 | | layout: None, [INFO] [stdout] ... | [INFO] [stdout] 229 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 17 + #[derive(Default)] [INFO] [stdout] 18 | pub struct GlobalTextureAtlas { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/enemy.rs:256:22 [INFO] [stdout] | [INFO] [stdout] 256 | mut enemy_query: Query<(&mut Transform, &mut EnemyState), (With,Without)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/enemy.rs:278:16 [INFO] [stdout] | [INFO] [stdout] 278 | if 0.0 <= angle && 25f32 >= angle || 335f32 <= angle && 360f32 >= angle { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0.0..=25f32).contains(&angle)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/enemy.rs:278:50 [INFO] [stdout] | [INFO] [stdout] 278 | if 0.0 <= angle && 25f32 >= angle || 335f32 <= angle && 360f32 >= angle { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(335f32..=360f32).contains(&angle)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/enemy.rs:281:16 [INFO] [stdout] | [INFO] [stdout] 281 | if 26f32 <= angle && 155f32 >= angle{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(26f32..=155f32).contains(&angle)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/enemy.rs:284:16 [INFO] [stdout] | [INFO] [stdout] 284 | if 156f32 <= angle && 205f32 >= angle { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(156f32..=205f32).contains(&angle)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/enemy.rs:287:16 [INFO] [stdout] | [INFO] [stdout] 287 | if 206f32 <= angle && 334f32 >= angle{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(206f32..=334f32).contains(&angle)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/assets_loader.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | / impl Default for TextureGameAssets{ [INFO] [stdout] 23 | | fn default() -> Self { [INFO] [stdout] 24 | | Self{ [INFO] [stdout] 25 | | player_handler: None, [INFO] [stdout] ... | [INFO] [stdout] 32 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 5 + #[derive(Default)] [INFO] [stdout] 6 | pub struct TextureGameAssets{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/main.rs:39:22 [INFO] [stdout] | [INFO] [stdout] 39 | .add_plugins(PanCamPlugin::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 39 - .add_plugins(PanCamPlugin::default()) [INFO] [stdout] 39 + .add_plugins(PanCamPlugin) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [optimized + debuginfo] target(s) in 3m 16s [INFO] running `Command { std: "docker" "inspect" "9fc89f30fa5ce70e68c5a9c4224e0d04fb1377a3b14d6d57f2bde43887cdf402", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9fc89f30fa5ce70e68c5a9c4224e0d04fb1377a3b14d6d57f2bde43887cdf402", kill_on_drop: false }` [INFO] [stdout] 9fc89f30fa5ce70e68c5a9c4224e0d04fb1377a3b14d6d57f2bde43887cdf402