[INFO] cloning repository https://github.com/DKormann/rubox [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DKormann/rubox" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDKormann%2Frubox", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDKormann%2Frubox'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 41f51d639d807786bcba4ef0b978ff9b1fe3e2b0 [INFO] linting DKormann/rubox against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDKormann%2Frubox" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/DKormann/rubox [INFO] finished tweaking git repo https://github.com/DKormann/rubox [INFO] tweaked toml for git repo https://github.com/DKormann/rubox written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/DKormann/rubox on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/DKormann/rubox already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pest_derive v2.8.1 [INFO] [stderr] Downloaded pest_generator v2.8.1 [INFO] [stderr] Downloaded proc-macro2 v1.0.96 [INFO] [stderr] Downloaded sha2 v0.10.9 [INFO] [stderr] Downloaded rand_xoshiro v0.6.0 [INFO] [stderr] Downloaded sized-chunks v0.6.5 [INFO] [stderr] Downloaded ucd-trie v0.1.7 [INFO] [stderr] Downloaded pest_meta v2.8.1 [INFO] [stderr] Downloaded pest v2.8.1 [INFO] [stderr] Downloaded bitmaps v2.1.0 [INFO] [stderr] Downloaded im v15.1.0 [INFO] [stderr] Downloaded libc v0.2.175 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a5ee556be0b2c04d9e6d6c9d150a20914ff03606685d97209d210460b6bc7f5b [INFO] running `Command { std: "docker" "start" "-a" "a5ee556be0b2c04d9e6d6c9d150a20914ff03606685d97209d210460b6bc7f5b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a5ee556be0b2c04d9e6d6c9d150a20914ff03606685d97209d210460b6bc7f5b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a5ee556be0b2c04d9e6d6c9d150a20914ff03606685d97209d210460b6bc7f5b", kill_on_drop: false }` [INFO] [stdout] a5ee556be0b2c04d9e6d6c9d150a20914ff03606685d97209d210460b6bc7f5b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 80b9bd5d4c667a3e781cf43ea5d3d07ae903a917df1726ebb547f9b4f3c914f8 [INFO] running `Command { std: "docker" "start" "-a" "80b9bd5d4c667a3e781cf43ea5d3d07ae903a917df1726ebb547f9b4f3c914f8", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.96 [INFO] [stderr] Compiling unicode-ident v1.0.18 [INFO] [stderr] Compiling thiserror v2.0.12 [INFO] [stderr] Compiling typenum v1.18.0 [INFO] [stderr] Compiling memchr v2.7.5 [INFO] [stderr] Compiling ucd-trie v0.1.7 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_xoshiro v0.6.0 [INFO] [stderr] Compiling im v15.1.0 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking bitmaps v2.1.0 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Checking sized-chunks v0.6.5 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Compiling pest v2.8.1 [INFO] [stderr] Compiling pest_meta v2.8.1 [INFO] [stderr] Compiling pest_generator v2.8.1 [INFO] [stderr] Compiling pest_derive v2.8.1 [INFO] [stderr] Checking rubox v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> src/runtime.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | / #[allow(unreachable_code)] [INFO] [stdout] 3 | | [INFO] [stdout] | |_^ [INFO] [stdout] 4 | use im::HashMap; [INFO] [stdout] | - the attribute applies to this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the attribute should apply to the parent module use an inner attribute [INFO] [stdout] | [INFO] [stdout] 1 ~ #![allow(dead_code)] [INFO] [stdout] 2 ~ #![allow(unreachable_code)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> src/runtime.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | / #[allow(unreachable_code)] [INFO] [stdout] 3 | | [INFO] [stdout] | |_^ [INFO] [stdout] 4 | use im::HashMap; [INFO] [stdout] | - the attribute applies to this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the attribute should apply to the parent module use an inner attribute [INFO] [stdout] | [INFO] [stdout] 1 ~ #![allow(dead_code)] [INFO] [stdout] 2 ~ #![allow(unreachable_code)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/parser.rs:25:30 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn parse(input: &str) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 272 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/parser.rs:32:53 [INFO] [stdout] | [INFO] [stdout] 32 | fn build_expr(pair: pest::iterators::Pair) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 272 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/parser.rs:129:56 [INFO] [stdout] | [INFO] [stdout] 129 | fn build_arglist(pair: pest::iterators::Pair) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 272 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/parser.rs:138:56 [INFO] [stdout] | [INFO] [stdout] 138 | fn build_literal(pair: pest::iterators::Pair) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 272 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/parser.rs:188:54 [INFO] [stdout] | [INFO] [stdout] 188 | fn build_array(pair: pest::iterators::Pair) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 272 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/parser.rs:196:55 [INFO] [stdout] | [INFO] [stdout] 196 | fn build_object(pair: pest::iterators::Pair) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 272 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/runtime.rs:32:32 [INFO] [stdout] | [INFO] [stdout] 32 | Value::Builtin(builtin) => format!("[Builtin]"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"[Builtin]".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/runtime.rs:47:96 [INFO] [stdout] | [INFO] [stdout] 47 | let res = match op { "==" => a == b, "!=" => a != b, ">" => a && !b, "<" => !a && b, ">=" => a || (!a && !b), "<=" => !a || (a && ... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 47 - let res = match op { "==" => a == b, "!=" => a != b, ">" => a && !b, "<" => !a && b, ">=" => a || (!a && !b), "<=" => !a || (a && b), _ => unreachable!() }; [INFO] [stdout] 47 + let res = match op { "==" => a == b, "!=" => a != b, ">" => a && !b, "<" => !a && b, ">=" => !(!a && b), "<=" => !a || (a && b), _ => unreachable!() }; [INFO] [stdout] | [INFO] [stdout] 47 - let res = match op { "==" => a == b, "!=" => a != b, ">" => a && !b, "<" => !a && b, ">=" => a || (!a && !b), "<=" => !a || (a && b), _ => unreachable!() }; [INFO] [stdout] 47 + let res = match op { "==" => a == b, "!=" => a != b, ">" => a && !b, "<" => !a && b, ">=" => a || !b, "<=" => !a || (a && b), _ => unreachable!() }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/runtime.rs:47:121 [INFO] [stdout] | [INFO] [stdout] 47 | ... && !b, "<" => !a && b, ">=" => a || (!a && !b), "<=" => !a || (a && b), _ => unreachable!() }; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 47 - let res = match op { "==" => a == b, "!=" => a != b, ">" => a && !b, "<" => !a && b, ">=" => a || (!a && !b), "<=" => !a || (a && b), _ => unreachable!() }; [INFO] [stdout] 47 + let res = match op { "==" => a == b, "!=" => a != b, ">" => a && !b, "<" => !a && b, ">=" => a || (!a && !b), "<=" => !(a && !b), _ => unreachable!() }; [INFO] [stdout] | [INFO] [stdout] 47 - let res = match op { "==" => a == b, "!=" => a != b, ">" => a && !b, "<" => !a && b, ">=" => a || (!a && !b), "<=" => !a || (a && b), _ => unreachable!() }; [INFO] [stdout] 47 + let res = match op { "==" => a == b, "!=" => a != b, ">" => a && !b, "<" => !a && b, ">=" => a || (!a && !b), "<=" => !a || b, _ => unreachable!() }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:229:14 [INFO] [stdout] | [INFO] [stdout] 229 | _=>return Err("attempted to index a non-array value".into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 229 - _=>return Err("attempted to index a non-array value".into()) [INFO] [stdout] 229 + _=>Err("attempted to index a non-array value".into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:257:22 [INFO] [stdout] | [INFO] [stdout] 257 | _=>return Err("attempted to concatenate a non-array value".into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 257 - _=>return Err("attempted to concatenate a non-array value".into()) [INFO] [stdout] 257 + _=>Err("attempted to concatenate a non-array value".into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:270:18 [INFO] [stdout] | [INFO] [stdout] 270 | _=>return Err(format!("property {} not found on array", prop)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 270 - _=>return Err(format!("property {} not found on array", prop)) [INFO] [stdout] 270 + _=>Err(format!("property {} not found on array", prop)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:280:20 [INFO] [stdout] | [INFO] [stdout] 280 | _=>return Err(format!("property {} not found on object", prop)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 280 - _=>return Err(format!("property {} not found on object", prop)) [INFO] [stdout] 280 + _=>Err(format!("property {} not found on object", prop)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:284:20 [INFO] [stdout] | [INFO] [stdout] 284 | _=>return Err(format!("property {} not found on array", prop)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 284 - _=>return Err(format!("property {} not found on array", prop)) [INFO] [stdout] 284 + _=>Err(format!("property {} not found on array", prop)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:292:20 [INFO] [stdout] | [INFO] [stdout] 292 | _=>return Err(format!("property {} not found on db", prop)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 292 - _=>return Err(format!("property {} not found on db", prop)) [INFO] [stdout] 292 + _=>Err(format!("property {} not found on db", prop)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:294:18 [INFO] [stdout] | [INFO] [stdout] 294 | _=>return Err(format!("property {} not found on builtin", prop)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 294 - _=>return Err(format!("property {} not found on builtin", prop)) [INFO] [stdout] 294 + _=>Err(format!("property {} not found on builtin", prop)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:297:14 [INFO] [stdout] | [INFO] [stdout] 297 | _=>return Err("attempted to access a non-object value".into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 297 - _=>return Err("attempted to access a non-object value".into()) [INFO] [stdout] 297 + _=>Err("attempted to access a non-object value".into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/runtime.rs:115:17 [INFO] [stdout] | [INFO] [stdout] 115 | / match builtin { [INFO] [stdout] 116 | | Builtin::ObjectKeys=>{ [INFO] [stdout] 117 | | let mut keys: Vec> = Vec::new(); [INFO] [stdout] 118 | | match arg_vals.get(0) { [INFO] [stdout] ... | [INFO] [stdout] 133 | | _ => Err("attempted call a non‑function value".into()), [INFO] [stdout] 134 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/runtime.rs:114:30 [INFO] [stdout] | [INFO] [stdout] 114 | Value::Builtin(builtin)=>{ [INFO] [stdout] | ^^^^^^^ replace this binding [INFO] [stdout] 115 | match builtin { [INFO] [stdout] 116 | Builtin::ObjectKeys=>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `arg_vals.get(0)` [INFO] [stdout] --> src/runtime.rs:118:27 [INFO] [stdout] | [INFO] [stdout] 118 | match arg_vals.get(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `arg_vals.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/ast.rs:188:32 [INFO] [stdout] | [INFO] [stdout] 188 | params.into_iter().map(|s| s.into()).collect(), [INFO] [stdout] | ^^^^^^^^ help: consider removing `.into()`: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/ast.rs:202:37 [INFO] [stdout] | [INFO] [stdout] 202 | Expr::Array(elems.into_iter().map(|e| ArrElem::Expr(e)).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ArrElem::Expr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/parser.rs:25:30 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn parse(input: &str) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 272 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/parser.rs:32:53 [INFO] [stdout] | [INFO] [stdout] 32 | fn build_expr(pair: pest::iterators::Pair) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 272 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/parser.rs:129:56 [INFO] [stdout] | [INFO] [stdout] 129 | fn build_arglist(pair: pest::iterators::Pair) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 272 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/parser.rs:138:56 [INFO] [stdout] | [INFO] [stdout] 138 | fn build_literal(pair: pest::iterators::Pair) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 272 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/parser.rs:188:54 [INFO] [stdout] | [INFO] [stdout] 188 | fn build_array(pair: pest::iterators::Pair) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 272 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/parser.rs:196:55 [INFO] [stdout] | [INFO] [stdout] 196 | fn build_object(pair: pest::iterators::Pair) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 272 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/runtime.rs:32:32 [INFO] [stdout] | [INFO] [stdout] 32 | Value::Builtin(builtin) => format!("[Builtin]"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"[Builtin]".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/runtime.rs:47:96 [INFO] [stdout] | [INFO] [stdout] 47 | let res = match op { "==" => a == b, "!=" => a != b, ">" => a && !b, "<" => !a && b, ">=" => a || (!a && !b), "<=" => !a || (a && ... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 47 - let res = match op { "==" => a == b, "!=" => a != b, ">" => a && !b, "<" => !a && b, ">=" => a || (!a && !b), "<=" => !a || (a && b), _ => unreachable!() }; [INFO] [stdout] 47 + let res = match op { "==" => a == b, "!=" => a != b, ">" => a && !b, "<" => !a && b, ">=" => !(!a && b), "<=" => !a || (a && b), _ => unreachable!() }; [INFO] [stdout] | [INFO] [stdout] 47 - let res = match op { "==" => a == b, "!=" => a != b, ">" => a && !b, "<" => !a && b, ">=" => a || (!a && !b), "<=" => !a || (a && b), _ => unreachable!() }; [INFO] [stdout] 47 + let res = match op { "==" => a == b, "!=" => a != b, ">" => a && !b, "<" => !a && b, ">=" => a || !b, "<=" => !a || (a && b), _ => unreachable!() }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/runtime.rs:47:121 [INFO] [stdout] | [INFO] [stdout] 47 | ... && !b, "<" => !a && b, ">=" => a || (!a && !b), "<=" => !a || (a && b), _ => unreachable!() }; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 47 - let res = match op { "==" => a == b, "!=" => a != b, ">" => a && !b, "<" => !a && b, ">=" => a || (!a && !b), "<=" => !a || (a && b), _ => unreachable!() }; [INFO] [stdout] 47 + let res = match op { "==" => a == b, "!=" => a != b, ">" => a && !b, "<" => !a && b, ">=" => a || (!a && !b), "<=" => !(a && !b), _ => unreachable!() }; [INFO] [stdout] | [INFO] [stdout] 47 - let res = match op { "==" => a == b, "!=" => a != b, ">" => a && !b, "<" => !a && b, ">=" => a || (!a && !b), "<=" => !a || (a && b), _ => unreachable!() }; [INFO] [stdout] 47 + let res = match op { "==" => a == b, "!=" => a != b, ">" => a && !b, "<" => !a && b, ">=" => a || (!a && !b), "<=" => !a || b, _ => unreachable!() }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:229:14 [INFO] [stdout] | [INFO] [stdout] 229 | _=>return Err("attempted to index a non-array value".into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 229 - _=>return Err("attempted to index a non-array value".into()) [INFO] [stdout] 229 + _=>Err("attempted to index a non-array value".into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:257:22 [INFO] [stdout] | [INFO] [stdout] 257 | _=>return Err("attempted to concatenate a non-array value".into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 257 - _=>return Err("attempted to concatenate a non-array value".into()) [INFO] [stdout] 257 + _=>Err("attempted to concatenate a non-array value".into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:270:18 [INFO] [stdout] | [INFO] [stdout] 270 | _=>return Err(format!("property {} not found on array", prop)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 270 - _=>return Err(format!("property {} not found on array", prop)) [INFO] [stdout] 270 + _=>Err(format!("property {} not found on array", prop)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:280:20 [INFO] [stdout] | [INFO] [stdout] 280 | _=>return Err(format!("property {} not found on object", prop)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 280 - _=>return Err(format!("property {} not found on object", prop)) [INFO] [stdout] 280 + _=>Err(format!("property {} not found on object", prop)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:284:20 [INFO] [stdout] | [INFO] [stdout] 284 | _=>return Err(format!("property {} not found on array", prop)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 284 - _=>return Err(format!("property {} not found on array", prop)) [INFO] [stdout] 284 + _=>Err(format!("property {} not found on array", prop)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:292:20 [INFO] [stdout] | [INFO] [stdout] 292 | _=>return Err(format!("property {} not found on db", prop)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 292 - _=>return Err(format!("property {} not found on db", prop)) [INFO] [stdout] 292 + _=>Err(format!("property {} not found on db", prop)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:294:18 [INFO] [stdout] | [INFO] [stdout] 294 | _=>return Err(format!("property {} not found on builtin", prop)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 294 - _=>return Err(format!("property {} not found on builtin", prop)) [INFO] [stdout] 294 + _=>Err(format!("property {} not found on builtin", prop)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime.rs:297:14 [INFO] [stdout] | [INFO] [stdout] 297 | _=>return Err("attempted to access a non-object value".into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 297 - _=>return Err("attempted to access a non-object value".into()) [INFO] [stdout] 297 + _=>Err("attempted to access a non-object value".into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/runtime.rs:115:17 [INFO] [stdout] | [INFO] [stdout] 115 | / match builtin { [INFO] [stdout] 116 | | Builtin::ObjectKeys=>{ [INFO] [stdout] 117 | | let mut keys: Vec> = Vec::new(); [INFO] [stdout] 118 | | match arg_vals.get(0) { [INFO] [stdout] ... | [INFO] [stdout] 133 | | _ => Err("attempted call a non‑function value".into()), [INFO] [stdout] 134 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/runtime.rs:114:30 [INFO] [stdout] | [INFO] [stdout] 114 | Value::Builtin(builtin)=>{ [INFO] [stdout] | ^^^^^^^ replace this binding [INFO] [stdout] 115 | match builtin { [INFO] [stdout] 116 | Builtin::ObjectKeys=>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `arg_vals.get(0)` [INFO] [stdout] --> src/runtime.rs:118:27 [INFO] [stdout] | [INFO] [stdout] 118 | match arg_vals.get(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `arg_vals.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/tests.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | / mod tests { [INFO] [stdout] 6 | | use std::array; [INFO] [stdout] 7 | | use crate::ast::*; [INFO] [stdout] 8 | | use crate::parser::parse; [INFO] [stdout] ... | [INFO] [stdout] 227 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tests.rs:132:47 [INFO] [stdout] | [INFO] [stdout] 132 | test_parse(code, mk_call(mk_access(mk_var("a".into()), "b".into()), vec![mk_int(22)])); [INFO] [stdout] | ^^^^^^^^^^ help: consider removing `.into()`: `"a"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tests.rs:138:49 [INFO] [stdout] | [INFO] [stdout] 138 | test_parse(code, mk_access(mk_access(mk_var("a".into()), "b".into()), "c".into())); [INFO] [stdout] | ^^^^^^^^^^ help: consider removing `.into()`: `"a"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tests.rs:141:76 [INFO] [stdout] | [INFO] [stdout] 141 | test_parse(code, mk_access(mk_index(mk_call(mk_access(mk_access(mk_var("a".into()), "b".into()), "c".into()), vec![mk_int(22)])... [INFO] [stdout] | ^^^^^^^^^^ help: consider removing `.into()`: `"a"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tests.rs:144:76 [INFO] [stdout] | [INFO] [stdout] 144 | test_parse(code, mk_access(mk_index(mk_call(mk_access(mk_access(mk_var("a".into()), "b".into()), "c".into()), vec![mk_int(22)])... [INFO] [stdout] | ^^^^^^^^^^ help: consider removing `.into()`: `"a"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/ast.rs:188:32 [INFO] [stdout] | [INFO] [stdout] 188 | params.into_iter().map(|s| s.into()).collect(), [INFO] [stdout] | ^^^^^^^^ help: consider removing `.into()`: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/ast.rs:202:37 [INFO] [stdout] | [INFO] [stdout] 202 | Expr::Array(elems.into_iter().map(|e| ArrElem::Expr(e)).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ArrElem::Expr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.40s [INFO] running `Command { std: "docker" "inspect" "80b9bd5d4c667a3e781cf43ea5d3d07ae903a917df1726ebb547f9b4f3c914f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "80b9bd5d4c667a3e781cf43ea5d3d07ae903a917df1726ebb547f9b4f3c914f8", kill_on_drop: false }` [INFO] [stdout] 80b9bd5d4c667a3e781cf43ea5d3d07ae903a917df1726ebb547f9b4f3c914f8