[INFO] cloning repository https://github.com/DJ-UKOL/Searcher [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DJ-UKOL/Searcher" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDJ-UKOL%2FSearcher", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDJ-UKOL%2FSearcher'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ceaa8e8ffe558e4894d896eb3067557f08b22cdc [INFO] linting DJ-UKOL/Searcher against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDJ-UKOL%2FSearcher" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/DJ-UKOL/Searcher [INFO] finished tweaking git repo https://github.com/DJ-UKOL/Searcher [INFO] tweaked toml for git repo https://github.com/DJ-UKOL/Searcher written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/DJ-UKOL/Searcher on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/DJ-UKOL/Searcher already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 62e6732bb55508df01e45d9c1750360fc7d57b09c72c71371496a16f19c6a33b [INFO] running `Command { std: "docker" "start" "-a" "62e6732bb55508df01e45d9c1750360fc7d57b09c72c71371496a16f19c6a33b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "62e6732bb55508df01e45d9c1750360fc7d57b09c72c71371496a16f19c6a33b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "62e6732bb55508df01e45d9c1750360fc7d57b09c72c71371496a16f19c6a33b", kill_on_drop: false }` [INFO] [stdout] 62e6732bb55508df01e45d9c1750360fc7d57b09c72c71371496a16f19c6a33b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ff92a7f4641fe244dfa548f1d1bb09d9929565e89086ce444c1bf1c07be0c871 [INFO] running `Command { std: "docker" "start" "-a" "ff92a7f4641fe244dfa548f1d1bb09d9929565e89086ce444c1bf1c07be0c871", kill_on_drop: false }` [INFO] [stderr] Checking Searcher v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:53:19 [INFO] [stdout] | [INFO] [stdout] 53 | if(!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 53 - if(!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions { [INFO] [stdout] 53 + if!(!is_no_extensions && !extensions.contains(&file_extension)) { [INFO] [stdout] | [INFO] [stdout] 53 - if(!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions { [INFO] [stdout] 53 + ifis_no_extensions || extensions.contains(&file_extension) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/main.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | / for entry in files { [INFO] [stdout] 33 | | if let Ok(entry) = entry { [INFO] [stdout] 34 | | let path = entry.path(); // получаем путь к файлу [INFO] [stdout] 35 | | let file_name = convert_os_str(path.file_stem()); // получаем имя файла [INFO] [stdout] ... | [INFO] [stdout] 58 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/main.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | / if let Ok(entry) = entry { [INFO] [stdout] 34 | | let path = entry.path(); // получаем путь к файлу [INFO] [stdout] 35 | | let file_name = convert_os_str(path.file_stem()); // получаем имя файла [INFO] [stdout] 36 | | let file_extension = convert_os_str(path.extension()); // получаем расширение файла [INFO] [stdout] ... | [INFO] [stdout] 57 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 32 ~ for entry in files.flatten() { [INFO] [stdout] 33 ~ let path = entry.path(); // получаем путь к файлу [INFO] [stdout] 34 ~ let file_name = convert_os_str(path.file_stem()); // получаем имя файла [INFO] [stdout] 35 ~ let file_extension = convert_os_str(path.extension()); // получаем расширение файла [INFO] [stdout] 36 + [INFO] [stdout] 37 ~ // если это папка [INFO] [stdout] 38 + if path.is_dir() { [INFO] [stdout] 39 + if is_no_extensions && file_name.contains(filename) { [INFO] [stdout] 40 + file_found(&path, now, results_count); [INFO] [stdout] 41 + } [INFO] [stdout] 42 + [INFO] [stdout] 43 + search_files(path.to_str().unwrap_or_default(), [INFO] [stdout] 44 + filename, [INFO] [stdout] 45 + extensions, [INFO] [stdout] 46 + now, [INFO] [stdout] 47 + results_count [INFO] [stdout] 48 + ); [INFO] [stdout] 49 + } else if is_empty_filename && extensions.contains(&file_extension) { [INFO] [stdout] 50 + file_found(&path, now, results_count); [INFO] [stdout] 51 + } else if path.is_file() && file_name.contains(filename) { [INFO] [stdout] 52 + if(!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions { [INFO] [stdout] 53 + file_found(&path, now, results_count); [INFO] [stdout] 54 + } [INFO] [stdout] 55 + } [INFO] [stdout] 56 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:52:20 [INFO] [stdout] | [INFO] [stdout] 52 | } else if path.is_file() && file_name.contains(filename) { [INFO] [stdout] | ____________________^ [INFO] [stdout] 53 | | if(!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions { [INFO] [stdout] 54 | | file_found(&path, now, results_count); [INFO] [stdout] 55 | | } [INFO] [stdout] 56 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 52 ~ } else if path.is_file() && file_name.contains(filename) [INFO] [stdout] 53 ~ &&((!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions) { [INFO] [stdout] 54 | file_found(&path, now, results_count); [INFO] [stdout] 55 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/main.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 121 | ... print!(" - {} Mb\n", metadata.len() as f64 / FILE_SIZE_BASE); // делим размер на константу чтобы получить из байтов мегабайты [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 121 - print!(" - {} Mb\n", metadata.len() as f64 / FILE_SIZE_BASE); // делим размер на константу чтобы получить из байтов мегабайты [INFO] [stdout] 121 + println!(" - {} Mb", metadata.len() as f64 / FILE_SIZE_BASE); // делим размер на константу чтобы получить из байтов мегабайты [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.34s [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:53:19 [INFO] [stdout] | [INFO] [stdout] 53 | if(!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 53 - if(!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions { [INFO] [stdout] 53 + if!(!is_no_extensions && !extensions.contains(&file_extension)) { [INFO] [stdout] | [INFO] [stdout] 53 - if(!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions { [INFO] [stdout] 53 + ifis_no_extensions || extensions.contains(&file_extension) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/main.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | / for entry in files { [INFO] [stdout] 33 | | if let Ok(entry) = entry { [INFO] [stdout] 34 | | let path = entry.path(); // получаем путь к файлу [INFO] [stdout] 35 | | let file_name = convert_os_str(path.file_stem()); // получаем имя файла [INFO] [stdout] ... | [INFO] [stdout] 58 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/main.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | / if let Ok(entry) = entry { [INFO] [stdout] 34 | | let path = entry.path(); // получаем путь к файлу [INFO] [stdout] 35 | | let file_name = convert_os_str(path.file_stem()); // получаем имя файла [INFO] [stdout] 36 | | let file_extension = convert_os_str(path.extension()); // получаем расширение файла [INFO] [stdout] ... | [INFO] [stdout] 57 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 32 ~ for entry in files.flatten() { [INFO] [stdout] 33 ~ let path = entry.path(); // получаем путь к файлу [INFO] [stdout] 34 ~ let file_name = convert_os_str(path.file_stem()); // получаем имя файла [INFO] [stdout] 35 ~ let file_extension = convert_os_str(path.extension()); // получаем расширение файла [INFO] [stdout] 36 + [INFO] [stdout] 37 ~ // если это папка [INFO] [stdout] 38 + if path.is_dir() { [INFO] [stdout] 39 + if is_no_extensions && file_name.contains(filename) { [INFO] [stdout] 40 + file_found(&path, now, results_count); [INFO] [stdout] 41 + } [INFO] [stdout] 42 + [INFO] [stdout] 43 + search_files(path.to_str().unwrap_or_default(), [INFO] [stdout] 44 + filename, [INFO] [stdout] 45 + extensions, [INFO] [stdout] 46 + now, [INFO] [stdout] 47 + results_count [INFO] [stdout] 48 + ); [INFO] [stdout] 49 + } else if is_empty_filename && extensions.contains(&file_extension) { [INFO] [stdout] 50 + file_found(&path, now, results_count); [INFO] [stdout] 51 + } else if path.is_file() && file_name.contains(filename) { [INFO] [stdout] 52 + if(!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions { [INFO] [stdout] 53 + file_found(&path, now, results_count); [INFO] [stdout] 54 + } [INFO] [stdout] 55 + } [INFO] [stdout] 56 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:52:20 [INFO] [stdout] | [INFO] [stdout] 52 | } else if path.is_file() && file_name.contains(filename) { [INFO] [stdout] | ____________________^ [INFO] [stdout] 53 | | if(!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions { [INFO] [stdout] 54 | | file_found(&path, now, results_count); [INFO] [stdout] 55 | | } [INFO] [stdout] 56 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 52 ~ } else if path.is_file() && file_name.contains(filename) [INFO] [stdout] 53 ~ &&((!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions) { [INFO] [stdout] 54 | file_found(&path, now, results_count); [INFO] [stdout] 55 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/main.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 121 | ... print!(" - {} Mb\n", metadata.len() as f64 / FILE_SIZE_BASE); // делим размер на константу чтобы получить из байтов мегабайты [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 121 - print!(" - {} Mb\n", metadata.len() as f64 / FILE_SIZE_BASE); // делим размер на константу чтобы получить из байтов мегабайты [INFO] [stdout] 121 + println!(" - {} Mb", metadata.len() as f64 / FILE_SIZE_BASE); // делим размер на константу чтобы получить из байтов мегабайты [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "ff92a7f4641fe244dfa548f1d1bb09d9929565e89086ce444c1bf1c07be0c871", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ff92a7f4641fe244dfa548f1d1bb09d9929565e89086ce444c1bf1c07be0c871", kill_on_drop: false }` [INFO] [stdout] ff92a7f4641fe244dfa548f1d1bb09d9929565e89086ce444c1bf1c07be0c871