[INFO] cloning repository https://github.com/DCNick3/shin-translation-tools [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DCNick3/shin-translation-tools" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDCNick3%2Fshin-translation-tools", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDCNick3%2Fshin-translation-tools'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e2fbd365948aa934f9b36f20f9add6d4013a7dca [INFO] linting DCNick3/shin-translation-tools against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDCNick3%2Fshin-translation-tools" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/DCNick3/shin-translation-tools [INFO] finished tweaking git repo https://github.com/DCNick3/shin-translation-tools [INFO] tweaked toml for git repo https://github.com/DCNick3/shin-translation-tools written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/DCNick3/shin-translation-tools on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/DCNick3/shin-translation-tools already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tracing-indicatif v0.3.9 [INFO] [stderr] Downloaded enum-map-derive v1.0.0-beta.1 [INFO] [stderr] Downloaded enum-map v3.0.0-beta.2 [INFO] [stderr] Downloaded vte v0.11.1 [INFO] [stderr] Downloaded terminal_size v0.4.2 [INFO] [stderr] Downloaded proc-bitfield v0.3.1 [INFO] [stderr] Downloaded smallvec v2.0.0-alpha.6 [INFO] [stderr] Downloaded vt100 v0.15.2 [INFO] [stderr] Downloaded bytesize v1.3.3 [INFO] [stderr] Downloaded miette-derive v7.5.0 [INFO] [stderr] Downloaded proc-bitfield-macros v0.3.1 [INFO] [stderr] Downloaded minicbor-derive v0.16.2 [INFO] [stderr] Downloaded clap_complete v4.5.47 [INFO] [stderr] Downloaded binrw_derive v0.13.3 [INFO] [stderr] Downloaded binrw v0.13.3 [INFO] [stderr] Downloaded binrw v0.14.1 [INFO] [stderr] Downloaded ruzstd v0.8.0 [INFO] [stderr] Downloaded miette v7.5.0 [INFO] [stderr] Downloaded clap_builder v4.5.37 [INFO] [stderr] Downloaded minicbor v0.26.4 [INFO] [stderr] Downloaded binrw_derive v0.14.1 [INFO] [stderr] Downloaded clap v4.5.37 [INFO] [stderr] Downloaded owo-colors v4.2.0 [INFO] [stderr] Downloaded array-init v2.1.0 [INFO] [stderr] Downloaded hex-slice v0.1.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d8b5e6db1bce494eb4f4be4af5af9ee62070f0dd5544934672c5c2a3b8219c39 [INFO] running `Command { std: "docker" "start" "-a" "d8b5e6db1bce494eb4f4be4af5af9ee62070f0dd5544934672c5c2a3b8219c39", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d8b5e6db1bce494eb4f4be4af5af9ee62070f0dd5544934672c5c2a3b8219c39", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d8b5e6db1bce494eb4f4be4af5af9ee62070f0dd5544934672c5c2a3b8219c39", kill_on_drop: false }` [INFO] [stdout] d8b5e6db1bce494eb4f4be4af5af9ee62070f0dd5544934672c5c2a3b8219c39 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bb39fb7daae94e349605b9a6d185f3083f624c25a9515e9521430fdd372ee0b9 [INFO] running `Command { std: "docker" "start" "-a" "bb39fb7daae94e349605b9a6d185f3083f624c25a9515e9521430fdd372ee0b9", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.95 [INFO] [stderr] Checking clap_builder v4.5.37 [INFO] [stderr] Checking miniz_oxide v0.8.8 [INFO] [stderr] Compiling owo-colors v3.5.0 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Checking bytemuck v1.22.0 [INFO] [stderr] Checking array-init v2.1.0 [INFO] [stderr] Checking bumpalo v3.17.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling binrw_derive v0.14.1 [INFO] [stderr] Compiling object v0.36.7 [INFO] [stderr] Compiling portable-atomic v1.11.0 [INFO] [stderr] Compiling binrw v0.14.1 [INFO] [stderr] Checking gimli v0.31.1 [INFO] [stderr] Checking shin-text v0.10.5 (/opt/rustwide/workdir/shin-text) [INFO] [stderr] Compiling rustix v1.0.5 [INFO] [stderr] Checking flate2 v1.1.1 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Compiling syn v2.0.100 [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> shin-text/src/lib.rs:339:5 [INFO] [stdout] | [INFO] [stdout] 339 | / if fixup { [INFO] [stdout] 340 | | if let Some(position) = SJIS_FIXUP_ENTRIES.iter().position(|&c| c == sjis) { [INFO] [stdout] 341 | | sjis = (KATAKANA_START + position as u8) as u16; [INFO] [stdout] 342 | | } [INFO] [stdout] 343 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 339 ~ if fixup [INFO] [stdout] 340 ~ && let Some(position) = SJIS_FIXUP_ENTRIES.iter().position(|&c| c == sjis) { [INFO] [stdout] 341 | sjis = (KATAKANA_START + position as u8) as u16; [INFO] [stdout] 342 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> shin-text/src/lib.rs:374:9 [INFO] [stdout] | [INFO] [stdout] 374 | / if fixup.should_fixup() { [INFO] [stdout] 375 | | if let Some(position) = SJIS_FIXUP_ENTRIES.iter().position(|&c| c == sjis) { [INFO] [stdout] 376 | | sjis = (KATAKANA_START + position as u8) as u16; [INFO] [stdout] 377 | | } [INFO] [stdout] 378 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 374 ~ if fixup.should_fixup() [INFO] [stdout] 375 ~ && let Some(position) = SJIS_FIXUP_ENTRIES.iter().position(|&c| c == sjis) { [INFO] [stdout] 376 | sjis = (KATAKANA_START + position as u8) as u16; [INFO] [stdout] 377 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling vte_generate_state_changes v0.1.2 [INFO] [stderr] Checking vte v0.11.1 [INFO] [stderr] Compiling owo-colors v4.2.0 [INFO] [stderr] Checking bitflags v2.9.0 [INFO] [stderr] Compiling binrw_derive v0.13.3 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Checking image v0.25.6 [INFO] [stderr] Checking vt100 v0.15.2 [INFO] [stderr] Checking addr2line v0.24.2 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking smallvec v1.15.0 [INFO] [stderr] Checking is_ci v1.2.0 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Compiling minicbor v0.26.4 [INFO] [stderr] Compiling binrw v0.13.3 [INFO] [stderr] Compiling camino v1.1.9 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking indicatif v0.17.11 [INFO] [stderr] Checking supports-color v3.0.2 [INFO] [stderr] Checking terminal_size v0.4.2 [INFO] [stderr] Checking csv-core v0.1.12 [INFO] [stderr] Checking supports-unicode v3.0.0 [INFO] [stderr] Checking textwrap v0.16.2 [INFO] [stderr] Checking supports-hyperlinks v3.1.0 [INFO] [stderr] Checking memmap2 v0.9.5 [INFO] [stderr] Checking smallvec v2.0.0-alpha.6 [INFO] [stderr] Checking hex-slice v0.1.4 [INFO] [stderr] Checking bytesize v1.3.3 [INFO] [stderr] Checking drop_bomb v0.1.5 [INFO] [stderr] Checking twox-hash v2.1.0 [INFO] [stderr] Checking ruzstd v0.8.0 [INFO] [stderr] Checking backtrace v0.3.74 [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> shin-text/src/lib.rs:339:5 [INFO] [stdout] | [INFO] [stdout] 339 | / if fixup { [INFO] [stdout] 340 | | if let Some(position) = SJIS_FIXUP_ENTRIES.iter().position(|&c| c == sjis) { [INFO] [stdout] 341 | | sjis = (KATAKANA_START + position as u8) as u16; [INFO] [stdout] 342 | | } [INFO] [stdout] 343 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 339 ~ if fixup [INFO] [stdout] 340 ~ && let Some(position) = SJIS_FIXUP_ENTRIES.iter().position(|&c| c == sjis) { [INFO] [stdout] 341 | sjis = (KATAKANA_START + position as u8) as u16; [INFO] [stdout] 342 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> shin-text/src/lib.rs:374:9 [INFO] [stdout] | [INFO] [stdout] 374 | / if fixup.should_fixup() { [INFO] [stdout] 375 | | if let Some(position) = SJIS_FIXUP_ENTRIES.iter().position(|&c| c == sjis) { [INFO] [stdout] 376 | | sjis = (KATAKANA_START + position as u8) as u16; [INFO] [stdout] 377 | | } [INFO] [stdout] 378 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 374 ~ if fixup.should_fixup() [INFO] [stdout] 375 ~ && let Some(position) = SJIS_FIXUP_ENTRIES.iter().position(|&c| c == sjis) { [INFO] [stdout] 376 | sjis = (KATAKANA_START + position as u8) as u16; [INFO] [stdout] 377 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> shin-text/src/lib.rs:457:50 [INFO] [stdout] | [INFO] [stdout] 457 | let encoded = encode_sjis_zstring(&bump, &s, false).unwrap(); [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking backtrace-ext v0.2.1 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling clap_derive v4.5.32 [INFO] [stderr] Compiling enum-map-derive v1.0.0-beta.1 [INFO] [stderr] Compiling tracing-attributes v0.1.28 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling miette-derive v7.5.0 [INFO] [stderr] Compiling proc-bitfield-macros v0.3.1 [INFO] [stderr] Checking enum-map v3.0.0-beta.2 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Compiling minicbor-derive v0.16.2 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking proc-bitfield v0.3.1 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking miette v7.5.0 [INFO] [stderr] Checking thiserror v2.0.12 [INFO] [stderr] Checking tracing-subscriber v0.3.19 [INFO] [stderr] Checking clap v4.5.37 [INFO] [stderr] Checking clap_complete v4.5.47 [INFO] [stderr] Checking tracing-indicatif v0.3.9 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking shin-versions v0.10.5 (/opt/rustwide/workdir/shin-versions) [INFO] [stderr] Checking csv v1.3.1 [INFO] [stderr] Checking serde_json v1.0.140 [INFO] [stderr] Checking shin-rom v0.10.5 (/opt/rustwide/workdir/shin-rom) [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> shin-rom/src/create/allocate.rs:274:17 [INFO] [stdout] | [INFO] [stdout] 274 | std::iter::repeat(FileSpan::dummy()).take(directory_count), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(FileSpan::dummy(), directory_count)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> shin-rom/src/create/allocate.rs:274:17 [INFO] [stdout] | [INFO] [stdout] 274 | std::iter::repeat(FileSpan::dummy()).take(directory_count), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(FileSpan::dummy(), directory_count)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking shin-font v0.10.5 (/opt/rustwide/workdir/shin-font) [INFO] [stderr] Checking shin-snr v0.10.5 (/opt/rustwide/workdir/shin-snr) [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> shin-snr/src/layout/message_parser/lint.rs:82:29 [INFO] [stdout] | [INFO] [stdout] 82 | if command.has_arg() && command_token.argument == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `command_token.argument.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CountingStringSink` [INFO] [stdout] --> shin-snr/src/layout/message_parser/sink.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | / pub fn new() -> Self { [INFO] [stdout] 37 | | Self { [INFO] [stdout] 38 | | char_count: 0, [INFO] [stdout] 39 | | utf8_byte_count: 0, [INFO] [stdout] 40 | | } [INFO] [stdout] 41 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 35 + impl Default for CountingStringSink { [INFO] [stdout] 36 + fn default() -> Self { [INFO] [stdout] 37 + Self::new() [INFO] [stdout] 38 + } [INFO] [stdout] 39 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> shin-snr/src/layout/message_parser/sink.rs:79:21 [INFO] [stdout] | [INFO] [stdout] 79 | .extend(std::iter::repeat(fixup).take(s.chars().count())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(fixup, s.chars().count())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> shin-snr/src/layout/message_parser/mod.rs:487:1 [INFO] [stdout] | [INFO] [stdout] 487 | / pub fn transform_reflow_and_infer_fixup_policy<'bump>( [INFO] [stdout] 488 | | bump: &'bump Bump, [INFO] [stdout] 489 | | decoded: &'bump str, [INFO] [stdout] 490 | | in_style: MessageCommandStyle, [INFO] [stdout] ... | [INFO] [stdout] 495 | | source: AnyLocalizableStringSource, [INFO] [stdout] 496 | | ) -> (&'bump str, &'bump [bool]) { [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> shin-snr/src/layout/message_parser/mod.rs:501:9 [INFO] [stdout] | [INFO] [stdout] 501 | / if source.is_for_messagebox() { [INFO] [stdout] 502 | | if let MessageReflowMode::Greedy { metrics, layout } = reflow { [INFO] [stdout] 503 | | let mut tokens_out = Vec::new_in(bump); [INFO] [stdout] 504 | | super::reflow::reflow_message(bump, metrics, layout, &tokens, &mut tokens_out); [INFO] [stdout] ... | [INFO] [stdout] 507 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 501 ~ if source.is_for_messagebox() [INFO] [stdout] 502 ~ && let MessageReflowMode::Greedy { metrics, layout } = reflow { [INFO] [stdout] 503 | let mut tokens_out = Vec::new_in(bump); [INFO] [stdout] 504 | super::reflow::reflow_message(bump, metrics, layout, &tokens, &mut tokens_out); [INFO] [stdout] 505 | tokens = tokens_out; [INFO] [stdout] 506 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> shin-snr/src/layout/message_parser/mod.rs:556:9 [INFO] [stdout] | [INFO] [stdout] 556 | / if source.is_for_messagebox() { [INFO] [stdout] 557 | | if let MessageReflowMode::Greedy { metrics, layout } = reflow { [INFO] [stdout] 558 | | let mut tokens_out = Vec::new_in(bump); [INFO] [stdout] 559 | | super::reflow::reflow_message(bump, metrics, layout, &tokens, &mut tokens_out); [INFO] [stdout] ... | [INFO] [stdout] 562 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 556 ~ if source.is_for_messagebox() [INFO] [stdout] 557 ~ && let MessageReflowMode::Greedy { metrics, layout } = reflow { [INFO] [stdout] 558 | let mut tokens_out = Vec::new_in(bump); [INFO] [stdout] 559 | super::reflow::reflow_message(bump, metrics, layout, &tokens, &mut tokens_out); [INFO] [stdout] 560 | tokens = tokens_out; [INFO] [stdout] 561 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> shin-snr/src/layout/reflow.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | / if let layouter::Command::Char(c) = command { [INFO] [stdout] 27 | | if c.pos_x + c.width - base_x > layout_info.width { [INFO] [stdout] 28 | | // need a line break [INFO] [stdout] 29 | | if let Some(breakpoint) = last_seen_candidate_breakpoint { [INFO] [stdout] ... | [INFO] [stdout] 42 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 26 ~ if let layouter::Command::Char(c) = command [INFO] [stdout] 27 ~ && c.pos_x + c.width - base_x > layout_info.width { [INFO] [stdout] 28 | // need a line break [INFO] [stdout] ... [INFO] [stdout] 40 | } [INFO] [stdout] 41 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `OperationArenaPosition` [INFO] [stdout] --> shin-snr/src/operation/arena.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | / pub fn new() -> Self { [INFO] [stdout] 43 | | Self { [INFO] [stdout] 44 | | u8s: 0, [INFO] [stdout] 45 | | u16s: 0, [INFO] [stdout] ... | [INFO] [stdout] 54 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 41 + impl Default for OperationArenaPosition { [INFO] [stdout] 42 + fn default() -> Self { [INFO] [stdout] 43 + Self::new() [INFO] [stdout] 44 + } [INFO] [stdout] 45 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `OperationArena<'snr>` [INFO] [stdout] --> shin-snr/src/operation/arena.rs:231:5 [INFO] [stdout] | [INFO] [stdout] 231 | / pub fn new() -> Self { [INFO] [stdout] 232 | | Self { [INFO] [stdout] 233 | | // capacities chosen by parsing the umineko script and observing the capacities after parsing the whole file [INFO] [stdout] 234 | | u8s: Vec::with_capacity(16), [INFO] [stdout] ... | [INFO] [stdout] 244 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 230 + impl<'snr> Default for OperationArena<'snr> { [INFO] [stdout] 231 + fn default() -> Self { [INFO] [stdout] 232 + Self::new() [INFO] [stdout] 233 + } [INFO] [stdout] 234 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> shin-snr/src/operation/schema/def/mod.rs:322:20 [INFO] [stdout] | [INFO] [stdout] 322 | if !elements.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `elements.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> shin-snr/src/layout/message_parser/lint.rs:82:29 [INFO] [stdout] | [INFO] [stdout] 82 | if command.has_arg() && command_token.argument == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `command_token.argument.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CountingStringSink` [INFO] [stdout] --> shin-snr/src/layout/message_parser/sink.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | / pub fn new() -> Self { [INFO] [stdout] 37 | | Self { [INFO] [stdout] 38 | | char_count: 0, [INFO] [stdout] 39 | | utf8_byte_count: 0, [INFO] [stdout] 40 | | } [INFO] [stdout] 41 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 35 + impl Default for CountingStringSink { [INFO] [stdout] 36 + fn default() -> Self { [INFO] [stdout] 37 + Self::new() [INFO] [stdout] 38 + } [INFO] [stdout] 39 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> shin-snr/src/layout/message_parser/sink.rs:79:21 [INFO] [stdout] | [INFO] [stdout] 79 | .extend(std::iter::repeat(fixup).take(s.chars().count())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(fixup, s.chars().count())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> shin-snr/src/layout/message_parser/mod.rs:487:1 [INFO] [stdout] | [INFO] [stdout] 487 | / pub fn transform_reflow_and_infer_fixup_policy<'bump>( [INFO] [stdout] 488 | | bump: &'bump Bump, [INFO] [stdout] 489 | | decoded: &'bump str, [INFO] [stdout] 490 | | in_style: MessageCommandStyle, [INFO] [stdout] ... | [INFO] [stdout] 495 | | source: AnyLocalizableStringSource, [INFO] [stdout] 496 | | ) -> (&'bump str, &'bump [bool]) { [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> shin-snr/src/layout/message_parser/mod.rs:501:9 [INFO] [stdout] | [INFO] [stdout] 501 | / if source.is_for_messagebox() { [INFO] [stdout] 502 | | if let MessageReflowMode::Greedy { metrics, layout } = reflow { [INFO] [stdout] 503 | | let mut tokens_out = Vec::new_in(bump); [INFO] [stdout] 504 | | super::reflow::reflow_message(bump, metrics, layout, &tokens, &mut tokens_out); [INFO] [stdout] ... | [INFO] [stdout] 507 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 501 ~ if source.is_for_messagebox() [INFO] [stdout] 502 ~ && let MessageReflowMode::Greedy { metrics, layout } = reflow { [INFO] [stdout] 503 | let mut tokens_out = Vec::new_in(bump); [INFO] [stdout] 504 | super::reflow::reflow_message(bump, metrics, layout, &tokens, &mut tokens_out); [INFO] [stdout] 505 | tokens = tokens_out; [INFO] [stdout] 506 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> shin-snr/src/layout/message_parser/mod.rs:556:9 [INFO] [stdout] | [INFO] [stdout] 556 | / if source.is_for_messagebox() { [INFO] [stdout] 557 | | if let MessageReflowMode::Greedy { metrics, layout } = reflow { [INFO] [stdout] 558 | | let mut tokens_out = Vec::new_in(bump); [INFO] [stdout] 559 | | super::reflow::reflow_message(bump, metrics, layout, &tokens, &mut tokens_out); [INFO] [stdout] ... | [INFO] [stdout] 562 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 556 ~ if source.is_for_messagebox() [INFO] [stdout] 557 ~ && let MessageReflowMode::Greedy { metrics, layout } = reflow { [INFO] [stdout] 558 | let mut tokens_out = Vec::new_in(bump); [INFO] [stdout] 559 | super::reflow::reflow_message(bump, metrics, layout, &tokens, &mut tokens_out); [INFO] [stdout] 560 | tokens = tokens_out; [INFO] [stdout] 561 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> shin-snr/src/layout/reflow.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | / if let layouter::Command::Char(c) = command { [INFO] [stdout] 27 | | if c.pos_x + c.width - base_x > layout_info.width { [INFO] [stdout] 28 | | // need a line break [INFO] [stdout] 29 | | if let Some(breakpoint) = last_seen_candidate_breakpoint { [INFO] [stdout] ... | [INFO] [stdout] 42 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 26 ~ if let layouter::Command::Char(c) = command [INFO] [stdout] 27 ~ && c.pos_x + c.width - base_x > layout_info.width { [INFO] [stdout] 28 | // need a line break [INFO] [stdout] ... [INFO] [stdout] 40 | } [INFO] [stdout] 41 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `OperationArenaPosition` [INFO] [stdout] --> shin-snr/src/operation/arena.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | / pub fn new() -> Self { [INFO] [stdout] 43 | | Self { [INFO] [stdout] 44 | | u8s: 0, [INFO] [stdout] 45 | | u16s: 0, [INFO] [stdout] ... | [INFO] [stdout] 54 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 41 + impl Default for OperationArenaPosition { [INFO] [stdout] 42 + fn default() -> Self { [INFO] [stdout] 43 + Self::new() [INFO] [stdout] 44 + } [INFO] [stdout] 45 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `OperationArena<'snr>` [INFO] [stdout] --> shin-snr/src/operation/arena.rs:231:5 [INFO] [stdout] | [INFO] [stdout] 231 | / pub fn new() -> Self { [INFO] [stdout] 232 | | Self { [INFO] [stdout] 233 | | // capacities chosen by parsing the umineko script and observing the capacities after parsing the whole file [INFO] [stdout] 234 | | u8s: Vec::with_capacity(16), [INFO] [stdout] ... | [INFO] [stdout] 244 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 230 + impl<'snr> Default for OperationArena<'snr> { [INFO] [stdout] 231 + fn default() -> Self { [INFO] [stdout] 232 + Self::new() [INFO] [stdout] 233 + } [INFO] [stdout] 234 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> shin-snr/src/reactor/dump_bin.rs:34:35 [INFO] [stdout] | [INFO] [stdout] 34 | for element in arena.iter(&op_schema) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `op_schema` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `OffsetValidatorReactor` [INFO] [stdout] --> shin-snr/src/reactor/offset_validator.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | / pub fn new() -> Self { [INFO] [stdout] 20 | | Self { [INFO] [stdout] 21 | | referred_offsets: HashSet::new(), [INFO] [stdout] 22 | | operation_offsets: HashSet::new(), [INFO] [stdout] 23 | | } [INFO] [stdout] 24 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 18 + impl Default for OffsetValidatorReactor { [INFO] [stdout] 19 + fn default() -> Self { [INFO] [stdout] 20 + Self::new() [INFO] [stdout] 21 + } [INFO] [stdout] 22 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> shin-snr/src/reactor/rewrite/mod.rs:371:35 [INFO] [stdout] | [INFO] [stdout] 371 | for element in arena.iter(&op_schema) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `op_schema` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> shin-snr/src/reactor/string_roundrip_validator.rs:219:6 [INFO] [stdout] | [INFO] [stdout] 219 | impl<'a> Reactor for StringRoundtripValidatorReactor { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> shin-snr/src/reactor/string_roundrip_validator.rs:228:35 [INFO] [stdout] | [INFO] [stdout] 228 | for element in arena.iter(&op_schema) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `op_schema` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> shin-snr/src/reactor/trace/mod.rs:87:35 [INFO] [stdout] | [INFO] [stdout] 87 | for element in arena.iter(&op_schema) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `op_schema` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> shin-snr/src/reactor/mod.rs:201:9 [INFO] [stdout] | [INFO] [stdout] 201 | / match self { [INFO] [stdout] 202 | | LocalizableStringSource::Msgset(_) | LocalizableStringSource::Logset => true, [INFO] [stdout] 203 | | _ => false, [INFO] [stdout] 204 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 201 - match self { [INFO] [stdout] 202 - LocalizableStringSource::Msgset(_) | LocalizableStringSource::Logset => true, [INFO] [stdout] 203 - _ => false, [INFO] [stdout] 204 - } [INFO] [stdout] 201 + matches!(self, LocalizableStringSource::Msgset(_) | LocalizableStringSource::Logset) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> shin-snr/src/reactor/mod.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 208 | / match self { [INFO] [stdout] 209 | | LocalizableStringSource::Msgset(_) | LocalizableStringSource::Logset => true, [INFO] [stdout] 210 | | _ => false, [INFO] [stdout] 211 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 208 - match self { [INFO] [stdout] 209 - LocalizableStringSource::Msgset(_) | LocalizableStringSource::Logset => true, [INFO] [stdout] 210 - _ => false, [INFO] [stdout] 211 - } [INFO] [stdout] 208 + matches!(self, LocalizableStringSource::Msgset(_) | LocalizableStringSource::Logset) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lint expectation is unfulfilled [INFO] [stdout] --> shin-snr/src/layout/message_parser/lint.rs:14:15 [INFO] [stdout] | [INFO] [stdout] 14 | #![expect(unused_assignments)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unfulfilled_lint_expectations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> shin-snr/src/reactor/dump_bin.rs:34:35 [INFO] [stdout] | [INFO] [stdout] 34 | for element in arena.iter(&op_schema) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `op_schema` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `OffsetValidatorReactor` [INFO] [stdout] --> shin-snr/src/reactor/offset_validator.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | / pub fn new() -> Self { [INFO] [stdout] 20 | | Self { [INFO] [stdout] 21 | | referred_offsets: HashSet::new(), [INFO] [stdout] 22 | | operation_offsets: HashSet::new(), [INFO] [stdout] 23 | | } [INFO] [stdout] 24 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 18 + impl Default for OffsetValidatorReactor { [INFO] [stdout] 19 + fn default() -> Self { [INFO] [stdout] 20 + Self::new() [INFO] [stdout] 21 + } [INFO] [stdout] 22 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> shin-snr/src/reactor/rewrite/mod.rs:371:35 [INFO] [stdout] | [INFO] [stdout] 371 | for element in arena.iter(&op_schema) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `op_schema` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> shin-snr/src/reactor/string_roundrip_validator.rs:219:6 [INFO] [stdout] | [INFO] [stdout] 219 | impl<'a> Reactor for StringRoundtripValidatorReactor { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> shin-snr/src/reactor/string_roundrip_validator.rs:228:35 [INFO] [stdout] | [INFO] [stdout] 228 | for element in arena.iter(&op_schema) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `op_schema` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> shin-snr/src/reactor/trace/mod.rs:87:35 [INFO] [stdout] | [INFO] [stdout] 87 | for element in arena.iter(&op_schema) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `op_schema` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> shin-snr/src/reactor/mod.rs:201:9 [INFO] [stdout] | [INFO] [stdout] 201 | / match self { [INFO] [stdout] 202 | | LocalizableStringSource::Msgset(_) | LocalizableStringSource::Logset => true, [INFO] [stdout] 203 | | _ => false, [INFO] [stdout] 204 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 201 - match self { [INFO] [stdout] 202 - LocalizableStringSource::Msgset(_) | LocalizableStringSource::Logset => true, [INFO] [stdout] 203 - _ => false, [INFO] [stdout] 204 - } [INFO] [stdout] 201 + matches!(self, LocalizableStringSource::Msgset(_) | LocalizableStringSource::Logset) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> shin-snr/src/reactor/mod.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 208 | / match self { [INFO] [stdout] 209 | | LocalizableStringSource::Msgset(_) | LocalizableStringSource::Logset => true, [INFO] [stdout] 210 | | _ => false, [INFO] [stdout] 211 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 208 - match self { [INFO] [stdout] 209 - LocalizableStringSource::Msgset(_) | LocalizableStringSource::Logset => true, [INFO] [stdout] 210 - _ => false, [INFO] [stdout] 211 - } [INFO] [stdout] 208 + matches!(self, LocalizableStringSource::Msgset(_) | LocalizableStringSource::Logset) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lint expectation is unfulfilled [INFO] [stdout] --> shin-snr/src/layout/message_parser/lint.rs:14:15 [INFO] [stdout] | [INFO] [stdout] 14 | #![expect(unused_assignments)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unfulfilled_lint_expectations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking shin-tl v0.10.5 (/opt/rustwide/workdir/shin-tl) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> shin-tl/src/snr/mod.rs:80:30 [INFO] [stdout] | [INFO] [stdout] 80 | metrics: &font.expect("Message reflowing requires a corresponding font file (supplied with --font-file option)"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `font.expect("Message reflowing requires a corresponding font file (supplied with --font-file option)")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> shin-tl/src/snr/mod.rs:174:1 [INFO] [stdout] | [INFO] [stdout] 174 | / fn rewrite_snr<'a, R, O>( [INFO] [stdout] 175 | | snr_file: &[u8], [INFO] [stdout] 176 | | reader: Reader, [INFO] [stdout] 177 | | code_offset: u32, [INFO] [stdout] ... | [INFO] [stdout] 185 | | R: StringRewriter, [INFO] [stdout] 186 | | O: Write, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> shin-tl/src/snr/mod.rs:80:30 [INFO] [stdout] | [INFO] [stdout] 80 | metrics: &font.expect("Message reflowing requires a corresponding font file (supplied with --font-file option)"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `font.expect("Message reflowing requires a corresponding font file (supplied with --font-file option)")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> shin-tl/src/snr/mod.rs:472:17 [INFO] [stdout] | [INFO] [stdout] 472 | / if !no_lint { [INFO] [stdout] 473 | | if let Err(e) = data.lint(replacement_mode, user_style) { [INFO] [stdout] 474 | | println!("There are some issues with strings in the provided CSV file"); [INFO] [stdout] ... | [INFO] [stdout] 484 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 472 ~ if !no_lint [INFO] [stdout] 473 ~ && let Err(e) = data.lint(replacement_mode, user_style) { [INFO] [stdout] 474 | println!("There are some issues with strings in the provided CSV file"); [INFO] [stdout] ... [INFO] [stdout] 482 | std::process::exit(1); [INFO] [stdout] 483 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> shin-tl/src/snr/mod.rs:174:1 [INFO] [stdout] | [INFO] [stdout] 174 | / fn rewrite_snr<'a, R, O>( [INFO] [stdout] 175 | | snr_file: &[u8], [INFO] [stdout] 176 | | reader: Reader, [INFO] [stdout] 177 | | code_offset: u32, [INFO] [stdout] ... | [INFO] [stdout] 185 | | R: StringRewriter, [INFO] [stdout] 186 | | O: Write, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> shin-tl/src/snr/mod.rs:472:17 [INFO] [stdout] | [INFO] [stdout] 472 | / if !no_lint { [INFO] [stdout] 473 | | if let Err(e) = data.lint(replacement_mode, user_style) { [INFO] [stdout] 474 | | println!("There are some issues with strings in the provided CSV file"); [INFO] [stdout] ... | [INFO] [stdout] 484 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 472 ~ if !no_lint [INFO] [stdout] 473 ~ && let Err(e) = data.lint(replacement_mode, user_style) { [INFO] [stdout] 474 | println!("There are some issues with strings in the provided CSV file"); [INFO] [stdout] ... [INFO] [stdout] 482 | std::process::exit(1); [INFO] [stdout] 483 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 13s [INFO] running `Command { std: "docker" "inspect" "bb39fb7daae94e349605b9a6d185f3083f624c25a9515e9521430fdd372ee0b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb39fb7daae94e349605b9a6d185f3083f624c25a9515e9521430fdd372ee0b9", kill_on_drop: false }` [INFO] [stdout] bb39fb7daae94e349605b9a6d185f3083f624c25a9515e9521430fdd372ee0b9