[INFO] cloning repository https://github.com/D3faIt/status [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/D3faIt/status" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FD3faIt%2Fstatus", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FD3faIt%2Fstatus'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b954fe4ca5edeafdb1b39ec1dbabc340b2a05464 [INFO] linting D3faIt/status against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FD3faIt%2Fstatus" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/D3faIt/status [INFO] finished tweaking git repo https://github.com/D3faIt/status [INFO] tweaked toml for git repo https://github.com/D3faIt/status written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/D3faIt/status on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/D3faIt/status already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded online v4.0.1 [INFO] [stderr] Downloaded process_alive v0.1.1 [INFO] [stderr] Downloaded zmq-sys v0.12.0 [INFO] [stderr] Downloaded toml v0.8.6 [INFO] [stderr] Downloaded dircpy v0.3.15 [INFO] [stderr] Downloaded zmq v0.10.0 [INFO] [stderr] Downloaded clap v4.4.5 [INFO] [stderr] Downloaded clap_builder v4.4.5 [INFO] [stderr] Downloaded zeromq-src v0.2.6+4.3.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ee357471de60127896c433d38fa345a65bf63f43ea049aecfeafa870ccbf75ee [INFO] running `Command { std: "docker" "start" "-a" "ee357471de60127896c433d38fa345a65bf63f43ea049aecfeafa870ccbf75ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ee357471de60127896c433d38fa345a65bf63f43ea049aecfeafa870ccbf75ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ee357471de60127896c433d38fa345a65bf63f43ea049aecfeafa870ccbf75ee", kill_on_drop: false }` [INFO] [stdout] ee357471de60127896c433d38fa345a65bf63f43ea049aecfeafa870ccbf75ee [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2b7cd9ac86772efce80ecba0583a60b9bcbae7ea39d705a2504aaf1b6f072a45 [INFO] running `Command { std: "docker" "start" "-a" "2b7cd9ac86772efce80ecba0583a60b9bcbae7ea39d705a2504aaf1b6f072a45", kill_on_drop: false }` [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Compiling crossbeam-queue v0.3.8 [INFO] [stderr] Compiling hashbrown v0.14.2 [INFO] [stderr] Compiling either v1.9.0 [INFO] [stderr] Compiling winnow v0.5.19 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Compiling smallvec v1.11.0 [INFO] [stderr] Compiling walkdir v2.4.0 [INFO] [stderr] Compiling jobserver v0.1.27 [INFO] [stderr] Compiling syn v2.0.29 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking anstyle v1.0.3 [INFO] [stderr] Compiling serde_json v1.0.105 [INFO] [stderr] Compiling zmq v0.10.0 [INFO] [stderr] Checking process_alive v0.1.1 [INFO] [stderr] Checking online v4.0.1 [INFO] [stderr] Checking anstream v0.5.0 [INFO] [stderr] Compiling cfg-expr v0.15.5 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking clap_builder v4.4.5 [INFO] [stderr] Compiling crossbeam-channel v0.5.8 [INFO] [stderr] Compiling crossbeam-deque v0.8.3 [INFO] [stderr] Compiling indexmap v2.1.0 [INFO] [stderr] Compiling rayon v1.8.0 [INFO] [stderr] Compiling crossbeam v0.8.2 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling clap_derive v4.4.2 [INFO] [stderr] Compiling jwalk v0.8.1 [INFO] [stderr] Compiling serde_spanned v0.6.4 [INFO] [stderr] Compiling toml_datetime v0.6.5 [INFO] [stderr] Compiling dircpy v0.3.15 [INFO] [stderr] Compiling toml_edit v0.20.7 [INFO] [stderr] Compiling zeromq-src v0.2.6+4.3.4 [INFO] [stderr] Checking clap v4.4.5 [INFO] [stderr] Compiling toml v0.8.6 [INFO] [stderr] Compiling system-deps v6.2.0 [INFO] [stderr] Compiling zmq-sys v0.12.0 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking status v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | use online; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | use online; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/settings.rs:79:23 [INFO] [stdout] | [INFO] [stdout] 79 | .and_then(|s| Protocol::from_str(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Protocol::from_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/settings.rs:81:20 [INFO] [stdout] | [INFO] [stdout] 81 | let port = json [INFO] [stdout] | ____________________^ [INFO] [stdout] 82 | | .get("port") [INFO] [stdout] 83 | | .and_then(|v| v.as_u64()) [INFO] [stdout] 84 | | .unwrap_or_else(|| default_settings.port as u64) as u16; [INFO] [stdout] | |____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 84 - .unwrap_or_else(|| default_settings.port as u64) as u16; [INFO] [stdout] 84 + .unwrap_or(default_settings.port as u64) as u16; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/settings.rs:85:24 [INFO] [stdout] | [INFO] [stdout] 85 | let interval = json [INFO] [stdout] | ________________________^ [INFO] [stdout] 86 | | .get("interval") [INFO] [stdout] 87 | | .and_then(|v| v.as_u64()) [INFO] [stdout] 88 | | .unwrap_or_else(|| default_settings.interval); [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 88 - .unwrap_or_else(|| default_settings.interval); [INFO] [stdout] 88 + .unwrap_or(default_settings.interval); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/settings.rs:89:23 [INFO] [stdout] | [INFO] [stdout] 89 | let timeout = json [INFO] [stdout] | _______________________^ [INFO] [stdout] 90 | | .get("timeout") [INFO] [stdout] 91 | | .and_then(|v| v.as_f64()) [INFO] [stdout] 92 | | .unwrap_or_else(|| default_settings.timeout); [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 92 - .unwrap_or_else(|| default_settings.timeout); [INFO] [stdout] 92 + .unwrap_or(default_settings.timeout); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/settings.rs:93:36 [INFO] [stdout] | [INFO] [stdout] 93 | let pause_on_no_internet = json [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 94 | | .get("pause_on_no_internet") [INFO] [stdout] 95 | | .and_then(|v| v.as_bool()) [INFO] [stdout] 96 | | .unwrap_or_else(|| default_settings.pause_on_no_internet); [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 96 - .unwrap_or_else(|| default_settings.pause_on_no_internet); [INFO] [stdout] 96 + .unwrap_or(default_settings.pause_on_no_internet); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/settings.rs:97:29 [INFO] [stdout] | [INFO] [stdout] 97 | let retry_counter = json [INFO] [stdout] | _____________________________^ [INFO] [stdout] 98 | | .get("retry_counter") [INFO] [stdout] 99 | | .and_then(|v| v.as_i64()) [INFO] [stdout] 100 | | .unwrap_or_else(|| default_settings.retry_counter); [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 100 - .unwrap_or_else(|| default_settings.retry_counter); [INFO] [stdout] 100 + .unwrap_or(default_settings.retry_counter); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/settings.rs:101:30 [INFO] [stdout] | [INFO] [stdout] 101 | let retry_strategy = json [INFO] [stdout] | ______________________________^ [INFO] [stdout] 102 | | .get("retry_strategy") [INFO] [stdout] 103 | | .and_then(|v| v.as_str()) [INFO] [stdout] 104 | | .and_then(|s| RetryStrategy::from_str(s)) [INFO] [stdout] 105 | | .unwrap_or_else(|| default_settings.retry_strategy); [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 105 - .unwrap_or_else(|| default_settings.retry_strategy); [INFO] [stdout] 105 + .unwrap_or(default_settings.retry_strategy); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/settings.rs:104:23 [INFO] [stdout] | [INFO] [stdout] 104 | .and_then(|s| RetryStrategy::from_str(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `RetryStrategy::from_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/tester.rs:217:16 [INFO] [stdout] | [INFO] [stdout] 217 | if success > 1.00 || 0.00 > success { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(0.00..=1.00).contains(&success)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/tester.rs:302:16 [INFO] [stdout] | [INFO] [stdout] 302 | if found_name == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `!found_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/utils/protocol.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | / pub fn from_str(protocol: &str) -> Option { [INFO] [stdout] 23 | | match protocol { [INFO] [stdout] 24 | | "tcp" => Some(Protocol::Tcp), [INFO] [stdout] 25 | | "ipc" => Some(Protocol::Ipc), [INFO] [stdout] ... | [INFO] [stdout] 30 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/utils/retry_strategy.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / pub fn from_str(retry_strategy: &str) -> Option { [INFO] [stdout] 26 | | match retry_strategy { [INFO] [stdout] 27 | | "best" => Some(RetryStrategy::Best), [INFO] [stdout] 28 | | "combined_best" => Some(RetryStrategy::CombinedBest), [INFO] [stdout] ... | [INFO] [stdout] 34 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly performing saturating subtraction [INFO] [stdout] --> src/utils/jsonc.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 38 | / if block_comment_depth > 0 { [INFO] [stdout] 39 | | block_comment_depth -= 1; [INFO] [stdout] 40 | | } [INFO] [stdout] | |_________________^ help: try: `block_comment_depth = block_comment_depth.saturating_sub(1);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] = note: `#[warn(clippy::implicit_saturating_sub)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/utils/jsonc.rs:53:25 [INFO] [stdout] | [INFO] [stdout] 53 | json_output.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `json_output.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/settings.rs:79:23 [INFO] [stdout] | [INFO] [stdout] 79 | .and_then(|s| Protocol::from_str(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Protocol::from_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/settings.rs:81:20 [INFO] [stdout] | [INFO] [stdout] 81 | let port = json [INFO] [stdout] | ____________________^ [INFO] [stdout] 82 | | .get("port") [INFO] [stdout] 83 | | .and_then(|v| v.as_u64()) [INFO] [stdout] 84 | | .unwrap_or_else(|| default_settings.port as u64) as u16; [INFO] [stdout] | |____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 84 - .unwrap_or_else(|| default_settings.port as u64) as u16; [INFO] [stdout] 84 + .unwrap_or(default_settings.port as u64) as u16; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/settings.rs:85:24 [INFO] [stdout] | [INFO] [stdout] 85 | let interval = json [INFO] [stdout] | ________________________^ [INFO] [stdout] 86 | | .get("interval") [INFO] [stdout] 87 | | .and_then(|v| v.as_u64()) [INFO] [stdout] 88 | | .unwrap_or_else(|| default_settings.interval); [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 88 - .unwrap_or_else(|| default_settings.interval); [INFO] [stdout] 88 + .unwrap_or(default_settings.interval); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/settings.rs:89:23 [INFO] [stdout] | [INFO] [stdout] 89 | let timeout = json [INFO] [stdout] | _______________________^ [INFO] [stdout] 90 | | .get("timeout") [INFO] [stdout] 91 | | .and_then(|v| v.as_f64()) [INFO] [stdout] 92 | | .unwrap_or_else(|| default_settings.timeout); [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 92 - .unwrap_or_else(|| default_settings.timeout); [INFO] [stdout] 92 + .unwrap_or(default_settings.timeout); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/settings.rs:93:36 [INFO] [stdout] | [INFO] [stdout] 93 | let pause_on_no_internet = json [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 94 | | .get("pause_on_no_internet") [INFO] [stdout] 95 | | .and_then(|v| v.as_bool()) [INFO] [stdout] 96 | | .unwrap_or_else(|| default_settings.pause_on_no_internet); [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 96 - .unwrap_or_else(|| default_settings.pause_on_no_internet); [INFO] [stdout] 96 + .unwrap_or(default_settings.pause_on_no_internet); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/settings.rs:97:29 [INFO] [stdout] | [INFO] [stdout] 97 | let retry_counter = json [INFO] [stdout] | _____________________________^ [INFO] [stdout] 98 | | .get("retry_counter") [INFO] [stdout] 99 | | .and_then(|v| v.as_i64()) [INFO] [stdout] 100 | | .unwrap_or_else(|| default_settings.retry_counter); [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 100 - .unwrap_or_else(|| default_settings.retry_counter); [INFO] [stdout] 100 + .unwrap_or(default_settings.retry_counter); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/settings.rs:101:30 [INFO] [stdout] | [INFO] [stdout] 101 | let retry_strategy = json [INFO] [stdout] | ______________________________^ [INFO] [stdout] 102 | | .get("retry_strategy") [INFO] [stdout] 103 | | .and_then(|v| v.as_str()) [INFO] [stdout] 104 | | .and_then(|s| RetryStrategy::from_str(s)) [INFO] [stdout] 105 | | .unwrap_or_else(|| default_settings.retry_strategy); [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 105 - .unwrap_or_else(|| default_settings.retry_strategy); [INFO] [stdout] 105 + .unwrap_or(default_settings.retry_strategy); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/settings.rs:104:23 [INFO] [stdout] | [INFO] [stdout] 104 | .and_then(|s| RetryStrategy::from_str(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `RetryStrategy::from_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/zmq_handler/listen.rs:93:31 [INFO] [stdout] | [INFO] [stdout] 93 | .display() [INFO] [stdout] | _______________________________^ [INFO] [stdout] 94 | | .to_string(), [INFO] [stdout] | |________________________________^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/zmq_handler/listen.rs:156:17 [INFO] [stdout] | [INFO] [stdout] 156 | / match &mut s.result { [INFO] [stdout] 157 | | ResultOutput::Result(r) => { [INFO] [stdout] 158 | | r.retain(|test_result| test_result.success != 1.0); [INFO] [stdout] ... | [INFO] [stdout] 161 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 156 ~ if let ResultOutput::Result(r) = &mut s.result { [INFO] [stdout] 157 + r.retain(|test_result| test_result.success != 1.0); [INFO] [stdout] 158 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/tester.rs:217:16 [INFO] [stdout] | [INFO] [stdout] 217 | if success > 1.00 || 0.00 > success { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(0.00..=1.00).contains(&success)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/zmq_handler/mod.rs:45:19 [INFO] [stdout] | [INFO] [stdout] 45 | .bind(&*format!("{}://*:{}", protocol, port)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&format!("{}://*:{}", protocol, port)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/tester.rs:302:16 [INFO] [stdout] | [INFO] [stdout] 302 | if found_name == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `!found_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/utils/protocol.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | / pub fn from_str(protocol: &str) -> Option { [INFO] [stdout] 23 | | match protocol { [INFO] [stdout] 24 | | "tcp" => Some(Protocol::Tcp), [INFO] [stdout] 25 | | "ipc" => Some(Protocol::Ipc), [INFO] [stdout] ... | [INFO] [stdout] 30 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/service.rs:74:23 [INFO] [stdout] | [INFO] [stdout] 74 | .and_then(|s| RetryStrategy::from_str(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `RetryStrategy::from_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/utils/retry_strategy.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / pub fn from_str(retry_strategy: &str) -> Option { [INFO] [stdout] 26 | | match retry_strategy { [INFO] [stdout] 27 | | "best" => Some(RetryStrategy::Best), [INFO] [stdout] 28 | | "combined_best" => Some(RetryStrategy::CombinedBest), [INFO] [stdout] ... | [INFO] [stdout] 34 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly performing saturating subtraction [INFO] [stdout] --> src/utils/jsonc.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 38 | / if block_comment_depth > 0 { [INFO] [stdout] 39 | | block_comment_depth -= 1; [INFO] [stdout] 40 | | } [INFO] [stdout] | |_________________^ help: try: `block_comment_depth = block_comment_depth.saturating_sub(1);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] = note: `#[warn(clippy::implicit_saturating_sub)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/utils/jsonc.rs:53:25 [INFO] [stdout] | [INFO] [stdout] 53 | json_output.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `json_output.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:70:44 [INFO] [stdout] | [INFO] [stdout] 70 | if service.pause_on_no_internet && !online::check(Some(12)).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `online::check(Some(12)).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/main.rs:74:46 [INFO] [stdout] | [INFO] [stdout] 74 | ResultOutput::Bool(state) if state == false => { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] = note: `#[warn(clippy::redundant_guards)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 74 - ResultOutput::Bool(state) if state == false => { [INFO] [stdout] 74 + ResultOutput::Bool(false) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/main.rs:74:46 [INFO] [stdout] | [INFO] [stdout] 74 | ResultOutput::Bool(state) if state == false => { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `!state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/zmq_handler/listen.rs:93:31 [INFO] [stdout] | [INFO] [stdout] 93 | .display() [INFO] [stdout] | _______________________________^ [INFO] [stdout] 94 | | .to_string(), [INFO] [stdout] | |________________________________^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/zmq_handler/listen.rs:156:17 [INFO] [stdout] | [INFO] [stdout] 156 | / match &mut s.result { [INFO] [stdout] 157 | | ResultOutput::Result(r) => { [INFO] [stdout] 158 | | r.retain(|test_result| test_result.success != 1.0); [INFO] [stdout] ... | [INFO] [stdout] 161 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 156 ~ if let ResultOutput::Result(r) = &mut s.result { [INFO] [stdout] 157 + r.retain(|test_result| test_result.success != 1.0); [INFO] [stdout] 158 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/zmq_handler/mod.rs:45:19 [INFO] [stdout] | [INFO] [stdout] 45 | .bind(&*format!("{}://*:{}", protocol, port)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&format!("{}://*:{}", protocol, port)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/service.rs:74:23 [INFO] [stdout] | [INFO] [stdout] 74 | .and_then(|s| RetryStrategy::from_str(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `RetryStrategy::from_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:70:44 [INFO] [stdout] | [INFO] [stdout] 70 | if service.pause_on_no_internet && !online::check(Some(12)).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `online::check(Some(12)).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/main.rs:74:46 [INFO] [stdout] | [INFO] [stdout] 74 | ResultOutput::Bool(state) if state == false => { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] = note: `#[warn(clippy::redundant_guards)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 74 - ResultOutput::Bool(state) if state == false => { [INFO] [stdout] 74 + ResultOutput::Bool(false) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/main.rs:74:46 [INFO] [stdout] | [INFO] [stdout] 74 | ResultOutput::Bool(state) if state == false => { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `!state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 55.78s [INFO] running `Command { std: "docker" "inspect" "2b7cd9ac86772efce80ecba0583a60b9bcbae7ea39d705a2504aaf1b6f072a45", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2b7cd9ac86772efce80ecba0583a60b9bcbae7ea39d705a2504aaf1b6f072a45", kill_on_drop: false }` [INFO] [stdout] 2b7cd9ac86772efce80ecba0583a60b9bcbae7ea39d705a2504aaf1b6f072a45