[INFO] cloning repository https://github.com/D3faIt/elasticsearch-nginx-logger [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/D3faIt/elasticsearch-nginx-logger" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FD3faIt%2Felasticsearch-nginx-logger", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FD3faIt%2Felasticsearch-nginx-logger'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8c5a3b4a0bf07edc17dd8ae75ce7321001e8481b [INFO] linting D3faIt/elasticsearch-nginx-logger against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FD3faIt%2Felasticsearch-nginx-logger" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/D3faIt/elasticsearch-nginx-logger [INFO] finished tweaking git repo https://github.com/D3faIt/elasticsearch-nginx-logger [INFO] tweaked toml for git repo https://github.com/D3faIt/elasticsearch-nginx-logger written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/D3faIt/elasticsearch-nginx-logger on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/D3faIt/elasticsearch-nginx-logger already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded semver v1.0.24 [INFO] [stderr] Downloaded iana-time-zone v0.1.48 [INFO] [stderr] Downloaded termsize v0.1.6 [INFO] [stderr] Downloaded logwatcher v0.1.1 [INFO] [stderr] Downloaded redox_termios v0.1.3 [INFO] [stderr] Downloaded async-await v0.2.1 [INFO] [stderr] Downloaded termion v1.5.6 [INFO] [stderr] Downloaded elasticsearch v8.15.0-alpha.1 [INFO] [stderr] Downloaded async-compression v0.4.18 [INFO] [stderr] Downloaded cc v1.2.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7b2096557a287c1f29e75f22ebaf8b92d75606630a5fa824585e971519dfdfae [INFO] running `Command { std: "docker" "start" "-a" "7b2096557a287c1f29e75f22ebaf8b92d75606630a5fa824585e971519dfdfae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7b2096557a287c1f29e75f22ebaf8b92d75606630a5fa824585e971519dfdfae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7b2096557a287c1f29e75f22ebaf8b92d75606630a5fa824585e971519dfdfae", kill_on_drop: false }` [INFO] [stdout] 7b2096557a287c1f29e75f22ebaf8b92d75606630a5fa824585e971519dfdfae [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 916176f5193592185b51b7449f9f4e5ea111c6e9b193f8ce6967108790c2764b [INFO] running `Command { std: "docker" "start" "-a" "916176f5193592185b51b7449f9f4e5ea111c6e9b193f8ce6967108790c2764b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.92 [INFO] [stderr] Compiling libc v0.2.168 [INFO] [stderr] Compiling lock_api v0.4.8 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Compiling cc v1.2.4 [INFO] [stderr] Compiling pkg-config v0.3.25 [INFO] [stderr] Checking itoa v1.0.3 [INFO] [stderr] Checking once_cell v1.20.2 [INFO] [stderr] Checking litemap v0.7.4 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Checking http v1.2.0 [INFO] [stderr] Checking icu_locid_transform_data v1.5.0 [INFO] [stderr] Checking tracing-core v0.1.29 [INFO] [stderr] Checking icu_properties_data v1.5.0 [INFO] [stderr] Compiling openssl v0.10.41 [INFO] [stderr] Compiling serde v1.0.216 [INFO] [stderr] Checking indexmap v2.7.0 [INFO] [stderr] Compiling native-tls v0.2.10 [INFO] [stderr] Checking tracing v0.1.36 [INFO] [stderr] Checking icu_normalizer_data v1.5.0 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Compiling semver v1.0.24 [INFO] [stderr] Checking miniz_oxide v0.5.4 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking generic-array v0.14.6 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling serde_json v1.0.85 [INFO] [stderr] Checking socket2 v0.5.8 [INFO] [stderr] Compiling syn v2.0.90 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking ryu v1.0.11 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking flate2 v1.0.24 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking block-buffer v0.10.3 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking ipnet v2.5.0 [INFO] [stderr] Compiling anyhow v1.0.94 [INFO] [stderr] Compiling elasticsearch v8.15.0-alpha.1 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Checking digest v0.10.5 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking aho-corasick v0.7.19 [INFO] [stderr] Compiling openssl-sys v0.9.75 [INFO] [stderr] Checking dyn-clone v1.0.9 [INFO] [stderr] Checking iana-time-zone v0.1.48 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking cpufeatures v0.2.5 [INFO] [stderr] Checking sha1 v0.10.5 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking termsize v0.1.6 [INFO] [stderr] Checking async-await v0.2.1 [INFO] [stderr] Checking logwatcher v0.1.1 [INFO] [stderr] Checking chrono v0.4.22 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Compiling openssl-macros v0.1.0 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling zerofrom-derive v0.1.5 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling serde_derive v1.0.216 [INFO] [stderr] Checking tokio v1.43.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking zerofrom v0.1.5 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling serde_with_macros v3.11.0 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures-executor v0.3.24 [INFO] [stderr] Checking futures v0.3.24 [INFO] [stderr] Checking tokio-util v0.7.13 [INFO] [stderr] Checking tokio-native-tls v0.3.0 [INFO] [stderr] Checking async-compression v0.4.18 [INFO] [stderr] Checking h2 v0.4.7 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_with v3.11.0 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking hyper v1.5.1 [INFO] [stderr] Checking hyper-util v0.1.10 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.9 [INFO] [stderr] Checking nginx-es v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/logger.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/logger.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cert.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | / return Ok(Cert { [INFO] [stdout] 34 | | cert, [INFO] [stdout] 35 | | es_cert, [INFO] [stdout] 36 | | pem_data, [INFO] [stdout] 37 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 ~ Ok(Cert { [INFO] [stdout] 34 + cert, [INFO] [stdout] 35 + es_cert, [INFO] [stdout] 36 + pem_data, [INFO] [stdout] 37 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/config.rs:46:24 [INFO] [stdout] | [INFO] [stdout] 46 | if let Ok(_) = Cert::new(PathBuf::from(arg)) { [INFO] [stdout] | -------^^^^^-------------------------------- help: try: `if Cert::new(PathBuf::from(arg)).is_ok()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/config.rs:101:29 [INFO] [stdout] | [INFO] [stdout] 101 | eprintln!("{}", "No log file found to log data from"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 101 - eprintln!("{}", "No log file found to log data from"); [INFO] [stdout] 101 + eprintln!("No log file found to log data from"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option<&Path>` which implements the `Copy` trait [INFO] [stdout] --> src/config.rs:185:27 [INFO] [stdout] | [INFO] [stdout] 185 | if let Some(ap) = archive_folder.as_deref().clone().and_then(|ap| ap.to_str()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `archive_folder.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/logger.rs:140:8 [INFO] [stdout] | [INFO] [stdout] 140 | if Path::new(loc).exists() == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!Path::new(loc).exists()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/logger.rs:151:8 [INFO] [stdout] | [INFO] [stdout] 151 | if res.is_ok() == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `!res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/logger.rs:162:5 [INFO] [stdout] | [INFO] [stdout] 162 | / for line in reader.lines() { [INFO] [stdout] 163 | | if let Ok(l) = line { [INFO] [stdout] 164 | | let result = Logger::from_line(&l); [INFO] [stdout] 165 | | if counter > 10 { [INFO] [stdout] ... | [INFO] [stdout] 173 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/logger.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | / if let Ok(l) = line { [INFO] [stdout] 164 | | let result = Logger::from_line(&l); [INFO] [stdout] 165 | | if counter > 10 { [INFO] [stdout] 166 | | break; [INFO] [stdout] ... | [INFO] [stdout] 171 | | counter += 1; [INFO] [stdout] 172 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 162 ~ for l in reader.lines().flatten() { [INFO] [stdout] 163 + let result = Logger::from_line(&l); [INFO] [stdout] 164 + if counter > 10 { [INFO] [stdout] 165 + break; [INFO] [stdout] 166 + } [INFO] [stdout] 167 + if result.is_err() { [INFO] [stdout] 168 + fails += 1; [INFO] [stdout] 169 + } [INFO] [stdout] 170 + counter += 1; [INFO] [stdout] 171 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cert.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | / return Ok(Cert { [INFO] [stdout] 34 | | cert, [INFO] [stdout] 35 | | es_cert, [INFO] [stdout] 36 | | pem_data, [INFO] [stdout] 37 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 ~ Ok(Cert { [INFO] [stdout] 34 + cert, [INFO] [stdout] 35 + es_cert, [INFO] [stdout] 36 + pem_data, [INFO] [stdout] 37 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/logger.rs:228:28 [INFO] [stdout] | [INFO] [stdout] 228 | pub fn from_line(line: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 228 - pub fn from_line(line: &String) -> Result { [INFO] [stdout] 228 + pub fn from_line(line: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/logger.rs:268:27 [INFO] [stdout] | [INFO] [stdout] 268 | let status_code = (&cap[5]).parse::()?; [INFO] [stdout] | ^^^^^^^^^ help: change this to: `cap[5]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/logger.rs:269:20 [INFO] [stdout] | [INFO] [stdout] 269 | let size = (&cap[6]).parse::()?; [INFO] [stdout] | ^^^^^^^^^ help: change this to: `cap[6]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/config.rs:46:24 [INFO] [stdout] | [INFO] [stdout] 46 | if let Ok(_) = Cert::new(PathBuf::from(arg)) { [INFO] [stdout] | -------^^^^^-------------------------------- help: try: `if Cert::new(PathBuf::from(arg)).is_ok()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/logger.rs:309:20 [INFO] [stdout] | [INFO] [stdout] 309 | let host = es.get("host").and_then(|s| Some(s.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `es.get("host").map(|s| s.to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/logger.rs:312:21 [INFO] [stdout] | [INFO] [stdout] 312 | let refer = es.get("refer").and_then(|s| Some(s.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `es.get("refer").map(|s| s.to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/config.rs:101:29 [INFO] [stdout] | [INFO] [stdout] 101 | eprintln!("{}", "No log file found to log data from"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 101 - eprintln!("{}", "No log file found to log data from"); [INFO] [stdout] 101 + eprintln!("No log file found to log data from"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/logger.rs:315:26 [INFO] [stdout] | [INFO] [stdout] 315 | let user_agent = es.get("user_agent").and_then(|s| Some(s.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `es.get("user_agent").map(|s| s.to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/logger.rs:362:16 [INFO] [stdout] | [INFO] [stdout] 362 | if keys2.contains_key(elm.0) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!keys2.contains_key(elm.0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/logger.rs:368:16 [INFO] [stdout] | [INFO] [stdout] 368 | if keys.contains_key(elm.0) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!keys.contains_key(elm.0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/logger.rs:393:16 [INFO] [stdout] | [INFO] [stdout] 393 | if keys2.contains_key(elm) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!keys2.contains_key(elm)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/logger.rs:398:16 [INFO] [stdout] | [INFO] [stdout] 398 | if keys.contains_key(elm) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!keys.contains_key(elm)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/logger.rs:417:12 [INFO] [stdout] | [INFO] [stdout] 417 | if res["acknowledged"].is_boolean() == false [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!res["acknowledged"].is_boolean()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/logger.rs:418:16 [INFO] [stdout] | [INFO] [stdout] 418 | || res["acknowledged"].as_bool().unwrap() == false [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!res["acknowledged"].as_bool().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option<&Path>` which implements the `Copy` trait [INFO] [stdout] --> src/config.rs:185:27 [INFO] [stdout] | [INFO] [stdout] 185 | if let Some(ap) = archive_folder.as_deref().clone().and_then(|ap| ap.to_str()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `archive_folder.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | return re.is_match(str); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return re.is_match(str); [INFO] [stdout] 28 + re.is_match(str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server.rs:140:12 [INFO] [stdout] | [INFO] [stdout] 140 | if !search_response.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `search_response.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server.rs:147:12 [INFO] [stdout] | [INFO] [stdout] 147 | if !response.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `response.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 158 | return response_body.get("count").unwrap().as_i64().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 158 - return response_body.get("count").unwrap().as_i64().unwrap(); [INFO] [stdout] 158 + response_body.get("count").unwrap().as_i64().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server.rs:183:12 [INFO] [stdout] | [INFO] [stdout] 183 | if !delete_query.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `delete_query.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server.rs:191:12 [INFO] [stdout] | [INFO] [stdout] 191 | if !response.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `response.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server.rs:269:16 [INFO] [stdout] | [INFO] [stdout] 269 | if !search_response.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `search_response.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server.rs:277:16 [INFO] [stdout] | [INFO] [stdout] 277 | if !response.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `response.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server.rs:289:16 [INFO] [stdout] | [INFO] [stdout] 289 | if !failed.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `failed.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server.rs:380:12 [INFO] [stdout] | [INFO] [stdout] 380 | if !response.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `response.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server.rs:387:12 [INFO] [stdout] | [INFO] [stdout] 387 | if !response.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `response.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/server.rs:394:26 [INFO] [stdout] | [INFO] [stdout] 394 | let successful = response_body["errors"].as_bool().unwrap_or(false) == false; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!response_body["errors"].as_bool().unwrap_or(false)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/server.rs:427:12 [INFO] [stdout] | [INFO] [stdout] 427 | if self.index == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.index.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/server.rs:507:12 [INFO] [stdout] | [INFO] [stdout] 507 | if is_json(text.as_ref().unwrap().as_str()).is_ok() == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!is_json(text.as_ref().unwrap().as_str()).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | return new_path; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return new_path; [INFO] [stdout] 28 + new_path [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/utils.rs:15:31 [INFO] [stdout] | [INFO] [stdout] 15 | for (_, c) in path.chars().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 15 - for (_, c) in path.chars().enumerate() { [INFO] [stdout] 15 + for c in path.chars() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/utils.rs:18:16 [INFO] [stdout] | [INFO] [stdout] 18 | } else if c == '/' { [INFO] [stdout] | ________________^ [INFO] [stdout] 19 | | is_slash = true; [INFO] [stdout] 20 | | } else { [INFO] [stdout] 21 | | is_slash = false; [INFO] [stdout] 22 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `{ is_slash = c == '/'; }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should use the `ends_with` method [INFO] [stdout] --> src/utils.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 25 | if new_path.chars().last().unwrap() != '/' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `!new_path.ends_with('/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stdout] = note: `#[warn(clippy::chars_last_cmp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/utils.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | if Path::new(loc2.as_str()).exists() == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!Path::new(loc2.as_str()).exists()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/utils.rs:38:8 [INFO] [stdout] | [INFO] [stdout] 38 | if Path::new(loc2.as_str()).is_dir() == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!Path::new(loc2.as_str()).is_dir()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 62 | return newdate; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return newdate; [INFO] [stdout] 62 + newdate [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:70:8 [INFO] [stdout] | [INFO] [stdout] 70 | if !file_res.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `file_res.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:76:8 [INFO] [stdout] | [INFO] [stdout] 76 | if !res.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `res.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/utils.rs:81:40 [INFO] [stdout] | [INFO] [stdout] 81 | fs::remove_file(file_path.clone()).expect( [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 82 | | format!( [INFO] [stdout] 83 | | "The program crashed, you need to go delete {} manually", [INFO] [stdout] 84 | | file_path [INFO] [stdout] 85 | | ) [INFO] [stdout] 86 | | .as_str(), [INFO] [stdout] 87 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 81 ~ fs::remove_file(file_path.clone()).unwrap_or_else(|_| panic!("The program crashed, you need to go delete {} manually", [INFO] [stdout] 82 ~ file_path)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | return epoch; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return epoch; [INFO] [stdout] 28 + epoch [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/logger.rs:140:8 [INFO] [stdout] | [INFO] [stdout] 140 | if Path::new(loc).exists() == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!Path::new(loc).exists()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/logger.rs:151:8 [INFO] [stdout] | [INFO] [stdout] 151 | if res.is_ok() == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `!res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/logger.rs:162:5 [INFO] [stdout] | [INFO] [stdout] 162 | / for line in reader.lines() { [INFO] [stdout] 163 | | if let Ok(l) = line { [INFO] [stdout] 164 | | let result = Logger::from_line(&l); [INFO] [stdout] 165 | | if counter > 10 { [INFO] [stdout] ... | [INFO] [stdout] 173 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/logger.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | / if let Ok(l) = line { [INFO] [stdout] 164 | | let result = Logger::from_line(&l); [INFO] [stdout] 165 | | if counter > 10 { [INFO] [stdout] 166 | | break; [INFO] [stdout] ... | [INFO] [stdout] 171 | | counter += 1; [INFO] [stdout] 172 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 162 ~ for l in reader.lines().flatten() { [INFO] [stdout] 163 + let result = Logger::from_line(&l); [INFO] [stdout] 164 + if counter > 10 { [INFO] [stdout] 165 + break; [INFO] [stdout] 166 + } [INFO] [stdout] 167 + if result.is_err() { [INFO] [stdout] 168 + fails += 1; [INFO] [stdout] 169 + } [INFO] [stdout] 170 + counter += 1; [INFO] [stdout] 171 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/logger.rs:228:28 [INFO] [stdout] | [INFO] [stdout] 228 | pub fn from_line(line: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 228 - pub fn from_line(line: &String) -> Result { [INFO] [stdout] 228 + pub fn from_line(line: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/logger.rs:268:27 [INFO] [stdout] | [INFO] [stdout] 268 | let status_code = (&cap[5]).parse::()?; [INFO] [stdout] | ^^^^^^^^^ help: change this to: `cap[5]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/logger.rs:269:20 [INFO] [stdout] | [INFO] [stdout] 269 | let size = (&cap[6]).parse::()?; [INFO] [stdout] | ^^^^^^^^^ help: change this to: `cap[6]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/logger.rs:309:20 [INFO] [stdout] | [INFO] [stdout] 309 | let host = es.get("host").and_then(|s| Some(s.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `es.get("host").map(|s| s.to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/logger.rs:312:21 [INFO] [stdout] | [INFO] [stdout] 312 | let refer = es.get("refer").and_then(|s| Some(s.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `es.get("refer").map(|s| s.to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/logger.rs:315:26 [INFO] [stdout] | [INFO] [stdout] 315 | let user_agent = es.get("user_agent").and_then(|s| Some(s.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `es.get("user_agent").map(|s| s.to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/logger.rs:362:16 [INFO] [stdout] | [INFO] [stdout] 362 | if keys2.contains_key(elm.0) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!keys2.contains_key(elm.0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/logger.rs:368:16 [INFO] [stdout] | [INFO] [stdout] 368 | if keys.contains_key(elm.0) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!keys.contains_key(elm.0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/logger.rs:393:16 [INFO] [stdout] | [INFO] [stdout] 393 | if keys2.contains_key(elm) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!keys2.contains_key(elm)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/logger.rs:398:16 [INFO] [stdout] | [INFO] [stdout] 398 | if keys.contains_key(elm) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!keys.contains_key(elm)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/logger.rs:417:12 [INFO] [stdout] | [INFO] [stdout] 417 | if res["acknowledged"].is_boolean() == false [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!res["acknowledged"].is_boolean()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/logger.rs:418:16 [INFO] [stdout] | [INFO] [stdout] 418 | || res["acknowledged"].as_bool().unwrap() == false [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!res["acknowledged"].as_bool().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | return re.is_match(str); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return re.is_match(str); [INFO] [stdout] 28 + re.is_match(str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server.rs:140:12 [INFO] [stdout] | [INFO] [stdout] 140 | if !search_response.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `search_response.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server.rs:147:12 [INFO] [stdout] | [INFO] [stdout] 147 | if !response.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `response.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 158 | return response_body.get("count").unwrap().as_i64().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 158 - return response_body.get("count").unwrap().as_i64().unwrap(); [INFO] [stdout] 158 + response_body.get("count").unwrap().as_i64().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server.rs:183:12 [INFO] [stdout] | [INFO] [stdout] 183 | if !delete_query.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `delete_query.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server.rs:191:12 [INFO] [stdout] | [INFO] [stdout] 191 | if !response.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `response.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server.rs:269:16 [INFO] [stdout] | [INFO] [stdout] 269 | if !search_response.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `search_response.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server.rs:277:16 [INFO] [stdout] | [INFO] [stdout] 277 | if !response.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `response.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server.rs:289:16 [INFO] [stdout] | [INFO] [stdout] 289 | if !failed.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `failed.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 22s [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server.rs:380:12 [INFO] [stdout] | [INFO] [stdout] 380 | if !response.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `response.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: openssl v0.10.41 [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server.rs:387:12 [INFO] [stdout] | [INFO] [stdout] 387 | if !response.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `response.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 4` [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/server.rs:394:26 [INFO] [stdout] | [INFO] [stdout] 394 | let successful = response_body["errors"].as_bool().unwrap_or(false) == false; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!response_body["errors"].as_bool().unwrap_or(false)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/server.rs:427:12 [INFO] [stdout] | [INFO] [stdout] 427 | if self.index == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.index.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/server.rs:507:12 [INFO] [stdout] | [INFO] [stdout] 507 | if is_json(text.as_ref().unwrap().as_str()).is_ok() == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!is_json(text.as_ref().unwrap().as_str()).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | return new_path; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return new_path; [INFO] [stdout] 28 + new_path [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/utils.rs:15:31 [INFO] [stdout] | [INFO] [stdout] 15 | for (_, c) in path.chars().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 15 - for (_, c) in path.chars().enumerate() { [INFO] [stdout] 15 + for c in path.chars() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/utils.rs:18:16 [INFO] [stdout] | [INFO] [stdout] 18 | } else if c == '/' { [INFO] [stdout] | ________________^ [INFO] [stdout] 19 | | is_slash = true; [INFO] [stdout] 20 | | } else { [INFO] [stdout] 21 | | is_slash = false; [INFO] [stdout] 22 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `{ is_slash = c == '/'; }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should use the `ends_with` method [INFO] [stdout] --> src/utils.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 25 | if new_path.chars().last().unwrap() != '/' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `!new_path.ends_with('/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stdout] = note: `#[warn(clippy::chars_last_cmp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/utils.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | if Path::new(loc2.as_str()).exists() == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!Path::new(loc2.as_str()).exists()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/utils.rs:38:8 [INFO] [stdout] | [INFO] [stdout] 38 | if Path::new(loc2.as_str()).is_dir() == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!Path::new(loc2.as_str()).is_dir()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 62 | return newdate; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return newdate; [INFO] [stdout] 62 + newdate [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:70:8 [INFO] [stdout] | [INFO] [stdout] 70 | if !file_res.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `file_res.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:76:8 [INFO] [stdout] | [INFO] [stdout] 76 | if !res.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `res.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/utils.rs:81:40 [INFO] [stdout] | [INFO] [stdout] 81 | fs::remove_file(file_path.clone()).expect( [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 82 | | format!( [INFO] [stdout] 83 | | "The program crashed, you need to go delete {} manually", [INFO] [stdout] 84 | | file_path [INFO] [stdout] 85 | | ) [INFO] [stdout] 86 | | .as_str(), [INFO] [stdout] 87 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 81 ~ fs::remove_file(file_path.clone()).unwrap_or_else(|_| panic!("The program crashed, you need to go delete {} manually", [INFO] [stdout] 82 ~ file_path)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | return epoch; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return epoch; [INFO] [stdout] 28 + epoch [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "916176f5193592185b51b7449f9f4e5ea111c6e9b193f8ce6967108790c2764b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "916176f5193592185b51b7449f9f4e5ea111c6e9b193f8ce6967108790c2764b", kill_on_drop: false }` [INFO] [stdout] 916176f5193592185b51b7449f9f4e5ea111c6e9b193f8ce6967108790c2764b