[INFO] cloning repository https://github.com/Cs4r/tsp-rust
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Cs4r/tsp-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCs4r%2Ftsp-rust", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCs4r%2Ftsp-rust'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] f9dbf3581aa3f2b81083e5ad6a349351ccd98ccf
[INFO] linting Cs4r/tsp-rust against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCs4r%2Ftsp-rust" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/Cs4r/tsp-rust
[INFO] finished tweaking git repo https://github.com/Cs4r/tsp-rust
[INFO] tweaked toml for git repo https://github.com/Cs4r/tsp-rust written to /workspace/builds/worker-0-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/Cs4r/tsp-rust on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/Cs4r/tsp-rust already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 583885ac350088cc3c5a5a7798936ea6161cf5a26e1e7edf06425abbbea0e793
[INFO] running `Command { std: "docker" "start" "-a" "583885ac350088cc3c5a5a7798936ea6161cf5a26e1e7edf06425abbbea0e793", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "583885ac350088cc3c5a5a7798936ea6161cf5a26e1e7edf06425abbbea0e793", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "583885ac350088cc3c5a5a7798936ea6161cf5a26e1e7edf06425abbbea0e793", kill_on_drop: false }`
[INFO] [stdout] 583885ac350088cc3c5a5a7798936ea6161cf5a26e1e7edf06425abbbea0e793
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 6445beb99451ebcd950be85de2e52c8dd4d02158f005fbb4c8287c743cf7c0b8
[INFO] running `Command { std: "docker" "start" "-a" "6445beb99451ebcd950be85de2e52c8dd4d02158f005fbb4c8287c743cf7c0b8", kill_on_drop: false }`
[INFO] [stderr]     Checking getrandom v0.2.16
[INFO] [stderr]     Checking rand_core v0.6.4
[INFO] [stderr]     Checking rand_chacha v0.3.1
[INFO] [stderr]     Checking rand v0.8.5
[INFO] [stderr]     Checking tsp-rust v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: value assigned to `best_path` is never read
[INFO] [stdout]   --> src/algs/random_search.rs:16:13
[INFO] [stdout]    |
[INFO] [stdout] 16 |             best_path = current_path;
[INFO] [stdout]    |             ^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: maybe it is overwritten before being read?
[INFO] [stdout]    = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/cli/utils.rs:41:52
[INFO] [stdout]    |
[INFO] [stdout] 41 |             let parts: Vec<&str> = to_parts(&line, &":");
[INFO] [stdout]    |                                                    ^^^^ help: change this to: `":"`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/cli/utils.rs:44:41
[INFO] [stdout]    |
[INFO] [stdout] 44 |             let parts = to_parts(&line, &" ");
[INFO] [stdout]    |                                         ^^^^ help: change this to: `" "`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/cli/utils.rs:79:12
[INFO] [stdout]    |
[INFO] [stdout] 79 |         || (!seed_required && !(args.len() == 2 || args.len() == 3))
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(seed_required || args.len() == 2 || args.len() == 3)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: accessing first element with `args.get(0)`
[INFO] [stdout]   --> src/cli/utils.rs:74:24
[INFO] [stdout]    |
[INFO] [stdout] 74 |     let program_name = args.get(0).map_or("program", String::as_str);
[INFO] [stdout]    |                        ^^^^^^^^^^^ help: try: `args.first()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
[INFO] [stdout]    = note: `#[warn(clippy::get_first)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]  --> src/algs/random_search.rs:6:41
[INFO] [stdout]   |
[INFO] [stdout] 6 |     let problem_size = get_problem_size(&distance_matrix);
[INFO] [stdout]   |                                         ^^^^^^^^^^^^^^^^ help: change this to: `distance_matrix`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]  --> src/algs/random_search.rs:8:50
[INFO] [stdout]   |
[INFO] [stdout] 8 |     let mut best_cost = compute_cost(&best_path, &distance_matrix);
[INFO] [stdout]   |                                                  ^^^^^^^^^^^^^^^^ help: change this to: `distance_matrix`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/algs/random_search.rs:12:56
[INFO] [stdout]    |
[INFO] [stdout] 12 |         let current_cost = compute_cost(&current_path, &distance_matrix);
[INFO] [stdout]    |                                                        ^^^^^^^^^^^^^^^^ help: change this to: `distance_matrix`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]  --> src/algs/deterministic_greedy.rs:5:41
[INFO] [stdout]   |
[INFO] [stdout] 5 |     let problem_size = get_problem_size(&distance_matrix);
[INFO] [stdout]   |                                         ^^^^^^^^^^^^^^^^ help: change this to: `distance_matrix`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `city` is used to index `distance_matrix`
[INFO] [stdout]   --> src/algs/deterministic_greedy.rs:14:17
[INFO] [stdout]    |
[INFO] [stdout] 14 |     for city in 1..problem_size {
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]    = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator and enumerate()
[INFO] [stdout]    |
[INFO] [stdout] 14 -     for city in 1..problem_size {
[INFO] [stdout] 14 +     for (city, <item>) in distance_matrix.iter().enumerate().take(problem_size).skip(1) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is only used to index `tour`
[INFO] [stdout]   --> src/algs/deterministic_greedy.rs:35:14
[INFO] [stdout]    |
[INFO] [stdout] 35 |     for i in 1..problem_size {
[INFO] [stdout]    |              ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout] help: consider using an iterator
[INFO] [stdout]    |
[INFO] [stdout] 35 -     for i in 1..problem_size {
[INFO] [stdout] 35 +     for <item> in tour.iter_mut().take(problem_size).skip(1) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: value assigned to `best_path` is never read
[INFO] [stdout]   --> src/algs/random_search.rs:16:13
[INFO] [stdout]    |
[INFO] [stdout] 16 |             best_path = current_path;
[INFO] [stdout]    |             ^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: maybe it is overwritten before being read?
[INFO] [stdout]    = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/cli/utils.rs:41:52
[INFO] [stdout]    |
[INFO] [stdout] 41 |             let parts: Vec<&str> = to_parts(&line, &":");
[INFO] [stdout]    |                                                    ^^^^ help: change this to: `":"`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/cli/utils.rs:44:41
[INFO] [stdout]    |
[INFO] [stdout] 44 |             let parts = to_parts(&line, &" ");
[INFO] [stdout]    |                                         ^^^^ help: change this to: `" "`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/cli/utils.rs:79:12
[INFO] [stdout]    |
[INFO] [stdout] 79 |         || (!seed_required && !(args.len() == 2 || args.len() == 3))
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(seed_required || args.len() == 2 || args.len() == 3)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: accessing first element with `args.get(0)`
[INFO] [stdout]   --> src/cli/utils.rs:74:24
[INFO] [stdout]    |
[INFO] [stdout] 74 |     let program_name = args.get(0).map_or("program", String::as_str);
[INFO] [stdout]    |                        ^^^^^^^^^^^ help: try: `args.first()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
[INFO] [stdout]    = note: `#[warn(clippy::get_first)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]  --> src/algs/random_search.rs:6:41
[INFO] [stdout]   |
[INFO] [stdout] 6 |     let problem_size = get_problem_size(&distance_matrix);
[INFO] [stdout]   |                                         ^^^^^^^^^^^^^^^^ help: change this to: `distance_matrix`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]  --> src/algs/random_search.rs:8:50
[INFO] [stdout]   |
[INFO] [stdout] 8 |     let mut best_cost = compute_cost(&best_path, &distance_matrix);
[INFO] [stdout]   |                                                  ^^^^^^^^^^^^^^^^ help: change this to: `distance_matrix`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/algs/random_search.rs:12:56
[INFO] [stdout]    |
[INFO] [stdout] 12 |         let current_cost = compute_cost(&current_path, &distance_matrix);
[INFO] [stdout]    |                                                        ^^^^^^^^^^^^^^^^ help: change this to: `distance_matrix`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]  --> src/algs/deterministic_greedy.rs:5:41
[INFO] [stdout]   |
[INFO] [stdout] 5 |     let problem_size = get_problem_size(&distance_matrix);
[INFO] [stdout]   |                                         ^^^^^^^^^^^^^^^^ help: change this to: `distance_matrix`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `city` is used to index `distance_matrix`
[INFO] [stdout]   --> src/algs/deterministic_greedy.rs:14:17
[INFO] [stdout]    |
[INFO] [stdout] 14 |     for city in 1..problem_size {
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]    = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator and enumerate()
[INFO] [stdout]    |
[INFO] [stdout] 14 -     for city in 1..problem_size {
[INFO] [stdout] 14 +     for (city, <item>) in distance_matrix.iter().enumerate().take(problem_size).skip(1) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is only used to index `tour`
[INFO] [stdout]   --> src/algs/deterministic_greedy.rs:35:14
[INFO] [stdout]    |
[INFO] [stdout] 35 |     for i in 1..problem_size {
[INFO] [stdout]    |              ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout] help: consider using an iterator
[INFO] [stdout]    |
[INFO] [stdout] 35 -     for i in 1..problem_size {
[INFO] [stdout] 35 +     for <item> in tour.iter_mut().take(problem_size).skip(1) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `get_problem_size`
[INFO] [stdout]  --> bin/local_search.rs:3:58
[INFO] [stdout]   |
[INFO] [stdout] 3 | use tsp_rust::algs::utils::{create_rng_from_seed_string, get_problem_size};
[INFO] [stdout]   |                                                          ^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `get_problem_size`
[INFO] [stdout]  --> bin/local_search.rs:3:58
[INFO] [stdout]   |
[INFO] [stdout] 3 | use tsp_rust::algs::utils::{create_rng_from_seed_string, get_problem_size};
[INFO] [stdout]   |                                                          ^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.70s
[INFO] running `Command { std: "docker" "inspect" "6445beb99451ebcd950be85de2e52c8dd4d02158f005fbb4c8287c743cf7c0b8", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "6445beb99451ebcd950be85de2e52c8dd4d02158f005fbb4c8287c743cf7c0b8", kill_on_drop: false }`
[INFO] [stdout] 6445beb99451ebcd950be85de2e52c8dd4d02158f005fbb4c8287c743cf7c0b8