[INFO] cloning repository https://github.com/Cristiansen13/Shell-in-Rust
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Cristiansen13/Shell-in-Rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCristiansen13%2FShell-in-Rust", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCristiansen13%2FShell-in-Rust'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] f54492862c40749d890af91632c531f8e7c90a07
[INFO] linting Cristiansen13/Shell-in-Rust against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCristiansen13%2FShell-in-Rust" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/Cristiansen13/Shell-in-Rust
[INFO] finished tweaking git repo https://github.com/Cristiansen13/Shell-in-Rust
[INFO] tweaked toml for git repo https://github.com/Cristiansen13/Shell-in-Rust written to /workspace/builds/worker-6-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/Cristiansen13/Shell-in-Rust on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/Cristiansen13/Shell-in-Rust already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 245e15e32bde7b3b97be41bc51f6d5251dc26b9287692b9c156edce2ef40b28a
[INFO] running `Command { std: "docker" "start" "-a" "245e15e32bde7b3b97be41bc51f6d5251dc26b9287692b9c156edce2ef40b28a", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "245e15e32bde7b3b97be41bc51f6d5251dc26b9287692b9c156edce2ef40b28a", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "245e15e32bde7b3b97be41bc51f6d5251dc26b9287692b9c156edce2ef40b28a", kill_on_drop: false }`
[INFO] [stdout] 245e15e32bde7b3b97be41bc51f6d5251dc26b9287692b9c156edce2ef40b28a
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] f519d4894c47faf4094093b56ab9fcdc4d51e94ffeba4738383c0f198212327a
[INFO] running `Command { std: "docker" "start" "-a" "f519d4894c47faf4094093b56ab9fcdc4d51e94ffeba4738383c0f198212327a", kill_on_drop: false }`
[INFO] [stderr]     Checking rustybox v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:197:8
[INFO] [stdout]     |
[INFO] [stdout] 197 |     if !fs::metadata(source).is_ok() {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(source).is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/main.rs:184:5
[INFO] [stdout]     |
[INFO] [stdout] 184 | /     if args.len() > 3 {
[INFO] [stdout] 185 | |         if args[2] == "-r" || args[2] == "-R" || args[2] == "--recursive" {
[INFO] [stdout] 186 | |             recursive = true;
[INFO] [stdout] 187 | |             source_index += 1;
[INFO] [stdout] ...   |
[INFO] [stdout] 190 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 184 ~     if args.len() > 3
[INFO] [stdout] 185 ~         && (args[2] == "-r" || args[2] == "-R" || args[2] == "--recursive") {
[INFO] [stdout] 186 |             recursive = true;
[INFO] [stdout] 187 |             source_index += 1;
[INFO] [stdout] 188 |             destination_index += 1;
[INFO] [stdout] 189 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]    --> src/main.rs:277:12
[INFO] [stdout]     |
[INFO] [stdout] 277 |         if permissions_str.chars().nth(0).unwrap() == '-' {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `permissions_str.chars().next()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout]     = note: `#[warn(clippy::iter_nth_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used
[INFO] [stdout]    --> src/main.rs:329:9
[INFO] [stdout]     |
[INFO] [stdout] 329 | /         for entry in entries {
[INFO] [stdout] 330 | |             if let Ok(entry) = entry {
[INFO] [stdout] 331 | |                 if let Some(file_name) = entry.file_name().to_str() {
[INFO] [stdout] 332 | |                     if show_hidden || !file_name.starts_with('.') {
[INFO] [stdout] ...   |
[INFO] [stdout] 342 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop
[INFO] [stdout]    --> src/main.rs:330:13
[INFO] [stdout]     |
[INFO] [stdout] 330 | /             if let Ok(entry) = entry {
[INFO] [stdout] 331 | |                 if let Some(file_name) = entry.file_name().to_str() {
[INFO] [stdout] 332 | |                     if show_hidden || !file_name.starts_with('.') {
[INFO] [stdout] 333 | |                         if recursive && entry.file_type().unwrap().is_dir() {
[INFO] [stdout] ...   |
[INFO] [stdout] 341 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten
[INFO] [stdout]     = note: `#[warn(clippy::manual_flatten)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 329 ~         for entry in entries.flatten() {
[INFO] [stdout] 330 +             if let Some(file_name) = entry.file_name().to_str() {
[INFO] [stdout] 331 +                 if show_hidden || !file_name.starts_with('.') {
[INFO] [stdout] 332 +                     if recursive && entry.file_type().unwrap().is_dir() {
[INFO] [stdout] 333 +                         println!("{}", entry.path().display());
[INFO] [stdout] 334 +                         list_directory_contents(&entry.path().to_str().unwrap(), show_hidden, recursive);
[INFO] [stdout] 335 +                     } else {
[INFO] [stdout] 336 +                         println!("{}", entry.path().file_name().unwrap().to_str().unwrap());
[INFO] [stdout] 337 +                     }
[INFO] [stdout] 338 +                 }
[INFO] [stdout] 339 +             }
[INFO] [stdout] 340 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/main.rs:335:53
[INFO] [stdout]     |
[INFO] [stdout] 335 | ...                   list_directory_contents(&entry.path().to_str().unwrap(), show_hidden, recursive);
[INFO] [stdout]     |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `entry.path().to_str().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:197:8
[INFO] [stdout]     |
[INFO] [stdout] 197 |     if !fs::metadata(source).is_ok() {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(source).is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/main.rs:184:5
[INFO] [stdout]     |
[INFO] [stdout] 184 | /     if args.len() > 3 {
[INFO] [stdout] 185 | |         if args[2] == "-r" || args[2] == "-R" || args[2] == "--recursive" {
[INFO] [stdout] 186 | |             recursive = true;
[INFO] [stdout] 187 | |             source_index += 1;
[INFO] [stdout] ...   |
[INFO] [stdout] 190 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 184 ~     if args.len() > 3
[INFO] [stdout] 185 ~         && (args[2] == "-r" || args[2] == "-R" || args[2] == "--recursive") {
[INFO] [stdout] 186 |             recursive = true;
[INFO] [stdout] 187 |             source_index += 1;
[INFO] [stdout] 188 |             destination_index += 1;
[INFO] [stdout] 189 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]    --> src/main.rs:277:12
[INFO] [stdout]     |
[INFO] [stdout] 277 |         if permissions_str.chars().nth(0).unwrap() == '-' {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `permissions_str.chars().next()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout]     = note: `#[warn(clippy::iter_nth_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used
[INFO] [stdout]    --> src/main.rs:329:9
[INFO] [stdout]     |
[INFO] [stdout] 329 | /         for entry in entries {
[INFO] [stdout] 330 | |             if let Ok(entry) = entry {
[INFO] [stdout] 331 | |                 if let Some(file_name) = entry.file_name().to_str() {
[INFO] [stdout] 332 | |                     if show_hidden || !file_name.starts_with('.') {
[INFO] [stdout] ...   |
[INFO] [stdout] 342 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop
[INFO] [stdout]    --> src/main.rs:330:13
[INFO] [stdout]     |
[INFO] [stdout] 330 | /             if let Ok(entry) = entry {
[INFO] [stdout] 331 | |                 if let Some(file_name) = entry.file_name().to_str() {
[INFO] [stdout] 332 | |                     if show_hidden || !file_name.starts_with('.') {
[INFO] [stdout] 333 | |                         if recursive && entry.file_type().unwrap().is_dir() {
[INFO] [stdout] ...   |
[INFO] [stdout] 341 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten
[INFO] [stdout]     = note: `#[warn(clippy::manual_flatten)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 329 ~         for entry in entries.flatten() {
[INFO] [stdout] 330 +             if let Some(file_name) = entry.file_name().to_str() {
[INFO] [stdout] 331 +                 if show_hidden || !file_name.starts_with('.') {
[INFO] [stdout] 332 +                     if recursive && entry.file_type().unwrap().is_dir() {
[INFO] [stdout] 333 +                         println!("{}", entry.path().display());
[INFO] [stdout] 334 +                         list_directory_contents(&entry.path().to_str().unwrap(), show_hidden, recursive);
[INFO] [stdout] 335 +                     } else {
[INFO] [stdout] 336 +                         println!("{}", entry.path().file_name().unwrap().to_str().unwrap());
[INFO] [stdout] 337 +                     }
[INFO] [stdout] 338 +                 }
[INFO] [stdout] 339 +             }
[INFO] [stdout] 340 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/main.rs:335:53
[INFO] [stdout]     |
[INFO] [stdout] 335 | ...                   list_directory_contents(&entry.path().to_str().unwrap(), show_hidden, recursive);
[INFO] [stdout]     |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `entry.path().to_str().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.26s
[INFO] running `Command { std: "docker" "inspect" "f519d4894c47faf4094093b56ab9fcdc4d51e94ffeba4738383c0f198212327a", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "f519d4894c47faf4094093b56ab9fcdc4d51e94ffeba4738383c0f198212327a", kill_on_drop: false }`
[INFO] [stdout] f519d4894c47faf4094093b56ab9fcdc4d51e94ffeba4738383c0f198212327a