[INFO] cloning repository https://github.com/Course-Brains/tic-tac-test [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Course-Brains/tic-tac-test" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCourse-Brains%2Ftic-tac-test", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCourse-Brains%2Ftic-tac-test'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c7bed089885e1982c5cba386f2024d5c43cea667 [INFO] linting Course-Brains/tic-tac-test against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCourse-Brains%2Ftic-tac-test" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Course-Brains/tic-tac-test [INFO] finished tweaking git repo https://github.com/Course-Brains/tic-tac-test [INFO] tweaked toml for git repo https://github.com/Course-Brains/tic-tac-test written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Course-Brains/tic-tac-test on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Course-Brains/tic-tac-test already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 162a819096951d9b9cb20a0002e2238bd3a674ad178eae23172fcf53ad913d3d [INFO] running `Command { std: "docker" "start" "-a" "162a819096951d9b9cb20a0002e2238bd3a674ad178eae23172fcf53ad913d3d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "162a819096951d9b9cb20a0002e2238bd3a674ad178eae23172fcf53ad913d3d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "162a819096951d9b9cb20a0002e2238bd3a674ad178eae23172fcf53ad913d3d", kill_on_drop: false }` [INFO] [stdout] 162a819096951d9b9cb20a0002e2238bd3a674ad178eae23172fcf53ad913d3d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3b89caceec1e56e4cdbbf24b87976f5703675ce126ede2bb9bac53cb9a9eab09 [INFO] running `Command { std: "docker" "start" "-a" "3b89caceec1e56e4cdbbf24b87976f5703675ce126ede2bb9bac53cb9a9eab09", kill_on_drop: false }` [INFO] [stderr] Checking rusttest v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:14:3 [INFO] [stdout] | [INFO] [stdout] 14 | / return Board { [INFO] [stdout] 15 | | board:[ [INFO] [stdout] 16 | | [String::from(" "),String::from(" "),String::from(" ")], [INFO] [stdout] 17 | | [String::from(" "),String::from(" "),String::from(" ")], [INFO] [stdout] ... | [INFO] [stdout] 20 | | turn: String::from("o") [INFO] [stdout] 21 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Board { [INFO] [stdout] 15 ~ board:[ [INFO] [stdout] 16 ~ [String::from(" "),String::from(" "),String::from(" ")], [INFO] [stdout] 17 ~ [String::from(" "),String::from(" "),String::from(" ")], [INFO] [stdout] 18 ~ [String::from(" "),String::from(" "),String::from(" ")] [INFO] [stdout] 19 ~ ], [INFO] [stdout] 20 ~ turn: String::from("o") [INFO] [stdout] 21 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:32:3 [INFO] [stdout] | [INFO] [stdout] 32 | return true [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return true [INFO] [stdout] 32 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:54:7 [INFO] [stdout] | [INFO] [stdout] 54 | ... if !(row[1] == " "){// if even one is a space then it fails, allows us to not have to check the others because even if it make... [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `(row[1] != " ")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:62:7 [INFO] [stdout] | [INFO] [stdout] 62 | if !(self.board[0][i] == " "){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.board[0][i] != " ")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:69:6 [INFO] [stdout] | [INFO] [stdout] 69 | if !(self.board[1][1] == " "){// only need one check because both pass through [1][1] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.board[1][1] != " ")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:87:3 [INFO] [stdout] | [INFO] [stdout] 87 | / return Out { [INFO] [stdout] 88 | | valid: false, [INFO] [stdout] 89 | | x: check[0], [INFO] [stdout] 90 | | y: check[1] [INFO] [stdout] 91 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 ~ Out { [INFO] [stdout] 88 ~ valid: false, [INFO] [stdout] 89 ~ x: check[0], [INFO] [stdout] 90 ~ y: check[1] [INFO] [stdout] 91 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `usize` [INFO] [stdout] --> src/main.rs:57:15 [INFO] [stdout] | [INFO] [stdout] 57 | check = [index.try_into().unwrap(),1]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:62:4 [INFO] [stdout] | [INFO] [stdout] 62 | / if !(self.board[0][i] == " "){ [INFO] [stdout] 63 | | if self.board[0][i] == self.board[1][i] && self.board[1][i] == self.board[2][i] { [INFO] [stdout] 64 | | valid = false; [INFO] [stdout] 65 | | check = [1,i.try_into().unwrap()]; [INFO] [stdout] 66 | | } [INFO] [stdout] 67 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 62 ~ if !(self.board[0][i] == " ") [INFO] [stdout] 63 ~ && self.board[0][i] == self.board[1][i] && self.board[1][i] == self.board[2][i] { [INFO] [stdout] 64 | valid = false; [INFO] [stdout] 65 | check = [1,i.try_into().unwrap()]; [INFO] [stdout] 66 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `usize` [INFO] [stdout] --> src/main.rs:65:17 [INFO] [stdout] | [INFO] [stdout] 65 | check = [1,i.try_into().unwrap()]; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/main.rs:70:84 [INFO] [stdout] | [INFO] [stdout] 70 | if self.board[0][0] == self.board[1][1] && self.board[1][1] == self.board[2][2] { [INFO] [stdout] | _____________________________________________________________________________________________^ [INFO] [stdout] 71 | | valid = false; [INFO] [stdout] 72 | | check = [1,1]; [INFO] [stdout] 73 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/main.rs:74:89 [INFO] [stdout] | [INFO] [stdout] 74 | else if self.board[0][2] == self.board[1][1] && self.board[1][1] == self.board[2][0] { [INFO] [stdout] | __________________________________________________________________________________________________^ [INFO] [stdout] 75 | | valid = false; [INFO] [stdout] 76 | | check = [1,1]; [INFO] [stdout] 77 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/main.rs:100:20 [INFO] [stdout] | [INFO] [stdout] 100 | if self.turn == String::from("x") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"x"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/main.rs:136:21 [INFO] [stdout] | [INFO] [stdout] 136 | if self.turn == String::from("x"){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"x"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:160:2 [INFO] [stdout] | [INFO] [stdout] 160 | return input [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 160 - return input [INFO] [stdout] 160 + input [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:14:3 [INFO] [stdout] | [INFO] [stdout] 14 | / return Board { [INFO] [stdout] 15 | | board:[ [INFO] [stdout] 16 | | [String::from(" "),String::from(" "),String::from(" ")], [INFO] [stdout] 17 | | [String::from(" "),String::from(" "),String::from(" ")], [INFO] [stdout] ... | [INFO] [stdout] 20 | | turn: String::from("o") [INFO] [stdout] 21 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ Board { [INFO] [stdout] 15 ~ board:[ [INFO] [stdout] 16 ~ [String::from(" "),String::from(" "),String::from(" ")], [INFO] [stdout] 17 ~ [String::from(" "),String::from(" "),String::from(" ")], [INFO] [stdout] 18 ~ [String::from(" "),String::from(" "),String::from(" ")] [INFO] [stdout] 19 ~ ], [INFO] [stdout] 20 ~ turn: String::from("o") [INFO] [stdout] 21 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:32:3 [INFO] [stdout] | [INFO] [stdout] 32 | return true [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return true [INFO] [stdout] 32 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:54:7 [INFO] [stdout] | [INFO] [stdout] 54 | ... if !(row[1] == " "){// if even one is a space then it fails, allows us to not have to check the others because even if it make... [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `(row[1] != " ")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:62:7 [INFO] [stdout] | [INFO] [stdout] 62 | if !(self.board[0][i] == " "){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.board[0][i] != " ")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:69:6 [INFO] [stdout] | [INFO] [stdout] 69 | if !(self.board[1][1] == " "){// only need one check because both pass through [1][1] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.board[1][1] != " ")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:87:3 [INFO] [stdout] | [INFO] [stdout] 87 | / return Out { [INFO] [stdout] 88 | | valid: false, [INFO] [stdout] 89 | | x: check[0], [INFO] [stdout] 90 | | y: check[1] [INFO] [stdout] 91 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 ~ Out { [INFO] [stdout] 88 ~ valid: false, [INFO] [stdout] 89 ~ x: check[0], [INFO] [stdout] 90 ~ y: check[1] [INFO] [stdout] 91 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `usize` [INFO] [stdout] --> src/main.rs:57:15 [INFO] [stdout] | [INFO] [stdout] 57 | check = [index.try_into().unwrap(),1]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:62:4 [INFO] [stdout] | [INFO] [stdout] 62 | / if !(self.board[0][i] == " "){ [INFO] [stdout] 63 | | if self.board[0][i] == self.board[1][i] && self.board[1][i] == self.board[2][i] { [INFO] [stdout] 64 | | valid = false; [INFO] [stdout] 65 | | check = [1,i.try_into().unwrap()]; [INFO] [stdout] 66 | | } [INFO] [stdout] 67 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 62 ~ if !(self.board[0][i] == " ") [INFO] [stdout] 63 ~ && self.board[0][i] == self.board[1][i] && self.board[1][i] == self.board[2][i] { [INFO] [stdout] 64 | valid = false; [INFO] [stdout] 65 | check = [1,i.try_into().unwrap()]; [INFO] [stdout] 66 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `usize` [INFO] [stdout] --> src/main.rs:65:17 [INFO] [stdout] | [INFO] [stdout] 65 | check = [1,i.try_into().unwrap()]; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/main.rs:70:84 [INFO] [stdout] | [INFO] [stdout] 70 | if self.board[0][0] == self.board[1][1] && self.board[1][1] == self.board[2][2] { [INFO] [stdout] | _____________________________________________________________________________________________^ [INFO] [stdout] 71 | | valid = false; [INFO] [stdout] 72 | | check = [1,1]; [INFO] [stdout] 73 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/main.rs:74:89 [INFO] [stdout] | [INFO] [stdout] 74 | else if self.board[0][2] == self.board[1][1] && self.board[1][1] == self.board[2][0] { [INFO] [stdout] | __________________________________________________________________________________________________^ [INFO] [stdout] 75 | | valid = false; [INFO] [stdout] 76 | | check = [1,1]; [INFO] [stdout] 77 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/main.rs:100:20 [INFO] [stdout] | [INFO] [stdout] 100 | if self.turn == String::from("x") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"x"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/main.rs:136:21 [INFO] [stdout] | [INFO] [stdout] 136 | if self.turn == String::from("x"){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"x"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:160:2 [INFO] [stdout] | [INFO] [stdout] 160 | return input [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 160 - return input [INFO] [stdout] 160 + input [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.32s [INFO] running `Command { std: "docker" "inspect" "3b89caceec1e56e4cdbbf24b87976f5703675ce126ede2bb9bac53cb9a9eab09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3b89caceec1e56e4cdbbf24b87976f5703675ce126ede2bb9bac53cb9a9eab09", kill_on_drop: false }` [INFO] [stdout] 3b89caceec1e56e4cdbbf24b87976f5703675ce126ede2bb9bac53cb9a9eab09