[INFO] cloning repository https://github.com/Corgea/fastsecrets [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Corgea/fastsecrets" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCorgea%2Ffastsecrets", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCorgea%2Ffastsecrets'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ba1d4ab96027f0e4caa59ec004f1fcf5598dda68 [INFO] linting Corgea/fastsecrets against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCorgea%2Ffastsecrets" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Corgea/fastsecrets [INFO] finished tweaking git repo https://github.com/Corgea/fastsecrets [INFO] tweaked toml for git repo https://github.com/Corgea/fastsecrets written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Corgea/fastsecrets on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Corgea/fastsecrets already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded zmij v1.0.0 [INFO] [stderr] Downloaded pyo3-macros v0.27.2 [INFO] [stderr] Downloaded pyo3-build-config v0.27.2 [INFO] [stderr] Downloaded target-lexicon v0.13.4 [INFO] [stderr] Downloaded pyo3-ffi v0.27.2 [INFO] [stderr] Downloaded pyo3-macros-backend v0.27.2 [INFO] [stderr] Downloaded pyo3 v0.27.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 57ff532cd44f9099b62e12e161e6d78900566b52aadd027773fd1806bd8b6337 [INFO] running `Command { std: "docker" "start" "-a" "57ff532cd44f9099b62e12e161e6d78900566b52aadd027773fd1806bd8b6337", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "57ff532cd44f9099b62e12e161e6d78900566b52aadd027773fd1806bd8b6337", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "57ff532cd44f9099b62e12e161e6d78900566b52aadd027773fd1806bd8b6337", kill_on_drop: false }` [INFO] [stdout] 57ff532cd44f9099b62e12e161e6d78900566b52aadd027773fd1806bd8b6337 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fe3ed8ffb35ae51e26cb072fbd52e22afbddfce1226e9c721d84c32debed7c51 [INFO] running `Command { std: "docker" "start" "-a" "fe3ed8ffb35ae51e26cb072fbd52e22afbddfce1226e9c721d84c32debed7c51", kill_on_drop: false }` [INFO] [stderr] Compiling target-lexicon v0.13.4 [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Compiling serde_json v1.0.148 [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Checking zmij v1.0.0 [INFO] [stderr] Checking unindent v0.2.4 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Compiling pyo3-build-config v0.27.2 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Compiling pyo3-ffi v0.27.2 [INFO] [stderr] Compiling pyo3-macros-backend v0.27.2 [INFO] [stderr] Compiling pyo3 v0.27.2 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Compiling pyo3-macros v0.27.2 [INFO] [stderr] Checking fastsecrets v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/secrets/aws.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | /// All followed by 16 alphanumeric characters (uppercase and digits only) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 11 | /// All followed by 16 alphanumeric characters (uppercase and digits only) [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/secrets/aws.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | /// Total length: 20 characters [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 12 | /// Total length: 20 characters [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/secrets/aws.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | / if let Some(key_match) = AWS_ACCESS_KEY_PATTERN.find(secret) { [INFO] [stdout] 43 | | Some(( [INFO] [stdout] 44 | | "AWS Access Key ID".to_string(), [INFO] [stdout] 45 | | key_match.as_str().to_string(), [INFO] [stdout] ... | [INFO] [stdout] 48 | | None [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 42 ~ AWS_ACCESS_KEY_PATTERN.find(secret).map(|key_match| ( [INFO] [stdout] 43 + "AWS Access Key ID".to_string(), [INFO] [stdout] 44 + key_match.as_str().to_string(), [INFO] [stdout] 45 + )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/secrets/jwt.rs:43:16 [INFO] [stdout] | [INFO] [stdout] 43 | if !header_value.get("alg").is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `header_value.get("alg").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/secrets/npm.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | /// ref. https://stackoverflow.com/questions/53099434/using-auth-tokens-in-npmrc [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 8 | /// ref. https://stackoverflow.com/questions/53099434/using-auth-tokens-in-npmrc [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/lib.rs:62:29 [INFO] [stdout] | [INFO] [stdout] 62 | let mut detector_tasks: Vec Vec<(String, String)> + Send>> = vec![]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/lib.rs:202:18 [INFO] [stdout] | [INFO] [stdout] 202 | .map(|task| std::thread::spawn(task)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `std::thread::spawn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/secrets/aws.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | /// All followed by 16 alphanumeric characters (uppercase and digits only) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 11 | /// All followed by 16 alphanumeric characters (uppercase and digits only) [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/secrets/aws.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | /// Total length: 20 characters [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 12 | /// Total length: 20 characters [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/secrets/aws.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | / if let Some(key_match) = AWS_ACCESS_KEY_PATTERN.find(secret) { [INFO] [stdout] 43 | | Some(( [INFO] [stdout] 44 | | "AWS Access Key ID".to_string(), [INFO] [stdout] 45 | | key_match.as_str().to_string(), [INFO] [stdout] ... | [INFO] [stdout] 48 | | None [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 42 ~ AWS_ACCESS_KEY_PATTERN.find(secret).map(|key_match| ( [INFO] [stdout] 43 + "AWS Access Key ID".to_string(), [INFO] [stdout] 44 + key_match.as_str().to_string(), [INFO] [stdout] 45 + )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/secrets/jwt.rs:43:16 [INFO] [stdout] | [INFO] [stdout] 43 | if !header_value.get("alg").is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `header_value.get("alg").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/secrets/npm.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | /// ref. https://stackoverflow.com/questions/53099434/using-auth-tokens-in-npmrc [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 8 | /// ref. https://stackoverflow.com/questions/53099434/using-auth-tokens-in-npmrc [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/lib.rs:62:29 [INFO] [stdout] | [INFO] [stdout] 62 | let mut detector_tasks: Vec Vec<(String, String)> + Send>> = vec![]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/lib.rs:202:18 [INFO] [stdout] | [INFO] [stdout] 202 | .map(|task| std::thread::spawn(task)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `std::thread::spawn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 26.68s [INFO] running `Command { std: "docker" "inspect" "fe3ed8ffb35ae51e26cb072fbd52e22afbddfce1226e9c721d84c32debed7c51", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe3ed8ffb35ae51e26cb072fbd52e22afbddfce1226e9c721d84c32debed7c51", kill_on_drop: false }` [INFO] [stdout] fe3ed8ffb35ae51e26cb072fbd52e22afbddfce1226e9c721d84c32debed7c51