[INFO] cloning repository https://github.com/Colton923/aoc-2024 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Colton923/aoc-2024" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FColton923%2Faoc-2024", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FColton923%2Faoc-2024'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 805afe6bb14f0a9130d08fc93cb56d35861c593b [INFO] linting Colton923/aoc-2024 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FColton923%2Faoc-2024" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Colton923/aoc-2024 [INFO] finished tweaking git repo https://github.com/Colton923/aoc-2024 [INFO] tweaked toml for git repo https://github.com/Colton923/aoc-2024 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Colton923/aoc-2024 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Colton923/aoc-2024 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7fe04fa4a073e7c90a58576b41f790b181bbfa45baa18999124fd574f7dca987 [INFO] running `Command { std: "docker" "start" "-a" "7fe04fa4a073e7c90a58576b41f790b181bbfa45baa18999124fd574f7dca987", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7fe04fa4a073e7c90a58576b41f790b181bbfa45baa18999124fd574f7dca987", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7fe04fa4a073e7c90a58576b41f790b181bbfa45baa18999124fd574f7dca987", kill_on_drop: false }` [INFO] [stdout] 7fe04fa4a073e7c90a58576b41f790b181bbfa45baa18999124fd574f7dca987 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 390b9c388f05aeddd835ba5f1ba4130d573656730d2f59657eeba287511caefd [INFO] running `Command { std: "docker" "start" "-a" "390b9c388f05aeddd835ba5f1ba4130d573656730d2f59657eeba287511caefd", kill_on_drop: false }` [INFO] [stderr] Checking aoc-2024 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/day_1/mod.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | if (numbers.is_none()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 14 - if (numbers.is_none()) { [INFO] [stdout] 14 + if numbers.is_none() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/day_1/mod.rs:17:11 [INFO] [stdout] | [INFO] [stdout] 17 | if(numbers.unwrap().0.is_empty() || numbers.unwrap().1.is_empty()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 17 - if(numbers.unwrap().0.is_empty() || numbers.unwrap().1.is_empty()) { [INFO] [stdout] 17 + if numbers.unwrap().0.is_empty() || numbers.unwrap().1.is_empty() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/day_1/mod.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 50 | if (numbers.is_none()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 50 - if (numbers.is_none()) { [INFO] [stdout] 50 + if numbers.is_none() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/day_1/mod.rs:53:11 [INFO] [stdout] | [INFO] [stdout] 53 | if(numbers.unwrap().0.is_empty() || numbers.unwrap().1.is_empty()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 53 - if(numbers.unwrap().0.is_empty() || numbers.unwrap().1.is_empty()) { [INFO] [stdout] 53 + if numbers.unwrap().0.is_empty() || numbers.unwrap().1.is_empty() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/day_1/mod.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | if (numbers.is_none()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 14 - if (numbers.is_none()) { [INFO] [stdout] 14 + if numbers.is_none() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/day_1/mod.rs:17:11 [INFO] [stdout] | [INFO] [stdout] 17 | if(numbers.unwrap().0.is_empty() || numbers.unwrap().1.is_empty()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 17 - if(numbers.unwrap().0.is_empty() || numbers.unwrap().1.is_empty()) { [INFO] [stdout] 17 + if numbers.unwrap().0.is_empty() || numbers.unwrap().1.is_empty() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/day_1/mod.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 50 | if (numbers.is_none()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 50 - if (numbers.is_none()) { [INFO] [stdout] 50 + if numbers.is_none() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/day_1/mod.rs:53:11 [INFO] [stdout] | [INFO] [stdout] 53 | if(numbers.unwrap().0.is_empty() || numbers.unwrap().1.is_empty()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 53 - if(numbers.unwrap().0.is_empty() || numbers.unwrap().1.is_empty()) { [INFO] [stdout] 53 + if numbers.unwrap().0.is_empty() || numbers.unwrap().1.is_empty() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/day_3/mod.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 6 | let mut result = 0; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `content` [INFO] [stdout] --> src/day_3/mod.rs:5:25 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn solve_day_part_1(content: &str) -> i32 { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_content` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/day_3/mod.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | let mut result = 0; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `content` [INFO] [stdout] --> src/day_3/mod.rs:14:25 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn solve_day_part_2(content: &str) -> i32 { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_content` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/mod.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | return output; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return output; [INFO] [stdout] 45 + output [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day_1/mod.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return result; [INFO] [stdout] 40 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort` [INFO] [stdout] --> src/day_1/mod.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | items_a.sort_by(|a, b| a.cmp(&b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 28 - items_a.sort_by(|a, b| a.cmp(&b)); [INFO] [stdout] 28 + items_a.sort(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day_1/mod.rs:28:34 [INFO] [stdout] | [INFO] [stdout] 28 | items_a.sort_by(|a, b| a.cmp(&b)); [INFO] [stdout] | ^^ help: change this to: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort` [INFO] [stdout] --> src/day_1/mod.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | items_b.sort_by(|a, b| a.cmp(&b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 29 - items_b.sort_by(|a, b| a.cmp(&b)); [INFO] [stdout] 29 + items_b.sort(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day_1/mod.rs:29:34 [INFO] [stdout] | [INFO] [stdout] 29 | items_b.sort_by(|a, b| a.cmp(&b)); [INFO] [stdout] | ^^ help: change this to: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day_1/mod.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return result; [INFO] [stdout] 82 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day_2/mod.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | return num_list; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return num_list; [INFO] [stdout] 15 + num_list [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day_2/mod.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | if !num.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `num.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `num` after checking its variant with `is_err` [INFO] [stdout] --> src/day_2/mod.rs:12:27 [INFO] [stdout] | [INFO] [stdout] 11 | if !num.is_err() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 12 | num_list.push(num.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day_2/mod.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return result; [INFO] [stdout] 58 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: inequality checks against true can be replaced by a negation [INFO] [stdout] --> src/day_2/mod.rs:42:20 [INFO] [stdout] | [INFO] [stdout] 42 | if direction != true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `!direction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: inequality checks against false are unnecessary [INFO] [stdout] --> src/day_2/mod.rs:46:20 [INFO] [stdout] | [INFO] [stdout] 46 | if direction != false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `direction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/day_3/mod.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 6 | let mut result = 0; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `content` [INFO] [stdout] --> src/day_3/mod.rs:5:25 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn solve_day_part_1(content: &str) -> i32 { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_content` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/day_3/mod.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | let mut result = 0; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `content` [INFO] [stdout] --> src/day_3/mod.rs:14:25 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn solve_day_part_2(content: &str) -> i32 { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_content` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/mod.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | return output; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return output; [INFO] [stdout] 45 + output [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day_1/mod.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return result; [INFO] [stdout] 40 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort` [INFO] [stdout] --> src/day_1/mod.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | items_a.sort_by(|a, b| a.cmp(&b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 28 - items_a.sort_by(|a, b| a.cmp(&b)); [INFO] [stdout] 28 + items_a.sort(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day_1/mod.rs:28:34 [INFO] [stdout] | [INFO] [stdout] 28 | items_a.sort_by(|a, b| a.cmp(&b)); [INFO] [stdout] | ^^ help: change this to: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort` [INFO] [stdout] --> src/day_1/mod.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | items_b.sort_by(|a, b| a.cmp(&b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 29 - items_b.sort_by(|a, b| a.cmp(&b)); [INFO] [stdout] 29 + items_b.sort(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day_1/mod.rs:29:34 [INFO] [stdout] | [INFO] [stdout] 29 | items_b.sort_by(|a, b| a.cmp(&b)); [INFO] [stdout] | ^^ help: change this to: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day_1/mod.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return result; [INFO] [stdout] 82 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day_2/mod.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | return num_list; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return num_list; [INFO] [stdout] 15 + num_list [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day_2/mod.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | if !num.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `num.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `num` after checking its variant with `is_err` [INFO] [stdout] --> src/day_2/mod.rs:12:27 [INFO] [stdout] | [INFO] [stdout] 11 | if !num.is_err() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 12 | num_list.push(num.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day_2/mod.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return result; [INFO] [stdout] 58 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: inequality checks against true can be replaced by a negation [INFO] [stdout] --> src/day_2/mod.rs:42:20 [INFO] [stdout] | [INFO] [stdout] 42 | if direction != true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `!direction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: inequality checks against false are unnecessary [INFO] [stdout] --> src/day_2/mod.rs:46:20 [INFO] [stdout] | [INFO] [stdout] 46 | if direction != false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `direction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.36s [INFO] running `Command { std: "docker" "inspect" "390b9c388f05aeddd835ba5f1ba4130d573656730d2f59657eeba287511caefd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "390b9c388f05aeddd835ba5f1ba4130d573656730d2f59657eeba287511caefd", kill_on_drop: false }` [INFO] [stdout] 390b9c388f05aeddd835ba5f1ba4130d573656730d2f59657eeba287511caefd