[INFO] cloning repository https://github.com/ChillyCoyote273/advent_of_code_2023 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ChillyCoyote273/advent_of_code_2023" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FChillyCoyote273%2Fadvent_of_code_2023", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FChillyCoyote273%2Fadvent_of_code_2023'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1d96e6ce60c680aa2c280f5d1748a9f0f8be5935 [INFO] linting ChillyCoyote273/advent_of_code_2023 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FChillyCoyote273%2Fadvent_of_code_2023" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ChillyCoyote273/advent_of_code_2023 [INFO] finished tweaking git repo https://github.com/ChillyCoyote273/advent_of_code_2023 [INFO] tweaked toml for git repo https://github.com/ChillyCoyote273/advent_of_code_2023 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ChillyCoyote273/advent_of_code_2023 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ChillyCoyote273/advent_of_code_2023 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 15208aa74b5ded67bb9cfaf9ed2590ce8320c5466bb2c6e4f004a3f4ca1f2126 [INFO] running `Command { std: "docker" "start" "-a" "15208aa74b5ded67bb9cfaf9ed2590ce8320c5466bb2c6e4f004a3f4ca1f2126", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "15208aa74b5ded67bb9cfaf9ed2590ce8320c5466bb2c6e4f004a3f4ca1f2126", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "15208aa74b5ded67bb9cfaf9ed2590ce8320c5466bb2c6e4f004a3f4ca1f2126", kill_on_drop: false }` [INFO] [stdout] 15208aa74b5ded67bb9cfaf9ed2590ce8320c5466bb2c6e4f004a3f4ca1f2126 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5e111bb2a69a13a694d0a6d45e0a79becaee527ee5f03e0bb81594b6f976fc41 [INFO] running `Command { std: "docker" "start" "-a" "5e111bb2a69a13a694d0a6d45e0a79becaee527ee5f03e0bb81594b6f976fc41", kill_on_drop: false }` [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking itertools v0.12.0 [INFO] [stderr] Checking advent_of_code_2023 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the loop variable `i` is used to index `universe` [INFO] [stdout] --> src/days/day_11.rs:38:14 [INFO] [stdout] | [INFO] [stdout] 38 | for i in 0..universe.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 38 - for i in 0..universe.len() { [INFO] [stdout] 38 + for (i, ) in universe.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `universe` [INFO] [stdout] --> src/days/day_11.rs:39:18 [INFO] [stdout] | [INFO] [stdout] 39 | for j in 0..universe[i].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 39 - for j in 0..universe[i].len() { [INFO] [stdout] 39 + for (j, ) in universe.iter().enumerate().take(universe[i].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `universe` [INFO] [stdout] --> src/days/day_11.rs:74:18 [INFO] [stdout] | [INFO] [stdout] 74 | for j in 0..universe.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 74 - for j in 0..universe.len() { [INFO] [stdout] 74 + for in &universe { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `universe` [INFO] [stdout] --> src/days/day_11.rs:86:14 [INFO] [stdout] | [INFO] [stdout] 86 | for i in 0..universe.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 86 - for i in 0..universe.len() { [INFO] [stdout] 86 + for (i, ) in universe.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `universe` [INFO] [stdout] --> src/days/day_11.rs:87:18 [INFO] [stdout] | [INFO] [stdout] 87 | for j in 0..universe[i].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 87 - for j in 0..universe[i].len() { [INFO] [stdout] 87 + for (j, ) in universe.iter().enumerate().take(universe[i].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/days/day_13.rs:8:32 [INFO] [stdout] | [INFO] [stdout] 8 | fn check_mirror_vertical(grid: &Vec>, line: usize) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 8 - fn check_mirror_vertical(grid: &Vec>, line: usize) -> bool { [INFO] [stdout] 8 + fn check_mirror_vertical(grid: &[Vec], line: usize) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/days/day_13.rs:23:34 [INFO] [stdout] | [INFO] [stdout] 23 | fn check_mirror_horizontal(grid: &Vec>, line: usize) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 23 - fn check_mirror_horizontal(grid: &Vec>, line: usize) -> bool { [INFO] [stdout] 23 + fn check_mirror_horizontal(grid: &[Vec], line: usize) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/days/day_13.rs:38:39 [INFO] [stdout] | [INFO] [stdout] 38 | fn check_mirror_vertical_smudge(grid: &Vec>, line: usize) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 38 - fn check_mirror_vertical_smudge(grid: &Vec>, line: usize) -> bool { [INFO] [stdout] 38 + fn check_mirror_vertical_smudge(grid: &[Vec], line: usize) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/days/day_13.rs:53:41 [INFO] [stdout] | [INFO] [stdout] 53 | fn check_mirror_horizontal_smudge(grid: &Vec>, line: usize) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 53 - fn check_mirror_horizontal_smudge(grid: &Vec>, line: usize) -> bool { [INFO] [stdout] 53 + fn check_mirror_horizontal_smudge(grid: &[Vec], line: usize) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/days/day_14.rs:46:15 [INFO] [stdout] | [INFO] [stdout] 46 | fn cycle(map: &mut Vec>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 46 - fn cycle(map: &mut Vec>) { [INFO] [stdout] 46 + fn cycle(map: &mut [Vec]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `map` [INFO] [stdout] --> src/days/day_14.rs:67:14 [INFO] [stdout] | [INFO] [stdout] 67 | for i in 0..map.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 67 - for i in 0..map.len() { [INFO] [stdout] 67 + for in &mut map { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is used to index `map` [INFO] [stdout] --> src/days/day_14.rs:93:22 [INFO] [stdout] | [INFO] [stdout] 93 | for k in (i + 1)..map.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 93 - for k in (i + 1)..map.len() { [INFO] [stdout] 93 + for (k, ) in map.iter().enumerate().skip((i + 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `map` [INFO] [stdout] --> src/days/day_14.rs:105:14 [INFO] [stdout] | [INFO] [stdout] 105 | for i in 0..map.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 105 - for i in 0..map.len() { [INFO] [stdout] 105 + for in &mut map { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is used to index `map` [INFO] [stdout] --> src/days/day_14.rs:112:22 [INFO] [stdout] | [INFO] [stdout] 112 | for k in (j + 1)..map[i].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 112 - for k in (j + 1)..map[i].len() { [INFO] [stdout] 112 + for (k, ) in map.iter().enumerate().take(map[i].len()).skip((j + 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `universe` [INFO] [stdout] --> src/days/day_11.rs:38:14 [INFO] [stdout] | [INFO] [stdout] 38 | for i in 0..universe.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 38 - for i in 0..universe.len() { [INFO] [stdout] 38 + for (i, ) in universe.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `universe` [INFO] [stdout] --> src/days/day_11.rs:39:18 [INFO] [stdout] | [INFO] [stdout] 39 | for j in 0..universe[i].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 39 - for j in 0..universe[i].len() { [INFO] [stdout] 39 + for (j, ) in universe.iter().enumerate().take(universe[i].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `universe` [INFO] [stdout] --> src/days/day_11.rs:74:18 [INFO] [stdout] | [INFO] [stdout] 74 | for j in 0..universe.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 74 - for j in 0..universe.len() { [INFO] [stdout] 74 + for in &universe { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `universe` [INFO] [stdout] --> src/days/day_11.rs:86:14 [INFO] [stdout] | [INFO] [stdout] 86 | for i in 0..universe.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 86 - for i in 0..universe.len() { [INFO] [stdout] 86 + for (i, ) in universe.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `universe` [INFO] [stdout] --> src/days/day_11.rs:87:18 [INFO] [stdout] | [INFO] [stdout] 87 | for j in 0..universe[i].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 87 - for j in 0..universe[i].len() { [INFO] [stdout] 87 + for (j, ) in universe.iter().enumerate().take(universe[i].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/days/day_13.rs:8:32 [INFO] [stdout] | [INFO] [stdout] 8 | fn check_mirror_vertical(grid: &Vec>, line: usize) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 8 - fn check_mirror_vertical(grid: &Vec>, line: usize) -> bool { [INFO] [stdout] 8 + fn check_mirror_vertical(grid: &[Vec], line: usize) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/days/day_13.rs:23:34 [INFO] [stdout] | [INFO] [stdout] 23 | fn check_mirror_horizontal(grid: &Vec>, line: usize) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 23 - fn check_mirror_horizontal(grid: &Vec>, line: usize) -> bool { [INFO] [stdout] 23 + fn check_mirror_horizontal(grid: &[Vec], line: usize) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/days/day_13.rs:38:39 [INFO] [stdout] | [INFO] [stdout] 38 | fn check_mirror_vertical_smudge(grid: &Vec>, line: usize) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 38 - fn check_mirror_vertical_smudge(grid: &Vec>, line: usize) -> bool { [INFO] [stdout] 38 + fn check_mirror_vertical_smudge(grid: &[Vec], line: usize) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/days/day_13.rs:53:41 [INFO] [stdout] | [INFO] [stdout] 53 | fn check_mirror_horizontal_smudge(grid: &Vec>, line: usize) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 53 - fn check_mirror_horizontal_smudge(grid: &Vec>, line: usize) -> bool { [INFO] [stdout] 53 + fn check_mirror_horizontal_smudge(grid: &[Vec], line: usize) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/days/day_14.rs:46:15 [INFO] [stdout] | [INFO] [stdout] 46 | fn cycle(map: &mut Vec>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 46 - fn cycle(map: &mut Vec>) { [INFO] [stdout] 46 + fn cycle(map: &mut [Vec]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `map` [INFO] [stdout] --> src/days/day_14.rs:67:14 [INFO] [stdout] | [INFO] [stdout] 67 | for i in 0..map.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 67 - for i in 0..map.len() { [INFO] [stdout] 67 + for in &mut map { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is used to index `map` [INFO] [stdout] --> src/days/day_14.rs:93:22 [INFO] [stdout] | [INFO] [stdout] 93 | for k in (i + 1)..map.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 93 - for k in (i + 1)..map.len() { [INFO] [stdout] 93 + for (k, ) in map.iter().enumerate().skip((i + 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `map` [INFO] [stdout] --> src/days/day_14.rs:105:14 [INFO] [stdout] | [INFO] [stdout] 105 | for i in 0..map.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 105 - for i in 0..map.len() { [INFO] [stdout] 105 + for in &mut map { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is used to index `map` [INFO] [stdout] --> src/days/day_14.rs:112:22 [INFO] [stdout] | [INFO] [stdout] 112 | for k in (j + 1)..map[i].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 112 - for k in (j + 1)..map[i].len() { [INFO] [stdout] 112 + for (k, ) in map.iter().enumerate().take(map[i].len()).skip((j + 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/days/day_19.rs:95:8 [INFO] [stdout] | [INFO] [stdout] 95 | a: &Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 95 ~ a: &[RangeInclusive], [INFO] [stdout] 96 | b: RangeInclusive, [INFO] [stdout] 97 | ) -> Vec> { [INFO] [stdout] 98 ~ let mut result = a.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/days/day_19.rs:95:8 [INFO] [stdout] | [INFO] [stdout] 95 | a: &Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 95 ~ a: &[RangeInclusive], [INFO] [stdout] 96 | b: RangeInclusive, [INFO] [stdout] 97 | ) -> Vec> { [INFO] [stdout] 98 ~ let mut result = a.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/days/day_23.rs:97:20 [INFO] [stdout] | [INFO] [stdout] 97 | fn find_nodes(map: &Vec>) -> Vec<(usize, usize)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 97 - fn find_nodes(map: &Vec>) -> Vec<(usize, usize)> { [INFO] [stdout] 97 + fn find_nodes(map: &[Vec]) -> Vec<(usize, usize)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/days/day_24.rs:131:17 [INFO] [stdout] | [INFO] [stdout] 131 | let stones: Vec<((i128, i128, i128), (i128, i128, i128))> = rx [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is only used to index `mask` [INFO] [stdout] --> src/days/day_3.rs:53:26 [INFO] [stdout] | [INFO] [stdout] 53 | for k in start as usize..end { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 53 - for k in start as usize..end { [INFO] [stdout] 53 + for in mask.iter_mut().take(end).skip(start as usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/days/day_23.rs:97:20 [INFO] [stdout] | [INFO] [stdout] 97 | fn find_nodes(map: &Vec>) -> Vec<(usize, usize)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 97 - fn find_nodes(map: &Vec>) -> Vec<(usize, usize)> { [INFO] [stdout] 97 + fn find_nodes(map: &[Vec]) -> Vec<(usize, usize)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: a `Vec` of `Range` that is only one element [INFO] [stdout] --> src/days/day_5.rs:127:13 [INFO] [stdout] | [INFO] [stdout] 127 | vec![start..(start + length)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_range_in_vec_init [INFO] [stdout] = note: `#[warn(clippy::single_range_in_vec_init)]` on by default [INFO] [stdout] help: if you wanted a `Vec` that contains the entire range, try [INFO] [stdout] | [INFO] [stdout] 127 - vec![start..(start + length)] [INFO] [stdout] 127 + (start..(start + length)).collect::>() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/days/day_7.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | / (hand[0] == hand[1]) && (hand[2] == hand[3]) [INFO] [stdout] 35 | | || (hand[0] == hand[1]) && (hand[3] == hand[4]) [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 34 - (hand[0] == hand[1]) && (hand[2] == hand[3]) [INFO] [stdout] 35 - || (hand[0] == hand[1]) && (hand[3] == hand[4]) [INFO] [stdout] 34 + !(hand[0] != hand[1] || hand[2] != hand[3] && hand[3] != hand[4]) [INFO] [stdout] | [INFO] [stdout] 34 - (hand[0] == hand[1]) && (hand[2] == hand[3]) [INFO] [stdout] 35 - || (hand[0] == hand[1]) && (hand[3] == hand[4]) [INFO] [stdout] 34 + ((hand[3] == hand[4]) || (hand[2] == hand[3])) && (hand[0] == hand[1]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/days/day_24.rs:131:17 [INFO] [stdout] | [INFO] [stdout] 131 | let stones: Vec<((i128, i128, i128), (i128, i128, i128))> = rx [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is only used to index `mask` [INFO] [stdout] --> src/days/day_3.rs:53:26 [INFO] [stdout] | [INFO] [stdout] 53 | for k in start as usize..end { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 53 - for k in start as usize..end { [INFO] [stdout] 53 + for in mask.iter_mut().take(end).skip(start as usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: a `Vec` of `Range` that is only one element [INFO] [stdout] --> src/days/day_5.rs:127:13 [INFO] [stdout] | [INFO] [stdout] 127 | vec![start..(start + length)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_range_in_vec_init [INFO] [stdout] = note: `#[warn(clippy::single_range_in_vec_init)]` on by default [INFO] [stdout] help: if you wanted a `Vec` that contains the entire range, try [INFO] [stdout] | [INFO] [stdout] 127 - vec![start..(start + length)] [INFO] [stdout] 127 + (start..(start + length)).collect::>() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/days/day_7.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | / (hand[0] == hand[1]) && (hand[2] == hand[3]) [INFO] [stdout] 35 | | || (hand[0] == hand[1]) && (hand[3] == hand[4]) [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 34 - (hand[0] == hand[1]) && (hand[2] == hand[3]) [INFO] [stdout] 35 - || (hand[0] == hand[1]) && (hand[3] == hand[4]) [INFO] [stdout] 34 + !(hand[0] != hand[1] || hand[2] != hand[3] && hand[3] != hand[4]) [INFO] [stdout] | [INFO] [stdout] 34 - (hand[0] == hand[1]) && (hand[2] == hand[3]) [INFO] [stdout] 35 - || (hand[0] == hand[1]) && (hand[3] == hand[4]) [INFO] [stdout] 34 + ((hand[3] == hand[4]) || (hand[2] == hand[3])) && (hand[0] == hand[1]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.46s [INFO] running `Command { std: "docker" "inspect" "5e111bb2a69a13a694d0a6d45e0a79becaee527ee5f03e0bb81594b6f976fc41", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e111bb2a69a13a694d0a6d45e0a79becaee527ee5f03e0bb81594b6f976fc41", kill_on_drop: false }` [INFO] [stdout] 5e111bb2a69a13a694d0a6d45e0a79becaee527ee5f03e0bb81594b6f976fc41