[INFO] cloning repository https://github.com/CarlosDanielMaturano/asteroids [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/CarlosDanielMaturano/asteroids" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCarlosDanielMaturano%2Fasteroids", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCarlosDanielMaturano%2Fasteroids'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1e0d5d0db3821cfeeb7fa2fea23ff636bae0ddcc [INFO] linting CarlosDanielMaturano/asteroids against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCarlosDanielMaturano%2Fasteroids" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/CarlosDanielMaturano/asteroids [INFO] finished tweaking git repo https://github.com/CarlosDanielMaturano/asteroids [INFO] tweaked toml for git repo https://github.com/CarlosDanielMaturano/asteroids written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/CarlosDanielMaturano/asteroids on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/CarlosDanielMaturano/asteroids already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded sdl2 v0.36.0 [INFO] [stderr] Downloaded sdl2-sys v0.36.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ffe60abdd9ce924e9e87759d52e8414052b58fdc6a64366493e6f9bfbbaa47a1 [INFO] running `Command { std: "docker" "start" "-a" "ffe60abdd9ce924e9e87759d52e8414052b58fdc6a64366493e6f9bfbbaa47a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ffe60abdd9ce924e9e87759d52e8414052b58fdc6a64366493e6f9bfbbaa47a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ffe60abdd9ce924e9e87759d52e8414052b58fdc6a64366493e6f9bfbbaa47a1", kill_on_drop: false }` [INFO] [stdout] ffe60abdd9ce924e9e87759d52e8414052b58fdc6a64366493e6f9bfbbaa47a1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d2b7f4748df2797417a61d24ae3fc2548c03da03e1d46e9c88a903dd98c20ef6 [INFO] running `Command { std: "docker" "start" "-a" "d2b7f4748df2797417a61d24ae3fc2548c03da03e1d46e9c88a903dd98c20ef6", kill_on_drop: false }` [INFO] [stderr] Compiling version-compare v0.1.1 [INFO] [stderr] Compiling sdl2 v0.36.0 [INFO] [stderr] Compiling sdl2-sys v0.36.0 [INFO] [stderr] Checking asteroids v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `should_close` is never read [INFO] [stdout] --> src/screen.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct Screen { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 18 | pub should_close: bool, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `should_close` is never read [INFO] [stdout] --> src/screen.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct Screen { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 18 | pub should_close: bool, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/game_logic.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 25 | / match event { [INFO] [stdout] 26 | | sdl2::event::Event::Quit { .. } => break 'gameloop, [INFO] [stdout] 27 | | _ => (), [INFO] [stdout] 28 | | } [INFO] [stdout] | |_________________^ help: try: `if let sdl2::event::Event::Quit { .. } = event { break 'gameloop }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/game_logic.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 25 | / match event { [INFO] [stdout] 26 | | sdl2::event::Event::Quit { .. } => break 'gameloop, [INFO] [stdout] 27 | | _ => (), [INFO] [stdout] 28 | | } [INFO] [stdout] | |_________________^ help: try: `if let sdl2::event::Event::Quit { .. } = event { break 'gameloop }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Vector2` which implements the `Copy` trait [INFO] [stdout] --> src/screen.rs:52:23 [INFO] [stdout] | [INFO] [stdout] 52 | let mut pos = pos.clone(); [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Vector2` which implements the `Copy` trait [INFO] [stdout] --> src/screen.rs:52:23 [INFO] [stdout] | [INFO] [stdout] 52 | let mut pos = pos.clone(); [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/utils/vector2.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | self.x = self.x - w; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.x -= w` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/utils/vector2.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | self.x = w + self.x [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.x += w` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/utils/vector2.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | self.y = self.y - h; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.y -= h` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/main.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 34 | / let asteroid = SpaceObject { [INFO] [stdout] 35 | | pos, [INFO] [stdout] 36 | | dir, [INFO] [stdout] 37 | | angle: random::() * 10f32, [INFO] [stdout] 38 | | radius: asteroid_radius as usize, [INFO] [stdout] 39 | | model: Box::new(asteroid_model), [INFO] [stdout] 40 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 41 | asteroid [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 34 ~ [INFO] [stdout] 35 ~ SpaceObject { [INFO] [stdout] 36 + pos, [INFO] [stdout] 37 + dir, [INFO] [stdout] 38 + angle: random::() * 10f32, [INFO] [stdout] 39 + radius: asteroid_radius as usize, [INFO] [stdout] 40 + model: Box::new(asteroid_model), [INFO] [stdout] 41 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/utils/vector2.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | self.x = self.x - w; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.x -= w` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/utils/vector2.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | self.x = w + self.x [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.x += w` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/utils/vector2.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | self.y = self.y - h; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.y -= h` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:130:43 [INFO] [stdout] | [INFO] [stdout] 130 | screen.draw_pixel(bullet.pos, PIXEL_SIZE as i32, Color::WHITE) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `PIXEL_SIZE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/main.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 34 | / let asteroid = SpaceObject { [INFO] [stdout] 35 | | pos, [INFO] [stdout] 36 | | dir, [INFO] [stdout] 37 | | angle: random::() * 10f32, [INFO] [stdout] 38 | | radius: asteroid_radius as usize, [INFO] [stdout] 39 | | model: Box::new(asteroid_model), [INFO] [stdout] 40 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 41 | asteroid [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 34 ~ [INFO] [stdout] 35 ~ SpaceObject { [INFO] [stdout] 36 + pos, [INFO] [stdout] 37 + dir, [INFO] [stdout] 38 + angle: random::() * 10f32, [INFO] [stdout] 39 + radius: asteroid_radius as usize, [INFO] [stdout] 40 + model: Box::new(asteroid_model), [INFO] [stdout] 41 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:156:13 [INFO] [stdout] | [INFO] [stdout] 156 | !(asteroid.radius < 6) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(asteroid.radius >= 6)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:184:42 [INFO] [stdout] | [INFO] [stdout] 184 | screen.draw_wire_frame_model(&asteroid, Color::YELLOW); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `asteroid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:130:43 [INFO] [stdout] | [INFO] [stdout] 130 | screen.draw_pixel(bullet.pos, PIXEL_SIZE as i32, Color::WHITE) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `PIXEL_SIZE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:156:13 [INFO] [stdout] | [INFO] [stdout] 156 | !(asteroid.radius < 6) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(asteroid.radius >= 6)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:184:42 [INFO] [stdout] | [INFO] [stdout] 184 | screen.draw_wire_frame_model(&asteroid, Color::YELLOW); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `asteroid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.03s [INFO] running `Command { std: "docker" "inspect" "d2b7f4748df2797417a61d24ae3fc2548c03da03e1d46e9c88a903dd98c20ef6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d2b7f4748df2797417a61d24ae3fc2548c03da03e1d46e9c88a903dd98c20ef6", kill_on_drop: false }` [INFO] [stdout] d2b7f4748df2797417a61d24ae3fc2548c03da03e1d46e9c88a903dd98c20ef6