[INFO] cloning repository https://github.com/Calbabreaker/cheseng [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Calbabreaker/cheseng" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCalbabreaker%2Fcheseng", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCalbabreaker%2Fcheseng'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c66ec7d083acad2f29123fe5e267bbce4897347b [INFO] linting Calbabreaker/cheseng against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCalbabreaker%2Fcheseng" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Calbabreaker/cheseng [INFO] finished tweaking git repo https://github.com/Calbabreaker/cheseng [INFO] tweaked toml for git repo https://github.com/Calbabreaker/cheseng written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Calbabreaker/cheseng on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Calbabreaker/cheseng already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] | [INFO] [stderr] = note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] = note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] = note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded sapp-wasm v0.1.26 [INFO] [stderr] Downloaded miniquad v0.3.0-alpha.42 [INFO] [stderr] Downloaded sapp-ios v0.1.2 [INFO] [stderr] Downloaded sapp-windows v0.2.19 [INFO] [stderr] Downloaded sapp-darwin v0.1.6 [INFO] [stderr] Downloaded sapp-android v0.1.14 [INFO] [stderr] Downloaded sapp-dummy v0.1.5 [INFO] [stderr] Downloaded fontdue v0.5.2 [INFO] [stderr] Downloaded glam v0.14.0 [INFO] [stderr] Downloaded sapp-linux v0.1.13 [INFO] [stderr] Downloaded quad-snd v0.2.3 [INFO] [stderr] Downloaded macroquad v0.3.13 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 46e9f6fd9634dd57be1cdf35f00f961e8c5f45f48b9afd19fa20b8677f5e41c0 [INFO] running `Command { std: "docker" "start" "-a" "46e9f6fd9634dd57be1cdf35f00f961e8c5f45f48b9afd19fa20b8677f5e41c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "46e9f6fd9634dd57be1cdf35f00f961e8c5f45f48b9afd19fa20b8677f5e41c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "46e9f6fd9634dd57be1cdf35f00f961e8c5f45f48b9afd19fa20b8677f5e41c0", kill_on_drop: false }` [INFO] [stdout] 46e9f6fd9634dd57be1cdf35f00f961e8c5f45f48b9afd19fa20b8677f5e41c0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 17fd73f86666ebccb8f441cd41c1f7ec20f2dcde72936723ed92775637576ad4 [INFO] running `Command { std: "docker" "start" "-a" "17fd73f86666ebccb8f441cd41c1f7ec20f2dcde72936723ed92775637576ad4", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] | [INFO] [stderr] = note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] = note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] = note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling crc32fast v1.3.0 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Compiling sapp-linux v0.1.13 [INFO] [stderr] Compiling quad-snd v0.2.3 [INFO] [stderr] Checking hound v3.4.0 [INFO] [stderr] Checking cheseng v0.1.0 (/opt/rustwide/workdir/cheseng) [INFO] [stderr] Checking ttf-parser v0.12.3 [INFO] [stderr] Checking bytemuck v1.7.3 [INFO] [stderr] Checking bumpalo v3.9.1 [INFO] [stderr] Checking glam v0.14.0 [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> cheseng/src/board.rs:119:33 [INFO] [stdout] | [INFO] [stdout] 119 | Color::White => (end_i + 8), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 119 - Color::White => (end_i + 8), [INFO] [stdout] 119 + Color::White => end_i + 8 , [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> cheseng/src/board.rs:120:33 [INFO] [stdout] | [INFO] [stdout] 120 | Color::Black => (end_i.saturating_sub(8)), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 120 - Color::Black => (end_i.saturating_sub(8)), [INFO] [stdout] 120 + Color::Black => end_i.saturating_sub(8) , [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> cheseng/src/board.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 157 | / match end_piece { [INFO] [stdout] 158 | | Some(Piece::Rook(color)) => { [INFO] [stdout] 159 | | set_rights!(end_i, color); [INFO] [stdout] ... | [INFO] [stdout] 162 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 157 ~ if let Some(Piece::Rook(color)) = end_piece { [INFO] [stdout] 158 + set_rights!(end_i, color); [INFO] [stdout] 159 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cheseng/src/board.rs:180:60 [INFO] [stdout] | [INFO] [stdout] 180 | piece.add_legal_moves(i as u8, &mut moves, &self); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cheseng/src/board.rs:191:76 [INFO] [stdout] | [INFO] [stdout] 191 | let legal_moves = piece.get_legal_moves(test_move.start_index, &self); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> cheseng/src/piece.rs:148:84 [INFO] [stdout] | [INFO] [stdout] 148 | ... add_promote_moves(moves, piece_index, piece_color, end_index as u8); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `end_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `index` is used to index `num_times_to_edge` [INFO] [stdout] --> cheseng/src/piece.rs:249:18 [INFO] [stdout] | [INFO] [stdout] 249 | for index in 0..64 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 249 - for index in 0..64 { [INFO] [stdout] 249 + for (index, ) in num_times_to_edge.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> cheseng/src/piece.rs:279:16 [INFO] [stdout] | [INFO] [stdout] 279 | if end_index >= 0 && end_index < 64 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..64).contains(&end_index)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> cheseng/src/board.rs:119:33 [INFO] [stdout] | [INFO] [stdout] 119 | Color::White => (end_i + 8), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 119 - Color::White => (end_i + 8), [INFO] [stdout] 119 + Color::White => end_i + 8 , [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> cheseng/src/board.rs:120:33 [INFO] [stdout] | [INFO] [stdout] 120 | Color::Black => (end_i.saturating_sub(8)), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 120 - Color::Black => (end_i.saturating_sub(8)), [INFO] [stdout] 120 + Color::Black => end_i.saturating_sub(8) , [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> cheseng/src/board.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 157 | / match end_piece { [INFO] [stdout] 158 | | Some(Piece::Rook(color)) => { [INFO] [stdout] 159 | | set_rights!(end_i, color); [INFO] [stdout] ... | [INFO] [stdout] 162 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 157 ~ if let Some(Piece::Rook(color)) = end_piece { [INFO] [stdout] 158 + set_rights!(end_i, color); [INFO] [stdout] 159 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cheseng/src/board.rs:180:60 [INFO] [stdout] | [INFO] [stdout] 180 | piece.add_legal_moves(i as u8, &mut moves, &self); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cheseng/src/board.rs:191:76 [INFO] [stdout] | [INFO] [stdout] 191 | let legal_moves = piece.get_legal_moves(test_move.start_index, &self); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking audrey v0.3.0 [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> cheseng/src/piece.rs:148:84 [INFO] [stdout] | [INFO] [stdout] 148 | ... add_promote_moves(moves, piece_index, piece_color, end_index as u8); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `end_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `index` is used to index `num_times_to_edge` [INFO] [stdout] --> cheseng/src/piece.rs:249:18 [INFO] [stdout] | [INFO] [stdout] 249 | for index in 0..64 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 249 - for index in 0..64 { [INFO] [stdout] 249 + for (index, ) in num_times_to_edge.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> cheseng/src/piece.rs:279:16 [INFO] [stdout] | [INFO] [stdout] 279 | if end_index >= 0 && end_index < 64 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..64).contains(&end_index)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking cheseng-cli v0.1.0 (/opt/rustwide/workdir/cli) [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking quad-alsa-sys v0.3.2 [INFO] [stderr] Checking fontdue v0.5.2 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking miniquad v0.3.0-alpha.42 [INFO] [stderr] Checking macroquad v0.3.13 [INFO] [stderr] Checking cheseng-ui v0.1.0 (/opt/rustwide/workdir/ui) [INFO] [stdout] warning: field `size` is never read [INFO] [stdout] --> ui/src/utils.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct SquareViewport { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 6 | pub size: f32, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> ui/src/board_ui.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 45 | if !self.dragged_piece.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.dragged_piece.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> ui/src/board_ui.rs:104:20 [INFO] [stdout] | [INFO] [stdout] 104 | if (board_pos.file + board_pos.rank) % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(board_pos.file + board_pos.rank).is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> ui/src/board_ui.rs:113:20 [INFO] [stdout] | [INFO] [stdout] 113 | if self [INFO] [stdout] | ____________________^ [INFO] [stdout] 114 | | .dragged_piece [INFO] [stdout] 115 | | .as_ref() [INFO] [stdout] 116 | | .map_or(true, |piece| piece.index != i as u8) [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 116 - .map_or(true, |piece| piece.index != i as u8) [INFO] [stdout] 116 + .is_none_or(|piece| piece.index != i as u8) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> ui/src/board_ui.rs:125:35 [INFO] [stdout] | [INFO] [stdout] 125 | self.draw_moves_hints(&screen_view, &piece.legal_moves); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `screen_view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `size` is never read [INFO] [stdout] --> ui/src/utils.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct SquareViewport { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 6 | pub size: f32, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> ui/src/board_ui.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 45 | if !self.dragged_piece.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.dragged_piece.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> ui/src/board_ui.rs:104:20 [INFO] [stdout] | [INFO] [stdout] 104 | if (board_pos.file + board_pos.rank) % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(board_pos.file + board_pos.rank).is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> ui/src/board_ui.rs:113:20 [INFO] [stdout] | [INFO] [stdout] 113 | if self [INFO] [stdout] | ____________________^ [INFO] [stdout] 114 | | .dragged_piece [INFO] [stdout] 115 | | .as_ref() [INFO] [stdout] 116 | | .map_or(true, |piece| piece.index != i as u8) [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 116 - .map_or(true, |piece| piece.index != i as u8) [INFO] [stdout] 116 + .is_none_or(|piece| piece.index != i as u8) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> ui/src/board_ui.rs:125:35 [INFO] [stdout] | [INFO] [stdout] 125 | self.draw_moves_hints(&screen_view, &piece.legal_moves); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `screen_view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.55s [INFO] running `Command { std: "docker" "inspect" "17fd73f86666ebccb8f441cd41c1f7ec20f2dcde72936723ed92775637576ad4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "17fd73f86666ebccb8f441cd41c1f7ec20f2dcde72936723ed92775637576ad4", kill_on_drop: false }` [INFO] [stdout] 17fd73f86666ebccb8f441cd41c1f7ec20f2dcde72936723ed92775637576ad4