[INFO] cloning repository https://github.com/Cabbache/ChatRoulette [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Cabbache/ChatRoulette" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCabbache%2FChatRoulette", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCabbache%2FChatRoulette'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f95e43859a83bc09db71d7826d1e50c6dc3c458e [INFO] linting Cabbache/ChatRoulette against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCabbache%2FChatRoulette" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Cabbache/ChatRoulette [INFO] finished tweaking git repo https://github.com/Cabbache/ChatRoulette [INFO] tweaked toml for git repo https://github.com/Cabbache/ChatRoulette written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Cabbache/ChatRoulette on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Cabbache/ChatRoulette already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded cpufeatures v0.2.13 [INFO] [stderr] Downloaded cc v1.1.14 [INFO] [stderr] Downloaded bytemuck v1.17.1 [INFO] [stderr] Downloaded axum-extra v0.9.3 [INFO] [stderr] Downloaded serde v1.0.209 [INFO] [stderr] Downloaded flate2 v1.0.33 [INFO] [stderr] Downloaded serde_json v1.0.127 [INFO] [stderr] Downloaded lodepng v3.10.6 [INFO] [stderr] Downloaded serde_derive v1.0.209 [INFO] [stderr] Downloaded syn v2.0.76 [INFO] [stderr] Downloaded captcha v0.0.9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3e2cf9b0e2196015c36f9305e94d21b0844243322e2e80916eef9286f0cb509f [INFO] running `Command { std: "docker" "start" "-a" "3e2cf9b0e2196015c36f9305e94d21b0844243322e2e80916eef9286f0cb509f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3e2cf9b0e2196015c36f9305e94d21b0844243322e2e80916eef9286f0cb509f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e2cf9b0e2196015c36f9305e94d21b0844243322e2e80916eef9286f0cb509f", kill_on_drop: false }` [INFO] [stdout] 3e2cf9b0e2196015c36f9305e94d21b0844243322e2e80916eef9286f0cb509f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c68596858e3207b4a14a210c77db304f44adeaadd7a39b0dfea1fd18aa18c44f [INFO] running `Command { std: "docker" "start" "-a" "c68596858e3207b4a14a210c77db304f44adeaadd7a39b0dfea1fd18aa18c44f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling syn v2.0.76 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling phf v0.11.2 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling axum-core v0.4.3 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking unic-common v0.9.0 [INFO] [stderr] Checking unic-char-range v0.9.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking unic-char-property v0.9.0 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking unic-ucd-version v0.9.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Compiling axum v0.7.5 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking unic-ucd-segment v0.9.0 [INFO] [stderr] Checking rgb v0.8.50 [INFO] [stderr] Checking headers-core v0.3.0 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking deunicode v1.6.0 [INFO] [stderr] Checking lodepng v3.10.6 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking slug v0.1.6 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking headers v0.4.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking unic-segment v0.9.0 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Checking humansize v2.1.3 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Compiling parse-zoneinfo v0.3.1 [INFO] [stderr] Checking globwalk v0.9.1 [INFO] [stderr] Compiling chrono-tz-build v0.3.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling chrono-tz v0.9.0 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking tokio v1.39.3 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling pest v2.7.11 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Compiling pest_meta v2.7.11 [INFO] [stderr] Compiling pest_generator v2.7.11 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Compiling pest_derive v2.7.11 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking serde_path_to_error v0.1.16 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking captcha v0.0.9 [INFO] [stderr] Checking tera v1.20.0 [INFO] [stderr] Checking axum-extra v0.9.3 [INFO] [stderr] Checking strangerdanger v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:54:4 [INFO] [stdout] | [INFO] [stdout] 54 | id: id, [INFO] [stdout] | ^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:120:4 [INFO] [stdout] | [INFO] [stdout] 120 | msg: msg, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `msg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:180:4 [INFO] [stdout] | [INFO] [stdout] 180 | id: id, [INFO] [stdout] | ^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:181:4 [INFO] [stdout] | [INFO] [stdout] 181 | users: users, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `users` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:54:4 [INFO] [stdout] | [INFO] [stdout] 54 | id: id, [INFO] [stdout] | ^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:120:4 [INFO] [stdout] | [INFO] [stdout] 120 | msg: msg, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `msg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:180:4 [INFO] [stdout] | [INFO] [stdout] 180 | id: id, [INFO] [stdout] | ^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:181:4 [INFO] [stdout] | [INFO] [stdout] 181 | users: users, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `users` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `YOU` contains a capitalized acronym [INFO] [stdout] --> src/main.rs:102:2 [INFO] [stdout] | [INFO] [stdout] 102 | YOU, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `You` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `THEM` contains a capitalized acronym [INFO] [stdout] --> src/main.rs:103:2 [INFO] [stdout] | [INFO] [stdout] 103 | THEM, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Them` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SYSTEM` contains a capitalized acronym [INFO] [stdout] --> src/main.rs:104:2 [INFO] [stdout] | [INFO] [stdout] 104 | SYSTEM, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `System` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/main.rs:204:48 [INFO] [stdout] | [INFO] [stdout] 204 | let users_to_remove: Vec<(UserState, u64)> = stateguard [INFO] [stdout] | ______________________________________________________^ [INFO] [stdout] 205 | | .users [INFO] [stdout] 206 | | .iter() [INFO] [stdout] 207 | | .map(|(_, v)| (v.clone(), v.last_seen.elapsed())) [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 204 ~ let users_to_remove: Vec<(UserState, u64)> = stateguard [INFO] [stdout] 205 ~ .users.values().map(|v| (v.clone(), v.last_seen.elapsed())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:445:15 [INFO] [stdout] | [INFO] [stdout] 445 | assert!(roomguard.messages.len() == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `roomguard.messages.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:547:9 [INFO] [stdout] | [INFO] [stdout] 547 | if !roomguard.terminator.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `roomguard.terminator.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:533:2 [INFO] [stdout] | [INFO] [stdout] 533 | / match cookie [INFO] [stdout] 534 | | .get("uid") [INFO] [stdout] 535 | | .and_then(|uid| stateguard.users.get(uid).map(|user| (uid, user))) [INFO] [stdout] 536 | | .and_then(|(uid, user)| user.room_id.as_ref().map(|room_id| (uid, room_id))) [INFO] [stdout] ... | [INFO] [stdout] 564 | | None => {} [INFO] [stdout] 565 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 533 ~ if let Some((uid, room)) = cookie [INFO] [stdout] 534 ~ .get("uid") [INFO] [stdout] 535 ~ .and_then(|uid| stateguard.users.get(uid).map(|user| (uid, user))) [INFO] [stdout] 536 ~ .and_then(|(uid, user)| user.room_id.as_ref().map(|room_id| (uid, room_id))) [INFO] [stdout] 537 ~ .and_then(|(uid, room_id)| stateguard.chats.get(room_id).map(|room| (uid, room))) { [INFO] [stdout] 538 ~ let parsed: Vec<(String, String)> = form_urlencoded::parse(body.as_bytes()) [INFO] [stdout] 539 ~ .into_owned() [INFO] [stdout] 540 ~ .collect(); [INFO] [stdout] 541 ~ if parsed.len() == 1 { [INFO] [stdout] 542 ~ let (param, value) = &parsed[0]; [INFO] [stdout] 543 ~ if param == "message" { [INFO] [stdout] 544 ~ let mut roomguard = room.lock().unwrap(); [INFO] [stdout] 545 ~ if !roomguard.terminator.is_some() { [INFO] [stdout] 546 ~ let msgobj = Message::new(Some(uid.to_string()), value.to_string()); [INFO] [stdout] 547 ~ trace!("[{}][{}]: '{}'", roomguard.id, uid, value); [INFO] [stdout] 548 ~ roomguard.messages.push(msgobj); [INFO] [stdout] 549 ~ if roomguard.messages.len() > sc.config.max_messages { [INFO] [stdout] 550 ~ roomguard.messages.remove(0); [INFO] [stdout] 551 ~ } [INFO] [stdout] 552 ~ } else { [INFO] [stdout] 553 ~ warn!("cannot send to terminated room"); [INFO] [stdout] 554 ~ } [INFO] [stdout] 555 ~ } else { [INFO] [stdout] 556 ~ warn!("param not named message"); [INFO] [stdout] 557 ~ } [INFO] [stdout] 558 ~ } else { [INFO] [stdout] 559 ~ warn!("got weird params"); [INFO] [stdout] 560 ~ } [INFO] [stdout] 561 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `YOU` contains a capitalized acronym [INFO] [stdout] --> src/main.rs:102:2 [INFO] [stdout] | [INFO] [stdout] 102 | YOU, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `You` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `THEM` contains a capitalized acronym [INFO] [stdout] --> src/main.rs:103:2 [INFO] [stdout] | [INFO] [stdout] 103 | THEM, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Them` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SYSTEM` contains a capitalized acronym [INFO] [stdout] --> src/main.rs:104:2 [INFO] [stdout] | [INFO] [stdout] 104 | SYSTEM, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `System` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/main.rs:204:48 [INFO] [stdout] | [INFO] [stdout] 204 | let users_to_remove: Vec<(UserState, u64)> = stateguard [INFO] [stdout] | ______________________________________________________^ [INFO] [stdout] 205 | | .users [INFO] [stdout] 206 | | .iter() [INFO] [stdout] 207 | | .map(|(_, v)| (v.clone(), v.last_seen.elapsed())) [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 204 ~ let users_to_remove: Vec<(UserState, u64)> = stateguard [INFO] [stdout] 205 ~ .users.values().map(|v| (v.clone(), v.last_seen.elapsed())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:445:15 [INFO] [stdout] | [INFO] [stdout] 445 | assert!(roomguard.messages.len() == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `roomguard.messages.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:547:9 [INFO] [stdout] | [INFO] [stdout] 547 | if !roomguard.terminator.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `roomguard.terminator.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:533:2 [INFO] [stdout] | [INFO] [stdout] 533 | / match cookie [INFO] [stdout] 534 | | .get("uid") [INFO] [stdout] 535 | | .and_then(|uid| stateguard.users.get(uid).map(|user| (uid, user))) [INFO] [stdout] 536 | | .and_then(|(uid, user)| user.room_id.as_ref().map(|room_id| (uid, room_id))) [INFO] [stdout] ... | [INFO] [stdout] 564 | | None => {} [INFO] [stdout] 565 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 533 ~ if let Some((uid, room)) = cookie [INFO] [stdout] 534 ~ .get("uid") [INFO] [stdout] 535 ~ .and_then(|uid| stateguard.users.get(uid).map(|user| (uid, user))) [INFO] [stdout] 536 ~ .and_then(|(uid, user)| user.room_id.as_ref().map(|room_id| (uid, room_id))) [INFO] [stdout] 537 ~ .and_then(|(uid, room_id)| stateguard.chats.get(room_id).map(|room| (uid, room))) { [INFO] [stdout] 538 ~ let parsed: Vec<(String, String)> = form_urlencoded::parse(body.as_bytes()) [INFO] [stdout] 539 ~ .into_owned() [INFO] [stdout] 540 ~ .collect(); [INFO] [stdout] 541 ~ if parsed.len() == 1 { [INFO] [stdout] 542 ~ let (param, value) = &parsed[0]; [INFO] [stdout] 543 ~ if param == "message" { [INFO] [stdout] 544 ~ let mut roomguard = room.lock().unwrap(); [INFO] [stdout] 545 ~ if !roomguard.terminator.is_some() { [INFO] [stdout] 546 ~ let msgobj = Message::new(Some(uid.to_string()), value.to_string()); [INFO] [stdout] 547 ~ trace!("[{}][{}]: '{}'", roomguard.id, uid, value); [INFO] [stdout] 548 ~ roomguard.messages.push(msgobj); [INFO] [stdout] 549 ~ if roomguard.messages.len() > sc.config.max_messages { [INFO] [stdout] 550 ~ roomguard.messages.remove(0); [INFO] [stdout] 551 ~ } [INFO] [stdout] 552 ~ } else { [INFO] [stdout] 553 ~ warn!("cannot send to terminated room"); [INFO] [stdout] 554 ~ } [INFO] [stdout] 555 ~ } else { [INFO] [stdout] 556 ~ warn!("param not named message"); [INFO] [stdout] 557 ~ } [INFO] [stdout] 558 ~ } else { [INFO] [stdout] 559 ~ warn!("got weird params"); [INFO] [stdout] 560 ~ } [INFO] [stdout] 561 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 08s [INFO] running `Command { std: "docker" "inspect" "c68596858e3207b4a14a210c77db304f44adeaadd7a39b0dfea1fd18aa18c44f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c68596858e3207b4a14a210c77db304f44adeaadd7a39b0dfea1fd18aa18c44f", kill_on_drop: false }` [INFO] [stdout] c68596858e3207b4a14a210c77db304f44adeaadd7a39b0dfea1fd18aa18c44f