[INFO] cloning repository https://github.com/C-h-a-r/DiscordCustoms [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/C-h-a-r/DiscordCustoms" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FC-h-a-r%2FDiscordCustoms", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FC-h-a-r%2FDiscordCustoms'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d847152075daafd0456d47fb1ca22d5a23a94d19 [INFO] linting C-h-a-r/DiscordCustoms against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FC-h-a-r%2FDiscordCustoms" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/C-h-a-r/DiscordCustoms [INFO] finished tweaking git repo https://github.com/C-h-a-r/DiscordCustoms [INFO] tweaked toml for git repo https://github.com/C-h-a-r/DiscordCustoms written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/C-h-a-r/DiscordCustoms on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/C-h-a-r/DiscordCustoms already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded strsim v0.11.0 [INFO] [stderr] Downloaded openssl-sys v0.9.101 [INFO] [stderr] Downloaded clap_derive v4.5.0 [INFO] [stderr] Downloaded toml v0.8.11 [INFO] [stderr] Downloaded toml_edit v0.22.7 [INFO] [stderr] Downloaded h2 v0.3.25 [INFO] [stderr] Downloaded winnow v0.6.5 [INFO] [stderr] Downloaded git2 v0.18.2 [INFO] [stderr] Downloaded rustix v0.38.31 [INFO] [stderr] Downloaded libssh2-sys v0.3.0 [INFO] [stderr] Downloaded libz-sys v1.1.15 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a90f7946eeaddf3b2b48e78934e956419e3df1ca5b2b1eea825f7511a186b540 [INFO] running `Command { std: "docker" "start" "-a" "a90f7946eeaddf3b2b48e78934e956419e3df1ca5b2b1eea825f7511a186b540", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a90f7946eeaddf3b2b48e78934e956419e3df1ca5b2b1eea825f7511a186b540", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a90f7946eeaddf3b2b48e78934e956419e3df1ca5b2b1eea825f7511a186b540", kill_on_drop: false }` [INFO] [stdout] a90f7946eeaddf3b2b48e78934e956419e3df1ca5b2b1eea825f7511a186b540 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bd094da5f0aac3155422b1108b4c4d70534eaa84e0a00d8a9e22242e5faf6911 [INFO] running `Command { std: "docker" "start" "-a" "bd094da5f0aac3155422b1108b4c4d70534eaa84e0a00d8a9e22242e5faf6911", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking indexmap v2.2.5 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Compiling jobserver v0.1.28 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking winnow v0.6.5 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling openssl-sys v0.9.101 [INFO] [stderr] Compiling libz-sys v1.1.15 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Compiling libgit2-sys v0.16.2+1.7.2 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking dialoguer v0.11.0 [INFO] [stderr] Checking clap v4.5.2 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking h2 v0.3.25 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking toml_edit v0.22.7 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking git2 v0.18.2 [INFO] [stderr] Checking toml v0.8.11 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking customs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `Config` is never constructed [INFO] [stdout] --> src/model.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Config { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/cli/auth/create.rs:15:28 [INFO] [stdout] | [INFO] [stdout] 15 | fs::create_dir_all(&data_dir_path).expect("Failed to create data directory"); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `data_dir_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/cli/auth/create.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | "You are logged into an account" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 22 ~ "{} You are logged into an account", [INFO] [stdout] 23 ~ "ERROR".red().bold() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/cli/auth/create.rs:57:69 [INFO] [stdout] | [INFO] [stdout] 57 | ... println!("{} {}", "ERROR".red().bold(), "Internal error"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 57 - println!("{} {}", "ERROR".red().bold(), "Internal error"); [INFO] [stdout] 57 + println!("{} Internal error", "ERROR".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)` [INFO] [stdout] --> src/cli/auth/create.rs:70:29 [INFO] [stdout] | [INFO] [stdout] 70 | ... .write(true) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove `.write(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options [INFO] [stdout] = note: `#[warn(clippy::ineffective_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/cli/auth/login.rs:14:28 [INFO] [stdout] | [INFO] [stdout] 14 | fs::create_dir_all(&data_dir_path).expect("Failed to create data directory"); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `data_dir_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/cli/auth/login.rs:20:49 [INFO] [stdout] | [INFO] [stdout] 20 | println!("{} {}", "ERROR".red().bold(), "You are already logged in"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 20 - println!("{} {}", "ERROR".red().bold(), "You are already logged in"); [INFO] [stdout] 20 + println!("{} You are already logged in", "ERROR".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/cli/auth/login.rs:53:69 [INFO] [stdout] | [INFO] [stdout] 53 | ... println!("{} {}", "ERROR".red().bold(), "Internal error"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 53 - println!("{} {}", "ERROR".red().bold(), "Internal error"); [INFO] [stdout] 53 + println!("{} Internal error", "ERROR".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)` [INFO] [stdout] --> src/cli/auth/login.rs:66:29 [INFO] [stdout] | [INFO] [stdout] 66 | ... .write(true) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove `.write(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `println!` args [INFO] [stdout] --> src/cli/init.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | println!("{}", format!("{} Failed to clone: {}", "ERROR".bold().red(), e)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `println!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli/add.rs:18:8 [INFO] [stdout] | [INFO] [stdout] 18 | if !fs::metadata("Customs.toml").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata("Customs.toml").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/cli/add.rs:63:69 [INFO] [stdout] | [INFO] [stdout] 63 | ... println!("{} {}", "ERROR".red().bold(), "Internal error"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 63 - println!("{} {}", "ERROR".red().bold(), "Internal error"); [INFO] [stdout] 63 + println!("{} Internal error", "ERROR".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/cli/add.rs:75:42 [INFO] [stdout] | [INFO] [stdout] 75 | ... let gitURL = "https://github.com/".to_string() [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 76 | | ... + &gitrepo.to_string().trim_matches('"'); [INFO] [stdout] | |_____________________________-------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `gitrepo.to_string().trim_matches('"')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cli/add.rs:76:35 [INFO] [stdout] | [INFO] [stdout] 76 | ... + &gitrepo.to_string().trim_matches('"'); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `gitrepo.to_string().trim_matches('"')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `println!` args [INFO] [stdout] --> src/cli/add.rs:87:37 [INFO] [stdout] | [INFO] [stdout] 87 | / ... println!( [INFO] [stdout] 88 | | ... "{}", [INFO] [stdout] 89 | | ... format!("{} Failed to clone: {}", "ERROR".bold().red(), e) [INFO] [stdout] 90 | | ... ); [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `println!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `gitURL` should have a snake case name [INFO] [stdout] --> src/cli/add.rs:75:33 [INFO] [stdout] | [INFO] [stdout] 75 | ... let gitURL = "https://github.com/".to_string() [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `git_url` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Config` is never constructed [INFO] [stdout] --> src/model.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Config { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/cli/auth/create.rs:15:28 [INFO] [stdout] | [INFO] [stdout] 15 | fs::create_dir_all(&data_dir_path).expect("Failed to create data directory"); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `data_dir_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/cli/auth/create.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | "You are logged into an account" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 22 ~ "{} You are logged into an account", [INFO] [stdout] 23 ~ "ERROR".red().bold() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/cli/auth/create.rs:57:69 [INFO] [stdout] | [INFO] [stdout] 57 | ... println!("{} {}", "ERROR".red().bold(), "Internal error"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 57 - println!("{} {}", "ERROR".red().bold(), "Internal error"); [INFO] [stdout] 57 + println!("{} Internal error", "ERROR".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)` [INFO] [stdout] --> src/cli/auth/create.rs:70:29 [INFO] [stdout] | [INFO] [stdout] 70 | ... .write(true) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove `.write(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options [INFO] [stdout] = note: `#[warn(clippy::ineffective_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/cli/auth/login.rs:14:28 [INFO] [stdout] | [INFO] [stdout] 14 | fs::create_dir_all(&data_dir_path).expect("Failed to create data directory"); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `data_dir_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/cli/auth/login.rs:20:49 [INFO] [stdout] | [INFO] [stdout] 20 | println!("{} {}", "ERROR".red().bold(), "You are already logged in"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 20 - println!("{} {}", "ERROR".red().bold(), "You are already logged in"); [INFO] [stdout] 20 + println!("{} You are already logged in", "ERROR".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/cli/auth/login.rs:53:69 [INFO] [stdout] | [INFO] [stdout] 53 | ... println!("{} {}", "ERROR".red().bold(), "Internal error"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 53 - println!("{} {}", "ERROR".red().bold(), "Internal error"); [INFO] [stdout] 53 + println!("{} Internal error", "ERROR".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)` [INFO] [stdout] --> src/cli/auth/login.rs:66:29 [INFO] [stdout] | [INFO] [stdout] 66 | ... .write(true) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove `.write(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `println!` args [INFO] [stdout] --> src/cli/init.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | println!("{}", format!("{} Failed to clone: {}", "ERROR".bold().red(), e)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `println!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli/add.rs:18:8 [INFO] [stdout] | [INFO] [stdout] 18 | if !fs::metadata("Customs.toml").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata("Customs.toml").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/cli/add.rs:63:69 [INFO] [stdout] | [INFO] [stdout] 63 | ... println!("{} {}", "ERROR".red().bold(), "Internal error"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 63 - println!("{} {}", "ERROR".red().bold(), "Internal error"); [INFO] [stdout] 63 + println!("{} Internal error", "ERROR".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/cli/add.rs:75:42 [INFO] [stdout] | [INFO] [stdout] 75 | ... let gitURL = "https://github.com/".to_string() [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 76 | | ... + &gitrepo.to_string().trim_matches('"'); [INFO] [stdout] | |_____________________________-------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `gitrepo.to_string().trim_matches('"')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cli/add.rs:76:35 [INFO] [stdout] | [INFO] [stdout] 76 | ... + &gitrepo.to_string().trim_matches('"'); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `gitrepo.to_string().trim_matches('"')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `println!` args [INFO] [stdout] --> src/cli/add.rs:87:37 [INFO] [stdout] | [INFO] [stdout] 87 | / ... println!( [INFO] [stdout] 88 | | ... "{}", [INFO] [stdout] 89 | | ... format!("{} Failed to clone: {}", "ERROR".bold().red(), e) [INFO] [stdout] 90 | | ... ); [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `println!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `gitURL` should have a snake case name [INFO] [stdout] --> src/cli/add.rs:75:33 [INFO] [stdout] | [INFO] [stdout] 75 | ... let gitURL = "https://github.com/".to_string() [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `git_url` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 22s [INFO] running `Command { std: "docker" "inspect" "bd094da5f0aac3155422b1108b4c4d70534eaa84e0a00d8a9e22242e5faf6911", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bd094da5f0aac3155422b1108b4c4d70534eaa84e0a00d8a9e22242e5faf6911", kill_on_drop: false }` [INFO] [stdout] bd094da5f0aac3155422b1108b4c4d70534eaa84e0a00d8a9e22242e5faf6911