[INFO] cloning repository https://github.com/C-Teo/AOC2024 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/C-Teo/AOC2024" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FC-Teo%2FAOC2024", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FC-Teo%2FAOC2024'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2e829582658ae61520bd45cdd53c59fdb421d6f0 [INFO] linting C-Teo/AOC2024 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FC-Teo%2FAOC2024" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/C-Teo/AOC2024 [INFO] finished tweaking git repo https://github.com/C-Teo/AOC2024 [INFO] tweaked toml for git repo https://github.com/C-Teo/AOC2024 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/C-Teo/AOC2024 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/C-Teo/AOC2024 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 81d2273a4b37093361ce5b41af97b108d5274006511afd4965cfdae21d152323 [INFO] running `Command { std: "docker" "start" "-a" "81d2273a4b37093361ce5b41af97b108d5274006511afd4965cfdae21d152323", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "81d2273a4b37093361ce5b41af97b108d5274006511afd4965cfdae21d152323", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "81d2273a4b37093361ce5b41af97b108d5274006511afd4965cfdae21d152323", kill_on_drop: false }` [INFO] [stdout] 81d2273a4b37093361ce5b41af97b108d5274006511afd4965cfdae21d152323 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c17457e5d4f497550312498db48d7524b2e3b81d8e4667b194293b5c338d7ecd [INFO] running `Command { std: "docker" "start" "-a" "c17457e5d4f497550312498db48d7524b2e3b81d8e4667b194293b5c338d7ecd", kill_on_drop: false }` [INFO] [stderr] Checking AOC2024 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: name `INC` contains a capitalized acronym [INFO] [stdout] --> src/solutions/day02/mod.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | INC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEC` contains a capitalized acronym [INFO] [stdout] --> src/solutions/day02/mod.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | DEC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/solutions/day03/mod.rs:133:8 [INFO] [stdout] | [INFO] [stdout] 133 | if !input[idx..=idx].parse::().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `input[idx..=idx].parse::().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/solutions/day03/mod.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 144 | return Ok((input[idx..index].parse().unwrap(), index)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 144 - return Ok((input[idx..index].parse().unwrap(), index)); [INFO] [stdout] 144 + Ok((input[idx..index].parse().unwrap(), index)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/solutions/day03/mod.rs:137:11 [INFO] [stdout] | [INFO] [stdout] 137 | while (&input)[idx..=index].parse::().is_ok() { [INFO] [stdout] | ^^^^^^^^ help: change this to: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/solutions/day03/mod.rs:149:5 [INFO] [stdout] | [INFO] [stdout] 149 | return val; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 149 - return val; [INFO] [stdout] 149 + val [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/solutions/day04/mod.rs:61:22 [INFO] [stdout] | [INFO] [stdout] 61 | if input[i as usize][j as usize] == 'A' { [INFO] [stdout] | ^^^^^^^^^^ help: try: `{ i }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/solutions/day04/mod.rs:61:34 [INFO] [stdout] | [INFO] [stdout] 61 | if input[i as usize][j as usize] == 'A' { [INFO] [stdout] | ^^^^^^^^^^ help: try: `j` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/solutions/day04/mod.rs:68:21 [INFO] [stdout] | [INFO] [stdout] 68 | / if (a + dir.0) >= 0 [INFO] [stdout] 69 | | && ((a + dir.0) as usize) < input.len() [INFO] [stdout] 70 | | && (b + dir.1) >= 0 [INFO] [stdout] 71 | | && ((b + dir.1) as usize) < input[0].len() [INFO] [stdout] ... | [INFO] [stdout] 82 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 75 ~ && ((b - dir.1) as usize) < input[0].len() [INFO] [stdout] 76 ~ && input[(a + dir.0) as usize][(b + dir.1) as usize] == 'M' [INFO] [stdout] 77 | && input[(a - dir.0) as usize][(b - dir.1) as usize] == 'S' [INFO] [stdout] 78 | { [INFO] [stdout] 79 | ct += 1; [INFO] [stdout] 80 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/solutions/day05/mod.rs:18:31 [INFO] [stdout] | [INFO] [stdout] 18 | if cache.contains(&update) { [INFO] [stdout] | ^^^^^^^ help: change this to: `update` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/solutions/day05/mod.rs:22:30 [INFO] [stdout] | [INFO] [stdout] 22 | match mp.get_mut(&update) { [INFO] [stdout] | ^^^^^^^ help: change this to: `update` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/solutions/day05/mod.rs:42:15 [INFO] [stdout] | [INFO] [stdout] 42 | fn input() -> (HashMap)>, Vec>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/solutions/day05/mod.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 50 | if line == "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INC` contains a capitalized acronym [INFO] [stdout] --> src/solutions/day02/mod.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | INC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEC` contains a capitalized acronym [INFO] [stdout] --> src/solutions/day02/mod.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | DEC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/solutions/day03/mod.rs:133:8 [INFO] [stdout] | [INFO] [stdout] 133 | if !input[idx..=idx].parse::().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `input[idx..=idx].parse::().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/solutions/day03/mod.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 144 | return Ok((input[idx..index].parse().unwrap(), index)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 144 - return Ok((input[idx..index].parse().unwrap(), index)); [INFO] [stdout] 144 + Ok((input[idx..index].parse().unwrap(), index)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/solutions/day03/mod.rs:137:11 [INFO] [stdout] | [INFO] [stdout] 137 | while (&input)[idx..=index].parse::().is_ok() { [INFO] [stdout] | ^^^^^^^^ help: change this to: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/solutions/day03/mod.rs:149:5 [INFO] [stdout] | [INFO] [stdout] 149 | return val; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 149 - return val; [INFO] [stdout] 149 + val [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/solutions/day04/mod.rs:61:22 [INFO] [stdout] | [INFO] [stdout] 61 | if input[i as usize][j as usize] == 'A' { [INFO] [stdout] | ^^^^^^^^^^ help: try: `{ i }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/solutions/day04/mod.rs:61:34 [INFO] [stdout] | [INFO] [stdout] 61 | if input[i as usize][j as usize] == 'A' { [INFO] [stdout] | ^^^^^^^^^^ help: try: `j` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/solutions/day04/mod.rs:68:21 [INFO] [stdout] | [INFO] [stdout] 68 | / if (a + dir.0) >= 0 [INFO] [stdout] 69 | | && ((a + dir.0) as usize) < input.len() [INFO] [stdout] 70 | | && (b + dir.1) >= 0 [INFO] [stdout] 71 | | && ((b + dir.1) as usize) < input[0].len() [INFO] [stdout] ... | [INFO] [stdout] 82 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 75 ~ && ((b - dir.1) as usize) < input[0].len() [INFO] [stdout] 76 ~ && input[(a + dir.0) as usize][(b + dir.1) as usize] == 'M' [INFO] [stdout] 77 | && input[(a - dir.0) as usize][(b - dir.1) as usize] == 'S' [INFO] [stdout] 78 | { [INFO] [stdout] 79 | ct += 1; [INFO] [stdout] 80 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/solutions/day05/mod.rs:18:31 [INFO] [stdout] | [INFO] [stdout] 18 | if cache.contains(&update) { [INFO] [stdout] | ^^^^^^^ help: change this to: `update` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/solutions/day05/mod.rs:22:30 [INFO] [stdout] | [INFO] [stdout] 22 | match mp.get_mut(&update) { [INFO] [stdout] | ^^^^^^^ help: change this to: `update` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/solutions/day05/mod.rs:42:15 [INFO] [stdout] | [INFO] [stdout] 42 | fn input() -> (HashMap)>, Vec>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/solutions/day05/mod.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 50 | if line == "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.41s [INFO] running `Command { std: "docker" "inspect" "c17457e5d4f497550312498db48d7524b2e3b81d8e4667b194293b5c338d7ecd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c17457e5d4f497550312498db48d7524b2e3b81d8e4667b194293b5c338d7ecd", kill_on_drop: false }` [INFO] [stdout] c17457e5d4f497550312498db48d7524b2e3b81d8e4667b194293b5c338d7ecd