[INFO] cloning repository https://github.com/ButterDebugger/BreezeGui [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ButterDebugger/BreezeGui" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FButterDebugger%2FBreezeGui", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FButterDebugger%2FBreezeGui'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a4e6ad414b5358ba9ae414b2c02bd9f6bc89ccfb [INFO] linting ButterDebugger/BreezeGui against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FButterDebugger%2FBreezeGui" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ButterDebugger/BreezeGui [INFO] finished tweaking git repo https://github.com/ButterDebugger/BreezeGui [INFO] tweaked toml for git repo https://github.com/ButterDebugger/BreezeGui written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ButterDebugger/BreezeGui on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ButterDebugger/BreezeGui already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating git repository `https://github.com/gorilla-devs/libium` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded filetime_creation v0.2.0 [INFO] [stderr] Downloaded lazy-regex v3.4.1 [INFO] [stderr] Downloaded murmur2 v0.1.0 [INFO] [stderr] Downloaded zip-extensions v0.8.1 [INFO] [stderr] Downloaded furse v1.5.15 [INFO] [stderr] Downloaded lzma-rust v0.1.7 [INFO] [stderr] Downloaded lazy-regex-proc_macros v3.4.1 [INFO] [stderr] Downloaded quinn-udp v0.5.9 [INFO] [stderr] Downloaded ferinth v2.11.1 [INFO] [stderr] Downloaded snafu v0.8.5 [INFO] [stderr] Downloaded wayland-client v0.31.8 [INFO] [stderr] Downloaded wayland-backend v0.3.8 [INFO] [stderr] Downloaded zip v2.2.2 [INFO] [stderr] Downloaded iri-string v0.7.7 [INFO] [stderr] Downloaded winnow v0.7.2 [INFO] [stderr] Downloaded ashpd v0.10.2 [INFO] [stderr] Downloaded quick-xml v0.37.2 [INFO] [stderr] Downloaded wayland-protocols v0.32.6 [INFO] [stderr] Downloaded rfd v0.15.2 [INFO] [stderr] Downloaded nt-time v0.8.1 [INFO] [stderr] Downloaded snafu-derive v0.8.5 [INFO] [stderr] Downloaded open v5.3.1 [INFO] [stderr] Downloaded octocrab v0.42.1 [INFO] [stderr] Downloaded sevenz-rust v0.6.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a38a7ae04bc44fc89b93654104aa2467bbd815f431aff7df612cc3dd930bc17b [INFO] running `Command { std: "docker" "start" "-a" "a38a7ae04bc44fc89b93654104aa2467bbd815f431aff7df612cc3dd930bc17b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a38a7ae04bc44fc89b93654104aa2467bbd815f431aff7df612cc3dd930bc17b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a38a7ae04bc44fc89b93654104aa2467bbd815f431aff7df612cc3dd930bc17b", kill_on_drop: false }` [INFO] [stdout] a38a7ae04bc44fc89b93654104aa2467bbd815f431aff7df612cc3dd930bc17b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 552aed6ef0088a399827ee5530059f5b9fc909e8a9c3727143d015f17ae92662 [INFO] running `Command { std: "docker" "start" "-a" "552aed6ef0088a399827ee5530059f5b9fc909e8a9c3727143d015f17ae92662", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.92 [INFO] [stderr] Compiling libc v0.2.169 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Checking bytes v1.9.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking litemap v0.7.4 [INFO] [stderr] Compiling rustix v0.38.42 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking indexmap v2.7.0 [INFO] [stderr] Compiling winnow v0.7.2 [INFO] [stderr] Checking rustls-pki-types v1.10.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking futures-lite v2.6.0 [INFO] [stderr] Compiling static_assertions v1.1.0 [INFO] [stderr] Checking unicode-ident v1.0.14 [INFO] [stderr] Compiling rustls v0.23.20 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling native-tls v0.2.13 [INFO] [stderr] Checking libloading v0.8.6 [INFO] [stderr] Checking http v1.2.0 [INFO] [stderr] Compiling wayland-sys v0.31.6 [INFO] [stderr] Checking cpufeatures v0.2.16 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Checking webpki-roots v0.26.7 [INFO] [stderr] Checking rustls-native-certs v0.8.1 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking quote v1.0.38 [INFO] [stderr] Checking event-listener v5.4.0 [INFO] [stderr] Compiling endi v1.1.0 [INFO] [stderr] Checking syn v2.0.93 [INFO] [stderr] Checking crc v3.2.1 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking event-listener-strategy v0.5.3 [INFO] [stderr] Compiling quick-xml v0.37.2 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Compiling thiserror v2.0.9 [INFO] [stderr] Compiling wayland-client v0.31.8 [INFO] [stderr] Checking miniz_oxide v0.8.2 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling cc v1.2.6 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking rustls-pemfile v2.2.0 [INFO] [stderr] Checking bumpalo v3.16.0 [INFO] [stderr] Checking ipnet v2.10.1 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking lockfree-object-pool v0.1.6 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Compiling zip v2.2.2 [INFO] [stderr] Checking async-fs v2.1.2 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking flate2 v1.0.35 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking lzma-rs v0.3.0 [INFO] [stderr] Checking zopfli v0.8.1 [INFO] [stderr] Checking async-executor v1.13.1 [INFO] [stderr] Compiling wayland-scanner v0.31.6 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking pem v3.0.4 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking iri-string v0.7.7 [INFO] [stderr] Checking deflate64 v0.1.9 [INFO] [stderr] Checking clap_builder v4.5.23 [INFO] [stderr] Checking is-docker v0.2.0 [INFO] [stderr] Checking murmur2 v0.1.0 [INFO] [stderr] Checking web-time v1.1.0 [INFO] [stderr] Checking unicode-width v0.2.0 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking socket2 v0.5.8 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking xdg-home v1.3.0 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Compiling regex-automata v0.4.9 [INFO] [stderr] Checking raw-window-handle v0.6.2 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking bit-vec v0.7.0 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Compiling rfd v0.15.2 [INFO] [stderr] Checking filetime_creation v0.2.0 [INFO] [stderr] Checking console v0.15.10 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking bit-set v0.6.0 [INFO] [stderr] Checking is-wsl v0.4.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking nt-time v0.8.1 [INFO] [stderr] Checking lzma-rust v0.1.7 [INFO] [stderr] Checking open v5.3.1 [INFO] [stderr] Compiling toml_edit v0.22.24 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling openssl-sys v0.9.106 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Compiling wayland-backend v0.3.8 [INFO] [stderr] Checking sevenz-rust v0.6.1 [INFO] [stderr] Compiling openssl v0.10.71 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Checking tempfile v3.14.0 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Compiling regex v1.11.1 [INFO] [stderr] Compiling serde_derive v1.0.217 [INFO] [stderr] Compiling zerofrom-derive v0.1.5 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tracing-attributes v0.1.28 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling enumflags2_derive v0.7.11 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking tokio v1.43.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking rustls-webpki v0.102.8 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling thiserror-impl v2.0.9 [INFO] [stderr] Compiling pin-project-internal v1.1.7 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking zerofrom v0.1.5 [INFO] [stderr] Compiling lazy-regex-proc_macros v3.4.1 [INFO] [stderr] Checking polling v3.7.4 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Compiling snafu-derive v0.8.5 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking async-io v2.4.0 [INFO] [stderr] Checking secrecy v0.10.3 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking simple_asn1 v0.6.2 [INFO] [stderr] Checking lazy-regex v3.4.1 [INFO] [stderr] Compiling clap_derive v4.5.18 [INFO] [stderr] Compiling derive_more-impl v1.0.0 [INFO] [stderr] Checking dialoguer v0.11.0 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking pin-project v1.1.7 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking wayland-protocols v0.32.6 [INFO] [stderr] Checking async-signal v0.2.10 [INFO] [stderr] Checking async-net v2.0.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking async-process v2.3.0 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking serde v1.0.217 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking clap v4.5.23 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking derive_more v1.0.0 [INFO] [stderr] Checking snafu v0.8.5 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking zip-extensions v0.8.1 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking tokio-util v0.7.13 [INFO] [stderr] Checking tokio-rustls v0.26.1 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking h2 v0.4.7 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Compiling zvariant_utils v3.2.0 [INFO] [stderr] Compiling enumflags2 v0.7.11 [INFO] [stderr] Checking serde_json v1.0.134 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking chrono v0.4.39 [INFO] [stderr] Checking serde_path_to_error v0.1.16 [INFO] [stderr] Compiling zvariant_derive v5.4.0 [INFO] [stderr] Checking tower-http v0.6.2 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking jsonwebtoken v9.3.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Compiling zvariant v5.4.0 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking hyper-util v0.1.10 [INFO] [stderr] Compiling zbus_names v4.2.0 [INFO] [stderr] Compiling zbus_macros v5.5.0 [INFO] [stderr] Checking hyper-rustls v0.27.5 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking hyper-timeout v0.5.2 [INFO] [stderr] Checking reqwest v0.12.12 [INFO] [stderr] Checking octocrab v0.42.1 [INFO] [stderr] Checking furse v1.5.15 [INFO] [stderr] Checking ferinth v2.11.1 [INFO] [stderr] Checking zbus v5.5.0 [INFO] [stderr] Checking ashpd v0.10.2 [INFO] [stderr] Checking libium v1.32.0 (https://github.com/gorilla-devs/libium#71305712) [INFO] [stderr] Checking breeze_gui v1.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/config.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 29 | if !maybe_config.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `maybe_config.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `maybe_config` after checking its variant with `is_err` [INFO] [stdout] --> src/config.rs:30:34 [INFO] [stdout] | [INFO] [stdout] 29 | if !maybe_config.is_err() { [INFO] [stdout] | --------------------- the check is happening here [INFO] [stdout] 30 | let config: Config = maybe_config.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | return config; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return config; [INFO] [stdout] 87 + config [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `client` after checking its variant with `is_err` [INFO] [stdout] --> src/installations.rs:52:54 [INFO] [stdout] | [INFO] [stdout] 51 | if client.is_err() { [INFO] [stdout] | ------------------ help: try: `if let Err() = client` [INFO] [stdout] 52 | println!("Failed to create http client: {}", client.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `res` after checking its variant with `is_err` [INFO] [stdout] --> src/installations.rs:65:40 [INFO] [stdout] | [INFO] [stdout] 64 | if res.is_err() { [INFO] [stdout] | --------------- help: try: `if let Err() = res` [INFO] [stdout] 65 | println!("Request failed: {}", res.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `body` after checking its variant with `is_err` [INFO] [stdout] --> src/installations.rs:80:46 [INFO] [stdout] | [INFO] [stdout] 79 | if body.is_err() { [INFO] [stdout] | ---------------- help: try: `if let Err() = body` [INFO] [stdout] 80 | println!("Failed to parse JSON: {}", body.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `body.get(0)` [INFO] [stdout] --> src/installations.rs:87:17 [INFO] [stdout] | [INFO] [stdout] 87 | let entry = body.get(0); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `body.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `client` after checking its variant with `is_err` [INFO] [stdout] --> src/installations.rs:109:54 [INFO] [stdout] | [INFO] [stdout] 108 | if client.is_err() { [INFO] [stdout] | ------------------ help: try: `if let Err() = client` [INFO] [stdout] 109 | println!("Failed to create http client: {}", client.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `client` after checking its variant with `is_err` [INFO] [stdout] --> src/installations.rs:128:54 [INFO] [stdout] | [INFO] [stdout] 127 | if client.is_err() { [INFO] [stdout] | ------------------ help: try: `if let Err() = client` [INFO] [stdout] 128 | println!("Failed to create http client: {}", client.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `res` after checking its variant with `is_err` [INFO] [stdout] --> src/installations.rs:141:40 [INFO] [stdout] | [INFO] [stdout] 140 | if res.is_err() { [INFO] [stdout] | --------------- help: try: `if let Err() = res` [INFO] [stdout] 141 | println!("Request failed: {}", res.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `body` after checking its variant with `is_err` [INFO] [stdout] --> src/installations.rs:156:46 [INFO] [stdout] | [INFO] [stdout] 155 | if body.is_err() { [INFO] [stdout] | ---------------- help: try: `if let Err() = body` [INFO] [stdout] 156 | println!("Failed to parse JSON: {}", body.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `res` after checking its variant with `is_err` [INFO] [stdout] --> src/installations.rs:173:41 [INFO] [stdout] | [INFO] [stdout] 172 | if res.is_err() { [INFO] [stdout] | --------------- help: try: `if let Err() = res` [INFO] [stdout] 173 | println!("Download failed: {}", res.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `child` after checking its variant with `is_err` [INFO] [stdout] --> src/installations.rs:202:53 [INFO] [stdout] | [INFO] [stdout] 201 | if child.is_err() { [INFO] [stdout] | ----------------- help: try: `if let Err() = child` [INFO] [stdout] 202 | println!("Failed to execute installer: {}", child.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `write_all` doesn't need a mutable reference [INFO] [stdout] --> src/installations.rs:192:20 [INFO] [stdout] | [INFO] [stdout] 192 | file.write_all(&mut content).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 192 - file.write_all(&mut content).unwrap(); [INFO] [stdout] 192 + file.write_all(&content).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/modpacks.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 142 | let _ = zip_create_from_directory(&modpack_path, &temp_path).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 142 - let _ = zip_create_from_directory(&modpack_path, &temp_path).unwrap(); [INFO] [stdout] 142 + zip_create_from_directory(&modpack_path, &temp_path).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/modpacks.rs:264:5 [INFO] [stdout] | [INFO] [stdout] 264 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 264 - return true; [INFO] [stdout] 264 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/modpacks.rs:240:5 [INFO] [stdout] | [INFO] [stdout] 240 | / for ele in fs::read_dir(minecraft_path.join("mods")).expect("Cannot read mods directory") { [INFO] [stdout] 241 | | if let Ok(entry) = ele { [INFO] [stdout] 242 | | let entry_path = entry.path(); [INFO] [stdout] 243 | | if entry_path.is_file() && entry_path.extension().unwrap() == "jar" { [INFO] [stdout] ... | [INFO] [stdout] 251 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/modpacks.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 241 | / if let Ok(entry) = ele { [INFO] [stdout] 242 | | let entry_path = entry.path(); [INFO] [stdout] 243 | | if entry_path.is_file() && entry_path.extension().unwrap() == "jar" { [INFO] [stdout] 244 | | let _ = fs::rename( [INFO] [stdout] ... | [INFO] [stdout] 250 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 240 ~ for entry in fs::read_dir(minecraft_path.join("mods")).expect("Cannot read mods directory").flatten() { [INFO] [stdout] 241 + let entry_path = entry.path(); [INFO] [stdout] 242 + if entry_path.is_file() && entry_path.extension().unwrap() == "jar" { [INFO] [stdout] 243 + let _ = fs::rename( [INFO] [stdout] 244 + // TODO: handle error (program using jar) [INFO] [stdout] 245 + entry_path.clone(), [INFO] [stdout] 246 + temp_path.join(entry_path.file_name().unwrap()), [INFO] [stdout] 247 + ); [INFO] [stdout] 248 + } [INFO] [stdout] 249 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mods.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 91 - return true; [INFO] [stdout] 91 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return false; [INFO] [stdout] 23 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/utils.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / for ele in fs::read_dir(minecraft_path.join("mods")).expect("Cannot read mods directory") { [INFO] [stdout] 15 | | if let Ok(entry) = ele { [INFO] [stdout] 16 | | let entry_path = entry.path(); [INFO] [stdout] 17 | | if entry_path.is_file() && entry_path.extension().unwrap() == "jar" { [INFO] [stdout] ... | [INFO] [stdout] 21 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/utils.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | / if let Ok(entry) = ele { [INFO] [stdout] 16 | | let entry_path = entry.path(); [INFO] [stdout] 17 | | if entry_path.is_file() && entry_path.extension().unwrap() == "jar" { [INFO] [stdout] 18 | | return true; [INFO] [stdout] 19 | | } [INFO] [stdout] 20 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 14 ~ for entry in fs::read_dir(minecraft_path.join("mods")).expect("Cannot read mods directory").flatten() { [INFO] [stdout] 15 + let entry_path = entry.path(); [INFO] [stdout] 16 + if entry_path.is_file() && entry_path.extension().unwrap() == "jar" { [INFO] [stdout] 17 + return true; [INFO] [stdout] 18 + } [INFO] [stdout] 19 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | return installed_mods; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return installed_mods; [INFO] [stdout] 48 + installed_mods [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/utils.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | / for ele in fs::read_dir(minecraft_path.join("mods")).expect("Cannot read mods directory") { [INFO] [stdout] 34 | | if let Ok(entry) = ele { [INFO] [stdout] 35 | | let entry_path = entry.path(); [INFO] [stdout] 36 | | if entry_path.is_file() && entry_path.extension().unwrap() == "jar" { [INFO] [stdout] ... | [INFO] [stdout] 46 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/utils.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | / if let Ok(entry) = ele { [INFO] [stdout] 35 | | let entry_path = entry.path(); [INFO] [stdout] 36 | | if entry_path.is_file() && entry_path.extension().unwrap() == "jar" { [INFO] [stdout] 37 | | installed_mods.push( [INFO] [stdout] ... | [INFO] [stdout] 45 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 33 ~ for entry in fs::read_dir(minecraft_path.join("mods")).expect("Cannot read mods directory").flatten() { [INFO] [stdout] 34 + let entry_path = entry.path(); [INFO] [stdout] 35 + if entry_path.is_file() && entry_path.extension().unwrap() == "jar" { [INFO] [stdout] 36 + installed_mods.push( [INFO] [stdout] 37 + entry_path [INFO] [stdout] 38 + .file_stem() [INFO] [stdout] 39 + .unwrap() [INFO] [stdout] 40 + .to_string_lossy() [INFO] [stdout] 41 + .to_string(), [INFO] [stdout] 42 + ); [INFO] [stdout] 43 + } [INFO] [stdout] 44 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | return modpack_names; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return modpack_names; [INFO] [stdout] 75 + modpack_names [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/utils.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | / for ele in [INFO] [stdout] 59 | | fs::read_dir(minecraft_path.join("modpacks")).expect("Cannot read modpacks directory") [INFO] [stdout] 60 | | { [INFO] [stdout] 61 | | if let Ok(entry) = ele { [INFO] [stdout] ... | [INFO] [stdout] 73 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/utils.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | / if let Ok(entry) = ele { [INFO] [stdout] 62 | | let entry_path = entry.path(); [INFO] [stdout] 63 | | if entry_path.is_file() && entry_path.extension().unwrap() == "zip" { [INFO] [stdout] 64 | | modpack_names.push( [INFO] [stdout] ... | [INFO] [stdout] 72 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 58 ~ for entry in [INFO] [stdout] 59 ~ fs::read_dir(minecraft_path.join("modpacks")).expect("Cannot read modpacks directory").flatten() [INFO] [stdout] 60 ~ { [INFO] [stdout] 61 + let entry_path = entry.path(); [INFO] [stdout] 62 + if entry_path.is_file() && entry_path.extension().unwrap() == "zip" { [INFO] [stdout] 63 + modpack_names.push( [INFO] [stdout] 64 + entry_path [INFO] [stdout] 65 + .file_stem() [INFO] [stdout] 66 + .unwrap() [INFO] [stdout] 67 + .to_string_lossy() [INFO] [stdout] 68 + .to_string(), [INFO] [stdout] 69 + ); [INFO] [stdout] 70 + } [INFO] [stdout] 71 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/config.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 29 | if !maybe_config.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `maybe_config.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `maybe_config` after checking its variant with `is_err` [INFO] [stdout] --> src/config.rs:30:34 [INFO] [stdout] | [INFO] [stdout] 29 | if !maybe_config.is_err() { [INFO] [stdout] | --------------------- the check is happening here [INFO] [stdout] 30 | let config: Config = maybe_config.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | return config; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return config; [INFO] [stdout] 87 + config [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `client` after checking its variant with `is_err` [INFO] [stdout] --> src/installations.rs:52:54 [INFO] [stdout] | [INFO] [stdout] 51 | if client.is_err() { [INFO] [stdout] | ------------------ help: try: `if let Err() = client` [INFO] [stdout] 52 | println!("Failed to create http client: {}", client.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `res` after checking its variant with `is_err` [INFO] [stdout] --> src/installations.rs:65:40 [INFO] [stdout] | [INFO] [stdout] 64 | if res.is_err() { [INFO] [stdout] | --------------- help: try: `if let Err() = res` [INFO] [stdout] 65 | println!("Request failed: {}", res.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `body` after checking its variant with `is_err` [INFO] [stdout] --> src/installations.rs:80:46 [INFO] [stdout] | [INFO] [stdout] 79 | if body.is_err() { [INFO] [stdout] | ---------------- help: try: `if let Err() = body` [INFO] [stdout] 80 | println!("Failed to parse JSON: {}", body.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `body.get(0)` [INFO] [stdout] --> src/installations.rs:87:17 [INFO] [stdout] | [INFO] [stdout] 87 | let entry = body.get(0); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `body.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `client` after checking its variant with `is_err` [INFO] [stdout] --> src/installations.rs:109:54 [INFO] [stdout] | [INFO] [stdout] 108 | if client.is_err() { [INFO] [stdout] | ------------------ help: try: `if let Err() = client` [INFO] [stdout] 109 | println!("Failed to create http client: {}", client.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `client` after checking its variant with `is_err` [INFO] [stdout] --> src/installations.rs:128:54 [INFO] [stdout] | [INFO] [stdout] 127 | if client.is_err() { [INFO] [stdout] | ------------------ help: try: `if let Err() = client` [INFO] [stdout] 128 | println!("Failed to create http client: {}", client.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `res` after checking its variant with `is_err` [INFO] [stdout] --> src/installations.rs:141:40 [INFO] [stdout] | [INFO] [stdout] 140 | if res.is_err() { [INFO] [stdout] | --------------- help: try: `if let Err() = res` [INFO] [stdout] 141 | println!("Request failed: {}", res.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `body` after checking its variant with `is_err` [INFO] [stdout] --> src/installations.rs:156:46 [INFO] [stdout] | [INFO] [stdout] 155 | if body.is_err() { [INFO] [stdout] | ---------------- help: try: `if let Err() = body` [INFO] [stdout] 156 | println!("Failed to parse JSON: {}", body.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `res` after checking its variant with `is_err` [INFO] [stdout] --> src/installations.rs:173:41 [INFO] [stdout] | [INFO] [stdout] 172 | if res.is_err() { [INFO] [stdout] | --------------- help: try: `if let Err() = res` [INFO] [stdout] 173 | println!("Download failed: {}", res.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `child` after checking its variant with `is_err` [INFO] [stdout] --> src/installations.rs:202:53 [INFO] [stdout] | [INFO] [stdout] 201 | if child.is_err() { [INFO] [stdout] | ----------------- help: try: `if let Err() = child` [INFO] [stdout] 202 | println!("Failed to execute installer: {}", child.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `write_all` doesn't need a mutable reference [INFO] [stdout] --> src/installations.rs:192:20 [INFO] [stdout] | [INFO] [stdout] 192 | file.write_all(&mut content).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 192 - file.write_all(&mut content).unwrap(); [INFO] [stdout] 192 + file.write_all(&content).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/modpacks.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 142 | let _ = zip_create_from_directory(&modpack_path, &temp_path).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 142 - let _ = zip_create_from_directory(&modpack_path, &temp_path).unwrap(); [INFO] [stdout] 142 + zip_create_from_directory(&modpack_path, &temp_path).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/modpacks.rs:264:5 [INFO] [stdout] | [INFO] [stdout] 264 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 264 - return true; [INFO] [stdout] 264 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/modpacks.rs:240:5 [INFO] [stdout] | [INFO] [stdout] 240 | / for ele in fs::read_dir(minecraft_path.join("mods")).expect("Cannot read mods directory") { [INFO] [stdout] 241 | | if let Ok(entry) = ele { [INFO] [stdout] 242 | | let entry_path = entry.path(); [INFO] [stdout] 243 | | if entry_path.is_file() && entry_path.extension().unwrap() == "jar" { [INFO] [stdout] ... | [INFO] [stdout] 251 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/modpacks.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 241 | / if let Ok(entry) = ele { [INFO] [stdout] 242 | | let entry_path = entry.path(); [INFO] [stdout] 243 | | if entry_path.is_file() && entry_path.extension().unwrap() == "jar" { [INFO] [stdout] 244 | | let _ = fs::rename( [INFO] [stdout] ... | [INFO] [stdout] 250 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 240 ~ for entry in fs::read_dir(minecraft_path.join("mods")).expect("Cannot read mods directory").flatten() { [INFO] [stdout] 241 + let entry_path = entry.path(); [INFO] [stdout] 242 + if entry_path.is_file() && entry_path.extension().unwrap() == "jar" { [INFO] [stdout] 243 + let _ = fs::rename( [INFO] [stdout] 244 + // TODO: handle error (program using jar) [INFO] [stdout] 245 + entry_path.clone(), [INFO] [stdout] 246 + temp_path.join(entry_path.file_name().unwrap()), [INFO] [stdout] 247 + ); [INFO] [stdout] 248 + } [INFO] [stdout] 249 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mods.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 91 - return true; [INFO] [stdout] 91 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return false; [INFO] [stdout] 23 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/utils.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / for ele in fs::read_dir(minecraft_path.join("mods")).expect("Cannot read mods directory") { [INFO] [stdout] 15 | | if let Ok(entry) = ele { [INFO] [stdout] 16 | | let entry_path = entry.path(); [INFO] [stdout] 17 | | if entry_path.is_file() && entry_path.extension().unwrap() == "jar" { [INFO] [stdout] ... | [INFO] [stdout] 21 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/utils.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | / if let Ok(entry) = ele { [INFO] [stdout] 16 | | let entry_path = entry.path(); [INFO] [stdout] 17 | | if entry_path.is_file() && entry_path.extension().unwrap() == "jar" { [INFO] [stdout] 18 | | return true; [INFO] [stdout] 19 | | } [INFO] [stdout] 20 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 14 ~ for entry in fs::read_dir(minecraft_path.join("mods")).expect("Cannot read mods directory").flatten() { [INFO] [stdout] 15 + let entry_path = entry.path(); [INFO] [stdout] 16 + if entry_path.is_file() && entry_path.extension().unwrap() == "jar" { [INFO] [stdout] 17 + return true; [INFO] [stdout] 18 + } [INFO] [stdout] 19 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | return installed_mods; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return installed_mods; [INFO] [stdout] 48 + installed_mods [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/utils.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | / for ele in fs::read_dir(minecraft_path.join("mods")).expect("Cannot read mods directory") { [INFO] [stdout] 34 | | if let Ok(entry) = ele { [INFO] [stdout] 35 | | let entry_path = entry.path(); [INFO] [stdout] 36 | | if entry_path.is_file() && entry_path.extension().unwrap() == "jar" { [INFO] [stdout] ... | [INFO] [stdout] 46 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/utils.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | / if let Ok(entry) = ele { [INFO] [stdout] 35 | | let entry_path = entry.path(); [INFO] [stdout] 36 | | if entry_path.is_file() && entry_path.extension().unwrap() == "jar" { [INFO] [stdout] 37 | | installed_mods.push( [INFO] [stdout] ... | [INFO] [stdout] 45 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 33 ~ for entry in fs::read_dir(minecraft_path.join("mods")).expect("Cannot read mods directory").flatten() { [INFO] [stdout] 34 + let entry_path = entry.path(); [INFO] [stdout] 35 + if entry_path.is_file() && entry_path.extension().unwrap() == "jar" { [INFO] [stdout] 36 + installed_mods.push( [INFO] [stdout] 37 + entry_path [INFO] [stdout] 38 + .file_stem() [INFO] [stdout] 39 + .unwrap() [INFO] [stdout] 40 + .to_string_lossy() [INFO] [stdout] 41 + .to_string(), [INFO] [stdout] 42 + ); [INFO] [stdout] 43 + } [INFO] [stdout] 44 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | return modpack_names; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return modpack_names; [INFO] [stdout] 75 + modpack_names [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/utils.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | / for ele in [INFO] [stdout] 59 | | fs::read_dir(minecraft_path.join("modpacks")).expect("Cannot read modpacks directory") [INFO] [stdout] 60 | | { [INFO] [stdout] 61 | | if let Ok(entry) = ele { [INFO] [stdout] ... | [INFO] [stdout] 73 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/utils.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | / if let Ok(entry) = ele { [INFO] [stdout] 62 | | let entry_path = entry.path(); [INFO] [stdout] 63 | | if entry_path.is_file() && entry_path.extension().unwrap() == "zip" { [INFO] [stdout] 64 | | modpack_names.push( [INFO] [stdout] ... | [INFO] [stdout] 72 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 58 ~ for entry in [INFO] [stdout] 59 ~ fs::read_dir(minecraft_path.join("modpacks")).expect("Cannot read modpacks directory").flatten() [INFO] [stdout] 60 ~ { [INFO] [stdout] 61 + let entry_path = entry.path(); [INFO] [stdout] 62 + if entry_path.is_file() && entry_path.extension().unwrap() == "zip" { [INFO] [stdout] 63 + modpack_names.push( [INFO] [stdout] 64 + entry_path [INFO] [stdout] 65 + .file_stem() [INFO] [stdout] 66 + .unwrap() [INFO] [stdout] 67 + .to_string_lossy() [INFO] [stdout] 68 + .to_string(), [INFO] [stdout] 69 + ); [INFO] [stdout] 70 + } [INFO] [stdout] 71 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 41s [INFO] running `Command { std: "docker" "inspect" "552aed6ef0088a399827ee5530059f5b9fc909e8a9c3727143d015f17ae92662", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "552aed6ef0088a399827ee5530059f5b9fc909e8a9c3727143d015f17ae92662", kill_on_drop: false }` [INFO] [stdout] 552aed6ef0088a399827ee5530059f5b9fc909e8a9c3727143d015f17ae92662