[INFO] cloning repository https://github.com/BuonHobo/petronio [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/BuonHobo/petronio" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBuonHobo%2Fpetronio", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBuonHobo%2Fpetronio'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] de23dcb491cf213081e2298344f70c66314a29a7 [INFO] linting BuonHobo/petronio against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBuonHobo%2Fpetronio" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/BuonHobo/petronio [INFO] finished tweaking git repo https://github.com/BuonHobo/petronio [INFO] tweaked toml for git repo https://github.com/BuonHobo/petronio written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/BuonHobo/petronio on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/BuonHobo/petronio already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 613e7eca5780c427f2c0c1cd37847346db9332459ee2b91d03a46353ab251ceb [INFO] running `Command { std: "docker" "start" "-a" "613e7eca5780c427f2c0c1cd37847346db9332459ee2b91d03a46353ab251ceb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "613e7eca5780c427f2c0c1cd37847346db9332459ee2b91d03a46353ab251ceb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "613e7eca5780c427f2c0c1cd37847346db9332459ee2b91d03a46353ab251ceb", kill_on_drop: false }` [INFO] [stdout] 613e7eca5780c427f2c0c1cd37847346db9332459ee2b91d03a46353ab251ceb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3771c52c3dc3f79338b1f538aa43855d1c9a9951b8be1eb6ce70e6e4fe9d0f53 [INFO] running `Command { std: "docker" "start" "-a" "3771c52c3dc3f79338b1f538aa43855d1c9a9951b8be1eb6ce70e6e4fe9d0f53", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.108 [INFO] [stderr] Checking ppv-lite86 v0.2.15 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking petri v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 27 | !(vect[*i] >= -*u as i32) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(vect[*i] < -*u as i32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i8` -> `i8`) [INFO] [stdout] --> src/main.rs:41:58 [INFO] [stdout] | [INFO] [stdout] 41 | .map(|(index, weight)| (*index as usize, *weight as i8)) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `(*weight)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/main.rs:53:39 [INFO] [stdout] | [INFO] [stdout] 53 | fn enable(&self, vect: &mut [i32]) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/main.rs:110:57 [INFO] [stdout] | [INFO] [stdout] 110 | let active_trans: Vec>> = shared_trans [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 111 | | .iter() [INFO] [stdout] 112 | | .filter(|t| lockunwrap(t).is_active(lockunwrap(&shared_places).as_slice())) [INFO] [stdout] 113 | | .map(|t| t.clone()) [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] help: consider calling the dedicated `cloned` method [INFO] [stdout] | [INFO] [stdout] 110 ~ let active_trans: Vec>> = shared_trans [INFO] [stdout] 111 + .iter() [INFO] [stdout] 112 + .filter(|t| lockunwrap(t).is_active(lockunwrap(&shared_places).as_slice())).cloned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:147:41 [INFO] [stdout] | [INFO] [stdout] 147 | let curr_trans = Arc::clone(&rand_trans); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `rand_trans` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/main.rs:67:25 [INFO] [stdout] | [INFO] [stdout] 67 | fn lockunwrap(input: &Arc>) -> MutexGuard { [INFO] [stdout] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 67 | fn lockunwrap(input: &Arc>) -> MutexGuard<'_, T> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 27 | !(vect[*i] >= -*u as i32) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(vect[*i] < -*u as i32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i8` -> `i8`) [INFO] [stdout] --> src/main.rs:41:58 [INFO] [stdout] | [INFO] [stdout] 41 | .map(|(index, weight)| (*index as usize, *weight as i8)) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `(*weight)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/main.rs:53:39 [INFO] [stdout] | [INFO] [stdout] 53 | fn enable(&self, vect: &mut [i32]) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/main.rs:110:57 [INFO] [stdout] | [INFO] [stdout] 110 | let active_trans: Vec>> = shared_trans [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 111 | | .iter() [INFO] [stdout] 112 | | .filter(|t| lockunwrap(t).is_active(lockunwrap(&shared_places).as_slice())) [INFO] [stdout] 113 | | .map(|t| t.clone()) [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] help: consider calling the dedicated `cloned` method [INFO] [stdout] | [INFO] [stdout] 110 ~ let active_trans: Vec>> = shared_trans [INFO] [stdout] 111 + .iter() [INFO] [stdout] 112 + .filter(|t| lockunwrap(t).is_active(lockunwrap(&shared_places).as_slice())).cloned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:147:41 [INFO] [stdout] | [INFO] [stdout] 147 | let curr_trans = Arc::clone(&rand_trans); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `rand_trans` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/main.rs:67:25 [INFO] [stdout] | [INFO] [stdout] 67 | fn lockunwrap(input: &Arc>) -> MutexGuard { [INFO] [stdout] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 67 | fn lockunwrap(input: &Arc>) -> MutexGuard<'_, T> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.31s [INFO] running `Command { std: "docker" "inspect" "3771c52c3dc3f79338b1f538aa43855d1c9a9951b8be1eb6ce70e6e4fe9d0f53", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3771c52c3dc3f79338b1f538aa43855d1c9a9951b8be1eb6ce70e6e4fe9d0f53", kill_on_drop: false }` [INFO] [stdout] 3771c52c3dc3f79338b1f538aa43855d1c9a9951b8be1eb6ce70e6e4fe9d0f53