[INFO] cloning repository https://github.com/Bogdans2001/Project_ATAD [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Bogdans2001/Project_ATAD" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBogdans2001%2FProject_ATAD", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBogdans2001%2FProject_ATAD'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7043eed69e34df22e15a0a033934ca074c4b1ae1 [INFO] linting Bogdans2001/Project_ATAD against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBogdans2001%2FProject_ATAD" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Bogdans2001/Project_ATAD [INFO] finished tweaking git repo https://github.com/Bogdans2001/Project_ATAD [INFO] tweaked toml for git repo https://github.com/Bogdans2001/Project_ATAD written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Bogdans2001/Project_ATAD on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Bogdans2001/Project_ATAD already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded clap v4.5.51 [INFO] [stderr] Downloaded tui-textarea v0.4.0 [INFO] [stderr] Downloaded clap_builder v4.5.51 [INFO] [stderr] Downloaded rusqlite v0.31.0 [INFO] [stderr] Downloaded ratatui v0.28.1 [INFO] [stderr] Downloaded libsqlite3-sys v0.28.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 890e5134a98d417b52e05eed7c203841627ef9674f51f28fda69d4bcbfb9610c [INFO] running `Command { std: "docker" "start" "-a" "890e5134a98d417b52e05eed7c203841627ef9674f51f28fda69d4bcbfb9610c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "890e5134a98d417b52e05eed7c203841627ef9674f51f28fda69d4bcbfb9610c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "890e5134a98d417b52e05eed7c203841627ef9674f51f28fda69d4bcbfb9610c", kill_on_drop: false }` [INFO] [stdout] 890e5134a98d417b52e05eed7c203841627ef9674f51f28fda69d4bcbfb9610c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f029bb07aa3a756ba2458268cb0378fdbffb02fc723abe701b2c07566834e7ca [INFO] running `Command { std: "docker" "start" "-a" "f029bb07aa3a756ba2458268cb0378fdbffb02fc723abe701b2c07566834e7ca", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.110 [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling find-msvc-tools v0.1.5 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking rustix v0.38.44 [INFO] [stderr] Checking compact_str v0.8.1 [INFO] [stderr] Checking clap_builder v4.5.51 [INFO] [stderr] Compiling cc v1.2.46 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking csv-core v0.1.13 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking signal-hook v0.3.18 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking signal-hook-mio v0.2.5 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Compiling libsqlite3-sys v0.28.0 [INFO] [stderr] Checking csv v1.4.0 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Compiling darling_core v0.23.0 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking clap v4.5.51 [INFO] [stderr] Compiling darling_macro v0.23.0 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Compiling darling v0.23.0 [INFO] [stderr] Compiling instability v0.3.11 [INFO] [stderr] Checking ratatui v0.28.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking uuid v1.18.1 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking quick-xml v0.36.2 [INFO] [stderr] Checking tui-textarea v0.4.0 [INFO] [stderr] Checking rusqlite v0.31.0 [INFO] [stderr] Checking finance_app v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/core/finance_app.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 69 | kind: kind, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/core/finance_app.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 69 | kind: kind, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/domain/category.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return None; [INFO] [stdout] 26 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/domain/category.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | / if let Ok(re) = Regex::new(rule) { [INFO] [stdout] 21 | | if re.is_match(description) { [INFO] [stdout] 22 | | return Some(category_id); [INFO] [stdout] 23 | | } [INFO] [stdout] 24 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 20 ~ if let Ok(re) = Regex::new(rule) [INFO] [stdout] 21 ~ && re.is_match(description) { [INFO] [stdout] 22 | return Some(category_id); [INFO] [stdout] 23 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/core/finance_app.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | expenses = expenses + amount; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expenses += amount` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/core/finance_app.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | Ok(self.transaction_service.search(filter)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 78 - Ok(self.transaction_service.search(filter)?) [INFO] [stdout] 78 + self.transaction_service.search(filter) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/domain/category.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return None; [INFO] [stdout] 26 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/domain/category.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | / if let Ok(re) = Regex::new(rule) { [INFO] [stdout] 21 | | if re.is_match(description) { [INFO] [stdout] 22 | | return Some(category_id); [INFO] [stdout] 23 | | } [INFO] [stdout] 24 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 20 ~ if let Ok(re) = Regex::new(rule) [INFO] [stdout] 21 ~ && re.is_match(description) { [INFO] [stdout] 22 | return Some(category_id); [INFO] [stdout] 23 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/core/finance_app.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | expenses = expenses + amount; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expenses += amount` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/core/finance_app.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | Ok(self.transaction_service.search(filter)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 78 - Ok(self.transaction_service.search(filter)?) [INFO] [stdout] 78 + self.transaction_service.search(filter) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/importers/csv_parser.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 10 | if !NaiveDate::parse_from_str(&row[0], "%Y-%m-%d").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `NaiveDate::parse_from_str(&row[0], "%Y-%m-%d").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/importers/csv_parser.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 13 | if !row[1].parse::().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `row[1].parse::().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/importers/csv_parser.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 19 | if !row[3].parse::().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `row[3].parse::().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/importers/csv_parser.rs:6:26 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn validate_row(row: &Vec) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 6 - pub fn validate_row(row: &Vec) -> anyhow::Result<()> { [INFO] [stdout] 6 + pub fn validate_row(row: &[String]) -> anyhow::Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/importers/csv_parser.rs:22:8 [INFO] [stdout] | [INFO] [stdout] 22 | if row[4] == "" { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `row[4].is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/tui.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | let next_row; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `next_row` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 25 ~ [INFO] [stdout] 26 | [INFO] [stdout] 27 ~ let next_row = if !direction{ [INFO] [stdout] 28 ~ match selected_row{ [INFO] [stdout] 29 | Some(row) => [INFO] [stdout] ... [INFO] [stdout] 37 | }else{ [INFO] [stdout] 38 ~ match selected_row{ [INFO] [stdout] 39 | Some(row) => [INFO] [stdout] ... [INFO] [stdout] 46 | } [INFO] [stdout] 47 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `cols.get(0)` [INFO] [stdout] --> src/tui.rs:108:32 [INFO] [stdout] | [INFO] [stdout] 108 | let date = cols.get(0).map(String::as_str).unwrap_or(""); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `cols.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/importers/csv_parser.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 10 | if !NaiveDate::parse_from_str(&row[0], "%Y-%m-%d").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `NaiveDate::parse_from_str(&row[0], "%Y-%m-%d").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/importers/csv_parser.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 13 | if !row[1].parse::().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `row[1].parse::().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/importers/csv_parser.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 19 | if !row[3].parse::().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `row[3].parse::().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/importers/csv_parser.rs:6:26 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn validate_row(row: &Vec) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 6 - pub fn validate_row(row: &Vec) -> anyhow::Result<()> { [INFO] [stdout] 6 + pub fn validate_row(row: &[String]) -> anyhow::Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/importers/csv_parser.rs:22:8 [INFO] [stdout] | [INFO] [stdout] 22 | if row[4] == "" { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `row[4].is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/tui.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | let next_row; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `next_row` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 25 ~ [INFO] [stdout] 26 | [INFO] [stdout] 27 ~ let next_row = if !direction{ [INFO] [stdout] 28 ~ match selected_row{ [INFO] [stdout] 29 | Some(row) => [INFO] [stdout] ... [INFO] [stdout] 37 | }else{ [INFO] [stdout] 38 ~ match selected_row{ [INFO] [stdout] 39 | Some(row) => [INFO] [stdout] ... [INFO] [stdout] 46 | } [INFO] [stdout] 47 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `cols.get(0)` [INFO] [stdout] --> src/tui.rs:108:32 [INFO] [stdout] | [INFO] [stdout] 108 | let date = cols.get(0).map(String::as_str).unwrap_or(""); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `cols.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 50.45s [INFO] running `Command { std: "docker" "inspect" "f029bb07aa3a756ba2458268cb0378fdbffb02fc723abe701b2c07566834e7ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f029bb07aa3a756ba2458268cb0378fdbffb02fc723abe701b2c07566834e7ca", kill_on_drop: false }` [INFO] [stdout] f029bb07aa3a756ba2458268cb0378fdbffb02fc723abe701b2c07566834e7ca