[INFO] cloning repository https://github.com/BjornTheProgrammer/rp2350-sim [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/BjornTheProgrammer/rp2350-sim" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBjornTheProgrammer%2Frp2350-sim", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBjornTheProgrammer%2Frp2350-sim'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ed01e53aac11c3b2298c1e9e140fdbf76620ef05 [INFO] linting BjornTheProgrammer/rp2350-sim against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBjornTheProgrammer%2Frp2350-sim" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-4-tc1/source/rust-toolchain.toml [INFO] started tweaking git repo https://github.com/BjornTheProgrammer/rp2350-sim [INFO] finished tweaking git repo https://github.com/BjornTheProgrammer/rp2350-sim [INFO] tweaked toml for git repo https://github.com/BjornTheProgrammer/rp2350-sim written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/BjornTheProgrammer/rp2350-sim on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/BjornTheProgrammer/rp2350-sim already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded bilge v0.2.0 [INFO] [stderr] Downloaded assert_hex v0.4.1 [INFO] [stderr] Downloaded bitmatch v0.1.1 [INFO] [stderr] Downloaded boolean_expression v0.3.11 [INFO] [stderr] Downloaded arbitrary-int v1.2.7 [INFO] [stderr] Downloaded bilge-impl v0.2.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bb5aedc1ed4687cf9f531a0d1fa21cb19f222f0413505d0c9872342ec3878009 [INFO] running `Command { std: "docker" "start" "-a" "bb5aedc1ed4687cf9f531a0d1fa21cb19f222f0413505d0c9872342ec3878009", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bb5aedc1ed4687cf9f531a0d1fa21cb19f222f0413505d0c9872342ec3878009", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb5aedc1ed4687cf9f531a0d1fa21cb19f222f0413505d0c9872342ec3878009", kill_on_drop: false }` [INFO] [stdout] bb5aedc1ed4687cf9f531a0d1fa21cb19f222f0413505d0c9872342ec3878009 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8d920f64079ad50673fd8195c7d60a0b5451c5f361eb6781c852944782f4f580 [INFO] running `Command { std: "docker" "start" "-a" "8d920f64079ad50673fd8195c7d60a0b5451c5f361eb6781c852944782f4f580", kill_on_drop: false }` [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling unicode-segmentation v1.11.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Compiling unicode-xid v0.2.4 [INFO] [stderr] Checking arbitrary-int v1.2.7 [INFO] [stderr] Checking assert_hex v0.4.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling syn v2.0.76 [INFO] [stderr] Compiling itertools v0.11.0 [INFO] [stderr] Compiling itertools v0.9.0 [INFO] [stderr] Compiling convert_case v0.6.0 [INFO] [stderr] Compiling boolean_expression v0.3.11 [INFO] [stderr] Compiling bitmatch v0.1.1 [INFO] [stderr] Compiling bilge-impl v0.2.0 [INFO] [stderr] Compiling derive_more-impl v1.0.0 [INFO] [stderr] Checking bilge v0.2.0 [INFO] [stderr] Checking derive_more v1.0.0 [INFO] [stderr] Checking rp2350-sim v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: operator precedence might not be obvious [INFO] [stdout] --> src/cortex_m33/instructions.rs:570:26 [INFO] [stdout] | [INFO] [stdout] 570 | .set(cortex_m33.registers.pc.get() + 2 | 0x1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(cortex_m33.registers.pc.get() + 2) | 0x1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stdout] = note: `#[warn(clippy::precedence)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Ipsr` [INFO] [stdout] --> src/cortex_m33/operation.rs:8:18 [INFO] [stdout] | [INFO] [stdout] 8 | apsr::{Apsr, Ipsr}, control::NPriv, exception::Exceptions, registers::{PcRegister, Register}, CortexM33, Mode [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: operator precedence might not be obvious [INFO] [stdout] --> src/cortex_m33/operation.rs:406:18 [INFO] [stdout] | [INFO] [stdout] 406 | let result = value >> 1 + (carry_in as u32) << 31; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `value >> (1 + (carry_in as u32))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cortex_m33::apsr::Apsr` [INFO] [stdout] --> src/cortex_m33/mod.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use crate::cortex_m33::apsr::Apsr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: operator precedence might not be obvious [INFO] [stdout] --> src/cortex_m33/instructions.rs:570:26 [INFO] [stdout] | [INFO] [stdout] 570 | .set(cortex_m33.registers.pc.get() + 2 | 0x1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(cortex_m33.registers.pc.get() + 2) | 0x1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stdout] = note: `#[warn(clippy::precedence)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Ipsr` [INFO] [stdout] --> src/cortex_m33/operation.rs:8:18 [INFO] [stdout] | [INFO] [stdout] 8 | apsr::{Apsr, Ipsr}, control::NPriv, exception::Exceptions, registers::{PcRegister, Register}, CortexM33, Mode [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: operator precedence might not be obvious [INFO] [stdout] --> src/cortex_m33/operation.rs:406:18 [INFO] [stdout] | [INFO] [stdout] 406 | let result = value >> 1 + (carry_in as u32) << 31; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `value >> (1 + (carry_in as u32))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cortex_m33::apsr::Apsr` [INFO] [stdout] --> src/cortex_m33/mod.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use crate::cortex_m33::apsr::Apsr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `frameptr` [INFO] [stdout] --> src/cortex_m33/operation.rs:260:17 [INFO] [stdout] | [INFO] [stdout] 260 | let frameptr = cortex.registers.sp.get_msp(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_frameptr` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `current_mode` [INFO] [stdout] --> src/cortex_m33/operation.rs:261:17 [INFO] [stdout] | [INFO] [stdout] 261 | let current_mode = Mode::Handler; [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_current_mode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `frameptr` [INFO] [stdout] --> src/cortex_m33/operation.rs:269:17 [INFO] [stdout] | [INFO] [stdout] 269 | let frameptr = cortex.registers.sp.get_msp(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_frameptr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `current_mode` [INFO] [stdout] --> src/cortex_m33/operation.rs:270:17 [INFO] [stdout] | [INFO] [stdout] 270 | let current_mode = Mode::Thread; [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_current_mode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `frameptr` [INFO] [stdout] --> src/cortex_m33/operation.rs:278:17 [INFO] [stdout] | [INFO] [stdout] 278 | let frameptr = cortex.registers.sp.get_psp(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_frameptr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `current_mode` [INFO] [stdout] --> src/cortex_m33/operation.rs:279:17 [INFO] [stdout] | [INFO] [stdout] 279 | let current_mode = Mode::Thread; [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_current_mode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `force_thread` [INFO] [stdout] --> src/cortex_m33/operation.rs:326:9 [INFO] [stdout] | [INFO] [stdout] 326 | let force_thread = cortex.mode == Mode::Thread && cortex.control.npriv == NPriv::ThreadModeUnprivileged; [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_force_thread` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pc` [INFO] [stdout] --> src/cortex_m33/operation.rs:336:20 [INFO] [stdout] | [INFO] [stdout] 336 | pub fn bx_write_pc(pc: &mut PcRegister, current_mode: Mode, address: u32) { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_pc` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_lsb` is never used [INFO] [stdout] --> src/cortex_m33/operation.rs:201:8 [INFO] [stdout] | [INFO] [stdout] 201 | pub fn get_lsb(n: N) -> N { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_msb` is never used [INFO] [stdout] --> src/cortex_m33/operation.rs:209:8 [INFO] [stdout] | [INFO] [stdout] 209 | pub fn get_msb(n: N) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_ones` is never used [INFO] [stdout] --> src/cortex_m33/operation.rs:222:8 [INFO] [stdout] | [INFO] [stdout] 222 | pub fn is_ones>(value: N, range: R) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `exception_active_bit_count` is never used [INFO] [stdout] --> src/cortex_m33/operation.rs:234:8 [INFO] [stdout] | [INFO] [stdout] 234 | pub fn exception_active_bit_count(exceptions: &Exceptions) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `exception_return` is never used [INFO] [stdout] --> src/cortex_m33/operation.rs:238:8 [INFO] [stdout] | [INFO] [stdout] 238 | pub fn exception_return(cortex: &mut CortexM33, ipsr: u8, current_mode: Mode, exc_return: u32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `deactivate` is never used [INFO] [stdout] --> src/cortex_m33/operation.rs:288:8 [INFO] [stdout] | [INFO] [stdout] 288 | pub fn deactivate(cortex: &mut CortexM33, returning_exception_number: u8) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `popstack` is never used [INFO] [stdout] --> src/cortex_m33/operation.rs:292:8 [INFO] [stdout] | [INFO] [stdout] 292 | pub fn popstack(cortex: &mut CortexM33, frameptr: u32, exc_return: u32) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `branch_to` is never used [INFO] [stdout] --> src/cortex_m33/operation.rs:332:8 [INFO] [stdout] | [INFO] [stdout] 332 | pub fn branch_to(cortex: &mut CortexM33, address: u32) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `bx_write_pc` is never used [INFO] [stdout] --> src/cortex_m33/operation.rs:336:8 [INFO] [stdout] | [INFO] [stdout] 336 | pub fn bx_write_pc(pc: &mut PcRegister, current_mode: Mode, address: u32) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Lsr` is never constructed [INFO] [stdout] --> src/cortex_m33/operation.rs:414:5 [INFO] [stdout] | [INFO] [stdout] 412 | pub enum SRType { [INFO] [stdout] | ------ variant in this enum [INFO] [stdout] 413 | Lsl, [INFO] [stdout] 414 | Lsr, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SRType` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `into_*` usually take `self` by value [INFO] [stdout] --> src/cortex_m33/apsr.rs:21:21 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn into_u32(&self) -> u32 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `into_*` usually take `self` by value [INFO] [stdout] --> src/cortex_m33/apsr.rs:70:21 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn into_u32(&self) -> u32 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `into_*` usually take `self` by value [INFO] [stdout] --> src/cortex_m33/apsr.rs:92:21 [INFO] [stdout] | [INFO] [stdout] 92 | pub fn into_u32(&self) -> u32 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `into_*` usually take `self` by value [INFO] [stdout] --> src/cortex_m33/apsr.rs:219:21 [INFO] [stdout] | [INFO] [stdout] 219 | pub fn into_u32(&self) -> u32 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Exceptions` [INFO] [stdout] --> src/cortex_m33/exception.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | / pub fn new() -> Self { [INFO] [stdout] 44 | | Self { [INFO] [stdout] 45 | | active: HashMap::new(), [INFO] [stdout] 46 | | } [INFO] [stdout] 47 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 42 + impl Default for Exceptions { [INFO] [stdout] 43 + fn default() -> Self { [INFO] [stdout] 44 + Self::new() [INFO] [stdout] 45 + } [INFO] [stdout] 46 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cortex_m33/exception.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 50 | assert!(n >= 1 && n <= 48); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `(1..=48).contains(&n)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/cortex_m33/exception.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 69 | let bits = get_bits(cortex.nvic[r], (v + 6)..=(v + 7)) as i8; [INFO] [stdout] | ------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 70 | [INFO] [stdout] 71 | bits [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 69 ~ [INFO] [stdout] 70 | [INFO] [stdout] 71 ~ get_bits(cortex.nvic[r], (v + 6)..=(v + 7)) as i8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cortex_m33/exception.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 76 | assert!(-3 <= result && result <= 4); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(-3..=4).contains(&result)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cortex_m33/instructions.rs:649:20 [INFO] [stdout] | [INFO] [stdout] 649 | if !(registers & (1 << rn) > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(registers & (1 << rn) <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cortex_m33/instructions.rs:815:20 [INFO] [stdout] | [INFO] [stdout] 815 | if !(registers & (1 << rn) > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(registers & (1 << rn) <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Nvic` [INFO] [stdout] --> src/cortex_m33/nvic.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | / pub fn new() -> Self { [INFO] [stdout] 16 | | Self { [INFO] [stdout] 17 | | ipr0: 0, [INFO] [stdout] 18 | | ipr1: 0, [INFO] [stdout] ... | [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 14 + impl Default for Nvic { [INFO] [stdout] 15 + fn default() -> Self { [INFO] [stdout] 16 + Self::new() [INFO] [stdout] 17 + } [INFO] [stdout] 18 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | return binary; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return binary; [INFO] [stdout] 31 + binary [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cortex_m33/opcodes.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | binary = binary | (1 << number); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `binary |= (1 << number)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | return (0b1011010 << 9) | ((push_to_lr as u16) << 8) | registers.binary(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return (0b1011010 << 9) | ((push_to_lr as u16) << 8) | registers.binary(); [INFO] [stdout] 38 + (0b1011010 << 9) | ((push_to_lr as u16) << 8) | registers.binary() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | return (0b0100000101 << 6) | ((rm.number() & 7) << 3) | (rdn.number() & 7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return (0b0100000101 << 6) | ((rm.number() & 7) << 3) | (rdn.number() & 7); [INFO] [stdout] 45 + (0b0100000101 << 6) | ((rm.number() & 7) << 3) | (rdn.number() & 7) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | return (0b101100000 << 7) | ((imm >> 2) & 0x7f); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return (0b101100000 << 7) | ((imm >> 2) & 0x7f); [INFO] [stdout] 52 + (0b101100000 << 7) | ((imm >> 2) & 0x7f) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | return (0b10101 << 11) | ((rd.number() & 7) << 8) | ((imm8 >> 2) & 0xff); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 - return (0b10101 << 11) | ((rd.number() & 7) << 8) | ((imm8 >> 2) & 0xff); [INFO] [stdout] 60 + (0b10101 << 11) | ((rd.number() & 7) << 8) | ((imm8 >> 2) & 0xff) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | / return (0b0001110 << 9) [INFO] [stdout] 68 | | | ((imm3 & 0x7) << 6) [INFO] [stdout] 69 | | | ((rn.number() & 7) << 3) [INFO] [stdout] 70 | | | (rd.number() & 7); [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 ~ (0b0001110 << 9) [INFO] [stdout] 68 + | ((imm3 & 0x7) << 6) [INFO] [stdout] 69 + | ((rn.number() & 7) << 3) [INFO] [stdout] 70 ~ | (rd.number() & 7) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | return (0b00110 << 11) | ((rdn.number() & 7) << 8) | (imm8 & 0xff); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return (0b00110 << 11) | ((rdn.number() & 7) << 8) | (imm8 & 0xff); [INFO] [stdout] 77 + (0b00110 << 11) | ((rdn.number() & 7) << 8) | (imm8 & 0xff) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | / return (0b0001100 << 9) [INFO] [stdout] 85 | | | ((rm.number() & 0x7) << 6) [INFO] [stdout] 86 | | | ((rn.number() & 7) << 3) [INFO] [stdout] 87 | | | (rd.number() & 7); [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 ~ (0b0001100 << 9) [INFO] [stdout] 85 + | ((rm.number() & 0x7) << 6) [INFO] [stdout] 86 + | ((rn.number() & 7) << 3) [INFO] [stdout] 87 ~ | (rd.number() & 7) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 94 | / return (0b01000100 << 8) [INFO] [stdout] 95 | | | ((rdn.number() & 0x8) << 4) [INFO] [stdout] 96 | | | ((rm.number() & 0xf) << 3) [INFO] [stdout] 97 | | | (rdn.number() & 0x7); [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 94 ~ (0b01000100 << 8) [INFO] [stdout] 95 + | ((rdn.number() & 0x8) << 4) [INFO] [stdout] 96 + | ((rm.number() & 0xf) << 3) [INFO] [stdout] 97 ~ | (rdn.number() & 0x7) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | return (0b10100 << 11) | ((rd.number() & 7) << 8) | ((imm8 >> 2) & 0xff); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 104 - return (0b10100 << 11) | ((rd.number() & 7) << 8) | ((imm8 >> 2) & 0xff); [INFO] [stdout] 104 + (0b10100 << 11) | ((rd.number() & 7) << 8) | ((imm8 >> 2) & 0xff) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:111:9 [INFO] [stdout] | [INFO] [stdout] 111 | return (0b0100000000 << 6) | ((rm.number() & 7) << 3) | (rn.number() & 0x7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 111 - return (0b0100000000 << 6) | ((rm.number() & 7) << 3) | (rn.number() & 0x7); [INFO] [stdout] 111 + (0b0100000000 << 6) | ((rm.number() & 7) << 3) | (rn.number() & 0x7) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | return (0b11100 << 11) | ((imm11 >> 1) & 0x7ff); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 - return (0b11100 << 11) | ((imm11 >> 1) & 0x7ff); [INFO] [stdout] 118 + (0b11100 << 11) | ((imm11 >> 1) & 0x7ff) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | return (0b1101 << 12) | ((cond & 0xf) << 8) | ((imm8 >> 1) & 0x1ff); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 125 - return (0b1101 << 12) | ((cond & 0xf) << 8) | ((imm8 >> 1) & 0x1ff); [INFO] [stdout] 125 + (0b1101 << 12) | ((cond & 0xf) << 8) | ((imm8 >> 1) & 0x1ff) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | return 0x8f50f3bf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 132 - return 0x8f50f3bf; [INFO] [stdout] 132 + 0x8f50f3bf [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | return 0x8f4ff3bf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 - return 0x8f4ff3bf; [INFO] [stdout] 139 + 0x8f4ff3bf [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | return 0x8f6ff3bf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 146 - return 0x8f6ff3bf; [INFO] [stdout] 146 + 0x8f6ff3bf [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 155 | return (0b01000110 << 8) | (bit << 7) | (rm.number() << 3) | (rd.number() & 0x7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 155 - return (0b01000110 << 8) | (bit << 7) | (rm.number() << 3) | (rd.number() & 0x7); [INFO] [stdout] 155 + (0b01000110 << 8) | (bit << 7) | (rm.number() << 3) | (rd.number() & 0x7) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 162 | return (0b11001 << 11) | ((rn.number() & 0x7) << 8) | (registers.binary() & 0xff); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 162 - return (0b11001 << 11) | ((rn.number() & 0x7) << 8) | (registers.binary() & 0xff); [INFO] [stdout] 162 + (0b11001 << 11) | ((rn.number() & 0x7) << 8) | (registers.binary() & 0xff) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | return (0b1011101000 << 6) | ((rn.number() & 0x7) << 3) | (rd.number() & 0x7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 169 - return (0b1011101000 << 6) | ((rn.number() & 0x7) << 3) | (rd.number() & 0x7); [INFO] [stdout] 169 + (0b1011101000 << 6) | ((rn.number() & 0x7) << 3) | (rd.number() & 0x7) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 176 | return (0b1011101001 << 6) | ((rn.number() & 0x7) << 3) | (rd.number() & 0x7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 176 - return (0b1011101001 << 6) | ((rn.number() & 0x7) << 3) | (rd.number() & 0x7); [INFO] [stdout] 176 + (0b1011101001 << 6) | ((rn.number() & 0x7) << 3) | (rd.number() & 0x7) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:183:9 [INFO] [stdout] | [INFO] [stdout] 183 | return (0b11000 << 11) | ((rn.number() & 0x7) << 8) | (registers.binary() & 0xff); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 183 - return (0b11000 << 11) | ((rn.number() & 0x7) << 8) | (registers.binary() & 0xff); [INFO] [stdout] 183 + (0b11000 << 11) | ((rn.number() & 0x7) << 8) | (registers.binary() & 0xff) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 190 | return (0b101100001 << 7) | ((imm >> 2) & 0x7f); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 190 - return (0b101100001 << 7) | ((imm >> 2) & 0x7f); [INFO] [stdout] 190 + (0b101100001 << 7) | ((imm >> 2) & 0x7f) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:197:9 [INFO] [stdout] | [INFO] [stdout] 197 | return (0b1011001011 << 6) | ((rm.number() & 7) << 3) | (rd.number() & 7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 197 - return (0b1011001011 << 6) | ((rm.number() & 7) << 3) | (rd.number() & 7); [INFO] [stdout] 197 + (0b1011001011 << 6) | ((rm.number() & 7) << 3) | (rd.number() & 7) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | return (0b1011001010 << 6) | ((rm.number() & 7) << 3) | (rd.number() & 7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 204 - return (0b1011001010 << 6) | ((rm.number() & 7) << 3) | (rd.number() & 7); [INFO] [stdout] 204 + (0b1011001010 << 6) | ((rm.number() & 7) << 3) | (rd.number() & 7) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 211 | return 0b1011111100010000; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 211 - return 0b1011111100010000; [INFO] [stdout] 211 + 0b1011111100010000 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `frameptr` [INFO] [stdout] --> src/cortex_m33/operation.rs:260:17 [INFO] [stdout] | [INFO] [stdout] 260 | let frameptr = cortex.registers.sp.get_msp(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_frameptr` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `current_mode` [INFO] [stdout] --> src/cortex_m33/operation.rs:261:17 [INFO] [stdout] | [INFO] [stdout] 261 | let current_mode = Mode::Handler; [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_current_mode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:230:9 [INFO] [stdout] | [INFO] [stdout] 230 | return opcode as u32 >> 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 230 - return opcode as u32 >> 0; [INFO] [stdout] 230 + opcode as u32 >> 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `frameptr` [INFO] [stdout] --> src/cortex_m33/operation.rs:269:17 [INFO] [stdout] | [INFO] [stdout] 269 | let frameptr = cortex.registers.sp.get_msp(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_frameptr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `current_mode` [INFO] [stdout] --> src/cortex_m33/operation.rs:270:17 [INFO] [stdout] | [INFO] [stdout] 270 | let current_mode = Mode::Thread; [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_current_mode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `frameptr` [INFO] [stdout] --> src/cortex_m33/operation.rs:278:17 [INFO] [stdout] | [INFO] [stdout] 278 | let frameptr = cortex.registers.sp.get_psp(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_frameptr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `current_mode` [INFO] [stdout] --> src/cortex_m33/operation.rs:279:17 [INFO] [stdout] | [INFO] [stdout] 279 | let current_mode = Mode::Thread; [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_current_mode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/cortex_m33/opcodes.rs:230:16 [INFO] [stdout] | [INFO] [stdout] 230 | return opcode as u32 >> 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(opcode as u32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:237:9 [INFO] [stdout] | [INFO] [stdout] 237 | return (0b010001111 << 7) | (rm.number() << 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 237 - return (0b010001111 << 7) | (rm.number() << 3); [INFO] [stdout] 237 + (0b010001111 << 7) | (rm.number() << 3) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:244:9 [INFO] [stdout] | [INFO] [stdout] 244 | / return (0b00010 << 11) [INFO] [stdout] 245 | | | ((imm5 & 0x1f) << 6) [INFO] [stdout] 246 | | | ((rm.number() & 0x7) << 3) [INFO] [stdout] 247 | | | (rd.number() & 0x7); [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 244 ~ (0b00010 << 11) [INFO] [stdout] 245 + | ((imm5 & 0x1f) << 6) [INFO] [stdout] 246 + | ((rm.number() & 0x7) << 3) [INFO] [stdout] 247 ~ | (rd.number() & 0x7) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `force_thread` [INFO] [stdout] --> src/cortex_m33/operation.rs:326:9 [INFO] [stdout] | [INFO] [stdout] 326 | let force_thread = cortex.mode == Mode::Thread && cortex.control.npriv == NPriv::ThreadModeUnprivileged; [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_force_thread` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:254:9 [INFO] [stdout] | [INFO] [stdout] 254 | / return (0b0100000100 << 6) [INFO] [stdout] 255 | | | ((rm.number() & 0x7) << 3) [INFO] [stdout] 256 | | | ((rm.number() & 0x7) << 3) [INFO] [stdout] 257 | | | (rdn.number() & 0x7); [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 254 ~ (0b0100000100 << 6) [INFO] [stdout] 255 + | ((rm.number() & 0x7) << 3) [INFO] [stdout] 256 + | ((rm.number() & 0x7) << 3) [INFO] [stdout] 257 ~ | (rdn.number() & 0x7) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pc` [INFO] [stdout] --> src/cortex_m33/operation.rs:336:20 [INFO] [stdout] | [INFO] [stdout] 336 | pub fn bx_write_pc(pc: &mut PcRegister, current_mode: Mode, address: u32) { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_pc` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant redefinition of a binding `range` [INFO] [stdout] --> src/cortex_m33/operation.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | let range = range; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: `range` is initially defined here [INFO] [stdout] --> src/cortex_m33/operation.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | range: Range, [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals [INFO] [stdout] = note: `#[warn(clippy::redundant_locals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `usize` [INFO] [stdout] --> src/cortex_m33/operation.rs:89:28 [INFO] [stdout] | [INFO] [stdout] 89 | let mask = V::one() << bit.into(); [INFO] [stdout] | ^^^^^^^^^^ help: consider removing `.into()`: `bit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/cortex_m33/operation.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | / if (mask & value) > V::zero() { [INFO] [stdout] 91 | | true [INFO] [stdout] 92 | | } else { [INFO] [stdout] 93 | | false [INFO] [stdout] 94 | | } [INFO] [stdout] | |_____^ help: you can reduce it to: `(mask & value) > V::zero()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/operation.rs:129:5 [INFO] [stdout] | [INFO] [stdout] 129 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 129 - return false; [INFO] [stdout] 129 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/cortex_m33/operation.rs:140:13 [INFO] [stdout] | [INFO] [stdout] 140 | apsr.z() == true [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `apsr.z()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/cortex_m33/operation.rs:144:13 [INFO] [stdout] | [INFO] [stdout] 144 | apsr.c() == true [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `apsr.c()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/cortex_m33/operation.rs:148:13 [INFO] [stdout] | [INFO] [stdout] 148 | apsr.n() == true [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `apsr.n()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/cortex_m33/operation.rs:152:13 [INFO] [stdout] | [INFO] [stdout] 152 | apsr.v() == true [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `apsr.v()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/cortex_m33/operation.rs:156:13 [INFO] [stdout] | [INFO] [stdout] 156 | apsr.c() == true && apsr.z() == false [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `apsr.c()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/cortex_m33/operation.rs:156:33 [INFO] [stdout] | [INFO] [stdout] 156 | apsr.c() == true && apsr.z() == false [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `!apsr.z()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/cortex_m33/operation.rs:164:37 [INFO] [stdout] | [INFO] [stdout] 164 | apsr.n() == apsr.v() && apsr.z() == false [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `!apsr.z()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/cortex_m33/operation.rs:175:8 [INFO] [stdout] | [INFO] [stdout] 175 | if get_bit(cond, 0) == true && cond != 0b1111 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `get_bit(cond, 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/cortex_m33/operation.rs:211:5 [INFO] [stdout] | [INFO] [stdout] 211 | / if (n >> shift) & N::one() == N::zero() { [INFO] [stdout] 212 | | false [INFO] [stdout] 213 | | } else { [INFO] [stdout] 214 | | true [INFO] [stdout] 215 | | } [INFO] [stdout] | |_____^ help: you can reduce it to: `(n >> shift) & N::one() != N::zero()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/cortex_m33/operation.rs:226:12 [INFO] [stdout] | [INFO] [stdout] 226 | if get_bit(value, i) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!get_bit(value, i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/cortex_m33/operation.rs:302:8 [INFO] [stdout] | [INFO] [stdout] 302 | if get_bit(psr, 0) == true { unpredictable!() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `get_bit(psr, 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_lsb` is never used [INFO] [stdout] --> src/cortex_m33/operation.rs:201:8 [INFO] [stdout] | [INFO] [stdout] 201 | pub fn get_lsb(n: N) -> N { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_msb` is never used [INFO] [stdout] --> src/cortex_m33/operation.rs:209:8 [INFO] [stdout] | [INFO] [stdout] 209 | pub fn get_msb(n: N) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_ones` is never used [INFO] [stdout] --> src/cortex_m33/operation.rs:222:8 [INFO] [stdout] | [INFO] [stdout] 222 | pub fn is_ones>(value: N, range: R) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `exception_active_bit_count` is never used [INFO] [stdout] --> src/cortex_m33/operation.rs:234:8 [INFO] [stdout] | [INFO] [stdout] 234 | pub fn exception_active_bit_count(exceptions: &Exceptions) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `exception_return` is never used [INFO] [stdout] --> src/cortex_m33/operation.rs:238:8 [INFO] [stdout] | [INFO] [stdout] 238 | pub fn exception_return(cortex: &mut CortexM33, ipsr: u8, current_mode: Mode, exc_return: u32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `deactivate` is never used [INFO] [stdout] --> src/cortex_m33/operation.rs:288:8 [INFO] [stdout] | [INFO] [stdout] 288 | pub fn deactivate(cortex: &mut CortexM33, returning_exception_number: u8) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `popstack` is never used [INFO] [stdout] --> src/cortex_m33/operation.rs:292:8 [INFO] [stdout] | [INFO] [stdout] 292 | pub fn popstack(cortex: &mut CortexM33, frameptr: u32, exc_return: u32) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `branch_to` is never used [INFO] [stdout] --> src/cortex_m33/operation.rs:332:8 [INFO] [stdout] | [INFO] [stdout] 332 | pub fn branch_to(cortex: &mut CortexM33, address: u32) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `bx_write_pc` is never used [INFO] [stdout] --> src/cortex_m33/operation.rs:336:8 [INFO] [stdout] | [INFO] [stdout] 336 | pub fn bx_write_pc(pc: &mut PcRegister, current_mode: Mode, address: u32) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Lsr` is never constructed [INFO] [stdout] --> src/cortex_m33/operation.rs:414:5 [INFO] [stdout] | [INFO] [stdout] 412 | pub enum SRType { [INFO] [stdout] | ------ variant in this enum [INFO] [stdout] 413 | Lsl, [INFO] [stdout] 414 | Lsr, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SRType` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `into_*` usually take `self` by value [INFO] [stdout] --> src/cortex_m33/apsr.rs:21:21 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn into_u32(&self) -> u32 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CortexM33Registers` [INFO] [stdout] --> src/cortex_m33/registers.rs:205:5 [INFO] [stdout] | [INFO] [stdout] 205 | / pub fn new() -> Self { [INFO] [stdout] 206 | | Self { [INFO] [stdout] 207 | | r0: GeneralRegister(0, 0), [INFO] [stdout] 208 | | r1: GeneralRegister(1, 0), [INFO] [stdout] ... | [INFO] [stdout] 224 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 204 + impl Default for CortexM33Registers { [INFO] [stdout] 205 + fn default() -> Self { [INFO] [stdout] 206 + Self::new() [INFO] [stdout] 207 + } [INFO] [stdout] 208 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `into_*` usually take `self` by value [INFO] [stdout] --> src/cortex_m33/apsr.rs:70:21 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn into_u32(&self) -> u32 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `into_*` usually take `self` by value [INFO] [stdout] --> src/cortex_m33/apsr.rs:92:21 [INFO] [stdout] | [INFO] [stdout] 92 | pub fn into_u32(&self) -> u32 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `into_*` usually take `self` by value [INFO] [stdout] --> src/cortex_m33/apsr.rs:219:21 [INFO] [stdout] | [INFO] [stdout] 219 | pub fn into_u32(&self) -> u32 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `RP2350Memory` [INFO] [stdout] --> src/rp2350.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | / pub fn new() -> Self { [INFO] [stdout] 41 | | Self { [INFO] [stdout] 42 | | sram: [0; KB_OF_RAM * 1024], [INFO] [stdout] ... | [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 39 + impl Default for RP2350Memory { [INFO] [stdout] 40 + fn default() -> Self { [INFO] [stdout] 41 + Self::new() [INFO] [stdout] 42 + } [INFO] [stdout] 43 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Exceptions` [INFO] [stdout] --> src/cortex_m33/exception.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | / pub fn new() -> Self { [INFO] [stdout] 44 | | Self { [INFO] [stdout] 45 | | active: HashMap::new(), [INFO] [stdout] 46 | | } [INFO] [stdout] 47 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 42 + impl Default for Exceptions { [INFO] [stdout] 43 + fn default() -> Self { [INFO] [stdout] 44 + Self::new() [INFO] [stdout] 45 + } [INFO] [stdout] 46 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/rp2350.rs:56:6 [INFO] [stdout] | [INFO] [stdout] 56 | impl<'a> MemoryInterface for RP2350Memory { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cortex_m33/exception.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 50 | assert!(n >= 1 && n <= 48); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `(1..=48).contains(&n)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/rp2350.rs:80:46 [INFO] [stdout] | [INFO] [stdout] 80 | self.sram[address as usize - 0x20000000 as usize] = value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `0x20000000_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/cortex_m33/exception.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 69 | let bits = get_bits(cortex.nvic[r], (v + 6)..=(v + 7)) as i8; [INFO] [stdout] | ------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 70 | [INFO] [stdout] 71 | bits [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 69 ~ [INFO] [stdout] 70 | [INFO] [stdout] 71 ~ get_bits(cortex.nvic[r], (v + 6)..=(v + 7)) as i8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `RP2350` [INFO] [stdout] --> src/rp2350.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 95 | / pub fn new() -> Self { [INFO] [stdout] 96 | | let memory = RP2350Memory::new(); [INFO] [stdout] 97 | | let cortex = CortexM33::new(Box::new(memory)); [INFO] [stdout] 98 | | RP2350 { [INFO] [stdout] ... | [INFO] [stdout] 101 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 94 + impl Default for RP2350 { [INFO] [stdout] 95 + fn default() -> Self { [INFO] [stdout] 96 + Self::new() [INFO] [stdout] 97 + } [INFO] [stdout] 98 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cortex_m33/exception.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 76 | assert!(-3 <= result && result <= 4); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(-3..=4).contains(&result)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cortex_m33/instructions.rs:649:20 [INFO] [stdout] | [INFO] [stdout] 649 | if !(registers & (1 << rn) > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(registers & (1 << rn) <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cortex_m33/instructions.rs:815:20 [INFO] [stdout] | [INFO] [stdout] 815 | if !(registers & (1 << rn) > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(registers & (1 << rn) <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Nvic` [INFO] [stdout] --> src/cortex_m33/nvic.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | / pub fn new() -> Self { [INFO] [stdout] 16 | | Self { [INFO] [stdout] 17 | | ipr0: 0, [INFO] [stdout] 18 | | ipr1: 0, [INFO] [stdout] ... | [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 14 + impl Default for Nvic { [INFO] [stdout] 15 + fn default() -> Self { [INFO] [stdout] 16 + Self::new() [INFO] [stdout] 17 + } [INFO] [stdout] 18 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | return binary; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return binary; [INFO] [stdout] 31 + binary [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cortex_m33/opcodes.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | binary = binary | (1 << number); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `binary |= (1 << number)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | return (0b1011010 << 9) | ((push_to_lr as u16) << 8) | registers.binary(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return (0b1011010 << 9) | ((push_to_lr as u16) << 8) | registers.binary(); [INFO] [stdout] 38 + (0b1011010 << 9) | ((push_to_lr as u16) << 8) | registers.binary() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | return (0b0100000101 << 6) | ((rm.number() & 7) << 3) | (rdn.number() & 7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return (0b0100000101 << 6) | ((rm.number() & 7) << 3) | (rdn.number() & 7); [INFO] [stdout] 45 + (0b0100000101 << 6) | ((rm.number() & 7) << 3) | (rdn.number() & 7) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | return (0b101100000 << 7) | ((imm >> 2) & 0x7f); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return (0b101100000 << 7) | ((imm >> 2) & 0x7f); [INFO] [stdout] 52 + (0b101100000 << 7) | ((imm >> 2) & 0x7f) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | return (0b10101 << 11) | ((rd.number() & 7) << 8) | ((imm8 >> 2) & 0xff); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 - return (0b10101 << 11) | ((rd.number() & 7) << 8) | ((imm8 >> 2) & 0xff); [INFO] [stdout] 60 + (0b10101 << 11) | ((rd.number() & 7) << 8) | ((imm8 >> 2) & 0xff) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | / return (0b0001110 << 9) [INFO] [stdout] 68 | | | ((imm3 & 0x7) << 6) [INFO] [stdout] 69 | | | ((rn.number() & 7) << 3) [INFO] [stdout] 70 | | | (rd.number() & 7); [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 ~ (0b0001110 << 9) [INFO] [stdout] 68 + | ((imm3 & 0x7) << 6) [INFO] [stdout] 69 + | ((rn.number() & 7) << 3) [INFO] [stdout] 70 ~ | (rd.number() & 7) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | return (0b00110 << 11) | ((rdn.number() & 7) << 8) | (imm8 & 0xff); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return (0b00110 << 11) | ((rdn.number() & 7) << 8) | (imm8 & 0xff); [INFO] [stdout] 77 + (0b00110 << 11) | ((rdn.number() & 7) << 8) | (imm8 & 0xff) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | / return (0b0001100 << 9) [INFO] [stdout] 85 | | | ((rm.number() & 0x7) << 6) [INFO] [stdout] 86 | | | ((rn.number() & 7) << 3) [INFO] [stdout] 87 | | | (rd.number() & 7); [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 ~ (0b0001100 << 9) [INFO] [stdout] 85 + | ((rm.number() & 0x7) << 6) [INFO] [stdout] 86 + | ((rn.number() & 7) << 3) [INFO] [stdout] 87 ~ | (rd.number() & 7) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 94 | / return (0b01000100 << 8) [INFO] [stdout] 95 | | | ((rdn.number() & 0x8) << 4) [INFO] [stdout] 96 | | | ((rm.number() & 0xf) << 3) [INFO] [stdout] 97 | | | (rdn.number() & 0x7); [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 94 ~ (0b01000100 << 8) [INFO] [stdout] 95 + | ((rdn.number() & 0x8) << 4) [INFO] [stdout] 96 + | ((rm.number() & 0xf) << 3) [INFO] [stdout] 97 ~ | (rdn.number() & 0x7) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | return (0b10100 << 11) | ((rd.number() & 7) << 8) | ((imm8 >> 2) & 0xff); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 104 - return (0b10100 << 11) | ((rd.number() & 7) << 8) | ((imm8 >> 2) & 0xff); [INFO] [stdout] 104 + (0b10100 << 11) | ((rd.number() & 7) << 8) | ((imm8 >> 2) & 0xff) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:111:9 [INFO] [stdout] | [INFO] [stdout] 111 | return (0b0100000000 << 6) | ((rm.number() & 7) << 3) | (rn.number() & 0x7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 111 - return (0b0100000000 << 6) | ((rm.number() & 7) << 3) | (rn.number() & 0x7); [INFO] [stdout] 111 + (0b0100000000 << 6) | ((rm.number() & 7) << 3) | (rn.number() & 0x7) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | return (0b11100 << 11) | ((imm11 >> 1) & 0x7ff); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 - return (0b11100 << 11) | ((imm11 >> 1) & 0x7ff); [INFO] [stdout] 118 + (0b11100 << 11) | ((imm11 >> 1) & 0x7ff) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | return (0b1101 << 12) | ((cond & 0xf) << 8) | ((imm8 >> 1) & 0x1ff); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 125 - return (0b1101 << 12) | ((cond & 0xf) << 8) | ((imm8 >> 1) & 0x1ff); [INFO] [stdout] 125 + (0b1101 << 12) | ((cond & 0xf) << 8) | ((imm8 >> 1) & 0x1ff) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | return 0x8f50f3bf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 132 - return 0x8f50f3bf; [INFO] [stdout] 132 + 0x8f50f3bf [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | return 0x8f4ff3bf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 - return 0x8f4ff3bf; [INFO] [stdout] 139 + 0x8f4ff3bf [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | return 0x8f6ff3bf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 146 - return 0x8f6ff3bf; [INFO] [stdout] 146 + 0x8f6ff3bf [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 155 | return (0b01000110 << 8) | (bit << 7) | (rm.number() << 3) | (rd.number() & 0x7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 155 - return (0b01000110 << 8) | (bit << 7) | (rm.number() << 3) | (rd.number() & 0x7); [INFO] [stdout] 155 + (0b01000110 << 8) | (bit << 7) | (rm.number() << 3) | (rd.number() & 0x7) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 162 | return (0b11001 << 11) | ((rn.number() & 0x7) << 8) | (registers.binary() & 0xff); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 162 - return (0b11001 << 11) | ((rn.number() & 0x7) << 8) | (registers.binary() & 0xff); [INFO] [stdout] 162 + (0b11001 << 11) | ((rn.number() & 0x7) << 8) | (registers.binary() & 0xff) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | return (0b1011101000 << 6) | ((rn.number() & 0x7) << 3) | (rd.number() & 0x7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 169 - return (0b1011101000 << 6) | ((rn.number() & 0x7) << 3) | (rd.number() & 0x7); [INFO] [stdout] 169 + (0b1011101000 << 6) | ((rn.number() & 0x7) << 3) | (rd.number() & 0x7) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 176 | return (0b1011101001 << 6) | ((rn.number() & 0x7) << 3) | (rd.number() & 0x7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 176 - return (0b1011101001 << 6) | ((rn.number() & 0x7) << 3) | (rd.number() & 0x7); [INFO] [stdout] 176 + (0b1011101001 << 6) | ((rn.number() & 0x7) << 3) | (rd.number() & 0x7) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:183:9 [INFO] [stdout] | [INFO] [stdout] 183 | return (0b11000 << 11) | ((rn.number() & 0x7) << 8) | (registers.binary() & 0xff); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 183 - return (0b11000 << 11) | ((rn.number() & 0x7) << 8) | (registers.binary() & 0xff); [INFO] [stdout] 183 + (0b11000 << 11) | ((rn.number() & 0x7) << 8) | (registers.binary() & 0xff) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 190 | return (0b101100001 << 7) | ((imm >> 2) & 0x7f); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 190 - return (0b101100001 << 7) | ((imm >> 2) & 0x7f); [INFO] [stdout] 190 + (0b101100001 << 7) | ((imm >> 2) & 0x7f) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:197:9 [INFO] [stdout] | [INFO] [stdout] 197 | return (0b1011001011 << 6) | ((rm.number() & 7) << 3) | (rd.number() & 7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 197 - return (0b1011001011 << 6) | ((rm.number() & 7) << 3) | (rd.number() & 7); [INFO] [stdout] 197 + (0b1011001011 << 6) | ((rm.number() & 7) << 3) | (rd.number() & 7) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | return (0b1011001010 << 6) | ((rm.number() & 7) << 3) | (rd.number() & 7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 204 - return (0b1011001010 << 6) | ((rm.number() & 7) << 3) | (rd.number() & 7); [INFO] [stdout] 204 + (0b1011001010 << 6) | ((rm.number() & 7) << 3) | (rd.number() & 7) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 211 | return 0b1011111100010000; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 211 - return 0b1011111100010000; [INFO] [stdout] 211 + 0b1011111100010000 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:230:9 [INFO] [stdout] | [INFO] [stdout] 230 | return opcode as u32 >> 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 230 - return opcode as u32 >> 0; [INFO] [stdout] 230 + opcode as u32 >> 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/cortex_m33/opcodes.rs:230:16 [INFO] [stdout] | [INFO] [stdout] 230 | return opcode as u32 >> 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(opcode as u32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:237:9 [INFO] [stdout] | [INFO] [stdout] 237 | return (0b010001111 << 7) | (rm.number() << 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 237 - return (0b010001111 << 7) | (rm.number() << 3); [INFO] [stdout] 237 + (0b010001111 << 7) | (rm.number() << 3) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:244:9 [INFO] [stdout] | [INFO] [stdout] 244 | / return (0b00010 << 11) [INFO] [stdout] 245 | | | ((imm5 & 0x1f) << 6) [INFO] [stdout] 246 | | | ((rm.number() & 0x7) << 3) [INFO] [stdout] 247 | | | (rd.number() & 0x7); [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 244 ~ (0b00010 << 11) [INFO] [stdout] 245 + | ((imm5 & 0x1f) << 6) [INFO] [stdout] 246 + | ((rm.number() & 0x7) << 3) [INFO] [stdout] 247 ~ | (rd.number() & 0x7) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/opcodes.rs:254:9 [INFO] [stdout] | [INFO] [stdout] 254 | / return (0b0100000100 << 6) [INFO] [stdout] 255 | | | ((rm.number() & 0x7) << 3) [INFO] [stdout] 256 | | | ((rm.number() & 0x7) << 3) [INFO] [stdout] 257 | | | (rdn.number() & 0x7); [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 254 ~ (0b0100000100 << 6) [INFO] [stdout] 255 + | ((rm.number() & 0x7) << 3) [INFO] [stdout] 256 + | ((rm.number() & 0x7) << 3) [INFO] [stdout] 257 ~ | (rdn.number() & 0x7) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant redefinition of a binding `range` [INFO] [stdout] --> src/cortex_m33/operation.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | let range = range; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: `range` is initially defined here [INFO] [stdout] --> src/cortex_m33/operation.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | range: Range, [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals [INFO] [stdout] = note: `#[warn(clippy::redundant_locals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `usize` [INFO] [stdout] --> src/cortex_m33/operation.rs:89:28 [INFO] [stdout] | [INFO] [stdout] 89 | let mask = V::one() << bit.into(); [INFO] [stdout] | ^^^^^^^^^^ help: consider removing `.into()`: `bit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/cortex_m33/operation.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | / if (mask & value) > V::zero() { [INFO] [stdout] 91 | | true [INFO] [stdout] 92 | | } else { [INFO] [stdout] 93 | | false [INFO] [stdout] 94 | | } [INFO] [stdout] | |_____^ help: you can reduce it to: `(mask & value) > V::zero()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cortex_m33/operation.rs:129:5 [INFO] [stdout] | [INFO] [stdout] 129 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 129 - return false; [INFO] [stdout] 129 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/cortex_m33/operation.rs:140:13 [INFO] [stdout] | [INFO] [stdout] 140 | apsr.z() == true [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `apsr.z()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/cortex_m33/operation.rs:144:13 [INFO] [stdout] | [INFO] [stdout] 144 | apsr.c() == true [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `apsr.c()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/cortex_m33/operation.rs:148:13 [INFO] [stdout] | [INFO] [stdout] 148 | apsr.n() == true [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `apsr.n()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/cortex_m33/operation.rs:152:13 [INFO] [stdout] | [INFO] [stdout] 152 | apsr.v() == true [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `apsr.v()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/cortex_m33/operation.rs:156:13 [INFO] [stdout] | [INFO] [stdout] 156 | apsr.c() == true && apsr.z() == false [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `apsr.c()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/cortex_m33/operation.rs:156:33 [INFO] [stdout] | [INFO] [stdout] 156 | apsr.c() == true && apsr.z() == false [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `!apsr.z()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/cortex_m33/operation.rs:164:37 [INFO] [stdout] | [INFO] [stdout] 164 | apsr.n() == apsr.v() && apsr.z() == false [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `!apsr.z()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/cortex_m33/operation.rs:175:8 [INFO] [stdout] | [INFO] [stdout] 175 | if get_bit(cond, 0) == true && cond != 0b1111 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `get_bit(cond, 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/cortex_m33/operation.rs:211:5 [INFO] [stdout] | [INFO] [stdout] 211 | / if (n >> shift) & N::one() == N::zero() { [INFO] [stdout] 212 | | false [INFO] [stdout] 213 | | } else { [INFO] [stdout] 214 | | true [INFO] [stdout] 215 | | } [INFO] [stdout] | |_____^ help: you can reduce it to: `(n >> shift) & N::one() != N::zero()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/cortex_m33/operation.rs:226:12 [INFO] [stdout] | [INFO] [stdout] 226 | if get_bit(value, i) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!get_bit(value, i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/cortex_m33/operation.rs:302:8 [INFO] [stdout] | [INFO] [stdout] 302 | if get_bit(psr, 0) == true { unpredictable!() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `get_bit(psr, 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CortexM33Registers` [INFO] [stdout] --> src/cortex_m33/registers.rs:205:5 [INFO] [stdout] | [INFO] [stdout] 205 | / pub fn new() -> Self { [INFO] [stdout] 206 | | Self { [INFO] [stdout] 207 | | r0: GeneralRegister(0, 0), [INFO] [stdout] 208 | | r1: GeneralRegister(1, 0), [INFO] [stdout] ... | [INFO] [stdout] 224 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 204 + impl Default for CortexM33Registers { [INFO] [stdout] 205 + fn default() -> Self { [INFO] [stdout] 206 + Self::new() [INFO] [stdout] 207 + } [INFO] [stdout] 208 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `RP2350Memory` [INFO] [stdout] --> src/rp2350.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | / pub fn new() -> Self { [INFO] [stdout] 41 | | Self { [INFO] [stdout] 42 | | sram: [0; KB_OF_RAM * 1024], [INFO] [stdout] ... | [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 39 + impl Default for RP2350Memory { [INFO] [stdout] 40 + fn default() -> Self { [INFO] [stdout] 41 + Self::new() [INFO] [stdout] 42 + } [INFO] [stdout] 43 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/rp2350.rs:56:6 [INFO] [stdout] | [INFO] [stdout] 56 | impl<'a> MemoryInterface for RP2350Memory { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/rp2350.rs:80:46 [INFO] [stdout] | [INFO] [stdout] 80 | self.sram[address as usize - 0x20000000 as usize] = value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `0x20000000_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `RP2350` [INFO] [stdout] --> src/rp2350.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 95 | / pub fn new() -> Self { [INFO] [stdout] 96 | | let memory = RP2350Memory::new(); [INFO] [stdout] 97 | | let cortex = CortexM33::new(Box::new(memory)); [INFO] [stdout] 98 | | RP2350 { [INFO] [stdout] ... | [INFO] [stdout] 101 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 94 + impl Default for RP2350 { [INFO] [stdout] 95 + fn default() -> Self { [INFO] [stdout] 96 + Self::new() [INFO] [stdout] 97 + } [INFO] [stdout] 98 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/adc.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 27 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), false); [INFO] [stdout] 27 + assert!(!rp2350.cortex_m33.xpsr.apsr.n()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/adc.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 28 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), false); [INFO] [stdout] 28 + assert!(!rp2350.cortex_m33.xpsr.apsr.z()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/adc.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 29 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), false); [INFO] [stdout] 29 + assert!(!rp2350.cortex_m33.xpsr.apsr.c()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/adc.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.v(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 30 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.v(), false); [INFO] [stdout] 30 + assert!(!rp2350.cortex_m33.xpsr.apsr.v()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/adc.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 53 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), true); [INFO] [stdout] 53 + assert!(rp2350.cortex_m33.xpsr.apsr.n()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/adc.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 54 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), false); [INFO] [stdout] 54 + assert!(!rp2350.cortex_m33.xpsr.apsr.z()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/adc.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 55 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), false); [INFO] [stdout] 55 + assert!(!rp2350.cortex_m33.xpsr.apsr.c()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/adc.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.v(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 56 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.v(), true); [INFO] [stdout] 56 + assert!(rp2350.cortex_m33.xpsr.apsr.v()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/adc.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 80 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), false); [INFO] [stdout] 80 + assert!(!rp2350.cortex_m33.xpsr.apsr.n()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/adc.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 81 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), false); [INFO] [stdout] 81 + assert!(!rp2350.cortex_m33.xpsr.apsr.z()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/adc.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 82 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), false); [INFO] [stdout] 82 + assert!(!rp2350.cortex_m33.xpsr.apsr.c()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/adc.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.v(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 83 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.v(), false); [INFO] [stdout] 83 + assert!(!rp2350.cortex_m33.xpsr.apsr.v()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/adc.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 105 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), false); [INFO] [stdout] 105 + assert!(!rp2350.cortex_m33.xpsr.apsr.n()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/adc.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 106 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), true); [INFO] [stdout] 106 + assert!(rp2350.cortex_m33.xpsr.apsr.z()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/adc.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 107 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), true); [INFO] [stdout] 107 + assert!(rp2350.cortex_m33.xpsr.apsr.c()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/adc.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.v(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 108 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.v(), true); [INFO] [stdout] 108 + assert!(rp2350.cortex_m33.xpsr.apsr.v()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/add.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 56 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), false); [INFO] [stdout] 56 + assert!(!rp2350.cortex_m33.xpsr.apsr.n()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/add.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 57 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), false); [INFO] [stdout] 57 + assert!(!rp2350.cortex_m33.xpsr.apsr.z()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/add.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 58 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), false); [INFO] [stdout] 58 + assert!(!rp2350.cortex_m33.xpsr.apsr.c()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/add.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.v(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 59 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.v(), false); [INFO] [stdout] 59 + assert!(!rp2350.cortex_m33.xpsr.apsr.v()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/add.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 82 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), false); [INFO] [stdout] 82 + assert!(!rp2350.cortex_m33.xpsr.apsr.n()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/add.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 83 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), true); [INFO] [stdout] 83 + assert!(rp2350.cortex_m33.xpsr.apsr.z()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/add.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 84 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), true); [INFO] [stdout] 84 + assert!(rp2350.cortex_m33.xpsr.apsr.c()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/add.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.v(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 85 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.v(), false); [INFO] [stdout] 85 + assert!(!rp2350.cortex_m33.xpsr.apsr.v()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/add.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 108 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), false); [INFO] [stdout] 108 + assert!(!rp2350.cortex_m33.xpsr.apsr.n()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/add.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 109 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), false); [INFO] [stdout] 109 + assert!(!rp2350.cortex_m33.xpsr.apsr.z()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/add.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 110 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), false); [INFO] [stdout] 110 + assert!(!rp2350.cortex_m33.xpsr.apsr.c()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/add.rs:111:9 [INFO] [stdout] | [INFO] [stdout] 111 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.v(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 111 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.v(), false); [INFO] [stdout] 111 + assert!(!rp2350.cortex_m33.xpsr.apsr.v()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/add.rs:134:9 [INFO] [stdout] | [INFO] [stdout] 134 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 134 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), true); [INFO] [stdout] 134 + assert!(rp2350.cortex_m33.xpsr.apsr.n()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/add.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 135 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), false); [INFO] [stdout] 135 + assert!(!rp2350.cortex_m33.xpsr.apsr.z()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/add.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 136 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 136 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), false); [INFO] [stdout] 136 + assert!(!rp2350.cortex_m33.xpsr.apsr.c()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/add.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 137 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.v(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 137 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.v(), true); [INFO] [stdout] 137 + assert!(rp2350.cortex_m33.xpsr.apsr.v()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/add.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 160 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 160 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), false); [INFO] [stdout] 160 + assert!(!rp2350.cortex_m33.xpsr.apsr.n()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/add.rs:161:9 [INFO] [stdout] | [INFO] [stdout] 161 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 161 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), false); [INFO] [stdout] 161 + assert!(!rp2350.cortex_m33.xpsr.apsr.z()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/add.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 162 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 162 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), true); [INFO] [stdout] 162 + assert!(rp2350.cortex_m33.xpsr.apsr.c()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/add.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.v(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 163 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.v(), true); [INFO] [stdout] 163 + assert!(rp2350.cortex_m33.xpsr.apsr.v()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/and.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 25 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), true); [INFO] [stdout] 25 + assert!(rp2350.cortex_m33.xpsr.apsr.n()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/and.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 26 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), false); [INFO] [stdout] 26 + assert!(!rp2350.cortex_m33.xpsr.apsr.z()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/asr.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 27 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), true); [INFO] [stdout] 27 + assert!(rp2350.cortex_m33.xpsr.apsr.n()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/asr.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 28 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), false); [INFO] [stdout] 28 + assert!(!rp2350.cortex_m33.xpsr.apsr.z()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/asr.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 29 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), false); [INFO] [stdout] 29 + assert!(!rp2350.cortex_m33.xpsr.apsr.c()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/asr.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 52 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), true); [INFO] [stdout] 52 + assert!(rp2350.cortex_m33.xpsr.apsr.n()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/asr.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 53 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), false); [INFO] [stdout] 53 + assert!(!rp2350.cortex_m33.xpsr.apsr.z()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/asr.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 54 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), true); [INFO] [stdout] 54 + assert!(rp2350.cortex_m33.xpsr.apsr.c()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/asr.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 76 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), true); [INFO] [stdout] 76 + assert!(rp2350.cortex_m33.xpsr.apsr.n()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/asr.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 77 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), false); [INFO] [stdout] 77 + assert!(!rp2350.cortex_m33.xpsr.apsr.z()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/asr.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 78 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), true); [INFO] [stdout] 78 + assert!(rp2350.cortex_m33.xpsr.apsr.c()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/asr.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 101 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), false); [INFO] [stdout] 101 + assert!(!rp2350.cortex_m33.xpsr.apsr.n()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/asr.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 102 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), true); [INFO] [stdout] 102 + assert!(rp2350.cortex_m33.xpsr.apsr.z()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/asr.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 103 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), false); [INFO] [stdout] 103 + assert!(!rp2350.cortex_m33.xpsr.apsr.c()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/asr.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 126 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), false); [INFO] [stdout] 126 + assert!(!rp2350.cortex_m33.xpsr.apsr.n()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/asr.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 127 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 127 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), true); [INFO] [stdout] 127 + assert!(rp2350.cortex_m33.xpsr.apsr.z()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/asr.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 128 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 128 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), true); [INFO] [stdout] 128 + assert!(rp2350.cortex_m33.xpsr.apsr.c()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/asr.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 151 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 151 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), true); [INFO] [stdout] 151 + assert!(rp2350.cortex_m33.xpsr.apsr.n()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/asr.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 152 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), false); [INFO] [stdout] 152 + assert!(!rp2350.cortex_m33.xpsr.apsr.z()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/asr.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 153 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 153 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), true); [INFO] [stdout] 153 + assert!(rp2350.cortex_m33.xpsr.apsr.c()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/asr.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 176 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 176 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.n(), true); [INFO] [stdout] 176 + assert!(rp2350.cortex_m33.xpsr.apsr.n()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/asr.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 177 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 177 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.z(), false); [INFO] [stdout] 177 + assert!(!rp2350.cortex_m33.xpsr.apsr.z()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/instructions/asr.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 178 | assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 178 - assert_eq!(rp2350.cortex_m33.xpsr.apsr.c(), true); [INFO] [stdout] 178 + assert!(rp2350.cortex_m33.xpsr.apsr.c()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `rp2350_sim::cortex_m33::opcodes::Registers` [INFO] [stdout] --> tests/instructions/ldmia.rs:17:71 [INFO] [stdout] | [INFO] [stdout] 17 | let opcode = LdmiaT1::opcode(&rp2350.cortex_m33.registers.r0, registers.into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `registers` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> tests/instructions/ldmia.rs:21:56 [INFO] [stdout] | [INFO] [stdout] 21 | rp2350.cortex_m33.memory.write_u32(0x20000010, 0xf00df00d as u32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `0xf00df00d_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u16` is unnecessary [INFO] [stdout] --> tests/instructions/ldmia.rs:22:56 [INFO] [stdout] | [INFO] [stdout] 22 | rp2350.cortex_m33.memory.write_u16(0x20000014, 0x4242 as u16); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `0x4242_u16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `rp2350_sim::cortex_m33::opcodes::Registers` [INFO] [stdout] --> tests/instructions/push.rs:24:43 [INFO] [stdout] | [INFO] [stdout] 24 | let binary = PushT1::opcode(true, registers.into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `registers` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.61s [INFO] running `Command { std: "docker" "inspect" "8d920f64079ad50673fd8195c7d60a0b5451c5f361eb6781c852944782f4f580", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8d920f64079ad50673fd8195c7d60a0b5451c5f361eb6781c852944782f4f580", kill_on_drop: false }` [INFO] [stdout] 8d920f64079ad50673fd8195c7d60a0b5451c5f361eb6781c852944782f4f580