[INFO] cloning repository https://github.com/Bequen/hittamul [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Bequen/hittamul" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBequen%2Fhittamul", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBequen%2Fhittamul'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 16b9775496c6328678486424721ca4e48713ec06 [INFO] linting Bequen/hittamul against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBequen%2Fhittamul" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Bequen/hittamul [INFO] finished tweaking git repo https://github.com/Bequen/hittamul [INFO] tweaked toml for git repo https://github.com/Bequen/hittamul written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Bequen/hittamul on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Bequen/hittamul already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded roxmltree v0.18.1 [INFO] [stderr] Downloaded derive-new v0.7.0 [INFO] [stderr] Downloaded from-pest v0.3.4 [INFO] [stderr] Downloaded pest-ast v0.3.6 [INFO] [stderr] Downloaded syn_derive v0.2.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e312405548a696f1c4b6b1f0637898ad9a4feea9d182aa65350e8e4e041f4937 [INFO] running `Command { std: "docker" "start" "-a" "e312405548a696f1c4b6b1f0637898ad9a4feea9d182aa65350e8e4e041f4937", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e312405548a696f1c4b6b1f0637898ad9a4feea9d182aa65350e8e4e041f4937", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e312405548a696f1c4b6b1f0637898ad9a4feea9d182aa65350e8e4e041f4937", kill_on_drop: false }` [INFO] [stdout] e312405548a696f1c4b6b1f0637898ad9a4feea9d182aa65350e8e4e041f4937 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c50d5a5a26d440040141636c7c70a64f4d5b3024bdcbaa7c6b07a2b8c08a2588 [INFO] running `Command { std: "docker" "start" "-a" "c50d5a5a26d440040141636c7c70a64f4d5b3024bdcbaa7c6b07a2b8c08a2588", kill_on_drop: false }` [INFO] [stderr] Compiling quote v1.0.41 [INFO] [stderr] Compiling memchr v2.7.6 [INFO] [stderr] Checking unicode-ident v1.0.19 [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Checking pest v2.8.3 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking clap_lex v0.7.6 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Checking xmlparser v0.13.6 [INFO] [stderr] Checking clap_builder v4.5.49 [INFO] [stderr] Checking roxmltree v0.18.1 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Compiling proc-macro-error-attr2 v2.0.0 [INFO] [stderr] Checking from-pest v0.3.4 [INFO] [stderr] Compiling proc-macro-error2 v2.0.1 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Compiling pest_meta v2.8.3 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Compiling pest_generator v2.8.3 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling pest_derive v2.8.3 [INFO] [stderr] Compiling pest-ast v0.3.6 [INFO] [stderr] Compiling derive-new v0.7.0 [INFO] [stderr] Compiling syn_derive v0.2.0 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking jsonpath-ast v0.1.0 (/opt/rustwide/workdir/external/jsonpath-rust/jsonpath-ast) [INFO] [stderr] Checking clap v4.5.49 [INFO] [stderr] Checking jsonpath-rust v1.0.4 (/opt/rustwide/workdir/external/jsonpath-rust) [INFO] [stderr] Checking hittamul v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `js_path_process` [INFO] [stdout] --> src/main.rs:2:28 [INFO] [stdout] | [INFO] [stdout] 2 | use jsonpath_rust::query::{js_path_process, Query as JsonQuery}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::data::json_data_source::JsonDataSource` [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use crate::data::json_data_source::JsonDataSource; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `jsonpath_rust::query::queryable::Queryable` [INFO] [stdout] --> src/data/data_source.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use jsonpath_rust::query::queryable::Queryable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Debug` [INFO] [stdout] --> src/data/data_source.rs:4:16 [INFO] [stdout] | [INFO] [stdout] 4 | use std::fmt::{Debug, Display, Error, Formatter}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `jsonpath_rust::query::queryable::Queryable` [INFO] [stdout] --> src/data_context.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use jsonpath_rust::query::queryable::Queryable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:181:16 [INFO] [stdout] | [INFO] [stdout] 181 | Self { data: data, components, output, is_prev_empty: false, depth: 0 } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::data::data_source::DataSource` [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use crate::data::data_source::DataSource; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `jsonpath_rust::JsonPath` [INFO] [stdout] --> src/main.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use jsonpath_rust::JsonPath; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `key` [INFO] [stdout] --> src/data/json_data_source.rs:80:27 [INFO] [stdout] | [INFO] [stdout] 80 | fn iter<'a>(&'a self, key: Option<&str>) -> std::slice::Iter { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_key` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `f` [INFO] [stdout] --> src/data_context.rs:28:19 [INFO] [stdout] | [INFO] [stdout] 28 | fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `js_path_process` [INFO] [stdout] --> src/main.rs:2:28 [INFO] [stdout] | [INFO] [stdout] 2 | use jsonpath_rust::query::{js_path_process, Query as JsonQuery}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::data::json_data_source::JsonDataSource` [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use crate::data::json_data_source::JsonDataSource; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `jsonpath_rust::query::queryable::Queryable` [INFO] [stdout] --> src/data/data_source.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use jsonpath_rust::query::queryable::Queryable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Debug` [INFO] [stdout] --> src/data/data_source.rs:4:16 [INFO] [stdout] | [INFO] [stdout] 4 | use std::fmt::{Debug, Display, Error, Formatter}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | let mut prev_value: Option = None; [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `prev_value` [INFO] [stdout] --> src/main.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | let mut prev_value: Option = None; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_prev_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `jsonpath_rust::query::queryable::Queryable` [INFO] [stdout] --> src/data_context.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use jsonpath_rust::query::queryable::Queryable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:181:16 [INFO] [stdout] | [INFO] [stdout] 181 | Self { data: data, components, output, is_prev_empty: false, depth: 0 } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `LetGuard` is never constructed [INFO] [stdout] --> src/main.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | struct LetGuard<'a> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/main.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 36 | impl DataContext { [INFO] [stdout] | ---------------- associated function in this implementation [INFO] [stdout] 37 | fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Value` is never used [INFO] [stdout] --> src/data/data_source.rs:6:10 [INFO] [stdout] | [INFO] [stdout] 6 | pub enum Value { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `DataSource` is never used [INFO] [stdout] --> src/data/data_source.rs:26:11 [INFO] [stdout] | [INFO] [stdout] 26 | pub trait DataSource { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Bindings` is never constructed [INFO] [stdout] --> src/data/data_source.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 34 | pub struct Bindings { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `JsonDataSource` is never constructed [INFO] [stdout] --> src/data/json_data_source.rs:6:12 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct JsonDataSource { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/data/json_data_source.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 10 | impl JsonDataSource { [INFO] [stdout] | ------------------- associated function in this implementation [INFO] [stdout] 11 | pub fn new(key: Option<&str>, value: serde_json::Value) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `json_number_to_value` is never used [INFO] [stdout] --> src/data/json_data_source.rs:24:4 [INFO] [stdout] | [INFO] [stdout] 24 | fn json_number_to_value(number: &serde_json::Number) -> Value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `json_value_to_value` is never used [INFO] [stdout] --> src/data/json_data_source.rs:36:4 [INFO] [stdout] | [INFO] [stdout] 36 | fn json_value_to_value(value: &serde_json::Value) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `JsonDataSourceIterator` is never constructed [INFO] [stdout] --> src/data/json_data_source.rs:105:8 [INFO] [stdout] | [INFO] [stdout] 105 | struct JsonDataSourceIterator<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DataContext` is never constructed [INFO] [stdout] --> src/data_context.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | struct DataContext { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/data/data_source.rs:17:56 [INFO] [stdout] | [INFO] [stdout] 17 | Value::Bool(value) => write!(f, "{}", value.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/data/data_source.rs:18:55 [INFO] [stdout] | [INFO] [stdout] 18 | Value::Int(value) => write!(f, "{}", value.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/data/data_source.rs:19:56 [INFO] [stdout] | [INFO] [stdout] 19 | Value::Uint(value) => write!(f, "{}", value.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/data/data_source.rs:20:57 [INFO] [stdout] | [INFO] [stdout] 20 | Value::Float(value) => write!(f, "{}", value.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/data/data_source.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 31 | fn iter<'a>(&'a self, key: Option<&str>) -> std::slice::Iter; [INFO] [stdout] | ^^ ^^ ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 31 - fn iter<'a>(&'a self, key: Option<&str>) -> std::slice::Iter; [INFO] [stdout] 31 + fn iter(&self, key: Option<&str>) -> std::slice::Iter; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `key` after checking its variant with `is_some` [INFO] [stdout] --> src/data/json_data_source.rs:14:24 [INFO] [stdout] | [INFO] [stdout] 12 | if key.is_some() { [INFO] [stdout] | ---------------- help: try: `if let Some() = key` [INFO] [stdout] 13 | let mut map = serde_json::Map::new(); [INFO] [stdout] 14 | map.insert(key.unwrap().to_string(), value); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/data/json_data_source.rs:43:17 [INFO] [stdout] | [INFO] [stdout] 43 | return json_value_to_value(&arr[0]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return json_value_to_value(&arr[0]); [INFO] [stdout] 43 + json_value_to_value(&arr[0]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/data/json_data_source.rs:45:17 [INFO] [stdout] | [INFO] [stdout] 45 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return None; [INFO] [stdout] 45 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `bool` which implements the `Copy` trait [INFO] [stdout] --> src/data/json_data_source.rs:38:60 [INFO] [stdout] | [INFO] [stdout] 38 | serde_json::Value::Bool(value) => Some(Value::Bool(value.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/data/json_data_source.rs:39:69 [INFO] [stdout] | [INFO] [stdout] 39 | serde_json::Value::Number(num) => Some(json_number_to_value(&num)), [INFO] [stdout] | ^^^^ help: change this to: `num` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/data/json_data_source.rs:53:14 [INFO] [stdout] | [INFO] [stdout] 53 | fn query<'a>(&'a self, query: &Query) -> Option> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 53 - fn query<'a>(&'a self, query: &Query) -> Option> { [INFO] [stdout] 53 + fn query(&self, query: &Query) -> Option> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/data/json_data_source.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return None; [INFO] [stdout] 64 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/data/json_data_source.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | / if let Ok(result) = js_path_process(&query.query, &self.value) { [INFO] [stdout] 55 | | if result.len() > 0 { [INFO] [stdout] 56 | | return Some(Box::from(JsonDataSource::new(None, [INFO] [stdout] 57 | | serde_json::Value::Array(result [INFO] [stdout] ... | [INFO] [stdout] 62 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 54 ~ if let Ok(result) = js_path_process(&query.query, &self.value) [INFO] [stdout] 55 ~ && result.len() > 0 { [INFO] [stdout] 56 | return Some(Box::from(JsonDataSource::new(None, [INFO] [stdout] ... [INFO] [stdout] 60 | .collect::>())))); [INFO] [stdout] 61 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/data/json_data_source.rs:55:16 [INFO] [stdout] | [INFO] [stdout] 55 | if result.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!result.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/data/json_data_source.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | fn iter<'a>(&'a self, key: Option<&str>) -> std::slice::Iter { [INFO] [stdout] | ^^ ^^ ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 80 - fn iter<'a>(&'a self, key: Option<&str>) -> std::slice::Iter { [INFO] [stdout] 80 + fn iter(&self, key: Option<&str>) -> std::slice::Iter { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/data/json_data_source.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | return std::slice::Iter::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - return std::slice::Iter::default(); [INFO] [stdout] 88 + std::slice::Iter::default() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/data/json_data_source.rs:116:59 [INFO] [stdout] | [INFO] [stdout] 116 | self.source.value.as_array().unwrap().len() > self.idx as usize [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `self.idx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/data/json_data_source.rs:125:13 [INFO] [stdout] | [INFO] [stdout] 125 | self.idx = self.idx + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.idx += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/data_context.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | / impl Default for DataContext { [INFO] [stdout] 12 | | fn default() -> Self { [INFO] [stdout] 13 | | Self { [INFO] [stdout] 14 | | bindings: HashMap::new() [INFO] [stdout] ... | [INFO] [stdout] 17 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 7 + #[derive(Default)] [INFO] [stdout] 8 | struct DataContext { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `serde_json::Value` [INFO] [stdout] --> src/main.rs:48:36 [INFO] [stdout] | [INFO] [stdout] 48 | Data::Value(v) => Some(v.into()), [INFO] [stdout] | ^^^^^^^^ help: consider removing `.into()`: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | / if let Some(queue) = self.hidden.get_mut(key) { [INFO] [stdout] 58 | | if let Some(value) = queue.pop_front() { [INFO] [stdout] 59 | | obj.insert(String::from(key), value); [INFO] [stdout] 60 | | } [INFO] [stdout] 61 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 57 ~ if let Some(queue) = self.hidden.get_mut(key) [INFO] [stdout] 58 ~ && let Some(value) = queue.pop_front() { [INFO] [stdout] 59 | obj.insert(String::from(key), value); [INFO] [stdout] 60 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/main.rs:65:21 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn let_bind<'a>(&'a mut self, key: &str, value: serde_json::Value) { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 65 - pub fn let_bind<'a>(&'a mut self, key: &str, value: serde_json::Value) { [INFO] [stdout] 65 + pub fn let_bind(&mut self, key: &str, value: serde_json::Value) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | / return replace_all( [INFO] [stdout] 103 | | ®ex, [INFO] [stdout] 104 | | content, [INFO] [stdout] 105 | | |caps: ®ex::Captures| -> Result { [INFO] [stdout] ... | [INFO] [stdout] 122 | | }, [INFO] [stdout] 123 | | ).expect("Failed to substitute data"); [INFO] [stdout] | |_____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 ~ replace_all( [INFO] [stdout] 103 + ®ex, [INFO] [stdout] 104 + content, [INFO] [stdout] 105 + |caps: ®ex::Captures| -> Result { [INFO] [stdout] 106 + let path = caps.get(2) [INFO] [stdout] 107 + .expect("Invalid data substitution regex") [INFO] [stdout] 108 + .as_str(); [INFO] [stdout] 109 + [INFO] [stdout] 110 + let result = self.query(&Query::from_json_path(path)); [INFO] [stdout] 111 + if let Some(val) = result { [INFO] [stdout] 112 + // if let Some(value) = val.value(None) { [INFO] [stdout] 113 + return Ok(val.to_string() [INFO] [stdout] 114 + .trim_matches('"') [INFO] [stdout] 115 + .to_string()); [INFO] [stdout] 116 + //} [INFO] [stdout] 117 + } [INFO] [stdout] 118 + [INFO] [stdout] 119 + // return empty string [INFO] [stdout] 120 + return Ok(String::new()); [INFO] [stdout] 121 + // return Ok(caps.get(0).unwrap().as_str().to_string()); [INFO] [stdout] 122 + }, [INFO] [stdout] 123 ~ ).expect("Failed to substitute data") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | return Ok(String::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 120 - return Ok(String::new()); [INFO] [stdout] 120 + Ok(String::new()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/main.rs:155:46 [INFO] [stdout] | [INFO] [stdout] 155 | if node.tag_name().namespace().is_some() { [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 156 | | write!(write, "<{}", [INFO] [stdout] 157 | | node.tag_name().name())?; [INFO] [stdout] 158 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/main.rs:158:12 [INFO] [stdout] | [INFO] [stdout] 158 | } else { [INFO] [stdout] | ____________^ [INFO] [stdout] 159 | | write!(write, "<{}", node.tag_name().name())?; [INFO] [stdout] 160 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:198:64 [INFO] [stdout] | [INFO] [stdout] 198 | write!(self.output, "{}", self.data.substitute(&trimmed)) [INFO] [stdout] | ^^^^^^^^ help: change this to: `trimmed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/main.rs:235:17 [INFO] [stdout] | [INFO] [stdout] 235 | components: HashMap<(String, String), Rc) + 'a>> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/main.rs:250:51 [INFO] [stdout] | [INFO] [stdout] 250 | fn get_component(&self, tag: (&str, &str)) -> Option) + 'a>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:358:26 [INFO] [stdout] | [INFO] [stdout] 358 | let is_negated = !y.attribute("true").is_some(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `y.attribute("true").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:375:12 [INFO] [stdout] | [INFO] [stdout] 375 | if is_true == !is_negated { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `is_true != is_negated` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:397:17 [INFO] [stdout] | [INFO] [stdout] 397 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 397 - return result; [INFO] [stdout] 397 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:394:17 [INFO] [stdout] | [INFO] [stdout] 394 | let result = x2.generate_inner(y); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 394 ~ x2.generate_inner(y); [INFO] [stdout] 395 | y2.attributes().for_each(|attr| { x2.data.unbind(attr.name()); }); [INFO] [stdout] 396 | [INFO] [stdout] 397 ~ return (); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/data/data_source.rs:31:49 [INFO] [stdout] | [INFO] [stdout] 31 | fn iter<'a>(&'a self, key: Option<&str>) -> std::slice::Iter; [INFO] [stdout] | -- the lifetime is named here ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 31 | fn iter<'a>(&'a self, key: Option<&str>) -> std::slice::Iter<'a, serde_json::Value>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/data/json_data_source.rs:80:49 [INFO] [stdout] | [INFO] [stdout] 80 | fn iter<'a>(&'a self, key: Option<&str>) -> std::slice::Iter { [INFO] [stdout] | -- the lifetime is named here ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 80 | fn iter<'a>(&'a self, key: Option<&str>) -> std::slice::Iter<'a, serde_json::Value> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::data::data_source::DataSource` [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use crate::data::data_source::DataSource; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `jsonpath_rust::JsonPath` [INFO] [stdout] --> src/main.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use jsonpath_rust::JsonPath; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `key` [INFO] [stdout] --> src/data/json_data_source.rs:80:27 [INFO] [stdout] | [INFO] [stdout] 80 | fn iter<'a>(&'a self, key: Option<&str>) -> std::slice::Iter { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_key` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `f` [INFO] [stdout] --> src/data_context.rs:28:19 [INFO] [stdout] | [INFO] [stdout] 28 | fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | let mut prev_value: Option = None; [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `prev_value` [INFO] [stdout] --> src/main.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | let mut prev_value: Option = None; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_prev_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `LetGuard` is never constructed [INFO] [stdout] --> src/main.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | struct LetGuard<'a> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/main.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 36 | impl DataContext { [INFO] [stdout] | ---------------- associated function in this implementation [INFO] [stdout] 37 | fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Value` is never used [INFO] [stdout] --> src/data/data_source.rs:6:10 [INFO] [stdout] | [INFO] [stdout] 6 | pub enum Value { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `DataSource` is never used [INFO] [stdout] --> src/data/data_source.rs:26:11 [INFO] [stdout] | [INFO] [stdout] 26 | pub trait DataSource { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Bindings` is never constructed [INFO] [stdout] --> src/data/data_source.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 34 | pub struct Bindings { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `JsonDataSource` is never constructed [INFO] [stdout] --> src/data/json_data_source.rs:6:12 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct JsonDataSource { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/data/json_data_source.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 10 | impl JsonDataSource { [INFO] [stdout] | ------------------- associated function in this implementation [INFO] [stdout] 11 | pub fn new(key: Option<&str>, value: serde_json::Value) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `json_number_to_value` is never used [INFO] [stdout] --> src/data/json_data_source.rs:24:4 [INFO] [stdout] | [INFO] [stdout] 24 | fn json_number_to_value(number: &serde_json::Number) -> Value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `json_value_to_value` is never used [INFO] [stdout] --> src/data/json_data_source.rs:36:4 [INFO] [stdout] | [INFO] [stdout] 36 | fn json_value_to_value(value: &serde_json::Value) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `JsonDataSourceIterator` is never constructed [INFO] [stdout] --> src/data/json_data_source.rs:105:8 [INFO] [stdout] | [INFO] [stdout] 105 | struct JsonDataSourceIterator<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DataContext` is never constructed [INFO] [stdout] --> src/data_context.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | struct DataContext { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/data/data_source.rs:17:56 [INFO] [stdout] | [INFO] [stdout] 17 | Value::Bool(value) => write!(f, "{}", value.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/data/data_source.rs:18:55 [INFO] [stdout] | [INFO] [stdout] 18 | Value::Int(value) => write!(f, "{}", value.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/data/data_source.rs:19:56 [INFO] [stdout] | [INFO] [stdout] 19 | Value::Uint(value) => write!(f, "{}", value.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/data/data_source.rs:20:57 [INFO] [stdout] | [INFO] [stdout] 20 | Value::Float(value) => write!(f, "{}", value.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/data/data_source.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 31 | fn iter<'a>(&'a self, key: Option<&str>) -> std::slice::Iter; [INFO] [stdout] | ^^ ^^ ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 31 - fn iter<'a>(&'a self, key: Option<&str>) -> std::slice::Iter; [INFO] [stdout] 31 + fn iter(&self, key: Option<&str>) -> std::slice::Iter; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `key` after checking its variant with `is_some` [INFO] [stdout] --> src/data/json_data_source.rs:14:24 [INFO] [stdout] | [INFO] [stdout] 12 | if key.is_some() { [INFO] [stdout] | ---------------- help: try: `if let Some() = key` [INFO] [stdout] 13 | let mut map = serde_json::Map::new(); [INFO] [stdout] 14 | map.insert(key.unwrap().to_string(), value); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/data/json_data_source.rs:43:17 [INFO] [stdout] | [INFO] [stdout] 43 | return json_value_to_value(&arr[0]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return json_value_to_value(&arr[0]); [INFO] [stdout] 43 + json_value_to_value(&arr[0]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/data/json_data_source.rs:45:17 [INFO] [stdout] | [INFO] [stdout] 45 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return None; [INFO] [stdout] 45 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `bool` which implements the `Copy` trait [INFO] [stdout] --> src/data/json_data_source.rs:38:60 [INFO] [stdout] | [INFO] [stdout] 38 | serde_json::Value::Bool(value) => Some(Value::Bool(value.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/data/json_data_source.rs:39:69 [INFO] [stdout] | [INFO] [stdout] 39 | serde_json::Value::Number(num) => Some(json_number_to_value(&num)), [INFO] [stdout] | ^^^^ help: change this to: `num` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/data/json_data_source.rs:53:14 [INFO] [stdout] | [INFO] [stdout] 53 | fn query<'a>(&'a self, query: &Query) -> Option> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 53 - fn query<'a>(&'a self, query: &Query) -> Option> { [INFO] [stdout] 53 + fn query(&self, query: &Query) -> Option> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/data/json_data_source.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return None; [INFO] [stdout] 64 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/data/json_data_source.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | / if let Ok(result) = js_path_process(&query.query, &self.value) { [INFO] [stdout] 55 | | if result.len() > 0 { [INFO] [stdout] 56 | | return Some(Box::from(JsonDataSource::new(None, [INFO] [stdout] 57 | | serde_json::Value::Array(result [INFO] [stdout] ... | [INFO] [stdout] 62 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 54 ~ if let Ok(result) = js_path_process(&query.query, &self.value) [INFO] [stdout] 55 ~ && result.len() > 0 { [INFO] [stdout] 56 | return Some(Box::from(JsonDataSource::new(None, [INFO] [stdout] ... [INFO] [stdout] 60 | .collect::>())))); [INFO] [stdout] 61 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/data/json_data_source.rs:55:16 [INFO] [stdout] | [INFO] [stdout] 55 | if result.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!result.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/data/json_data_source.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | fn iter<'a>(&'a self, key: Option<&str>) -> std::slice::Iter { [INFO] [stdout] | ^^ ^^ ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 80 - fn iter<'a>(&'a self, key: Option<&str>) -> std::slice::Iter { [INFO] [stdout] 80 + fn iter(&self, key: Option<&str>) -> std::slice::Iter { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/data/json_data_source.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | return std::slice::Iter::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - return std::slice::Iter::default(); [INFO] [stdout] 88 + std::slice::Iter::default() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/data/json_data_source.rs:116:59 [INFO] [stdout] | [INFO] [stdout] 116 | self.source.value.as_array().unwrap().len() > self.idx as usize [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `self.idx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/data/json_data_source.rs:125:13 [INFO] [stdout] | [INFO] [stdout] 125 | self.idx = self.idx + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.idx += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/data_context.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | / impl Default for DataContext { [INFO] [stdout] 12 | | fn default() -> Self { [INFO] [stdout] 13 | | Self { [INFO] [stdout] 14 | | bindings: HashMap::new() [INFO] [stdout] ... | [INFO] [stdout] 17 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 7 + #[derive(Default)] [INFO] [stdout] 8 | struct DataContext { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `serde_json::Value` [INFO] [stdout] --> src/main.rs:48:36 [INFO] [stdout] | [INFO] [stdout] 48 | Data::Value(v) => Some(v.into()), [INFO] [stdout] | ^^^^^^^^ help: consider removing `.into()`: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | / if let Some(queue) = self.hidden.get_mut(key) { [INFO] [stdout] 58 | | if let Some(value) = queue.pop_front() { [INFO] [stdout] 59 | | obj.insert(String::from(key), value); [INFO] [stdout] 60 | | } [INFO] [stdout] 61 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 57 ~ if let Some(queue) = self.hidden.get_mut(key) [INFO] [stdout] 58 ~ && let Some(value) = queue.pop_front() { [INFO] [stdout] 59 | obj.insert(String::from(key), value); [INFO] [stdout] 60 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/main.rs:65:21 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn let_bind<'a>(&'a mut self, key: &str, value: serde_json::Value) { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 65 - pub fn let_bind<'a>(&'a mut self, key: &str, value: serde_json::Value) { [INFO] [stdout] 65 + pub fn let_bind(&mut self, key: &str, value: serde_json::Value) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | / return replace_all( [INFO] [stdout] 103 | | ®ex, [INFO] [stdout] 104 | | content, [INFO] [stdout] 105 | | |caps: ®ex::Captures| -> Result { [INFO] [stdout] ... | [INFO] [stdout] 122 | | }, [INFO] [stdout] 123 | | ).expect("Failed to substitute data"); [INFO] [stdout] | |_____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 ~ replace_all( [INFO] [stdout] 103 + ®ex, [INFO] [stdout] 104 + content, [INFO] [stdout] 105 + |caps: ®ex::Captures| -> Result { [INFO] [stdout] 106 + let path = caps.get(2) [INFO] [stdout] 107 + .expect("Invalid data substitution regex") [INFO] [stdout] 108 + .as_str(); [INFO] [stdout] 109 + [INFO] [stdout] 110 + let result = self.query(&Query::from_json_path(path)); [INFO] [stdout] 111 + if let Some(val) = result { [INFO] [stdout] 112 + // if let Some(value) = val.value(None) { [INFO] [stdout] 113 + return Ok(val.to_string() [INFO] [stdout] 114 + .trim_matches('"') [INFO] [stdout] 115 + .to_string()); [INFO] [stdout] 116 + //} [INFO] [stdout] 117 + } [INFO] [stdout] 118 + [INFO] [stdout] 119 + // return empty string [INFO] [stdout] 120 + return Ok(String::new()); [INFO] [stdout] 121 + // return Ok(caps.get(0).unwrap().as_str().to_string()); [INFO] [stdout] 122 + }, [INFO] [stdout] 123 ~ ).expect("Failed to substitute data") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | return Ok(String::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 120 - return Ok(String::new()); [INFO] [stdout] 120 + Ok(String::new()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/main.rs:155:46 [INFO] [stdout] | [INFO] [stdout] 155 | if node.tag_name().namespace().is_some() { [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 156 | | write!(write, "<{}", [INFO] [stdout] 157 | | node.tag_name().name())?; [INFO] [stdout] 158 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/main.rs:158:12 [INFO] [stdout] | [INFO] [stdout] 158 | } else { [INFO] [stdout] | ____________^ [INFO] [stdout] 159 | | write!(write, "<{}", node.tag_name().name())?; [INFO] [stdout] 160 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:198:64 [INFO] [stdout] | [INFO] [stdout] 198 | write!(self.output, "{}", self.data.substitute(&trimmed)) [INFO] [stdout] | ^^^^^^^^ help: change this to: `trimmed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/main.rs:235:17 [INFO] [stdout] | [INFO] [stdout] 235 | components: HashMap<(String, String), Rc) + 'a>> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/main.rs:250:51 [INFO] [stdout] | [INFO] [stdout] 250 | fn get_component(&self, tag: (&str, &str)) -> Option) + 'a>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:358:26 [INFO] [stdout] | [INFO] [stdout] 358 | let is_negated = !y.attribute("true").is_some(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `y.attribute("true").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:375:12 [INFO] [stdout] | [INFO] [stdout] 375 | if is_true == !is_negated { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `is_true != is_negated` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:397:17 [INFO] [stdout] | [INFO] [stdout] 397 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 397 - return result; [INFO] [stdout] 397 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:394:17 [INFO] [stdout] | [INFO] [stdout] 394 | let result = x2.generate_inner(y); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 394 ~ x2.generate_inner(y); [INFO] [stdout] 395 | y2.attributes().for_each(|attr| { x2.data.unbind(attr.name()); }); [INFO] [stdout] 396 | [INFO] [stdout] 397 ~ return (); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/data/data_source.rs:31:49 [INFO] [stdout] | [INFO] [stdout] 31 | fn iter<'a>(&'a self, key: Option<&str>) -> std::slice::Iter; [INFO] [stdout] | -- the lifetime is named here ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 31 | fn iter<'a>(&'a self, key: Option<&str>) -> std::slice::Iter<'a, serde_json::Value>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/data/json_data_source.rs:80:49 [INFO] [stdout] | [INFO] [stdout] 80 | fn iter<'a>(&'a self, key: Option<&str>) -> std::slice::Iter { [INFO] [stdout] | -- the lifetime is named here ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 80 | fn iter<'a>(&'a self, key: Option<&str>) -> std::slice::Iter<'a, serde_json::Value> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 15.20s [INFO] running `Command { std: "docker" "inspect" "c50d5a5a26d440040141636c7c70a64f4d5b3024bdcbaa7c6b07a2b8c08a2588", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c50d5a5a26d440040141636c7c70a64f4d5b3024bdcbaa7c6b07a2b8c08a2588", kill_on_drop: false }` [INFO] [stdout] c50d5a5a26d440040141636c7c70a64f4d5b3024bdcbaa7c6b07a2b8c08a2588