[INFO] cloning repository https://github.com/BenderBlog/qsl_recorder [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/BenderBlog/qsl_recorder" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBenderBlog%2Fqsl_recorder", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBenderBlog%2Fqsl_recorder'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ae6c77cd029c10603b3111cb15c2758031b9d366 [INFO] linting BenderBlog/qsl_recorder against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBenderBlog%2Fqsl_recorder" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/BenderBlog/qsl_recorder [INFO] finished tweaking git repo https://github.com/BenderBlog/qsl_recorder [INFO] tweaked toml for git repo https://github.com/BenderBlog/qsl_recorder written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/BenderBlog/qsl_recorder on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/BenderBlog/qsl_recorder already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded enumset_derive v0.12.0 [INFO] [stderr] Downloaded askama v0.14.0 [INFO] [stderr] Downloaded askama_derive v0.14.0 [INFO] [stderr] Downloaded enumset v1.1.7 [INFO] [stderr] Downloaded cursive_table_view v0.15.0 [INFO] [stderr] Downloaded askama_parser v0.14.0 [INFO] [stderr] Downloaded time v0.3.9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6abe29953216b688e13590272915e0128014225d4449558142864db4f489a39f [INFO] running `Command { std: "docker" "start" "-a" "6abe29953216b688e13590272915e0128014225d4449558142864db4f489a39f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6abe29953216b688e13590272915e0128014225d4449558142864db4f489a39f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6abe29953216b688e13590272915e0128014225d4449558142864db4f489a39f", kill_on_drop: false }` [INFO] [stdout] 6abe29953216b688e13590272915e0128014225d4449558142864db4f489a39f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 028789c7f93b1fd1766511f3d25ae58afc1607683dd8d03b2ec9357edafa6dee [INFO] running `Command { std: "docker" "start" "-a" "028789c7f93b1fd1766511f3d25ae58afc1607683dd8d03b2ec9357edafa6dee", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.95 [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Checking cfg-if v1.0.1 [INFO] [stderr] Compiling rustversion v1.0.21 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling lock_api v0.4.13 [INFO] [stderr] Compiling zerocopy v0.8.26 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Compiling serde_json v1.0.140 [INFO] [stderr] Compiling cc v1.2.27 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Checking memchr v2.7.5 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking xi-unicode v0.3.0 [INFO] [stderr] Checking hashbrown v0.15.4 [INFO] [stderr] Compiling basic-toml v0.1.10 [INFO] [stderr] Compiling rustc-hash v2.1.1 [INFO] [stderr] Checking iana-time-zone v0.1.63 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling cursive-macros v0.1.0 [INFO] [stderr] Checking hashlink v0.10.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking compact_str v0.8.1 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking signal-hook-registry v1.4.5 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking time v0.3.9 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling libsqlite3-sys v0.35.0 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking signal-hook v0.3.18 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling enum-map-derive v0.17.0 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Checking enum-map v2.7.3 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling enumset_derive v0.12.0 [INFO] [stderr] Checking enumset v1.1.7 [INFO] [stderr] Checking cursive_core v0.4.6 [INFO] [stderr] Compiling askama_parser v0.14.0 [INFO] [stderr] Compiling askama_derive v0.14.0 [INFO] [stderr] Checking cursive v0.21.1 [INFO] [stderr] Checking cursive_table_view v0.15.0 [INFO] [stderr] Checking rusqlite v0.37.0 [INFO] [stderr] Checking askama v0.14.0 [INFO] [stderr] Checking qsl_recorder v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `else` branch is empty [INFO] [stdout] --> src/main.rs:197:15 [INFO] [stdout] | [INFO] [stdout] 197 | } else { [INFO] [stdout] | _______________^ [INFO] [stdout] 198 | | } [INFO] [stdout] | |_____________^ help: you can remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_else [INFO] [stdout] = note: `#[warn(clippy::needless_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `else` branch is empty [INFO] [stdout] --> src/main.rs:197:15 [INFO] [stdout] | [INFO] [stdout] 197 | } else { [INFO] [stdout] | _______________^ [INFO] [stdout] 198 | | } [INFO] [stdout] | |_____________^ help: you can remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_else [INFO] [stdout] = note: `#[warn(clippy::needless_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/qsl_adif_helper.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | str.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/qsl_adif_helper.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | str.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/qsl_adif_helper.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | str.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/qsl_adif_helper.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | str.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/qsl_adif_helper.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | str.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/qsl_adif_helper.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | str.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/qsl_adif_helper.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | str.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/qsl_adif_helper.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | str.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `str.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/qsl_manage_ui.rs:104:42 [INFO] [stdout] | [INFO] [stdout] 104 | .on_event(event::Key::Right, |s| next_page(s)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `next_page` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/qsl_manage_ui.rs:103:41 [INFO] [stdout] | [INFO] [stdout] 103 | .on_event(event::Key::Left, |s| previous_page(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `previous_page` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/qsl_manage_ui.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | / if let Some(qslmanager) = s.user_data::() { [INFO] [stdout] 117 | | if qslmanager.page < qslmanager.max_page() { [INFO] [stdout] 118 | | qslmanager.page += 1; [INFO] [stdout] 119 | | show_qsl_table(s); [INFO] [stdout] 120 | | } [INFO] [stdout] 121 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 116 ~ if let Some(qslmanager) = s.user_data::() [INFO] [stdout] 117 ~ && qslmanager.page < qslmanager.max_page() { [INFO] [stdout] 118 | qslmanager.page += 1; [INFO] [stdout] 119 | show_qsl_table(s); [INFO] [stdout] 120 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/qsl_manage_ui.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | / if let Some(qslmanager) = s.user_data::() { [INFO] [stdout] 126 | | if qslmanager.page > 0 { [INFO] [stdout] 127 | | qslmanager.page -= 1; [INFO] [stdout] 128 | | show_qsl_table(s); [INFO] [stdout] 129 | | } [INFO] [stdout] 130 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 125 ~ if let Some(qslmanager) = s.user_data::() [INFO] [stdout] 126 ~ && qslmanager.page > 0 { [INFO] [stdout] 127 | qslmanager.page -= 1; [INFO] [stdout] 128 | show_qsl_table(s); [INFO] [stdout] 129 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/qsl_manage_ui.rs:424:21 [INFO] [stdout] | [INFO] [stdout] 424 | id: id.clone(), [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/qsl_manager.rs:57:25 [INFO] [stdout] | [INFO] [stdout] 57 | self.max_page = (self.number_of_record / self.split_page_size as usize + 1) as usize - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.number_of_record / self.split_page_size as usize + 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/qsl_manage_ui.rs:104:42 [INFO] [stdout] | [INFO] [stdout] 104 | .on_event(event::Key::Right, |s| next_page(s)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `next_page` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/qsl_manage_ui.rs:103:41 [INFO] [stdout] | [INFO] [stdout] 103 | .on_event(event::Key::Left, |s| previous_page(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `previous_page` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i64` -> `i64`) [INFO] [stdout] --> src/qsl_manager.rs:90:60 [INFO] [stdout] | [INFO] [stdout] 90 | .get_formal_qsl_page(self.split_page_size, i as i64) [INFO] [stdout] | ^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/qsl_manage_ui.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | / if let Some(qslmanager) = s.user_data::() { [INFO] [stdout] 117 | | if qslmanager.page < qslmanager.max_page() { [INFO] [stdout] 118 | | qslmanager.page += 1; [INFO] [stdout] 119 | | show_qsl_table(s); [INFO] [stdout] 120 | | } [INFO] [stdout] 121 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 116 ~ if let Some(qslmanager) = s.user_data::() [INFO] [stdout] 117 ~ && qslmanager.page < qslmanager.max_page() { [INFO] [stdout] 118 | qslmanager.page += 1; [INFO] [stdout] 119 | show_qsl_table(s); [INFO] [stdout] 120 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/qsl_manage_ui.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | / if let Some(qslmanager) = s.user_data::() { [INFO] [stdout] 126 | | if qslmanager.page > 0 { [INFO] [stdout] 127 | | qslmanager.page -= 1; [INFO] [stdout] 128 | | show_qsl_table(s); [INFO] [stdout] 129 | | } [INFO] [stdout] 130 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 125 ~ if let Some(qslmanager) = s.user_data::() [INFO] [stdout] 126 ~ && qslmanager.page > 0 { [INFO] [stdout] 127 | qslmanager.page -= 1; [INFO] [stdout] 128 | show_qsl_table(s); [INFO] [stdout] 129 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i64` -> `i64`) [INFO] [stdout] --> src/qsl_manager.rs:143:60 [INFO] [stdout] | [INFO] [stdout] 143 | .get_formal_qsl_page(self.split_page_size, i as i64) [INFO] [stdout] | ^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/qsl_manage_ui.rs:424:21 [INFO] [stdout] | [INFO] [stdout] 424 | id: id.clone(), [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HTML` contains a capitalized acronym [INFO] [stdout] --> src/qsl_type.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | HTML, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Html` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/qsl_manager.rs:57:25 [INFO] [stdout] | [INFO] [stdout] 57 | self.max_page = (self.number_of_record / self.split_page_size as usize + 1) as usize - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.number_of_record / self.split_page_size as usize + 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TYPST` contains a capitalized acronym [INFO] [stdout] --> src/qsl_type.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | TYPST, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Typst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ADIF` contains a capitalized acronym [INFO] [stdout] --> src/qsl_type.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | ADIF, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Adif` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EYEBALL` contains a capitalized acronym [INFO] [stdout] --> src/qsl_type.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | EYEBALL, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Eyeball` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SSB` contains a capitalized acronym [INFO] [stdout] --> src/qsl_type.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | SSB, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ssb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FTB` contains a capitalized acronym [INFO] [stdout] --> src/qsl_type.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | FTB, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ftb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `OTHER` contains a capitalized acronym [INFO] [stdout] --> src/qsl_type.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | OTHER, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `QSL` contains a capitalized acronym [INFO] [stdout] --> src/qsl_type.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 38 | pub struct QSL { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Qsl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i64` -> `i64`) [INFO] [stdout] --> src/qsl_manager.rs:90:60 [INFO] [stdout] | [INFO] [stdout] 90 | .get_formal_qsl_page(self.split_page_size, i as i64) [INFO] [stdout] | ^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i64` -> `i64`) [INFO] [stdout] --> src/qsl_manager.rs:143:60 [INFO] [stdout] | [INFO] [stdout] 143 | .get_formal_qsl_page(self.split_page_size, i as i64) [INFO] [stdout] | ^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/qsl_type.rs:170:17 [INFO] [stdout] | [INFO] [stdout] 170 | fn get_band<'a>(&self) -> Result, String> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:73:24 [INFO] [stdout] | [INFO] [stdout] 73 | if !path.read_dir().unwrap().next().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `path.read_dir().unwrap().next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/main.rs:196:60 [INFO] [stdout] | [INFO] [stdout] 196 | if mode == Usage::HTML || mode == Usage::TYPST { [INFO] [stdout] | ____________________________________________________________^ [INFO] [stdout] 197 | | } else { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/main.rs:197:20 [INFO] [stdout] | [INFO] [stdout] 197 | } else { [INFO] [stdout] | ____________________^ [INFO] [stdout] 198 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HTML` contains a capitalized acronym [INFO] [stdout] --> src/qsl_type.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | HTML, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Html` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TYPST` contains a capitalized acronym [INFO] [stdout] --> src/qsl_type.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | TYPST, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Typst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ADIF` contains a capitalized acronym [INFO] [stdout] --> src/qsl_type.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | ADIF, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Adif` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EYEBALL` contains a capitalized acronym [INFO] [stdout] --> src/qsl_type.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | EYEBALL, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Eyeball` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SSB` contains a capitalized acronym [INFO] [stdout] --> src/qsl_type.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | SSB, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ssb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FTB` contains a capitalized acronym [INFO] [stdout] --> src/qsl_type.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | FTB, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ftb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `OTHER` contains a capitalized acronym [INFO] [stdout] --> src/qsl_type.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | OTHER, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `QSL` contains a capitalized acronym [INFO] [stdout] --> src/qsl_type.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 38 | pub struct QSL { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Qsl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/qsl_type.rs:170:17 [INFO] [stdout] | [INFO] [stdout] 170 | fn get_band<'a>(&self) -> Result, String> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:73:24 [INFO] [stdout] | [INFO] [stdout] 73 | if !path.read_dir().unwrap().next().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `path.read_dir().unwrap().next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/main.rs:196:60 [INFO] [stdout] | [INFO] [stdout] 196 | if mode == Usage::HTML || mode == Usage::TYPST { [INFO] [stdout] | ____________________________________________________________^ [INFO] [stdout] 197 | | } else { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/main.rs:197:20 [INFO] [stdout] | [INFO] [stdout] 197 | } else { [INFO] [stdout] | ____________________^ [INFO] [stdout] 198 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 21.11s [INFO] running `Command { std: "docker" "inspect" "028789c7f93b1fd1766511f3d25ae58afc1607683dd8d03b2ec9357edafa6dee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "028789c7f93b1fd1766511f3d25ae58afc1607683dd8d03b2ec9357edafa6dee", kill_on_drop: false }` [INFO] [stdout] 028789c7f93b1fd1766511f3d25ae58afc1607683dd8d03b2ec9357edafa6dee