[INFO] cloning repository https://github.com/Beauhurst/rvc [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Beauhurst/rvc" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBeauhurst%2Frvc", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBeauhurst%2Frvc'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8fe3a074d960133e39e257011e4698f6919f1352 [INFO] linting Beauhurst/rvc against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBeauhurst%2Frvc" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Beauhurst/rvc [INFO] finished tweaking git repo https://github.com/Beauhurst/rvc [INFO] tweaked toml for git repo https://github.com/Beauhurst/rvc written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Beauhurst/rvc on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Beauhurst/rvc already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded testing_table v0.3.0 [INFO] [stderr] Downloaded tabled_derive v0.11.0 [INFO] [stderr] Downloaded aws-region v0.28.1 [INFO] [stderr] Downloaded zmij v1.0.19 [INFO] [stderr] Downloaded maybe-async v0.2.10 [INFO] [stderr] Downloaded aws-endpoint v0.55.3 [INFO] [stderr] Downloaded aws-creds v0.39.1 [INFO] [stderr] Downloaded aws-smithy-async v0.55.3 [INFO] [stderr] Downloaded aws-sig-auth v0.55.3 [INFO] [stderr] Downloaded aws-smithy-xml v0.55.3 [INFO] [stderr] Downloaded aws-credential-types v0.55.3 [INFO] [stderr] Downloaded aws-http v0.55.3 [INFO] [stderr] Downloaded aws-smithy-json v0.55.3 [INFO] [stderr] Downloaded aws-smithy-types v0.55.3 [INFO] [stderr] Downloaded aws-sdk-sso v0.28.0 [INFO] [stderr] Downloaded aws-smithy-http v0.55.3 [INFO] [stderr] Downloaded fraction v0.15.3 [INFO] [stderr] Downloaded aws-sdk-sts v0.28.0 [INFO] [stderr] Downloaded aws-config v0.55.3 [INFO] [stderr] Downloaded jsonschema v0.18.3 [INFO] [stderr] Downloaded rust-s3 v0.37.1 [INFO] [stderr] Downloaded tabled v0.20.0 [INFO] [stderr] Downloaded papergrid v0.17.0 [INFO] [stderr] Downloaded aws-smithy-client v0.55.3 [INFO] [stderr] Downloaded aws-sigv4 v0.55.3 [INFO] [stderr] Downloaded xmlparser v0.13.6 [INFO] [stderr] Downloaded bytes-utils v0.1.4 [INFO] [stderr] Downloaded aws-types v0.55.3 [INFO] [stderr] Downloaded reflink-copy v0.1.28 [INFO] [stderr] Downloaded md5 v0.8.0 [INFO] [stderr] Downloaded aws-smithy-query v0.55.3 [INFO] [stderr] Downloaded aws-smithy-http-tower v0.55.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9e65528168f4748080a188fd49f18ae6f68755bf6af0119f4e2b6c4742dd6d85 [INFO] running `Command { std: "docker" "start" "-a" "9e65528168f4748080a188fd49f18ae6f68755bf6af0119f4e2b6c4742dd6d85", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9e65528168f4748080a188fd49f18ae6f68755bf6af0119f4e2b6c4742dd6d85", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9e65528168f4748080a188fd49f18ae6f68755bf6af0119f4e2b6c4742dd6d85", kill_on_drop: false }` [INFO] [stdout] 9e65528168f4748080a188fd49f18ae6f68755bf6af0119f4e2b6c4742dd6d85 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 41c3bfd32748dcd8dbdb7f04e36afebf6ed9a134ab82d361362cb88baa0f651c [INFO] running `Command { std: "docker" "start" "-a" "41c3bfd32748dcd8dbdb7f04e36afebf6ed9a134ab82d361362cb88baa0f651c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Compiling find-msvc-tools v0.1.9 [INFO] [stderr] Checking bytes v1.11.0 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking ryu v1.0.22 [INFO] [stderr] Compiling time-core v0.1.8 [INFO] [stderr] Compiling num-conv v0.2.0 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Compiling time-macros v0.2.27 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Checking vsimd v0.8.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Compiling cc v1.2.55 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Checking outref v0.5.2 [INFO] [stderr] Checking base64-simd v0.8.0 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking litemap v0.8.1 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking writeable v0.6.2 [INFO] [stderr] Compiling aws-lc-rs v1.15.4 [INFO] [stderr] Compiling rustls v0.20.9 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Compiling icu_normalizer_data v2.1.1 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Compiling icu_properties_data v2.1.2 [INFO] [stderr] Checking bytes-utils v0.1.4 [INFO] [stderr] Checking deranged v0.5.5 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Checking openssl-probe v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking rustls-pki-types v1.14.0 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling aws-lc-sys v0.37.0 [INFO] [stderr] Checking regex-syntax v0.8.9 [INFO] [stderr] Checking rustls-native-certs v0.6.3 [INFO] [stderr] Compiling rustls v0.23.36 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Compiling aws-types v0.55.3 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling zmij v1.0.19 [INFO] [stderr] Compiling libz-sys v1.1.23 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Checking time v0.3.47 [INFO] [stderr] Checking webpki-roots v1.0.6 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Compiling libssh2-sys v0.3.1 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling thiserror v2.0.18 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking dlv-list v0.5.2 [INFO] [stderr] Checking iri-string v0.7.10 [INFO] [stderr] Checking ordered-multimap v0.7.3 [INFO] [stderr] Checking aws-smithy-types v0.55.3 [INFO] [stderr] Checking aws-smithy-json v0.55.3 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking webpki v0.22.4 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Compiling pin-project-internal v1.1.10 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking pin-project v1.1.10 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Compiling libgit2-sys v0.18.3+1.9.2 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Compiling proc-macro-error-attr2 v2.0.0 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking xmlparser v0.13.6 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking clap_lex v0.7.7 [INFO] [stderr] Checking bytecount v0.6.9 [INFO] [stderr] Checking clap_builder v4.5.56 [INFO] [stderr] Checking aws-smithy-xml v0.55.3 [INFO] [stderr] Compiling proc-macro-error2 v2.0.1 [INFO] [stderr] Checking aws-smithy-query v0.55.3 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Checking rust-ini v0.21.3 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tokio-stream v0.1.18 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking aws-smithy-async v0.55.3 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-rustls v0.23.4 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking aws-credential-types v0.55.3 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking quick-xml v0.38.4 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking home v0.5.12 [INFO] [stderr] Compiling zerocopy v0.8.39 [INFO] [stderr] Checking clap v4.5.56 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling tabled_derive v0.11.0 [INFO] [stderr] Checking papergrid v0.17.0 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking testing_table v0.3.0 [INFO] [stderr] Checking aws-region v0.28.1 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling maybe-async v0.2.10 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking sysinfo v0.37.2 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Checking csv-core v0.1.13 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking iana-time-zone v0.1.65 [INFO] [stderr] Checking md5 v0.8.0 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking chrono v0.4.43 [INFO] [stderr] Checking csv v1.4.0 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking tabled v0.20.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking reflink-copy v0.1.28 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking colored v2.2.0 [INFO] [stderr] Checking nom v8.0.0 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking fancy-regex v0.13.0 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking fraction v0.15.3 [INFO] [stderr] Checking num-cmp v0.1.0 [INFO] [stderr] Checking uuid v1.20.0 [INFO] [stderr] Checking tempfile v3.24.0 [INFO] [stderr] Checking aws-smithy-http v0.55.3 [INFO] [stderr] Checking hyper-rustls v0.23.2 [INFO] [stderr] Checking iso8601 v0.6.3 [INFO] [stderr] Checking aws-smithy-http-tower v0.55.3 [INFO] [stderr] Checking aws-sigv4 v0.55.3 [INFO] [stderr] Checking aws-smithy-client v0.55.3 [INFO] [stderr] Checking aws-sig-auth v0.55.3 [INFO] [stderr] Checking aws-http v0.55.3 [INFO] [stderr] Checking aws-endpoint v0.55.3 [INFO] [stderr] Checking aws-sdk-sso v0.28.0 [INFO] [stderr] Checking aws-sdk-sts v0.28.0 [INFO] [stderr] Checking aws-config v0.55.3 [INFO] [stderr] Checking git2 v0.20.4 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking attohttpc v0.30.1 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stderr] Checking aws-creds v0.39.1 [INFO] [stderr] Checking rust-s3 v0.37.1 [INFO] [stderr] Checking jsonschema v0.18.3 [INFO] [stderr] Checking rvc v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/app/metrics.rs:92:1 [INFO] [stdout] | [INFO] [stdout] 92 | / pub(super) fn run_metrics( [INFO] [stdout] 93 | | config_path: &str, [INFO] [stdout] 94 | | base_dir: &Path, [INFO] [stdout] 95 | | filter_steps: &[String], [INFO] [stdout] ... | [INFO] [stdout] 101 | | show_timestamps: bool, [INFO] [stdout] 102 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/app/metrics.rs:205:1 [INFO] [stdout] | [INFO] [stdout] 205 | / pub(super) fn run_metrics_diff( [INFO] [stdout] 206 | | config_path: &str, [INFO] [stdout] 207 | | base_dir: &Path, [INFO] [stdout] 208 | | filter_steps: &[String], [INFO] [stdout] ... | [INFO] [stdout] 216 | | show_deltas_override: Option, [INFO] [stdout] 217 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/app/metrics.rs:396:19 [INFO] [stdout] | [INFO] [stdout] 396 | data.and_then(|d| crate::metrics::parse_metric(d)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `crate::metrics::parse_metric` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Key` [INFO] [stdout] --> src/app/metrics.rs:1157:1 [INFO] [stdout] | [INFO] [stdout] 1157 | / enum RowKeyKind { [INFO] [stdout] 1158 | | /// First column is "field"; non-key headers are bare ref names. [INFO] [stdout] 1159 | | /// Used for flat values and timeseries summary. [INFO] [stdout] 1160 | | FieldKey, [INFO] [stdout] ... | [INFO] [stdout] 1166 | | BinKey { split_range: bool }, [INFO] [stdout] 1167 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/app/plots.rs:280:1 [INFO] [stdout] | [INFO] [stdout] 280 | / fn live_poll_loop( [INFO] [stdout] 281 | | config_path: &str, [INFO] [stdout] 282 | | base_dir: &Path, [INFO] [stdout] 283 | | config_abs: &Path, [INFO] [stdout] ... | [INFO] [stdout] 288 | | stop_flag: &AtomicBool, [INFO] [stdout] 289 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/app/plots.rs:318:1 [INFO] [stdout] | [INFO] [stdout] 318 | / fn do_live_update( [INFO] [stdout] 319 | | config_path: &str, [INFO] [stdout] 320 | | base_dir: &Path, [INFO] [stdout] 321 | | config_abs: &Path, [INFO] [stdout] ... | [INFO] [stdout] 326 | | status: Option<&str>, [INFO] [stdout] 327 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/app/remote.rs:306:1 [INFO] [stdout] | [INFO] [stdout] 306 | / pub async fn run_push( [INFO] [stdout] 307 | | config_path: &str, [INFO] [stdout] 308 | | lock_path: &Path, [INFO] [stdout] 309 | | base_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 314 | | force: bool, [INFO] [stdout] 315 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/app/remote.rs:566:1 [INFO] [stdout] | [INFO] [stdout] 566 | / pub async fn run_pull( [INFO] [stdout] 567 | | config_path: &str, [INFO] [stdout] 568 | | lock_path: &Path, [INFO] [stdout] 569 | | base_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 574 | | force: bool, [INFO] [stdout] 575 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/app/remote.rs:635:39 [INFO] [stdout] | [INFO] [stdout] 635 | std::fs::metadata(&cache_dir.join(&rel)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `cache_dir.join(&rel)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `artifact.cache` after checking its variant with `is_some` [INFO] [stdout] --> src/app/remote.rs:921:33 [INFO] [stdout] | [INFO] [stdout] 920 | if artifact.manifest && artifact.cache.is_some() { [INFO] [stdout] | ------------------------ the check is happening here [INFO] [stdout] 921 | let cache_rel = artifact [INFO] [stdout] | _________________________________^ [INFO] [stdout] 922 | | .cache [INFO] [stdout] 923 | | .as_ref() [INFO] [stdout] 924 | | .unwrap() [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `Arc>` [INFO] [stdout] --> src/app/remote.rs:1245:14 [INFO] [stdout] | [INFO] [stdout] 1245 | bucket: &Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Box` is already on the heap, `Arc>` makes an extra allocation [INFO] [stdout] = help: consider using just `Arc` or `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_allocation [INFO] [stdout] = note: `#[warn(clippy::redundant_allocation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/app/remote.rs:1240:1 [INFO] [stdout] | [INFO] [stdout] 1240 | / async fn probe_and_download( [INFO] [stdout] 1241 | | hashes: &[String], [INFO] [stdout] 1242 | | cache_dir: &Path, [INFO] [stdout] 1243 | | bucket_name: &str, [INFO] [stdout] ... | [INFO] [stdout] 1249 | | ref_map: &DisplayMap, [INFO] [stdout] 1250 | | ) -> Result { [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `Arc>` [INFO] [stdout] --> src/app/remote.rs:1391:14 [INFO] [stdout] | [INFO] [stdout] 1391 | bucket: &Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Box` is already on the heap, `Arc>` makes an extra allocation [INFO] [stdout] = help: consider using just `Arc` or `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_allocation [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/app/remote.rs:1386:1 [INFO] [stdout] | [INFO] [stdout] 1386 | / async fn download_files( [INFO] [stdout] 1387 | | cache_rels: &[String], [INFO] [stdout] 1388 | | cache_dir: &Path, [INFO] [stdout] 1389 | | bucket_name: &str, [INFO] [stdout] ... | [INFO] [stdout] 1394 | | ref_map: &DisplayMap, [INFO] [stdout] 1395 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `clone` can be replaced with `std::slice::from_ref` [INFO] [stdout] --> src/app/status.rs:86:48 [INFO] [stdout] | [INFO] [stdout] 86 | let hashes = collect_step_hashes(lock, &[step_name.clone()]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `std::slice::from_ref(step_name)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_ref_to_slice_refs [INFO] [stdout] = note: `#[warn(clippy::cloned_ref_to_slice_refs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/config.rs:240:13 [INFO] [stdout] | [INFO] [stdout] 240 | / if !prefix.is_empty() { [INFO] [stdout] 241 | | result.insert(prefix.to_string(), s.clone()); [INFO] [stdout] 242 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 239 ~ serde_yaml::Value::String(s) [INFO] [stdout] 240 ~ if !prefix.is_empty() => { [INFO] [stdout] 241 | result.insert(prefix.to_string(), s.clone()); [INFO] [stdout] 242 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/config.rs:245:13 [INFO] [stdout] | [INFO] [stdout] 245 | / if !prefix.is_empty() { [INFO] [stdout] 246 | | result.insert(prefix.to_string(), n.to_string()); [INFO] [stdout] 247 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 244 ~ serde_yaml::Value::Number(n) [INFO] [stdout] 245 ~ if !prefix.is_empty() => { [INFO] [stdout] 246 | result.insert(prefix.to_string(), n.to_string()); [INFO] [stdout] 247 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/config.rs:250:13 [INFO] [stdout] | [INFO] [stdout] 250 | / if !prefix.is_empty() { [INFO] [stdout] 251 | | result.insert(prefix.to_string(), b.to_string()); [INFO] [stdout] 252 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 249 ~ serde_yaml::Value::Bool(b) [INFO] [stdout] 250 ~ if !prefix.is_empty() => { [INFO] [stdout] 251 | result.insert(prefix.to_string(), b.to_string()); [INFO] [stdout] 252 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/dag.rs:17:10 [INFO] [stdout] | [INFO] [stdout] 17 | name.replace('-', "_").replace('.', "_") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace(['-', '.'], "_")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] = note: `#[warn(clippy::collapsible_str_replace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/app/metrics.rs:92:1 [INFO] [stdout] | [INFO] [stdout] 92 | / pub(super) fn run_metrics( [INFO] [stdout] 93 | | config_path: &str, [INFO] [stdout] 94 | | base_dir: &Path, [INFO] [stdout] 95 | | filter_steps: &[String], [INFO] [stdout] ... | [INFO] [stdout] 101 | | show_timestamps: bool, [INFO] [stdout] 102 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/app/metrics.rs:205:1 [INFO] [stdout] | [INFO] [stdout] 205 | / pub(super) fn run_metrics_diff( [INFO] [stdout] 206 | | config_path: &str, [INFO] [stdout] 207 | | base_dir: &Path, [INFO] [stdout] 208 | | filter_steps: &[String], [INFO] [stdout] ... | [INFO] [stdout] 216 | | show_deltas_override: Option, [INFO] [stdout] 217 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/app/metrics.rs:396:19 [INFO] [stdout] | [INFO] [stdout] 396 | data.and_then(|d| crate::metrics::parse_metric(d)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `crate::metrics::parse_metric` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Key` [INFO] [stdout] --> src/app/metrics.rs:1157:1 [INFO] [stdout] | [INFO] [stdout] 1157 | / enum RowKeyKind { [INFO] [stdout] 1158 | | /// First column is "field"; non-key headers are bare ref names. [INFO] [stdout] 1159 | | /// Used for flat values and timeseries summary. [INFO] [stdout] 1160 | | FieldKey, [INFO] [stdout] ... | [INFO] [stdout] 1166 | | BinKey { split_range: bool }, [INFO] [stdout] 1167 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/hash.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | / pub fn from_str(s: &str) -> Result { [INFO] [stdout] 20 | | match s.to_lowercase().as_str() { [INFO] [stdout] 21 | | "md5" => Ok(HashAlgorithm::Md5), [INFO] [stdout] 22 | | "sha256" => Ok(HashAlgorithm::Sha256), [INFO] [stdout] ... | [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/app/plots.rs:280:1 [INFO] [stdout] | [INFO] [stdout] 280 | / fn live_poll_loop( [INFO] [stdout] 281 | | config_path: &str, [INFO] [stdout] 282 | | base_dir: &Path, [INFO] [stdout] 283 | | config_abs: &Path, [INFO] [stdout] ... | [INFO] [stdout] 288 | | stop_flag: &AtomicBool, [INFO] [stdout] 289 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/app/plots.rs:318:1 [INFO] [stdout] | [INFO] [stdout] 318 | / fn do_live_update( [INFO] [stdout] 319 | | config_path: &str, [INFO] [stdout] 320 | | base_dir: &Path, [INFO] [stdout] 321 | | config_abs: &Path, [INFO] [stdout] ... | [INFO] [stdout] 326 | | status: Option<&str>, [INFO] [stdout] 327 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/app/remote.rs:306:1 [INFO] [stdout] | [INFO] [stdout] 306 | / pub async fn run_push( [INFO] [stdout] 307 | | config_path: &str, [INFO] [stdout] 308 | | lock_path: &Path, [INFO] [stdout] 309 | | base_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 314 | | force: bool, [INFO] [stdout] 315 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/app/remote.rs:566:1 [INFO] [stdout] | [INFO] [stdout] 566 | / pub async fn run_pull( [INFO] [stdout] 567 | | config_path: &str, [INFO] [stdout] 568 | | lock_path: &Path, [INFO] [stdout] 569 | | base_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 574 | | force: bool, [INFO] [stdout] 575 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/app/remote.rs:635:39 [INFO] [stdout] | [INFO] [stdout] 635 | std::fs::metadata(&cache_dir.join(&rel)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `cache_dir.join(&rel)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `artifact.cache` after checking its variant with `is_some` [INFO] [stdout] --> src/app/remote.rs:921:33 [INFO] [stdout] | [INFO] [stdout] 920 | if artifact.manifest && artifact.cache.is_some() { [INFO] [stdout] | ------------------------ the check is happening here [INFO] [stdout] 921 | let cache_rel = artifact [INFO] [stdout] | _________________________________^ [INFO] [stdout] 922 | | .cache [INFO] [stdout] 923 | | .as_ref() [INFO] [stdout] 924 | | .unwrap() [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `Arc>` [INFO] [stdout] --> src/app/remote.rs:1245:14 [INFO] [stdout] | [INFO] [stdout] 1245 | bucket: &Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Box` is already on the heap, `Arc>` makes an extra allocation [INFO] [stdout] = help: consider using just `Arc` or `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_allocation [INFO] [stdout] = note: `#[warn(clippy::redundant_allocation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/app/remote.rs:1240:1 [INFO] [stdout] | [INFO] [stdout] 1240 | / async fn probe_and_download( [INFO] [stdout] 1241 | | hashes: &[String], [INFO] [stdout] 1242 | | cache_dir: &Path, [INFO] [stdout] 1243 | | bucket_name: &str, [INFO] [stdout] ... | [INFO] [stdout] 1249 | | ref_map: &DisplayMap, [INFO] [stdout] 1250 | | ) -> Result { [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `Arc>` [INFO] [stdout] --> src/app/remote.rs:1391:14 [INFO] [stdout] | [INFO] [stdout] 1391 | bucket: &Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Box` is already on the heap, `Arc>` makes an extra allocation [INFO] [stdout] = help: consider using just `Arc` or `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_allocation [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/app/remote.rs:1386:1 [INFO] [stdout] | [INFO] [stdout] 1386 | / async fn download_files( [INFO] [stdout] 1387 | | cache_rels: &[String], [INFO] [stdout] 1388 | | cache_dir: &Path, [INFO] [stdout] 1389 | | bucket_name: &str, [INFO] [stdout] ... | [INFO] [stdout] 1394 | | ref_map: &DisplayMap, [INFO] [stdout] 1395 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/metrics/parse.rs:138:8 [INFO] [stdout] | [INFO] [stdout] 138 | if !has_bin && !(has_bin_start && has_bin_end) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(has_bin || has_bin_start && has_bin_end)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `clone` can be replaced with `std::slice::from_ref` [INFO] [stdout] --> src/app/status.rs:86:48 [INFO] [stdout] | [INFO] [stdout] 86 | let hashes = collect_step_hashes(lock, &[step_name.clone()]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `std::slice::from_ref(step_name)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_ref_to_slice_refs [INFO] [stdout] = note: `#[warn(clippy::cloned_ref_to_slice_refs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/metrics/types.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | / if (trimmed.starts_with('{') && trimmed.ends_with('}')) [INFO] [stdout] 37 | | || (trimmed.starts_with('[') && trimmed.ends_with(']')) [INFO] [stdout] 38 | | { [INFO] [stdout] 39 | | if serde_json::from_str::(trimmed).is_ok() { [INFO] [stdout] ... | [INFO] [stdout] 42 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 36 ~ if ((trimmed.starts_with('{') && trimmed.ends_with('}')) [INFO] [stdout] 37 ~ || (trimmed.starts_with('[') && trimmed.ends_with(']')) [INFO] [stdout] 38 ~ || (trimmed.starts_with('[') && trimmed.ends_with(']'))) [INFO] [stdout] 39 | { [INFO] [stdout] 40 ~ && serde_json::from_str::(trimmed).is_ok() { [INFO] [stdout] 41 | return MetricFormat::Json; [INFO] [stdout] 42 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/plots.rs:79:21 [INFO] [stdout] | [INFO] [stdout] 79 | metrics_by_ref: &[(String, IndexMap>)], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/plots.rs:91:31 [INFO] [stdout] | [INFO] [stdout] 91 | .and_then(|d| crate::metrics::parse_metric(d)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `crate::metrics::parse_metric` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/plots.rs:123:21 [INFO] [stdout] | [INFO] [stdout] 123 | metrics_by_ref: &[(String, IndexMap>)], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/plots.rs:389:31 [INFO] [stdout] | [INFO] [stdout] 389 | let tick_stride = (x_labels.len() + max_tick_labels - 1) / max_tick_labels; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `x_labels.len().div_ceil(max_tick_labels)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: items after a test module [INFO] [stdout] --> src/config.rs:363:1 [INFO] [stdout] | [INFO] [stdout] 363 | mod tests { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 575 | impl RvcConfig { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_test_module [INFO] [stdout] = note: `#[warn(clippy::items_after_test_module)]` on by default [INFO] [stdout] = help: move the items to before the test module was defined [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/config.rs:240:13 [INFO] [stdout] | [INFO] [stdout] 240 | / if !prefix.is_empty() { [INFO] [stdout] 241 | | result.insert(prefix.to_string(), s.clone()); [INFO] [stdout] 242 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 239 ~ serde_yaml::Value::String(s) [INFO] [stdout] 240 ~ if !prefix.is_empty() => { [INFO] [stdout] 241 | result.insert(prefix.to_string(), s.clone()); [INFO] [stdout] 242 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/config.rs:245:13 [INFO] [stdout] | [INFO] [stdout] 245 | / if !prefix.is_empty() { [INFO] [stdout] 246 | | result.insert(prefix.to_string(), n.to_string()); [INFO] [stdout] 247 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 244 ~ serde_yaml::Value::Number(n) [INFO] [stdout] 245 ~ if !prefix.is_empty() => { [INFO] [stdout] 246 | result.insert(prefix.to_string(), n.to_string()); [INFO] [stdout] 247 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/config.rs:250:13 [INFO] [stdout] | [INFO] [stdout] 250 | / if !prefix.is_empty() { [INFO] [stdout] 251 | | result.insert(prefix.to_string(), b.to_string()); [INFO] [stdout] 252 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 249 ~ serde_yaml::Value::Bool(b) [INFO] [stdout] 250 ~ if !prefix.is_empty() => { [INFO] [stdout] 251 | result.insert(prefix.to_string(), b.to_string()); [INFO] [stdout] 252 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/dag.rs:17:10 [INFO] [stdout] | [INFO] [stdout] 17 | name.replace('-', "_").replace('.', "_") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace(['-', '.'], "_")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] = note: `#[warn(clippy::collapsible_str_replace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/dag.rs:595:17 [INFO] [stdout] | [INFO] [stdout] 595 | assert!(levels.len() >= 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!levels.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/hash.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | / pub fn from_str(s: &str) -> Result { [INFO] [stdout] 20 | | match s.to_lowercase().as_str() { [INFO] [stdout] 21 | | "md5" => Ok(HashAlgorithm::Md5), [INFO] [stdout] 22 | | "sha256" => Ok(HashAlgorithm::Sha256), [INFO] [stdout] ... | [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/metrics/parse.rs:138:8 [INFO] [stdout] | [INFO] [stdout] 138 | if !has_bin && !(has_bin_start && has_bin_end) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(has_bin || has_bin_start && has_bin_end)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/metrics/types.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | / if (trimmed.starts_with('{') && trimmed.ends_with('}')) [INFO] [stdout] 37 | | || (trimmed.starts_with('[') && trimmed.ends_with(']')) [INFO] [stdout] 38 | | { [INFO] [stdout] 39 | | if serde_json::from_str::(trimmed).is_ok() { [INFO] [stdout] ... | [INFO] [stdout] 42 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 36 ~ if ((trimmed.starts_with('{') && trimmed.ends_with('}')) [INFO] [stdout] 37 ~ || (trimmed.starts_with('[') && trimmed.ends_with(']')) [INFO] [stdout] 38 ~ || (trimmed.starts_with('[') && trimmed.ends_with(']'))) [INFO] [stdout] 39 | { [INFO] [stdout] 40 ~ && serde_json::from_str::(trimmed).is_ok() { [INFO] [stdout] 41 | return MetricFormat::Json; [INFO] [stdout] 42 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/plots.rs:79:21 [INFO] [stdout] | [INFO] [stdout] 79 | metrics_by_ref: &[(String, IndexMap>)], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/plots.rs:91:31 [INFO] [stdout] | [INFO] [stdout] 91 | .and_then(|d| crate::metrics::parse_metric(d)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `crate::metrics::parse_metric` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/plots.rs:123:21 [INFO] [stdout] | [INFO] [stdout] 123 | metrics_by_ref: &[(String, IndexMap>)], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/plots.rs:389:31 [INFO] [stdout] | [INFO] [stdout] 389 | let tick_stride = (x_labels.len() + max_tick_labels - 1) / max_tick_labels; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `x_labels.len().div_ceil(max_tick_labels)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/e2e_metrics_formats.rs:1092:14 [INFO] [stdout] | [INFO] [stdout] 1092 | .get(&serde_yaml::Value::String("v2".to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `serde_yaml::Value::String("v2".to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3m 42s [INFO] running `Command { std: "docker" "inspect" "41c3bfd32748dcd8dbdb7f04e36afebf6ed9a134ab82d361362cb88baa0f651c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "41c3bfd32748dcd8dbdb7f04e36afebf6ed9a134ab82d361362cb88baa0f651c", kill_on_drop: false }` [INFO] [stdout] 41c3bfd32748dcd8dbdb7f04e36afebf6ed9a134ab82d361362cb88baa0f651c