[INFO] cloning repository https://github.com/BastRav/neutreeko [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/BastRav/neutreeko" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBastRav%2Fneutreeko", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBastRav%2Fneutreeko'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1f7d1495ac92b8556bbd9c7df60fb6d42b7fe0d5 [INFO] linting BastRav/neutreeko against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBastRav%2Fneutreeko" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/BastRav/neutreeko [INFO] finished tweaking git repo https://github.com/BastRav/neutreeko [INFO] tweaked toml for git repo https://github.com/BastRav/neutreeko written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/BastRav/neutreeko on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/BastRav/neutreeko already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tokise v0.2.0 [INFO] [stderr] Downloaded implicit-clone-derive v0.1.2 [INFO] [stderr] Downloaded implicit-clone v0.6.0 [INFO] [stderr] Downloaded cc v1.2.53 [INFO] [stderr] Downloaded no-std-compat v0.2.0 [INFO] [stderr] Downloaded atomic_float v1.1.0 [INFO] [stderr] Downloaded macerator-macros v0.1.3 [INFO] [stderr] Downloaded moddef v0.3.0 [INFO] [stderr] Downloaded wgpu-core-deps-emscripten v26.0.0 [INFO] [stderr] Downloaded macerator v0.2.9 [INFO] [stderr] Downloaded relative-path v1.9.3 [INFO] [stderr] Downloaded burn-ir v0.20.0 [INFO] [stderr] Downloaded burn-autodiff v0.20.0 [INFO] [stderr] Downloaded burn-dataset v0.20.0 [INFO] [stderr] Downloaded burn-ndarray v0.20.0 [INFO] [stderr] Downloaded burn-train v0.20.0 [INFO] [stderr] Downloaded burn-core v0.20.0 [INFO] [stderr] Downloaded cubecl-core v0.9.0 [INFO] [stderr] Downloaded burn-tensor v0.20.0 [INFO] [stderr] Downloaded wgpu v26.0.1 [INFO] [stderr] Downloaded burn-store v0.20.0 [INFO] [stderr] Downloaded time v0.3.45 [INFO] [stderr] Downloaded burn-nn v0.20.0 [INFO] [stderr] Downloaded lzma-rust2 v0.15.7 [INFO] [stderr] Downloaded wgpu-core v26.0.1 [INFO] [stderr] Downloaded cubecl-runtime v0.9.0 [INFO] [stderr] Downloaded burn-backend v0.20.0 [INFO] [stderr] Downloaded cubecl-cpp v0.9.0 [INFO] [stderr] Downloaded wgpu-hal v26.0.6 [INFO] [stderr] Downloaded wgpu-types v26.0.0 [INFO] [stderr] Downloaded cubecl-wgpu v0.9.0 [INFO] [stderr] Downloaded cubecl-common v0.9.0 [INFO] [stderr] Downloaded burn-std v0.20.0 [INFO] [stderr] Downloaded yew v0.22.0 [INFO] [stderr] Downloaded burn-optim v0.20.0 [INFO] [stderr] Downloaded rstest_macros v0.26.1 [INFO] [stderr] Downloaded burn v0.20.0 [INFO] [stderr] Downloaded cubecl-opt v0.9.0 [INFO] [stderr] Downloaded ppmd-rust v1.3.0 [INFO] [stderr] Downloaded typed-path v0.12.0 [INFO] [stderr] Downloaded rstest v0.26.1 [INFO] [stderr] Downloaded stable-vec v0.4.1 [INFO] [stderr] Downloaded cudarc v0.18.2 [INFO] [stderr] Downloaded cubecl-cuda v0.9.0 [INFO] [stderr] Downloaded cubecl-macros v0.9.0 [INFO] [stderr] Downloaded cubecl-ir v0.9.0 [INFO] [stderr] Downloaded cubecl v0.9.0 [INFO] [stderr] Downloaded textdistance v1.1.1 [INFO] [stderr] Downloaded time-macros v0.2.25 [INFO] [stderr] Downloaded yew-macro v0.22.0 [INFO] [stderr] Downloaded burn-derive v0.20.0 [INFO] [stderr] Downloaded naga v26.0.0 [INFO] [stderr] Downloaded float8 v0.4.2 [INFO] [stderr] Downloaded ordered-float v5.0.0 [INFO] [stderr] Downloaded float4 v0.1.0 [INFO] [stderr] Downloaded md5 v0.8.0 [INFO] [stderr] Downloaded wgpu-core-deps-windows-linux-android v26.0.0 [INFO] [stderr] Downloaded embassy-time v0.4.0 [INFO] [stderr] Downloaded derive-new v0.7.0 [INFO] [stderr] Downloaded cubecl-zspace v0.9.0 [INFO] [stderr] Downloaded cubecl-macros-internal v0.9.0 [INFO] [stderr] Downloaded wgpu-core-deps-apple v26.0.0 [INFO] [stderr] Downloaded embassy-futures v0.1.2 [INFO] [stderr] Downloaded embassy-time-driver v0.2.1 [INFO] [stderr] Downloaded time-core v0.1.7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f1122864132a6ed9876ddbb87ccef6815befbd2c3c182b11cdb99a84dee9605b [INFO] running `Command { std: "docker" "start" "-a" "f1122864132a6ed9876ddbb87ccef6815befbd2c3c182b11cdb99a84dee9605b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f1122864132a6ed9876ddbb87ccef6815befbd2c3c182b11cdb99a84dee9605b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f1122864132a6ed9876ddbb87ccef6815befbd2c3c182b11cdb99a84dee9605b", kill_on_drop: false }` [INFO] [stdout] f1122864132a6ed9876ddbb87ccef6815befbd2c3c182b11cdb99a84dee9605b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c0b820b17e740de5b8199c48b66280442cf88f6e99e831bef20e7076089cd53a [INFO] running `Command { std: "docker" "start" "-a" "c0b820b17e740de5b8199c48b66280442cf88f6e99e831bef20e7076089cd53a", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.105 [INFO] [stderr] Compiling quote v1.0.43 [INFO] [stderr] Compiling libm v0.2.15 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.106 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling zerocopy v0.8.33 [INFO] [stderr] Compiling bumpalo v3.19.1 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Compiling zmij v1.0.12 [INFO] [stderr] Checking foldhash v0.2.0 [INFO] [stderr] Compiling wasm-bindgen v0.2.106 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Compiling portable-atomic v1.13.0 [INFO] [stderr] Compiling object v0.37.3 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Checking gimli v0.32.3 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Compiling cubecl-common v0.9.0 [INFO] [stderr] Checking rustc-demangle v0.1.27 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Checking serde_bytes v0.11.19 [INFO] [stderr] Checking web-time v1.1.0 [INFO] [stderr] Checking embassy-futures v0.1.2 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking rand_core v0.9.5 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Compiling find-msvc-tools v0.1.8 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking csv-core v0.1.13 [INFO] [stderr] Checking zlib-rs v0.5.5 [INFO] [stderr] Checking dirs v6.0.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking csv v1.4.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking spin v0.10.0 [INFO] [stderr] Compiling winnow v0.7.14 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Checking rmp v0.8.15 [INFO] [stderr] Compiling rayon-core v1.13.0 [INFO] [stderr] Checking unty v0.0.4 [INFO] [stderr] Checking colored v3.1.1 [INFO] [stderr] Compiling matrixmultiply v0.3.10 [INFO] [stderr] Checking data-encoding v2.10.0 [INFO] [stderr] Checking time-core v0.1.7 [INFO] [stderr] Compiling toml_datetime v0.6.11 [INFO] [stderr] Checking uuid v1.19.0 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Compiling toml_datetime v0.7.5+spec-1.1.0 [INFO] [stderr] Checking time v0.3.45 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Checking thread-tree v0.3.3 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Compiling getrandom v0.2.16 [INFO] [stderr] Compiling rstest_macros v0.26.1 [INFO] [stderr] Compiling macerator v0.2.9 [INFO] [stderr] Compiling cc v1.2.53 [INFO] [stderr] Checking flate2 v1.1.8 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Checking addr2line v0.25.1 [INFO] [stderr] Checking tempfile v3.24.0 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Compiling burn-ndarray v0.20.0 [INFO] [stderr] Compiling glob v0.3.3 [INFO] [stderr] Checking moddef v0.3.0 [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Compiling prettyplease v0.2.37 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Checking crc v3.3.0 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling toml_parser v1.0.6+spec-1.1.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Compiling seq-macro v0.3.6 [INFO] [stderr] Checking libbz2-rs-sys v0.2.2 [INFO] [stderr] Checking atomic_float v1.1.0 [INFO] [stderr] Compiling toml_edit v0.23.10+spec-1.0.0 [INFO] [stderr] Checking lzma-rust2 v0.15.7 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking zopfli v0.8.3 [INFO] [stderr] Checking bzip2 v0.6.1 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking ppmd-rust v1.3.0 [INFO] [stderr] Compiling zstd-sys v2.0.16+zstd.1.5.7 [INFO] [stderr] Checking typed-path v0.12.0 [INFO] [stderr] Compiling proc-macro-crate v3.4.0 [INFO] [stderr] Checking deflate64 v0.1.10 [INFO] [stderr] Checking sanitize-filename v0.6.0 [INFO] [stderr] Checking memmap2 v0.9.9 [INFO] [stderr] Checking backtrace v0.3.76 [INFO] [stderr] Checking fixedbitset v0.5.7 [INFO] [stderr] Checking textdistance v1.1.1 [INFO] [stderr] Checking ndarray v0.17.2 [INFO] [stderr] Checking petgraph v0.8.3 [INFO] [stderr] Checking tokio-stream v0.1.18 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.106 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerocopy-derive v0.8.33 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling derive-new v0.7.0 [INFO] [stderr] Compiling derive_more-impl v2.1.1 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling strum_macros v0.27.2 [INFO] [stderr] Compiling burn-derive v0.20.0 [INFO] [stderr] Compiling pin-project-internal v1.1.10 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Compiling gloo-worker-macros v0.1.0 [INFO] [stderr] Compiling zeroize_derive v1.4.3 [INFO] [stderr] Checking tracing-appender v0.2.4 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Checking pin-project v1.1.10 [INFO] [stderr] Compiling implicit-clone-derive v0.1.2 [INFO] [stderr] Compiling yew-macro v0.22.0 [INFO] [stderr] Checking implicit-clone v0.6.0 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Checking derive_more v2.1.1 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking strum v0.27.2 [INFO] [stderr] Checking zip v7.2.0 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.106 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling macerator-macros v0.1.3 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking pinned v0.1.0 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking tokise v0.2.0 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking rmp-serde v1.3.1 [INFO] [stderr] Checking bincode v2.0.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking safetensors v0.7.0 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking js-sys v0.3.83 [INFO] [stderr] Checking console_error_panic_hook v0.1.7 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking rand_distr v0.5.1 [INFO] [stderr] Checking burn-dataset v0.20.0 [INFO] [stderr] Checking rstest v0.26.1 [INFO] [stderr] Checking burn-std v0.20.0 [INFO] [stderr] Checking burn-backend v0.20.0 [INFO] [stderr] Checking web-sys v0.3.83 [INFO] [stderr] Checking wasm-bindgen-futures v0.4.56 [INFO] [stderr] Checking serde-wasm-bindgen v0.6.5 [INFO] [stderr] Checking gloo-timers v0.3.0 [INFO] [stderr] Checking burn-tensor v0.20.0 [INFO] [stderr] Checking burn-autodiff v0.20.0 [INFO] [stderr] Checking burn-ir v0.20.0 [INFO] [stderr] Checking burn-core v0.20.0 [INFO] [stderr] Checking burn-nn v0.20.0 [INFO] [stderr] Checking burn-optim v0.20.0 [INFO] [stderr] Checking burn-train v0.20.0 [INFO] [stderr] Checking burn-store v0.20.0 [INFO] [stderr] Checking burn v0.20.0 [INFO] [stderr] Checking gloo-utils v0.2.0 [INFO] [stderr] Checking gloo-events v0.2.0 [INFO] [stderr] Checking gloo-dialogs v0.2.0 [INFO] [stderr] Checking gloo-render v0.2.0 [INFO] [stderr] Checking wasm-logger v0.2.0 [INFO] [stderr] Checking gloo-storage v0.3.0 [INFO] [stderr] Checking gloo-worker v0.5.0 [INFO] [stderr] Checking gloo-net v0.5.0 [INFO] [stderr] Checking gloo-console v0.3.0 [INFO] [stderr] Checking gloo-history v0.2.2 [INFO] [stderr] Checking gloo-file v0.3.0 [INFO] [stderr] Checking gloo v0.11.0 [INFO] [stderr] Checking yew v0.22.0 [INFO] [stderr] Checking neutreeko v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/ui.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | () [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ai/minmax.rs:24:28 [INFO] [stdout] | [INFO] [stdout] 24 | let mut a = Self { board: board, color: color, score: 0, depth: depth}; [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `board` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ai/minmax.rs:24:42 [INFO] [stdout] | [INFO] [stdout] 24 | let mut a = Self { board: board, color: color, score: 0, depth: depth}; [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ai/minmax.rs:24:66 [INFO] [stdout] | [INFO] [stdout] 24 | let mut a = Self { board: board, color: color, score: 0, depth: depth}; [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/ui.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | () [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ai/minmax.rs:24:28 [INFO] [stdout] | [INFO] [stdout] 24 | let mut a = Self { board: board, color: color, score: 0, depth: depth}; [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `board` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ai/minmax.rs:24:42 [INFO] [stdout] | [INFO] [stdout] 24 | let mut a = Self { board: board, color: color, score: 0, depth: depth}; [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ai/minmax.rs:24:66 [INFO] [stdout] | [INFO] [stdout] 24 | let mut a = Self { board: board, color: color, score: 0, depth: depth}; [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/logic.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | let resulting_direction; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `resulting_direction` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 87 ~ [INFO] [stdout] 88 ~ let resulting_direction = match &self { [INFO] [stdout] 89 ~ Direction::Up => &Direction::Right, [INFO] [stdout] 90 ~ Direction::UpRight => &Direction::DownRight, [INFO] [stdout] 91 ~ Direction::Right => &Direction::Down, [INFO] [stdout] 92 ~ Direction::DownRight => &Direction::DownLeft, [INFO] [stdout] 93 ~ Direction::Down => &Direction::Left, [INFO] [stdout] 94 ~ Direction::DownLeft => &Direction::UpLeft, [INFO] [stdout] 95 ~ Direction::Left => &Direction::Up, [INFO] [stdout] 96 ~ Direction::UpLeft => &Direction::UpRight, [INFO] [stdout] 97 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/logic.rs:128:36 [INFO] [stdout] | [INFO] [stdout] 128 | fn aligned_positions(positions_in: &Vec<&Position>) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 128 ~ fn aligned_positions(positions_in: &[&Position]) -> bool { [INFO] [stdout] 129 | if positions_in.len() != 3 { [INFO] [stdout] 130 | panic!("aligned_positions function requires exactly 3 positions"); [INFO] [stdout] 131 | } [INFO] [stdout] 132 ~ let mut positions = positions_in.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/logic.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | positions.sort_by(|a, b| a.row.cmp(&b.row)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 134 - positions.sort_by(|a, b| a.row.cmp(&b.row)); [INFO] [stdout] 134 + positions.sort_by_key(|a| a.row); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/logic.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 165 | / let mut pawns = Vec::new(); [INFO] [stdout] 166 | | pawns.push(Pawn::new(Color::Green, Position { row: 0, column: 1 })); [INFO] [stdout] 167 | | pawns.push(Pawn::new(Color::Green, Position { row: 0, column: 3 })); [INFO] [stdout] 168 | | pawns.push(Pawn::new(Color::Green, Position { row: 3, column: 2 })); [INFO] [stdout] 169 | | pawns.push(Pawn::new(Color::Yellow, Position { row: 1, column: 2 })); [INFO] [stdout] 170 | | pawns.push(Pawn::new(Color::Yellow, Position { row: 4, column: 1 })); [INFO] [stdout] 171 | | pawns.push(Pawn::new(Color::Yellow, Position { row: 4, column: 3 })); [INFO] [stdout] | |_____________________________________________________________________________^ help: consider using the `vec![]` macro: `let pawns = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/logic.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | / let mut pawns = Vec::new(); [INFO] [stdout] 179 | | pawns.push(Pawn::new(Color::Green, Position { row: P::random_int(5), column: P::random_int(5) })); [INFO] [stdout] 180 | | pawns.push(Pawn::new(Color::Green, Position { row: P::random_int(5), column: P::random_int(5) })); [INFO] [stdout] 181 | | pawns.push(Pawn::new(Color::Green, Position { row: P::random_int(5), column: P::random_int(5) })); [INFO] [stdout] 182 | | pawns.push(Pawn::new(Color::Yellow, Position { row: P::random_int(5), column: P::random_int(5) })); [INFO] [stdout] 183 | | pawns.push(Pawn::new(Color::Yellow, Position { row: P::random_int(5), column: P::random_int(5) })); [INFO] [stdout] 184 | | pawns.push(Pawn::new(Color::Yellow, Position { row: P::random_int(5), column: P::random_int(5) })); [INFO] [stdout] | |_______________________________________________________________________________________________________________^ help: consider using the `vec![]` macro: `let pawns = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/logic.rs:204:52 [INFO] [stdout] | [INFO] [stdout] 204 | let mut grid = vec![vec![". ".to_string(); self.number_of_columns as usize]; self.number_of_rows as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.number_of_columns` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/logic.rs:204:86 [INFO] [stdout] | [INFO] [stdout] 204 | let mut grid = vec![vec![". ".to_string(); self.number_of_columns as usize]; self.number_of_rows as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.number_of_rows` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/logic.rs:211:18 [INFO] [stdout] | [INFO] [stdout] 211 | grid[pawn.position.row as usize][pawn.position.column as usize] = symbol; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `{ pawn.position.row }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/logic.rs:211:46 [INFO] [stdout] | [INFO] [stdout] 211 | grid[pawn.position.row as usize][pawn.position.column as usize] = symbol; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pawn.position.column` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `aligned_positions` doesn't need a mutable reference [INFO] [stdout] --> src/logic.rs:256:30 [INFO] [stdout] | [INFO] [stdout] 256 | if aligned_positions(&mut green_positions) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 256 - if aligned_positions(&mut green_positions) { [INFO] [stdout] 256 + if aligned_positions(&green_positions) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `aligned_positions` doesn't need a mutable reference [INFO] [stdout] --> src/logic.rs:259:30 [INFO] [stdout] | [INFO] [stdout] 259 | if aligned_positions(&mut yellow_positions) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 259 - if aligned_positions(&mut yellow_positions) { [INFO] [stdout] 259 + if aligned_positions(&yellow_positions) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/logic.rs:334:32 [INFO] [stdout] | [INFO] [stdout] 334 | self.next_player = match &self.next_player { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 335 | | Some(color) => Some(color.other_color()), [INFO] [stdout] 336 | | None => None, [INFO] [stdout] 337 | | }; [INFO] [stdout] | |_____________^ help: try: `self.next_player.as_ref().map(|color| color.other_color())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MCTS` contains a capitalized acronym [INFO] [stdout] --> src/ui.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | MCTS(Color), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Mcts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/ui.rs:335:100 [INFO] [stdout] | [INFO] [stdout] 335 | fn render_direction_button(&self, ctx: &Context, direction: Direction, valid_directions: &Vec, symbol: &str) -... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 335 - fn render_direction_button(&self, ctx: &Context, direction: Direction, valid_directions: &Vec, symbol: &str) -> Html { [INFO] [stdout] 335 + fn render_direction_button(&self, ctx: &Context, direction: Direction, valid_directions: &[Direction], symbol: &str) -> Html { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/ai/mcts.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | self.untried_actions.len() == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.untried_actions.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/ai/ann/utils.rs:14:27 [INFO] [stdout] | [INFO] [stdout] 14 | input[0][channel][pawn.position.row as usize][pawn.position.column as usize] = 1.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pawn.position.row` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/ai/ann/utils.rs:14:55 [INFO] [stdout] | [INFO] [stdout] 14 | input[0][channel][pawn.position.row as usize][pawn.position.column as usize] = 1.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pawn.position.column` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/ai/ann/utils.rs:28:57 [INFO] [stdout] | [INFO] [stdout] 28 | let index = (direction.clone() as usize) * 25 + (pawn_position.row as usize) * 5 + pawn_position.column as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pawn_position.row` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/ai/ann/utils.rs:28:92 [INFO] [stdout] | [INFO] [stdout] 28 | let index = (direction.clone() as usize) * 25 + (pawn_position.row as usize) * 5 + pawn_position.column as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pawn_position.column` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/logic.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | let resulting_direction; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `resulting_direction` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 87 ~ [INFO] [stdout] 88 ~ let resulting_direction = match &self { [INFO] [stdout] 89 ~ Direction::Up => &Direction::Right, [INFO] [stdout] 90 ~ Direction::UpRight => &Direction::DownRight, [INFO] [stdout] 91 ~ Direction::Right => &Direction::Down, [INFO] [stdout] 92 ~ Direction::DownRight => &Direction::DownLeft, [INFO] [stdout] 93 ~ Direction::Down => &Direction::Left, [INFO] [stdout] 94 ~ Direction::DownLeft => &Direction::UpLeft, [INFO] [stdout] 95 ~ Direction::Left => &Direction::Up, [INFO] [stdout] 96 ~ Direction::UpLeft => &Direction::UpRight, [INFO] [stdout] 97 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/logic.rs:128:36 [INFO] [stdout] | [INFO] [stdout] 128 | fn aligned_positions(positions_in: &Vec<&Position>) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 128 ~ fn aligned_positions(positions_in: &[&Position]) -> bool { [INFO] [stdout] 129 | if positions_in.len() != 3 { [INFO] [stdout] 130 | panic!("aligned_positions function requires exactly 3 positions"); [INFO] [stdout] 131 | } [INFO] [stdout] 132 ~ let mut positions = positions_in.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/logic.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | positions.sort_by(|a, b| a.row.cmp(&b.row)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 134 - positions.sort_by(|a, b| a.row.cmp(&b.row)); [INFO] [stdout] 134 + positions.sort_by_key(|a| a.row); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/logic.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 165 | / let mut pawns = Vec::new(); [INFO] [stdout] 166 | | pawns.push(Pawn::new(Color::Green, Position { row: 0, column: 1 })); [INFO] [stdout] 167 | | pawns.push(Pawn::new(Color::Green, Position { row: 0, column: 3 })); [INFO] [stdout] 168 | | pawns.push(Pawn::new(Color::Green, Position { row: 3, column: 2 })); [INFO] [stdout] 169 | | pawns.push(Pawn::new(Color::Yellow, Position { row: 1, column: 2 })); [INFO] [stdout] 170 | | pawns.push(Pawn::new(Color::Yellow, Position { row: 4, column: 1 })); [INFO] [stdout] 171 | | pawns.push(Pawn::new(Color::Yellow, Position { row: 4, column: 3 })); [INFO] [stdout] | |_____________________________________________________________________________^ help: consider using the `vec![]` macro: `let pawns = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/logic.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | / let mut pawns = Vec::new(); [INFO] [stdout] 179 | | pawns.push(Pawn::new(Color::Green, Position { row: P::random_int(5), column: P::random_int(5) })); [INFO] [stdout] 180 | | pawns.push(Pawn::new(Color::Green, Position { row: P::random_int(5), column: P::random_int(5) })); [INFO] [stdout] 181 | | pawns.push(Pawn::new(Color::Green, Position { row: P::random_int(5), column: P::random_int(5) })); [INFO] [stdout] 182 | | pawns.push(Pawn::new(Color::Yellow, Position { row: P::random_int(5), column: P::random_int(5) })); [INFO] [stdout] 183 | | pawns.push(Pawn::new(Color::Yellow, Position { row: P::random_int(5), column: P::random_int(5) })); [INFO] [stdout] 184 | | pawns.push(Pawn::new(Color::Yellow, Position { row: P::random_int(5), column: P::random_int(5) })); [INFO] [stdout] | |_______________________________________________________________________________________________________________^ help: consider using the `vec![]` macro: `let pawns = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/logic.rs:204:52 [INFO] [stdout] | [INFO] [stdout] 204 | let mut grid = vec![vec![". ".to_string(); self.number_of_columns as usize]; self.number_of_rows as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.number_of_columns` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/logic.rs:204:86 [INFO] [stdout] | [INFO] [stdout] 204 | let mut grid = vec![vec![". ".to_string(); self.number_of_columns as usize]; self.number_of_rows as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.number_of_rows` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/logic.rs:211:18 [INFO] [stdout] | [INFO] [stdout] 211 | grid[pawn.position.row as usize][pawn.position.column as usize] = symbol; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `{ pawn.position.row }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/logic.rs:211:46 [INFO] [stdout] | [INFO] [stdout] 211 | grid[pawn.position.row as usize][pawn.position.column as usize] = symbol; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pawn.position.column` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/logic.rs:140:16 [INFO] [stdout] | [INFO] [stdout] 140 | let rows = vec![first_position.row as i8, second_position.row as i8, third_position.row as i8]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[first_position.row as i8, second_position.row as i8, third_position.row as i8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `aligned_positions` doesn't need a mutable reference [INFO] [stdout] --> src/logic.rs:256:30 [INFO] [stdout] | [INFO] [stdout] 256 | if aligned_positions(&mut green_positions) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 256 - if aligned_positions(&mut green_positions) { [INFO] [stdout] 256 + if aligned_positions(&green_positions) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `aligned_positions` doesn't need a mutable reference [INFO] [stdout] --> src/logic.rs:259:30 [INFO] [stdout] | [INFO] [stdout] 259 | if aligned_positions(&mut yellow_positions) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 259 - if aligned_positions(&mut yellow_positions) { [INFO] [stdout] 259 + if aligned_positions(&yellow_positions) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/logic.rs:334:32 [INFO] [stdout] | [INFO] [stdout] 334 | self.next_player = match &self.next_player { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 335 | | Some(color) => Some(color.other_color()), [INFO] [stdout] 336 | | None => None, [INFO] [stdout] 337 | | }; [INFO] [stdout] | |_____________^ help: try: `self.next_player.as_ref().map(|color| color.other_color())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MCTS` contains a capitalized acronym [INFO] [stdout] --> src/ui.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | MCTS(Color), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Mcts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/ui.rs:335:100 [INFO] [stdout] | [INFO] [stdout] 335 | fn render_direction_button(&self, ctx: &Context, direction: Direction, valid_directions: &Vec, symbol: &str) -... [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 335 - fn render_direction_button(&self, ctx: &Context, direction: Direction, valid_directions: &Vec, symbol: &str) -> Html { [INFO] [stdout] 335 + fn render_direction_button(&self, ctx: &Context, direction: Direction, valid_directions: &[Direction], symbol: &str) -> Html { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/ai/mcts.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | self.untried_actions.len() == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.untried_actions.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/ai/ann/utils.rs:14:27 [INFO] [stdout] | [INFO] [stdout] 14 | input[0][channel][pawn.position.row as usize][pawn.position.column as usize] = 1.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pawn.position.row` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/ai/ann/utils.rs:14:55 [INFO] [stdout] | [INFO] [stdout] 14 | input[0][channel][pawn.position.row as usize][pawn.position.column as usize] = 1.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pawn.position.column` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/ai/ann/utils.rs:28:57 [INFO] [stdout] | [INFO] [stdout] 28 | let index = (direction.clone() as usize) * 25 + (pawn_position.row as usize) * 5 + pawn_position.column as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pawn_position.row` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/ai/ann/utils.rs:28:92 [INFO] [stdout] | [INFO] [stdout] 28 | let index = (direction.clone() as usize) * 25 + (pawn_position.row as usize) * 5 + pawn_position.column as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pawn_position.column` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/logic.rs:140:16 [INFO] [stdout] | [INFO] [stdout] 140 | let rows = vec![first_position.row as i8, second_position.row as i8, third_position.row as i8]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[first_position.row as i8, second_position.row as i8, third_position.row as i8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 30s [INFO] running `Command { std: "docker" "inspect" "c0b820b17e740de5b8199c48b66280442cf88f6e99e831bef20e7076089cd53a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c0b820b17e740de5b8199c48b66280442cf88f6e99e831bef20e7076089cd53a", kill_on_drop: false }` [INFO] [stdout] c0b820b17e740de5b8199c48b66280442cf88f6e99e831bef20e7076089cd53a